[Compass-ci] Re: [PATCH v4 compass-ci] /lib: keep suite result in top for compare output

On Mon, Nov 16, 2020 at 10:49:22AM +0800, Lu Kaiyi wrote:

On Mon, Nov 16, 2020 at 10:14:19AM +0800, Zhang Yuhang wrote:

...

On Sat, Nov 14, 2020 at 10:42:59AM +0800, Lu Kaiyi wrote:

good!

btw, maybe it's more efficient to keep judgement of value.size on inner top of 'groups.each ...', like below:

suites_list = [] groups.each do |group_key, value| if value.size < 2 groups.delete[group_key] next end suite_list = [] value.each do |dimension_key, jobs| groups[group_key][dimension_key], suites = create_matrix(jobs) suite_list.concat(suites) end suites_list << suite_list end

Thanks, Kaiyi

Yes. You are right.

Thanks, Zhang Yuhang