Function set_pp_initrd() is confusing, since what it does is to set depends, so change function name to set_depends_initrd.
Signed-off-by: Xu Xijian xuxijian@huawei.com --- src/lib/job.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 20afa65..1e44d15 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -133,7 +133,7 @@ class Job set_result_root() set_result_service() set_os_mount() - set_pp_initrd() + set_depends_initrd() set_initrds_uri() set_kernel_uri() set_kernel_append_root() @@ -391,7 +391,7 @@ class Job self["user_lkp_src"] = Jobfile::Operate.prepare_lkp_tests(lkp_initrd_user, os_arch) end
- private def set_pp_initrd + private def set_depends_initrd initrd_deps_arr = Array(String).new initrd_pkg_arr = Array(String).new initrd_http_prefix = "http://#%7BINITRD_HTTP_HOST%7D:#%7BINITRD_HTTP_PORT%7D"
On Fri, Oct 16, 2020 at 05:29:18PM +0800, Xu Xijian wrote:
Function set_pp_initrd() is confusing, since what it does is to set depends, so change function name to set_depends_initrd.
"pp" is come from the lkp-tests domain. job has an "pp" field. it seems to be a "domain name". advice to "make clear" at lkp-tests first.
can add a comment at scheduler.
Signed-off-by: Xu Xijian xuxijian@huawei.com
src/lib/job.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 20afa65..1e44d15 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -133,7 +133,7 @@ class Job set_result_root() set_result_service() set_os_mount()
- set_pp_initrd()
- set_depends_initrd() set_initrds_uri() set_kernel_uri() set_kernel_append_root()
@@ -391,7 +391,7 @@ class Job self["user_lkp_src"] = Jobfile::Operate.prepare_lkp_tests(lkp_initrd_user, os_arch) end
- private def set_pp_initrd
- private def set_depends_initrd initrd_deps_arr = Array(String).new initrd_pkg_arr = Array(String).new initrd_http_prefix = "http://#%7BINITRD_HTTP_HOST%7D:#%7BINITRD_HTTP_PORT%7D"
-- 2.23.0
On Mon, Oct 19, 2020 at 08:59:38AM +0800, Tong Qunfeng wrote:
On Fri, Oct 16, 2020 at 05:29:18PM +0800, Xu Xijian wrote:
Function set_pp_initrd() is confusing, since what it does is to set depends, so change function name to set_depends_initrd.
"pp" is come from the lkp-tests domain. job has an "pp" field. it seems to be a "domain name". advice to "make clear" at lkp-tests first.
can add a comment at scheduler.
Do you mean add a comment for function set_pp_initrd()?
Thanks, Xijian
On Mon, Oct 19, 2020 at 08:59:38AM +0800, Tong Qunfeng wrote:
On Fri, Oct 16, 2020 at 05:29:18PM +0800, Xu Xijian wrote:
Function set_pp_initrd() is confusing, since what it does is to set depends, so change function name to set_depends_initrd.
"pp" is come from the lkp-tests domain. job has an "pp" field. it seems to be a "domain name". advice to "make clear" at lkp-tests first.
can add a comment at scheduler.
After consideration, I think whatever "pp" means, here "pp" is just a data source, what this function does is to set depends, function name should be related with what it does, So when someone roughly read this code, he won't be entangled in "pp". And making clear at lkp-tests is also necessary too.
Thanks, Xijian
Signed-off-by: Xu Xijian xuxijian@huawei.com
src/lib/job.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 20afa65..1e44d15 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -133,7 +133,7 @@ class Job set_result_root() set_result_service() set_os_mount()
- set_pp_initrd()
- set_depends_initrd() set_initrds_uri() set_kernel_uri() set_kernel_append_root()
@@ -391,7 +391,7 @@ class Job self["user_lkp_src"] = Jobfile::Operate.prepare_lkp_tests(lkp_initrd_user, os_arch) end
- private def set_pp_initrd
- private def set_depends_initrd initrd_deps_arr = Array(String).new initrd_pkg_arr = Array(String).new initrd_http_prefix = "http://#%7BINITRD_HTTP_HOST%7D:#%7BINITRD_HTTP_PORT%7D"
-- 2.23.0
-- Thanks. chief tongqunfeng@huawei.com
On Mon, Oct 19, 2020 at 03:54:03PM +0800, Xu Xijian wrote:
On Mon, Oct 19, 2020 at 08:59:38AM +0800, Tong Qunfeng wrote:
On Fri, Oct 16, 2020 at 05:29:18PM +0800, Xu Xijian wrote:
Function set_pp_initrd() is confusing, since what it does is to set depends, so change function name to set_depends_initrd.
"pp" is come from the lkp-tests domain. job has an "pp" field. it seems to be a "domain name". advice to "make clear" at lkp-tests first.
can add a comment at scheduler.
After consideration, I think whatever "pp" means, here "pp" is just a data source, what this function does is to set depends, function name should be related with what it does, So when someone roughly read this code, he won't be entangled in "pp". And making clear at lkp-tests is also necessary too.
1.make clear pp concept at lkp-tests first (program params?) 2.if "pp" is a domain name, then scheduler can directory use it (maybe add some comment). if it is not a domain name, then change it.
Thanks, Xijian
Signed-off-by: Xu Xijian xuxijian@huawei.com
src/lib/job.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 20afa65..1e44d15 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -133,7 +133,7 @@ class Job set_result_root() set_result_service() set_os_mount()
- set_pp_initrd()
- set_depends_initrd() set_initrds_uri() set_kernel_uri() set_kernel_append_root()
@@ -391,7 +391,7 @@ class Job self["user_lkp_src"] = Jobfile::Operate.prepare_lkp_tests(lkp_initrd_user, os_arch) end
- private def set_pp_initrd
- private def set_depends_initrd initrd_deps_arr = Array(String).new initrd_pkg_arr = Array(String).new initrd_http_prefix = "http://#%7BINITRD_HTTP_HOST%7D:#%7BINITRD_HTTP_PORT%7D"
-- 2.23.0
-- Thanks. chief tongqunfeng@huawei.com
On Mon, Oct 19, 2020 at 03:58:33PM +0800, Tong Qunfeng wrote:
On Mon, Oct 19, 2020 at 03:54:03PM +0800, Xu Xijian wrote:
On Mon, Oct 19, 2020 at 08:59:38AM +0800, Tong Qunfeng wrote:
On Fri, Oct 16, 2020 at 05:29:18PM +0800, Xu Xijian wrote:
Function set_pp_initrd() is confusing, since what it does is to set depends, so change function name to set_depends_initrd.
"pp" is come from the lkp-tests domain. job has an "pp" field. it seems to be a "domain name". advice to "make clear" at lkp-tests first.
can add a comment at scheduler.
After consideration, I think whatever "pp" means, here "pp" is just a data source, what this function does is to set depends, function name should be related with what it does, So when someone roughly read this code, he won't be entangled in "pp". And making clear at lkp-tests is also necessary too.
1.make clear pp concept at lkp-tests first (program params?)
pp = program params.
The function just tested some fields under pp for add depends cgz. So Xijian is right, let's rename the function to match its purpose. pp.* is merely a test condition here.
Thanks, Fengguang
2.if "pp" is a domain name, then scheduler can directory use it (maybe add some comment). if it is not a domain name, then change it.
Thanks, Xijian
Signed-off-by: Xu Xijian xuxijian@huawei.com
src/lib/job.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 20afa65..1e44d15 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -133,7 +133,7 @@ class Job set_result_root() set_result_service() set_os_mount()
- set_pp_initrd()
- set_depends_initrd() set_initrds_uri() set_kernel_uri() set_kernel_append_root()
@@ -391,7 +391,7 @@ class Job self["user_lkp_src"] = Jobfile::Operate.prepare_lkp_tests(lkp_initrd_user, os_arch) end
- private def set_pp_initrd
- private def set_depends_initrd initrd_deps_arr = Array(String).new initrd_pkg_arr = Array(String).new initrd_http_prefix = "http://#%7BINITRD_HTTP_HOST%7D:#%7BINITRD_HTTP_PORT%7D"
-- 2.23.0
-- Thanks. chief tongqunfeng@huawei.com
-- Thanks. chief tongqunfeng@huawei.com
-
Tong Qunfeng -
Wu Fengguang -
Xu Xijian