'dailybuild' is closer to logic than 'debug'.
Signed-off-by: Yu Chuan 13186087857@163.com --- tests/iso2rootfs | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/tests/iso2rootfs b/tests/iso2rootfs index 7ab4a08b0d60..524ab6695f93 100755 --- a/tests/iso2rootfs +++ b/tests/iso2rootfs @@ -72,7 +72,7 @@ get_daily_iso_checksum()
mount_rootfs() { - DEBUG_ROOTFS_DIR="debug-versions/dailybuild" + DAILYBUILD_ROOTFS_DIR="debug-versions/dailybuild" case ${rootfs_protocol} in "nfs") ROOTFS_SERVER_PATH="${rootfs_server}:${rootfs_path}/${iso_os}/${iso_arch}" @@ -103,7 +103,7 @@ get_cache_iso_checksum() { mount_rootfs
- CHECKSUM_FILE_CACHE="${ROOTFS_LOCAL_PATH}/${DEBUG_ROOTFS_DIR}/${iso_version}-newest.sha256sum" + CHECKSUM_FILE_CACHE="${ROOTFS_LOCAL_PATH}/${DAILYBUILD_ROOTFS_DIR}/${iso_version}-newest.sha256sum" [ ! -f "${CHECKSUM_FILE_CACHE}" ] || SHA256SUM_CACHE=$(awk '{print $1}' "$CHECKSUM_FILE_CACHE") } @@ -255,7 +255,7 @@ download_compass_ci()
config_rootfs_dir() { - ROOTFS_DES_DIR=${ROOTFS_LOCAL_PATH}/${DEBUG_ROOTFS_DIR}/${iso_version}-$(date "+%Y%m%d%H%M%S") + ROOTFS_DES_DIR=${ROOTFS_LOCAL_PATH}/${DAILYBUILD_ROOTFS_DIR}/${iso_version}-$(date "+%Y%m%d%H%M%S") [ -d "${ROOTFS_DES_DIR}" ] && ROOTFS_DES_DIR="${ROOTFS_DES_DIR}-${HOSTNAME##*--}" mkdir -p "$ROOTFS_DES_DIR" @@ -310,10 +310,10 @@ test_rootfs() local root_path case ${rootfs_protocol} in "nfs") - root_path="${ROOTFS_SERVER_PATH}/${DEBUG_ROOTFS_DIR}/$(basename "${ROOTFS_DES_DIR}")" + root_path="${ROOTFS_SERVER_PATH}/${DAILYBUILD_ROOTFS_DIR}/$(basename "${ROOTFS_DES_DIR}")" ;; "cifs") - root_path="cifs:${ROOTFS_SERVER_PATH}/${DEBUG_ROOTFS_DIR}/$(basename "${ROOTFS_DES_DIR}"),${ROOTFS_MOUNT_PARAM}" + root_path="cifs:${ROOTFS_SERVER_PATH}/${DAILYBUILD_ROOTFS_DIR}/$(basename "${ROOTFS_DES_DIR}"),${ROOTFS_MOUNT_PARAM}" ;; *) die "rootfs_protocol is none, exit !!!" @@ -363,10 +363,11 @@ post_works()
mv "${CHECKSUM_FILE_CACHE}.tmp" "${CHECKSUM_FILE_CACHE}"
+ local soft_link="${iso_version}-dailybuild" cd "${ROOTFS_LOCAL_PATH}" && - rm -f "${iso_version}-debug" && - ln -s "${DEBUG_ROOTFS_DIR}/$(basename ${ROOTFS_DES_DIR})" \ - "${iso_version}-debug" + rm -f "${soft_link}" && + ln -s "${DAILYBUILD_ROOTFS_DIR}/$(basename ${ROOTFS_DES_DIR})" \ + "${soft_link}"
cd / && umount "${ROOTFS_LOCAL_PATH}"
wfg@z9 /srv/os/openeuler/aarch64/debug-versions/dailybuild% ll total 64K drwxr-xr-x 18 root root 4.0K 2020-09-05 19:43 20.03-20200905193523 drwxr-xr-x 18 root root 4.0K 2020-09-07 16:15 20.03-20200907160616 drwxr-xr-x 18 root root 4.0K 2020-09-24 00:28 20.03-20200924000826
Should we remove the debug-versions/dailybuild dir? I suspect it'll create problem in some other places due to not consistent with the typical dir layout.
Also the name "20.03-20200907160616" might be improved to "20.03.2020-09-07" where the date is another level of version.
Thanks, Fengguang
On Fri, Oct 16, 2020 at 10:40:41AM +0800, Wu Fengguang wrote:
wfg@z9 /srv/os/openeuler/aarch64/debug-versions/dailybuild% ll total 64K drwxr-xr-x 18 root root 4.0K 2020-09-05 19:43 20.03-20200905193523 drwxr-xr-x 18 root root 4.0K 2020-09-07 16:15 20.03-20200907160616 drwxr-xr-x 18 root root 4.0K 2020-09-24 00:28 20.03-20200924000826
Should we remove the debug-versions/dailybuild dir? I suspect it'll create problem in some other places due to not consistent with the typical dir layout.
ok, we've already modify the dir layout.
Also the name "20.03-20200907160616" might be improved to "20.03.2020-09-07" where the date is another level of version.
ok, i'll modify the code.
-------- Thanks Yu Chuan
Thanks, Fengguang