[why] compare tool support output result with json | html format, but haven't corresponding direction in help message. [how] add the corresponding direction in --theme option [example] compare id=crystal.109482 id=crystal.109483 --theme json
Signed-off-by: Lu Weitao luweitaobe@163.com --- sbin/compare | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sbin/compare b/sbin/compare index b13682e..baa90d4 100755 --- a/sbin/compare +++ b/sbin/compare @@ -12,7 +12,7 @@ # compare "commit=a12d232e" "commit=b3bacc31" # compare "os=debian" "os=centos" -c "suite=iperf" # compare "os=centos" -d "os_version os_arch" -# compare "os=centos" -d "os_version os_arch" --color "classic" +# compare "os=centos" -d "os_version os_arch" --theme "classic"
require 'optparse' require_relative '../lib/compare.rb' @@ -42,9 +42,9 @@ opt_parser = OptionParser.new do |opts| is_group = true end
- opts.on('--color color', 'turn on colorful display with theme: classic|focus_good|focus_bad', - '|striking|light|none') do |color| - colorful = color + opts.on('--theme theme', 'turn on colorful display with theme: classic|focus_good|focus_bad', + '|striking|light|json|html') do |theme| + colorful = theme end
opts.on('-t', '--template template', 'compare with user-defined template') do |t|
On Wed, Nov 11, 2020 at 02:25:59PM +0800, Lu Weitao wrote:
[why] compare tool support output result with json | html format, but haven't corresponding direction in help message.
haven't => have no / don't have
What does corresponding direction mean? Do you mean guide?
Thanks, Yuanchao
On Wed, Nov 11, 2020 at 03:55:39PM +0800, Li Yuanchao wrote:
On Wed, Nov 11, 2020 at 02:25:59PM +0800, Lu Weitao wrote:
[why] compare tool support output result with json | html format, but haven't corresponding direction in help message.
haven't => have no / don't have
ok
What does corresponding direction mean? Do you mean guide?
想表达,--theme(old options: --color) 的help msg漏掉了json | html
Thanks, Weitao
Thanks, Yuanchao