[why] tests need some common softwares which at lkp-tests/distro/depend/lkp. initramfs-common just for initramfs os, it is not enough.
Signed-off-by: Wei Jihui weijihuiall@163.com --- src/lib/job.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 07bfda0..ae1f170 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -556,7 +556,7 @@ class Job private def get_depends_initrd(program_params, initrd_deps_arr, initrd_pkg_arr) initrd_http_prefix = "http://#%7BINITRD_HTTP_HOST%7D:#%7BINITRD_HTTP_PORT%7D" mount_type = os_mount == "cifs" ? "nfs" : os_mount.dup - program_params["initramfs-common"] = JSON::Any.new("") if os_mount == "initramfs" + program_params["lkp"] = JSON::Any.new("")
program_params.keys.each do |program| if program =~ /^(.*)-\d+$/
Please add the below comments.
Note that the 'lkp' depends should best be pre-installed in each rootfs. So in theory (if that step is well done) only docker image need this, since we cannot modify 3rd party docker image. However to be robust, we can always include this.
On Mon, Jan 18, 2021 at 10:33:49AM +0800, Wei Jihui wrote:
[why] tests need some common softwares which at lkp-tests/distro/depend/lkp. initramfs-common just for initramfs os, it is not enough.
Signed-off-by: Wei Jihui weijihuiall@163.com
src/lib/job.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/job.cr b/src/lib/job.cr index 07bfda0..ae1f170 100644 --- a/src/lib/job.cr +++ b/src/lib/job.cr @@ -556,7 +556,7 @@ class Job private def get_depends_initrd(program_params, initrd_deps_arr, initrd_pkg_arr) initrd_http_prefix = "http://#%7BINITRD_HTTP_HOST%7D:#%7BINITRD_HTTP_PORT%7D" mount_type = os_mount == "cifs" ? "nfs" : os_mount.dup
- program_params["initramfs-common"] = JSON::Any.new("") if os_mount == "initramfs"
program_params["lkp"] = JSON::Any.new("")
program_params.keys.each do |program| if program =~ /^(.*)-\d+$/
-- 2.23.0
-
Wei Jihui -
Wu Fengguang