On Wed, Mar 31, 2021 at 11:34:03AM +0800, Liu Shaofei wrote:

On Wed, Mar 31, 2021 at 11:09:56AM +0800, Xu Xijian wrote:

...

Signed-off-by: Xu Xijian hdxuxijian@163.com

src/scheduler/kernel_params.cr | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/scheduler/kernel_params.cr b/src/scheduler/kernel_params.cr index 8ad5029..9e2f58b 100644 --- a/src/scheduler/kernel_params.cr +++ b/src/scheduler/kernel_params.cr @@ -9,7 +9,8 @@ class Job os_info = "#{os}_#{os_arch}_#{os_version}" use_root_partition = "/dev/mapper/os-#{os_info}_#{src_lv_suffix}" if @hash["src_lv_suffix"]? != nil save_root_partition = "/dev/mapper/os-#{os_info}_#{boot_lv_suffix}" if @hash["boot_lv_suffix"]? != nil

• return "#{common_params} local use_root_partition=#{use_root_partition} save_root_partition=#{save_root_partition} rw"

• pv_device = "#{self.pv_device}" if @hash["pv_device"]? != nil

 if ... != nil   => unless

 Thanks,
 Liushaofei

I don't think it's necessary, just 2 kinds of format. Other scripts have both these 2 kinds of format too. And here can keep the same with upon code.

-------- Thanks, Xijian