Signed-off-by: Liu Yinsi liuyinsi@163.com --- container/initrd-cifs/start | 4 ++-- container/os-cifs/start | 4 ++-- container/os-nfs/start | 4 ++-- container/result-cifs/start | 4 ++-- providers/my-qemu.sh | 4 +--- providers/qemu/kvm.sh | 3 +-- providers/qemu/pxe.sh | 4 +--- sparrow/4-docker/buildall | 8 ++++---- 8 files changed, 15 insertions(+), 20 deletions(-)
diff --git a/container/initrd-cifs/start b/container/initrd-cifs/start index 119d1b1..6a91b37 100755 --- a/container/initrd-cifs/start +++ b/container/initrd-cifs/start @@ -3,10 +3,10 @@ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.
. $CCI_SRC/container/defconfig.sh -. $LKP_SRC/lib/log.sh +. $CCI_SRC/lib/log.sh
lsmod | grep -q "^cifs\s" || { - log_error "[ERROR] kernel module cifs is missing (try: sudo modprobe cifs)" + log_error "kernel module cifs is missing (try: sudo modprobe cifs)" exit 1 }
diff --git a/container/os-cifs/start b/container/os-cifs/start index 47da260..85017cc 100755 --- a/container/os-cifs/start +++ b/container/os-cifs/start @@ -3,10 +3,10 @@ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.
. $CCI_SRC/container/defconfig.sh -. $LKP_SRC/lib/log.sh +. $CCI_SRC/lib/log.sh
lsmod | grep -q "^cifs\s" || { - log_error "[ERROR] kernel module cifs is missing (try: sudo modprobe cifs)" + log_error "kernel module cifs is missing (try: sudo modprobe cifs)" exit 1 }
diff --git a/container/os-nfs/start b/container/os-nfs/start index 8c08db8..7577647 100755 --- a/container/os-nfs/start +++ b/container/os-nfs/start @@ -3,10 +3,10 @@ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.
. $CCI_SRC/container/defconfig.sh -. $LKP_SRC/lib/log.sh +. $CCI_SRC/lib/log.sh
lsmod | grep -q "^nfs\s" || { - log_error "[ERROR] kernel module nfs is missing (try: sudo modprobe nfs)" + log_error "kernel module nfs is missing (try: sudo modprobe nfs)" exit 1 } lsmod | grep -q "^nfsd\s" || { diff --git a/container/result-cifs/start b/container/result-cifs/start index 4f8c2b9..7ce066a 100755 --- a/container/result-cifs/start +++ b/container/result-cifs/start @@ -3,10 +3,10 @@ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.
. $CCI_SRC/container/defconfig.sh -. $LKP_SRC/lib/log.sh +. $CCI_SRC/lib/log.sh
lsmod | grep -q "^cifs\s" || { - log_error "[ERROR] kernel module cifs is missing (try: sudo modprobe cifs)" + log_error "kernel module cifs is missing (try: sudo modprobe cifs)" exit 1 }
diff --git a/providers/my-qemu.sh b/providers/my-qemu.sh index 113b3ef..3e3b2f4 100755 --- a/providers/my-qemu.sh +++ b/providers/my-qemu.sh @@ -2,9 +2,7 @@ # SPDX-License-Identifier: MulanPSL-2.0+ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.
-: ${LKP_SRC:="/c/lkp-tests"} - -source ${LKP_SRC}/lib/log.sh +source ${CCI_SRC}/lib/log.sh
help() { diff --git a/providers/qemu/kvm.sh b/providers/qemu/kvm.sh index 66099ee..d394681 100755 --- a/providers/qemu/kvm.sh +++ b/providers/qemu/kvm.sh @@ -6,9 +6,8 @@
: ${nr_cpu:=1} : ${memory:=1G} -: ${LKP_SRC:="/c/lkp-tests"}
-source ${LKP_SRC}/lib/log.sh +source ${CCI_SRC}/lib/log.sh
check_logfile() { diff --git a/providers/qemu/pxe.sh b/providers/qemu/pxe.sh index 0ba052c..3ab3c2b 100755 --- a/providers/qemu/pxe.sh +++ b/providers/qemu/pxe.sh @@ -4,9 +4,7 @@ # - nr_cpu # - memory
-: ${LKP_SRC:="/c/lkp-tests"} - -source ${LKP_SRC}/lib/log.sh +source ${CCI_SRC}/lib/log.sh
: ${nr_cpu:=1} : ${memory:=1G} diff --git a/sparrow/4-docker/buildall b/sparrow/4-docker/buildall index a60067f..9d6c977 100755 --- a/sparrow/4-docker/buildall +++ b/sparrow/4-docker/buildall @@ -2,11 +2,11 @@ # SPDX-License-Identifier: MulanPSL-2.0+ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.
+source ${CCI_SRC}/lib/log.sh + CONTAINER_PATH="$CCI_SRC/container" export action=$1
-[ -n "$LKP_SRC" ] && source "${LKP_SRC}/lib/log.sh" - build_depends() { local container=$1 @@ -27,7 +27,7 @@ do_one() lockfile-create -q --use-pid --retry 100 --lock-name "$container_name".lock echo "$started_containers" | grep -w -q "$container_name" && return 0
- [ -n "$LKP_SRC" ] && log_info "start build $container." + log_info "start build $container." mkdir $tmpdir/$container_name 2>/dev/null && ( cd "$container" @@ -40,7 +40,7 @@ do_one() [ -x first-run ] && ./first-run [ -x start ] && ./start ) - [ -n "$LKP_SRC" ] && log_info "finish build $container." + log_info "finish build $container." started_containers+="$container_name" lockfile-remove --lock-name "$container_name".lock }
On Thu, Jan 28, 2021 at 06:31:46PM +0800, Liu Yinsi wrote:
Signed-off-by: Liu Yinsi liuyinsi@163.com
container/initrd-cifs/start | 4 ++-- container/os-cifs/start | 4 ++-- container/os-nfs/start | 4 ++-- container/result-cifs/start | 4 ++-- providers/my-qemu.sh | 4 +--- providers/qemu/kvm.sh | 3 +-- providers/qemu/pxe.sh | 4 +--- sparrow/4-docker/buildall | 8 ++++---- 8 files changed, 15 insertions(+), 20 deletions(-)
diff --git a/container/initrd-cifs/start b/container/initrd-cifs/start index 119d1b1..6a91b37 100755 --- a/container/initrd-cifs/start +++ b/container/initrd-cifs/start @@ -3,10 +3,10 @@ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.
. $CCI_SRC/container/defconfig.sh -. $LKP_SRC/lib/log.sh +. $CCI_SRC/lib/log.sh
lsmod | grep -q "^cifs\s" || {
- log_error "[ERROR] kernel module cifs is missing (try: sudo modprobe cifs)"
- log_error "kernel module cifs is missing (try: sudo modprobe cifs)"
You delete '[ERROR]', why delete it? Do you want to say "it's a warning"? Then you change change '[ERROR]' to '[WARNING]'.
Thanks, Yuanchao
On Fri, Jan 29, 2021 at 10:10:59AM +0800, Li Yuanchao wrote:
On Thu, Jan 28, 2021 at 06:31:46PM +0800, Liu Yinsi wrote:
Signed-off-by: Liu Yinsi liuyinsi@163.com
+. $CCI_SRC/lib/log.sh
lsmod | grep -q "^cifs\s" || {
- log_error "[ERROR] kernel module cifs is missing (try: sudo modprobe cifs)"
- log_error "kernel module cifs is missing (try: sudo modprobe cifs)"
You delete '[ERROR]', why delete it? Do you want to say "it's a warning"? Then you change change '[ERROR]' to '[WARNING]'.
$CCI_SRC/lib/log.sh: log_error() { date +"[ERROR] ..." }
log_error have "[ERROR]", so no need to write again when call log_error().
Thanks, Yinsi
Thanks, Yuanchao
On Fri, Jan 29, 2021 at 10:26:57AM +0800, Liu Yinsi wrote:
On Fri, Jan 29, 2021 at 10:10:59AM +0800, Li Yuanchao wrote:
On Thu, Jan 28, 2021 at 06:31:46PM +0800, Liu Yinsi wrote:
Signed-off-by: Liu Yinsi liuyinsi@163.com
+. $CCI_SRC/lib/log.sh
lsmod | grep -q "^cifs\s" || {
- log_error "[ERROR] kernel module cifs is missing (try: sudo modprobe cifs)"
- log_error "kernel module cifs is missing (try: sudo modprobe cifs)"
You delete '[ERROR]', why delete it? Do you want to say "it's a warning"? Then you change change '[ERROR]' to '[WARNING]'.
$CCI_SRC/lib/log.sh: log_error() { date +"[ERROR] ..." }
log_error have "[ERROR]", so no need to write again when call log_error().
I got it. This reason should be an [why] in your change log.
Thanks, Yuanchao
- log_error "kernel module cifs is missing (try: sudo modprobe cifs)"
You delete '[ERROR]', why delete it? Do you want to say "it's a warning"? Then you change change '[ERROR]' to '[WARNING]'.
$CCI_SRC/lib/log.sh: log_error() { date +"[ERROR] ..." }
log_error have "[ERROR]", so no need to write again when call log_error().
I got it. This reason should be an [why] in your change log.
ok
Thanks, Yinsi
Thanks, Yuanchao