On Wed, Nov 04, 2020 at 09:35:35AM +0800, Lu Kaiyi wrote:

[why] iozone-bs.yaml has combined multiple parameter to single, so, iozone tool also need change the way of parsing parameter. [how] modify the way of parsing parameter.

Signed-off-by: Lu Kaiyi 2392863668@qq.com

tests/iozone | 65 ++++++++++++++++++++++++++++++---------------------- 1 file changed, 37 insertions(+), 28 deletions(-)

diff --git a/tests/iozone b/tests/iozone index 88a92a18..b85bc4a9 100755 --- a/tests/iozone +++ b/tests/iozone @@ -1,42 +1,51 @@ #!/bin/sh # - block_size # - file_size -# - write_rewrite -# - read_reread -# - random_read_write -# - read_backwards -# - rewrite_record -# - stride_read -# - fwrite_refwrite -# - fread_refread -# - random_mix -# - pwrite_repwrite -# - pread_repread -# - pwritev_repwritev -# - preadv_repreadv +# - test ## IOzone is a filesystem benchmark tool. The benchmark generates ## and measures a variety of file operations.

. $LKP_SRC/lib/reproduce-log.sh

args="iozone" if [ -n "$block_size" ]; then args+=" -r $block_size"

• [ -n "$file_size" ] && args+=" -s $file_size"
• [ -n "$write_rewrite" ] && args+=" -i 0"
• [ -n "$read_reread" ] && args+=" -i 1"
• [ -n "$random_read_write" ] && args+=" -i 2"
• [ -n "$read_backwards" ] && args+=" -i 3"
• [ -n "$rewrite_record" ] && args+=" -i 4"
• [ -n "$stride_read" ] && args+=" -i 5"
• [ -n "$fwrite_refwrite" ] && args+=" -i 6"
• [ -n "$fread_refread" ] && args+=" -i 7"
• [ -n "$random_mix" ] && args+=" -i 8"
• [ -n "$pwrite_repwrite" ] && args+=" -i 9"
• [ -n "$pread_repread" ] && args+=" -i 10"
• [ -n "$pwritev_repwritev" ] && args+=" -i 11"
• [ -n "$preadv_repreadv" ] && args+=" -i 12"

• [ -n "$file_size" ] && args+=" -s $file_size"
• OLD_IFS="$IFS"
• IFS=","

It's a reduandant line, it seems unused and just be covered by "$OLD_IFS" later.

Thanks, Xijian

• array=($test)
• IFS="$OLD_IFS"
• for ele in ${array[@]}
• do

• case $ele in
  

• 	"write_rewrite")     args+=" -i 0"
  

• 		;;
  

• 	"read_reread")       args+=" -i 1"
  

• 		;;
  

• 	"random_read_write") args+=" -i 2"
  

• 		;;
  

• 	"read_backwards")    args+=" -i 3"
  

• 		;;
  

• 	"rewrite_record")    args+=" -i 4"
  

• 		;;
  

• 	"stride_read")       args+=" -i 5"
  

• 		;;
  

• 	"fwrite_refwrite")   args+=" -i 6"
  

• 		;;
  

• 	"fread_refread")     args+=" -i 7"
  

• 		;;
  

• 	"random_mix")        args+=" -i 8"
  

• 		;;
  

• 	"pwrite_repwrite")   args+=" -i 9"
  

• 		;;
  

• 	"pread_repread")     args+=" -i 10"
  

• 		;;
  

• 	"pwritev_repwritev") args+=" -i 11"
  

• 		;;
  

• 	"preadv_repreadv")   args+=" -i 12"
  

• 		;;
  

• esac
  

• done

else args+=" -a" fi -- 2.23.0