seems it's not spell error, just ":stddev" doesn't exists in metric_value

lib/compare.rb have ":stddev", and ":stddev_percent", it will cause confusion we'd better merge them if it's possible in this patch

Thanks, Weitao

On Tue, Dec 01, 2020 at 03:23:53PM +0800, Lu Kaiyi wrote:

there should be stddev_percent

Signed-off-by: Lu Kaiyi 2392863668@qq.com

lib/compare_matrixes.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/compare_matrixes.rb b/lib/compare_matrixes.rb index 7a9870a..2bb6a61 100644 --- a/lib/compare_matrixes.rb +++ b/lib/compare_matrixes.rb @@ -460,7 +460,7 @@ def assign_metric_values(metrics_values, dim, metric, values) metrics_values[metric]['standard_deviation'] ||= {} metric_value = get_values(values, true) metrics_values[metric]['average'][dim] = metric_value[:average]

• metrics_values[metric]['standard_deviation'][dim] = metric_value[:stddev] || 0

• metrics_values[metric]['standard_deviation'][dim] = metric_value[:stddev_percent] || 0

end

def assign_metric_change(metrics_values)

2.23.0