Hi Docs team, community,
To add one committer to Docs team,
@amyMaYun submitted [1], and I put -1 comment with reason, but I haven't got any reply so far.
@Rudy_Tan submitted another one [2], and it got approved immediately.
I am not against the nominated committer himself/herself, but I am against the process.
I propos to revert [2] if there is not a reasonalbe explanation.
[1] https://gitee.com/openeuler/community/pulls/321 [2] https://gitee.com/openeuler/community/pulls/300
同意永乐的观点。
具体建议： 1. PR中应该说明为什么candidate有能力作为maintainer 2. 有两个/lgtm，然后再/approve
-----Original Message----- From: Fred Li [mailto:yongle.li@gmail.com] Sent: Thursday, April 2, 2020 11:31 AM To: community community@openeuler.org; Liyongle via Dev dev@openeuler.org Cc: infra infra@openeuler.org; tc tc@openeuler.org Subject: [Tc] [Docs]Please check the 2 PRs for the same(perhaps) purpose
Hi Docs team, community,
To add one committer to Docs team,
@amyMaYun submitted [1], and I put -1 comment with reason, but I haven't got any reply so far.
@Rudy_Tan submitted another one [2], and it got approved immediately.
I am not against the nominated committer himself/herself, but I am against the process.
I propos to revert [2] if there is not a reasonalbe explanation.
[1] https://gitee.com/openeuler/community/pulls/321 [2] https://gitee.com/openeuler/community/pulls/300
-- Regards Fred Li (李永乐) _______________________________________________ Tc mailing list -- tc@openeuler.org To unsubscribe send an email to tc-leave@openeuler.org
对于approve，可以明确一下approve的前提，类似 @Huxinwei 所述，比如必须收集2个/lgtm才能进行approve，也就是3个人才能完成一个pr的合入。
在 2020-04-02 12:02:23，"Huxinwei via Tc" tc@openeuler.org 写道：
同意永乐的观点。
具体建议：
- PR中应该说明为什么candidate有能力作为maintainer
- 有两个/lgtm，然后再/approve
-----Original Message----- From: Fred Li [mailto:yongle.li@gmail.com] Sent: Thursday, April 2, 2020 11:31 AM To: community community@openeuler.org; Liyongle via Dev dev@openeuler.org Cc: infra infra@openeuler.org; tc tc@openeuler.org Subject: [Tc] [Docs]Please check the 2 PRs for the same(perhaps) purpose
Hi Docs team, community,
To add one committer to Docs team,
@amyMaYun submitted [1], and I put -1 comment with reason, but I haven't got any reply so far.
@Rudy_Tan submitted another one [2], and it got approved immediately.
I am not against the nominated committer himself/herself, but I am against the process.
I propos to revert [2] if there is not a reasonalbe explanation.
[1] https://gitee.com/openeuler/community/pulls/321 [2] https://gitee.com/openeuler/community/pulls/300
-- Regards Fred Li (李永乐) _______________________________________________ Tc mailing list -- tc@openeuler.org To unsubscribe send an email to tc-leave@openeuler.org
Tc mailing list -- tc@openeuler.org To unsubscribe send an email to tc-leave@openeuler.org
我认为2人也可以，但1个人最好避免。此外，就是对于committer提名这种，需要先陈述理由，得到认可后再合入，[1]没有表现出足够的理由。
On Thu, Apr 2, 2020 at 12:35 PM myeuler myeuler@163.com wrote:
对于approve，可以明确一下approve的前提，类似 @Huxinwei 所述，比如必须收集2个/lgtm才能进行approve，也就是3个人才能完成一个pr的合入。
在 2020-04-02 12:02:23，"Huxinwei via Tc" tc@openeuler.org 写道：
同意永乐的观点。
具体建议：
- PR中应该说明为什么candidate有能力作为maintainer
- 有两个/lgtm，然后再/approve
-----Original Message----- From: Fred Li [mailto:yongle.li@gmail.com] Sent: Thursday, April 2, 2020 11:31 AM To: community community@openeuler.org; Liyongle via Dev dev@openeuler.org Cc: infra infra@openeuler.org; tc tc@openeuler.org Subject: [Tc] [Docs]Please check the 2 PRs for the same(perhaps) purpose
Hi Docs team, community,
To add one committer to Docs team,
@amyMaYun submitted [1], and I put -1 comment with reason, but I haven't got any reply so far.
@Rudy_Tan submitted another one [2], and it got approved immediately.
I am not against the nominated committer himself/herself, but I am against the process.
I propos to revert [2] if there is not a reasonalbe explanation.
[1] https://gitee.com/openeuler/community/pulls/321 [2] https://gitee.com/openeuler/community/pulls/300
-- Regards Fred Li (李永乐) _______________________________________________ Tc mailing list -- tc@openeuler.org To unsubscribe send an email to tc-leave@openeuler.org
Tc mailing list -- tc@openeuler.org To unsubscribe send an email to tc-leave@openeuler.org
To close the thread, I created https://gitee.com/openeuler/community/pulls/328.
On Thu, Apr 2, 2020 at 12:39 PM Fred Li yongle.li@gmail.com wrote:
我认为2人也可以，但1个人最好避免。此外，就是对于committer提名这种，需要先陈述理由，得到认可后再合入，[1]没有表现出足够的理由。
On Thu, Apr 2, 2020 at 12:35 PM myeuler myeuler@163.com wrote:
对于approve，可以明确一下approve的前提，类似 @Huxinwei 所述，比如必须收集2个/lgtm才能进行approve，也就是3个人才能完成一个pr的合入。
在 2020-04-02 12:02:23，"Huxinwei via Tc" tc@openeuler.org 写道：
同意永乐的观点。
具体建议：
- PR中应该说明为什么candidate有能力作为maintainer
- 有两个/lgtm，然后再/approve
-----Original Message----- From: Fred Li [mailto:yongle.li@gmail.com] Sent: Thursday, April 2, 2020 11:31 AM To: community community@openeuler.org; Liyongle via Dev dev@openeuler.org Cc: infra infra@openeuler.org; tc tc@openeuler.org Subject: [Tc] [Docs]Please check the 2 PRs for the same(perhaps) purpose
Hi Docs team, community,
To add one committer to Docs team,
@amyMaYun submitted [1], and I put -1 comment with reason, but I haven't got any reply so far.
@Rudy_Tan submitted another one [2], and it got approved immediately.
I am not against the nominated committer himself/herself, but I am against the process.
I propos to revert [2] if there is not a reasonalbe explanation.
[1] https://gitee.com/openeuler/community/pulls/321 [2] https://gitee.com/openeuler/community/pulls/300
-- Regards Fred Li (李永乐) _______________________________________________ Tc mailing list -- tc@openeuler.org To unsubscribe send an email to tc-leave@openeuler.org
Tc mailing list -- tc@openeuler.org To unsubscribe send an email to tc-leave@openeuler.org
-- Regards Fred Li (李永乐)
-
Fred Li -
Huxinwei -
myeuler