Hi GUI: 很好的工作! 看了一下你的pr,包含一个patch,没有对spec文件进行修改; src-openEuler/grub2 用于构建openEuler的软件包,由上游社区发行版+patch组成,你的提交需要确保能够构建成功软件包,然后才能由maintainer/commiter 审核之后合入; 建议在本地环境上先将 利用src-openEuler/grub2 下的spec文件作出rpm包的过程验证完成再提交pr。
另外src-openEuler/grub2 仓中包含300+ 个patch,结构确实有些复杂,已将此邮件转发至dev mailist,还请负责维护grub2 的开发者审视pr,协助完成补丁的合入。 十分感谢。
BR Whoisxxx(张旭舟)
发件人: GUI [mailto:2991707448@qq.com] 发送时间: 2021年4月26日 8:40 收件人: buildteam buildteam@openeuler.org 主题: [Buildteam] 对openEuler for risc-v grub2 补丁的添加
RISC-V SIG的前辈们大家好,我前段时间完成了openEuler kernel 5.12rc riscv的grub2 启动测试,前天完成了稳定版OLK-5.10的测试。 仓库地址是:5-GuEe Studio: XBook and GNL forever! (gitee.com)https://gitee.com/openeuler2020/team-1375238611 仓库里有非常详细的实现步骤以及补丁。 昨天基于最新master分支向src-openEuler/grub2 (gitee.com)https://gitee.com/src-openeuler/grub2提交了补丁PR,第一次向OpenEuler社区提交补丁,因此格式可能还不符合OpenEuler社区的要求,欢迎大家使用和提出改进建议。
Hello, RISC-V SIG, I completed the test of grub2 startup for openEuler kernel 5.12rc riscv before, and completed the test of the release version of OLK-5.10 in the day before yesterday. The depository address is: 5-GuEe Studio: XBook and GNL forever! (gitee.com)https://gitee.com/openeuler2020/team-1375238611 There are some implementation ways and patches in there. I based on the new master branch hand in a patch PR to src-openEuler/grub2 (gitee.com)https://gitee.com/src-openeuler/grub2 This is my first time to hand in a patch to the OpenEuler community. So my PR's format may not meet the requirements of the OpenEuler community. You are welcome to use the tool and give suggestion.