- High-performance-network - mailweb.openeuler.org

[PATCH] libhns: Two bugfixes in post_send flow
by Chengchang Tang 15 Nov '24

15 Nov '24

From: Xinghai Cen <cenxinghai(a)h-partners.com> Two bugfixes in post_send flow: libhns: Fix out-of-order issue of requester when setting FENCE libhns: Fix reference to uninitialized cq pointer Signed-off-by: Xinghai Cen <cenxinghai(a)h-partners.com> --- ...f-order-issue-of-requester-when-sett.patch | 50 ++++++++++++++ ...eference-to-uninitialized-cq-pointer.patch | 68 +++++++++++++++++++ rdma-core.spec | 10 ++- 3 files changed, 127 insertions(+), 1 deletion(-) create mode 100644 0037-libhns-Fix-out-of-order-issue-of-requester-when-sett.patch create mode 100644 0038-libhns-Fix-reference-to-uninitialized-cq-pointer.patch diff --git a/0037-libhns-Fix-out-of-order-issue-of-requester-when-sett.patch b/0037-libhns-Fix-out-of-order-issue-of-requester-when-sett.patch new file mode 100644 index 0000000..0996c7f --- /dev/null +++ b/0037-libhns-Fix-out-of-order-issue-of-requester-when-sett.patch @@ -0,0 +1,50 @@ +From 23c00575e9dc2b61f2ac429f9d039cb7e2e6deb2 Mon Sep 17 00:00:00 2001 +From: Junxian Huang <huangjunxian6(a)hisilicon.com> +Date: Fri, 8 Nov 2024 17:04:09 +0800 +Subject: [PATCH] libhns: Fix out-of-order issue of requester when setting + FENCE + +mainline inclusion +from mainline-master +commit c4119911c212aaa552c9cb928fba0a696640c9b5 +category: bugfix +bugzilla: https://gitee.com/openeuler/kernel/issues/IB3ZHQ +CVE: NA +Reference: https://github.com/linux-rdma/rdma-core/pull/1513/commits/c4119911c212aaa55… + +---------------------------------------------------------------------- + +The FENCE indicator in hns WQE doesn't ensure that response data from +a previous Read/Atomic operation has been written to the requester's +memory before the subsequent Send/Write operation is processed. This +may result in the subsequent Send/Write operation accessing the original +data in memory instead of the expected response data. + +Unlike FENCE, the SO (Strong Order) indicator blocks the subsequent +operation until the previous response data is written to memory and a +bresp is returned. Set the SO indicator instead of FENCE to maintain +strict order. + +Fixes: cbdf5e32a855 ("libhns: Reimplement verbs of post_send and post_recv for hip08 RoCE") +Signed-off-by: Junxian Huang <huangjunxian6(a)hisilicon.com> +Signed-off-by: Xinghai Cen <cenxinghai(a)h-partners.com> +--- + providers/hns/hns_roce_u_hw_v2.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/providers/hns/hns_roce_u_hw_v2.c b/providers/hns/hns_roce_u_hw_v2.c +index 9371150..2debcb3 100644 +--- a/providers/hns/hns_roce_u_hw_v2.c ++++ b/providers/hns/hns_roce_u_hw_v2.c +@@ -1527,7 +1527,7 @@ static int set_rc_wqe(void *wqe, struct hns_roce_qp *qp, struct ibv_send_wr *wr, + + hr_reg_write_bool(wqe, RCWQE_CQE, + !!(wr->send_flags & IBV_SEND_SIGNALED)); +- hr_reg_write_bool(wqe, RCWQE_FENCE, ++ hr_reg_write_bool(wqe, RCWQE_SO, + !!(wr->send_flags & IBV_SEND_FENCE)); + hr_reg_write_bool(wqe, RCWQE_SE, + !!(wr->send_flags & IBV_SEND_SOLICITED)); +-- +2.33.0 + diff --git a/0038-libhns-Fix-reference-to-uninitialized-cq-pointer.patch b/0038-libhns-Fix-reference-to-uninitialized-cq-pointer.patch new file mode 100644 index 0000000..e45d61a --- /dev/null +++ b/0038-libhns-Fix-reference-to-uninitialized-cq-pointer.patch @@ -0,0 +1,68 @@ +From e941cc407d89595d1affd5211e1daf34786c7641 Mon Sep 17 00:00:00 2001 +From: Chengchang Tang <tangchengchang(a)huawei.com> +Date: Fri, 8 Nov 2024 17:04:08 +0800 +Subject: [PATCH] libhns: Fix reference to uninitialized cq pointer +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +mainline inclusion +from mainline-master +commit 18e3117cdd161a3f40b8a917f24cfb5227a1d75a +category: bugfix +bugzilla: https://gitee.com/openeuler/kernel/issues/IB3ZHQ +CVE: NA +Reference: https://github.com/linux-rdma/rdma-core/pull/1513/commits/18e3117cdd161a3f4… + +---------------------------------------------------------------------- + +For QPs which do not have an SQ, such as XRC TGT，the send_cq +pointer will not be initailized. Since the supported max_gs +will be 0 in this case, check it and return before referencing +the send_cq pointer. + +Fixes: cbdf5e32a855 ("libhns: Reimplement verbs of post_send and post_recv for hip08 RoCE") +Signed-off-by: Chengchang Tang <tangchengchang(a)huawei.com> +Signed-off-by: Junxian Huang <huangjunxian6(a)hisilicon.com> +Signed-off-by: Xinghai Cen <cenxinghai(a)h-partners.com> +--- + providers/hns/hns_roce_u_hw_v2.c | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/providers/hns/hns_roce_u_hw_v2.c b/providers/hns/hns_roce_u_hw_v2.c +index 2debcb3..465ef1e 100644 +--- a/providers/hns/hns_roce_u_hw_v2.c ++++ b/providers/hns/hns_roce_u_hw_v2.c +@@ -1579,7 +1579,7 @@ int hns_roce_u_v2_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, + struct hns_roce_context *ctx = to_hr_ctx(ibvqp->context); + struct hns_roce_qp *qp = to_hr_qp(ibvqp); + struct hns_roce_sge_info sge_info = {}; +- struct hns_roce_rc_sq_wqe *wqe; ++ struct hns_roce_rc_sq_wqe *wqe = NULL; + struct ibv_qp_attr attr = {}; + unsigned int wqe_idx, nreq; + int ret; +@@ -1595,15 +1595,15 @@ int hns_roce_u_v2_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, + sge_info.start_idx = qp->next_sge; /* start index of extend sge */ + + for (nreq = 0; wr; ++nreq, wr = wr->next) { +- if (hns_roce_v2_wq_overflow(&qp->sq, nreq, +- to_hr_cq(qp->verbs_qp.qp.send_cq))) { +- ret = ENOMEM; ++ if (wr->num_sge > (int)qp->sq.max_gs) { ++ ret = qp->sq.max_gs > 0 ? EINVAL : EOPNOTSUPP; + *bad_wr = wr; + goto out; + } + +- if (wr->num_sge > qp->sq.max_gs) { +- ret = EINVAL; ++ if (hns_roce_v2_wq_overflow(&qp->sq, nreq, ++ to_hr_cq(qp->verbs_qp.qp.send_cq))) { ++ ret = ENOMEM; + *bad_wr = wr; + goto out; + } +-- +2.33.0 + diff --git a/rdma-core.spec b/rdma-core.spec index 21a690e..4135ada 100644 --- a/rdma-core.spec +++ b/rdma-core.spec @@ -1,6 +1,6 @@ Name: rdma-core Version: 50.0 -Release: 13 +Release: 14 Summary: RDMA core userspace libraries and daemons License: GPLv2 or BSD Url: https://github.com/linux-rdma/rdma-core @@ -42,6 +42,8 @@ patch33: 0033-libhns-Fix-missing-flag-when-creating-qp-by-hnsdv_cr.patch patch34: 0034-librdmacm-Fix-an-overflow-bug-in-qsort-comparison-function.patch patch35: 0035-Fix-the-stride-calculation-for-MSN-PSN-area.patch patch36: 0036-add-ZTE-Dinghai-rdma-driver.patch +patch37: 0037-libhns-Fix-out-of-order-issue-of-requester-when-sett.patch +patch38: 0038-libhns-Fix-reference-to-uninitialized-cq-pointer.patch BuildRequires: binutils cmake >= 2.8.11 gcc libudev-devel pkgconfig pkgconfig(libnl-3.0) BuildRequires: pkgconfig(libnl-route-3.0) systemd systemd-devel @@ -627,6 +629,12 @@ fi %doc %{_docdir}/%{name}-%{version}/tag_matching.md %doc %{_docdir}/%{name}-%{version}/70-persistent-ipoib.rules +* Fri Nov 15 2024 Xinghai Cen <cenxinghai(a)h-partners.com> - 50.0-14 +- Type: bugfix +- ID: NA +- SUG: NA +- DESC: Two bugfixes in post_send flow + %changelog * Sat Aug 31 2024 Li Fuyan <li.fuyan(a)zte.com.cn> - 50.0-13 - Type: requirement -- 2.33.0

1 0

高性能网络sig会议
by openEuler conference 15 Nov '24

15 Nov '24

您好！ sig-high-performance-network 邀请您参加 2024-11-15 14:00 召开的WeLink会议(自动录制) 会议主题：高性能网络sig会议会议链接：https://meeting.huaweicloud.com:36443/#/j/965651261 会议纪要：https://etherpad.openeuler.org/p/sig-high-performance-network-meetings 更多资讯尽在：https://www.openeuler.org/zh/ Hello! sig-high-performance-network invites you to attend the WeLink conference(auto recording) will be held at 2024-11-15 14:00, The subject of the conference is 高性能网络sig会议, You can join the meeting at https://meeting.huaweicloud.com:36443/#/j/965651261. Add topics at https://etherpad.openeuler.org/p/sig-high-performance-network-meetings. More information: https://www.openeuler.org/en/

1 0

[PATCH rdma-core 0/2] libhns: Two bugfixes in post_send flow
by Junxian Huang 08 Nov '24

08 Nov '24

Two hns bugfixes in post_send flow Chengchang Tang (1): libhns: Fix reference to uninitialized cq pointer Junxian Huang (1): libhns: Fix out-of-order issue of requester when setting FENCE providers/hns/hns_roce_u_hw_v2.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.33.0

1 2

高性能网络sig例会
by openEuler conference 06 Nov '24

06 Nov '24

您好！ sig-high-performance-network 邀请您参加 2024-11-08 11:00 召开的WeLink会议(自动录制) 会议主题：高性能网络sig例会会议链接：https://meeting.huaweicloud.com:36443/#/j/960933891 会议纪要：https://etherpad.openeuler.org/p/sig-high-performance-network-meetings 更多资讯尽在：https://www.openeuler.org/zh/ Hello! sig-high-performance-network invites you to attend the WeLink conference(auto recording) will be held at 2024-11-08 11:00, The subject of the conference is 高性能网络sig例会, You can join the meeting at https://meeting.huaweicloud.com:36443/#/j/960933891. Add topics at https://etherpad.openeuler.org/p/sig-high-performance-network-meetings. More information: https://www.openeuler.org/en/

1 0

高性能网络sig会议
by openEuler conference 23 Oct '24

23 Oct '24

您好！ sig-high-performance-network 邀请您参加 2024-10-25 11:00 召开的WeLink会议会议主题：高性能网络sig会议会议链接：https://meeting.huaweicloud.com:36443/#/j/982220702 会议纪要：https://etherpad.openeuler.org/p/sig-high-performance-network-meetings 更多资讯尽在：https://www.openeuler.org/zh/ Hello! sig-high-performance-network invites you to attend the WeLink conference will be held at 2024-10-25 11:00, The subject of the conference is 高性能网络sig会议, You can join the meeting at https://meeting.huaweicloud.com:36443/#/j/982220702. Add topics at https://etherpad.openeuler.org/p/sig-high-performance-network-meetings. More information: https://www.openeuler.org/en/

1 0

Update kernel headers
by Junxian Huang 14 Oct '24

14 Oct '24

To commit: ?? ("RDMA/hns: Support mmapping reset state to userspace"). Signed-off-by: Junxian Huang <huangjunxian6(a)hisilicon.com> --- kernel-headers/rdma/hns-abi.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel-headers/rdma/hns-abi.h b/kernel-headers/rdma/hns-abi.h index 94e861870..065eb2e0a 100644 --- a/kernel-headers/rdma/hns-abi.h +++ b/kernel-headers/rdma/hns-abi.h @@ -136,6 +136,7 @@ struct hns_roce_ib_alloc_ucontext_resp { __u32 max_inline_data; __u8 congest_type; __u8 reserved0[7]; + __aligned_u64 reset_mmap_key; }; struct hns_roce_ib_alloc_ucontext { @@ -153,4 +154,9 @@ struct hns_roce_ib_create_ah_resp { __u8 tc_mode; }; +struct hns_roce_reset_state { + __u32 hw_ready; + __u32 reserved; +}; + #endif /* HNS_ABI_USER_H */ -- 2.33.0

1 3

Re: rdma-core PR流程rpm差异分析已完成，待下一步处理
by li.fuyan＠zte.com.cn 27 Sep '24

27 Sep '24

你好，帮忙看下新的rpm差异分析是否还有问题。 https://gitee.com/src-openeuler/rdma-core/pulls/165 感谢！李富艳软件开发工程师 ICF六部/智算云底座研发中心/无线及算力研究院 ICF Dept. VI/Intelligent Computing and Cloud Foundation R&D Center/Wireless and Computing Product R&D Institute 中兴通讯股份有限公司西安市长安区西沣路五星段9号中兴通讯1E-401 邮编: 710114 T: +86 029 xxxxxxxx M: +86 15332482266 E: li.fuyan(a)zte.com.cn www.zte.com.cn Original From: 李富艳00122684 To: tangchengchang <tangchengchang(a)huawei.com>; Cc: high-performance-network(a)openeuler.org <high-performance-network(a)openeuler.org>;dev(a)openeuler.org <dev(a)openeuler.org>; Date: 2024年09月19日 14:49 Subject: rdma-core PR流程rpm差异分析已完成，待下一步处理您好，下面PR链接已经在9月11日针对RPM构建的差异完成了分析，下一步处理是不是到您那边了，请帮忙看一下。 https://gitee.com/src-openeuler/rdma-core/pulls/165 感谢！李富艳软件开发工程师 ICF六部/智算云底座研发中心/无线及算力研究院 ICF Dept. VI/Intelligent Computing and Cloud Foundation R&D Center/Wireless and Computing Product R&D Institute 中兴通讯股份有限公司西安市长安区西沣路五星段9号中兴通讯1E-401 邮编: 710114 T: +86 029 xxxxxxxx M: +86 15332482266 E: li.fuyan(a)zte.com.cn www.zte.com.cn

1 0

rdma-core PR流程rpm差异分析已完成，待下一步处理
by li.fuyan＠zte.com.cn 19 Sep '24

19 Sep '24

您好，下面PR链接已经在9月11日针对RPM构建的差异完成了分析，下一步处理是不是到您那边了，请帮忙看一下。 https://gitee.com/src-openeuler/rdma-core/pulls/165 感谢！李富艳软件开发工程师 ICF六部/智算云底座研发中心/无线及算力研究院 ICF Dept. VI/Intelligent Computing and Cloud Foundation R&D Center/Wireless and Computing Product R&D Institute 中兴通讯股份有限公司西安市长安区西沣路五星段9号中兴通讯1E-401 邮编: 710114 T: +86 029 xxxxxxxx M: +86 15332482266 E: li.fuyan(a)zte.com.cn www.zte.com.cn

1 0

关于rdma-core PR状态
by li.fuyan＠zte.com.cn 05 Sep '24

05 Sep '24

您好，请帮忙看一下我在高性能网络SIG下提交的关于“ZTE Dinghai rdma-core驱动合入”的PR是什么状态，我在页面上看不到构建信息了。 https://gitee.com/src-openeuler/rdma-core/pulls/165 李富艳中兴通讯股份有限公司 T: +86 029 xxxxxxxx M: +86 15332482266 E: li.fuyan(a)zte.com.cn www.zte.com.cn

1 0

Re: 关于欧拉社区合入rdma-core PR时门禁系统构建问题
by li.fuyan＠zte.com.cn 03 Sep '24

03 Sep '24

你好，帮忙看一下如下构建信息，我从日志里看不出来是哪里有问题，需要你的帮助。 PR链接: https://gitee.com/src-openeuler/rdma-core/pulls/165 构建链接： https://openeulerjenkins.osinfra.cn/job/multiarch/job/src-openeuler/job/x86… 构建错误日志： 3771 2024-09-03 17:22:56 patching file redhat/rdma-core.spec 3772 2024-09-03 17:22:56 Hunk #1 succeeded at 176 (offset 2 lines). 3773 2024-09-03 17:22:56 Hunk #2 succeeded at 204 (offset 2 lines). 3774 2024-09-03 17:22:56 Hunk #3 succeeded at 586 (offset 3 lines). 3775 2024-09-03 17:22:56 error: Bad exit status from /var/tmp/rpm-tmp.43Oe9Z (%prep) 3776 2024-09-03 17:22:56 Bad exit status from /var/tmp/rpm-tmp.43Oe9Z (%prep) 3777 2024-09-03 17:22:56 3778 2024-09-03 17:22:56 RPM build errors: 3779 2024-09-03 17:22:56 failed to build rpms with rdma-core.spec 看起来像是redhat/rdma-core.spec文件有异常，但是从如下修改内容来看，没有看到明显的错误，请帮忙看一下。李富艳软件开发工程师 ICF六部/智算云底座研发中心/无线及算力研究院 ICF Dept. VI/Intelligent Computing and Cloud Foundation R&D Center/Wireless and Computing Product R&D Institute 中兴通讯股份有限公司西安市长安区西沣路五星段9号中兴通讯1E-401 邮编: 710114 T: +86 029 xxxxxxxx M: +86 15332482266 E: li.fuyan(a)zte.com.cn www.zte.com.cn Original From: 李富艳00122684 To: tangchengchang <tangchengchang(a)huawei.com>;chenshaowei3(a)h-partners.com <chenshaowei3(a)h-partners.com>;wanghuan158(a)h-partners.com <wanghuan158(a)h-partners.com>; Cc: wanghuan158(a)h-partners.com <wanghuan158(a)h-partners.com>; Date: 2024年08月31日 14:07 Subject: 关于欧拉社区合入PR时门禁系统构建问题 tangchegnchang 你好，已经根据你之前提交的评审意见修改了ZTE Dinghai rdma-core的代码，但是由于操作问题，修改后的代码提交了新的PR，链接如下： https://gitee.com/src-openeuler/rdma-core/pulls/165 门禁系统当前状态为check_build失败，查看build日志，我发现提示信息如下红色标记，changelog部分错误看起来是基础内容，不是本次合入的，请你帮忙看一下如何解决这种问题。 https://eulermaker.compass-ci.openeuler.openatom.cn/package/build-record?os… 2024-08-31 12:59:19 Hunk #1 succeeded at 245 (offset 5 lines). 3772 2024-08-31 12:59:19 3773 2024-08-31 12:59:19 RPM build errors: 3774 2024-08-31 12:59:19 error: Bad exit status from /var/tmp/rpm-tmp.ikn0I8 (%prep) 3775 2024-08-31 12:59:19 bad date in %changelog: Wed May 29 zhangyaqi <zhangyaqi(a)kylinos.cn> - 50.0-11 3776 2024-08-31 12:59:19 Bad exit status from /var/tmp/rpm-tmp.ikn0I8 (%prep) 3777 2024-08-31 12:59:19 failed to build rpms with rdma-core.spec 另外，能否麻烦你加我微信或者你提供下你的电话，方便后续沟通。我的电话：15332482266 我的微信二维码如下，方便的话请你加一下我李富艳软件开发工程师 ICF六部/智算云底座研发中心/无线及算力研究院 ICF Dept. VI/Intelligent Computing and Cloud Foundation R&D Center/Wireless and Computing Product R&D Institute 中兴通讯股份有限公司西安市长安区西沣路五星段9号中兴通讯1E-401 邮编: 710114 T: +86 029 xxxxxxxx M: +86 15332482266 E: li.fuyan(a)zte.com.cn www.zte.com.cn

1 0

2025

2024

2023

2022

2021

2020

High-performance-network