Re: [PATCH OLK-5.10] crypto:rmd320 rmd128 rmd256-remove RIPE-MD 320 128 256 hash algorithm

Hi Wen Zhiwei,

Thank you for your patch!

It seems you are merging the following patches into one:

93f64202926f crypto: rmd320 - remove RIPE-MD 320 hash algorithm c15d4167f0b0 crypto: rmd256 - remove RIPE-MD 256 hash algorithm b21b9a5e0aef crypto: rmd128 - remove RIPE-MD 128 hash algorithm

It will be better to keep the origin patch set as it is when backporting from upstream.

在 2021/11/4 14:33, Wen Zhiwei 写道:

mainlin inclusion category: performance bugzilla: NA CVE: NA

---

RIPE-MD 256 is never referenced anywhere in the kernel, and unlikely to be depended upon by userspace via AF_ALG. So let's remove it

Signed-off-by: Ard Biesheuvel ardb@kernel.org Signed-off-by: Herbert Xu herbert@gondor.apana.org.au Signed-off-by: Wen Zhiwei wenzhiwei@kylinos.cn

---

crypto/tcrypt.c | 42 +----------------------------------------- 1 file changed, 1 insertion(+), 41 deletions(-)

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 8609174e036e..c8b0d31631f5 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -71,7 +71,7 @@ static const char *check[] = { "blowfish", "twofish", "serpent", "sha384", "sha512", "md4", "aes", "cast6", "arc4", "michael_mic", "deflate", "crc32c", "tea", "xtea", "khazad", "wp512", "wp384", "wp256", "tnepres", "xeta", "fcrypt",

• "camellia", "seed", "salsa20", "rmd128", "rmd160", "rmd256", "rmd320",

• "camellia", "seed", "salsa20", "rmd160", "lzo", "lzo-rle", "cts", "sha3-224", "sha3-256", "sha3-384", "sha3-512", "streebog256", "streebog512", NULL

@@ -1860,22 +1860,10 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb) ret += tcrypt_test("cts(cbc(aes))"); break;

•    case 39:
  

• ret += tcrypt_test("rmd128");
  

• break;
  

•     case 40:
  

  ret += tcrypt_test("rmd160"); break;

• case 41:

• ret += tcrypt_test("rmd256");
  

• break;
  

• case 42:

• ret += tcrypt_test("rmd320");
  

• break;
  

• case 43: ret += tcrypt_test("ecb(seed)"); break;

@@ -1948,10 +1936,6 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb) ret += tcrypt_test("xcbc(aes)"); break;

• case 107:

• ret += tcrypt_test("hmac(rmd128)");
  

• break;
  

• case 108: ret += tcrypt_test("hmac(rmd160)"); break;

@@ -2402,22 +2386,10 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb) test_hash_speed("sha224", sec, generic_hash_speed_template); if (mode > 300 && mode < 400) break; fallthrough;

• case 314:

• test_hash_speed("rmd128", sec, generic_hash_speed_template);
  

• if (mode > 300 && mode < 400) break;
  

• fallthrough;
  

  case 315: test_hash_speed("rmd160", sec, generic_hash_speed_template); if (mode > 300 && mode < 400) break; fallthrough;
• case 316:

• test_hash_speed("rmd256", sec, generic_hash_speed_template);
  

• if (mode > 300 && mode < 400) break;
  

• fallthrough;
  

• case 317:

• test_hash_speed("rmd320", sec, generic_hash_speed_template);
  

• if (mode > 300 && mode < 400) break;
  

• fallthrough;
  

  case 318: klen = 16; test_hash_speed("ghash", sec, generic_hash_speed_template);

@@ -2526,22 +2498,10 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb) test_ahash_speed("sha224", sec, generic_hash_speed_template); if (mode > 400 && mode < 500) break; fallthrough;

• case 414:

• test_ahash_speed("rmd128", sec, generic_hash_speed_template);
  

• if (mode > 400 && mode < 500) break;
  

• fallthrough;
  

  case 415: test_ahash_speed("rmd160", sec, generic_hash_speed_template); if (mode > 400 && mode < 500) break; fallthrough;
• case 416:

• test_ahash_speed("rmd256", sec, generic_hash_speed_template);
  

• if (mode > 400 && mode < 500) break;
  

• fallthrough;
  

• case 417:

• test_ahash_speed("rmd320", sec, generic_hash_speed_template);
  

• if (mode > 400 && mode < 500) break;
  

• fallthrough;
  

  case 418: test_ahash_speed("sha3-224", sec, generic_hash_speed_template); if (mode > 400 && mode < 500) break;