From: liuxp11@chinatelecom.cn

Date: 2021-09-07 10:47

To: cj.chengjian; kernel

CC: xiexiuqi; cheng_openeuler; Li Bin

Subject: Re: Re: [PATCH kernel-4.19 02/29] sched: loadavg: consolidate LOAD_INT, LOAD_FRAC, CALC_LOAD

There is no "calc_load --> calc_avg" in patch 02,please check.

---

Thanks！

 

From: chengjian (D)

Date: 2021-09-07 10:21

To: Liu Xinpeng; kernel@openeuler.org

CC: xiexiuqi; cheng_openeuler; Li Bin

Subject: Re: [PATCH kernel-4.19 02/29] sched: loadavg: consolidate LOAD_INT, LOAD_FRAC, CALC_LOAD

您好，冒昧打扰。

您的补丁自第 2 个补丁之后，有如下编译错误。

On 2021/9/5 22:26, Liu Xinpeng wrote:

  * latency such that 1/exp (decay rate) is [1 min, 2.5 min) when windows
@@ -505,7 +505,7 @@ static void iolatency_check_latencies(struct iolatency_grp *iolat, u64 now)
 	lat_info = &parent->child_lat;
 
 	/*
-	 * CALC_LOAD takes in a number stored in fixed point representation.
+	 * calc_load takes in a number stored in fixed point representation.
 	 * Because we are using this for IO time in ns, the values stored
 	 * are significantly larger than the FIXED_1 denominator (2048).
 	 * Therefore, rounding errors in the calculation are negligible and
@@ -514,7 +514,8 @@ static void iolatency_check_latencies(struct iolatency_grp *iolat, u64 now)
 	exp_idx = min_t(int, BLKIOLATENCY_NR_EXP_FACTORS - 1,
 			div64_u64(iolat->cur_win_nsec,
 				  BLKIOLATENCY_EXP_BUCKET_SIZE));
-	CALC_LOAD(iolat->lat_avg, iolatency_exp_factors[exp_idx], stat.mean);
+	iolat->lat_avg = calc_avg(iolat->lat_avg,
+				  iolatency_exp_factors[exp_idx], stat.mean);
 

[FAIL] build_x86_64Sept. 6, 2021, 9:54 a.m. UTC

make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- allmodconfig && make -j64 ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
block/blk-iolatency.c: In function ‘iolatency_check_latencies’:
block/blk-iolatency.c:517:19: error: implicit declaration of function ‘calc_avg’; did you mean ‘calc_load’? [-Werror=implicit-function-declaration]
  iolat->lat_avg = calc_avg(iolat->lat_avg,
                   ^~~~~~~~
                   calc_load
cc1: some warnings being treated as errors
make[1]: *** [block/blk-iolatency.o] Error 1
make: *** [block] Error 2
make: *** Waiting for unfinished jobs....

[FAIL] build_arm64Sept. 6, 2021, 9:54 a.m. UTC

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- allmodconfig && make -j64 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
block/blk-iolatency.c: In function ‘iolatency_check_latencies’:
block/blk-iolatency.c:517:19: error: implicit declaration of function ‘calc_avg’; did you mean ‘calc_load’? [-Werror=implicit-function-declaration]
  iolat->lat_avg = calc_avg(iolat->lat_avg,
                   ^~~~~~~~
                   calc_load
cc1: some warnings being treated as errors
make[1]: *** [block/blk-iolatency.o] Error 1
make: *** [block] Error 2
make: *** Waiting for unfinished jobs....

[FAIL] build_storage_arm64Sept. 6, 2021, 9:53 a.m. UTC

cp arch/arm64/configs/storage_ci_defconfig .config && make -j8 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
block/blk-iolatency.c: In function ‘iolatency_check_latencies’:
block/blk-iolatency.c:517:19: error: implicit declaration of function ‘calc_avg’; did you mean ‘calc_load’? [-Werror=implicit-function-declaration]
  iolat->lat_avg = calc_avg(iolat->lat_avg,
                   ^~~~~~~~
                   calc_load
cc1: some warnings being treated as errors
make[1]: *** [block/blk-iolatency.o] Error 1
make: *** [block] Error 2
make: *** Waiting for unfinished jobs.... * _HZ for the global load-average.

kernel 合入的补丁要求每个补丁依次顺序合入都可以正常编译。

谢谢。

---- 成坚