From: Jinjie Ruan ruanjinjie@huawei.com
mainline inclusion from mainline-v6.12-rc6 commit 5f994f534120f47432092fb36f5cb0c7a80ed2bf category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IBFOBV
Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
--------------------------------
The error path in msi_domain_alloc(), frees the already allocated MSI interrupts in a loop, but the loop condition terminates when the index reaches zero, which fails to free the first allocated MSI interrupt at index zero.
Check for >= 0 so that msi[0] is freed as well.
Fixes: f3cf8bb0d6c3 ("genirq: Add generic msi irq domain support") Signed-off-by: Jinjie Ruan ruanjinjie@huawei.com Signed-off-by: Thomas Gleixner tglx@linutronix.de Link: https://lore.kernel.org/all/20241026063639.10711-1-ruanjinjie@huawei.com Signed-off-by: Lin Yujun linyujun809@huawei.com --- kernel/irq/msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c index fa2f0cc033e8..6a25a6ebafd3 100644 --- a/kernel/irq/msi.c +++ b/kernel/irq/msi.c @@ -156,7 +156,7 @@ static int msi_domain_alloc(struct irq_domain *domain, unsigned int virq, ret = ops->msi_init(domain, info, virq + i, hwirq + i, arg); if (ret < 0) { if (ops->msi_free) { - for (i--; i > 0; i--) + for (i--; i >= 0; i--) ops->msi_free(domain, info, virq + i); } irq_domain_free_irqs_top(domain, virq, nr_irqs);