From: Gu Shengxian gushengxian@yulong.com
stable inclusion from linux-4.19.199 commit 4416df721325d97b9b8eb297e8a5d844dd3bf8b9
--------------------------------
commit bc832065b60f973771ff3e657214bb21b559833c upstream.
va_list 'ap' was opened but not closed by va_end() in error case. It should be closed by va_end() before the return.
Fixes: aa52bcbe0e72 ("tools: bpftool: Fix json dump crash on powerpc") Signed-off-by: Gu Shengxian gushengxian@yulong.com Signed-off-by: Daniel Borkmann daniel@iogearbox.net Cc: Jiri Olsa jolsa@redhat.com Link: https://lore.kernel.org/bpf/20210706013543.671114-1-gushengxian507419@gmail.... Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org Signed-off-by: Yang Yingliang yangyingliang@huawei.com --- tools/bpf/bpftool/jit_disasm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c index 73d7252729fad..e4cfbecf02189 100644 --- a/tools/bpf/bpftool/jit_disasm.c +++ b/tools/bpf/bpftool/jit_disasm.c @@ -51,11 +51,13 @@ static int fprintf_json(void *out, const char *fmt, ...) { va_list ap; char *s; + int err;
va_start(ap, fmt); - if (vasprintf(&s, fmt, ap) < 0) - return -1; + err = vasprintf(&s, fmt, ap); va_end(ap); + if (err < 0) + return -1;
if (!oper_count) { int i;