Hi Zhengyuan,

Would you please resend a patch to remove those ccflags?

Thanks!

On 2020/3/31 9:34, huangdaode wrote:
> Yes, I don't think we need these flags in open kernel tree, it's for product compile.
>
> -----邮件原件-----
> 发件人: Xiexiuqi
> 发送时间: 2020年3月27日 17:14
> 收件人: Guohanjun (Hanjun Guo) <guohanjun@huawei.com>; Zhengyuan Liu <liuzhengyuan@tj.kylinos.cn>; kernel@openeuler.org; huangdaode <huangdaode@huawei.com>; lipeng (Y) <lipeng321@huawei.com>
> 主题: Re: [PATCH] KYLIN: hns3: fix a compilation error
>
> Hi Li Peng & Daode,
>
> Please help to check this patch about hns3's Makefile.
>
> On 2020/3/27 11:38, Hanjun Guo via Kernel wrote:
>> On 2020/3/25 9:12, Zhengyuan Liu wrote:
>>>
>>>
>>> On 2020/3/24 下午9:22, Hanjun Guo wrote:
>>>> Hi Zhengyuan,
>>>>
>>>> On 2020/3/20 18:55, Zhengyuan Liu via Kernel wrote:
>>>>> From: Zhengyuan Liu <liuzhengyuan@kylinos.cn>
>>>>>
>>>>> Make stack-protector-strong building flag depend on
>>>>> CONFIG_STACKPROTECTOR_STRONG, otherwise there could be a
>>>>> copmilation error:
>>>>>
>>>>>     MODPOST 1532 modules
>>>>>     ERROR: "__stack_chk_fail" [drivers/net/ethernet/hisilicon/hns3/hns3_cae.ko] undefined!
>>>>>     ERROR: "__stack_chk_guard" [drivers/net/ethernet/hisilicon/hns3/hns3_cae.ko] undefined!
>>>>>     ERROR: "__stack_chk_fail" [drivers/net/ethernet/hisilicon/hns3/hns3.ko] undefined!
>>>>>     ERROR: "__stack_chk_guard" [drivers/net/ethernet/hisilicon/hns3/hns3.ko] undefined!
>>>>>     ERROR: "__stack_chk_fail" [drivers/net/ethernet/hisilicon/hns3/hclgevf.ko] undefined!
>>>>>     ERROR: "__stack_chk_guard" [drivers/net/ethernet/hisilicon/hns3/hclgevf.ko] undefined!
>>>>>     ERROR: "__stack_chk_fail" [drivers/net/ethernet/hisilicon/hns3/hclge.ko] undefined!
>>>>>     ERROR: "__stack_chk_guard" [drivers/net/ethernet/hisilicon/hns3/hclge.ko] undefined!
>>>>>     make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>>>>>
>>>>> Signed-off-by: Zhengyuan Liu <liuzhengyuan@kylinos.cn>
>>>>> ---
>>>>>   drivers/net/ethernet/hisilicon/hns3/Makefile | 2 ++
>>>>>   1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/drivers/net/ethernet/hisilicon/hns3/Makefile
>>>>> b/drivers/net/ethernet/hisilicon/hns3/Makefile
>>>>> index 6653e81ede9a..f4952f46be7f 100644
>>>>> --- a/drivers/net/ethernet/hisilicon/hns3/Makefile
>>>>> +++ b/drivers/net/ethernet/hisilicon/hns3/Makefile
>>>>> @@ -4,7 +4,9 @@
>>>>>   #
>>>>>     # Add security options
>>>>> +ifdef CONFIG_STACKPROTECTOR_STRONG
>>>>>   ccflags-y += -fstack-protector-strong
>>>>
>>>> I'm not sure why we need this compile option, seems we need to
>>>> remove all those ccflags-y in this file, I will take a look and get
>>>> back to you.
>>>
>>> Hi Hanjun, thanks for your reply. I'm curious about that ccflags too, the upstream seems to haven't those flags.
>>
>> I think we need to remove those ccflags, could you please send another
>> version of the patch?
>
> Hi, Hanjun,
> I agree with you, we do not need this ccflags in kernel tree.
> What do you think, Li Peng & Daode?
>
> @Li Peng, @Huang Daode.
>
>>
>> Thanks
>> Hanjun
>> _______________________________________________
>> Kernel mailing list -- kernel@openeuler.org To unsubscribe send an
>> email to kernel-leave@openeuler.org
>>
>