mainline inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I4AFG6?from=project-issue CVE: NA
in function qla24xx_sp_unmap, it is already called sp->free(sp), then it`s not need to called sp->free(sp) after qla24xx_sp_unmap is called.
Signed-off-by: zhangyue zhangyue1@kylinos.cn --- drivers/scsi/qla2xxx/qla_gs.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index c3195d4c25e5..a7198a1e23fb 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b/drivers/scsi/qla2xxx/qla_gs.c @@ -4228,7 +4228,6 @@ static void qla2x00_async_gpnft_gnnft_sp_done(void *s, int res) if (rc) { /* Cleanup here to prevent memory leak */ qla24xx_sp_unmap(vha, sp); - sp->free(sp); }
spin_lock_irqsave(&vha->work_lock, flags);
Hi zhangyue:
我们的CI报了一条格式告警（见附1），意思为您提交的补丁头加的不规范，缺少 了主线补丁对应的版本号（可以通过git name-rev + commit_id获得），后续请按 照规范的格式（见附2）进行提交，谢谢。
best regard
附1：以下是CI的告警：
[WARNING] checkformatNov. 12, 2021, 3:52 a.m. UTC euler patch format check
mainline inclusion OK from mainline-v4.13-rc2 <- missing
附2：以下是格式要求（这部分内容可以在kerenl仓的README中找到）
Patch format definition -----------------------
[M] stands for "mandatory" [O] stands for "option" $category can be: bug preparation, bugfix, perf, feature, doc, other...
If category is feature, then we also need to add feature name like below: category: feature feature: YYY (the feature name)
If the patch is related to CVE or bugzilla, then we need add the corresponding tag like below (In general, it should include at least one of the following): CVE: $cve-id bugzilla: $bug-id
Additional changelog should include at least one of the flollwing: 1) Why we should apply this patch 2) What real problem in product does this patch resolved 3) How could we reproduce this bug or how to test 4) Other useful information for help to understand this patch or problem
The detail information is very useful for porting patch to another kenrel branch.
Example for mainline patch:
mainline inclusion [M] from $mainline-version [M] commit $id [M] category: $category [M] bugzilla: $bug-id [O] CVE: $cve-id [O]
additional changelog [O]
--------------------------------
original changelog
Signed-off-by: $yourname $yourname@huawei.com [M]
($mainline-version could be mainline-3.5, mainline-3.6, etc...)
Examples --------
mainline inclusion from mainline-4.10 commit 0becc0ae5b42828785b589f686725ff5bc3b9b25 category: bugfix bugzilla: 3004 CVE: NA
The patch fixes a BUG_ON in the product: injecting single bit ECC error to memory before system boot use hardware inject tools, which cause a large amount of CMCI during system booting .
[ 1.146580] mce: [Hardware Error]: Machine check events logged [ 1.152908] ------------[ cut here ]------------ [ 1.157751] kernel BUG at kernel/timer.c:951! [ 1.162321] invalid opcode: 0000 [#1] SMP ...
-------------------------------------------------
original changelog
<original S-O-B> Signed-off-by: Zhang San zhangsan@huawei.com Tested-by: Li Si lisi@huawei.com
Email Client - Thunderbird Settings -----------------------------------
On 2021/11/10 6:24, zhangyue wrote:
mainline inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I4AFG6?from=project-issue CVE: NA
in function qla24xx_sp_unmap, it is already called sp->free(sp), then it`s not need to called sp->free(sp) after qla24xx_sp_unmap is called.
Signed-off-by: zhangyue zhangyue1@kylinos.cn
drivers/scsi/qla2xxx/qla_gs.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index c3195d4c25e5..a7198a1e23fb 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b/drivers/scsi/qla2xxx/qla_gs.c @@ -4228,7 +4228,6 @@ static void qla2x00_async_gpnft_gnnft_sp_done(void *s, int res) if (rc) { /* Cleanup here to prevent memory leak */ qla24xx_sp_unmap(vha, sp);
sp->free(sp);}
spin_lock_irqsave(&vha->work_lock, flags);
-
QiuLaibin -
zhangyue