Hi Wang,

FYI, the error/warning still remains.

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 7efcac7603953bb58d80041f410b079378b5174c commit: 1ce24a39db64afc5041e3a32893f3e5f1f5d4b9d [21358/21625] rtc: add rtc drivers for Phytium SOCs config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20240209/202402090220.HJntQd5h-lkp@i...) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240209/202402090220.HJntQd5h-lkp@i...)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot lkp@intel.com | Closes: https://lore.kernel.org/oe-kbuild-all/202402090220.HJntQd5h-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/rtc/rtc-phytium.c: In function 'phytium_rtc_read_time':

...

drivers/rtc/rtc-phytium.c:65:23: warning: variable 'tmp' set but not used [-Wunused-but-set-variable]

65 | unsigned long tmp = 0; | ^~~ drivers/rtc/rtc-phytium.c: In function 'phytium_rtc_set_mmss': drivers/rtc/rtc-phytium.c:85:23: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] 85 | unsigned long tmp = 0; | ^~~

...

drivers/rtc/rtc-phytium.c:84:23: warning: variable 'counter' set but not used [-Wunused-but-set-variable]

84 | unsigned long counter = 0; | ^~~~~~~ drivers/rtc/rtc-phytium.c: In function 'phytium_rtc_set_alarm':

...

drivers/rtc/rtc-phytium.c:139:23: warning: variable 'rtc_time' set but not used [-Wunused-but-set-variable]

139 | unsigned long rtc_time; | ^~~~~~~~

vim +/tmp +65 drivers/rtc/rtc-phytium.c

59 60 static int phytium_rtc_read_time(struct device *dev, struct rtc_time *tm) 61 { 62 struct phytium_rtc_dev *pdata = dev_get_drvdata(dev); 63 64 unsigned long counter = 0;

65 unsigned long tmp = 0;

66 67 spin_lock(&spinlock_phytium_rtc); 68 writel(RTC_AES_SEL_COUNTER, pdata->csr_base + RTC_AES_SEL); 69 counter = readl(pdata->csr_base + RTC_CCVR); 70 tmp = readl(pdata->csr_base + RTC_CDR_LOW); 71 72 dev_info(dev, "%s_%d : counter : 0x%lx\n", 73 __func__, __LINE__, counter); 74 75 spin_unlock(&spinlock_phytium_rtc); 76 77 rtc_time_to_tm(counter, tm); 78 return rtc_valid_tm(tm); 79 } 80 81 static int phytium_rtc_set_mmss(struct device *dev, unsigned long secs) 82 { 83 struct phytium_rtc_dev *pdata = dev_get_drvdata(dev);

84 unsigned long counter = 0; 85 unsigned long tmp = 0;

86 87 spin_lock(&spinlock_phytium_rtc); 88 89 writel(RTC_AES_SEL_COUNTER, pdata->csr_base + RTC_AES_SEL); 90 writel(0x00000000, pdata->csr_base + RTC_CLR_LOW); 91 writel((u32)secs, pdata->csr_base + RTC_CLR); 92 writel(RTC_AES_SEL_COUNTER, pdata->csr_base + RTC_AES_SEL); 93 counter = readl(pdata->csr_base + RTC_CLR); 94 tmp = readl(pdata->csr_base + RTC_CLR_LOW); 95 96 spin_unlock(&spinlock_phytium_rtc); 97 98 return 0; 99 } 100 101 static int phytium_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) 102 { 103 struct phytium_rtc_dev *pdata = dev_get_drvdata(dev); 104 105 rtc_time_to_tm(pdata->alarm_time, &alrm->time); 106 alrm->enabled = readl(pdata->csr_base + RTC_CCR) & RTC_CCR_IE; 107 108 return 0; 109 } 110 111 static int phytium_rtc_alarm_irq_enable(struct device *dev, u32 enabled) 112 { 113 struct phytium_rtc_dev *pdata = dev_get_drvdata(dev); 114 u32 ccr; 115 116 ccr = readl(pdata->csr_base + RTC_CCR); 117 if (enabled) { 118 ccr &= ~RTC_CCR_MASK; 119 ccr |= RTC_CCR_IE; 120 } else { 121 ccr &= ~RTC_CCR_IE; 122 ccr |= RTC_CCR_MASK; 123 } 124 writel(ccr, pdata->csr_base + RTC_CCR); 125 126 return 0; 127 } 128 129 static int phytium_rtc_alarm_irq_enabled(struct device *dev) 130 { 131 struct phytium_rtc_dev *pdata = dev_get_drvdata(dev); 132 133 return readl(pdata->csr_base + RTC_CCR) & RTC_CCR_IE ? 1 : 0; 134 } 135 136 static int phytium_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) 137 { 138 struct phytium_rtc_dev *pdata = dev_get_drvdata(dev);

139 unsigned long rtc_time;

140 unsigned long alarm_time; 141 142 rtc_time = readl(pdata->csr_base + RTC_CCVR); 143 rtc_tm_to_time(&alrm->time, &alarm_time); 144 145 pdata->alarm_time = alarm_time; 146 writel((u32) pdata->alarm_time, pdata->csr_base + RTC_CMR); 147 148 phytium_rtc_alarm_irq_enable(dev, alrm->enabled); 149 150 return 0; 151 } 152