[Linuxarm] Re: [RFCv2 PATCH net-next 080/167] net: fjes: use netdev feature helpers

Review-by: Jie Wang wangjie125@huawei.com

On 2021/9/22 22:57, Jian Shen wrote:

Use netdev_feature_xxx helpers to replace the logical operation for netdev features.

Signed-off-by: Jian Shen shenjian15@huawei.com

drivers/net/fjes/fjes_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 185c8a398681..583d21ad25c8 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -1344,7 +1344,8 @@ static void fjes_netdev_setup(struct net_device *netdev) netdev->mtu = fjes_support_mtu[3]; netdev->min_mtu = fjes_support_mtu[0]; netdev->max_mtu = fjes_support_mtu[3];

• netdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;

• netdev_feature_set_bit(NETIF_F_HW_VLAN_CTAG_FILTER_BIT,

• 	       &netdev->features);
  

}

static void fjes_irq_watch_task(struct work_struct *work)