[Linuxarm] Re: [RFCv2 PATCH net-next 071/167] net: bareudp: use netdev feature helpers

Review-by: Jie Wang wangjie125@huawei.com

On 2021/9/22 22:57, Jian Shen wrote:

Use netdev_feature_xxx helpers to replace the logical operation for netdev features.

Signed-off-by: Jian Shen shenjian15@huawei.com

drivers/net/bareudp.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 54e321a695ce..88be2288a78c 100644 --- a/drivers/net/bareudp.c +++ b/drivers/net/bareudp.c @@ -534,13 +534,15 @@ static void bareudp_setup(struct net_device *dev) dev->netdev_ops = &bareudp_netdev_ops; dev->needs_free_netdev = true; SET_NETDEV_DEVTYPE(dev, &bareudp_type);

• dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST;
• dev->features |= NETIF_F_RXCSUM;
• dev->features |= NETIF_F_LLTX;
• dev->features |= NETIF_F_GSO_SOFTWARE;
• dev->hw_features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST;
• dev->hw_features |= NETIF_F_RXCSUM;
• dev->hw_features |= NETIF_F_GSO_SOFTWARE;

• netdev_feature_set_bits(NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST,

• 		&dev->features);
  

• netdev_feature_set_bit(NETIF_F_RXCSUM_BIT, &dev->features);
• netdev_feature_set_bit(NETIF_F_LLTX_BIT, &dev->features);
• netdev_feature_set_bits(NETIF_F_GSO_SOFTWARE, &dev->features);
• netdev_feature_set_bits(NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST,

• 		&dev->hw_features);
  

• netdev_feature_set_bit(NETIF_F_RXCSUM_BIT, &dev->hw_features);
• netdev_feature_set_bits(NETIF_F_GSO_SOFTWARE, &dev->hw_features); dev->hard_header_len = 0; dev->addr_len = 0; dev->mtu = ETH_DATA_LEN;