On 2021/6/8 20:53, Vladimir Oltean wrote:
On Thu, Jun 03, 2021 at 11:35:48AM -0700, Jakub Kicinski wrote:
On Thu, 3 Jun 2021 09:47:57 +0800 Yunsheng Lin wrote:
Patch 1: remove unnecessary seqcount operation. Patch 2: implement TCQ_F_CAN_BYPASS. Patch 3: remove qdisc->empty.
Performance data for pktgen in queue_xmit mode + dummy netdev with pfifo_fast:
threads unpatched patched delta 1 2.60Mpps 3.21Mpps +23% 2 3.84Mpps 5.56Mpps +44% 4 5.52Mpps 5.58Mpps +1% 8 2.77Mpps 2.76Mpps -0.3% 16 2.24Mpps 2.23Mpps +0.4%
Performance for IP forward testing: 1.05Mpps increases to 1.16Mpps, about 10% improvement.
Acked-by: Jakub Kicinski kuba@kernel.org
Any idea why these patches are deferred in patchwork? https://patchwork.kernel.org/project/netdevbpf/cover/1622684880-39895-1-git-...
I suppose it is a controversial change, which need more time hanging to be reviewed and tested.
By the way, I did not pick up your "Tested-by" from previous RFC version because there is some change between those version that deserves a retesting. So it would be good to have a "Tested-by" from you after confirming no out of order happening for this version, thanks.