[Linuxarm] Re: [RFCv2 PATCH net-next 058/167] net: phonet: use netdev feature helpers

Review-by: Jie Wang wangjie125@huawei.com

On 2021/9/22 22:57, Jian Shen wrote:

Use netdev_feature_xxx helpers to replace the logical operation for netdev features.

Signed-off-by: Jian Shen shenjian15@huawei.com

net/phonet/pep-gprs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/phonet/pep-gprs.c b/net/phonet/pep-gprs.c index 1f5df0432d37..0f6e6c1f3ec1 100644 --- a/net/phonet/pep-gprs.c +++ b/net/phonet/pep-gprs.c @@ -212,7 +212,8 @@ static const struct net_device_ops gprs_netdev_ops = {

static void gprs_setup(struct net_device *dev) {

• dev->features = NETIF_F_FRAGLIST;

• netdev_feature_zero(&dev->features);
• netdev_feature_set_bit(NETIF_F_FRAGLIST_BIT, &dev->features); dev->type = ARPHRD_PHONET_PIPE; dev->flags = IFF_POINTOPOINT | IFF_NOARP; dev->mtu = GPRS_DEFAULT_MTU;