[Linuxarm] Re: [PATCH v2 plinth/topic-sas-5.16 0/6] Some small fixes for scsi/libsas

在 2022/1/14 1:21, John Garry 写道:

On 12/01/2022 03:28, chenxiang wrote:

...

From: Xiang Chenchenxiang66@hisilicon.com

There are some small fixes related to scsi and libsas:

• Use void for sas_discover_event() return code;
• Remove duplicated setting fro task->task_state_flags;
• Remove unused parameter for function sas_ata_eh();
• Use spin_{lock, unlock} instead of spin_{lock, unlock}_irq or

spin_lock_irqsave/spin_unlock_irqrestore for asd_sas_port->dev_list_lock and sas_ha->phy_port_lock;

• Remove unused member cmd_pool for structure scsi_host_template;

None of these seems like fixes, just saying.

Ok, maybe cleanup is more concise.

Thanks, John .