[Linuxarm] Re: [PATCH for next v1 2/2] gpio: grgpio: Replace spin_lock_irqsave with spin_lock in grgpio_irq_handler()

On Mon, Feb 8, 2021 at 10:58 AM Luo Jiaxing luojiaxing@huawei.com wrote:

There is no need to use API with _irqsave in grgpio_irq_handler(), because it already be in a irq-disabled context.

It seems you haven't read the code. The handler here is shared. And lock there is about something else that we discussed in the cover letter. Moreover, the driver is quite outdated and code inside is horrible according to the modern APIs / standards.

I would rather remove the driver completely.