[Linuxarm] Re: [PATCH plinth/topic-sas-5.16 4/7] {topost} scsi: libsas: Use spin_lock/unlock() for asd_sas_port->dev_list_lock

On 24/12/2021 06:07, chenxiang wrote:

From: Xiang Chenchenxiang66@hisilicon.com

Spinlock asd_sas_port->dev_list_lock is used when domain_dev is added or removed. But some places use spin_lock()/spin_unlock() while other places use spin_lock_irq() /spin_unlock_irq(). Actually all those places are called in process context (workqueue) now, so use spin_lock/unlock() instead of

spin_lock/unlock_irq().

Please use form spin_{lock, unlock}_irq(), and similar for other places.

So do you have an idea why spin_lock_irq() was used in the first place? There has to be a reason. Where some interrupt handlers using the locks?

Thanks, John