16/04/2021 11:41, Ferruh Yigit:
On 4/16/2021 9:58 AM, Thomas Monjalon wrote:
16/04/2021 10:46, Lijun Ou:
Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_eth_rx_queue_info_get and rte_eth_tx_queue_info_get API.
Note: After add queue_state field, the 'struct rte_eth_rxq_info' size remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so it could be ABI compatible.
[...]
--- a/doc/guides/rel_notes/release_21_05.rst +++ b/doc/guides/rel_notes/release_21_05.rst @@ -251,6 +251,12 @@ ABI Changes function was already marked as internal in the API documentation for it, and was not for use by external applications.
+* Added new field ``queue_state`` to ``rte_eth_rxq_info`` structure
- to provide indicated rxq queue state.
+* Added new field ``queue_state`` to ``rte_eth_txq_info`` structure
- to provide indicated txq queue state.
Not sure we should add a note here for additions which do not break ABI compatibility. It may be confusing.
Hi Thomas,
What do about adding the documentation to "API Changes" section? Since 'rte_eth_rx_queue_info_get()'/'rte_eth_tx_queue_info_get()' can get 'queue_state' now, which may taken as API change.
That's an addition. The users have nothing to change in their existing code, so I think we don't need a note in API or ABI change. The only required note would be in the "New Features".