-----Original Message----- From: Intel-wired-lan intel-wired-lan-bounces@osuosl.org On Behalf Of Salil Mehta Sent: Thursday, April 22, 2021 5:00 PM To: davem@davemloft.net; kuba@kernel.org Cc: salil.mehta@huawei.com; netdev@vger.kernel.org; linuxarm@huawei.com; linuxarm@openeuler.org; linux- kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org Subject: [Intel-wired-lan] [PATCH V3 net] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency

If user has explicitly requested the number of {R,T}XQs, then it is unnecessary to get the count of already available {R,T}XQs from the PF avail_{r,t}xqs bitmap. This value will get overridden by user specified value in any case.

Re-organize this code for improving the flow, readability and efficiency. This scope of improvement was found during the review of the ICE driver code.

Fixes: 87324e747fde ("ice: Implement ethtool ops for channels") Cc: intel-wired-lan@lists.osuosl.org Tested-by: Tony Brelinski tonyx.brelinski@intel.com Signed-off-by: Salil Mehta salil.mehta@huawei.com

---

Change: V2->V3 (*) Addressed some comments from Paul Menzel Link: https://lkml.org/lkml/2021/4/21/136 V1->V2 (*) Fixed the comments from Anthony Nguyen(Intel) Link: https://lkml.org/lkml/2021/4/12/1997

---

drivers/net/ethernet/intel/ice/ice_lib.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)

Tested-by: Tony Brelinski tonyx.brelinski@intel.com (A Contingent Worker at Intel)