-----Original Message----- From: liulongfang liulongfang@huawei.com Sent: Monday, November 4, 2024 8:31 AM To: Alex Williamson alex.williamson@redhat.com Cc: jgg@nvidia.com; Shameerali Kolothum Thodi shameerali.kolothum.thodi@huawei.com; Jonathan Cameron jonathan.cameron@huawei.com; kvm@vger.kernel.org; linux- kernel@vger.kernel.org; linuxarm@openeuler.org Subject: Re: [PATCH v11 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver

[...]

...

...

...

• seq_printf(seq,

•  "acc device:\n"
  

•  "guest driver load: %u\n"
  

•  "device opened: %d\n"
  

•  "migrate data length: %lu\n",
  

•  hisi_acc_vdev->vf_qm_state,
  

•  hisi_acc_vdev->dev_opened,
  

•  debug_migf->total_length);
  

This debugfs entry is described as returning the data from the last migration, but vf_qm_state and dev_opened are relative to the current device/guest driver state. Both seem to have no relevance to the data in debug_migf.

The benefit of dev_opened retention is that user can obtain the device

status

...

during the cat migf_data operation.

I will remove dev_opened in the next version. And hisi_acc_vdev->vf_qm_state is changed to debug_migf-

...

vf_data.vf_qm_state

Keep information about whether the device driver in the Guest OS is loaded when live migration occurs.

I think you already get that when you dump debug_migf->vf_data. So not required.

Thanks, Shameer