- Virt - mailweb.openeuler.org

[PATCH hulk-4.19-next] KVM: Boost vCPUs that are delivering interrupts
by Zengruan Ye 04 Aug '20

04 Aug '20

From: Wanpeng Li <wanpengli(a)tencent.com> mainline inclusion from mainline-v5.8-rc5 commit d73eb57b80b98ae147e4e6a7d9877c2ba175f972 category: feature bugzilla: NA DTS: NA CVE: NA -------------------------------- Inspired by commit 9cac38dd5d (KVM/s390: Set preempted flag during vcpu wakeup and interrupt delivery), we want to also boost not just lock holders but also vCPUs that are delivering interrupts. Most smp_call_function_many calls are synchronous, so the IPI target vCPUs are also good yield candidates. This patch introduces vcpu->ready to boost vCPUs during wakeup and interrupt delivery time; unlike s390 we do not reuse vcpu->preempted so that voluntarily preempted vCPUs are taken into account by kvm_vcpu_on_spin, but vmx_vcpu_pi_put is not affected (VT-d PI handles voluntary preemption separately, in pi_pre_block). Testing on 80 HT 2 socket Xeon Skylake server, with 80 vCPUs VM 80GB RAM: ebizzy -M vanilla boosting improved 1VM 21443 23520 9% 2VM 2800 8000 180% 3VM 1800 3100 72% Testing on my Haswell desktop 8 HT, with 8 vCPUs VM 8GB RAM, two VMs, one running ebizzy -M, the other running 'stress --cpu 2': w/ boosting + w/o pv sched yield(vanilla) vanilla boosting improved 1570 4000 155% w/ boosting + w/ pv sched yield(vanilla) vanilla boosting improved 1844 5157 179% w/o boosting, perf top in VM: 72.33% [kernel] [k] smp_call_function_many 4.22% [kernel] [k] call_function_i 3.71% [kernel] [k] async_page_fault w/ boosting, perf top in VM: 38.43% [kernel] [k] smp_call_function_many 6.31% [kernel] [k] async_page_fault 6.13% libc-2.23.so [.] __memcpy_avx_unaligned 4.88% [kernel] [k] call_function_interrupt Cc: Paolo Bonzini <pbonzini(a)redhat.com> Cc: Radim Krčmář <rkrcmar(a)redhat.com> Cc: Christian Borntraeger <borntraeger(a)de.ibm.com> Cc: Paul Mackerras <paulus(a)ozlabs.org> Cc: Marc Zyngier <maz(a)kernel.org> Signed-off-by: Wanpeng Li <wanpengli(a)tencent.com> Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> --- arch/s390/kvm/interrupt.c | 2 +- include/linux/kvm_host.h | 1 + virt/kvm/kvm_main.c | 12 ++++++++---- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c index 9dde4d7d8704..26f8bf4a22a7 100644 --- a/arch/s390/kvm/interrupt.c +++ b/arch/s390/kvm/interrupt.c @@ -1240,7 +1240,7 @@ void kvm_s390_vcpu_wakeup(struct kvm_vcpu *vcpu) * The vcpu gave up the cpu voluntarily, mark it as a good * yield-candidate. */ - vcpu->preempted = true; + vcpu->ready = true; swake_up_one(&vcpu->wq); vcpu->stat.halt_wakeup++; } diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index c5da875f19e3..5c5b5867024c 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -318,6 +318,7 @@ struct kvm_vcpu { } spin_loop; #endif bool preempted; + bool ready; struct kvm_vcpu_arch arch; struct dentry *debugfs_dentry; }; diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index b4ab59dd6846..887f3b0c2b60 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -314,6 +314,7 @@ int kvm_vcpu_init(struct kvm_vcpu *vcpu, struct kvm *kvm, unsigned id) kvm_vcpu_set_in_spin_loop(vcpu, false); kvm_vcpu_set_dy_eligible(vcpu, false); vcpu->preempted = false; + vcpu->ready = false; r = kvm_arch_vcpu_init(vcpu); if (r < 0) @@ -2387,6 +2388,7 @@ bool kvm_vcpu_wake_up(struct kvm_vcpu *vcpu) wqp = kvm_arch_vcpu_wq(vcpu); if (swq_has_sleeper(wqp)) { swake_up_one(wqp); + WRITE_ONCE(vcpu->ready, true); ++vcpu->stat.halt_wakeup; return true; } @@ -2500,7 +2502,7 @@ void kvm_vcpu_on_spin(struct kvm_vcpu *me, bool yield_to_kernel_mode) continue; } else if (pass && i > last_boosted_vcpu) break; - if (!READ_ONCE(vcpu->preempted)) + if (!READ_ONCE(vcpu->ready)) continue; if (vcpu == me) continue; @@ -4203,8 +4205,8 @@ static void kvm_sched_in(struct preempt_notifier *pn, int cpu) { struct kvm_vcpu *vcpu = preempt_notifier_to_vcpu(pn); - if (vcpu->preempted) - vcpu->preempted = false; + vcpu->preempted = false; + WRITE_ONCE(vcpu->ready, false); kvm_arch_sched_in(vcpu, cpu); @@ -4216,8 +4218,10 @@ static void kvm_sched_out(struct preempt_notifier *pn, { struct kvm_vcpu *vcpu = preempt_notifier_to_vcpu(pn); - if (current->state == TASK_RUNNING) + if (current->state == TASK_RUNNING) { vcpu->preempted = true; + WRITE_ONCE(vcpu->ready, true); + } kvm_arch_vcpu_put(vcpu); } -- 2.19.1

2 1

【Meeting Notice】Virt sig meeting Time: 2020-07-31 14:30-16:30
by Chenzhendong (alex) 30 Jul '20

30 Jul '20

Virt sig会议议程： 1、openEuler 20.09 虚拟化特性进展 alexchen 2、EulerRobot质量体系构建进展 kuhnchen 3、virt 技术路标讨论 all -------- 原始邮件 -------- 发件人： Meeting Book <uMeeting(a)huawei.com<mailto:uMeeting@huawei.com>> 日期： 2020年7月30日周四 10:12 收件人： zdchenhn(a)163.com<mailto:zdchenhn@163.com> 主题：【Meeting Notice】Virt sig meeting Time: 2020-07-31 14:30-16:30 Topic Virt sig meeting Time 2020-07-31 14:30-16:30((UTC+08:00)Beijing) Join Conference Join (External) >><https://welink-meeting.zoom.us/j/623832541> Meeting ID 623 832 541 Convener 陈振东 Tips: Dial the access number to join conference<http://app.huawei.com/eshare/voiceMeetings> 注：仅支持部分国家和地区。( Only some countries and regions are supported.) 如果加入会议提示“会议已结束或会议号不存在”，请在官网下载最新版本入会。立即下载<https://zoom.us/download> If a message is displayed, indicating that the meeting has ended or the meeting ID does not exist, download the latest meeting client and try again.Download<https://zoom.us/download>

1 0

[PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters
by Ying Fang 29 Jul '20

29 Jul '20

From: fangying <fangying1(a)huawei.com> When qemu or qemu-nbd process that uses a qcow2 file and configured with 'cache = none', it will write to the qcow2 file which uses qcow2 with a cache to cache L2 tables, the process will not use L2 tables without explicitly calling the flush command or closing the mirror flash into the disk. Which causes the disk data to be inconsistent with the written data for a long time. If an abnormal process exit occurs here, the written data will be lost. Therefore, we need to flush the changes to the L2 entry to the disk in time for the newly allocated cluster. Signed-off-by: Ying Fang <fangying1(a)huawei.com> diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index 7444b9c4ab..ab6e812c84 100644 --- a/block/qcow2-cache.c +++ b/block/qcow2-cache.c @@ -266,6 +266,22 @@ int qcow2_cache_flush(BlockDriverState *bs, Qcow2Cache *c) return result; } +#define L2_ENTRIES_PER_SECTOR 64 +int qcow2_cache_l2_write_entry(BlockDriverState *bs, Qcow2Cache *c, + void *table, int index, int num) +{ + int ret; + int i = qcow2_cache_get_table_idx(c, table); + int start_sector = index / L2_ENTRIES_PER_SECTOR; + int end_sector = (index + num - 1) / L2_ENTRIES_PER_SECTOR; + int nr_sectors = end_sector - start_sector + 1; + ret = bdrv_pwrite(bs->file, + c->entries[i].offset + start_sector * BDRV_SECTOR_SIZE, + table + start_sector * BDRV_SECTOR_SIZE, + nr_sectors * BDRV_SECTOR_SIZE); + return ret; +} + int qcow2_cache_set_dependency(BlockDriverState *bs, Qcow2Cache *c, Qcow2Cache *dependency) { diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index a677ba9f5c..ae49a83972 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -998,6 +998,9 @@ int qcow2_alloc_cluster_link_l2(BlockDriverState *bs, QCowL2Meta *m) } + ret = qcow2_cache_l2_write_entry(bs, s->l2_table_cache, l2_slice, + l2_index, m->nb_clusters); + qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice); /* diff --git a/block/qcow2.h b/block/qcow2.h index 7ce2c23bdb..168ab5918e 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -748,6 +748,8 @@ int qcow2_cache_destroy(Qcow2Cache *c); void qcow2_cache_entry_mark_dirty(Qcow2Cache *c, void *table); int qcow2_cache_flush(BlockDriverState *bs, Qcow2Cache *c); int qcow2_cache_write(BlockDriverState *bs, Qcow2Cache *c); +int qcow2_cache_l2_write_entry(BlockDriverState *bs, Qcow2Cache *c, + void *table, int index, int num); int qcow2_cache_set_dependency(BlockDriverState *bs, Qcow2Cache *c, Qcow2Cache *dependency); void qcow2_cache_depends_on_flush(Qcow2Cache *c); -- 2.23.0

1 0

Re: openEuler kata补丁
by Zhanghailiang 20 Jul '20

20 Jul '20

From: zhangliang (AG) Sent: Monday, July 20, 2020 11:26 AM To: Zhanghailiang <zhang.zhanghailiang(a)huawei.com>; openeuler(a)126.com; virt(a)openeuler.org Subject: openEuler kata补丁

1 0

Re: 上传到openEuler的kata补丁
by Zhanghailiang 17 Jul '20

17 Jul '20

From: zhangliang (AG) Sent: Friday, July 17, 2020 11:50 AM To: openeuler(a)126.com; virt(a)openeuler.org Cc: Wubin (H) <wu.wubin(a)huawei.com>; wangzhigang (O) <wangzhigang17(a)huawei.com>; Zhanghailiang <zhang.zhanghailiang(a)huawei.com> Subject: 上传到openEuler的kata补丁上传到openEuler的kata补丁

1 0

Virt meeting 会议纪要-0713//RE: 【Meeting Notice】virt sig meeting Time: 2020-07-10 14:15-16:15
by Chenzhendong (alex) 14 Jul '20

14 Jul '20

Virt meeting 会议纪要-0713： openEuler 20.09特性进展 1． KVM支持custom模式---zhanghailiang cpu custom原型完成，正在修改代码，当前仅实现feature的disable，enable，无特性相互依赖的判断处理，当前增加一个与内核交互接口 2． kvmtop---nocjj 完成x86环境适配，精简了部分代码，完成makefile编写，spec编写，增加了虚拟机状态统计功能 3． SmartPolling---miaoyubo Guest halt polling arm侧代码开发及调试，完成60% 4．支持SDEI设备---待定正在分析开源方案 5．双层调度---fanhenglong 6．锁优化---YeZengruan vCPU preempted check和PV qspinlock补丁已完成rebase，补丁先发到openeuler review 7．安全启动---待定 8．可信启动---JackJF 可信启动（aarch64 + vTPM + EDK中使能可信启动）的原型系统功能已经验证过。具体包括Libvirt拉起VM + vTPM，VM暂停启动，快照启动，热迁移。下一步将开源QEMU和EDK2回合到openEuler版本中；确认社区中的Libvrit支持aarch64 vTPM的情况或将目前该更代码提交到openEuler仓库中。 9．热补丁---FangYing 针对qemu场景里面的主线程、IO线程、协程、热迁移线程、vnc线程、vcpu线程和TLS进行热补丁验证，验证结果表示libcare热补丁支持上述场景下的热补丁基本功能。当前rcu线程比较特殊，还不支持热补丁应用，object_patch_verify_safety_single阶段出错导致补丁无法成功激活，正在解决。 From: Chenzhendong (alex) via Virt [mailto:virt@openeuler.org] Sent: Wednesday, July 8, 2020 11:57 AM To: virt(a)openeuler.org; dev(a)openeuler.org; tc(a)openeuler.org Subject: [Virt] 【Meeting Notice】virt sig meeting Time: 2020-07-10 14:15-16:15 virt会议议程： 1．Virt sig事务跟踪 a) qemu/libvirt 代码仓库从src-openeuler切换到openeuelr 2．openEuler 20.09特性进展 a) KVM支持custom模式---zhanghailiang b) kvmtop---nocjj c) SmartPolling---miaoyubo d) 支持SDEI设备---待定 e) 双层调度---fanhenglong f) 锁优化---YeZengruan g) 安全启动---待定 h) 可信启动---JackJF i) 热补丁---FangYing -------- 原始邮件 -------- 发件人： Meeting Book <uMeeting(a)huawei.com<mailto:uMeeting@huawei.com>> 日期： 2020年7月8日周三 11:11 收件人： zdchenhn(a)163.com<mailto:zdchenhn@163.com> 主题：【Meeting Notice】virt sig meeting Time: 2020-07-10 14:15-16:15 Topic virt sig meeting Time 2020-07-10 14:15-16:15((UTC+08:00)Beijing) Join Conference Join (External) >><https://welink-meeting.zoom.us/j/883868749> Meeting ID 883 868 749 Convener 陈振东 Tips: Dial the access number to join conference<http://app.huawei.com/eshare/voiceMeetings> 注：仅支持部分国家和地区。( Only some countries and regions are supported.) 如果加入会议提示“会议已结束或会议号不存在”，请在官网下载最新版本入会。立即下载<https://zoom.us/download> If a message is displayed, indicating that the meeting has ended or the meeting ID does not exist, download the latest meeting client and try again.Download<https://zoom.us/download>

1 0

【Meeting Notice】virt sig meeting Time: 2020-07-10 14:15-16:15
by Chenzhendong (alex) 08 Jul '20

08 Jul '20

virt会议议程： 1．Virt sig事务跟踪 a) qemu/libvirt 代码仓库从src-openeuler切换到openeuelr 2．openEuler 20.09特性进展 a) KVM支持custom模式---zhanghailiang b) kvmtop---nocjj c) SmartPolling---miaoyubo d) 支持SDEI设备---待定 e) 双层调度---fanhenglong f) 锁优化---YeZengruan g) 安全启动---待定 h) 可信启动---JackJF i) 热补丁---FangYing -------- 原始邮件 -------- 发件人： Meeting Book <uMeeting(a)huawei.com<mailto:uMeeting@huawei.com>> 日期： 2020年7月8日周三 11:11 收件人： zdchenhn(a)163.com<mailto:zdchenhn@163.com> 主题：【Meeting Notice】virt sig meeting Time: 2020-07-10 14:15-16:15 Topic virt sig meeting Time 2020-07-10 14:15-16:15((UTC+08:00)Beijing) Join Conference Join (External) >><https://welink-meeting.zoom.us/j/883868749> Meeting ID 883 868 749 Convener 陈振东 Tips: Dial the access number to join conference<http://app.huawei.com/eshare/voiceMeetings> 注：仅支持部分国家和地区。( Only some countries and regions are supported.) 如果加入会议提示“会议已结束或会议号不存在”，请在官网下载最新版本入会。立即下载<https://zoom.us/download> If a message is displayed, indicating that the meeting has ended or the meeting ID does not exist, download the latest meeting client and try again.Download<https://zoom.us/download>

1 0

2024

2023

2022

2021

2020

Virt