When a private key is preset via OSSL_PKEY_PARAM_EC_PRIV_KEY, the hardware keygen path skipped upper bound validation. The UADK driver only rejects d <= 1, so priv_k >= order would pass through and produce a non-canonical private key value. Check that priv_key < order before setting it on the hardware session. Signed-off-by: Weili Qian <qianweili@huawei.com> --- src/uadk_prov_ec_kmgmt.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/uadk_prov_ec_kmgmt.c b/src/uadk_prov_ec_kmgmt.c index 2b44d20..932b690 100644 --- a/src/uadk_prov_ec_kmgmt.c +++ b/src/uadk_prov_ec_kmgmt.c @@ -199,8 +199,15 @@ static int ec_set_private_key(EC_KEY *ec, BIGNUM *priv_key) const BIGNUM *order; int cnt = 0; - if (priv_k) + if (priv_k) { + group = EC_KEY_get0_group(ec); + order = EC_GROUP_get0_order(group); + if (BN_cmp(priv_k, order) >= 0) { + UADK_ERR("invalid: preset private key out of range\n"); + return UADK_P_FAIL; + } goto set_key; + } priv_k = BN_secure_new(); if (!priv_k) { -- 2.43.0