Add sig_r/s size check in ecdsa_verify_init_iot before BN_bn2bin writes to the fixed-size stack buffer to prevent overflow. Signed-off-by: Weili Qian <qianweili@huawei.com> --- src/uadk_prov_ecdsa.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/uadk_prov_ecdsa.c b/src/uadk_prov_ecdsa.c index 032bc2a..bd7ca73 100644 --- a/src/uadk_prov_ecdsa.c +++ b/src/uadk_prov_ecdsa.c @@ -737,6 +737,11 @@ static int ecdsa_verify_init_iot(handle_t sess, struct wd_ecc_req *req, r.bsize = UADK_ECC_MAX_KEY_BYTES; s.bsize = UADK_ECC_MAX_KEY_BYTES; ECDSA_SIG_get0(opdata->sig, &sig_r, &sig_s); + if (BN_num_bytes(sig_r) > UADK_ECC_MAX_KEY_BYTES || + BN_num_bytes(sig_s) > UADK_ECC_MAX_KEY_BYTES) { + UADK_ERR("invalid: sig_r/s too large\n"); + return UADK_P_FAIL; + } r.dsize = BN_bn2bin(sig_r, (void *)r.data); s.dsize = BN_bn2bin(sig_s, (void *)s.data); ecc_in = wd_ecdsa_new_verf_in(sess, &e, &r, &s); -- 2.43.0