November 2024 - Kernel - mailweb.openeuler.org

[openeuler:OLK-6.6 1540/1540] arch/arm64/kvm/../../../virt/kvm/vfio.c:581:5: warning: no previous prototype for 'cvm_smmu_domain_judge'
by kernel test robot 28 Nov '24

28 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 95bc69473a373c2e578d4fc39734e5811a03ead3 commit: ad540a13eb8292fc92651b3bf281088a502a85f9 [1540/1540] virtcca feature: fix msi iova map config: arm64-randconfig-002-20241128 (https://download.01.org/0day-ci/archive/20241128/202411282114.3K6QSB4D-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/202411282114.3K6QSB4D-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411282114.3K6QSB4D-lkp@intel.com/ All warnings (new ones prefixed by >>): arch/arm64/kvm/../../../virt/kvm/vfio.c:518:5: warning: no previous prototype for 'find_arm_smmu_domain' [-Wmissing-prototypes] 518 | int find_arm_smmu_domain(struct device *dev, void *data) | ^~~~~~~~~~~~~~~~~~~~ >> arch/arm64/kvm/../../../virt/kvm/vfio.c:581:5: warning: no previous prototype for 'cvm_smmu_domain_judge' [-Wmissing-prototypes] 581 | int cvm_smmu_domain_judge(struct device *dev, void *data) | ^~~~~~~~~~~~~~~~~~~~~ >> arch/arm64/kvm/../../../virt/kvm/vfio.c:599:5: warning: no previous prototype for 'virtcca_cvm_smmu_domain_judge' [-Wmissing-prototypes] 599 | int virtcca_cvm_smmu_domain_judge(struct iommu_group *group, struct arm_smmu_domain *smmu_domain) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> arch/arm64/kvm/../../../virt/kvm/vfio.c:616:5: warning: no previous prototype for 'virtcca_iommu_group_map_msi_address' [-Wmissing-prototypes] 616 | int virtcca_iommu_group_map_msi_address(struct kvm *kvm, struct kvm_vfio_file *kvf, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- arch/arm64/kvm/virtcca_cvm.c:963:5: warning: no previous prototype for 'kvm_cvm_create_dev_ttt_levels' [-Wmissing-prototypes] 963 | int kvm_cvm_create_dev_ttt_levels(struct kvm *kvm, struct virtcca_cvm *cvm, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> arch/arm64/kvm/virtcca_cvm.c:1193:5: warning: no previous prototype for 'cvm_arm_smmu_domain_set_kvm' [-Wmissing-prototypes] 1193 | int cvm_arm_smmu_domain_set_kvm(struct device *dev, void *data) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ -- >> drivers/coda/coda_vfio.c:323:5: warning: no previous prototype for 'virtcca_set_dev_msi_addr' [-Wmissing-prototypes] 323 | int virtcca_set_dev_msi_addr(struct device *dev, void *iova) | ^~~~~~~~~~~~~~~~~~~~~~~~ -- >> drivers/coda/coda.c:478:5: warning: no previous prototype for 'virtcca_secure_dev_operator' [-Wmissing-prototypes] 478 | int virtcca_secure_dev_operator(struct device *dev, void *domain) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ -- drivers/iommu/arm/arm-smmu-v3/arm-s-smmu-v3.c:330:13: warning: no previous prototype for 'virtcca_smmu_gerror_handler' [-Wmissing-prototypes] 330 | irqreturn_t virtcca_smmu_gerror_handler(int irq, void *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/iommu/arm/arm-smmu-v3/arm-s-smmu-v3.c:588:6: warning: no previous prototype for 'virtcca_smmu_map_init' [-Wmissing-prototypes] 588 | bool virtcca_smmu_map_init(struct arm_smmu_device *smmu, resource_size_t ioaddr) | ^~~~~~~~~~~~~~~~~~~~~ vim +/cvm_smmu_domain_judge +581 arch/arm64/kvm/../../../virt/kvm/vfio.c 512 513 /** 514 * find_arm_smmu_domain - Find smmu domain list from kvm vfio file 515 * @kvf: Kvm vfio file 516 * @smmu_domain_group_list: List of smmu domain group 517 */ > 518 int find_arm_smmu_domain(struct device *dev, void *data) 519 { 520 int ret = 0; 521 struct iommu_domain *domain = NULL; 522 struct arm_smmu_domain *arm_smmu_domain = NULL; 523 struct arm_smmu_domain *arm_smmu_domain_node = NULL; 524 struct list_head *smmu_domain_group_list = (struct list_head *)data; 525 526 domain = iommu_get_domain_for_dev(dev); 527 arm_smmu_domain = to_smmu_domain(domain); 528 list_for_each_entry(arm_smmu_domain_node, 529 smmu_domain_group_list, node) { 530 if (arm_smmu_domain_node == arm_smmu_domain) { 531 ret = -1; 532 break; 533 } 534 } 535 if (!ret) 536 list_add_tail(&arm_smmu_domain->node, smmu_domain_group_list); 537 538 return 1; 539 } 540 541 /** 542 * kvm_get_arm_smmu_domain - Find kvm vfio file from kvm 543 * @kvm: Kvm handle 544 * @smmu_domain_group_list: List of smmu domain group 545 */ 546 void kvm_get_arm_smmu_domain(struct kvm *kvm, struct list_head *smmu_domain_group_list) 547 { 548 struct kvm_device *dev; 549 struct kvm_vfio *kv; 550 struct kvm_vfio_file *kvf; 551 struct iommu_group *iommu_group = NULL; 552 553 INIT_LIST_HEAD(smmu_domain_group_list); 554 555 list_for_each_entry(dev, &kvm->devices, vm_node) { 556 /* The device name passed through the vfio driver is called kvm-vfio */ 557 if (dev->ops && strcmp(dev->ops->name, "kvm-vfio") != 0) 558 continue; 559 560 kv = (struct kvm_vfio *)dev->private; 561 mutex_lock(&kv->lock); 562 list_for_each_entry(kvf, &kv->file_list, node) { 563 iommu_group = cvm_vfio_file_iommu_group(kvf->file); 564 iommu_group_for_each_dev(iommu_group, 565 (void *)smmu_domain_group_list, find_arm_smmu_domain); 566 } 567 mutex_unlock(&kv->lock); 568 } 569 } 570 571 /** 572 * cvm_smmu_domain_judge - Find the iommu group corresponding to the smmu domain 573 * @dev: The handle of device 574 * @data: Smmu domain 575 * 576 * Returns: 577 * %-ENXIO if domain is null 578 * %SMMU_DOMAIN_IS_SAME if find the iommu group corresponding to the smmu domain 579 * %1 if does not find the iommu group 580 */ > 581 int cvm_smmu_domain_judge(struct device *dev, void *data) 582 { 583 struct iommu_domain *domain = NULL; 584 struct arm_smmu_domain *arm_smmu_domain = NULL; 585 struct arm_smmu_domain *smmu_domain = (struct arm_smmu_domain *)data; 586 587 domain = iommu_get_domain_for_dev(dev); 588 if (!domain) 589 return -ENXIO; 590 591 arm_smmu_domain = to_smmu_domain(domain); 592 if (arm_smmu_domain == smmu_domain) 593 return SMMU_DOMAIN_IS_SAME; 594 595 return 1; 596 } 597 598 /* Judge the iommu group correspond to the smmu domain */ > 599 int virtcca_cvm_smmu_domain_judge(struct iommu_group *group, struct arm_smmu_domain *smmu_domain) 600 { 601 int ret; 602 603 ret = iommu_group_for_each_dev((struct iommu_group *)group, 604 (void *)smmu_domain, cvm_smmu_domain_judge); 605 return ret; 606 } 607 608 /** 609 * virtcca_iommu_group_map_msi_address - Find iommu group from kvm vfio file, map it 610 * @kvm: The handle of kvm 611 * @kvf: Kvm vfio file 612 * @smmu_domain: Smmu domain 613 * @pa: Physical address 614 * @map_size: Mapped size 615 */ > 616 int virtcca_iommu_group_map_msi_address(struct kvm *kvm, struct kvm_vfio_file *kvf, 617 struct arm_smmu_domain *smmu_domain, phys_addr_t pa, unsigned long map_size) 618 { 619 unsigned long iova; 620 int ret = 0; 621 struct iommu_group *iommu_group = NULL; 622 623 iommu_group = cvm_vfio_file_iommu_group(kvf->file); 624 if (iommu_group) { 625 if (virtcca_cvm_smmu_domain_judge(iommu_group, smmu_domain) == 626 SMMU_DOMAIN_IS_SAME) { 627 iova = virtcca_get_iommu_device_msi_addr(iommu_group); 628 if (!iova) 629 return -ENXIO; 630 631 ret = virtcca_iommu_group_set_dev_msi_addr(iommu_group, &iova); 632 if (ret) 633 return ret; 634 635 ret = cvm_map_unmap_ipa_range(kvm, iova, pa, map_size, true); 636 if (ret) 637 return ret; 638 } 639 } 640 return ret; 641 } 642 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1315/1315] arch/arm64/kernel/smp.c:1124:14: error: 'pmu_nmi_enable' undeclared; did you mean 'perf_pmu_enable'?
by kernel test robot 28 Nov '24

28 Nov '24

Hi Yang, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: b5504db0db8375a77340b5bb54c17cfb75d3c754 commit: 9f05210dfee3a2319a61302f9bfd7317b522fa96 [1315/1315] arm64: perf: add pmu_nmi_enable to control pmu nmi support config: arm64-randconfig-002-20241128 (https://download.01.org/0day-ci/archive/20241128/202411282147.aYnkuR6v-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/202411282147.aYnkuR6v-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411282147.aYnkuR6v-lkp@intel.com/ All errors (new ones prefixed by >>): arch/arm64/kernel/smp.c:840:6: warning: no previous prototype for 'arch_irq_work_raise' [-Wmissing-prototypes] 840 | void arch_irq_work_raise(void) | ^~~~~~~~~~~~~~~~~~~ arch/arm64/kernel/smp.c:1053:5: warning: no previous prototype for 'setup_profiling_timer' [-Wmissing-prototypes] 1053 | int setup_profiling_timer(unsigned int multiplier) | ^~~~~~~~~~~~~~~~~~~~~ arch/arm64/kernel/smp.c: In function 'hw_nmi_get_sample_period': >> arch/arm64/kernel/smp.c:1124:14: error: 'pmu_nmi_enable' undeclared (first use in this function); did you mean 'perf_pmu_enable'? 1124 | if (!pmu_nmi_enable) | ^~~~~~~~~~~~~~ | perf_pmu_enable arch/arm64/kernel/smp.c:1124:14: note: each undeclared identifier is reported only once for each function it appears in In file included from include/linux/kernel.h:14, from include/linux/list.h:9, from include/linux/resource_ext.h:17, from include/linux/acpi.h:26, from arch/arm64/kernel/smp.c:20: arch/arm64/kernel/smp.c: In function '__cpu_up': include/linux/printk.h:346:9: warning: this statement may fall through [-Wimplicit-fallthrough=] 346 | printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/arm64/kernel/smp.c:169:25: note: in expansion of macro 'pr_crit' 169 | pr_crit("CPU%u: may not have shut down cleanly\n", cpu); | ^~~~~~~ arch/arm64/kernel/smp.c:170:17: note: here 170 | case CPU_STUCK_IN_KERNEL: | ^~~~ arch/arm64/kernel/smp.c: In function 'hw_nmi_get_sample_period': arch/arm64/kernel/smp.c:1128:1: warning: control reaches end of non-void function [-Wreturn-type] 1128 | } | ^ vim +1124 arch/arm64/kernel/smp.c 1121 1122 u64 hw_nmi_get_sample_period(int watchdog_thresh) 1123 { > 1124 if (!pmu_nmi_enable) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6] genirq/proc: Fix warning of no previous prototype for register_irqchip_proc()
by Jinjie Ruan 28 Nov '24

28 Nov '24

Fix the following warnings by add the proper header. kernel/irq/proc.c:334:13: warning: no previous prototype for function 'register_irqchip_proc' [-Wmissing-prototypes] 334 | void __weak register_irqchip_proc(struct irq_desc *desc, void *irqp) { } | ^ kernel/irq/proc.c:334:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 334 | void __weak register_irqchip_proc(struct irq_desc *desc, void *irqp) { } | ^ | static kernel/irq/proc.c:335:13: warning: no previous prototype for function 'unregister_irqchip_proc' [-Wmissing-prototypes] 335 | void __weak unregister_irqchip_proc(struct irq_desc *desc) { } | ^ kernel/irq/proc.c:335:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 335 | void __weak unregister_irqchip_proc(struct irq_desc *desc) { } | ^ | static 2 warnings generated. Fixes: 3053668e6b21 ("arm64: Introduce Xint software solution") Signed-off-by: Jinjie Ruan <ruanjinjie(a)huawei.com> --- kernel/irq/proc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index 0fdfde11ab81..2bb1769cf432 100644 --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c @@ -13,6 +13,10 @@ #include <linux/kernel_stat.h> #include <linux/mutex.h> +#ifdef CONFIG_FAST_IRQ +#include <linux/irqchip/arm-gic-v3.h> +#endif + #include "internals.h" /* -- 2.34.1

2 1

[PATCH OLK-6.6] genirq/proc: Fix warning of no previous prototype for register_irqchip_proc()
by Jinjie Ruan 28 Nov '24

28 Nov '24

Fix the following warnings by add the proper header. kernel/irq/proc.c:334:13: warning: no previous prototype for function 'register_irqchip_proc' [-Wmissing-prototypes] 334 | void __weak register_irqchip_proc(struct irq_desc *desc, void *irqp) { } | ^ kernel/irq/proc.c:334:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 334 | void __weak register_irqchip_proc(struct irq_desc *desc, void *irqp) { } | ^ | static kernel/irq/proc.c:335:13: warning: no previous prototype for function 'unregister_irqchip_proc' [-Wmissing-prototypes] 335 | void __weak unregister_irqchip_proc(struct irq_desc *desc) { } | ^ kernel/irq/proc.c:335:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 335 | void __weak unregister_irqchip_proc(struct irq_desc *desc) { } | ^ | static 2 warnings generated. Signed-off-by: Jinjie Ruan <ruanjinjie(a)huawei.com> --- kernel/irq/proc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index 0fdfde11ab81..2bb1769cf432 100644 --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c @@ -13,6 +13,10 @@ #include <linux/kernel_stat.h> #include <linux/mutex.h> +#ifdef CONFIG_FAST_IRQ +#include <linux/irqchip/arm-gic-v3.h> +#endif + #include "internals.h" /* -- 2.34.1

2 1

[PATCH OLK-6.6 00/16] Support haltpoll feature
by lishusen 28 Nov '24

28 Nov '24

Support haltpoll feature to improve performance Ankur Arora (10): asm-generic: add barrier smp_cond_load_relaxed_timeout() cpuidle/poll_state: poll via smp_cond_load_relaxed_timeout() cpuidle: rename ARCH_HAS_CPU_RELAX to ARCH_HAS_OPTIMIZED_POLL arm64: barrier: add support for smp_cond_relaxed_timeout() arm64: add support for polling in idle cpuidle-haltpoll: condition on ARCH_CPUIDLE_HALTPOLL arm64: idle: export arch_cpu_idle arm64: support cpuidle-haltpoll arm64/delay: move some constants out to a separate header arm64: support WFET in smp_cond_relaxed_timeout() Joao Martins (4): Kconfig: move ARCH_HAS_OPTIMIZED_POLL to arch/Kconfig arm64: define TIF_POLLING_NRFLAG cpuidle-haltpoll: define arch_haltpoll_want() governors/haltpoll: drop kvm_para_available() check Lifeng Zheng (1): ACPI: processor_idle: Support polling state for LPI lishusen (1): cpuidle: edit cpuidle-haltpoll driver module parameter arch/Kconfig | 3 + arch/arm64/Kconfig | 7 ++ arch/arm64/include/asm/barrier.h | 62 ++++++++++++- arch/arm64/include/asm/cmpxchg.h | 26 ++++-- arch/arm64/include/asm/cpuidle_haltpoll.h | 20 +++++ arch/arm64/include/asm/delay-const.h | 25 ++++++ arch/arm64/include/asm/thread_info.h | 2 + arch/arm64/kernel/idle.c | 1 + arch/arm64/lib/delay.c | 13 +-- arch/x86/Kconfig | 5 +- arch/x86/include/asm/cpuidle_haltpoll.h | 1 + arch/x86/kernel/kvm.c | 13 +++ drivers/acpi/processor_idle.c | 43 +++++++-- drivers/cpuidle/Kconfig | 5 +- drivers/cpuidle/Makefile | 2 +- drivers/cpuidle/cpuidle-haltpoll.c | 105 +++++++++++++++++++--- drivers/cpuidle/governors/haltpoll.c | 6 +- drivers/cpuidle/poll_state.c | 31 +++---- drivers/idle/Kconfig | 1 + include/asm-generic/barrier.h | 42 +++++++++ include/linux/cpuidle.h | 2 +- include/linux/cpuidle_haltpoll.h | 5 ++ 22 files changed, 346 insertions(+), 74 deletions(-) create mode 100644 arch/arm64/include/asm/cpuidle_haltpoll.h create mode 100644 arch/arm64/include/asm/delay-const.h -- 2.33.0

2 17

[PATCH OLK-6.6 0/2] fix CVE-2024-49861
by Xiaomeng Zhang 28 Nov '24

28 Nov '24

*** BLURB HERE *** Daniel Borkmann (1): bpf: Fix helper writes to read-only maps Xiaomeng Zhang (1): bpf: Fix kabi breakage in enum bpf_type_flag and bpf_arg_type include/linux/bpf.h | 11 +++++++++-- kernel/bpf/helpers.c | 6 ++++-- kernel/bpf/syscall.c | 3 ++- kernel/bpf/verifier.c | 41 +++++----------------------------------- kernel/trace/bpf_trace.c | 6 ++++-- net/core/filter.c | 6 ++++-- 6 files changed, 28 insertions(+), 45 deletions(-) -- 2.34.1

2 3

[PATCH OLK-6.6 V1] media: dvbdev: fix the logic when DVB_DYNAMIC_MINORS is not set
by Zicheng Qu 28 Nov '24

28 Nov '24

From: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org> stable inclusion from stable-v6.6.63 commit db12e874e1a202206c734d89920e4aa9e290efa2 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IB5KR8 CVE: CVE-2024-53063 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- commit a4aebaf6e6efff548b01a3dc49b4b9074751c15b upstream. When CONFIG_DVB_DYNAMIC_MINORS, ret is not initialized, and a semaphore is left at the wrong state, in case of errors. Make the code simpler and avoid mistakes by having just one error check logic used weather DVB_DYNAMIC_MINORS is used or not. Reported-by: kernel test robot <lkp(a)intel.com> Reported-by: Dan Carpenter <dan.carpenter(a)linaro.org> Closes: https://lore.kernel.org/r/202410201717.ULWWdJv8-lkp@intel.com/ Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org> Link: https://lore.kernel.org/r/9e067488d8935b8cf00959764a1fa5de85d65725.17309262… Cc: Nathan Chancellor <nathan(a)kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Zicheng Qu <quzicheng(a)huawei.com> --- drivers/media/dvb-core/dvbdev.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index 14f323fbada7..9df7c213716a 100644 --- a/drivers/media/dvb-core/dvbdev.c +++ b/drivers/media/dvb-core/dvbdev.c @@ -530,6 +530,9 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, for (minor = 0; minor < MAX_DVB_MINORS; minor++) if (!dvb_minors[minor]) break; +#else + minor = nums2minor(adap->num, type, id); +#endif if (minor >= MAX_DVB_MINORS) { if (new_node) { list_del(&new_node->list_head); @@ -543,17 +546,7 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, mutex_unlock(&dvbdev_register_lock); return -EINVAL; } -#else - minor = nums2minor(adap->num, type, id); - if (minor >= MAX_DVB_MINORS) { - dvb_media_device_free(dvbdev); - list_del(&dvbdev->list_head); - kfree(dvbdev); - *pdvbdev = NULL; - mutex_unlock(&dvbdev_register_lock); - return ret; - } -#endif + dvbdev->minor = minor; dvb_minors[minor] = dvb_device_get(dvbdev); up_write(&minor_rwsem); -- 2.34.1

2 1

[openeuler:OLK-6.6 1540/1540] drivers/net/ethernet/huawei/hinic3/cqm/cqm_bitmap_table.c:371:3: error: a randomized struct can only be initialized with a designated initializer
by kernel test robot 28 Nov '24

28 Nov '24

Hi Shuai, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 7f63ebb23914c3b2e597112d96eba6edb440e907 commit: 4213ff7957de370c1cfe528c2bad1eb2e499038a [1540/1540] net/ethernet/huawei/hinic3: Add the CQM on which the RDMA depends config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20241128/202411281914.t5QmcnnC-lkp@…) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/202411281914.t5QmcnnC-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411281914.t5QmcnnC-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from drivers/net/ethernet/huawei/hinic3/cqm/cqm_bitmap_table.c:6: In file included from include/linux/pci.h:1663: In file included from include/linux/dmapool.h:14: In file included from include/linux/scatterlist.h:8: In file included from include/linux/mm.h:2204: include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 508 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 509 | item]; | ~~~~ include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 515 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 516 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 527 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 528 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 536 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 537 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/huawei/hinic3/cqm/cqm_bitmap_table.c:371:3: error: a randomized struct can only be initialized with a designated initializer 371 | {check_for_use_node_alloc, cqm_buf_use_node_alloc_page}, | ^ drivers/net/ethernet/huawei/hinic3/cqm/cqm_bitmap_table.c:372:3: error: a randomized struct can only be initialized with a designated initializer 372 | {check_for_nouse_node_alloc, cqm_buf_unused_node_alloc_page} | ^ drivers/net/ethernet/huawei/hinic3/cqm/cqm_bitmap_table.c:376:3: error: a randomized struct can only be initialized with a designated initializer 376 | {check_use_non_vram, cqm_buf_free_page_common} | ^ drivers/net/ethernet/huawei/hinic3/cqm/cqm_bitmap_table.c:382:25: error: invalid application of 'sizeof' to an incomplete type 'const struct malloc_memory[]' 382 | u32 malloc_funcs_num = ARRAY_SIZE(g_malloc_funcs); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:57:32: note: expanded from macro 'ARRAY_SIZE' 57 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) | ^~~~~ drivers/net/ethernet/huawei/hinic3/cqm/cqm_bitmap_table.c:399:23: error: invalid application of 'sizeof' to an incomplete type 'const struct free_memory[]' 399 | u32 free_funcs_num = ARRAY_SIZE(g_free_funcs); | ^~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:57:32: note: expanded from macro 'ARRAY_SIZE' 57 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) | ^~~~~ 5 warnings and 5 errors generated. vim +371 drivers/net/ethernet/huawei/hinic3/cqm/cqm_bitmap_table.c 369 370 static const struct malloc_memory g_malloc_funcs[] = { > 371 {check_for_use_node_alloc, cqm_buf_use_node_alloc_page}, 372 {check_for_nouse_node_alloc, cqm_buf_unused_node_alloc_page} 373 }; 374 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-5.10] arm64: mm: Stop use spinlock during pbha early init
by Wupeng Ma 28 Nov '24

28 Nov '24

From: Ma Wupeng <mawupeng1(a)huawei.com> hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I96IZH -------------------------------- During early_pbha_init() in __primary_switched(), debug spinlock related function is not fully initialized. This will lead to kernel unable to boot with CONFIG_LOCK_STAT=y or related configs. Since kernel is running with only one cpu during startup, there is no need to use lock. Fix it by removing the spinlock. Fixes: f43933b3f947 ("arm64: cpufeature: Enable PBHA for stage1 early via FDT") Signed-off-by: Ma Wupeng <mawupeng1(a)huawei.com> --- arch/arm64/kernel/cpufeature.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index 36a426b0def2..33ece8a97023 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -1796,32 +1796,30 @@ void __init early_pbha_init(void) const u8 *prop; int size; - spin_lock(&pbha_dt_lock); - fdt = get_early_fdt_ptr(); if (!fdt) - goto unlock; + return; /* arm,pbha-performance-only may exist in both chosen and cpus node */ node = fdt_path_offset(fdt, "/chosen"); if (node < 0) - goto unlock; + return; prop = fdt_getprop(fdt, node, "arm,pbha-performance-only", &size); if (prop) - goto found; + return; node = fdt_path_offset(fdt, "/cpus"); if (node < 0) - goto unlock; + return; prop = fdt_getprop(fdt, node, "arm,pbha-performance-only", &size); if (prop) - goto unlock; + return; found: if (!cpu_has_pbha()) - goto unlock; + return; update_pbha_perf_only_bit(prop, size); enable_pbha_inner(); @@ -1829,9 +1827,6 @@ void __init early_pbha_init(void) pbha_enabled = true; early_pbha_bit0_init(); - -unlock: - spin_unlock(&pbha_dt_lock); } /* -- 2.25.1

2 1

[openeuler:openEuler-1.0-LTS 1315/1315] arch/arm64/mm/init.c:784:17: error: 'mem_sleep_current' undeclared
by kernel test robot 28 Nov '24

28 Nov '24

Hi Ding, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: b5504db0db8375a77340b5bb54c17cfb75d3c754 commit: fdda68feeca82610ccbcdcbda7250623a6d187d2 [1315/1315] arm64/ascend: Set mem_sleep_current to PM_SUSPEND_ON for ascend platform config: arm64-randconfig-004-20241128 (https://download.01.org/0day-ci/archive/20241128/202411281817.JPJpYz6h-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/202411281817.JPJpYz6h-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411281817.JPJpYz6h-lkp@intel.com/ All errors (new ones prefixed by >>): arch/arm64/mm/init.c:469:13: warning: no previous prototype for 'arm64_memblock_init' [-Wmissing-prototypes] 469 | void __init arm64_memblock_init(void) | ^~~~~~~~~~~~~~~~~~~ arch/arm64/mm/init.c: In function 'ascend_enable_setup': >> arch/arm64/mm/init.c:784:17: error: 'mem_sleep_current' undeclared (first use in this function) 784 | mem_sleep_current = PM_SUSPEND_ON; | ^~~~~~~~~~~~~~~~~ arch/arm64/mm/init.c:784:17: note: each undeclared identifier is reported only once for each function it appears in vim +/mem_sleep_current +784 arch/arm64/mm/init.c 770 771 #ifdef CONFIG_ASCEND_FEATURES 772 static int __init ascend_enable_setup(char *__unused) 773 { 774 if (IS_ENABLED(CONFIG_ASCEND_DVPP_MMAP)) 775 enable_mmap_dvpp = 1; 776 777 if (IS_ENABLED(CONFIG_ASCEND_IOPF_HIPRI)) 778 enable_iopf_hipri = 1; 779 780 if (IS_ENABLED(CONFIG_ASCEND_CHARGE_MIGRATE_HUGEPAGES)) 781 enable_charge_mighp = 1; 782 783 if (IS_ENABLED(CONFIG_SUSPEND)) > 784 mem_sleep_current = PM_SUSPEND_ON; 785 786 return 1; 787 } 788 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0