- Kernel - mailweb.openeuler.org

[PATCH OLK-6.6] arm64/mpam: Add quirk for cmax and cmin
by Zeng Heng 10 Sep '25

10 Sep '25

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/ICXA3G -------------------------------- According to the ARM MPAM specification, the legal range of CMAX depends on the MPAMF_CCAP_IDR.CMAX_WD field. However, on certain specialized SoCs, the valid CMAX range additionally relies on the length of the cache partition bit mask. To accommodate these chips, the conversion algorithm between ca_max and percent must be adapted so that the values delivered match the intended targets exactly. Fixes: 83c4315c75ba ("arm64/mpam: Add CMAX feature") Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- drivers/platform/mpam/mpam_resctrl.c | 57 ++++++++++++++++++++++++++-- 1 file changed, 53 insertions(+), 4 deletions(-) diff --git a/drivers/platform/mpam/mpam_resctrl.c b/drivers/platform/mpam/mpam_resctrl.c index a6381bcdf037..6540b84e0f14 100644 --- a/drivers/platform/mpam/mpam_resctrl.c +++ b/drivers/platform/mpam/mpam_resctrl.c @@ -683,6 +683,39 @@ static u16 percent_to_mbw_max(u32 pc, u8 wd) return value; } +static u16 percent_to_ca_max(u32 pc, u8 wd) +{ + struct rdt_resource *l3 = resctrl_arch_get_resource(RDT_RESOURCE_L3); + u32 valid_max; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return percent_to_mbw_max(pc, wd); + + valid_max = l3->cache.cbm_len; + + if (pc >= MAX_MBA_BW) + return valid_max << (16 - wd); + + return ((pc * valid_max + 50) / 100) << (16 - wd); +} + +static u16 ca_max_to_percent(u16 ca_max, u8 wd) +{ + struct rdt_resource *l3 = resctrl_arch_get_resource(RDT_RESOURCE_L3); + u32 valid_max; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return mbw_max_to_percent(ca_max, wd); + + valid_max = l3->cache.cbm_len; + + ca_max = ca_max >> (16 - wd); + if (ca_max >= valid_max) + return MAX_MBA_BW; + + return (ca_max * 100 + valid_max / 2) / valid_max; +} + /* Test whether we can export MPAM_CLASS_CACHE:{2,3}? */ static void mpam_resctrl_pick_caches(void) { @@ -885,6 +918,20 @@ void resctrl_arch_reset_rmid_all(struct rdt_resource *r, struct rdt_domain *d) mpam_msmon_reset_all_mbwu(dom->comp); } +static void mpam_llc_gran_hisi_workaround(struct rdt_resource *r) +{ + unsigned int cbm_len; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return; + + if (r->fflags != RFTYPE_RES_CACHE || r->cache_level != 3) + return; + + cbm_len = resctrl_arch_get_resource(RDT_RESOURCE_L3)->cache.cbm_len; + r->membw.bw_gran = max(100 / cbm_len, 1); +} + static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) { struct mpam_class *class = res->class; @@ -1002,6 +1049,7 @@ static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) r->membw.min_bw = 1; r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + mpam_llc_gran_hisi_workaround(r); break; case RDT_RESOURCE_L3_MIN: @@ -1019,6 +1067,7 @@ static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) r->membw.min_bw = 0; r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + mpam_llc_gran_hisi_workaround(r); break; case RDT_RESOURCE_MB_MIN: @@ -1249,9 +1298,9 @@ u32 resctrl_arch_get_config(struct rdt_resource *r, struct rdt_domain *d, /* TODO: Scaling is not yet supported */ return cfg->cpbm; case mpam_feat_ccap_part: - return mbw_max_to_percent(cfg->cmax, cprops->cmax_wd); + return ca_max_to_percent(cfg->cmax, cprops->cmax_wd); case mpam_feat_cmin: - return mbw_max_to_percent(cfg->cmin, cprops->cmax_wd); + return ca_max_to_percent(cfg->cmin, cprops->cmax_wd); case mpam_feat_intpri_part: return cfg->intpri; case mpam_feat_mbw_part: @@ -1301,12 +1350,12 @@ int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_domain *d, break; case RDT_RESOURCE_L2_MAX: case RDT_RESOURCE_L3_MAX: - cfg.cmax = percent_to_mbw_max(cfg_val, cprops->cmax_wd); + cfg.cmax = percent_to_ca_max(cfg_val, cprops->cmax_wd); mpam_set_feature(mpam_feat_ccap_part, &cfg); break; case RDT_RESOURCE_L2_MIN: case RDT_RESOURCE_L3_MIN: - cfg.cmin = percent_to_mbw_max(cfg_val, cprops->cmax_wd); + cfg.cmin = percent_to_ca_max(cfg_val, cprops->cmax_wd); mpam_set_feature(mpam_feat_cmin, &cfg); break; case RDT_RESOURCE_L2_PRI: -- 2.25.1

2 1

[openeuler:OLK-6.6 2871/2871] mm/memcontrol.c:3147:6: warning: no previous prototype for function 'hisi_oom_recover'
by kernel test robot 10 Sep '25

10 Sep '25

Hi Weilong, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 935ce5f701cad04fd0633c36012e5876ba0e4b37 commit: b498d9f1bacd40d583c0970cab02ad522127a7e7 [2871/2871] arm64/ascend: Add new enable_oom_killer interface for oom contrl config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250910/202509101646.6hsrX8dz-lkp@…) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250910/202509101646.6hsrX8dz-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202509101646.6hsrX8dz-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from mm/memcontrol.c:29: In file included from include/linux/memcontrol.h:20: In file included from include/linux/mm.h:2181: include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 508 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 509 | item]; | ~~~~ include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 515 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 516 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 527 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 528 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 536 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 537 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ In file included from mm/memcontrol.c:57: include/linux/mm_inline.h:46:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 46 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~ ^ ~~~ include/linux/mm_inline.h:48:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 48 | NR_ZONE_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~~~~~~ ^ ~~~ >> mm/memcontrol.c:3147:6: warning: no previous prototype for function 'hisi_oom_recover' [-Wmissing-prototypes] 3147 | void hisi_oom_recover(struct obj_cgroup *objcg) | ^ mm/memcontrol.c:3147:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 3147 | void hisi_oom_recover(struct obj_cgroup *objcg) | ^ | static mm/memcontrol.c:4007:48: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 4007 | nr += lruvec_page_state(lruvec, NR_LRU_BASE + lru); | ~~~~~~~~~~~ ^ ~~~ mm/memcontrol.c:4009:54: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 4009 | nr += lruvec_page_state_local(lruvec, NR_LRU_BASE + lru); | ~~~~~~~~~~~ ^ ~~~ mm/memcontrol.c:4025:46: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 4025 | nr += memcg_page_state(memcg, NR_LRU_BASE + lru); | ~~~~~~~~~~~ ^ ~~~ mm/memcontrol.c:4027:52: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 4027 | nr += memcg_page_state_local(memcg, NR_LRU_BASE + lru); | ~~~~~~~~~~~ ^ ~~~ 12 warnings generated. vim +/hisi_oom_recover +3147 mm/memcontrol.c 3145 3146 #ifdef CONFIG_ASCEND_OOM > 3147 void hisi_oom_recover(struct obj_cgroup *objcg) 3148 { 3149 struct mem_cgroup *memcg; 3150 3151 memcg = get_mem_cgroup_from_objcg(objcg); 3152 if (!mem_cgroup_is_root(memcg)) 3153 memcg_oom_recover(memcg); 3154 css_put(&memcg->css); 3155 } 3156 #else 3157 static inline void hisi_oom_recover(struct obj_cgroup *objcg) { } 3158 #endif 3159 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

openEuler Kernel SIG双周例会
by openEuler conference 10 Sep '25

10 Sep '25

您好！ Kernel 邀请您参加 2025-09-12 14:00 召开的WeLink会议(自动录制) 会议主题：openEuler Kernel SIG双周例会会议内容： 1. 进展update 2. 议题征集中（新增议题可回复本邮件申请，也可填报至会议纪要看板。）会议链接：https://meeting.huaweicloud.com:36443/#/j/966528928 会议纪要：https://etherpad.openeuler.org/p/Kernel-meetings 更多资讯尽在：https://www.openeuler.org/zh/ Hello! Kernel invites you to attend the WeLink conference(auto recording) will be held at 2025-09-12 14:00, The subject of the conference is openEuler Kernel SIG双周例会 Summary: 1. 进展update 2. 议题征集中（新增议题可回复本邮件申请，也可填报至会议纪要看板。） You can join the meeting at https://meeting.huaweicloud.com:36443/#/j/966528928 Add topics at https://etherpad.openeuler.org/p/Kernel-meetings More information: https://www.openeuler.org/en/

1 0

[PATCH OLK-6.6] arm64/mpam: Add quirk for cmax and cmin
by Zeng Heng 10 Sep '25

10 Sep '25

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/ICXA3G -------------------------------- According to the ARM MPAM specification, the legal range of CMAX depends on the MPAMF_CCAP_IDR.CMAX_WD field. However, on certain specialized SoCs, the valid CMAX range additionally relies on the length of the cache partition bit mask. To accommodate these chips, the conversion algorithm between ca_max and percent must be adapted so that the values delivered match the intended targets exactly. Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- drivers/platform/mpam/mpam_resctrl.c | 57 ++++++++++++++++++++++++++-- 1 file changed, 53 insertions(+), 4 deletions(-) diff --git a/drivers/platform/mpam/mpam_resctrl.c b/drivers/platform/mpam/mpam_resctrl.c index a6381bcdf037..6540b84e0f14 100644 --- a/drivers/platform/mpam/mpam_resctrl.c +++ b/drivers/platform/mpam/mpam_resctrl.c @@ -683,6 +683,39 @@ static u16 percent_to_mbw_max(u32 pc, u8 wd) return value; } +static u16 percent_to_ca_max(u32 pc, u8 wd) +{ + struct rdt_resource *l3 = resctrl_arch_get_resource(RDT_RESOURCE_L3); + u32 valid_max; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return percent_to_mbw_max(pc, wd); + + valid_max = l3->cache.cbm_len; + + if (pc >= MAX_MBA_BW) + return valid_max << (16 - wd); + + return ((pc * valid_max + 50) / 100) << (16 - wd); +} + +static u16 ca_max_to_percent(u16 ca_max, u8 wd) +{ + struct rdt_resource *l3 = resctrl_arch_get_resource(RDT_RESOURCE_L3); + u32 valid_max; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return mbw_max_to_percent(ca_max, wd); + + valid_max = l3->cache.cbm_len; + + ca_max = ca_max >> (16 - wd); + if (ca_max >= valid_max) + return MAX_MBA_BW; + + return (ca_max * 100 + valid_max / 2) / valid_max; +} + /* Test whether we can export MPAM_CLASS_CACHE:{2,3}? */ static void mpam_resctrl_pick_caches(void) { @@ -885,6 +918,20 @@ void resctrl_arch_reset_rmid_all(struct rdt_resource *r, struct rdt_domain *d) mpam_msmon_reset_all_mbwu(dom->comp); } +static void mpam_llc_gran_hisi_workaround(struct rdt_resource *r) +{ + unsigned int cbm_len; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return; + + if (r->fflags != RFTYPE_RES_CACHE || r->cache_level != 3) + return; + + cbm_len = resctrl_arch_get_resource(RDT_RESOURCE_L3)->cache.cbm_len; + r->membw.bw_gran = max(100 / cbm_len, 1); +} + static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) { struct mpam_class *class = res->class; @@ -1002,6 +1049,7 @@ static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) r->membw.min_bw = 1; r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + mpam_llc_gran_hisi_workaround(r); break; case RDT_RESOURCE_L3_MIN: @@ -1019,6 +1067,7 @@ static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) r->membw.min_bw = 0; r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + mpam_llc_gran_hisi_workaround(r); break; case RDT_RESOURCE_MB_MIN: @@ -1249,9 +1298,9 @@ u32 resctrl_arch_get_config(struct rdt_resource *r, struct rdt_domain *d, /* TODO: Scaling is not yet supported */ return cfg->cpbm; case mpam_feat_ccap_part: - return mbw_max_to_percent(cfg->cmax, cprops->cmax_wd); + return ca_max_to_percent(cfg->cmax, cprops->cmax_wd); case mpam_feat_cmin: - return mbw_max_to_percent(cfg->cmin, cprops->cmax_wd); + return ca_max_to_percent(cfg->cmin, cprops->cmax_wd); case mpam_feat_intpri_part: return cfg->intpri; case mpam_feat_mbw_part: @@ -1301,12 +1350,12 @@ int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_domain *d, break; case RDT_RESOURCE_L2_MAX: case RDT_RESOURCE_L3_MAX: - cfg.cmax = percent_to_mbw_max(cfg_val, cprops->cmax_wd); + cfg.cmax = percent_to_ca_max(cfg_val, cprops->cmax_wd); mpam_set_feature(mpam_feat_ccap_part, &cfg); break; case RDT_RESOURCE_L2_MIN: case RDT_RESOURCE_L3_MIN: - cfg.cmin = percent_to_mbw_max(cfg_val, cprops->cmax_wd); + cfg.cmin = percent_to_ca_max(cfg_val, cprops->cmax_wd); mpam_set_feature(mpam_feat_cmin, &cfg); break; case RDT_RESOURCE_L2_PRI: -- 2.25.1

2 1

[PATCH OLK-6.6] sched: Fix sched_numa_find_nth_cpu() if mask offline
by Wang Tao 10 Sep '25

10 Sep '25

From: Christian Loehle <christian.loehle(a)arm.com> stable inclusion from stable-v6.6.105 commit f9b8d4dba8e78c1887fecd81ba0d8204d6ff05fc category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/ICX9JK Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- commit 5ebf512f335053a42482ebff91e46c6dc156bf8c upstream. sched_numa_find_nth_cpu() uses a bsearch to look for the 'closest' CPU in sched_domains_numa_masks and given cpus mask. However they might not intersect if all CPUs in the cpus mask are offline. bsearch will return NULL in that case, bail out instead of dereferencing a bogus pointer. The previous behaviour lead to this bug when using maxcpus=4 on an rk3399 (LLLLbb) (i.e. booting with all big CPUs offline): [ 1.422922] Unable to handle kernel paging request at virtual address ffffff8000000000 [ 1.423635] Mem abort info: [ 1.423889] ESR = 0x0000000096000006 [ 1.424227] EC = 0x25: DABT (current EL), IL = 32 bits [ 1.424715] SET = 0, FnV = 0 [ 1.424995] EA = 0, S1PTW = 0 [ 1.425279] FSC = 0x06: level 2 translation fault [ 1.425735] Data abort info: [ 1.425998] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000 [ 1.426499] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 1.426952] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 1.427428] swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000004a9f000 [ 1.428038] [ffffff8000000000] pgd=18000000f7fff403, p4d=18000000f7fff403, pud=18000000f7fff403, pmd=0000000000000000 [ 1.429014] Internal error: Oops: 0000000096000006 [#1] SMP [ 1.429525] Modules linked in: [ 1.429813] CPU: 3 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.17.0-rc4-dirty #343 PREEMPT [ 1.430559] Hardware name: Pine64 RockPro64 v2.1 (DT) [ 1.431012] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 1.431634] pc : sched_numa_find_nth_cpu+0x2a0/0x488 [ 1.432094] lr : sched_numa_find_nth_cpu+0x284/0x488 [ 1.432543] sp : ffffffc084e1b960 [ 1.432843] x29: ffffffc084e1b960 x28: ffffff80078a8800 x27: ffffffc0846eb1d0 [ 1.433495] x26: 0000000000000000 x25: 0000000000000000 x24: 0000000000000000 [ 1.434144] x23: 0000000000000000 x22: fffffffffff7f093 x21: ffffffc081de6378 [ 1.434792] x20: 0000000000000000 x19: 0000000ffff7f093 x18: 00000000ffffffff [ 1.435441] x17: 3030303866666666 x16: 66663d736b73616d x15: ffffffc104e1b5b7 [ 1.436091] x14: 0000000000000000 x13: ffffffc084712860 x12: 0000000000000372 [ 1.436739] x11: 0000000000000126 x10: ffffffc08476a860 x9 : ffffffc084712860 [ 1.437389] x8 : 00000000ffffefff x7 : ffffffc08476a860 x6 : 0000000000000000 [ 1.438036] x5 : 000000000000bff4 x4 : 0000000000000000 x3 : 0000000000000000 [ 1.438683] x2 : 0000000000000000 x1 : ffffffc0846eb000 x0 : ffffff8000407b68 [ 1.439332] Call trace: [ 1.439559] sched_numa_find_nth_cpu+0x2a0/0x488 (P) [ 1.440016] smp_call_function_any+0xc8/0xd0 [ 1.440416] armv8_pmu_init+0x58/0x27c [ 1.440770] armv8_cortex_a72_pmu_init+0x20/0x2c [ 1.441199] arm_pmu_device_probe+0x1e4/0x5e8 [ 1.441603] armv8_pmu_device_probe+0x1c/0x28 [ 1.442007] platform_probe+0x5c/0xac [ 1.442347] really_probe+0xbc/0x298 [ 1.442683] __driver_probe_device+0x78/0x12c [ 1.443087] driver_probe_device+0xdc/0x160 [ 1.443475] __driver_attach+0x94/0x19c [ 1.443833] bus_for_each_dev+0x74/0xd4 [ 1.444190] driver_attach+0x24/0x30 [ 1.444525] bus_add_driver+0xe4/0x208 [ 1.444874] driver_register+0x60/0x128 [ 1.445233] __platform_driver_register+0x24/0x30 [ 1.445662] armv8_pmu_driver_init+0x28/0x4c [ 1.446059] do_one_initcall+0x44/0x25c [ 1.446416] kernel_init_freeable+0x1dc/0x3bc [ 1.446820] kernel_init+0x20/0x1d8 [ 1.447151] ret_from_fork+0x10/0x20 [ 1.447493] Code: 90022e21 f000e5f5 910de2b5 2a1703e2 (f8767803) [ 1.448040] ---[ end trace 0000000000000000 ]--- [ 1.448483] note: swapper/0[1] exited with preempt_count 1 [ 1.449047] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b [ 1.449741] SMP: stopping secondary CPUs [ 1.450105] Kernel Offset: disabled [ 1.450419] CPU features: 0x000000,00080000,20002001,0400421b [ 1.450935] Memory Limit: none [ 1.451217] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]--- Yury: with the fix, the function returns cpu == nr_cpu_ids, and later in smp_call_function_any -> smp_call_function_single -> generic_exec_single we test the cpu for '>= nr_cpu_ids' and return -ENXIO. So everything is handled correctly. Fixes: cd7f55359c90 ("sched: add sched_numa_find_nth_cpu()") Cc: stable(a)vger.kernel.org Signed-off-by: Christian Loehle <christian.loehle(a)arm.com> Signed-off-by: Yury Norov (NVIDIA) <yury.norov(a)gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Wang Tao <wangtao554(a)huawei.com> --- kernel/sched/topology.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 57a268a2a86a..3023e67da0fd 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -2306,6 +2306,8 @@ int sched_numa_find_nth_cpu(const struct cpumask *cpus, int cpu, int node) goto unlock; hop_masks = bsearch(&k, k.masks, sched_domains_numa_levels, sizeof(k.masks[0]), hop_cmp); + if (!hop_masks) + goto unlock; hop = hop_masks - k.masks; ret = hop ? -- 2.34.1

2 1

[openeuler:OLK-6.6 2871/2871] mm/share_pool.c:1468:7: warning: variable 'is_hugepage' set but not used
by kernel test robot 10 Sep '25

10 Sep '25

Hi Wang, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 935ce5f701cad04fd0633c36012e5876ba0e4b37 commit: eaafc4a2a3fd023a99c44286895074dd5712706f [2871/2871] mm/sharepool: Implement mg_sp_unshare_kva config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250910/202509101407.yFi7BLHu-lkp@…) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250910/202509101407.yFi7BLHu-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202509101407.yFi7BLHu-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from mm/share_pool.c:21: In file included from include/linux/share_pool.h:5: In file included from include/linux/mman.h:5: In file included from include/linux/mm.h:2174: include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 508 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 509 | item]; | ~~~~ include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 515 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 516 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 527 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 528 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 536 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 537 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ >> mm/share_pool.c:1468:7: warning: variable 'is_hugepage' set but not used [-Wunused-but-set-variable] 1468 | bool is_hugepage = true; | ^ mm/share_pool.c:73:12: warning: unused variable 'system_group_count' [-Wunused-variable] 73 | static int system_group_count; | ^~~~~~~~~~~~~~~~~~ mm/share_pool.c:76:19: warning: unused variable 'sp_group_idr' [-Wunused-variable] 76 | static DEFINE_IDR(sp_group_idr); | ^~~~~~~~~~~~ include/linux/idr.h:56:37: note: expanded from macro 'DEFINE_IDR' 56 | #define DEFINE_IDR(name) struct idr name = IDR_INIT(name) | ^~~~ mm/share_pool.c:223:20: warning: unused function 'sp_add_group_master' [-Wunused-function] 223 | static inline void sp_add_group_master(struct sp_group_master *master) | ^~~~~~~~~~~~~~~~~~~ mm/share_pool.c:230:20: warning: unused function 'sp_del_group_master' [-Wunused-function] 230 | static inline void sp_del_group_master(struct sp_group_master *master) | ^~~~~~~~~~~~~~~~~~~ mm/share_pool.c:237:13: warning: unused function 'meminfo_init' [-Wunused-function] 237 | static void meminfo_init(struct sp_meminfo *meminfo) | ^~~~~~~~~~~~ mm/share_pool.c:274:20: warning: unused function 'meminfo_alloc_sum_byKB' [-Wunused-function] 274 | static inline long meminfo_alloc_sum_byKB(struct sp_meminfo *meminfo) | ^~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:279:20: warning: unused function 'meminfo_k2u_size' [-Wunused-function] 279 | static inline long meminfo_k2u_size(struct sp_meminfo *meminfo) | ^~~~~~~~~~~~~~~~ mm/share_pool.c:284:25: warning: unused function 'meminfo_total_size' [-Wunused-function] 284 | static inline long long meminfo_total_size(struct sp_meminfo *meminfo) | ^~~~~~~~~~~~~~~~~~ mm/share_pool.c:380:13: warning: unused function 'sp_mapping_detach' [-Wunused-function] 380 | static void sp_mapping_detach(struct sp_group *spg, struct sp_mapping *spm) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c:438:12: warning: unused function 'sp_group_setup_mapping_normal' [-Wunused-function] 438 | static int sp_group_setup_mapping_normal(struct mm_struct *mm, struct sp_group *spg) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:485:13: warning: unused function 'update_mem_usage_alloc' [-Wunused-function] 485 | static void update_mem_usage_alloc(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:497:13: warning: unused function 'update_mem_usage_k2u' [-Wunused-function] 497 | static void update_mem_usage_k2u(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:582:22: warning: unused function 'spa_size' [-Wunused-function] 582 | static unsigned long spa_size(struct sp_area *spa) | ^~~~~~~~ mm/share_pool.c:587:21: warning: unused function 'spa_file' [-Wunused-function] 587 | static struct file *spa_file(struct sp_area *spa) | ^~~~~~~~ mm/share_pool.c:791:24: warning: unused function 'sp_area_alloc' [-Wunused-function] 791 | static struct sp_area *sp_area_alloc(unsigned long size, unsigned long flags, | ^~~~~~~~~~~~~ mm/share_pool.c:944:24: warning: unused function 'sp_area_get' [-Wunused-function] 944 | static struct sp_area *sp_area_get(struct sp_group *spg, | ^~~~~~~~~~~ mm/share_pool.c:1005:13: warning: unused function 'sp_area_put_locked' [-Wunused-function] 1005 | static void sp_area_put_locked(struct sp_area *spa) | ^~~~~~~~~~~~~~~~~~ 23 warnings generated. vim +/is_hugepage +1468 mm/share_pool.c 1460 1461 /* No possible concurrent protection, take care when use */ 1462 static int sp_unshare_kva(unsigned long kva, unsigned long size) 1463 { 1464 unsigned long addr, kva_aligned; 1465 struct page *page; 1466 unsigned long size_aligned; 1467 unsigned long step; > 1468 bool is_hugepage = true; 1469 int ret; 1470 1471 ret = is_vmap_hugepage(kva); 1472 if (ret > 0) { 1473 kva_aligned = ALIGN_DOWN(kva, PMD_SIZE); 1474 size_aligned = ALIGN(kva + size, PMD_SIZE) - kva_aligned; 1475 step = PMD_SIZE; 1476 } else if (ret == 0) { 1477 kva_aligned = ALIGN_DOWN(kva, PAGE_SIZE); 1478 size_aligned = ALIGN(kva + size, PAGE_SIZE) - kva_aligned; 1479 step = PAGE_SIZE; 1480 is_hugepage = false; 1481 } else { 1482 pr_err_ratelimited("check vmap hugepage failed %d\n", ret); 1483 return -EINVAL; 1484 } 1485 1486 if (kva_aligned + size_aligned < kva_aligned) { 1487 pr_err_ratelimited("overflow happened in unshare kva\n"); 1488 return -EINVAL; 1489 } 1490 1491 for (addr = kva_aligned; addr < (kva_aligned + size_aligned); addr += step) { 1492 page = vmalloc_to_page((void *)addr); 1493 if (page) 1494 put_page(page); 1495 else 1496 WARN(1, "vmalloc %pK to page/hugepage failed\n", 1497 (void *)addr); 1498 } 1499 1500 vunmap((void *)kva_aligned); 1501 1502 return 0; 1503 } 1504 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6] arm64/mpam: Add quirk for cmax and cmin
by Zeng Heng 10 Sep '25

10 Sep '25

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/ICXA3G -------------------------------- According to the ARM MPAM specification, the legal range of CMAX depends on the MPAMF_CCAP_IDR.CMAX_WD field. However, on certain specialized SoCs, the valid CMAX range additionally relies on the length of the cache partition bit mask. To accommodate these chips, the conversion algorithm between ca_max and percent must be adapted so that the values delivered match the intended targets exactly. Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- drivers/platform/mpam/mpam_resctrl.c | 51 ++++++++++++++++++++++++---- 1 file changed, 45 insertions(+), 6 deletions(-) diff --git a/drivers/platform/mpam/mpam_resctrl.c b/drivers/platform/mpam/mpam_resctrl.c index a6381bcdf037..e77622ec29bf 100644 --- a/drivers/platform/mpam/mpam_resctrl.c +++ b/drivers/platform/mpam/mpam_resctrl.c @@ -683,6 +683,39 @@ static u16 percent_to_mbw_max(u32 pc, u8 wd) return value; } +static u16 percent_to_ca_max(u32 pc, u8 wd) +{ + struct rdt_resource *l3 = resctrl_arch_get_resource(RDT_RESOURCE_L3); + u32 valid_max; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return percent_to_mbw_max(pc, wd); + + valid_max = l3->cache.cbm_len; + + if (pc >= MAX_MBA_BW) + return valid_max << (16 - wd); + + return ((pc * valid_max + 50) / 100) << (16 - wd); +} + +static u16 ca_max_to_percent(u16 ca_max, u8 wd) +{ + struct rdt_resource *l3 = resctrl_arch_get_resource(RDT_RESOURCE_L3); + u32 valid_max; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return mbw_max_to_percent(ca_max, wd); + + valid_max = l3->cache.cbm_len; + + ca_max = ca_max >> (16 - wd); + if (ca_max >= valid_max) + return MAX_MBA_BW; + + return (ca_max * 100 + valid_max / 2) / valid_max; +} + /* Test whether we can export MPAM_CLASS_CACHE:{2,3}? */ static void mpam_resctrl_pick_caches(void) { @@ -1001,7 +1034,10 @@ static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) r->alloc_capable = true; r->membw.min_bw = 1; - r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + else + r->membw.bw_gran = max(100 / resctrl_arch_get_resource(RDT_RESOURCE_L3)->cache.cbm_len, 1); break; case RDT_RESOURCE_L3_MIN: @@ -1018,7 +1054,10 @@ static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) r->alloc_capable = true; r->membw.min_bw = 0; - r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + else + r->membw.bw_gran = max(100 / resctrl_arch_get_resource(RDT_RESOURCE_L3)->cache.cbm_len, 1); break; case RDT_RESOURCE_MB_MIN: @@ -1249,9 +1288,9 @@ u32 resctrl_arch_get_config(struct rdt_resource *r, struct rdt_domain *d, /* TODO: Scaling is not yet supported */ return cfg->cpbm; case mpam_feat_ccap_part: - return mbw_max_to_percent(cfg->cmax, cprops->cmax_wd); + return ca_max_to_percent(cfg->cmax, cprops->cmax_wd); case mpam_feat_cmin: - return mbw_max_to_percent(cfg->cmin, cprops->cmax_wd); + return ca_max_to_percent(cfg->cmin, cprops->cmax_wd); case mpam_feat_intpri_part: return cfg->intpri; case mpam_feat_mbw_part: @@ -1301,12 +1340,12 @@ int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_domain *d, break; case RDT_RESOURCE_L2_MAX: case RDT_RESOURCE_L3_MAX: - cfg.cmax = percent_to_mbw_max(cfg_val, cprops->cmax_wd); + cfg.cmax = percent_to_ca_max(cfg_val, cprops->cmax_wd); mpam_set_feature(mpam_feat_ccap_part, &cfg); break; case RDT_RESOURCE_L2_MIN: case RDT_RESOURCE_L3_MIN: - cfg.cmin = percent_to_mbw_max(cfg_val, cprops->cmax_wd); + cfg.cmin = percent_to_ca_max(cfg_val, cprops->cmax_wd); mpam_set_feature(mpam_feat_cmin, &cfg); break; case RDT_RESOURCE_L2_PRI: -- 2.25.1

2 1

[openeuler:OLK-6.6 2871/2871] mm/share_pool.c:787: warning: Function parameter or member 'node_id' not described in 'sp_area_alloc'
by kernel test robot 10 Sep '25

10 Sep '25

Hi Wang, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 65083f33551f08e95659ac21bbe5096637ec5724 commit: b39fcd51ad1b62c99ed0932ad0d2f89dfdc17aaa [2871/2871] mm/sharepool: Add sp_area management code config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250910/202509101135.XUImZv6b-lkp@…) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250910/202509101135.XUImZv6b-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202509101135.XUImZv6b-lkp@intel.com/ All warnings (new ones prefixed by >>): mm/share_pool.c:685: warning: expecting prototype for mp_sp_group_id_by_pid(). Prototype was for mg_sp_group_id_by_pid() instead >> mm/share_pool.c:787: warning: Function parameter or member 'node_id' not described in 'sp_area_alloc' mm/share_pool.c:1110: warning: duplicate section name 'Return' mm/share_pool.c:1145: warning: Function parameter or member 'spg_id' not described in 'mg_sp_unshare' vim +787 mm/share_pool.c 773 774 /** 775 * sp_area_alloc() - Allocate a region of VA from the share pool. 776 * @size: the size of VA to allocate. 777 * @flags: how to allocate the memory. 778 * @spg: the share group that the memory is allocated to. 779 * @type: the type of the region. 780 * @applier: the tgid of the task which allocates the region. 781 * 782 * Return: a valid pointer for success, NULL on failure. 783 */ 784 static struct sp_area *sp_area_alloc(unsigned long size, unsigned long flags, 785 struct sp_group *spg, enum spa_type type, 786 pid_t applier, int node_id) > 787 { 788 int device_id; 789 struct sp_area *spa, *first, *err; 790 struct rb_node *n; 791 unsigned long vstart; 792 unsigned long vend; 793 unsigned long addr; 794 unsigned long size_align = ALIGN(size, PMD_SIZE); /* va aligned to 2M */ 795 struct sp_mapping *mapping; 796 797 device_id = sp_flags_device_id(flags); 798 if (device_id < 0 || device_id >= MAX_DEVID) { 799 pr_err("invalid device id %d\n", device_id); 800 return ERR_PTR(-EINVAL); 801 } 802 803 if (flags & SP_PROT_FOCUS) { 804 if ((flags & (SP_DVPP | SP_PROT_RO)) != SP_PROT_RO) { 805 pr_err("invalid sp_flags [%lx]\n", flags); 806 return ERR_PTR(-EINVAL); 807 } 808 mapping = spg->mapping[SP_MAPPING_RO]; 809 } else if (flags & SP_DVPP) { 810 mapping = spg->mapping[SP_MAPPING_DVPP]; 811 } else { 812 mapping = spg->mapping[SP_MAPPING_NORMAL]; 813 } 814 815 if (!mapping) { 816 pr_err_ratelimited("non DVPP spg, id %d\n", spg->id); 817 return ERR_PTR(-EINVAL); 818 } 819 820 vstart = mapping->start[device_id]; 821 vend = mapping->end[device_id]; 822 spa = kmalloc(sizeof(struct sp_area), GFP_KERNEL); 823 if (unlikely(!spa)) 824 return ERR_PTR(-ENOMEM); 825 826 spin_lock(&mapping->sp_mapping_lock); 827 828 /* 829 * Invalidate cache if we have more permissive parameters. 830 * cached_hole_size notes the largest hole noticed _below_ 831 * the sp_area cached in free_area_cache: if size fits 832 * into that hole, we want to scan from vstart to reuse 833 * the hole instead of allocating above free_area_cache. 834 * Note that sp_area_free may update free_area_cache 835 * without updating cached_hole_size. 836 */ 837 if (!mapping->free_area_cache || size_align < mapping->cached_hole_size || 838 vstart != mapping->cached_vstart) { 839 mapping->cached_hole_size = 0; 840 mapping->free_area_cache = NULL; 841 } 842 843 /* record if we encounter less permissive parameters */ 844 mapping->cached_vstart = vstart; 845 846 /* find starting point for our search */ 847 if (mapping->free_area_cache) { 848 first = rb_entry(mapping->free_area_cache, struct sp_area, rb_node); 849 addr = first->va_end; 850 if (addr + size_align < addr) { 851 err = ERR_PTR(-EOVERFLOW); 852 goto error; 853 } 854 } else { 855 addr = vstart; 856 if (addr + size_align < addr) { 857 err = ERR_PTR(-EOVERFLOW); 858 goto error; 859 } 860 861 n = mapping->area_root.rb_node; 862 first = NULL; 863 864 while (n) { 865 struct sp_area *tmp; 866 867 tmp = rb_entry(n, struct sp_area, rb_node); 868 if (tmp->va_end >= addr) { 869 first = tmp; 870 if (tmp->va_start <= addr) 871 break; 872 n = n->rb_left; 873 } else 874 n = n->rb_right; 875 } 876 877 if (!first) 878 goto found; 879 } 880 881 /* from the starting point, traverse areas until a suitable hole is found */ 882 while (addr + size_align > first->va_start && addr + size_align <= vend) { 883 if (addr + mapping->cached_hole_size < first->va_start) 884 mapping->cached_hole_size = first->va_start - addr; 885 addr = first->va_end; 886 if (addr + size_align < addr) { 887 err = ERR_PTR(-EOVERFLOW); 888 goto error; 889 } 890 891 n = rb_next(&first->rb_node); 892 if (n) 893 first = rb_entry(n, struct sp_area, rb_node); 894 else 895 goto found; 896 } 897 898 found: 899 if (addr + size_align > vend) { 900 err = ERR_PTR(-EOVERFLOW); 901 goto error; 902 } 903 904 spa->va_start = addr; 905 spa->va_end = addr + size_align; 906 spa->real_size = size; 907 spa->region_vstart = vstart; 908 spa->flags = flags; 909 spa->is_hugepage = (flags & SP_HUGEPAGE); 910 spa->spg = spg; 911 spa->spm = mapping; 912 spa->type = type; 913 spa->kva = 0; /* NULL pointer */ 914 spa->applier = applier; 915 spa->preferred_node_id = node_id; 916 atomic_set(&spa->use_count, 1); 917 918 /* the link location could be saved before, to be optimized */ 919 spm_insert_area(mapping, spa); 920 mapping->free_area_cache = &spa->rb_node; 921 922 spin_unlock(&mapping->sp_mapping_lock); 923 sp_group_insert_area(spg, spa); 924 925 return spa; 926 927 error: 928 spin_unlock(&mapping->sp_mapping_lock); 929 kfree(spa); 930 return err; 931 } 932 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6] arm64/mpam: Add quirk for cmax and cmin
by Zeng Heng 10 Sep '25

10 Sep '25

According to the ARM MPAM specification, the legal range of CMAX depends on the MPAMF_CCAP_IDR.CMAX_WD field. However, on certain specialized SoCs, the valid CMAX range additionally relies on the length of the cache partition bit mask. To accommodate these chips, the conversion algorithm between ca_max and percent must be adapted so that the values delivered match the intended targets exactly. Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- drivers/platform/mpam/mpam_resctrl.c | 51 ++++++++++++++++++++++++---- 1 file changed, 45 insertions(+), 6 deletions(-) diff --git a/drivers/platform/mpam/mpam_resctrl.c b/drivers/platform/mpam/mpam_resctrl.c index a6381bcdf037..e77622ec29bf 100644 --- a/drivers/platform/mpam/mpam_resctrl.c +++ b/drivers/platform/mpam/mpam_resctrl.c @@ -683,6 +683,39 @@ static u16 percent_to_mbw_max(u32 pc, u8 wd) return value; } +static u16 percent_to_ca_max(u32 pc, u8 wd) +{ + struct rdt_resource *l3 = resctrl_arch_get_resource(RDT_RESOURCE_L3); + u32 valid_max; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return percent_to_mbw_max(pc, wd); + + valid_max = l3->cache.cbm_len; + + if (pc >= MAX_MBA_BW) + return valid_max << (16 - wd); + + return ((pc * valid_max + 50) / 100) << (16 - wd); +} + +static u16 ca_max_to_percent(u16 ca_max, u8 wd) +{ + struct rdt_resource *l3 = resctrl_arch_get_resource(RDT_RESOURCE_L3); + u32 valid_max; + + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + return mbw_max_to_percent(ca_max, wd); + + valid_max = l3->cache.cbm_len; + + ca_max = ca_max >> (16 - wd); + if (ca_max >= valid_max) + return MAX_MBA_BW; + + return (ca_max * 100 + valid_max / 2) / valid_max; +} + /* Test whether we can export MPAM_CLASS_CACHE:{2,3}? */ static void mpam_resctrl_pick_caches(void) { @@ -1001,7 +1034,10 @@ static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) r->alloc_capable = true; r->membw.min_bw = 1; - r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + else + r->membw.bw_gran = max(100 / resctrl_arch_get_resource(RDT_RESOURCE_L3)->cache.cbm_len, 1); break; case RDT_RESOURCE_L3_MIN: @@ -1018,7 +1054,10 @@ static int mpam_resctrl_resource_init(struct mpam_resctrl_res *res) r->alloc_capable = true; r->membw.min_bw = 0; - r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + if (read_cpuid_implementor() != ARM_CPU_IMP_HISI) + r->membw.bw_gran = max(100 / (1 << cprops->cmax_wd), 1); + else + r->membw.bw_gran = max(100 / resctrl_arch_get_resource(RDT_RESOURCE_L3)->cache.cbm_len, 1); break; case RDT_RESOURCE_MB_MIN: @@ -1249,9 +1288,9 @@ u32 resctrl_arch_get_config(struct rdt_resource *r, struct rdt_domain *d, /* TODO: Scaling is not yet supported */ return cfg->cpbm; case mpam_feat_ccap_part: - return mbw_max_to_percent(cfg->cmax, cprops->cmax_wd); + return ca_max_to_percent(cfg->cmax, cprops->cmax_wd); case mpam_feat_cmin: - return mbw_max_to_percent(cfg->cmin, cprops->cmax_wd); + return ca_max_to_percent(cfg->cmin, cprops->cmax_wd); case mpam_feat_intpri_part: return cfg->intpri; case mpam_feat_mbw_part: @@ -1301,12 +1340,12 @@ int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_domain *d, break; case RDT_RESOURCE_L2_MAX: case RDT_RESOURCE_L3_MAX: - cfg.cmax = percent_to_mbw_max(cfg_val, cprops->cmax_wd); + cfg.cmax = percent_to_ca_max(cfg_val, cprops->cmax_wd); mpam_set_feature(mpam_feat_ccap_part, &cfg); break; case RDT_RESOURCE_L2_MIN: case RDT_RESOURCE_L3_MIN: - cfg.cmin = percent_to_mbw_max(cfg_val, cprops->cmax_wd); + cfg.cmin = percent_to_ca_max(cfg_val, cprops->cmax_wd); mpam_set_feature(mpam_feat_cmin, &cfg); break; case RDT_RESOURCE_L2_PRI: -- 2.25.1

2 1

[PATCH OLK-6.6] tools/mpam: Add MPAM dynamic adjustment and sampling scripts
by Zeng Heng 10 Sep '25

10 Sep '25

hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/ICWIH7 -------------------------------- For co-location scenarios, add a data-sampling script based on the resctrl file system, which monitors memory bandwidth and cache usage. The script also provides a dynamic bandwidth-adjustment policy that guarantees the response performance of latency-critical services by limiting best-effort services. Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- tools/mpam/dynamic_adjust/bw_dynamic.py | 257 ++++++++++++++++++++ tools/mpam/dynamic_adjust/calc_cpu_usage.py | 25 ++ tools/mpam/dynamic_adjust/draw_bw.py | 154 ++++++++++++ tools/mpam/dynamic_adjust/draw_cpu.py | 41 ++++ tools/mpam/dynamic_adjust/draw_lib.py | 38 +++ tools/mpam/dynamic_adjust/draw_llc.py | 126 ++++++++++ tools/mpam/dynamic_adjust/pid_controller.py | 45 ++++ 7 files changed, 686 insertions(+) create mode 100644 tools/mpam/dynamic_adjust/bw_dynamic.py create mode 100644 tools/mpam/dynamic_adjust/calc_cpu_usage.py create mode 100644 tools/mpam/dynamic_adjust/draw_bw.py create mode 100644 tools/mpam/dynamic_adjust/draw_cpu.py create mode 100644 tools/mpam/dynamic_adjust/draw_lib.py create mode 100644 tools/mpam/dynamic_adjust/draw_llc.py create mode 100644 tools/mpam/dynamic_adjust/pid_controller.py diff --git a/tools/mpam/dynamic_adjust/bw_dynamic.py b/tools/mpam/dynamic_adjust/bw_dynamic.py new file mode 100644 index 000000000000..a4553cd92e30 --- /dev/null +++ b/tools/mpam/dynamic_adjust/bw_dynamic.py @@ -0,0 +1,257 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Dynamic Bandwidth Adjustment +# +# Copyright (C) 2025, Technologies Co., Ltd. +# Author: Zeng Heng <zengheng4(a)huawei.com> + +import os, time, signal, json, sys, glob +import argparse +import subprocess +from pid_controller import PID_Controller +from calc_cpu_usage import read_cpu_times, calculate_cpu_utilization + +__version__ = "1.0.0" + +numa_bw_limit = 140000 + +bw_list = [] +llc_list = [] +set_list = [] +cpu_list = [] + +def read_bw(grp): + grps_val = {} + + for g in grp: + vals = [] + + resctrl_mon_data_dir = '/sys/fs/resctrl/%s/mon_data/' % g + mon_data_dirs = os.listdir(resctrl_mon_data_dir) + mon_MB_dirs = [dir for dir in mon_data_dirs if dir.startswith('mon_MB_')] + mon_MB_dirs.sort() + + for mb_dir in mon_MB_dirs: + with open(resctrl_mon_data_dir + mb_dir + '/mbm_total_bytes', 'r') as f: + # with open(resctrl_mon_data_dir + mb_dir, 'r') as f: + line = f.readline() + vals.append(int(line.strip())) + + grps_val[g] = vals + + totals = [] + for i in range(len(mon_MB_dirs)): + total = 0 + for g in grp: + total += grps_val[g][i] + totals.append(total) + + grps_val["__grp_total__"] = totals + return grps_val + +def increase_bw(be_grp, i, percent): + resctrl_par_dir = '/sys/fs/resctrl/%s/schemata' % be_grp[0] + with open(resctrl_par_dir, 'r') as f: + lines = f.readlines() + + for line in lines: + if "MB:" in line: + config = line.split(":") + config = config[1].split(";") + origin_p = int(config[i].split("=")[1]) + + new_p = (origin_p + percent) + if new_p > 100: + new_p = 100 + elif new_p < 4: + new_p = 4 + + for g in be_grp: + print("%s NUMA%d MB %d%%->%d%% delta %d%%" % (g, i, origin_p, new_p, percent)) + + cnt = "MB:%d=%d" % (i, new_p) + if new_p == origin_p: + continue + + resctrl_par_dir = '/sys/fs/resctrl/%s/schemata' % g + with open(resctrl_par_dir, 'w+') as f: + f.write("%s\n" % cnt) + + return origin_p + +def gain_numa_bw(lc_grp, be_grp, pid_ctl, adjust_enable, target_percent): + lc_val = read_bw(lc_grp) + be_val = read_bw(be_grp) + + bw_state = {} + bw_state["lc_bw"] = lc_val + bw_state["be_bw"] = be_val + bw_state["total_bw"] = [] + + numa_set = [] + + for i in range(len(lc_val["__grp_total__"])): + bw_state["total_bw"].append(lc_val["__grp_total__"][i] + be_val["__grp_total__"][i]) + + set_state = {} + + if adjust_enable == True: + if bw_state["lc_bw"]["__grp_total__"][i] < (0.02 * numa_bw_limit): + # enlarge BE load + diff = pid_ctl[i].max_output + elif bw_state["lc_bw"]["__grp_total__"][i] > ((target_percent + 10) * numa_bw_limit / 100): + # shutdown BE load + diff = pid_ctl[i].min_output + else: + diff = pid_ctl[i].update(bw_state["total_bw"][i] * 100 // numa_bw_limit , 1) + else: + diff = 0 + + curr = increase_bw(be_grp, i, diff) + set_state['setting'] = curr + numa_set.append(set_state) + + bw_list.append(bw_state) + set_list.append(numa_set) + return + +def read_llc(grp): + grps_val = {} + + for g in grp: + vals = [] + + resctrl_mon_data_dir = '/sys/fs/resctrl/%s/mon_data/' % g + mon_data_dirs = os.listdir(resctrl_mon_data_dir) + mon_llc_dirs = [dir for dir in mon_data_dirs if dir.startswith('mon_L3_')] + mon_llc_dirs.sort() + + for mb_dir in mon_llc_dirs: + with open(resctrl_mon_data_dir + mb_dir + '/llc_occupancy', 'r') as f: + # with open(resctrl_mon_data_dir + mb_dir, 'r') as f: + line = f.readline() + vals.append(int(line.strip())) + + grps_val[g] = vals + + totals = [] + for i in range(len(mon_llc_dirs)): + total = 0 + for g in grp: + total += grps_val[g][i] + totals.append(total) + + grps_val["__grp_total__"] = totals + return grps_val + +def gain_numa_llc(lc_grp, be_grp): + lc_llc = read_llc(lc_grp) + be_llc = read_llc(be_grp) + + llc_state = {} + llc_state["lc_llc"] = lc_llc + llc_state["be_llc"] = be_llc + + llc_list.append(llc_state) + + return + +def gain_cpu(time1, time2): + usage = calculate_cpu_utilization(time1, time2) + print(f"CPU load: {usage:.2f}%") + cpu_list.append(usage) + return + +def save_file(sig, frame): + with open(f"ctrlgrp_bw.data", 'w') as fl: + json.dump(bw_list, fl) + + with open(f"schemata_set.data", 'w') as fl: + json.dump(set_list, fl) + + with open(f"ctrlgrp_llc.data", 'w') as fl: + json.dump(llc_list, fl) + + with open(f"cpu_usage.data", 'w') as fl: + json.dump(cpu_list, fl) + + exit(0) + +def get_numa_count(): + return len(glob.glob("/sys/devices/system/node/node[0-9]*")) + +def flatten_comma_separated(raw_list): + out = [] + for item in raw_list: + out.extend([x.strip() for x in item.split(",") if x.strip()]) + return out + +def parse_args(): + parser = argparse.ArgumentParser( + description="Example: read execution time and isolation percentage from CLI") + + parser.add_argument("-t", "--time", required=False, type=int, + help="Expected execution time in seconds, positive integer") + parser.add_argument("-i", "--isolation", required=False, type=int, + help="Isolation percentage, integer between 1 and 100") + parser.add_argument("-l", "--lc", action="append", default=["."], + help="Comma-separated or repeated latency-critical group names.") + parser.add_argument("-b", "--be", action="append", default=[], + help="Comma-separated or repeated best-effort group names.") + parser.add_argument("-v", "--version", action="version", + version=f"%(prog)s {__version__}") + + args = parser.parse_args() + + if args.time and args.time <= 0: + sys.exit("ERROR: execution time must be > 0 seconds") + + if args.isolation and not 1 <= args.isolation <= 100: + sys.exit("ERROR: isolation percentage must be between 0 and 100") + + if not args.be or not args.lc: + sys.exit("ERROR: at least one -l or -b group name must be provided") + + args.lc = flatten_comma_separated(args.lc) + args.be = flatten_comma_separated(args.be) + + return args + +if __name__ == "__main__": + signal.signal(signal.SIGINT, save_file) + + args = parse_args() + exec_time = args.time + target_percent = args.isolation + lc_group = args.lc + be_group = args.be + + adj_enable = False + if target_percent: + adj_enable = True + + pid_ctl = [] + numa_cnt = get_numa_count() + for i in range(numa_cnt): + pid_ctl.append(PID_Controller(kp=1.0, ki=0.02, kd=0.05, + set_point=target_percent)) + + now = 0 + time1 = read_cpu_times() + + while True: + gain_numa_bw(lc_group, be_group, pid_ctl, adj_enable, target_percent) + gain_numa_llc(lc_group, be_group) + + time2 = read_cpu_times() + gain_cpu(time1, time2) + time1 = time2 + + print("..........................") + time.sleep(1) + now += 1 + + if exec_time and exec_time <= now: + break + + save_file(None, None) diff --git a/tools/mpam/dynamic_adjust/calc_cpu_usage.py b/tools/mpam/dynamic_adjust/calc_cpu_usage.py new file mode 100644 index 000000000000..75f591f4443a --- /dev/null +++ b/tools/mpam/dynamic_adjust/calc_cpu_usage.py @@ -0,0 +1,25 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# CPU Load Sampling for Dynamic Bandwidth Adjustment +# +# Copyright (C) 2025, Technologies Co., Ltd. +# Author: Zeng Heng <zengheng4(a)huawei.com> + +import time + +def read_cpu_times(): + with open('/proc/stat', 'r') as f: + line = f.readline() + + parts = line.split() + return list(map(int, parts[1:])) + +def calculate_cpu_utilization(times1, times2): + total1 = sum(times1) + idle1 = times1[3] + total2 = sum(times2) + idle2 = times2[3] + + total_diff = total2 - total1 + idle_diff = idle2 - idle1 + return (total_diff - idle_diff) * 100 / total_diff diff --git a/tools/mpam/dynamic_adjust/draw_bw.py b/tools/mpam/dynamic_adjust/draw_bw.py new file mode 100644 index 000000000000..c84d9d2047eb --- /dev/null +++ b/tools/mpam/dynamic_adjust/draw_bw.py @@ -0,0 +1,154 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Memory Bandwidth Analysis for Dynamic Bandwidth Adjustment +# +# Copyright (C) 2025, Technologies Co., Ltd. +# Author: Zeng Heng <zengheng4(a)huawei.com> + +import json +import matplotlib.pyplot as plt +from draw_lib import parse_args, get_data + +bw_max_limit = 140000 + +def get_lc_bw(data_list, idx): + table = {} + + table['total_bw'] = [] + table['lc_bw'] = [] + + for k, v in data_list[0]['lc_bw'].items(): + if k != "__grp_total__": + table[k] = [] + + for data in data_list: + table['total_bw'].append(data['total_bw'][idx]) + table['lc_bw'].append(data['lc_bw']["__grp_total__"][idx]) + + for k, v in data['lc_bw'].items(): + if k != "__grp_total__": + table[k].append(v[idx]) + + return table + +def get_be_bw(data_list, idx): + table = {} + + table['total_bw'] = [] + table['be_bw'] = [] + + for k, v in data_list[0]['be_bw'].items(): + if k != "__grp_total__": + table[k] = [] + + for data in data_list: + table['total_bw'].append(data['total_bw'][idx]) + table['be_bw'].append(data['be_bw']["__grp_total__"][idx]) + + for k, v in data['be_bw'].items(): + if k != "__grp_total__": + table[k].append(v[idx]) + + return table + +def get_all_bw(data_list, idx): + table = {} + + table['total_bw'] = [] + table['lc_bw'] = [] + table['be_bw'] = [] + + for k, v in data_list[0]['lc_bw'].items(): + if k != "__grp_total__": + table[k] = [] + for k, v in data_list[0]['be_bw'].items(): + if k != "__grp_total__": + table[k] = [] + + for data in data_list: + table['total_bw'].append(data['total_bw'][idx]) + table['lc_bw'].append(data['lc_bw']["__grp_total__"][idx]) + table['be_bw'].append(data['be_bw']["__grp_total__"][idx]) + + for k, v in data['lc_bw'].items(): + if k != "__grp_total__": + table[k].append(v[idx]) + + for k, v in data['be_bw'].items(): + if k != "__grp_total__": + table[k].append(v[idx]) + + return table + +def get_all_set(set_list, idx): + setting = [] + + for data in set_list: + setting.append(data[idx]['setting']) + + return setting + +def draw_data(bw_list, set_list, cpu_list, numa_th, percent): + fig = plt.figure() + x_arr = list(range(len(bw_list))) + ref = [bw_max_limit * percent / 100] * len(bw_list) + + ax1 = fig.add_subplot(3, 1, 1) + table = get_lc_bw(bw_list, numa_th) + + for k, v in table.items(): + ax1.plot(x_arr, v, label=k) + ax1.plot(x_arr, ref, label='Reference') + + ax1.set_ylabel(f"LC Mem bandwidth (MB)") + ax1.set_xlabel(f"Time (s)") + ax1.legend() + + ax2 = fig.add_subplot(3, 1, 2) + table = get_be_bw(bw_list, numa_th) + + for k, v in table.items(): + ax2.plot(x_arr, v, label=k) + ax2.plot(x_arr, ref, label='Reference') + + ax2.set_ylabel(f"BE Mem bandwidth (MB)") + ax2.set_xlabel(f"Time (s)") + ax2.legend() + + ax3 = fig.add_subplot(3, 1, 3) + setting = get_all_set(set_list, numa_th) + ax3.plot(x_arr, setting, label='MBMAX') + ax3.plot(x_arr, cpu_list, label='CPU Load') + + ax3.set_ylabel(f"Percent(%)") + ax3.set_xlabel(f"Time (s)") + ax3.legend() + + plt.tight_layout() + plt.show() + + return + +if __name__ == '__main__': + start, percent = parse_args() + if not start: + start = 0 + if not percent: + percent = 0 + + filename = 'ctrlgrp_bw.data' + bw_list = get_data(filename) + filename = 'schemata_set.data' + set_list = get_data(filename) + filename = 'cpu_usage.data' + cpu_list = get_data(filename) + + if not bw_list or not set_list: + print('FileNotFound') + + if len(bw_list) != len(cpu_list): + # length sync + bw_list.pop() + set_list.pop() + + draw_data(bw_list, set_list, cpu_list, start, percent) diff --git a/tools/mpam/dynamic_adjust/draw_cpu.py b/tools/mpam/dynamic_adjust/draw_cpu.py new file mode 100644 index 000000000000..5e9d8a738545 --- /dev/null +++ b/tools/mpam/dynamic_adjust/draw_cpu.py @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# CPU Load Analysis for Dynamic Bandwidth Adjustment +# +# Copyright (C) 2025, Technologies Co., Ltd. +# Author: Zeng Heng <zengheng4(a)huawei.com> + +import json +import matplotlib.pyplot as plt + +def draw_data(cpu_list): + fig = plt.figure() + x_arr = list(range(len(cpu_list))) + + ax1 = fig.add_subplot(1, 1, 1) + + ax1.plot(x_arr, cpu_list, label='CPU usage') + ax1.legend() + + plt.tight_layout() + plt.show() + + return + +def get_data(file): + try: + with open(file, 'r') as f: + cpu_list = json.load(f) + except FileNotFoundError: + return None + + return cpu_list + +if __name__ == '__main__': + filename = 'cpu_usage.data' + cpu_list = get_data(filename) + + if cpu_list: + draw_data(cpu_list) + else: + print('FileNotFound') diff --git a/tools/mpam/dynamic_adjust/draw_lib.py b/tools/mpam/dynamic_adjust/draw_lib.py new file mode 100644 index 000000000000..8a11c13f8ec9 --- /dev/null +++ b/tools/mpam/dynamic_adjust/draw_lib.py @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Analysis Lib for Dynamic Bandwidth Adjustment +# +# Copyright (C) 2025, Technologies Co., Ltd. +# Author: Zeng Heng <zengheng4(a)huawei.com> + +import sys, json, argparse + +__version__ = "1.0.0" + +def get_data(file): + try: + with open(file, 'r') as f: + data_list = json.load(f) + except FileNotFoundError: + return None + + return data_list + +def parse_args(): + parser = argparse.ArgumentParser(description="Display selected NUMA's Analysis") + parser.add_argument("-s", "--start", type=int, required=False, + help="Starting NUMA index (0-based)") + parser.add_argument("-i", "--isolation", required=False, type=int, + help="Isolation target percentage, integer between 1 and 100") + parser.add_argument("-v", "--version", action="version", + version=f"%(prog)s {__version__}") + + args = parser.parse_args() + + if args.start and args.start < 0: + sys.exit("ERROR: --index must be non-negative") + + if args.isolation and not 1 <= args.isolation <= 100: + sys.exit("ERROR: isolation percentage must be between 0 and 100") + + return args.start, args.isolation diff --git a/tools/mpam/dynamic_adjust/draw_llc.py b/tools/mpam/dynamic_adjust/draw_llc.py new file mode 100644 index 000000000000..9a6f112fcc2f --- /dev/null +++ b/tools/mpam/dynamic_adjust/draw_llc.py @@ -0,0 +1,126 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Cache Storage Analysis for Dynamic Bandwidth Adjustment +# +# Copyright (C) 2025, Technologies Co., Ltd. +# Author: Zeng Heng <zengheng4(a)huawei.com> + +import matplotlib.pyplot as plt +from draw_lib import parse_args, get_data + +def get_lc_llc(data_list, idx): + table = {} + + table['lc_llc'] = [] + + for k, v in data_list[0]['lc_llc'].items(): + if k != "__grp_total__": + table[k] = [] + + for data in data_list: + table['lc_llc'].append(data['lc_llc']["__grp_total__"][idx]) + for k, v in data['lc_llc'].items(): + if k != "__grp_total__": + table[k].append(v[idx]) + + return table + +def get_be_llc(data_list, idx): + table = {} + + table['be_llc'] = [] + + for k, v in data_list[0]['be_llc'].items(): + if k != "__grp_total__": + table[k] = [] + + for data in data_list: + table['be_llc'].append(data['be_llc']["__grp_total__"][idx]) + for k, v in data['be_llc'].items(): + if k != "__grp_total__": + table[k].append(v[idx]) + + return table + +def get_all_llc(data_list, idx): + table = {} + + table['lc_llc'] = [] + table['be_llc'] = [] + + for k, v in data_list[0]['lc_llc'].items(): + if k != "__grp_total__": + table[k] = [] + for k, v in data_list[0]['be_llc'].items(): + if k != "__grp_total__": + table[k] = [] + + for data in data_list: + table['lc_llc'].append(data['lc_llc']["__grp_total__"][idx]) + table['be_llc'].append(data['be_llc']["__grp_total__"][idx]) + + for k, v in data['lc_llc'].items(): + if k != "__grp_total__": + table[k].append(v[idx]) + + for k, v in data['be_llc'].items(): + if k != "__grp_total__": + table[k].append(v[idx]) + + return table + +def draw_data(llc_list, cpu_list, numa_th): + fig = plt.figure() + x_arr = list(range(len(llc_list))) + + ax1 = fig.add_subplot(3, 1, 1) + table = get_lc_llc(llc_list, numa_th) + + for k, v in table.items(): + ax1.plot(x_arr, v, label=k) + + ax1.set_ylabel(f"LC L3 Cache (KB)") + ax1.set_xlabel(f"Time (s)") + ax1.legend() + + ax2 = fig.add_subplot(3, 1, 2) + table = get_be_llc(llc_list, numa_th) + + for k, v in table.items(): + ax2.plot(x_arr, v, label=k) + + ax2.set_ylabel(f"BE L3 Cache (KB)") + ax2.set_xlabel(f"Time (s)") + ax2.legend() + + ax3 = fig.add_subplot(3, 1, 3) + ax3.plot(x_arr, cpu_list, label='CPU usage') + + ax3.set_ylabel(f"CPU Load (%)") + ax3.set_xlabel(f"Time (s)") + + ax3.legend() + + plt.tight_layout() + plt.show() + + return + +if __name__ == '__main__': + start, p = parse_args() + if not start: + start = 0 + + filename = 'ctrlgrp_llc.data' + llc_list = get_data(filename) + filename = 'cpu_usage.data' + cpu_list = get_data(filename) + + if not llc_list: + print('FileNotFound') + + if len(llc_list) != len(cpu_list): + # length sync + llc_list.pop() + + draw_data(llc_list, cpu_list, start) diff --git a/tools/mpam/dynamic_adjust/pid_controller.py b/tools/mpam/dynamic_adjust/pid_controller.py new file mode 100644 index 000000000000..0b42fc3e29a3 --- /dev/null +++ b/tools/mpam/dynamic_adjust/pid_controller.py @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# PID Algorithm Controller for Dynamic Bandwidth Adjustment +# +# Copyright (C) 2025, Technologies Co., Ltd. +# Author: Zeng Heng <zengheng4(a)huawei.com> + +class PID_Controller: + def __init__(self, kp, ki, kd, set_point): + self.kp = kp # Proportional Gain + self.ki = ki # Integral Gain + self.kd = kd # Derivative Gain + self.set_point = set_point + self.last_error = 0 + self.integral = 0 # Integral Term + + self.max_output = 10 # rise slowly + self.min_output = -100 # fall quickly + + def update(self, current_value, dt): + """ + Update the PID controller's output + :param current_value: Current system output value + :param dt: Time interval + :return: Controller output + """ + error = self.set_point - current_value # Calculate current error + self.integral += error * dt # Update Integral Term + if self.integral < -100: + self.integral = -100 + elif self.integral > 100: + self.integral = 100 + derivative = (error - self.last_error) / dt # Calculate Derivative Term + + output = (self.kp * error) + (self.ki * self.integral) + (self.kd * derivative) + + self.last_error = error + + # Limit the output range + if output > self.max_output: + output = self.max_output + elif output < self.min_output: + output = self.min_output + + return output -- 2.25.1

2 1