- Kernel - mailweb.openeuler.org

[PATCH openEuler-1.0-LTS] tty: fix return value for unsupported ioctls
by Yi Yang 19 Feb '24

19 Feb '24

From: Johan Hovold <johan(a)kernel.org> stable inclusion from stable-v4.19.191 commit 76d7fc0857bc4033415fcad905db13753d0febc7 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I926JG CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 1b8b20868a6d64cfe8174a21b25b74367bdf0560 ] Drivers should return -ENOTTY ("Inappropriate I/O control operation") when an ioctl isn't supported, while -EINVAL is used for invalid arguments. Fix up the TIOCMGET, TIOCMSET and TIOCGICOUNT helpers which returned -EINVAL when a tty driver did not implement the corresponding operations. Note that the TIOCMGET and TIOCMSET helpers predate git and do not get a corresponding Fixes tag below. Fixes: d281da7ff6f7 ("tty: Make tiocgicount a handler") Signed-off-by: Johan Hovold <johan(a)kernel.org> Link: https://lore.kernel.org/r/20210407095208.31838-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Yi Yang <yiyang13(a)huawei.com> --- drivers/tty/tty_io.c | 8 ++++---- include/linux/tty_driver.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 58c3f7b92b0d..908c331c5760 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -2441,14 +2441,14 @@ static int send_break(struct tty_struct *tty, unsigned int duration) * @p: pointer to result * * Obtain the modem status bits from the tty driver if the feature - * is supported. Return -EINVAL if it is not available. + * is supported. Return -ENOTTY if it is not available. * * Locking: none (up to the driver) */ static int tty_tiocmget(struct tty_struct *tty, int __user *p) { - int retval = -EINVAL; + int retval = -ENOTTY; if (tty->ops->tiocmget) { retval = tty->ops->tiocmget(tty); @@ -2466,7 +2466,7 @@ static int tty_tiocmget(struct tty_struct *tty, int __user *p) * @p: pointer to desired bits * * Set the modem status bits from the tty driver if the feature - * is supported. Return -EINVAL if it is not available. + * is supported. Return -ENOTTY if it is not available. * * Locking: none (up to the driver) */ @@ -2478,7 +2478,7 @@ static int tty_tiocmset(struct tty_struct *tty, unsigned int cmd, unsigned int set, clear, val; if (tty->ops->tiocmset == NULL) - return -EINVAL; + return -ENOTTY; retval = get_user(val, p); if (retval) diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h index 71dbc891851a..e10b09672345 100644 --- a/include/linux/tty_driver.h +++ b/include/linux/tty_driver.h @@ -236,7 +236,7 @@ * * Called when the device receives a TIOCGICOUNT ioctl. Passed a kernel * structure to complete. This method is optional and will only be called - * if provided (otherwise EINVAL will be returned). + * if provided (otherwise ENOTTY will be returned). */ #include <linux/export.h> -- 2.25.1

2 1

[PATCH openEuler-22.03-LTS-SP2] sctp: fix potential deadlock on &net->sctp.addr_wq_lock
by Dong Chenchen 19 Feb '24

19 Feb '24

From: Chengfeng Ye <dg573847474(a)gmail.com> stable inclusion from stable-v5.10.188 commit 6d2243ab783bf79d1d674ff0ca26229233c56508 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8WZLA CVE: CVE-2024-0639 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 6feb37b3b06e9049e20dcf7e23998f92c9c5be9a ] As &net->sctp.addr_wq_lock is also acquired by the timer sctp_addr_wq_timeout_handler() in protocal.c, the same lock acquisition at sctp_auto_asconf_init() seems should disable irq since it is called from sctp_accept() under process context. Possible deadlock scenario: sctp_accept() -> sctp_sock_migrate() -> sctp_auto_asconf_init() -> spin_lock(&net->sctp.addr_wq_lock) <timer interrupt> -> sctp_addr_wq_timeout_handler() -> spin_lock_bh(&net->sctp.addr_wq_lock); (deadlock here) This flaw was found using an experimental static analysis tool we are developing for irq-related deadlock. The tentative patch fix the potential deadlock by spin_lock_bh(). Signed-off-by: Chengfeng Ye <dg573847474(a)gmail.com> Fixes: 34e5b0118685 ("sctp: delay auto_asconf init until binding the first addr") Acked-by: Xin Long <lucien.xin(a)gmail.com> Link: https://lore.kernel.org/r/20230627120340.19432-1-dg573847474@gmail.com Signed-off-by: Paolo Abeni <pabeni(a)redhat.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Dong Chenchen <dongchenchen2(a)huawei.com> --- net/sctp/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index e9b4ea3d934f..02526c46dddc 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -362,9 +362,9 @@ static void sctp_auto_asconf_init(struct sctp_sock *sp) struct net *net = sock_net(&sp->inet.sk); if (net->sctp.default_auto_asconf) { - spin_lock(&net->sctp.addr_wq_lock); + spin_lock_bh(&net->sctp.addr_wq_lock); list_add_tail(&sp->auto_asconf_list, &net->sctp.auto_asconf_splist); - spin_unlock(&net->sctp.addr_wq_lock); + spin_unlock_bh(&net->sctp.addr_wq_lock); sp->do_auto_asconf = 1; } } -- 2.25.1

2 1

[PATCH openEuler-22.03-LTS-SP1] sctp: fix potential deadlock on &net->sctp.addr_wq_lock
by Dong Chenchen 19 Feb '24

19 Feb '24

From: Chengfeng Ye <dg573847474(a)gmail.com> stable inclusion from stable-v5.10.188 commit 6d2243ab783bf79d1d674ff0ca26229233c56508 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8WZLA CVE: CVE-2024-0639 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 6feb37b3b06e9049e20dcf7e23998f92c9c5be9a ] As &net->sctp.addr_wq_lock is also acquired by the timer sctp_addr_wq_timeout_handler() in protocal.c, the same lock acquisition at sctp_auto_asconf_init() seems should disable irq since it is called from sctp_accept() under process context. Possible deadlock scenario: sctp_accept() -> sctp_sock_migrate() -> sctp_auto_asconf_init() -> spin_lock(&net->sctp.addr_wq_lock) <timer interrupt> -> sctp_addr_wq_timeout_handler() -> spin_lock_bh(&net->sctp.addr_wq_lock); (deadlock here) This flaw was found using an experimental static analysis tool we are developing for irq-related deadlock. The tentative patch fix the potential deadlock by spin_lock_bh(). Signed-off-by: Chengfeng Ye <dg573847474(a)gmail.com> Fixes: 34e5b0118685 ("sctp: delay auto_asconf init until binding the first addr") Acked-by: Xin Long <lucien.xin(a)gmail.com> Link: https://lore.kernel.org/r/20230627120340.19432-1-dg573847474@gmail.com Signed-off-by: Paolo Abeni <pabeni(a)redhat.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Dong Chenchen <dongchenchen2(a)huawei.com> --- net/sctp/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index e9b4ea3d934f..02526c46dddc 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -362,9 +362,9 @@ static void sctp_auto_asconf_init(struct sctp_sock *sp) struct net *net = sock_net(&sp->inet.sk); if (net->sctp.default_auto_asconf) { - spin_lock(&net->sctp.addr_wq_lock); + spin_lock_bh(&net->sctp.addr_wq_lock); list_add_tail(&sp->auto_asconf_list, &net->sctp.auto_asconf_splist); - spin_unlock(&net->sctp.addr_wq_lock); + spin_unlock_bh(&net->sctp.addr_wq_lock); sp->do_auto_asconf = 1; } } -- 2.25.1

2 1

[PATCH openEuler-22.03-LTS] sctp: fix potential deadlock on &net->sctp.addr_wq_lock
by Dong Chenchen 19 Feb '24

19 Feb '24

From: Chengfeng Ye <dg573847474(a)gmail.com> stable inclusion from stable-v5.10.188 commit 6d2243ab783bf79d1d674ff0ca26229233c56508 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8WZLA CVE: CVE-2024-0639 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 6feb37b3b06e9049e20dcf7e23998f92c9c5be9a ] As &net->sctp.addr_wq_lock is also acquired by the timer sctp_addr_wq_timeout_handler() in protocal.c, the same lock acquisition at sctp_auto_asconf_init() seems should disable irq since it is called from sctp_accept() under process context. Possible deadlock scenario: sctp_accept() -> sctp_sock_migrate() -> sctp_auto_asconf_init() -> spin_lock(&net->sctp.addr_wq_lock) <timer interrupt> -> sctp_addr_wq_timeout_handler() -> spin_lock_bh(&net->sctp.addr_wq_lock); (deadlock here) This flaw was found using an experimental static analysis tool we are developing for irq-related deadlock. The tentative patch fix the potential deadlock by spin_lock_bh(). Signed-off-by: Chengfeng Ye <dg573847474(a)gmail.com> Fixes: 34e5b0118685 ("sctp: delay auto_asconf init until binding the first addr") Acked-by: Xin Long <lucien.xin(a)gmail.com> Link: https://lore.kernel.org/r/20230627120340.19432-1-dg573847474@gmail.com Signed-off-by: Paolo Abeni <pabeni(a)redhat.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Dong Chenchen <dongchenchen2(a)huawei.com> --- net/sctp/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index e9b4ea3d934f..02526c46dddc 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -362,9 +362,9 @@ static void sctp_auto_asconf_init(struct sctp_sock *sp) struct net *net = sock_net(&sp->inet.sk); if (net->sctp.default_auto_asconf) { - spin_lock(&net->sctp.addr_wq_lock); + spin_lock_bh(&net->sctp.addr_wq_lock); list_add_tail(&sp->auto_asconf_list, &net->sctp.auto_asconf_splist); - spin_unlock(&net->sctp.addr_wq_lock); + spin_unlock_bh(&net->sctp.addr_wq_lock); sp->do_auto_asconf = 1; } } -- 2.25.1

2 1

[openeuler:openEuler-1.0-LTS 17814/21628] drivers/edac/skx_common.o: warning: objtool: missing symbol for section .init.text
by kernel test robot 19 Feb '24

19 Feb '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 94f199d2ce0118d64c47192cef7247cf30560eba commit: e34047f6dc606c123911c6db8fa424bb4a035262 [17814/21628] EDAC, skx_edac: Delete duplicated code config: x86_64-buildonly-randconfig-005-20240218 (https://download.01.org/0day-ci/archive/20240219/202402191532.Uvy12NoM-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240219/202402191532.Uvy12NoM-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402191532.Uvy12NoM-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/edac/skx_common.c: In function 'skx_mce_output_error': drivers/edac/skx_common.c:470:15: warning: variable 'type' set but not used [-Wunused-but-set-variable] 470 | char *type, *optype; | ^~~~ drivers/edac/skx_common.c: In function 'skx_get_dimm_info': drivers/edac/skx_common.c:309:79: warning: '_DIMM#' directive output may be truncated writing 6 bytes into a region of size between 0 and 9 [-Wformat-truncation=] 309 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", | ^~~~~~ drivers/edac/skx_common.c:309:52: note: using the range [0, 4294967295] for directive argument 309 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/edac/skx_common.c:309:9: note: 'snprintf' output between 31 and 53 bytes into a destination of size 32 309 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 310 | imc->src_id, imc->lmc, chan, dimmno); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/edac/skx_common.c: In function 'skx_get_nvdimm_info': drivers/edac/skx_common.c:357:79: warning: '_DIMM#' directive output may be truncated writing 6 bytes into a region of size between 0 and 9 [-Wformat-truncation=] 357 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", | ^~~~~~ drivers/edac/skx_common.c:357:52: note: using the range [0, 4294967295] for directive argument 357 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/edac/skx_common.c:357:9: note: 'snprintf' output between 31 and 53 bytes into a destination of size 32 357 | snprintf(dimm->label, sizeof(dimm->label), "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 358 | imc->src_id, imc->lmc, chan, dimmno); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/edac/skx_common.o: warning: objtool: missing symbol for section .init.text -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/4] Add kabi reserve for iommu
by Wang Wensheng 19 Feb '24

19 Feb '24

Wang Wensheng (4): delayacct: Reserve kabi for task_delay_info xarray: Reserve kabi for xa_state sbitmap: Add kabi reserve iommu: Add kabi reserve include/linux/delayacct.h | 3 +++ include/linux/iommu.h | 17 +++++++++++++++++ include/linux/sbitmap.h | 9 +++++++++ include/linux/xarray.h | 3 +++ 4 files changed, 32 insertions(+) -- 2.17.1

2 5

[PATCH OLK-6.6] fs,hugetlb: fix NULL pointer dereference in hugetlbs_fill_super
by Liu Shixin 19 Feb '24

19 Feb '24

From: Oscar Salvador <osalvador(a)suse.de> mainline inclusion from mainline-v6.8-rc4 commit 79d72c68c58784a3e1cd2378669d51bfd0cb7498 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8ZGZK CVE: CVE-2024-0841 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- When configuring a hugetlb filesystem via the fsconfig() syscall, there is a possible NULL dereference in hugetlbfs_fill_super() caused by assigning NULL to ctx->hstate in hugetlbfs_parse_param() when the requested pagesize is non valid. E.g: Taking the following steps: fd = fsopen("hugetlbfs", FSOPEN_CLOEXEC); fsconfig(fd, FSCONFIG_SET_STRING, "pagesize", "1024", 0); fsconfig(fd, FSCONFIG_CMD_CREATE, NULL, NULL, 0); Given that the requested "pagesize" is invalid, ctxt->hstate will be replaced with NULL, losing its previous value, and we will print an error: ... ... case Opt_pagesize: ps = memparse(param->string, &rest); ctx->hstate = h; if (!ctx->hstate) { pr_err("Unsupported page size %lu MB\n", ps / SZ_1M); return -EINVAL; } return 0; ... ... This is a problem because later on, we will dereference ctxt->hstate in hugetlbfs_fill_super() ... ... sb->s_blocksize = huge_page_size(ctx->hstate); ... ... Causing below Oops. Fix this by replacing cxt->hstate value only when then pagesize is known to be valid. kernel: hugetlbfs: Unsupported page size 0 MB kernel: BUG: kernel NULL pointer dereference, address: 0000000000000028 kernel: #PF: supervisor read access in kernel mode kernel: #PF: error_code(0x0000) - not-present page kernel: PGD 800000010f66c067 P4D 800000010f66c067 PUD 1b22f8067 PMD 0 kernel: Oops: 0000 [#1] PREEMPT SMP PTI kernel: CPU: 4 PID: 5659 Comm: syscall Tainted: G E 6.8.0-rc2-default+ #22 5a47c3fef76212addcc6eb71344aabc35190ae8f kernel: Hardware name: Intel Corp. GROVEPORT/GROVEPORT, BIOS GVPRCRB1.86B.0016.D04.1705030402 05/03/2017 kernel: RIP: 0010:hugetlbfs_fill_super+0xb4/0x1a0 kernel: Code: 48 8b 3b e8 3e c6 ed ff 48 85 c0 48 89 45 20 0f 84 d6 00 00 00 48 b8 ff ff ff ff ff ff ff 7f 4c 89 e7 49 89 44 24 20 48 8b 03 <8b> 48 28 b8 00 10 00 00 48 d3 e0 49 89 44 24 18 48 8b 03 8b 40 28 kernel: RSP: 0018:ffffbe9960fcbd48 EFLAGS: 00010246 kernel: RAX: 0000000000000000 RBX: ffff9af5272ae780 RCX: 0000000000372004 kernel: RDX: ffffffffffffffff RSI: ffffffffffffffff RDI: ffff9af555e9b000 kernel: RBP: ffff9af52ee66b00 R08: 0000000000000040 R09: 0000000000370004 kernel: R10: ffffbe9960fcbd48 R11: 0000000000000040 R12: ffff9af555e9b000 kernel: R13: ffffffffa66b86c0 R14: ffff9af507d2f400 R15: ffff9af507d2f400 kernel: FS: 00007ffbc0ba4740(0000) GS:ffff9b0bd7000000(0000) knlGS:0000000000000000 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kernel: CR2: 0000000000000028 CR3: 00000001b1ee0000 CR4: 00000000001506f0 kernel: Call Trace: kernel: <TASK> kernel: ? __die_body+0x1a/0x60 kernel: ? page_fault_oops+0x16f/0x4a0 kernel: ? search_bpf_extables+0x65/0x70 kernel: ? fixup_exception+0x22/0x310 kernel: ? exc_page_fault+0x69/0x150 kernel: ? asm_exc_page_fault+0x22/0x30 kernel: ? __pfx_hugetlbfs_fill_super+0x10/0x10 kernel: ? hugetlbfs_fill_super+0xb4/0x1a0 kernel: ? hugetlbfs_fill_super+0x28/0x1a0 kernel: ? __pfx_hugetlbfs_fill_super+0x10/0x10 kernel: vfs_get_super+0x40/0xa0 kernel: ? __pfx_bpf_lsm_capable+0x10/0x10 kernel: vfs_get_tree+0x25/0xd0 kernel: vfs_cmd_create+0x64/0xe0 kernel: __x64_sys_fsconfig+0x395/0x410 kernel: do_syscall_64+0x80/0x160 kernel: ? syscall_exit_to_user_mode+0x82/0x240 kernel: ? do_syscall_64+0x8d/0x160 kernel: ? syscall_exit_to_user_mode+0x82/0x240 kernel: ? do_syscall_64+0x8d/0x160 kernel: ? exc_page_fault+0x69/0x150 kernel: entry_SYSCALL_64_after_hwframe+0x6e/0x76 kernel: RIP: 0033:0x7ffbc0cb87c9 kernel: Code: 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 97 96 0d 00 f7 d8 64 89 01 48 kernel: RSP: 002b:00007ffc29d2f388 EFLAGS: 00000206 ORIG_RAX: 00000000000001af kernel: RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ffbc0cb87c9 kernel: RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000003 kernel: RBP: 00007ffc29d2f3b0 R08: 0000000000000000 R09: 0000000000000000 kernel: R10: 0000000000000000 R11: 0000000000000206 R12: 0000000000000000 kernel: R13: 00007ffc29d2f4c0 R14: 0000000000000000 R15: 0000000000000000 kernel: </TASK> kernel: Modules linked in: rpcsec_gss_krb5(E) auth_rpcgss(E) nfsv4(E) dns_resolver(E) nfs(E) lockd(E) grace(E) sunrpc(E) netfs(E) af_packet(E) bridge(E) stp(E) llc(E) iscsi_ibft(E) iscsi_boot_sysfs(E) intel_rapl_msr(E) intel_rapl_common(E) iTCO_wdt(E) intel_pmc_bxt(E) sb_edac(E) iTCO_vendor_support(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) coretemp(E) kvm_intel(E) rfkill(E) ipmi_ssif(E) kvm(E) acpi_ipmi(E) irqbypass(E) pcspkr(E) igb(E) ipmi_si(E) mei_me(E) i2c_i801(E) joydev(E) intel_pch_thermal(E) i2c_smbus(E) dca(E) lpc_ich(E) mei(E) ipmi_devintf(E) ipmi_msghandler(E) acpi_pad(E) tiny_power_button(E) button(E) fuse(E) efi_pstore(E) configfs(E) ip_tables(E) x_tables(E) ext4(E) mbcache(E) jbd2(E) hid_generic(E) usbhid(E) sd_mod(E) t10_pi(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) polyval_clmulni(E) ahci(E) xhci_pci(E) polyval_generic(E) gf128mul(E) ghash_clmulni_intel(E) sha512_ssse3(E) sha256_ssse3(E) xhci_pci_renesas(E) libahci(E) ehci_pci(E) sha1_ssse3(E) xhci_hcd(E) ehci_hcd(E) libata(E) kernel: mgag200(E) i2c_algo_bit(E) usbcore(E) wmi(E) sg(E) dm_multipath(E) dm_mod(E) scsi_dh_rdac(E) scsi_dh_emc(E) scsi_dh_alua(E) scsi_mod(E) scsi_common(E) aesni_intel(E) crypto_simd(E) cryptd(E) kernel: Unloaded tainted modules: acpi_cpufreq(E):1 fjes(E):1 kernel: CR2: 0000000000000028 kernel: ---[ end trace 0000000000000000 ]--- kernel: RIP: 0010:hugetlbfs_fill_super+0xb4/0x1a0 kernel: Code: 48 8b 3b e8 3e c6 ed ff 48 85 c0 48 89 45 20 0f 84 d6 00 00 00 48 b8 ff ff ff ff ff ff ff 7f 4c 89 e7 49 89 44 24 20 48 8b 03 <8b> 48 28 b8 00 10 00 00 48 d3 e0 49 89 44 24 18 48 8b 03 8b 40 28 kernel: RSP: 0018:ffffbe9960fcbd48 EFLAGS: 00010246 kernel: RAX: 0000000000000000 RBX: ffff9af5272ae780 RCX: 0000000000372004 kernel: RDX: ffffffffffffffff RSI: ffffffffffffffff RDI: ffff9af555e9b000 kernel: RBP: ffff9af52ee66b00 R08: 0000000000000040 R09: 0000000000370004 kernel: R10: ffffbe9960fcbd48 R11: 0000000000000040 R12: ffff9af555e9b000 kernel: R13: ffffffffa66b86c0 R14: ffff9af507d2f400 R15: ffff9af507d2f400 kernel: FS: 00007ffbc0ba4740(0000) GS:ffff9b0bd7000000(0000) knlGS:0000000000000000 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kernel: CR2: 0000000000000028 CR3: 00000001b1ee0000 CR4: 00000000001506f0 Link: https://lkml.kernel.org/r/20240130210418.3771-1-osalvador@suse.de Fixes: 32021982a324 ("hugetlbfs: Convert to fs_context") Signed-off-by: Michal Hocko <mhocko(a)suse.com> Signed-off-by: Oscar Salvador <osalvador(a)suse.de> Acked-by: Muchun Song <muchun.song(a)linux.dev> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> Signed-off-by: Liu Shixin <liushixin2(a)huawei.com> --- fs/hugetlbfs/inode.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index 86a56890ce01..f001dfe52a14 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -1395,6 +1395,7 @@ static int hugetlbfs_parse_param(struct fs_context *fc, struct fs_parameter *par { struct hugetlbfs_fs_context *ctx = fc->fs_private; struct fs_parse_result result; + struct hstate *h; char *rest; unsigned long ps; int opt; @@ -1439,11 +1440,12 @@ static int hugetlbfs_parse_param(struct fs_context *fc, struct fs_parameter *par case Opt_pagesize: ps = memparse(param->string, &rest); - ctx->hstate = size_to_hstate(ps); - if (!ctx->hstate) { + h = size_to_hstate(ps); + if (!h) { pr_err("Unsupported page size %lu MB\n", ps / SZ_1M); return -EINVAL; } + ctx->hstate = h; return 0; case Opt_min_size: -- 2.25.1

2 1

[PATCH OLK-5.10] fs,hugetlb: fix NULL pointer dereference in hugetlbs_fill_super
by Liu Shixin 19 Feb '24

19 Feb '24

From: Oscar Salvador <osalvador(a)suse.de> mainline inclusion from mainline-v6.8-rc4 commit 79d72c68c58784a3e1cd2378669d51bfd0cb7498 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8ZGZK CVE: CVE-2024-0841 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- When configuring a hugetlb filesystem via the fsconfig() syscall, there is a possible NULL dereference in hugetlbfs_fill_super() caused by assigning NULL to ctx->hstate in hugetlbfs_parse_param() when the requested pagesize is non valid. E.g: Taking the following steps: fd = fsopen("hugetlbfs", FSOPEN_CLOEXEC); fsconfig(fd, FSCONFIG_SET_STRING, "pagesize", "1024", 0); fsconfig(fd, FSCONFIG_CMD_CREATE, NULL, NULL, 0); Given that the requested "pagesize" is invalid, ctxt->hstate will be replaced with NULL, losing its previous value, and we will print an error: ... ... case Opt_pagesize: ps = memparse(param->string, &rest); ctx->hstate = h; if (!ctx->hstate) { pr_err("Unsupported page size %lu MB\n", ps / SZ_1M); return -EINVAL; } return 0; ... ... This is a problem because later on, we will dereference ctxt->hstate in hugetlbfs_fill_super() ... ... sb->s_blocksize = huge_page_size(ctx->hstate); ... ... Causing below Oops. Fix this by replacing cxt->hstate value only when then pagesize is known to be valid. kernel: hugetlbfs: Unsupported page size 0 MB kernel: BUG: kernel NULL pointer dereference, address: 0000000000000028 kernel: #PF: supervisor read access in kernel mode kernel: #PF: error_code(0x0000) - not-present page kernel: PGD 800000010f66c067 P4D 800000010f66c067 PUD 1b22f8067 PMD 0 kernel: Oops: 0000 [#1] PREEMPT SMP PTI kernel: CPU: 4 PID: 5659 Comm: syscall Tainted: G E 6.8.0-rc2-default+ #22 5a47c3fef76212addcc6eb71344aabc35190ae8f kernel: Hardware name: Intel Corp. GROVEPORT/GROVEPORT, BIOS GVPRCRB1.86B.0016.D04.1705030402 05/03/2017 kernel: RIP: 0010:hugetlbfs_fill_super+0xb4/0x1a0 kernel: Code: 48 8b 3b e8 3e c6 ed ff 48 85 c0 48 89 45 20 0f 84 d6 00 00 00 48 b8 ff ff ff ff ff ff ff 7f 4c 89 e7 49 89 44 24 20 48 8b 03 <8b> 48 28 b8 00 10 00 00 48 d3 e0 49 89 44 24 18 48 8b 03 8b 40 28 kernel: RSP: 0018:ffffbe9960fcbd48 EFLAGS: 00010246 kernel: RAX: 0000000000000000 RBX: ffff9af5272ae780 RCX: 0000000000372004 kernel: RDX: ffffffffffffffff RSI: ffffffffffffffff RDI: ffff9af555e9b000 kernel: RBP: ffff9af52ee66b00 R08: 0000000000000040 R09: 0000000000370004 kernel: R10: ffffbe9960fcbd48 R11: 0000000000000040 R12: ffff9af555e9b000 kernel: R13: ffffffffa66b86c0 R14: ffff9af507d2f400 R15: ffff9af507d2f400 kernel: FS: 00007ffbc0ba4740(0000) GS:ffff9b0bd7000000(0000) knlGS:0000000000000000 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kernel: CR2: 0000000000000028 CR3: 00000001b1ee0000 CR4: 00000000001506f0 kernel: Call Trace: kernel: <TASK> kernel: ? __die_body+0x1a/0x60 kernel: ? page_fault_oops+0x16f/0x4a0 kernel: ? search_bpf_extables+0x65/0x70 kernel: ? fixup_exception+0x22/0x310 kernel: ? exc_page_fault+0x69/0x150 kernel: ? asm_exc_page_fault+0x22/0x30 kernel: ? __pfx_hugetlbfs_fill_super+0x10/0x10 kernel: ? hugetlbfs_fill_super+0xb4/0x1a0 kernel: ? hugetlbfs_fill_super+0x28/0x1a0 kernel: ? __pfx_hugetlbfs_fill_super+0x10/0x10 kernel: vfs_get_super+0x40/0xa0 kernel: ? __pfx_bpf_lsm_capable+0x10/0x10 kernel: vfs_get_tree+0x25/0xd0 kernel: vfs_cmd_create+0x64/0xe0 kernel: __x64_sys_fsconfig+0x395/0x410 kernel: do_syscall_64+0x80/0x160 kernel: ? syscall_exit_to_user_mode+0x82/0x240 kernel: ? do_syscall_64+0x8d/0x160 kernel: ? syscall_exit_to_user_mode+0x82/0x240 kernel: ? do_syscall_64+0x8d/0x160 kernel: ? exc_page_fault+0x69/0x150 kernel: entry_SYSCALL_64_after_hwframe+0x6e/0x76 kernel: RIP: 0033:0x7ffbc0cb87c9 kernel: Code: 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 97 96 0d 00 f7 d8 64 89 01 48 kernel: RSP: 002b:00007ffc29d2f388 EFLAGS: 00000206 ORIG_RAX: 00000000000001af kernel: RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ffbc0cb87c9 kernel: RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000003 kernel: RBP: 00007ffc29d2f3b0 R08: 0000000000000000 R09: 0000000000000000 kernel: R10: 0000000000000000 R11: 0000000000000206 R12: 0000000000000000 kernel: R13: 00007ffc29d2f4c0 R14: 0000000000000000 R15: 0000000000000000 kernel: </TASK> kernel: Modules linked in: rpcsec_gss_krb5(E) auth_rpcgss(E) nfsv4(E) dns_resolver(E) nfs(E) lockd(E) grace(E) sunrpc(E) netfs(E) af_packet(E) bridge(E) stp(E) llc(E) iscsi_ibft(E) iscsi_boot_sysfs(E) intel_rapl_msr(E) intel_rapl_common(E) iTCO_wdt(E) intel_pmc_bxt(E) sb_edac(E) iTCO_vendor_support(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) coretemp(E) kvm_intel(E) rfkill(E) ipmi_ssif(E) kvm(E) acpi_ipmi(E) irqbypass(E) pcspkr(E) igb(E) ipmi_si(E) mei_me(E) i2c_i801(E) joydev(E) intel_pch_thermal(E) i2c_smbus(E) dca(E) lpc_ich(E) mei(E) ipmi_devintf(E) ipmi_msghandler(E) acpi_pad(E) tiny_power_button(E) button(E) fuse(E) efi_pstore(E) configfs(E) ip_tables(E) x_tables(E) ext4(E) mbcache(E) jbd2(E) hid_generic(E) usbhid(E) sd_mod(E) t10_pi(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) polyval_clmulni(E) ahci(E) xhci_pci(E) polyval_generic(E) gf128mul(E) ghash_clmulni_intel(E) sha512_ssse3(E) sha256_ssse3(E) xhci_pci_renesas(E) libahci(E) ehci_pci(E) sha1_ssse3(E) xhci_hcd(E) ehci_hcd(E) libata(E) kernel: mgag200(E) i2c_algo_bit(E) usbcore(E) wmi(E) sg(E) dm_multipath(E) dm_mod(E) scsi_dh_rdac(E) scsi_dh_emc(E) scsi_dh_alua(E) scsi_mod(E) scsi_common(E) aesni_intel(E) crypto_simd(E) cryptd(E) kernel: Unloaded tainted modules: acpi_cpufreq(E):1 fjes(E):1 kernel: CR2: 0000000000000028 kernel: ---[ end trace 0000000000000000 ]--- kernel: RIP: 0010:hugetlbfs_fill_super+0xb4/0x1a0 kernel: Code: 48 8b 3b e8 3e c6 ed ff 48 85 c0 48 89 45 20 0f 84 d6 00 00 00 48 b8 ff ff ff ff ff ff ff 7f 4c 89 e7 49 89 44 24 20 48 8b 03 <8b> 48 28 b8 00 10 00 00 48 d3 e0 49 89 44 24 18 48 8b 03 8b 40 28 kernel: RSP: 0018:ffffbe9960fcbd48 EFLAGS: 00010246 kernel: RAX: 0000000000000000 RBX: ffff9af5272ae780 RCX: 0000000000372004 kernel: RDX: ffffffffffffffff RSI: ffffffffffffffff RDI: ffff9af555e9b000 kernel: RBP: ffff9af52ee66b00 R08: 0000000000000040 R09: 0000000000370004 kernel: R10: ffffbe9960fcbd48 R11: 0000000000000040 R12: ffff9af555e9b000 kernel: R13: ffffffffa66b86c0 R14: ffff9af507d2f400 R15: ffff9af507d2f400 kernel: FS: 00007ffbc0ba4740(0000) GS:ffff9b0bd7000000(0000) knlGS:0000000000000000 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kernel: CR2: 0000000000000028 CR3: 00000001b1ee0000 CR4: 00000000001506f0 Link: https://lkml.kernel.org/r/20240130210418.3771-1-osalvador@suse.de Fixes: 32021982a324 ("hugetlbfs: Convert to fs_context") Signed-off-by: Michal Hocko <mhocko(a)suse.com> Signed-off-by: Oscar Salvador <osalvador(a)suse.de> Acked-by: Muchun Song <muchun.song(a)linux.dev> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> Conflicts: fs/hugetlbfs/inode.c Signed-off-by: Liu Shixin <liushixin2(a)huawei.com> --- fs/hugetlbfs/inode.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index 179c860f952a..508c20ef9061 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -1312,6 +1312,7 @@ static int hugetlbfs_parse_param(struct fs_context *fc, struct fs_parameter *par { struct hugetlbfs_fs_context *ctx = fc->fs_private; struct fs_parse_result result; + struct hstate *h; char *rest; unsigned long ps; int opt; @@ -1356,11 +1357,12 @@ static int hugetlbfs_parse_param(struct fs_context *fc, struct fs_parameter *par case Opt_pagesize: ps = memparse(param->string, &rest); - ctx->hstate = size_to_hstate(ps); - if (!ctx->hstate) { + h = size_to_hstate(ps); + if (!h) { pr_err("Unsupported page size %lu MB\n", ps >> 20); return -EINVAL; } + ctx->hstate = h; return 0; case Opt_min_size: -- 2.25.1

2 1

[openeuler:OLK-5.10] BUILD REGRESSION a93c31a2b57d14fc10517b0c4bbaacd531b37374
by kernel test robot 19 Feb '24

19 Feb '24

tree/branch: https://gitee.com/openeuler/kernel.git OLK-5.10 branch HEAD: a93c31a2b57d14fc10517b0c4bbaacd531b37374 !4562 v4 tracing: Backport bugfixes Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- arm64-defconfig | |-- drivers-crypto-hisilicon-qm.c:warning:strncpy-specified-bound-depends-on-the-length-of-the-source-argument | |-- drivers-net-ethernet-hisilicon-hns3-hns3_ethtool.c:warning:hns3_unic_ethtool_ops-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_bios_common_reg-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_igu_egu_reg-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ncsi_reg-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ppp_reg-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_rcb_reg-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_rpu_reg_0-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_rpu_reg_1-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_rtc_reg-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ssu_reg_0-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ssu_reg_1-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ssu_reg_2-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_tqp_reg-defined-but-not-used | |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_main.c:warning:unused-variable-ae_dev | `-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_mbx.c:warning:unused-variable-hdev |-- x86_64-buildonly-randconfig-006-20240218 | `-- kernel-sched-topology.c:error:implicit-declaration-of-function-register_sysctl_init `-- x86_64-randconfig-121-20240218 |-- arch-x86-kernel-cpu-common.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-const-noderef-__percpu-__vpp_verify-got-unsigned-short `-- mm-damon-core-test.h:sparse:sparse:incompatible-types-in-comparison-expression-(different-signedness): clang_recent_errors |-- x86_64-allmodconfig | |-- drivers-gpio-gpio-hisi.c:warning:variable-clr-set-but-not-used | |-- drivers-gpio-gpio-hisi.c:warning:variable-dat-set-but-not-used | |-- drivers-gpio-gpio-hisi.c:warning:variable-set-set-but-not-used | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_chip.c:warning:no-previous-prototype-for-function-sss_tool_adm_csr_rd32 | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_chip.c:warning:no-previous-prototype-for-function-sss_tool_adm_csr_wr32 | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_chip.c:warning:no-previous-prototype-for-function-sss_tool_send_clp_msg | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_alloc_in_buf | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_alloc_out_buf | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_copy_to_user | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_free_in_buf | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_free_out_buf | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_sdk.c:warning:no-previous-prototype-for-function-sss_tool_get_func_id | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_sdk.c:warning:no-previous-prototype-for-function-sss_tool_get_func_type | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_sdk.c:warning:no-previous-prototype-for-function-sss_tool_get_hw_driver_stats | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm.c:warning:no-previous-prototype-for-function-sss_adm_msg_read | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm.c:warning:no-previous-prototype-for-function-sss_adm_msg_read_ack | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm.c:warning:no-previous-prototype-for-function-sss_adm_msg_write | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm.c:warning:no-previous-prototype-for-function-sss_adm_msg_write_nack | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm_init.c:warning:no-previous-prototype-for-function-sss_destroy_adm_msg | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_export.c:warning:no-previous-prototype-for-function-sss_get_func_id | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_dcb.c:warning:no-previous-prototype-for-function-sss_tool_dcb_mt_dcb_state | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_dcb.c:warning:no-previous-prototype-for-function-sss_tool_dcb_mt_hw_qos_get | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_dcb.c:warning:no-previous-prototype-for-function-sss_tool_dcb_mt_qos_map | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_func.c:warning:no-previous-prototype-for-function-sss_tool_ioctl | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_loopback_mode | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_netdev_name | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_netdev_tx_timeout | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_pf_bw_limit | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_xsfp_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_xsfp_present | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_set_link_mode | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_set_loopback_mode | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_set_netdev_tx_timeout | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_set_pf_bw_limit | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_inter_num | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_q_num | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_rx_cqe_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_rx_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_rx_wqe_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_tx_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_tx_wqe_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_stats.c:warning:no-previous-prototype-for-function-sss_tool_clear_func_stats | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_stats.c:warning:no-previous-prototype-for-function-sss_tool_get_sset_count | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_stats.c:warning:no-previous-prototype-for-function-sss_tool_get_sset_stats | |-- drivers-net-ethernet-3snic-sssnic-nic-sss_nic_ethtool_stats_api.c:warning:no-previous-prototype-for-function-sss_nic_get_io_stats_size | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_irq_type | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_match | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_set_vendor_irqs | |-- drivers-vfio-pci-vfio_pci_rdwr.c:warning:no-previous-prototype-for-function-vfio_pci_get_barmap | `-- mm-hugetlb.c:warning:variable-gfp-set-but-not-used |-- x86_64-allnoconfig | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-allyesconfig | |-- arch-x86-lib-copy_highpages.c:warning:no-previous-prototype-for-function-sysctl_hugepage_nocache_copy | |-- drivers-gpio-gpio-hisi.c:warning:variable-clr-set-but-not-used | |-- drivers-gpio-gpio-hisi.c:warning:variable-dat-set-but-not-used | |-- drivers-gpio-gpio-hisi.c:warning:variable-set-set-but-not-used | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_chip.c:warning:no-previous-prototype-for-function-sss_tool_adm_csr_rd32 | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_chip.c:warning:no-previous-prototype-for-function-sss_tool_adm_csr_wr32 | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_chip.c:warning:no-previous-prototype-for-function-sss_tool_send_clp_msg | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_alloc_in_buf | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_alloc_out_buf | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_copy_to_user | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_free_in_buf | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_main.c:warning:no-previous-prototype-for-function-sss_tool_free_out_buf | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_sdk.c:warning:no-previous-prototype-for-function-sss_tool_get_func_id | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_sdk.c:warning:no-previous-prototype-for-function-sss_tool_get_func_type | |-- drivers-net-ethernet-3snic-sssnic-hw-.-tool-sss_tool_sdk.c:warning:no-previous-prototype-for-function-sss_tool_get_hw_driver_stats | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm.c:warning:no-previous-prototype-for-function-sss_adm_msg_read | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm.c:warning:no-previous-prototype-for-function-sss_adm_msg_read_ack | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm.c:warning:no-previous-prototype-for-function-sss_adm_msg_write | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm.c:warning:no-previous-prototype-for-function-sss_adm_msg_write_nack | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_adm_init.c:warning:no-previous-prototype-for-function-sss_destroy_adm_msg | |-- drivers-net-ethernet-3snic-sssnic-hw-sss_hwif_export.c:warning:no-previous-prototype-for-function-sss_get_func_id | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_dcb.c:warning:no-previous-prototype-for-function-sss_tool_dcb_mt_dcb_state | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_dcb.c:warning:no-previous-prototype-for-function-sss_tool_dcb_mt_hw_qos_get | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_dcb.c:warning:no-previous-prototype-for-function-sss_tool_dcb_mt_qos_map | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_func.c:warning:no-previous-prototype-for-function-sss_tool_ioctl | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_loopback_mode | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_netdev_name | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_netdev_tx_timeout | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_pf_bw_limit | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_xsfp_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_get_xsfp_present | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_set_link_mode | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_set_loopback_mode | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_set_netdev_tx_timeout | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_phy_attr.c:warning:no-previous-prototype-for-function-sss_tool_set_pf_bw_limit | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_inter_num | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_q_num | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_rx_cqe_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_rx_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_rx_wqe_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_tx_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_qp_info.c:warning:no-previous-prototype-for-function-sss_tool_get_tx_wqe_info | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_stats.c:warning:no-previous-prototype-for-function-sss_tool_clear_func_stats | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_stats.c:warning:no-previous-prototype-for-function-sss_tool_get_sset_count | |-- drivers-net-ethernet-3snic-sssnic-nic-.-tool-sss_tool_nic_stats.c:warning:no-previous-prototype-for-function-sss_tool_get_sset_stats | |-- drivers-net-ethernet-3snic-sssnic-nic-sss_nic_ethtool_stats_api.c:warning:no-previous-prototype-for-function-sss_nic_get_io_stats_size | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_irq_type | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_match | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_set_vendor_irqs | |-- drivers-vfio-pci-vfio_pci_rdwr.c:warning:no-previous-prototype-for-function-vfio_pci_get_barmap | |-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register | |-- ld.lld:error:duplicate-symbol:g_card_node_array | `-- mm-hugetlb.c:warning:variable-gfp-set-but-not-used |-- x86_64-buildonly-randconfig-001-20240218 | |-- arch-x86-lib-copy_highpages.c:warning:no-previous-prototype-for-function-sysctl_hugepage_nocache_copy | |-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register | `-- mm-hugetlb.c:warning:variable-gfp-set-but-not-used |-- x86_64-buildonly-randconfig-004-20240218 | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-randconfig-001-20240218 | |-- arch-x86-lib-copy_highpages.c:warning:no-previous-prototype-for-function-sysctl_hugepage_nocache_copy | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-randconfig-002-20240218 | |-- arch-x86-lib-copy_highpages.c:warning:no-previous-prototype-for-function-sysctl_hugepage_nocache_copy | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-randconfig-006-20240218 | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-randconfig-011-20240218 | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_irq_type | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_match | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_set_vendor_irqs | |-- drivers-vfio-pci-vfio_pci_rdwr.c:warning:no-previous-prototype-for-function-vfio_pci_get_barmap | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-randconfig-013-20240218 | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_irq_type | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_match | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_set_vendor_irqs | |-- drivers-vfio-pci-vfio_pci_rdwr.c:warning:no-previous-prototype-for-function-vfio_pci_get_barmap | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-randconfig-014-20240218 | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_irq_type | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_match | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_set_vendor_irqs | |-- drivers-vfio-pci-vfio_pci_rdwr.c:warning:no-previous-prototype-for-function-vfio_pci_get_barmap | |-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register | `-- mm-hugetlb.c:warning:variable-gfp-set-but-not-used |-- x86_64-randconfig-016-20240218 | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_irq_type | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_match | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_set_vendor_irqs | |-- drivers-vfio-pci-vfio_pci_rdwr.c:warning:no-previous-prototype-for-function-vfio_pci_get_barmap | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-randconfig-072-20240218 | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-randconfig-075-20240218 | |-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register | `-- mm-hugetlb.c:warning:variable-gfp-set-but-not-used |-- x86_64-randconfig-122-20240218 | |-- arch-x86-kernel-cpu-common.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-const-noderef-__percpu-__vpp_verify-got-unsigned-short | `-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register |-- x86_64-randconfig-123-20240218 | |-- arch-x86-kernel-cpu-common.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-const-noderef-__percpu-__vpp_verify-got-unsigned-short | |-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register | `-- mm-hugetlb.c:warning:variable-gfp-set-but-not-used |-- x86_64-randconfig-161-20240218 | |-- arch-x86-events-zhaoxin-uncore.c-uncore_pci_probe()-warn:possible-memory-leak-of-boxes | |-- arch-x86-events-zhaoxin-uncore.c-uncore_pmu_disable()-warn:can-uncore_pmu-even-be-NULL | |-- arch-x86-events-zhaoxin-uncore.c-uncore_pmu_enable()-warn:can-uncore_pmu-even-be-NULL | |-- arch-x86-lib-copy_highpages.c:warning:no-previous-prototype-for-function-sysctl_hugepage_nocache_copy | |-- drivers-rtc-rtc-mc146818-lib.c-mc146818_set_time()-error:uninitialized-symbol-save_freq_select-. | |-- drivers-scsi-sd.c-sd_spinup_disk()-warn:unsigned-the_result-is-never-less-than-zero. | |-- drivers-vfio-vfio_iommu_type1.c-vfio_iommu_bind_group()-error:uninitialized-symbol-ret-. | |-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register | |-- mm-hugetlb.c-hugepages_setup()-warn:potential-spectre-issue-default_hugepages_in_node-w | |-- mm-hugetlb.c-hugepages_setup()-warn:potential-spectre-issue-parsed_hstate-max_huge_pages_node-w | `-- mm-hugetlb.c:warning:variable-gfp-set-but-not-used `-- x86_64-rhel-8.3-rust |-- arch-x86-lib-copy_highpages.c:warning:no-previous-prototype-for-function-sysctl_hugepage_nocache_copy |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_irq_type |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_match |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_set_vendor_irqs |-- drivers-vfio-pci-vfio_pci_rdwr.c:warning:no-previous-prototype-for-function-vfio_pci_get_barmap |-- kernel-static_call.c:warning:no-previous-prototype-for-function-klp_static_call_register `-- mm-hugetlb.c:warning:variable-gfp-set-but-not-used elapsed time: 943m configs tested: 36 configs skipped: 147 tested configs: arm64 allmodconfig clang arm64 allnoconfig gcc arm64 defconfig gcc arm64 randconfig-001-20240218 clang arm64 randconfig-002-20240218 clang arm64 randconfig-003-20240218 clang arm64 randconfig-004-20240218 gcc um x86_64_defconfig gcc x86_64 allnoconfig clang x86_64 allyesconfig clang x86_64 buildonly-randconfig-001-20240218 clang x86_64 buildonly-randconfig-002-20240218 gcc x86_64 buildonly-randconfig-003-20240218 gcc x86_64 buildonly-randconfig-004-20240218 clang x86_64 buildonly-randconfig-005-20240218 gcc x86_64 buildonly-randconfig-006-20240218 gcc x86_64 defconfig gcc x86_64 randconfig-001-20240218 clang x86_64 randconfig-002-20240218 clang x86_64 randconfig-003-20240218 gcc x86_64 randconfig-004-20240218 gcc x86_64 randconfig-005-20240218 gcc x86_64 randconfig-006-20240218 clang x86_64 randconfig-011-20240218 clang x86_64 randconfig-012-20240218 gcc x86_64 randconfig-013-20240218 clang x86_64 randconfig-014-20240218 clang x86_64 randconfig-015-20240218 gcc x86_64 randconfig-016-20240218 clang x86_64 randconfig-071-20240218 gcc x86_64 randconfig-072-20240218 clang x86_64 randconfig-073-20240218 gcc x86_64 randconfig-074-20240218 gcc x86_64 randconfig-075-20240218 clang x86_64 randconfig-076-20240218 gcc x86_64 rhel-8.3-rust clang -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 3176/3186] drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3988:39: warning: variable 'pre_addr' is uninitialized when used here
by kernel test robot 19 Feb '24

19 Feb '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 181ab23277f274c13c335d037d654b2879de50ca commit: 86b90dc581ce2fcc6b724b4ffaea6103122a4b68 [3176/3186] iommu/arm-smmu-v3: Add support for ECMDQ register mode config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20240219/202402190254.FDaGb5YO-lkp@…) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 36adfec155de366d722f2bac8ff9162289dcf06c) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240219/202402190254.FDaGb5YO-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402190254.FDaGb5YO-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3988:39: warning: variable 'pre_addr' is uninitialized when used here [-Wuninitialized] 3988 | if (i && ((val & ECMDQ_CP_ADDR) != (pre_addr + ECMDQ_CP_RRESET_SIZE))) { | ^~~~~~~~ drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3979:20: note: initialize the variable 'pre_addr' to silence this warning 3979 | u64 val, pre_addr; | ^ | = 0 1 warning generated. vim +/pre_addr +3988 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c 3957 3958 static int arm_smmu_ecmdq_probe(struct arm_smmu_device *smmu) 3959 { 3960 int ret, cpu; 3961 u32 i, nump, numq, gap; 3962 u32 reg, shift_increment; 3963 u64 addr, smmu_dma_base; 3964 void __iomem *cp_regs, *cp_base; 3965 3966 /* IDR6 */ 3967 reg = readl_relaxed(smmu->base + ARM_SMMU_IDR6); 3968 nump = 1 << FIELD_GET(IDR6_LOG2NUMP, reg); 3969 numq = 1 << FIELD_GET(IDR6_LOG2NUMQ, reg); 3970 smmu->nr_ecmdq = nump * numq; 3971 gap = ECMDQ_CP_RRESET_SIZE >> FIELD_GET(IDR6_LOG2NUMQ, reg); 3972 3973 smmu_dma_base = (vmalloc_to_pfn(smmu->base) << PAGE_SHIFT); 3974 cp_regs = ioremap(smmu_dma_base + ARM_SMMU_ECMDQ_CP_BASE, PAGE_SIZE); 3975 if (!cp_regs) 3976 return -ENOMEM; 3977 3978 for (i = 0; i < nump; i++) { 3979 u64 val, pre_addr; 3980 3981 val = readq_relaxed(cp_regs + 32 * i); 3982 if (!(val & ECMDQ_CP_PRESET)) { 3983 iounmap(cp_regs); 3984 dev_err(smmu->dev, "ecmdq control page %u is memory mode\n", i); 3985 return -EFAULT; 3986 } 3987 > 3988 if (i && ((val & ECMDQ_CP_ADDR) != (pre_addr + ECMDQ_CP_RRESET_SIZE))) { 3989 iounmap(cp_regs); 3990 dev_err(smmu->dev, "ecmdq_cp memory region is not contiguous\n"); 3991 return -EFAULT; 3992 } 3993 3994 pre_addr = val & ECMDQ_CP_ADDR; 3995 } 3996 3997 addr = readl_relaxed(cp_regs) & ECMDQ_CP_ADDR; 3998 iounmap(cp_regs); 3999 4000 cp_base = devm_ioremap(smmu->dev, smmu_dma_base + addr, ECMDQ_CP_RRESET_SIZE * nump); 4001 if (!cp_base) 4002 return -ENOMEM; 4003 4004 smmu->ecmdq = devm_alloc_percpu(smmu->dev, struct arm_smmu_ecmdq *); 4005 if (!smmu->ecmdq) 4006 return -ENOMEM; 4007 4008 ret = arm_smmu_ecmdq_layout(smmu); 4009 if (ret) 4010 return ret; 4011 4012 shift_increment = order_base_2(num_possible_cpus() / smmu->nr_ecmdq); 4013 4014 addr = 0; 4015 for_each_possible_cpu(cpu) { 4016 struct arm_smmu_ecmdq *ecmdq; 4017 struct arm_smmu_queue *q; 4018 4019 ecmdq = *per_cpu_ptr(smmu->ecmdq, cpu); 4020 ecmdq->base = cp_base + addr; 4021 4022 q = &ecmdq->cmdq.q; 4023 4024 q->llq.max_n_shift = ECMDQ_MAX_SZ_SHIFT + shift_increment; 4025 ret = arm_smmu_init_one_queue(smmu, q, ecmdq->base, ARM_SMMU_ECMDQ_PROD, 4026 ARM_SMMU_ECMDQ_CONS, CMDQ_ENT_DWORDS, "ecmdq"); 4027 if (ret) 4028 return ret; 4029 4030 q->ecmdq_prod = ECMDQ_PROD_EN; 4031 rwlock_init(&q->ecmdq_lock); 4032 4033 ret = arm_smmu_ecmdq_init(&ecmdq->cmdq); 4034 if (ret) { 4035 dev_err(smmu->dev, "ecmdq[%d] init failed\n", i); 4036 return ret; 4037 } 4038 4039 addr += gap; 4040 } 4041 4042 return 0; 4043 } 4044 #endif 4045 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0