- Kernel - mailweb.openeuler.org

[PATCH] acpi/arm64: check the returned logical CPU number of 'acpi_map_cpuid()'
by Yang Yingliang 22 Sep '20

22 Sep '20

From: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> hulk inclusion category: bugfix bugzilla: NA CVE: NA --------------------------- When we set 'nr_cpus=1' in kernel parameter, we get the following error. It's because 'acpi_map_cpuid()' return -ENODEV in 'acpi_map_cpu()' when there are not enough logical CPU numbers. So we need to check the returned logical CPU number and return error if it is negative. 'acpi_map_cpu' when there are not enough logical CPU [ 0.025955] Unable to handle kernel paging request at virtual address ffff00002915b828 [ 0.025958] Mem abort info: [ 0.025959] ESR = 0x96000006 [ 0.025961] Exception class = DABT (current EL), IL = 32 bits [ 0.025963] SET = 0, FnV = 0 [ 0.025965] EA = 0, S1PTW = 0 [ 0.025966] Data abort info: [ 0.025968] ISV = 0, ISS = 0x00000006 [ 0.025970] CM = 0, WnR = 0 [ 0.025972] swapper pgtable: 4k pages, 48-bit VAs, pgdp = (____ptrval____) [ 0.025974] [ffff00002915b828] pgd=000000013fffe003, pud=000000013fffd003, pmd=0000000000000000 [ 0.025979] Internal error: Oops: 96000006 [#1] SMP [ 0.025981] Modules linked in: [ 0.025983] Process swapper/0 (pid: 1, stack limit = 0x(____ptrval____)) [ 0.025986] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.19.141+ #37 [ 0.025988] Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015 [ 0.025991] pstate: a0c00005 (NzCv daif +PAN +UAO) [ 0.025993] pc : acpi_map_cpu+0xe0/0x170 [ 0.025996] lr : acpi_map_cpu+0xb8/0x170 [ 0.025997] sp : ffff8000fef1fa50 [ 0.025999] x29: ffff8000fef1fa50 x28: ffff000008e22058 [ 0.026001] x27: ffff0000092a6000 x26: ffff000008d60778 [ 0.026004] x25: ffff0000094c3000 x24: 0000000000000001 [ 0.026006] x23: ffff8000fe802c18 x22: 00000000ffffffff [ 0.026008] x21: ffff000008a16000 x20: ffff000008a16a20 [ 0.026011] x19: 00000000ffffffed x18: ffffffffffffffff [ 0.026013] x17: 0000000087411dcf x16: 00000000b93a5600 [ 0.026015] x15: ffff000009159708 x14: 0720072007200720 [ 0.026018] x13: 0720072007200720 x12: 0720072007200720 [ 0.026020] x11: 072007200720073d x10: 073d073d073d073d [ 0.026022] x9 : 073d073d073d0764 x8 : 0765076607660766 [ 0.026024] x7 : 0766076607660778 x6 : 0000000000000130 [ 0.026027] x5 : ffff0000085955c8 x4 : 0000000000000000 [ 0.026029] x3 : 0000000000000000 x2 : ffff00000915b830 [ 0.026031] x1 : ffff00002915b828 x0 : 0000200000000000 [ 0.026033] Call trace: [ 0.026035] acpi_map_cpu+0xe0/0x170 [ 0.026038] acpi_processor_add+0x44c/0x640 [ 0.026040] acpi_bus_attach+0x174/0x218 [ 0.026043] acpi_bus_attach+0xa8/0x218 [ 0.026045] acpi_bus_attach+0xa8/0x218 [ 0.026047] acpi_bus_attach+0xa8/0x218 [ 0.026049] acpi_bus_scan+0x58/0xb8 [ 0.026052] acpi_scan_init+0xf4/0x234 [ 0.026054] acpi_init+0x318/0x384 [ 0.026056] do_one_initcall+0x54/0x250 [ 0.026059] kernel_init_freeable+0x2d4/0x3c0 [ 0.026061] kernel_init+0x18/0x118 [ 0.026063] ret_from_fork+0x10/0x18 [ 0.026066] Code: d2800020 9120c042 8b010c41 9ad32000 (f820303f) Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> Reviewed-by: Hanjun Guo <guohanjun(a)huawei.com> Reviewed-by: Keqian Zhu <zhukeqian1(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- arch/arm64/kernel/acpi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c index 73eb04f997a7..729733536cb4 100644 --- a/arch/arm64/kernel/acpi.c +++ b/arch/arm64/kernel/acpi.c @@ -270,6 +270,10 @@ int acpi_map_cpu(acpi_handle handle, phys_cpuid_t physid, u32 acpi_id, int cpu, nid; cpu = acpi_map_cpuid(physid, acpi_id); + if (cpu < 0) { + pr_info("Unable to map GICC to logical cpu number\n"); + return cpu; + } nid = acpi_get_node(handle); if (nid != NUMA_NO_NODE) { set_cpu_numa_node(cpu, nid); -- 2.25.1

1 0

[PATCH 0/9] backport stable-4.19.145
by Yang Yingliang 22 Sep '20

22 Sep '20

Greg Kroah-Hartman (1): Linux 4.19.145 Jakub Kicinski (1): net: disable netpoll on fresh napis Jens Axboe (1): block: ensure bdi->io_pages is always initialized Kamil Lorenc (1): net: usb: dm9601: Add USB ID of Keenetic Plus DSL Paul Moore (1): netlabel: fix problems with mapping removal Roi Dayan (1): net/mlx5e: Don't support phys switch id if not in switchdev mode Takashi Sakamoto (1): ALSA; firewire-tascam: exclude Tascam FE-8 from detection Tetsuo Handa (1): tipc: fix shutdown() of connectionless socket Xin Long (1): sctp: not disable bh in the whole sctp_get_port_local() Makefile | 2 +- block/blk-core.c | 2 + .../net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- drivers/net/usb/dm9601.c | 4 ++ net/core/dev.c | 3 +- net/core/netpoll.c | 2 +- net/netlabel/netlabel_domainhash.c | 59 ++++++++++--------- net/sctp/socket.c | 16 ++--- net/tipc/socket.c | 9 ++- sound/firewire/tascam/tascam.c | 30 +++++++++- 10 files changed, 82 insertions(+), 47 deletions(-) -- 2.25.1

1 9

[PATCH 00/79] backport stable-4.19.144
by Yang Yingliang 22 Sep '20

22 Sep '20

Al Grant (1): perf tools: Correct SNOOPX field offset Al Viro (1): fix regression in "epoll: Keep a reference on files added to the check list" Amit Engel (1): nvmet: Disable keep-alive timer when kato is cleared to 0h Bodo Stroesser (2): scsi: target: tcmu: Fix size in calls to tcmu_flush_dcache_range scsi: target: tcmu: Optimize use of flush_dcache_page Christophe JAILLET (1): nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()' Dan Carpenter (1): net: gemini: Fix another missing clk_disable_unprepare() in probe Dan Crawford (1): ALSA: hda - Fix silent audio output and corrupted input on MSI X570-A PRO Daniel Borkmann (1): uaccess: Add non-pagefault user-space write function Daniele Palmas (1): net: usb: qmi_wwan: add Telit 0x1050 composition Darrick J. Wong (1): xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files Dinghao Liu (3): net: hns: Fix memleak in hns_nic_dev_probe net: systemport: Fix memleak in bcm_sysport_probe net: arc_emac: Fix memleak in arc_mdio_probe Dmitry Baryshkov (1): drm/msm/a6xx: fix gmu start on newer firmware Edwin Peer (1): bnxt_en: fix HWRM error when querying VF temperature Florian Fainelli (2): MIPS: mm: BMIPS5000 has inclusive physical caches MIPS: BMIPS: Also call bmips_cpu_setup() for secondary cores Florian Westphal (1): netfilter: nf_tables: fix destination register zeroing Greg Kroah-Hartman (1): Linux 4.19.144 Himadri Pandya (1): net: usb: Fix uninit-was-stored issue in asix_read_phy_addr() Huang Ying (1): x86, fakenuma: Fix invalid starting node ID Jakub Kicinski (1): bnxt: don't enable NAPI until rings are ready James Morse (4): KVM: arm64: Add kvm_extable for vaxorcism code KVM: arm64: Defer guest entry when an asynchronous exception is pending KVM: arm64: Survive synchronous exceptions caused by AT instructions KVM: arm64: Set HCR_EL2.PTW to prevent AT taking synchronous exception Jason Gunthorpe (1): include/linux/log2.h: add missing () around n in roundup_pow_of_two() Jeff Layton (1): ceph: don't allow setlease on cephfs Jesper Dangaard Brouer (1): selftests/bpf: Fix massive output from test_maps Johannes Berg (1): cfg80211: regulatory: reject invalid hints John Stultz (1): tty: serial: qcom_geni_serial: Drop __init from qcom_geni_console_setup Josef Bacik (3): btrfs: drop path before adding new uuid tree entry btrfs: set the lockdep class for log tree extent buffers btrfs: fix potential deadlock in the search ioctl Jussi Kivilinna (1): batman-adv: bla: use netif_rx_ni when not in interrupt context Kai Vehmanen (1): ALSA: hda/hdmi: always check pin power status in i915 pin fixup Kim Phillips (1): perf record/stat: Explicitly call out event modifiers in the documentation Krishna Manikandan (1): drm/msm: add shutdown support for display platform_driver Linus Lüssing (1): batman-adv: Fix own OGM check in aggregated OGMs Lu Baolu (1): iommu/vt-d: Serialize IOMMU GCMD register modifications Marc Zyngier (2): HID: core: Correctly handle ReportSize being zero HID: core: Sanitize event code and type when mapping input Marek Szyprowski (1): dmaengine: pl330: Fix burst length if burst size is smaller than bus width Masami Hiramatsu (1): uaccess: Add non-pagefault user-space read functions Max Staudt (1): affs: fix basic permission bits to actually work Michael Chan (1): tg3: Fix soft lockup when tg3_reset_task() fails. Mikulas Patocka (3): ext2: don't update mtime on COW faults xfs: don't update mtime on COW faults dm writecache: handle DAX to partitions on persistent memory correctly Ming Lei (1): block: allow for_each_bvec to support zero len bvec Mrinal Pandey (1): checkpatch: fix the usage of capture group ( ... ) Namhyung Kim (1): perf jevents: Fix suspicious code in fixregex() Nicolas Dichtel (1): gtp: add GTPA_LINK info to msg sent to userspace Nikolay Borisov (2): btrfs: Remove redundant extent_buffer_get in get_old_root btrfs: Remove extraneous extent_buffer_get from tree_mod_log_rewind Pablo Neira Ayuso (3): netfilter: nf_tables: add NFTA_SET_USERDATA if not null netfilter: nf_tables: incorrect enum nft_list_attributes definition netfilter: nfnetlink: nfnetlink_unicast() reports EAGAIN instead of ENOBUFS Pavan Chebbi (1): bnxt_en: Don't query FW when netif_running() is false. Peter Ujfalusi (1): dmaengine: of-dma: Fix of_dma_router_xlate's of_dma_xlate handling Peter Zijlstra (1): cpuidle: Fixup IRQ state Rogan Dawes (1): usb: qmi_wwan: add D-Link DWM-222 A2 device ID Sean Young (2): media: rc: do not access device via sysfs after rc_unregister_device() media: rc: uevent sysfs file races with rc_unregister_device() Shung-Hsi Yu (1): net: ethernet: mlx4: Fix memory allocation in mlx4_buddy_init() Simon Leiner (1): xen/xenbus: Fix granting of vmalloc'd memory Sven Eckelmann (1): batman-adv: Avoid uninitialized chaddr when handling DHCP Sven Schnelle (1): s390: don't trace preemption in percpu macros Takashi Iwai (1): ALSA: pcm: oss: Remove superfluous WARN_ON() for mulaw sanity check Takashi Sakamoto (1): ALSA: firewire-digi00x: exclude Avid Adrenaline from detection Tejun Heo (1): libata: implement ATA_HORKAGE_MAX_TRIM_128M and apply to Sandisks Tom Rix (1): hwmon: (applesmc) check status earlier. Tong Zhang (1): ALSA: ca0106: fix error code handling Tony Lindgren (1): thermal: ti-soc-thermal: Fix bogus thermal shutdowns for omap4430 Vasundhara Volam (2): bnxt_en: Check for zero dir entries in NVRAM. bnxt_en: Fix PCI AER error recovery flow Yu Kuai (1): dmaengine: at_hdmac: check return value of of_find_device_by_node() in at_dma_xlate() Yuusuke Ashizuka (1): ravb: Fixed to be able to unload modules Documentation/filesystems/affs.txt | 16 +- Makefile | 2 +- arch/arm64/include/asm/kvm_arm.h | 3 +- arch/arm64/include/asm/kvm_asm.h | 43 +++++ arch/arm64/kernel/vmlinux.lds.S | 8 + arch/arm64/kvm/hyp/entry.S | 31 +++- arch/arm64/kvm/hyp/hyp-entry.S | 66 ++++--- arch/arm64/kvm/hyp/switch.c | 39 +++- arch/mips/kernel/smp-bmips.c | 2 + arch/mips/mm/c-r4k.c | 4 + arch/s390/include/asm/percpu.h | 28 +-- arch/x86/mm/numa_emulation.c | 2 +- drivers/ata/libata-core.c | 5 +- drivers/ata/libata-scsi.c | 8 +- drivers/cpuidle/cpuidle.c | 3 +- drivers/dma/at_hdmac.c | 2 + drivers/dma/of-dma.c | 8 +- drivers/dma/pl330.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 12 +- drivers/gpu/drm/msm/msm_drv.c | 8 + drivers/hid/hid-core.c | 15 +- drivers/hid/hid-input.c | 4 + drivers/hid/hid-multitouch.c | 2 + drivers/hwmon/applesmc.c | 31 ++-- drivers/iommu/intel_irq_remapping.c | 10 +- drivers/md/dm-writecache.c | 12 +- drivers/media/rc/rc-main.c | 44 +++-- drivers/net/ethernet/arc/emac_mdio.c | 1 + drivers/net/ethernet/broadcom/bcmsysport.c | 6 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 +-- .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 5 +- drivers/net/ethernet/broadcom/tg3.c | 17 +- drivers/net/ethernet/cortina/gemini.c | 34 ++-- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 9 +- drivers/net/ethernet/mellanox/mlx4/mr.c | 2 +- drivers/net/ethernet/renesas/ravb_main.c | 110 ++++++------ drivers/net/gtp.c | 1 + drivers/net/usb/asix_common.c | 2 +- drivers/net/usb/qmi_wwan.c | 2 + drivers/nvme/target/core.c | 6 + drivers/nvme/target/fc.c | 4 +- drivers/target/target_core_user.c | 15 +- .../ti-soc-thermal/omap4-thermal-data.c | 23 +-- .../thermal/ti-soc-thermal/omap4xxx-bandgap.h | 10 +- drivers/tty/serial/qcom_geni_serial.c | 2 +- drivers/xen/xenbus/xenbus_client.c | 10 +- fs/affs/amigaffs.c | 27 +++ fs/affs/file.c | 26 ++- fs/btrfs/ctree.c | 8 +- fs/btrfs/extent_io.c | 8 +- fs/btrfs/extent_io.h | 6 +- fs/btrfs/ioctl.c | 27 ++- fs/btrfs/volumes.c | 3 +- fs/ceph/file.c | 1 + fs/eventpoll.c | 6 +- fs/ext2/file.c | 6 +- fs/xfs/libxfs/xfs_bmap.c | 2 +- fs/xfs/xfs_file.c | 12 +- include/linux/bvec.h | 9 +- include/linux/hid.h | 42 +++-- include/linux/libata.h | 1 + include/linux/log2.h | 2 +- include/linux/netfilter/nfnetlink.h | 3 +- include/linux/uaccess.h | 26 +++ include/net/netfilter/nf_tables.h | 2 + include/uapi/linux/netfilter/nf_tables.h | 2 +- mm/maccess.c | 167 ++++++++++++++++-- net/batman-adv/bat_v_ogm.c | 11 +- net/batman-adv/bridge_loop_avoidance.c | 5 +- net/batman-adv/gateway_client.c | 6 +- net/netfilter/nf_tables_api.c | 64 ++++--- net/netfilter/nfnetlink.c | 11 +- net/netfilter/nfnetlink_log.c | 3 +- net/netfilter/nfnetlink_queue.c | 2 +- net/netfilter/nft_payload.c | 4 +- net/wireless/reg.c | 3 + scripts/checkpatch.pl | 4 +- sound/core/oss/mulaw.c | 4 +- sound/firewire/digi00x/digi00x.c | 5 + sound/pci/ca0106/ca0106_main.c | 3 +- sound/pci/hda/patch_hdmi.c | 1 + sound/pci/hda/patch_realtek.c | 1 + tools/include/uapi/linux/perf_event.h | 2 +- tools/perf/Documentation/perf-record.txt | 4 + tools/perf/Documentation/perf-stat.txt | 4 + tools/perf/pmu-events/jevents.c | 2 +- tools/testing/selftests/bpf/test_maps.c | 2 + 87 files changed, 885 insertions(+), 337 deletions(-) -- 2.25.1

1 79

[PATCH 000/120] backport stable-4.19.143
by Yang Yingliang 22 Sep '20

22 Sep '20

Aditya Pakki (5): drm/radeon: fix multiple reference count leak omapfb: fix multiple reference count leaks due to pm_runtime_get_sync drm/nouveau/drm/noveau: fix reference count leak in nouveau_fbcon_open drm/nouveau: fix reference count leak in nv50_disp_atomic_commit drm/nouveau: Fix reference count leak in nouveau_connector_detect Adrian Hunter (1): scsi: ufs: Improve interrupt handling for shared interrupts Alan Stern (3): USB: yurex: Fix bad gfp argument USB: quirks: Ignore duplicate endpoint on Sound Devices MixPre-D usb: storage: Add unusual_uas entry for Sony PSZ drives Alex Deucher (1): drm/amdgpu: Fix buffer overflow in INFO ioctl Alexey Kardashevskiy (1): powerpc/xive: Ignore kmemleak false positives Alvin Šipraga (1): macvlan: validate setting of multiple remote source MAC addresses Amelie Delaunay (1): spi: stm32: fix stm32_spi_prepare_mbr in case of odd clk_rate Andrey Konovalov (1): efi: provide empty efi_enter_virtual_mode implementation Andy Shevchenko (2): mfd: intel-lpss: Add Intel Emmitsburg PCH PCI IDs USB: gadget: u_f: Unbreak offset calculation in VLAs Arnd Bergmann (1): powerpc/spufs: add CONFIG_COREDUMP dependency Athira Rajeev (1): powerpc/perf: Fix soft lockups due to missed interrupt accounting Bodo Stroesser (1): scsi: target: tcmu: Fix crash on ARM during cmd completion Brooke Basile (2): USB: gadget: u_f: add overflow checks to VLA macros USB: gadget: f_ncm: add bounds checks to ncm_unwrap_ntb() Changming Liu (1): USB: sisusbvga: Fix a potential UB casued by left shifting a negative value Chao Yu (1): f2fs: fix error path in do_recover_data() Chris Wilson (1): locking/lockdep: Fix overflow in presentation of average lock-time Christophe JAILLET (1): usb: gadget: f_tcm: Fix some resource leaks in some error paths Cong Wang (1): tipc: fix uninit skb->data in tipc_nl_compat_dumpit() Cyril Roelandt (1): USB: Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge Dave Chinner (1): xfs: Don't allow logging of XFS_ISTALE inodes David Brazdil (1): KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe Desnes A. Nunes do Rosario (1): selftests/powerpc: Purge extra count_pmc() calls of ebb selftests Dick Kennedy (1): scsi: lpfc: Fix shost refcount mismatch when deleting vport Ding Hui (1): xhci: Always restore EP_SOFT_CLEAR_TOGGLE even if ep reset failed Evan Quan (2): drm/amd/pm: correct Vega10 swctf limit setting drm/amd/pm: correct Vega12 swctf limit setting Evgeny Novikov (1): USB: lvtest: return proper error code in probe Filipe Manana (1): btrfs: fix space cache memory leak after transaction abort George Kennedy (2): fbcon: prevent user font height or width change from causing potential out-of-bounds access vt_ioctl: change VT_RESIZEX ioctl to check for error return from vc_resize() Greg Kroah-Hartman (1): Linux 4.19.143 Hans Verkuil (1): cec-api: prevent leaking memory through hole in structure Hans de Goede (1): HID: i2c-hid: Always sleep 60ms after I2C_HID_PWR_ON commands Hector Martin (1): ALSA: usb-audio: Update documentation comment for MS2109 quirk Heikki Krogerus (1): device property: Fix the secondary firmware node handling in set_primary_fwnode() Hou Pu (1): null_blk: fix passing of REQ_FUA flag in null_handle_rq Ikjoon Jang (1): HID: quirks: add NOGET quirk for Logitech GROUP Jan Kara (4): ext4: don't BUG on inconsistent journal feature writeback: Protect inode->i_io_list with inode->i_lock writeback: Avoid skipping inode writeback writeback: Fix sync livelock due to b_dirty_time processing Jarkko Sakkinen (1): tpm: Unify the mismatching TPM space buffer sizes Jason Baron (1): EDAC/ie31200: Fallback if host bridge device is already initialized Javed Hasan (1): scsi: fcoe: Memory leak fix in fcoe_sysfs_fcf_del() Jia-Ju Bai (1): media: pci: ttpci: av7110: fix possible buffer overflow caused by bad DMA value in debiirq() Jing Xiangfeng (1): scsi: iscsi: Do not put host in iscsi_set_flashnode_param() Josef Bacik (1): btrfs: check the right error variable in btrfs_del_dir_entries_in_log Kai-Heng Feng (2): xhci: Do warm-reset when both CAS and XDEV_RESUME are set USB: quirks: Add no-lpm quirk for another Raydium touchscreen Li Guifu (1): f2fs: fix use-after-free issue Li Jun (1): usb: host: xhci: fix ep context print mismatch in debugfs Lukas Czerner (3): jbd2: make sure jh have b_transaction set in refile/unfile_buffer ext4: handle read only external journal device ext4: handle option set by mount flags correctly Lukas Wunner (2): serial: pl011: Fix oops on -EPROBE_DEFER serial: pl011: Don't leak amba_ports entry on driver register error Mahesh Bandewar (1): ipvlan: fix device features Marcos Paulo de Souza (1): btrfs: reset compression level for lzo on remount Mark Tomlinson (1): gre6: Fix reception with IP6_TNL_F_RCV_DSCP_COPY Miaohe Lin (1): net: Fix potential wrong skb->protocol in skb_vlan_untag() Michael Ellerman (1): powerpc/64s: Don't init FSCR_DSCR in __init_FSCR() Mike Christie (1): scsi: fcoe: Fix I/O path allocation Ming Lei (1): blk-mq: order adding requests to hctx->dispatch and checking SCHED_RESTART Navid Emamdoost (4): drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms drm/amd/display: fix ref count leak in amdgpu_drm_ioctl drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails Necip Fazil Yildiran (1): net: qrtr: fix usage of idr in port assignment to socket Peilin Ye (2): net/smc: Prevent kernel-infoleak in __smc_diag_dump() HID: hiddev: Fix slab-out-of-bounds write in hiddev_ioctl_usage() Peng Fan (1): mips/vdso: Fix resource leaks in genvdso.c Qiushi Wu (5): ASoC: img: Fix a reference count leak in img_i2s_in_set_fmt ASoC: img-parallel-out: Fix a reference count leak ASoC: tegra: Fix reference count leaks. drm/amdkfd: Fix reference count leaks. PCI: Fix pci_create_slot() reference count leak Qu Wenruo (1): btrfs: file: reserve qgroup space after the hole punch range is locked Quinn Tran (1): scsi: qla2xxx: Fix null pointer access during disconnect from subsystem Rafael J. Wysocki (1): PM: sleep: core: Fix the handling of pending runtime resume requests Randy Dunlap (1): ALSA: pci: delete repeated words in comments Reto Schneider (1): rtlwifi: rtl8192cu: Prevent leaking urb Rob Clark (1): drm/msm/adreno: fix updating ring fence Robin Murphy (1): iommu/iova: Don't BUG on invalid PFNs Saurav Kashyap (2): scsi: qla2xxx: Check if FW supports MQ before enabling Revert "scsi: qla2xxx: Fix crash on qla2x00_mailbox_command" Sean Young (1): media: gpio-ir-tx: improve precision of transmitted signal due to scheduling Sergey Senozhatsky (1): serial: 8250: change lock order in serial8250_do_startup() Shay Agroskin (1): net: ena: Make missed_tx stat incremental Stanley Chu (2): scsi: ufs: Fix possible infinite loop in ufshcd_hold scsi: ufs: Clean up completed request without interrupt notification Stephan Gerhold (1): arm64: dts: qcom: msm8916: Pull down PDM GPIOs during sleep Sumera Priyadarsini (1): net: gianfar: Add of_node_put() before goto statement Sylwester Nawrocki (1): ASoC: wm8994: Avoid attempts to read unreadable registers Tamseel Shams (1): serial: samsung: Removes the IRQ not found warning Tang Bin (1): usb: host: ohci-exynos: Fix error handling in exynos_ohci_probe() Tetsuo Handa (1): vt: defer kfree() of vc_screenbuf in vc_do_resize() Thinh Nguyen (4): usb: uas: Add quirk for PNY Pro Elite usb: dwc3: gadget: Don't setup more than requested usb: dwc3: gadget: Fix handling ZLP usb: dwc3: gadget: Handle ZLP for sg requests Thomas Gleixner (2): XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information. genirq/matrix: Deal with the sillyness of for_each_cpu() on UP Tianjia Zhang (1): nvme-fc: Fix wrong return value in __nvme_fc_init_request() Tom Rix (1): USB: cdc-acm: rework notification_buffer resizing Valmer Huhn (1): serial: 8250_exar: Fix number of ports for Commtech PCIe cards Vineeth Vijayan (1): s390/cio: add cond_resched() in the slow_eval_known_fn() loop Wolfram Sang (1): i2c: rcar: in slave mode, clear NACK earlier Xianting Tian (1): fs: prevent BUG_ON in submit_bh_wbc() Xiubo Li (1): ceph: fix potential mdsc use-after-free crash Yangbo Lu (1): ARM: dts: ls1021a: output PPS signal on FIPER2 Zhi Chen (1): Revert "ath10k: fix DMA related firmware crashes on multiple devices" qiuguorui1 (1): irqchip/stm32-exti: Avoid losing interrupts due to clearing pending bits by mistake Makefile | 2 +- arch/arm/boot/dts/ls1021a.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 2 +- arch/arm64/kvm/hyp/switch.c | 2 +- arch/mips/vdso/genvdso.c | 10 ++ arch/powerpc/kernel/cpu_setup_power.S | 2 +- arch/powerpc/perf/core-book3s.c | 4 + arch/powerpc/platforms/cell/Kconfig | 1 + arch/powerpc/sysdev/xive/native.c | 2 + block/blk-mq-sched.c | 9 ++ block/blk-mq.c | 9 ++ drivers/base/core.c | 12 +- drivers/base/power/main.c | 16 +- drivers/block/null_blk_main.c | 2 +- drivers/char/tpm/tpm-chip.c | 9 +- drivers/char/tpm/tpm.h | 6 +- drivers/char/tpm/tpm2-space.c | 26 ++-- drivers/char/tpm/tpmrm-dev.c | 2 +- drivers/edac/ie31200_edac.c | 50 +++++- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 7 +- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 20 ++- .../drm/amd/powerplay/hwmgr/vega10_thermal.c | 7 +- .../drm/amd/powerplay/hwmgr/vega12_thermal.c | 6 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +- drivers/gpu/drm/radeon/radeon_connectors.c | 20 ++- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-quirks.c | 1 + drivers/hid/i2c-hid/i2c-hid-core.c | 22 +-- drivers/hid/usbhid/hiddev.c | 4 + drivers/i2c/busses/i2c-rcar.c | 1 + drivers/iommu/iova.c | 4 +- drivers/irqchip/irq-stm32-exti.c | 14 +- drivers/media/cec/cec-api.c | 8 +- drivers/media/pci/ttpci/av7110.c | 5 +- drivers/media/rc/gpio-ir-tx.c | 7 +- drivers/mfd/intel-lpss-pci.c | 3 + drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 +- drivers/net/ethernet/freescale/gianfar.c | 4 +- drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +- drivers/net/ipvlan/ipvlan_main.c | 27 +++- drivers/net/macvlan.c | 21 ++- drivers/net/wireless/ath/ath10k/hw.h | 2 +- drivers/net/wireless/realtek/rtlwifi/usb.c | 5 +- drivers/nvme/host/fc.c | 4 +- drivers/pci/slot.c | 6 +- drivers/s390/cio/css.c | 5 + drivers/scsi/fcoe/fcoe_ctlr.c | 2 +- drivers/scsi/lpfc/lpfc_vport.c | 26 +--- drivers/scsi/qla2xxx/qla_mbx.c | 8 - drivers/scsi/qla2xxx/qla_nvme.c | 5 + drivers/scsi/qla2xxx/qla_os.c | 5 + drivers/scsi/scsi_transport_iscsi.c | 2 +- drivers/scsi/ufs/ufshcd.c | 14 +- drivers/spi/spi-stm32.c | 3 +- drivers/target/target_core_user.c | 9 +- drivers/tty/serial/8250/8250_exar.c | 24 ++- drivers/tty/serial/8250/8250_port.c | 9 +- drivers/tty/serial/amba-pl011.c | 16 +- drivers/tty/serial/samsung.c | 8 +- drivers/tty/vt/vt.c | 5 +- drivers/tty/vt/vt_ioctl.c | 12 +- drivers/usb/class/cdc-acm.c | 22 ++- drivers/usb/core/quirks.c | 7 + drivers/usb/dwc3/gadget.c | 104 ++++++++++--- drivers/usb/gadget/function/f_ncm.c | 81 ++++++++-- drivers/usb/gadget/function/f_tcm.c | 7 +- drivers/usb/gadget/u_f.h | 38 +++-- drivers/usb/host/ohci-exynos.c | 5 +- drivers/usb/host/xhci-debugfs.c | 8 +- drivers/usb/host/xhci-hub.c | 19 +-- drivers/usb/host/xhci.c | 3 +- drivers/usb/misc/lvstest.c | 2 +- drivers/usb/misc/sisusbvga/sisusb.c | 2 +- drivers/usb/misc/yurex.c | 2 +- drivers/usb/storage/unusual_devs.h | 2 +- drivers/usb/storage/unusual_uas.h | 14 ++ drivers/video/fbdev/core/fbcon.c | 25 ++- drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 7 +- drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 7 +- drivers/video/fbdev/omap2/omapfb/dss/dss.c | 7 +- drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 +- drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 5 +- drivers/video/fbdev/omap2/omapfb/dss/venc.c | 7 +- drivers/xen/events/events_base.c | 16 +- fs/btrfs/disk-io.c | 1 + fs/btrfs/file.c | 8 +- fs/btrfs/free-space-cache.c | 2 +- fs/btrfs/super.c | 1 + fs/btrfs/tree-log.c | 10 +- fs/buffer.c | 9 ++ fs/ceph/mds_client.c | 14 +- fs/ext4/super.c | 147 ++++++++++++------ fs/f2fs/f2fs.h | 4 +- fs/f2fs/inline.c | 19 ++- fs/f2fs/node.c | 6 +- fs/f2fs/recovery.c | 10 +- fs/f2fs/super.c | 5 +- fs/fs-writeback.c | 83 +++++----- fs/jbd2/transaction.c | 10 ++ fs/xfs/xfs_icache.c | 3 +- fs/xfs/xfs_inode.c | 25 ++- fs/xfs/xfs_trans_inode.c | 2 + include/linux/efi.h | 4 + include/linux/fs.h | 8 +- include/trace/events/writeback.h | 13 +- kernel/irq/matrix.c | 7 + kernel/locking/lockdep_proc.c | 2 +- net/core/skbuff.c | 4 +- net/ipv6/ip6_tunnel.c | 10 +- net/qrtr/qrtr.c | 20 +-- net/smc/smc_diag.c | 16 +- net/tipc/netlink_compat.c | 12 +- sound/pci/cs46xx/cs46xx_lib.c | 2 +- sound/pci/cs46xx/dsp_spos_scb_lib.c | 2 +- sound/pci/hda/hda_codec.c | 2 +- sound/pci/hda/hda_generic.c | 2 +- sound/pci/hda/patch_sigmatel.c | 2 +- sound/pci/ice1712/prodigy192.c | 2 +- sound/pci/oxygen/xonar_dg.c | 2 +- sound/soc/codecs/wm8958-dsp2.c | 4 + sound/soc/img/img-i2s-in.c | 4 +- sound/soc/img/img-parallel-out.c | 4 +- sound/soc/tegra/tegra30_ahub.c | 4 +- sound/soc/tegra/tegra30_i2s.c | 4 +- sound/usb/quirks-table.h | 4 +- .../powerpc/pmu/ebb/back_to_back_ebbs_test.c | 2 - .../selftests/powerpc/pmu/ebb/cycles_test.c | 2 - .../powerpc/pmu/ebb/cycles_with_freeze_test.c | 2 - .../powerpc/pmu/ebb/cycles_with_mmcr2_test.c | 2 - tools/testing/selftests/powerpc/pmu/ebb/ebb.c | 2 - .../pmu/ebb/ebb_on_willing_child_test.c | 2 - .../powerpc/pmu/ebb/lost_exception_test.c | 1 - .../powerpc/pmu/ebb/multi_counter_test.c | 7 - .../powerpc/pmu/ebb/multi_ebb_procs_test.c | 2 - .../powerpc/pmu/ebb/pmae_handling_test.c | 2 - .../powerpc/pmu/ebb/pmc56_overflow_test.c | 2 - 142 files changed, 1037 insertions(+), 442 deletions(-) -- 2.25.1

1 120

[PATCH 01/37] arm64/ascend: enable ascend features for Ascend910 platform
by Yang Yingliang 22 Sep '20

22 Sep '20

From: Ding Tianhong <dingtianhong(a)huawei.com> ascend inclusion category: feature bugzilla: NA CVE: NA ------------------------------------------------- The Ascend910 platform only use the acpi mode to boot system, the oem message is recorded in the oem_table_id of IORT table, so use the oem message to enable the ascend features. Signed-off-by: Ding Tianhong <dingtianhong(a)huawei.com> Reviewed-by: Hanjun Guo <guohanjun(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- arch/arm64/mm/init.c | 7 ++++++- drivers/acpi/arm64/iort.c | 24 ++++++++++++++++++++++++ include/linux/init.h | 7 +++++++ 3 files changed, 37 insertions(+), 1 deletion(-) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 883350f9cc42..f23da539a476 100644 --- a/arch/arm64/mm/init.c +++ b/arch/arm64/mm/init.c @@ -769,7 +769,7 @@ __setup("keepinitrd", keepinitrd_setup); #endif #ifdef CONFIG_ASCEND_FEATURES -static int __init ascend_enable_setup(char *__unused) +void ascend_enable_all_features(void) { if (IS_ENABLED(CONFIG_ASCEND_DVPP_MMAP)) enable_mmap_dvpp = 1; @@ -782,6 +782,11 @@ static int __init ascend_enable_setup(char *__unused) if (IS_ENABLED(CONFIG_SUSPEND)) mem_sleep_current = PM_SUSPEND_ON; +} + +static int __init ascend_enable_setup(char *__unused) +{ + ascend_enable_all_features(); return 1; } diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c index 5a724bdb4a4d..7408ffab7303 100644 --- a/drivers/acpi/arm64/iort.c +++ b/drivers/acpi/arm64/iort.c @@ -25,6 +25,7 @@ #include <linux/pci.h> #include <linux/platform_device.h> #include <linux/slab.h> +#include <linux/init.h> #define IORT_TYPE_MASK(type) (1 << (type)) #define IORT_MSI_TYPE (1 << ACPI_IORT_NODE_ITS_GROUP) @@ -1639,6 +1640,26 @@ static void __init iort_init_platform_devices(void) } } +/* + * This function detects the ascend platform by oem table id. + */ +static bool ascend_platform_detected(struct acpi_table_header *h) +{ + if (!memcmp(h->oem_table_id, "HI19801P", ACPI_OEM_TABLE_ID_SIZE)) + return true; + + if (!memcmp(h->oem_table_id, "HI19802P", ACPI_OEM_TABLE_ID_SIZE)) + return true; + + if (!memcmp(h->oem_table_id, "HI19804P", ACPI_OEM_TABLE_ID_SIZE)) + return true; + + if (!memcmp(h->oem_table_id, "HI1980\0\0", ACPI_OEM_TABLE_ID_SIZE)) + return true; + + return false; +} + void __init acpi_iort_init(void) { acpi_status status; @@ -1654,5 +1675,8 @@ void __init acpi_iort_init(void) return; } + if (ascend_platform_detected(iort_table)) + ascend_enable_all_features(); + iort_init_platform_devices(); } diff --git a/include/linux/init.h b/include/linux/init.h index 2538d176dd1f..e6f970ac7bf4 100644 --- a/include/linux/init.h +++ b/include/linux/init.h @@ -306,4 +306,11 @@ void __init parse_early_options(char *cmdline); #define __exit_p(x) NULL #endif +#ifndef __ASSEMBLY__ +#ifdef CONFIG_ASCEND_FEATURES +extern void ascend_enable_all_features(void); +#else +static inline void ascend_enable_all_features(void) { } +#endif +#endif #endif /* _LINUX_INIT_H */ -- 2.25.1

1 36

[PATCH] export walk_page_range and tlb flush function
by Miaohe Lin 18 Sep '20

18 Sep '20

From: yanxiaodan <yanxiaodan(a)huawei.com> Export walk_page_range,__kvm_tlb_flush_vmid and flush_tlb_mm_range, so that memory-scan module can use these functions to scan the memory pages and flush TLB. memory-scan link: https://gitee.com/openeuler/memory-scan Signed-off-by: yanxiaodan <yanxiaodan(a)huawei.com> --- arch/arm64/kvm/hyp/tlb.c | 1 + arch/x86/mm/tlb.c | 2 +- mm/pagewalk.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kvm/hyp/tlb.c b/arch/arm64/kvm/hyp/tlb.c index d063a57..7158622 100644 --- a/arch/arm64/kvm/hyp/tlb.c +++ b/arch/arm64/kvm/hyp/tlb.c @@ -205,6 +205,7 @@ void __hyp_text __kvm_tlb_flush_vmid(struct kvm *kvm) __tlb_switch_to_host(kvm, &cxt); } +EXPORT_SYMBOL(__kvm_tlb_flush_vmid); void __hyp_text __kvm_tlb_flush_local_vmid(struct kvm_vcpu *vcpu) { diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 1a3569b..be19bf5 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -945,7 +945,7 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, put_flush_tlb_info(); put_cpu(); } - +EXPORT_SYMBOL(flush_tlb_mm_range); static void do_flush_tlb_all(void *info) { diff --git a/mm/pagewalk.c b/mm/pagewalk.c index e81640d..44a9ab1 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -430,6 +430,7 @@ int walk_page_range(struct mm_struct *mm, unsigned long start, } while (start = next, start < end); return err; } +EXPORT_SYMBOL(walk_page_range); /* * Similar to walk_page_range() but can walk any page tables even if they are -- 1.8.3.1

1 0

【Meeting Notice】openEuler kernel sig meeting Time: 2020-09-18 10:00-12:00
by Meeting Book 17 Sep '20

17 Sep '20

5 7

[PATCH v2] delete python2 dependency
by Zhipeng Xie 15 Sep '20

15 Sep '20

hulk inclusion category: tools bugzilla: NA CVE: NA Link: https://gitee.com/src-openeuler/kernel/issues/I1SMDG ------------------------------------------------- Python2 is no longer supported by the upstream community. The dependency on python2 should be removed from the kernel code. Signed-off-by: Zhipeng Xie <xiezhipeng1(a)huawei.com> --- tools/perf/scripts/python/call-graph-from-sql.py | 2 +- tools/perf/scripts/python/export-to-postgresql.py | 2 +- tools/power/pm-graph/bootgraph.py | 2 +- tools/power/pm-graph/sleepgraph.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/scripts/python/call-graph-from-sql.py b/tools/perf/scripts/python/call-graph-from-sql.py index b494a67a1c67..099b472df4a2 100644 --- a/tools/perf/scripts/python/call-graph-from-sql.py +++ b/tools/perf/scripts/python/call-graph-from-sql.py @@ -1,4 +1,4 @@ -#!/usr/bin/python2 +#!/usr/bin/python # call-graph-from-sql.py: create call-graph from sql database # Copyright (c) 2014-2017, Intel Corporation. # diff --git a/tools/perf/scripts/python/export-to-postgresql.py b/tools/perf/scripts/python/export-to-postgresql.py index e46f51b17513..e97a03697aa2 100644 --- a/tools/perf/scripts/python/export-to-postgresql.py +++ b/tools/perf/scripts/python/export-to-postgresql.py @@ -171,7 +171,7 @@ import datetime # SELECT * FROM samples_view WHERE event = 'transactions' AND branch_type_name = 'transaction abort'; # # To print a call stack requires walking the call_paths table. For example this python script: -# #!/usr/bin/python2 +# #!/usr/bin/python # # import sys # from PySide.QtSql import * diff --git a/tools/power/pm-graph/bootgraph.py b/tools/power/pm-graph/bootgraph.py index 8ee626c0f6a5..abb4c38f029b 100755 --- a/tools/power/pm-graph/bootgraph.py +++ b/tools/power/pm-graph/bootgraph.py @@ -1,4 +1,4 @@ -#!/usr/bin/python2 +#!/usr/bin/python # # Tool for analyzing boot timing # Copyright (c) 2013, Intel Corporation. diff --git a/tools/power/pm-graph/sleepgraph.py b/tools/power/pm-graph/sleepgraph.py index 0c760478f7d7..420102e2cd08 100755 --- a/tools/power/pm-graph/sleepgraph.py +++ b/tools/power/pm-graph/sleepgraph.py @@ -1,4 +1,4 @@ -#!/usr/bin/python2 +#!/usr/bin/python # # Tool for analyzing suspend/resume timing # Copyright (c) 2013, Intel Corporation. -- 2.18.1

3 2

[PATCH] arm64: configs: enable CONFIG_NUMA_AWARE_SPINLOCKS
by Yang Yingliang 15 Sep '20

15 Sep '20

hulk inclusion category: feature CVE: NA ----------------------- enable CONFIG_NUMA_AWARE_SPINLOCKS. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> Reviewed-by: Xie XiuQi <xiexiuqi(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- arch/arm64/configs/euleros_defconfig | 3 ++- arch/arm64/configs/hulk_defconfig | 2 +- arch/arm64/configs/openeuler_defconfig | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm64/configs/euleros_defconfig b/arch/arm64/configs/euleros_defconfig index 09c604738074..2762ee8afe05 100644 --- a/arch/arm64/configs/euleros_defconfig +++ b/arch/arm64/configs/euleros_defconfig @@ -418,6 +418,7 @@ CONFIG_ARM64_ERR_RECOV=y CONFIG_MPAM=y CONFIG_NUMA=y CONFIG_NODES_SHIFT=3 +CONFIG_NUMA_AWARE_SPINLOCKS=y CONFIG_USE_PERCPU_NUMA_NODE_ID=y CONFIG_HAVE_SETUP_PER_CPU_AREA=y CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y @@ -440,7 +441,7 @@ CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y CONFIG_SECCOMP=y CONFIG_PARAVIRT=y -# CONFIG_PARAVIRT_SPINLOCKS is not set +CONFIG_PARAVIRT_SPINLOCKS=y CONFIG_PARAVIRT_TIME_ACCOUNTING=y CONFIG_KEXEC=y CONFIG_CRASH_DUMP=y diff --git a/arch/arm64/configs/hulk_defconfig b/arch/arm64/configs/hulk_defconfig index 9952d0b89744..4979492bb484 100644 --- a/arch/arm64/configs/hulk_defconfig +++ b/arch/arm64/configs/hulk_defconfig @@ -440,7 +440,7 @@ CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y CONFIG_SECCOMP=y CONFIG_PARAVIRT=y -# CONFIG_PARAVIRT_SPINLOCKS is not set +CONFIG_PARAVIRT_SPINLOCKS=y CONFIG_PARAVIRT_TIME_ACCOUNTING=y CONFIG_KEXEC=y CONFIG_CRASH_DUMP=y diff --git a/arch/arm64/configs/openeuler_defconfig b/arch/arm64/configs/openeuler_defconfig index beb292fa9b47..809350e03968 100644 --- a/arch/arm64/configs/openeuler_defconfig +++ b/arch/arm64/configs/openeuler_defconfig @@ -421,7 +421,7 @@ CONFIG_ARM64_ERR_RECOV=y CONFIG_MPAM=y CONFIG_NUMA=y CONFIG_NODES_SHIFT=4 -# CONFIG_NUMA_AWARE_SPINLOCKS is not set +CONFIG_NUMA_AWARE_SPINLOCKS=y CONFIG_USE_PERCPU_NUMA_NODE_ID=y CONFIG_HAVE_SETUP_PER_CPU_AREA=y CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y -- 2.25.1

1 0

[PATCH 1/2] random: only read from /dev/random after its pool has received 128 bits
by Yang Yingliang 15 Sep '20

15 Sep '20

From: Theodore Ts'o <tytso(a)mit.edu> mainline inclusion from mainline-v5.2-rc1 commit eb9d1bf079bb438d1a066d72337092935fc770f6 category: bugfix bugzilla: NA CVE: NA https://gitee.com/openeuler/kernel/issues/I1CVQ4?from=project-issue ------------------------------------------------- Immediately after boot, we allow reads from /dev/random before its entropy pool has been fully initialized. Fix this so that we don't allow this until the blocking pool has received 128 bits. We do this by repurposing the initialized flag in the entropy pool struct, and use the initialized flag in the blocking pool to indicate whether it is safe to pull from the blocking pool. To do this, we needed to rework when we decide to push entropy from the input pool to the blocking pool, since the initialized flag for the input pool was used for this purpose. To simplify things, we no longer use the initialized flag for that purpose, nor do we use the entropy_total field any more. Signed-off-by: Theodore Ts'o <tytso(a)mit.edu> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> Reviewed-by: Xie XiuQi <xiexiuqi(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- drivers/char/random.c | 44 +++++++++++++++++------------------ include/trace/events/random.h | 13 ++++------- 2 files changed, 27 insertions(+), 30 deletions(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index 6a5d4dfafc47..750d2ab2ac54 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -471,7 +471,6 @@ struct entropy_store { unsigned short add_ptr; unsigned short input_rotate; int entropy_count; - int entropy_total; unsigned int initialized:1; unsigned int last_data_init:1; __u8 last_data[EXTRACT_SIZE]; @@ -644,7 +643,7 @@ static void process_random_ready_list(void) */ static void credit_entropy_bits(struct entropy_store *r, int nbits) { - int entropy_count, orig; + int entropy_count, orig, has_initialized = 0; const int pool_size = r->poolinfo->poolfracbits; int nfrac = nbits << ENTROPY_SHIFT; @@ -699,23 +698,25 @@ static void credit_entropy_bits(struct entropy_store *r, int nbits) entropy_count = 0; } else if (entropy_count > pool_size) entropy_count = pool_size; + if ((r == &blocking_pool) && !r->initialized && + (entropy_count >> ENTROPY_SHIFT) > 128) + has_initialized = 1; if (cmpxchg(&r->entropy_count, orig, entropy_count) != orig) goto retry; - r->entropy_total += nbits; - if (!r->initialized && r->entropy_total > 128) { + if (has_initialized) r->initialized = 1; - r->entropy_total = 0; - } trace_credit_entropy_bits(r->name, nbits, - entropy_count >> ENTROPY_SHIFT, - r->entropy_total, _RET_IP_); + entropy_count >> ENTROPY_SHIFT, _RET_IP_); if (r == &input_pool) { int entropy_bits = entropy_count >> ENTROPY_SHIFT; + struct entropy_store *other = &blocking_pool; - if (crng_init < 2 && entropy_bits >= 128) { + if (crng_init < 2) { + if (entropy_bits < 128) + return; crng_reseed(&primary_crng, r); entropy_bits = r->entropy_count >> ENTROPY_SHIFT; } @@ -726,20 +727,14 @@ static void credit_entropy_bits(struct entropy_store *r, int nbits) wake_up_interruptible(&random_read_wait); kill_fasync(&fasync, SIGIO, POLL_IN); } - /* If the input pool is getting full, send some - * entropy to the blocking pool until it is 75% full. + /* If the input pool is getting full, and the blocking + * pool has room, send some entropy to the blocking + * pool. */ - if (entropy_bits > random_write_wakeup_bits && - r->initialized && - r->entropy_total >= 2*random_read_wakeup_bits) { - struct entropy_store *other = &blocking_pool; - - if (other->entropy_count <= - 3 * other->poolinfo->poolfracbits / 4) { - schedule_work(&other->push_work); - r->entropy_total = 0; - } - } + if (!work_pending(&other->push_work) && + (ENTROPY_BITS(r) > 6 * r->poolinfo->poolbytes) && + (ENTROPY_BITS(other) <= 6 * other->poolinfo->poolbytes)) + schedule_work(&other->push_work); } } @@ -1558,6 +1553,11 @@ static ssize_t extract_entropy_user(struct entropy_store *r, void __user *buf, int large_request = (nbytes > 256); trace_extract_entropy_user(r->name, nbytes, ENTROPY_BITS(r), _RET_IP_); + if (!r->initialized && r->pull) { + xfer_secondary_pool(r, ENTROPY_BITS(r->pull)/8); + if (!r->initialized) + return 0; + } xfer_secondary_pool(r, nbytes); nbytes = account(r, nbytes, 0, 0); diff --git a/include/trace/events/random.h b/include/trace/events/random.h index 0560dfc33f1c..32c10a515e2d 100644 --- a/include/trace/events/random.h +++ b/include/trace/events/random.h @@ -62,15 +62,14 @@ DEFINE_EVENT(random__mix_pool_bytes, mix_pool_bytes_nolock, TRACE_EVENT(credit_entropy_bits, TP_PROTO(const char *pool_name, int bits, int entropy_count, - int entropy_total, unsigned long IP), + unsigned long IP), - TP_ARGS(pool_name, bits, entropy_count, entropy_total, IP), + TP_ARGS(pool_name, bits, entropy_count, IP), TP_STRUCT__entry( __field( const char *, pool_name ) __field( int, bits ) __field( int, entropy_count ) - __field( int, entropy_total ) __field(unsigned long, IP ) ), @@ -78,14 +77,12 @@ TRACE_EVENT(credit_entropy_bits, __entry->pool_name = pool_name; __entry->bits = bits; __entry->entropy_count = entropy_count; - __entry->entropy_total = entropy_total; __entry->IP = IP; ), - TP_printk("%s pool: bits %d entropy_count %d entropy_total %d " - "caller %pS", __entry->pool_name, __entry->bits, - __entry->entropy_count, __entry->entropy_total, - (void *)__entry->IP) + TP_printk("%s pool: bits %d entropy_count %d caller %pS", + __entry->pool_name, __entry->bits, + __entry->entropy_count, (void *)__entry->IP) ); TRACE_EVENT(push_to_pool, -- 2.25.1

1 1