- Kernel - mailweb.openeuler.org

[PATCH OLK-6.6][Backport] x86/selftests: Skip the tests if prerequisites aren't fulfilled
by Jiangshan Yi 20 Nov '24

20 Nov '24

From: Muhammad Usama Anjum <usama.anjum(a)collabora.com> mainline inclusion from mainline-v6.10-rc1 commit 99c84311e35f9399bdce666f6306a048e2a5b404 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IB5O23 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- Skip instead of failing when prerequisite conditions aren't fulfilled, such as invalid xstate values etc. Make the tests show as 'SKIP' when run: make -C tools/testing/selftests/ TARGETS=x86 run_tests ... # timeout set to 45 # selftests: x86: amx_64 # # xstate cpuid: invalid tile data size/offset: 0/0 ok 42 selftests: x86: amx_64 # SKIP # timeout set to 45 # selftests: x86: lam_64 # # Unsupported LAM feature! ok 43 selftests: x86: lam_64 # SKIP ... In the AMX test, Move away from check_cpuid_xsave() and start using arch_prctl() to find out if AMX support is present or not. In the kernels where AMX isn't present, arch_prctl() returns -EINVAL, hence it is backward compatible. Signed-off-by: Muhammad Usama Anjum <usama.anjum(a)collabora.com> Signed-off-by: Ingo Molnar <mingo(a)kernel.org> Reviewed-by: Chang S. Bae <chang.seok.bae(a)intel.com> Reviewed-by: Binbin Wu <binbin.wu(a)linux.intel.com> Acked-by: Kirill A. Shutemov <kirill.shutemov(a)linux.intel.com> Link: https://lore.kernel.org/r/20240327111720.3509180-1-usama.anjum@collabora.com Signed-off-by: Jiangshan Yi <yijiangshan(a)kylinos.cn> --- tools/testing/selftests/x86/amx.c | 27 ++++++++++----------------- tools/testing/selftests/x86/lam.c | 2 +- 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/tools/testing/selftests/x86/amx.c b/tools/testing/selftests/x86/amx.c index d884fd69dd51..95aad6d8849b 100644 --- a/tools/testing/selftests/x86/amx.c +++ b/tools/testing/selftests/x86/amx.c @@ -103,21 +103,6 @@ static void clearhandler(int sig) #define CPUID_LEAF1_ECX_XSAVE_MASK (1 << 26) #define CPUID_LEAF1_ECX_OSXSAVE_MASK (1 << 27) -static inline void check_cpuid_xsave(void) -{ - uint32_t eax, ebx, ecx, edx; - - /* - * CPUID.1:ECX.XSAVE[bit 26] enumerates general - * support for the XSAVE feature set, including - * XGETBV. - */ - __cpuid_count(1, 0, eax, ebx, ecx, edx); - if (!(ecx & CPUID_LEAF1_ECX_XSAVE_MASK)) - fatal_error("cpuid: no CPU xsave support"); - if (!(ecx & CPUID_LEAF1_ECX_OSXSAVE_MASK)) - fatal_error("cpuid: no OS xsave support"); -} static uint32_t xbuf_size; @@ -350,6 +335,7 @@ enum expected_result { FAIL_EXPECTED, SUCCESS_EXPECTED }; /* arch_prctl() and sigaltstack() test */ +#define ARCH_GET_XCOMP_SUPP 0x1021 #define ARCH_GET_XCOMP_PERM 0x1022 #define ARCH_REQ_XCOMP_PERM 0x1023 @@ -928,8 +914,15 @@ static void test_ptrace(void) int main(void) { - /* Check hardware availability at first */ - check_cpuid_xsave(); + unsigned long features; + long rc; + + rc = syscall(SYS_arch_prctl, ARCH_GET_XCOMP_SUPP, &features); + if (rc || (features & XFEATURE_MASK_XTILE) != XFEATURE_MASK_XTILE) { + ksft_print_msg("no AMX support\n"); + return KSFT_SKIP; + } + check_cpuid_xtiledata(); init_stashed_xsave(); diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/lam.c index 8f9b06d9ce03..edc14b15da34 100644 --- a/tools/testing/selftests/x86/lam.c +++ b/tools/testing/selftests/x86/lam.c @@ -1183,7 +1183,7 @@ int main(int argc, char **argv) if (!cpu_has_lam()) { ksft_print_msg("Unsupported LAM feature!\n"); - return -1; + return KSFT_SKIP; } while ((c = getopt(argc, argv, "ht:")) != -1) { -- 2.27.0

2 1

[PATCH OLK-5.10] NFSD: Initialize struct nfsd4_copy earlier
by Li Lingfeng 20 Nov '24

20 Nov '24

From: Chuck Lever <chuck.lever(a)oracle.com> mainline inclusion from mainline-v6.12-rc6 commit 63fab04cbd0f96191b6e5beedc3b643b01c15889 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IB37AU CVE: CVE-2024-50241 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… ---------------------------------------------------------------------- Ensure the refcount and async_copies fields are initialized early. cleanup_async_copy() will reference these fields if an error occurs in nfsd4_copy(). If they are not correctly initialized, at the very least, a refcount underflow occurs. Reported-by: Olga Kornievskaia <okorniev(a)redhat.com> Fixes: aadc3bbea163 ("NFSD: Limit the number of concurrent async COPY operations") Reviewed-by: Jeff Layton <jlayton(a)kernel.org> Tested-by: Olga Kornievskaia <okorniev(a)redhat.com> Signed-off-by: Chuck Lever <chuck.lever(a)oracle.com> Conflicts: fs/nfsd/nfs4proc.c [Commit 81e722978ad2("NFSD: fix problems with cleanup on errors in nfsd4_copy") add the initialization of async_copy->copies] Signed-off-by: Li Lingfeng <lilingfeng3(a)huawei.com> --- fs/nfsd/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index cef719ce5edf..0c209443f9be 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1529,6 +1529,7 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, if (!async_copy) goto out_err; async_copy->cp_nn = nn; + refcount_set(&async_copy->refcount, 1); /* Arbitrary cap on number of pending async copy operations */ if (atomic_inc_return(&nn->pending_async_copies) > (int)rqstp->rq_pool->sp_nrthreads) { @@ -1537,7 +1538,6 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, } if (!nfs4_init_copy_state(nn, copy)) goto out_err; - refcount_set(&async_copy->refcount, 1); memcpy(&copy->cp_res.cb_stateid, &copy->cp_stateid.stid, sizeof(copy->cp_res.cb_stateid)); dup_copy_fields(copy, async_copy); -- 2.31.1

2 1

[openeuler:OLK-6.6 1487/1487] vmlinux.o: warning: objtool: exc_nmi+0x7: call to sev_es_nmi_complete() leaves .noinstr.text section
by kernel test robot 20 Nov '24

20 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: cce003012298a00277187319a2527882a18278c1 commit: 241ad43fe7e9c24d5ba4cdd1ec22e731cdd22d14 [1487/1487] Compiler: Add clang's PGO support for kernel. config: x86_64-randconfig-013-20241119 (https://download.01.org/0day-ci/archive/20241120/202411201407.qu7Hs8Ch-lkp@…) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241120/202411201407.qu7Hs8Ch-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411201407.qu7Hs8Ch-lkp@intel.com/ All warnings (new ones prefixed by >>): vmlinux.o: warning: objtool: handle_bug+0x5: call to kmsan_unpoison_entry_regs() leaves .noinstr.text section >> vmlinux.o: warning: objtool: exc_nmi+0x7: call to sev_es_nmi_complete() leaves .noinstr.text section -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6] NFSD: Initialize struct nfsd4_copy earlier
by Li Lingfeng 20 Nov '24

20 Nov '24

From: Chuck Lever <chuck.lever(a)oracle.com> mainline inclusion from mainline-v6.12-rc6 commit 63fab04cbd0f96191b6e5beedc3b643b01c15889 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IB37AU CVE: CVE-2024-50241 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… ---------------------------------------------------------------------- Ensure the refcount and async_copies fields are initialized early. cleanup_async_copy() will reference these fields if an error occurs in nfsd4_copy(). If they are not correctly initialized, at the very least, a refcount underflow occurs. Reported-by: Olga Kornievskaia <okorniev(a)redhat.com> Fixes: aadc3bbea163 ("NFSD: Limit the number of concurrent async COPY operations") Reviewed-by: Jeff Layton <jlayton(a)kernel.org> Tested-by: Olga Kornievskaia <okorniev(a)redhat.com> Signed-off-by: Chuck Lever <chuck.lever(a)oracle.com> Conflicts: fs/nfsd/nfs4proc.c [Commit 8adb368675cf("[Backport] NFSD: Limit the number of concurrent async COPY operations") miss partial indent before "(int)rqstp->rq_pool->sp_nrthreads"] Signed-off-by: Li Lingfeng <lilingfeng3(a)huawei.com> --- fs/nfsd/nfs4proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 9b672ba7d02b..34d9931df6a4 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1823,14 +1823,14 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, if (!async_copy) goto out_err; async_copy->cp_nn = nn; + INIT_LIST_HEAD(&async_copy->copies); + refcount_set(&async_copy->refcount, 1); /* Arbitrary cap on number of pending async copy operations */ if (atomic_inc_return(&nn->pending_async_copies) > (int)rqstp->rq_pool->sp_nrthreads) { atomic_dec(&nn->pending_async_copies); goto out_err; } - INIT_LIST_HEAD(&async_copy->copies); - refcount_set(&async_copy->refcount, 1); async_copy->cp_src = kmalloc(sizeof(*async_copy->cp_src), GFP_KERNEL); if (!async_copy->cp_src) goto out_err; -- 2.31.1

2 1

[PATCH openEuler-22.03-LTS-SP1 0/2] openEuler-22.03-LTS-SP1
by Luo Gengkun 20 Nov '24

20 Nov '24

*** BLURB HERE *** Luo Gengkun (1): perf: Fix kabi problem by put mutex in front of perf_buffer Peter Zijlstra (1): perf/aux: Fix AUX buffer serialization kernel/events/core.c | 21 +++++++++++++++------ kernel/events/internal.h | 5 +++++ kernel/events/ring_buffer.c | 30 ++++++++++++++++++++---------- 3 files changed, 40 insertions(+), 16 deletions(-) -- 2.34.1

2 3

[PATCH OLK-6.6 0/2] OLK-6.6
by Luo Gengkun 20 Nov '24

20 Nov '24

*** BLURB HERE *** Luo Gengkun (1): perf: Fix kabi problem by put mutex in front of perf_buffer Peter Zijlstra (1): perf/aux: Fix AUX buffer serialization kernel/events/core.c | 21 +++++++++++++++------ kernel/events/internal.h | 5 +++++ kernel/events/ring_buffer.c | 30 ++++++++++++++++++++---------- 3 files changed, 40 insertions(+), 16 deletions(-) -- 2.34.1

2 3

[PATCH OLK-5.10 0/2] CVE-2024-46713
by Luo Gengkun 20 Nov '24

20 Nov '24

*** BLURB HERE *** Luo Gengkun (1): perf: Fix kabi problem by put mutex in front of perf_buffer Peter Zijlstra (1): perf/aux: Fix AUX buffer serialization kernel/events/core.c | 21 +++++++++++++++------ kernel/events/internal.h | 5 +++++ kernel/events/ring_buffer.c | 30 ++++++++++++++++++++---------- 3 files changed, 40 insertions(+), 16 deletions(-) -- 2.34.1

2 3

openEuler Kernel SIG双周例会
by openEuler conference 20 Nov '24

20 Nov '24

您好！ Kernel 邀请您参加 2024-11-22 14:00 召开的WeLink会议(自动录制) 会议主题：openEuler Kernel SIG双周例会会议内容： 1. 进展update 2. 内容征集中（可回复本邮件申请，也可直接填写至会议纪要看板）会议链接：https://meeting.huaweicloud.com:36443/#/j/961483852 会议纪要：https://etherpad.openeuler.org/p/Kernel-meetings 更多资讯尽在：https://www.openeuler.org/zh/ Hello! Kernel invites you to attend the WeLink conference(auto recording) will be held at 2024-11-22 14:00, The subject of the conference is openEuler Kernel SIG双周例会, Summary: 1. 进展update 2. 内容征集中（可回复本邮件申请，也可直接填写至会议纪要看板） You can join the meeting at https://meeting.huaweicloud.com:36443/#/j/961483852. Add topics at https://etherpad.openeuler.org/p/Kernel-meetings. More information: https://www.openeuler.org/en/

1 0

[openeuler:OLK-5.10 2430/2430] kernel/sched/topology.c:2385:39: sparse: sparse: incorrect type in assignment (different address spaces)
by kernel test robot 20 Nov '24

20 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 88a9bf0245509a724bfce4cef1d4dc86f0a117a0 commit: edd5e1effd36972e2b1910661daef5e4249fc3fd [2430/2430] sched/fair: Adjust the allowed NUMA imbalance when SD_NUMA spans multiple LLCs config: x86_64-randconfig-121-20241114 (https://download.01.org/0day-ci/archive/20241120/202411201411.gmJgGdOo-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241120/202411201411.gmJgGdOo-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411201411.gmJgGdOo-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) kernel/sched/topology.c:2086:32: sparse: sparse: incorrect type in initializer (different base types) @@ expected int flags @@ got restricted gfp_t @@ kernel/sched/topology.c:2086:32: sparse: expected int flags kernel/sched/topology.c:2086:32: sparse: got restricted gfp_t kernel/sched/topology.c:2094:61: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected restricted gfp_t [usertype] flags @@ got int flags @@ kernel/sched/topology.c:2094:61: sparse: expected restricted gfp_t [usertype] flags kernel/sched/topology.c:2094:61: sparse: got int flags kernel/sched/topology.c:2122:58: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:2122:58: sparse: expected struct sched_domain *[assigned] sd kernel/sched/topology.c:2122:58: sparse: got struct sched_domain [noderef] __rcu *parent kernel/sched/topology.c:121:56: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sched_domain *sd @@ got struct sched_domain [noderef] __rcu *child @@ kernel/sched/topology.c:121:56: sparse: expected struct sched_domain *sd kernel/sched/topology.c:121:56: sparse: got struct sched_domain [noderef] __rcu *child kernel/sched/topology.c:140:60: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sched_domain *sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:140:60: sparse: expected struct sched_domain *sd kernel/sched/topology.c:140:60: sparse: got struct sched_domain [noderef] __rcu *parent kernel/sched/topology.c:163:20: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:163:20: sparse: expected struct sched_domain *sd kernel/sched/topology.c:163:20: sparse: got struct sched_domain [noderef] __rcu *parent kernel/sched/topology.c:463:19: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct perf_domain *pd @@ got struct perf_domain [noderef] __rcu *pd @@ kernel/sched/topology.c:463:19: sparse: expected struct perf_domain *pd kernel/sched/topology.c:463:19: sparse: got struct perf_domain [noderef] __rcu *pd kernel/sched/topology.c:626:49: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct sched_domain *parent @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:626:49: sparse: expected struct sched_domain *parent kernel/sched/topology.c:626:49: sparse: got struct sched_domain [noderef] __rcu *parent kernel/sched/topology.c:682:9: sparse: sparse: incompatible types in comparison expression (different address spaces): kernel/sched/topology.c:682:9: sparse: struct sparsemask [noderef] __rcu * kernel/sched/topology.c:682:9: sparse: struct sparsemask * kernel/sched/topology.c:724:50: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct sched_domain *parent @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:731:55: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain [noderef] __rcu *[noderef] __rcu child @@ got struct sched_domain *[assigned] tmp @@ kernel/sched/topology.c:741:29: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] tmp @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:746:20: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:752:33: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] tmp @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:758:13: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] tmp @@ got struct sched_domain [noderef] __rcu *sd @@ kernel/sched/topology.c:920:70: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sched_domain *sd @@ got struct sched_domain [noderef] __rcu *child @@ kernel/sched/topology.c:949:59: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sched_domain *sd @@ got struct sched_domain [noderef] __rcu *child @@ kernel/sched/topology.c:993:57: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sched_domain *sd @@ got struct sched_domain [noderef] __rcu *child @@ kernel/sched/topology.c:995:25: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *sibling @@ got struct sched_domain [noderef] __rcu *child @@ kernel/sched/topology.c:1003:55: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sched_domain *sd @@ got struct sched_domain [noderef] __rcu *child @@ kernel/sched/topology.c:1005:25: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *sibling @@ got struct sched_domain [noderef] __rcu *child @@ kernel/sched/topology.c:1075:62: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sched_domain *sd @@ got struct sched_domain [noderef] __rcu *child @@ kernel/sched/topology.c:1179:40: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct sched_domain *child @@ got struct sched_domain [noderef] __rcu *child @@ kernel/sched/topology.c:1482:43: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct sched_domain [noderef] __rcu *child @@ got struct sched_domain *child @@ kernel/sched/topology.c:2163:31: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain [noderef] __rcu *parent @@ got struct sched_domain *sd @@ kernel/sched/topology.c:2334:57: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:2355:56: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct sched_domain *child @@ got struct sched_domain [noderef] __rcu *child @@ >> kernel/sched/topology.c:2385:39: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *top_p @@ got struct sched_domain [noderef] __rcu *parent @@ >> kernel/sched/topology.c:2387:45: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] top @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:2388:47: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *top_p @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:2354:57: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:2404:57: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:74:25: sparse: sparse: dereference of noderef expression kernel/sched/topology.c:79:25: sparse: sparse: dereference of noderef expression kernel/sched/topology.c: note: in included file: kernel/sched/sched.h:1792:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/sched.h:1805:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/sched.h:1805:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/sched.h:1792:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/sched.h:1805:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct sched_domain [noderef] __rcu *parent @@ kernel/sched/topology.c:1497:19: sparse: sparse: dereference of noderef expression vim +2385 kernel/sched/topology.c 2277 2278 2279 /* 2280 * Build sched domains for a given set of CPUs and attach the sched domains 2281 * to the individual CPUs 2282 */ 2283 static int 2284 build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *attr) 2285 { 2286 enum s_alloc alloc_state = sa_none; 2287 struct sched_domain *sd; 2288 struct s_data d; 2289 struct rq *rq = NULL; 2290 int i, ret = -ENOMEM; 2291 struct sched_domain_topology_level *tl_asym; 2292 bool has_asym = false; 2293 bool has_cluster = false; 2294 2295 if (WARN_ON(cpumask_empty(cpu_map))) 2296 goto error; 2297 2298 alloc_state = __visit_domain_allocation_hell(&d, cpu_map); 2299 if (alloc_state != sa_rootdomain) 2300 goto error; 2301 2302 tl_asym = asym_cpu_capacity_level(cpu_map); 2303 2304 /* Set up domains for CPUs specified by the cpu_map: */ 2305 for_each_cpu(i, cpu_map) { 2306 struct sched_domain_topology_level *tl; 2307 int dflags = 0; 2308 2309 sd = NULL; 2310 for_each_sd_topology(tl) { 2311 if (tl == tl_asym) { 2312 dflags |= SD_ASYM_CPUCAPACITY; 2313 has_asym = true; 2314 } 2315 2316 if (WARN_ON(!topology_span_sane(tl, cpu_map, i))) 2317 goto error; 2318 2319 sd = build_sched_domain(tl, cpu_map, attr, sd, dflags, i); 2320 2321 has_cluster |= sd->flags & SD_CLUSTER; 2322 2323 if (tl == sched_domain_topology) 2324 *per_cpu_ptr(d.sd, i) = sd; 2325 if (tl->flags & SDTL_OVERLAP) 2326 sd->flags |= SD_OVERLAP; 2327 if (cpumask_equal(cpu_map, sched_domain_span(sd))) 2328 break; 2329 } 2330 } 2331 2332 /* Build the groups for the domains */ 2333 for_each_cpu(i, cpu_map) { 2334 for (sd = *per_cpu_ptr(d.sd, i); sd; sd = sd->parent) { 2335 sd->span_weight = cpumask_weight(sched_domain_span(sd)); 2336 if (sd->flags & SD_OVERLAP) { 2337 if (build_overlap_sched_groups(sd, i)) 2338 goto error; 2339 } else { 2340 if (build_sched_groups(sd, i)) 2341 goto error; 2342 } 2343 } 2344 } 2345 2346 /* 2347 * Calculate an allowed NUMA imbalance such that LLCs do not get 2348 * imbalanced. 2349 */ 2350 for_each_cpu(i, cpu_map) { 2351 unsigned int imb = 0; 2352 unsigned int imb_span = 1; 2353 2354 for (sd = *per_cpu_ptr(d.sd, i); sd; sd = sd->parent) { 2355 struct sched_domain *child = sd->child; 2356 2357 if (!(sd->flags & SD_SHARE_PKG_RESOURCES) && child && 2358 (child->flags & SD_SHARE_PKG_RESOURCES)) { 2359 struct sched_domain *top, *top_p; 2360 unsigned int nr_llcs; 2361 2362 /* 2363 * For a single LLC per node, allow an 2364 * imbalance up to 25% of the node. This is an 2365 * arbitrary cutoff based on SMT-2 to balance 2366 * between memory bandwidth and avoiding 2367 * premature sharing of HT resources and SMT-4 2368 * or SMT-8 *may* benefit from a different 2369 * cutoff. 2370 * 2371 * For multiple LLCs, allow an imbalance 2372 * until multiple tasks would share an LLC 2373 * on one node while LLCs on another node 2374 * remain idle. 2375 */ 2376 nr_llcs = sd->span_weight / child->span_weight; 2377 if (nr_llcs == 1) 2378 imb = sd->span_weight >> 2; 2379 else 2380 imb = nr_llcs; 2381 sd->imb_numa_nr = imb; 2382 2383 /* Set span based on the first NUMA domain. */ 2384 top = sd; > 2385 top_p = top->parent; 2386 while (top_p && !(top_p->flags & SD_NUMA)) { > 2387 top = top->parent; 2388 top_p = top->parent; 2389 } 2390 imb_span = top_p ? top_p->span_weight : sd->span_weight; 2391 } else { 2392 int factor = max(1U, (sd->span_weight / imb_span)); 2393 2394 sd->imb_numa_nr = imb * factor; 2395 } 2396 } 2397 } 2398 2399 /* Calculate CPU capacity for physical packages and nodes */ 2400 for (i = nr_cpumask_bits-1; i >= 0; i--) { 2401 if (!cpumask_test_cpu(i, cpu_map)) 2402 continue; 2403 2404 for (sd = *per_cpu_ptr(d.sd, i); sd; sd = sd->parent) { 2405 claim_allocations(i, sd); 2406 init_sched_groups_capacity(i, sd); 2407 } 2408 } 2409 2410 /* 2411 * Allocate shared sd data at last level cache. Must be done after 2412 * domains are built above, but before the data is used in 2413 * cpu_attach_domain and descendants below. 2414 */ 2415 if (sd_llc_alloc_all(cpu_map, &d)) 2416 goto error; 2417 2418 /* Attach the domains */ 2419 rcu_read_lock(); 2420 for_each_cpu(i, cpu_map) { 2421 rq = cpu_rq(i); 2422 sd = *per_cpu_ptr(d.sd, i); 2423 2424 /* Use READ_ONCE()/WRITE_ONCE() to avoid load/store tearing: */ 2425 if (rq->cpu_capacity_orig > READ_ONCE(d.rd->max_cpu_capacity)) 2426 WRITE_ONCE(d.rd->max_cpu_capacity, rq->cpu_capacity_orig); 2427 2428 cpu_attach_domain(sd, d.rd, i); 2429 } 2430 rcu_read_unlock(); 2431 2432 if (has_asym) 2433 static_branch_inc_cpuslocked(&sched_asym_cpucapacity); 2434 2435 if (has_cluster) 2436 static_branch_inc_cpuslocked(&sched_cluster_active); 2437 2438 if (rq && sched_debug_enabled) { 2439 pr_info("root domain span: %*pbl (max cpu_capacity = %lu)\n", 2440 cpumask_pr_args(cpu_map), rq->rd->max_cpu_capacity); 2441 } 2442 2443 ret = 0; 2444 error: 2445 __free_domain_allocs(&d, alloc_state, cpu_map); 2446 2447 return ret; 2448 } 2449 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1474/1474] fs/ext4/inode.c:3585:24: sparse: sparse: symbol 'ext4_iomap_buffered_read_ops' was not declared. Should it be static?
by kernel test robot 20 Nov '24

20 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 76e29fd0dc6d0f5cf1dd449e526e6dba2d726379 commit: a38e9381cf2ba6f3300c716b1cff4551bec0fbdf [1474/1474] ext4: implement buffered read iomap path config: x86_64-randconfig-121-20241118 (https://download.01.org/0day-ci/archive/20241120/202411201344.6SAp7KFy-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241120/202411201344.6SAp7KFy-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411201344.6SAp7KFy-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> fs/ext4/inode.c:3585:24: sparse: sparse: symbol 'ext4_iomap_buffered_read_ops' was not declared. Should it be static? vim +/ext4_iomap_buffered_read_ops +3585 fs/ext4/inode.c 3584 > 3585 const struct iomap_ops ext4_iomap_buffered_read_ops = { 3586 .iomap_begin = ext4_iomap_buffered_io_begin, 3587 }; 3588 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0