- Kernel - mailweb.openeuler.org

[openeuler:OLK-5.10 2439/2439] arch/x86/kernel/fpu/core.o: warning: objtool: can't decode instruction at .text:0x26e0
by kernel test robot 17 Nov '24

17 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 4cbb736395eb31ff181c4488182276601992fa0b commit: 592d168ba66d3bfe054e06e484c53267990f3606 [2439/2439] !13239 scsi: pm80xx: Set phy->enable_completion only when we wait for it config: x86_64-randconfig-073-20241117 (https://download.01.org/0day-ci/archive/20241117/202411171458.FfbMIe5v-lkp@…) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411171458.FfbMIe5v-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411171458.FfbMIe5v-lkp@intel.com/ All warnings (new ones prefixed by >>): >> arch/x86/kernel/fpu/core.o: warning: objtool: can't decode instruction at .text:0x26e0 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1474/1474] kernel/livepatch/core.c:216:13: warning: no previous prototype for function 'arch_klp_skip_resolve'
by kernel test robot 17 Nov '24

17 Nov '24

Hi laokz, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 7c547c6bbe6b6a9cedf63d7cdadb2529404df633 commit: b8f3220637be1736c165c289c634f27841ac4e01 [1474/1474] livepatch: add arch hook before doing klp_resolve_symbols config: arm64-randconfig-003-20241117 (https://download.01.org/0day-ci/archive/20241117/202411171312.1qX29CJl-lkp@…) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411171312.1qX29CJl-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411171312.1qX29CJl-lkp@intel.com/ All warnings (new ones prefixed by >>): kernel/livepatch/core.c:97:12: warning: no previous prototype for function 'arch_klp_init_func' [-Wmissing-prototypes] int __weak arch_klp_init_func(struct klp_object *obj, struct klp_func *func) ^ kernel/livepatch/core.c:97:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_init_func(struct klp_object *obj, struct klp_func *func) ^ static >> kernel/livepatch/core.c:216:13: warning: no previous prototype for function 'arch_klp_skip_resolve' [-Wmissing-prototypes] bool __weak arch_klp_skip_resolve(unsigned int type) ^ kernel/livepatch/core.c:216:1: note: declare 'static' if the function is not intended to be used outside of this translation unit bool __weak arch_klp_skip_resolve(unsigned int type) ^ static kernel/livepatch/core.c:1767:12: warning: no previous prototype for function 'arch_klp_check_activeness_func' [-Wmissing-prototypes] int __weak arch_klp_check_activeness_func(struct klp_func *func, int enable, ^ kernel/livepatch/core.c:1767:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_check_activeness_func(struct klp_func *func, int enable, ^ static kernel/livepatch/core.c:2022:14: warning: no previous prototype for function 'arch_klp_mem_alloc' [-Wmissing-prototypes] void __weak *arch_klp_mem_alloc(size_t size) ^ kernel/livepatch/core.c:2022:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak *arch_klp_mem_alloc(size_t size) ^ static kernel/livepatch/core.c:2027:13: warning: no previous prototype for function 'arch_klp_mem_free' [-Wmissing-prototypes] void __weak arch_klp_mem_free(void *mem) ^ kernel/livepatch/core.c:2027:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_mem_free(void *mem) ^ static kernel/livepatch/core.c:2032:13: warning: no previous prototype for function 'arch_klp_code_modify_prepare' [-Wmissing-prototypes] void __weak arch_klp_code_modify_prepare(void) ^ kernel/livepatch/core.c:2032:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_code_modify_prepare(void) ^ static kernel/livepatch/core.c:2036:13: warning: no previous prototype for function 'arch_klp_code_modify_post_process' [-Wmissing-prototypes] void __weak arch_klp_code_modify_post_process(void) ^ kernel/livepatch/core.c:2036:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_code_modify_post_process(void) ^ static kernel/livepatch/core.c:2049:12: warning: no previous prototype for function 'arch_klp_check_breakpoint' [-Wmissing-prototypes] int __weak arch_klp_check_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ kernel/livepatch/core.c:2049:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_check_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ static kernel/livepatch/core.c:2063:13: warning: no previous prototype for function 'arch_klp_set_brk_func' [-Wmissing-prototypes] void __weak arch_klp_set_brk_func(struct klp_func_node *func_node, void *new_func) ^ kernel/livepatch/core.c:2063:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_set_brk_func(struct klp_func_node *func_node, void *new_func) ^ static 9 warnings generated. vim +/arch_klp_skip_resolve +216 kernel/livepatch/core.c 214 215 #ifdef CONFIG_LIVEPATCH_WO_FTRACE > 216 bool __weak arch_klp_skip_resolve(unsigned int type) 217 { 218 return false; 219 } 220 #endif 221 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 2439/2439] security/integrity/ima/ima.h:381:16: warning: declaration of 'struct ima_digest' will not be visible outside of this function
by kernel test robot 17 Nov '24

17 Nov '24

Hi Zhou, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 4cbb736395eb31ff181c4488182276601992fa0b commit: e94df9b790f7ed9025c9321f16a77044f66b14a5 [2439/2439] ima: Add macros to isolate the IMA digest list config: x86_64-randconfig-013-20241117 (https://download.01.org/0day-ci/archive/20241117/202411171333.Hd6pOCxj-lkp@…) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411171333.Hd6pOCxj-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411171333.Hd6pOCxj-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from security/integrity/ima/ima_init.c:15: In file included from include/linux/scatterlist.h:8: In file included from include/linux/mm.h:1573: include/linux/vmstat.h:417:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 417 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 418 | item]; | ~~~~ include/linux/vmstat.h:424:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 424 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 425 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:431:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 431 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:436:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 436 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 437 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:445:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 445 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 446 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ In file included from security/integrity/ima/ima_init.c:19: >> security/integrity/ima/ima.h:381:16: warning: declaration of 'struct ima_digest' will not be visible outside of this function [-Wvisibility] 381 | struct ima_digest *found_digest) | ^ 6 warnings generated. -- In file included from security/integrity/ima/ima_main.c:23: In file included from include/linux/mman.h:5: In file included from include/linux/mm.h:1573: include/linux/vmstat.h:417:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 417 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 418 | item]; | ~~~~ include/linux/vmstat.h:424:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 424 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 425 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:431:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 431 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:436:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 436 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 437 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:445:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 445 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 446 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ In file included from security/integrity/ima/ima_main.c:30: >> security/integrity/ima/ima.h:381:16: warning: declaration of 'struct ima_digest' will not be visible outside of this function [-Wvisibility] 381 | struct ima_digest *found_digest) | ^ security/integrity/ima/ima_main.c:440:29: error: too few arguments to function call, expected 8, have 7 433 | rc = ima_appraise_measurement(func, iint, file, | ~~~~~~~~~~~~~~~~~~~~~~~~ 434 | pathname, xattr_value, 435 | #ifdef CONFIG_IMA_DIGEST_LIST 436 | xattr_len, modsig, 437 | ima_digest_allow(found_digest, 438 | IMA_APPRAISE)); 439 | #else 440 | xattr_len, modsig); | ^ security/integrity/ima/ima.h:373:19: note: 'ima_appraise_measurement' declared here 373 | static inline int ima_appraise_measurement(enum ima_hooks func, | ^ ~~~~~~~~~~~~~~~~~~~~ 374 | struct integrity_iint_cache *iint, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 375 | struct file *file, | ~~~~~~~~~~~~~~~~~~ 376 | const unsigned char *filename, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 377 | struct evm_ima_xattr_data *xattr_value, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 378 | int xattr_len, | ~~~~~~~~~~~~~~ 379 | #ifndef CONFIG_IMA_DIGEST_LIST | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 380 | const struct modsig *modsig, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 381 | struct ima_digest *found_digest) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 6 warnings and 1 error generated. -- In file included from security/integrity/ima/ima_asymmetric_keys.c:13: In file included from security/integrity/ima/ima.h:19: In file included from include/linux/security.h:33: In file included from include/linux/mm.h:1573: include/linux/vmstat.h:417:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 417 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 418 | item]; | ~~~~ include/linux/vmstat.h:424:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 424 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 425 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:431:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 431 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:436:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 436 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 437 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:445:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 445 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 446 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ In file included from security/integrity/ima/ima_asymmetric_keys.c:13: >> security/integrity/ima/ima.h:381:16: warning: declaration of 'struct ima_digest' will not be visible outside of this function [-Wvisibility] 381 | struct ima_digest *found_digest) | ^ security/integrity/ima/ima_asymmetric_keys.c:27:6: warning: no previous prototype for function 'ima_post_key_create_or_update' [-Wmissing-prototypes] 27 | void ima_post_key_create_or_update(struct key *keyring, struct key *key, | ^ security/integrity/ima/ima_asymmetric_keys.c:27:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 27 | void ima_post_key_create_or_update(struct key *keyring, struct key *key, | ^ | static 7 warnings generated. vim +381 security/integrity/ima/ima.h 273df864cf7466 Nayna Jain 2019-10-30 372 4ad87a3d7444de Mimi Zohar 2016-01-14 373 static inline int ima_appraise_measurement(enum ima_hooks func, d79d72e02485c0 Mimi Zohar 2012-12-03 374 struct integrity_iint_cache *iint, 2fe5d6def1672a Mimi Zohar 2012-02-13 375 struct file *file, d3634d0f426bde Dmitry Kasatkin 2013-04-25 376 const unsigned char *filename, d3634d0f426bde Dmitry Kasatkin 2013-04-25 377 struct evm_ima_xattr_data *xattr_value, 39b07096364a42 Thiago Jung Bauermann 2019-06-27 378 int xattr_len, e94df9b790f7ed Zhou Shuiqing 2023-09-06 379 #ifndef CONFIG_IMA_DIGEST_LIST a44c2ae6cac55b Roberto Sassu 2021-03-03 380 const struct modsig *modsig, a44c2ae6cac55b Roberto Sassu 2021-03-03 @381 struct ima_digest *found_digest) e94df9b790f7ed Zhou Shuiqing 2023-09-06 382 #else e94df9b790f7ed Zhou Shuiqing 2023-09-06 383 const struct modsig *modsig) e94df9b790f7ed Zhou Shuiqing 2023-09-06 384 #endif 2fe5d6def1672a Mimi Zohar 2012-02-13 385 { 2fe5d6def1672a Mimi Zohar 2012-02-13 386 return INTEGRITY_UNKNOWN; 2fe5d6def1672a Mimi Zohar 2012-02-13 387 } 2fe5d6def1672a Mimi Zohar 2012-02-13 388 :::::: The code at line 381 was first introduced by commit :::::: a44c2ae6cac55bdcc0d33f62600233ea0f3f6688 ima: Add support for appraisal with digest lists :::::: TO: Roberto Sassu <roberto.sassu(a)huawei.com> :::::: CC: Zheng Zengkai <zhengzengkai(a)huawei.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1474/1474] kernel/livepatch/core.c:97:12: warning: no previous prototype for function 'arch_klp_init_func'
by kernel test robot 17 Nov '24

17 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 7c547c6bbe6b6a9cedf63d7cdadb2529404df633 commit: eabc33c6f2c91168537f10e9275b0921c9f78c45 [1474/1474] livepatch/ppc64: Implement livepatch without ftrace for ppc64be config: arm64-randconfig-003-20241117 (https://download.01.org/0day-ci/archive/20241117/202411171106.SNb1bUTk-lkp@…) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411171106.SNb1bUTk-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411171106.SNb1bUTk-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/livepatch/core.c:97:12: warning: no previous prototype for function 'arch_klp_init_func' [-Wmissing-prototypes] int __weak arch_klp_init_func(struct klp_object *obj, struct klp_func *func) ^ kernel/livepatch/core.c:97:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_init_func(struct klp_object *obj, struct klp_func *func) ^ static kernel/livepatch/core.c:1756:12: warning: no previous prototype for function 'arch_klp_check_activeness_func' [-Wmissing-prototypes] int __weak arch_klp_check_activeness_func(struct klp_func *func, int enable, ^ kernel/livepatch/core.c:1756:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_check_activeness_func(struct klp_func *func, int enable, ^ static kernel/livepatch/core.c:2011:14: warning: no previous prototype for function 'arch_klp_mem_alloc' [-Wmissing-prototypes] void __weak *arch_klp_mem_alloc(size_t size) ^ kernel/livepatch/core.c:2011:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak *arch_klp_mem_alloc(size_t size) ^ static kernel/livepatch/core.c:2016:13: warning: no previous prototype for function 'arch_klp_mem_free' [-Wmissing-prototypes] void __weak arch_klp_mem_free(void *mem) ^ kernel/livepatch/core.c:2016:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_mem_free(void *mem) ^ static kernel/livepatch/core.c:2021:13: warning: no previous prototype for function 'arch_klp_code_modify_prepare' [-Wmissing-prototypes] void __weak arch_klp_code_modify_prepare(void) ^ kernel/livepatch/core.c:2021:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_code_modify_prepare(void) ^ static kernel/livepatch/core.c:2025:13: warning: no previous prototype for function 'arch_klp_code_modify_post_process' [-Wmissing-prototypes] void __weak arch_klp_code_modify_post_process(void) ^ kernel/livepatch/core.c:2025:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_code_modify_post_process(void) ^ static kernel/livepatch/core.c:2038:12: warning: no previous prototype for function 'arch_klp_check_breakpoint' [-Wmissing-prototypes] int __weak arch_klp_check_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ kernel/livepatch/core.c:2038:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_check_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ static kernel/livepatch/core.c:2052:13: warning: no previous prototype for function 'arch_klp_set_brk_func' [-Wmissing-prototypes] void __weak arch_klp_set_brk_func(struct klp_func_node *func_node, void *new_func) ^ kernel/livepatch/core.c:2052:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_set_brk_func(struct klp_func_node *func_node, void *new_func) ^ static 8 warnings generated. vim +/arch_klp_init_func +97 kernel/livepatch/core.c 96 > 97 int __weak arch_klp_init_func(struct klp_object *obj, struct klp_func *func) 98 { 99 return 0; 100 } 101 #endif /* CONFIG_LIVEPATCH_FTRACE */ 102 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 2439/2439] drivers/iommu/arm/arm-smmu-v3/ascend_smmu.c:71:20: warning: no previous prototype for 'agent_smmu_unlocked_find'
by kernel test robot 17 Nov '24

17 Nov '24

Hi Binfeng, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 4cbb736395eb31ff181c4488182276601992fa0b commit: 3bf501c87ffe1f045f86af89e8958fed62c02c94 [2439/2439] ascend agent smmu: an implementation of ARM SMMUv3 ATOS feature config: arm64-randconfig-004-20241117 (https://download.01.org/0day-ci/archive/20241117/202411171149.AYnfA3ex-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411171149.AYnfA3ex-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411171149.AYnfA3ex-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/iommu/arm/arm-smmu-v3/ascend_smmu.c:71:20: warning: no previous prototype for 'agent_smmu_unlocked_find' [-Wmissing-prototypes] 71 | struct agent_smmu *agent_smmu_unlocked_find(u64 device_id) | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/iommu/arm/arm-smmu-v3/ascend_smmu.c: In function 'agent_smmu_platform_probe': drivers/iommu/arm/arm-smmu-v3/ascend_smmu.c:145:18: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration] 145 | status = acpi_evaluate_integer(ACPI_HANDLE(&pdev->dev), METHOD_NAME__UID, | ^~~~~~~~~~~~~~~~~~~~~ | acpi_evaluate_object drivers/iommu/arm/arm-smmu-v3/ascend_smmu.c: At top level: >> drivers/iommu/arm/arm-smmu-v3/ascend_smmu.c:420:36: warning: 'agent_smmu_acpi_match' defined but not used [-Wunused-const-variable=] 420 | static const struct acpi_device_id agent_smmu_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/agent_smmu_unlocked_find +71 drivers/iommu/arm/arm-smmu-v3/ascend_smmu.c 70 > 71 struct agent_smmu *agent_smmu_unlocked_find(u64 device_id) 72 { 73 struct agent_smmu *temp = NULL; 74 75 list_for_each_entry(temp, &agent_smmu_list, list) { 76 if (temp->device_id == device_id) { 77 return temp; 78 } 79 } 80 return NULL; 81 } 82 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1474/1474] kernel/livepatch/core.c:2006:12: warning: no previous prototype for function 'arch_klp_check_breakpoint'
by kernel test robot 17 Nov '24

17 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 7c547c6bbe6b6a9cedf63d7cdadb2529404df633 commit: 470628a716984e1325b92bef4fa2140ff5a062a5 [1474/1474] livepatch: Use breakpoint exception to optimize enabling livepatch config: arm64-randconfig-003-20241117 (https://download.01.org/0day-ci/archive/20241117/202411170907.1enJR1qQ-lkp@…) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411170907.1enJR1qQ-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411170907.1enJR1qQ-lkp@intel.com/ All warnings (new ones prefixed by >>): kernel/livepatch/core.c:1728:12: warning: no previous prototype for function 'arch_klp_check_activeness_func' [-Wmissing-prototypes] int __weak arch_klp_check_activeness_func(struct klp_func *func, int enable, ^ kernel/livepatch/core.c:1728:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_check_activeness_func(struct klp_func *func, int enable, ^ static kernel/livepatch/core.c:1983:14: warning: no previous prototype for function 'arch_klp_mem_alloc' [-Wmissing-prototypes] void __weak *arch_klp_mem_alloc(size_t size) ^ kernel/livepatch/core.c:1983:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak *arch_klp_mem_alloc(size_t size) ^ static kernel/livepatch/core.c:1988:13: warning: no previous prototype for function 'arch_klp_mem_free' [-Wmissing-prototypes] void __weak arch_klp_mem_free(void *mem) ^ kernel/livepatch/core.c:1988:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_mem_free(void *mem) ^ static kernel/livepatch/core.c:1993:13: warning: no previous prototype for function 'arch_klp_code_modify_prepare' [-Wmissing-prototypes] void __weak arch_klp_code_modify_prepare(void) ^ kernel/livepatch/core.c:1993:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_code_modify_prepare(void) ^ static kernel/livepatch/core.c:1997:13: warning: no previous prototype for function 'arch_klp_code_modify_post_process' [-Wmissing-prototypes] void __weak arch_klp_code_modify_post_process(void) ^ kernel/livepatch/core.c:1997:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_code_modify_post_process(void) ^ static >> kernel/livepatch/core.c:2006:12: warning: no previous prototype for function 'arch_klp_check_breakpoint' [-Wmissing-prototypes] int __weak arch_klp_check_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ kernel/livepatch/core.c:2006:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_check_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ static kernel/livepatch/core.c:2011:12: warning: no previous prototype for function 'arch_klp_add_breakpoint' [-Wmissing-prototypes] int __weak arch_klp_add_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ kernel/livepatch/core.c:2011:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_add_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ static kernel/livepatch/core.c:2016:13: warning: no previous prototype for function 'arch_klp_remove_breakpoint' [-Wmissing-prototypes] void __weak arch_klp_remove_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ kernel/livepatch/core.c:2016:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_remove_breakpoint(struct arch_klp_data *arch_data, void *old_func) ^ static >> kernel/livepatch/core.c:2020:13: warning: no previous prototype for function 'arch_klp_set_brk_func' [-Wmissing-prototypes] void __weak arch_klp_set_brk_func(struct klp_func_node *func_node, void *new_func) ^ kernel/livepatch/core.c:2020:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_set_brk_func(struct klp_func_node *func_node, void *new_func) ^ static 9 warnings generated. vim +/arch_klp_check_breakpoint +2006 kernel/livepatch/core.c 2005 > 2006 int __weak arch_klp_check_breakpoint(struct arch_klp_data *arch_data, void *old_func) 2007 { 2008 return 0; 2009 } 2010 2011 int __weak arch_klp_add_breakpoint(struct arch_klp_data *arch_data, void *old_func) 2012 { 2013 return -EOPNOTSUPP; 2014 } 2015 2016 void __weak arch_klp_remove_breakpoint(struct arch_klp_data *arch_data, void *old_func) 2017 { 2018 } 2019 > 2020 void __weak arch_klp_set_brk_func(struct klp_func_node *func_node, void *new_func) 2021 { 2022 func_node->brk_func = new_func; 2023 } 2024 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1474/1474] kernel/module/strict_rwx.c:36:6: warning: no previous prototype for function 'module_disable_ro'
by kernel test robot 17 Nov '24

17 Nov '24

Hi Zheng, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 7c547c6bbe6b6a9cedf63d7cdadb2529404df633 commit: c8783f92771c891518257c9deb22cd91d4e1a212 [1474/1474] livepatch/core: Revert module_enable_ro and module_disable_ro config: arm64-randconfig-003-20241117 (https://download.01.org/0day-ci/archive/20241117/202411170813.ebFeHSuu-lkp@…) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411170813.ebFeHSuu-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411170813.ebFeHSuu-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/module/strict_rwx.c:36:6: warning: no previous prototype for function 'module_disable_ro' [-Wmissing-prototypes] void module_disable_ro(const struct module *mod) ^ kernel/module/strict_rwx.c:36:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void module_disable_ro(const struct module *mod) ^ static 1 warning generated. vim +/module_disable_ro +36 kernel/module/strict_rwx.c 34 35 #ifdef CONFIG_LIVEPATCH_WO_FTRACE > 36 void module_disable_ro(const struct module *mod) 37 { 38 if (!IS_ENABLED(CONFIG_STRICT_MODULE_RWX)) 39 return; 40 #ifdef CONFIG_STRICT_MODULE_RWX 41 if (!rodata_enabled) 42 return; 43 #endif 44 45 module_set_memory(mod, MOD_TEXT, set_memory_rw); 46 module_set_memory(mod, MOD_INIT_TEXT, set_memory_rw); 47 module_set_memory(mod, MOD_RODATA, set_memory_rw); 48 module_set_memory(mod, MOD_INIT_RODATA, set_memory_rw); 49 } 50 #endif /* CONFIG_LIVEPATCH_WO_FTRACE */ 51 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1474/1474] security/security.c:1071:16: error: implicit declaration of function 'ima_bprm_creds_for_exec'; did you mean 'security_bprm_creds_for_exec'?
by kernel test robot 17 Nov '24

17 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 7c547c6bbe6b6a9cedf63d7cdadb2529404df633 commit: b89997c5e3ffa58c43c4cb3547eb0c11b75d0634 [1474/1474] IMA support script execution check config: arm64-randconfig-004-20241117 (https://download.01.org/0day-ci/archive/20241117/202411170859.cFlE6yaf-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411170859.cFlE6yaf-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411170859.cFlE6yaf-lkp@intel.com/ All errors (new ones prefixed by >>): security/security.c: In function 'security_bprm_creds_for_exec': >> security/security.c:1071:16: error: implicit declaration of function 'ima_bprm_creds_for_exec'; did you mean 'security_bprm_creds_for_exec'? [-Wimplicit-function-declaration] 1071 | return ima_bprm_creds_for_exec(bprm); | ^~~~~~~~~~~~~~~~~~~~~~~ | security_bprm_creds_for_exec vim +1071 security/security.c 1043 1044 /** 1045 * security_bprm_creds_for_exec() - Prepare the credentials for exec() 1046 * @bprm: binary program information 1047 * 1048 * If the setup in prepare_exec_creds did not setup @bprm->cred->security 1049 * properly for executing @bprm->file, update the LSM's portion of 1050 * @bprm->cred->security to be what commit_creds needs to install for the new 1051 * program. This hook may also optionally check permissions (e.g. for 1052 * transitions between security domains). The hook must set @bprm->secureexec 1053 * to 1 if AT_SECURE should be set to request libc enable secure mode. @bprm 1054 * contains the linux_binprm structure. 1055 * 1056 * If execveat(2) is called with the AT_CHECK flag, bprm->is_check is set. The 1057 * result must be the same as without this flag even if the execution will 1058 * never really happen and @bprm will always be dropped. 1059 * 1060 * This hook must not change current->cred, only @bprm->cred. 1061 * 1062 * Return: Returns 0 if the hook is successful and permission is granted. 1063 */ 1064 int security_bprm_creds_for_exec(struct linux_binprm *bprm) 1065 { 1066 int ret; 1067 1068 ret = call_int_hook(bprm_creds_for_exec, 0, bprm); 1069 if (ret) 1070 return ret; > 1071 return ima_bprm_creds_for_exec(bprm); 1072 } 1073 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1297/1297] mm/share_pool.c:3736:12: warning: 'proc_overview_show' defined but not used
by kernel test robot 17 Nov '24

17 Nov '24

Hi Tang, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 4c37b6449701a1fcb16050d4e517fa6d505673e1 commit: 1cfc25ccec44c17c19c892bd31d00d8f6fb23f9b [1297/1297] share_pool: Add proc node to show process overview info config: arm64-randconfig-002-20241117 (https://download.01.org/0day-ci/archive/20241117/202411170716.qehM7edl-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411170716.qehM7edl-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411170716.qehM7edl-lkp@intel.com/ All warnings (new ones prefixed by >>): mm/share_pool.c: In function 'sp_group_id_by_pid': mm/share_pool.c:840:29: warning: ordered comparison of pointer with integer zero [-Wextra] 840 | if (!spg_ids || num <= 0) | ^~ mm/share_pool.c: In function 'sp_compact_nodes': mm/share_pool.c:1689:9: error: implicit declaration of function 'sysctl_compaction_handler'; did you mean 'sysctl_memcg_qos_handler'? [-Werror=implicit-function-declaration] 1689 | sysctl_compaction_handler(NULL, 1, NULL, NULL, NULL); | ^~~~~~~~~~~~~~~~~~~~~~~~~ | sysctl_memcg_qos_handler mm/share_pool.c: At top level: >> mm/share_pool.c:3736:12: warning: 'proc_overview_show' defined but not used [-Wunused-function] 3736 | static int proc_overview_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~~~~~ mm/share_pool.c:3693:12: warning: 'proc_stat_show' defined but not used [-Wunused-function] 3693 | static int proc_stat_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~ mm/share_pool.c:3635:12: warning: 'spa_stat_show' defined but not used [-Wunused-function] 3635 | static int spa_stat_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/proc_overview_show +3736 mm/share_pool.c 3735 > 3736 static int proc_overview_show(struct seq_file *seq, void *offset) 3737 { 3738 seq_printf(seq, "%-8s %-16s %-9s %-9s %-9s %-10s %-10s %-8s\n", 3739 "PID", "COMM", "SP_ALLOC", "SP_K2U", "SP_RES", "Non-SP_RES", 3740 "Non-SP_Shm", "VIRT"); 3741 3742 down_read(&sp_proc_stat_sem); 3743 idr_for_each(&sp_proc_stat_idr, idr_proc_overview_cb, seq); 3744 up_read(&sp_proc_stat_sem); 3745 return 0; 3746 } 3747 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1474/1474] kernel/livepatch/core.c:1689:12: warning: no previous prototype for function 'arch_klp_check_activeness_func'
by kernel test robot 17 Nov '24

17 Nov '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 7c547c6bbe6b6a9cedf63d7cdadb2529404df633 commit: 8c7d888bedbc3642dcfa0ae682bb9fb2337de170 [1474/1474] livepatch/arm64: Support livepatch without ftrace config: arm64-randconfig-003-20241117 (https://download.01.org/0day-ci/archive/20241117/202411170755.dWPSfLjC-lkp@…) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411170755.dWPSfLjC-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411170755.dWPSfLjC-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/livepatch/core.c:1689:12: warning: no previous prototype for function 'arch_klp_check_activeness_func' [-Wmissing-prototypes] int __weak arch_klp_check_activeness_func(struct klp_func *func, int enable, ^ kernel/livepatch/core.c:1689:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int __weak arch_klp_check_activeness_func(struct klp_func *func, int enable, ^ static >> kernel/livepatch/core.c:1913:14: warning: no previous prototype for function 'arch_klp_mem_alloc' [-Wmissing-prototypes] void __weak *arch_klp_mem_alloc(size_t size) ^ kernel/livepatch/core.c:1913:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak *arch_klp_mem_alloc(size_t size) ^ static >> kernel/livepatch/core.c:1918:13: warning: no previous prototype for function 'arch_klp_mem_free' [-Wmissing-prototypes] void __weak arch_klp_mem_free(void *mem) ^ kernel/livepatch/core.c:1918:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_mem_free(void *mem) ^ static >> kernel/livepatch/core.c:1923:13: warning: no previous prototype for function 'arch_klp_code_modify_prepare' [-Wmissing-prototypes] void __weak arch_klp_code_modify_prepare(void) ^ kernel/livepatch/core.c:1923:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_code_modify_prepare(void) ^ static >> kernel/livepatch/core.c:1927:13: warning: no previous prototype for function 'arch_klp_code_modify_post_process' [-Wmissing-prototypes] void __weak arch_klp_code_modify_post_process(void) ^ kernel/livepatch/core.c:1927:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __weak arch_klp_code_modify_post_process(void) ^ static 5 warnings generated. vim +/arch_klp_check_activeness_func +1689 kernel/livepatch/core.c 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1688 583e6e55fb6aa1 Zheng Yejian 2023-12-23 @1689 int __weak arch_klp_check_activeness_func(struct klp_func *func, int enable, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1690 klp_add_func_t add_func, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1691 struct list_head *func_list) 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1692 { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1693 int ret; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1694 unsigned long func_addr = 0; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1695 unsigned long func_size; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1696 struct klp_func_node *func_node = NULL; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1697 unsigned long old_func = (unsigned long)func->old_func; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1698 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1699 func_node = func->func_node; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1700 /* Check func address in stack */ 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1701 if (enable) { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1702 if (func->patched || func->force == KLP_ENFORCEMENT) 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1703 return 0; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1704 /* 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1705 * When enable, checking the currently active functions. 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1706 */ 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1707 if (list_empty(&func_node->func_stack)) { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1708 /* 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1709 * Not patched on this function [the origin one] 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1710 */ 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1711 func_addr = old_func; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1712 func_size = func->old_size; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1713 } else { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1714 /* 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1715 * Previously patched function [the active one] 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1716 */ 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1717 struct klp_func *prev; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1718 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1719 prev = list_first_or_null_rcu(&func_node->func_stack, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1720 struct klp_func, stack_node); 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1721 func_addr = (unsigned long)prev->new_func; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1722 func_size = prev->new_size; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1723 } 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1724 /* 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1725 * When preemption is disabled and the replacement area 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1726 * does not contain a jump instruction, the migration 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1727 * thread is scheduled to run stop machine only after the 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1728 * execution of instructions to be replaced is complete. 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1729 */ 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1730 if (IS_ENABLED(CONFIG_PREEMPTION) || 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1731 (func->force == KLP_NORMAL_FORCE) || 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1732 arch_check_jump_insn(func_addr)) { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1733 ret = add_func(func_list, func_addr, func_size, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1734 func->old_name, func->force); 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1735 if (ret) 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1736 return ret; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1737 if (func_addr != old_func) { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1738 ret = add_func(func_list, old_func, KLP_MAX_REPLACE_SIZE, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1739 func->old_name, func->force); 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1740 if (ret) 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1741 return ret; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1742 } 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1743 } 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1744 } else { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1745 #ifdef CONFIG_PREEMPTION 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1746 /* 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1747 * No scheduling point in the replacement instructions. Therefore, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1748 * when preemption is not enabled, atomic execution is performed 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1749 * and these instructions will not appear on the stack. 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1750 */ 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1751 if (list_is_singular(&func_node->func_stack)) { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1752 func_addr = old_func; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1753 func_size = func->old_size; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1754 } else { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1755 struct klp_func *prev; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1756 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1757 prev = list_first_or_null_rcu( 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1758 &func_node->func_stack, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1759 struct klp_func, stack_node); 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1760 func_addr = (unsigned long)prev->new_func; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1761 func_size = prev->new_size; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1762 } 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1763 ret = add_func(func_list, func_addr, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1764 func_size, func->old_name, 0); 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1765 if (ret) 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1766 return ret; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1767 if (func_addr != old_func) { 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1768 ret = add_func(func_list, old_func, KLP_MAX_REPLACE_SIZE, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1769 func->old_name, 0); 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1770 if (ret) 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1771 return ret; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1772 } 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1773 #endif 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1774 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1775 func_addr = (unsigned long)func->new_func; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1776 func_size = func->new_size; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1777 ret = add_func(func_list, func_addr, 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1778 func_size, func->old_name, 0); 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1779 if (ret) 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1780 return ret; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1781 } 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1782 return 0; 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1783 } 583e6e55fb6aa1 Zheng Yejian 2023-12-23 1784 :::::: The code at line 1689 was first introduced by commit :::::: 583e6e55fb6aa193b1a82909069e8028c5d5653d livepatch/x86: Support livepatch without ftrace :::::: TO: Zheng Yejian <zhengyejian1(a)huawei.com> :::::: CC: Zheng Yejian <zhengyejian1(a)huawei.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0