- Kernel - mailweb.openeuler.org

[PATCH openEuler-22.03-LTS-SP1] xfs: Fix data overflow in xfs_mod_fdblocks()
by Zizhi Wo 03 Dec '24

03 Dec '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IB7V02 -------------------------------- If the xfs reserve block related ioctl takes a large input value, the input reserved size is still assigned to mp->m_resblks in xfs_reserve_blocks() even if the requested size is larger than the total free size in the filesystem. This is because the subsequent xfs_mod_fdblocks() will handle the adjustment. However, in the current code, xfs_mod_fdblocks() calculates mp->m_resblks - mp->m_resblks_avail and casts the result to a long long type, while both mp->m_resblks and mp->m_resblks_avail are of type unsigned long long. If the difference between these two values is very large, and the most significant bit (MSB) is set to 1 (indicating a large unsigned value), the result of the cast becomes a large negative value. This causes mp->m_fdblocks to be updated to a very large value. As a result, xfs will incorrectly determine that there is always free space during foreground writes, while background writebacks may fail due to lack of space. Modify the relevant data types in xfs_mod_fdblocks() to address this issue. Fixes: 0d485ada404b ("xfs: use generic percpu counters for free block counter") Signed-off-by: Zizhi Wo <wozizhi(a)huawei.com> --- fs/xfs/xfs_mount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 04b347fe1b59..4983fe7eadf0 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c @@ -1259,8 +1259,8 @@ xfs_mod_fdblocks( bool rsvd) { int64_t lcounter; - long long res_used; s32 batch; + uint64_t res_used; uint64_t set_aside; if (delta > 0) { @@ -1274,7 +1274,7 @@ xfs_mod_fdblocks( } spin_lock(&mp->m_sb_lock); - res_used = (long long)(mp->m_resblks - mp->m_resblks_avail); + res_used = mp->m_resblks - mp->m_resblks_avail; if (res_used > delta) { mp->m_resblks_avail += delta; -- 2.46.1

2 1

[openeuler:OLK-5.10 2516/2516] kernel/sched/relationship.c:46:39: error: no member named 'mems_allowed' in 'struct task_struct'
by kernel test robot 03 Dec '24

03 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: f86196bf02fd9bea8511335c45bf10b6b0a3ea13 commit: 2ac826b258e9aceefd719f7b0c3e3a9e73901ce5 [2516/2516] sched: Introduce task relationship by net and memory config: x86_64-randconfig-r063-20241203 (https://download.01.org/0day-ci/archive/20241203/202412031643.JKJ5FFhF-lkp@…) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412031643.JKJ5FFhF-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412031643.JKJ5FFhF-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from kernel/sched/relationship.c:19: In file included from include/linux/bpf_sched.h:5: In file included from include/linux/bpf.h:21: In file included from include/linux/kallsyms.h:12: In file included from include/linux/mm.h:1581: include/linux/vmstat.h:417:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 417 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 418 | item]; | ~~~~ include/linux/vmstat.h:424:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 424 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 425 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:431:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 431 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:436:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 436 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 437 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:445:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 445 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 446 | NR_VM_NUMA_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ In file included from kernel/sched/relationship.c:22: kernel/sched/sched.h:1838:15: warning: cast from 'void (*)(struct rq *)' to 'void (*)(struct callback_head *)' converts to incompatible function type [-Wcast-function-type-strict] 1838 | head->func = (void (*)(struct callback_head *))func; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> kernel/sched/relationship.c:46:39: error: no member named 'mems_allowed' in 'struct task_struct' 46 | !nodes_subset(node_online_map, tsk->mems_allowed) || | ~~~ ^ include/linux/nodemask.h:218:30: note: expanded from macro 'nodes_subset' 218 | __nodes_subset(&(src1), &(src2), MAX_NUMNODES) | ^~~~ 6 warnings and 1 error generated. vim +46 kernel/sched/relationship.c 38 39 bool task_relationship_supported(struct task_struct *tsk) 40 { 41 if (!task_relationship_used()) 42 return false; 43 44 if (!tsk->rship || !tsk->mm || 45 !cpumask_subset(cpu_online_mask, tsk->cpus_ptr) || > 46 !nodes_subset(node_online_map, tsk->mems_allowed) || 47 get_task_policy(tsk)->mode == MPOL_BIND || 48 get_task_policy(tsk)->mode == MPOL_INTERLEAVE) 49 return false; 50 51 return true; 52 } 53 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-5.10 0/3] fix CVE-2024-50278
by Zheng Qixing 03 Dec '24

03 Dec '24

Fix CVE-2024-50278. Ming-Hung Tsai (3): dm cache: fix out-of-bounds access to the dirty bitset when resizing dm cache: optimize dirty bit checking with find_next_bit when resizing dm cache: fix potential out-of-bounds access on the first resume drivers/md/dm-cache-target.c | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) -- 2.39.2

2 4

[PATCH openEuler-22.03-LTS-SP1 0/3] fix CVE-2024-50278
by Zheng Qixing 03 Dec '24

03 Dec '24

Fix CVE-2024-50278. Ming-Hung Tsai (3): dm cache: fix out-of-bounds access to the dirty bitset when resizing dm cache: optimize dirty bit checking with find_next_bit when resizing dm cache: fix potential out-of-bounds access on the first resume drivers/md/dm-cache-target.c | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) -- 2.39.2

2 4

[openeuler:OLK-5.10 2516/2516] security/integrity/ima/ima_template_lib.c:578:28: sparse: sparse: incorrect type in assignment (different base types)
by kernel test robot 03 Dec '24

03 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 020e0507954f21291b7b3a0a280128270a0d8959 commit: 3cc8c5969d7e15a044c4bd6d02ed1e82c060abd7 [2516/2516] ima: Define new template fields iuid and igid config: x86_64-randconfig-121-20241203 (https://download.01.org/0day-ci/archive/20241203/202412031511.qvHczHr1-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412031511.qvHczHr1-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412031511.qvHczHr1-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) security/integrity/ima/ima_template_lib.c:102:44: sparse: sparse: cast to restricted __le16 security/integrity/ima/ima_template_lib.c:109:44: sparse: sparse: cast to restricted __le32 security/integrity/ima/ima_template_lib.c:116:44: sparse: sparse: cast to restricted __le64 security/integrity/ima/ima_template_lib.c:137:60: sparse: sparse: restricted __le32 degrades to integer security/integrity/ima/ima_template_lib.c:232:49: sparse: sparse: cast to restricted __le32 >> security/integrity/ima/ima_template_lib.c:578:28: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [assigned] id @@ got restricted __le16 [usertype] @@ security/integrity/ima/ima_template_lib.c:578:28: sparse: expected unsigned int [assigned] id security/integrity/ima/ima_template_lib.c:578:28: sparse: got restricted __le16 [usertype] >> security/integrity/ima/ima_template_lib.c:580:28: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [assigned] id @@ got restricted __le32 [usertype] @@ security/integrity/ima/ima_template_lib.c:580:28: sparse: expected unsigned int [assigned] id security/integrity/ima/ima_template_lib.c:580:28: sparse: got restricted __le32 [usertype] vim +578 security/integrity/ima/ima_template_lib.c 561 562 static int ima_eventinodedac_init_common(struct ima_event_data *event_data, 563 struct ima_field_data *field_data, 564 bool get_uid) 565 { 566 unsigned int id; 567 568 if (!event_data->file) 569 return 0; 570 571 if (get_uid) 572 id = i_uid_read(file_inode(event_data->file)); 573 else 574 id = i_gid_read(file_inode(event_data->file)); 575 576 if (ima_canonical_fmt) { 577 if (sizeof(id) == sizeof(u16)) > 578 id = cpu_to_le16(id); 579 else > 580 id = cpu_to_le32(id); 581 } 582 583 return ima_write_template_field_data((void *)&id, sizeof(id), 584 DATA_FMT_UINT, field_data); 585 } 586 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1455/1455] drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5599:32: error: called object type 'int' is not a function or function pointer
by kernel test robot 03 Dec '24

03 Dec '24

Hi Dong, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 4672b15ea0310686f657dc38c95b8c90663590c0 commit: 6adab536d69347a10c2366aaf6b86de963d5994b [1455/1455] drivers: initial support for rnpvf drivers from Mucse Technology config: x86_64-randconfig-003-20241112 (https://download.01.org/0day-ci/archive/20241203/202412031516.G3dwLO6q-lkp@…) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412031516.G3dwLO6q-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412031516.G3dwLO6q-lkp@intel.com/ All errors (new ones prefixed by >>): | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:127:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 127 | void rnpvf_unmap_and_free_tx_resource(struct rnpvf_ring *ring, | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:1365:6: warning: no previous prototype for function 'rnpvf_alloc_rx_buffers' [-Wmissing-prototypes] 1365 | void rnpvf_alloc_rx_buffers(struct rnpvf_ring *rx_ring, u16 cleaned_count) | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:1365:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1365 | void rnpvf_alloc_rx_buffers(struct rnpvf_ring *rx_ring, u16 cleaned_count) | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:1659:7: warning: variable 'xdp_xmit' set but not used [-Wunused-but-set-variable] 1659 | bool xdp_xmit = false; | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:1945:6: warning: no previous prototype for function 'update_rx_count' [-Wmissing-prototypes] 1945 | void update_rx_count(int cleaned, struct rnpvf_q_vector *q_vector) | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:1945:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1945 | void update_rx_count(int cleaned, struct rnpvf_q_vector *q_vector) | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2420:6: warning: no previous prototype for function 'rnpvf_write_eitr_rx' [-Wmissing-prototypes] 2420 | void rnpvf_write_eitr_rx(struct rnpvf_q_vector *q_vector) | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2420:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2420 | void rnpvf_write_eitr_rx(struct rnpvf_q_vector *q_vector) | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2523:6: warning: no previous prototype for function 'rnpvf_configure_tx_ring' [-Wmissing-prototypes] 2523 | void rnpvf_configure_tx_ring(struct rnpvf_adapter *adapter, | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2523:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2523 | void rnpvf_configure_tx_ring(struct rnpvf_adapter *adapter, | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2589:6: warning: no previous prototype for function 'rnpvf_disable_rx_queue' [-Wmissing-prototypes] 2589 | void rnpvf_disable_rx_queue(struct rnpvf_adapter *adapter, | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2589:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2589 | void rnpvf_disable_rx_queue(struct rnpvf_adapter *adapter, | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2595:6: warning: no previous prototype for function 'rnpvf_enable_rx_queue' [-Wmissing-prototypes] 2595 | void rnpvf_enable_rx_queue(struct rnpvf_adapter *adapter, | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2595:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2595 | void rnpvf_enable_rx_queue(struct rnpvf_adapter *adapter, | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2601:6: warning: no previous prototype for function 'rnpvf_configure_rx_ring' [-Wmissing-prototypes] 2601 | void rnpvf_configure_rx_ring(struct rnpvf_adapter *adapter, | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2601:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 2601 | void rnpvf_configure_rx_ring(struct rnpvf_adapter *adapter, | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:2736:6: warning: variable 'err' set but not used [-Wunused-but-set-variable] 2736 | int err = -EOPNOTSUPP; | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:3307:6: warning: variable 'vector_threshold' set but not used [-Wunused-but-set-variable] 3307 | int vector_threshold; | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:3456:19: warning: variable 'hw' set but not used [-Wunused-but-set-variable] 3456 | struct rnpvf_hw *hw; | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:4590:6: warning: no previous prototype for function 'rnpvf_tx_ctxtdesc' [-Wmissing-prototypes] 4590 | void rnpvf_tx_ctxtdesc(struct rnpvf_ring *tx_ring, u16 mss_seg_len, | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:4590:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 4590 | void rnpvf_tx_ctxtdesc(struct rnpvf_ring *tx_ring, u16 mss_seg_len, | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5039:6: warning: no previous prototype for function 'rnpvf_maybe_tx_ctxtdesc' [-Wmissing-prototypes] 5039 | void rnpvf_maybe_tx_ctxtdesc(struct rnpvf_ring *tx_ring, | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5039:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 5039 | void rnpvf_maybe_tx_ctxtdesc(struct rnpvf_ring *tx_ring, | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5089:13: warning: no previous prototype for function 'rnpvf_xmit_frame_ring' [-Wmissing-prototypes] 5089 | netdev_tx_t rnpvf_xmit_frame_ring(struct sk_buff *skb, | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5089:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 5089 | netdev_tx_t rnpvf_xmit_frame_ring(struct sk_buff *skb, | ^ | static drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5484:6: warning: variable 'ring_csum_err' set but not used [-Wunused-but-set-variable] 5484 | u64 ring_csum_err = 0; | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5485:6: warning: variable 'ring_csum_good' set but not used [-Wunused-but-set-variable] 5485 | u64 ring_csum_good = 0; | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5580:6: warning: no previous prototype for function 'rnpvf_assign_netdev_ops' [-Wmissing-prototypes] 5580 | void rnpvf_assign_netdev_ops(struct net_device *dev) | ^ drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5580:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 5580 | void rnpvf_assign_netdev_ops(struct net_device *dev) | ^ | static >> drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c:5599:32: error: called object type 'int' is not a function or function pointer 5599 | v = rd32(hw, RNP_DMA_RX_START(ring)); | ~~~~~~~~~~~~~~~~^ drivers/net/ethernet/mucse/rnpvf/rnpvf_regs.h:116:53: note: expanded from macro 'rd32' 116 | #define rd32(hw, off) rnpvf_rd_reg((hw)->hw_addr + (off)) | ^~~ drivers/net/ethernet/mucse/rnpvf/rnpvf_regs.h:104:42: note: expanded from macro 'rnpvf_rd_reg' 104 | #define rnpvf_rd_reg(reg) readl((void *)(reg)) | ^~~ 19 warnings and 1 error generated. vim +/int +5599 drivers/net/ethernet/mucse/rnpvf/rnpvf_main.c 5587 5588 static u8 rnpvf_vfnum(struct rnpvf_hw *hw) 5589 { 5590 u16 vf_num = -1; 5591 u32 pfvfnum_reg; 5592 5593 #if CONFIG_BAR4_PFVFNUM 5594 int ring, v; 5595 u16 func = 0; 5596 5597 func = ((hw->pdev->devfn & 0x1) ? 1 : 0); 5598 for (ring = 0; ring < 128; ring += 2) { > 5599 v = rd32(hw, RNP_DMA_RX_START(ring)); 5600 if ((v & 0xFFFF) == hw->pdev->vendor) { 5601 continue; 5602 } else { 5603 vf_num = (1 << 7) /*vf-active*/ | 5604 (func << 6) /*pf*/ | (ring / 2) /*vfnum*/; 5605 break; 5606 } 5607 } 5608 return vf_num; 5609 #else 5610 pfvfnum_reg = 5611 (VF_NUM_REG_N10 & (pci_resource_len(hw->pdev, 0) - 1)); 5612 vf_num = readl(hw->hw_addr_bar0 + pfvfnum_reg); 5613 #define VF_NUM_MASK_TEMP (0xff0) 5614 #define VF_NUM_OFF (4) 5615 return ((vf_num & VF_NUM_MASK_TEMP) >> VF_NUM_OFF); 5616 #endif 5617 } 5618 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/3] Various memory tiering fixes
by Tong Tiangen 03 Dec '24

03 Dec '24

Zi Yan (3): memory tiering: read last_cpupid correctly in do_huge_pmd_numa_page() memory tiering: introduce folio_use_access_time() check memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled. include/linux/mm.h | 6 ++++++ kernel/sched/fair.c | 3 +-- mm/huge_memory.c | 5 ++--- mm/memory-tiers.c | 19 +++++++++++++++++++ mm/memory.c | 3 +-- mm/migrate.c | 4 +++- mm/mprotect.c | 3 +-- 7 files changed, 33 insertions(+), 10 deletions(-) -- 2.25.1

2 4

[openeuler:OLK-6.6 1455/1455] arch/loongarch/kernel/legacy_boot.c:439:25-27: WARNING !A || A && B is equivalent to !A || B
by kernel test robot 03 Dec '24

03 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 4672b15ea0310686f657dc38c95b8c90663590c0 commit: db5bb24abc8dd120fd81b7ce21819e96578d011e [1455/1455] LoongArch: Old BPI compatibility config: loongarch-randconfig-r053-20241112 (https://download.01.org/0day-ci/archive/20241203/202412031534.dakPdx99-lkp@…) compiler: loongarch64-linux-gcc (GCC) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412031534.dakPdx99-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> arch/loongarch/kernel/legacy_boot.c:439:25-27: WARNING !A || A && B is equivalent to !A || B vim +439 arch/loongarch/kernel/legacy_boot.c 423 424 static struct fwnode_handle * __init parse_isa_base(u64 *cpu_addr) 425 { 426 struct device_node *np; 427 const __be32 *ranges = NULL; 428 int len; 429 struct device_node *node; 430 431 for_each_node_by_name(np, "isa") { 432 node = of_node_get(np); 433 434 if (!node) 435 break; 436 437 ranges = of_get_property(node, "ranges", &len); 438 > 439 if (!ranges || (ranges && len > 0)) 440 break; 441 } 442 if (ranges) { 443 ranges += 2; 444 *cpu_addr = of_translate_address(np, ranges); 445 return &np->fwnode; 446 } 447 448 return NULL; 449 } 450 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 1572/1572] arch/x86/kernel/csv-shared.c:130:13: warning: no previous prototype for function 'csv3_scan_secure_call_pages'
by kernel test robot 03 Dec '24

03 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 4672b15ea0310686f657dc38c95b8c90663590c0 commit: ce19f23605e1ab1ab99b4caefdcd1d07dd3dc329 [1572/1572] x86/kernel: Add CSV3 early update(enc/dec)/reset memory helpers config: x86_64-buildonly-randconfig-006-20241203 (https://download.01.org/0day-ci/archive/20241203/202412031441.jesCKpSg-lkp@…) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412031441.jesCKpSg-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412031441.jesCKpSg-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from arch/x86/kernel/csv.c:10: In file included from include/linux/memblock.h:12: In file included from include/linux/mm.h:2243: include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ In file included from arch/x86/kernel/csv.c:15: >> arch/x86/kernel/csv-shared.c:130:13: warning: no previous prototype for function 'csv3_scan_secure_call_pages' [-Wmissing-prototypes] 130 | void __init csv3_scan_secure_call_pages(struct boot_params *boot_params) | ^ arch/x86/kernel/csv-shared.c:130:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 130 | void __init csv3_scan_secure_call_pages(struct boot_params *boot_params) | ^ | static >> arch/x86/kernel/csv-shared.c:177:13: warning: no previous prototype for function 'csv3_early_secure_call_ident_map' [-Wmissing-prototypes] 177 | void __init csv3_early_secure_call_ident_map(u64 base_address, u64 num_pages, | ^ arch/x86/kernel/csv-shared.c:177:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 177 | void __init csv3_early_secure_call_ident_map(u64 base_address, u64 num_pages, | ^ | static 3 warnings generated. vim +/csv3_scan_secure_call_pages +130 arch/x86/kernel/csv-shared.c d2600299dc44d38 Xin Jiang 2024-03-11 122 d2600299dc44d38 Xin Jiang 2024-03-11 123 /** d2600299dc44d38 Xin Jiang 2024-03-11 124 * csv3_scan_secure_call_pages - try to find the secure call pages. d2600299dc44d38 Xin Jiang 2024-03-11 125 * @boot_params: boot parameters where e820_table resides. d2600299dc44d38 Xin Jiang 2024-03-11 126 * d2600299dc44d38 Xin Jiang 2024-03-11 127 * The secure call pages are reserved by BIOS. We scan all the reserved pages d2600299dc44d38 Xin Jiang 2024-03-11 128 * to check the CSV3 secure call guid bytes. d2600299dc44d38 Xin Jiang 2024-03-11 129 */ d2600299dc44d38 Xin Jiang 2024-03-11 @130 void __init csv3_scan_secure_call_pages(struct boot_params *boot_params) d2600299dc44d38 Xin Jiang 2024-03-11 131 { d2600299dc44d38 Xin Jiang 2024-03-11 132 struct boot_e820_entry *entry; d2600299dc44d38 Xin Jiang 2024-03-11 133 struct csv3_secure_call_cmd *sc_page; d2600299dc44d38 Xin Jiang 2024-03-11 134 u64 offset; d2600299dc44d38 Xin Jiang 2024-03-11 135 u64 addr; d2600299dc44d38 Xin Jiang 2024-03-11 136 u8 i; d2600299dc44d38 Xin Jiang 2024-03-11 137 u8 table_num; d2600299dc44d38 Xin Jiang 2024-03-11 138 int count = 0; d2600299dc44d38 Xin Jiang 2024-03-11 139 d2600299dc44d38 Xin Jiang 2024-03-11 140 if (!boot_params) d2600299dc44d38 Xin Jiang 2024-03-11 141 return; d2600299dc44d38 Xin Jiang 2024-03-11 142 d2600299dc44d38 Xin Jiang 2024-03-11 143 if (csv3_boot_sc_page_a != -1ul && csv3_boot_sc_page_b != -1ul) d2600299dc44d38 Xin Jiang 2024-03-11 144 return; d2600299dc44d38 Xin Jiang 2024-03-11 145 d2600299dc44d38 Xin Jiang 2024-03-11 146 table_num = min_t(u8, boot_params->e820_entries, d2600299dc44d38 Xin Jiang 2024-03-11 147 E820_MAX_ENTRIES_ZEROPAGE); d2600299dc44d38 Xin Jiang 2024-03-11 148 entry = &boot_params->e820_table[0]; d2600299dc44d38 Xin Jiang 2024-03-11 149 for (i = 0; i < table_num; i++) { d2600299dc44d38 Xin Jiang 2024-03-11 150 if (entry[i].type != E820_TYPE_RESERVED) d2600299dc44d38 Xin Jiang 2024-03-11 151 continue; d2600299dc44d38 Xin Jiang 2024-03-11 152 d2600299dc44d38 Xin Jiang 2024-03-11 153 addr = entry[i].addr & PAGE_MASK; d2600299dc44d38 Xin Jiang 2024-03-11 154 for (offset = 0; offset < entry[i].size; offset += PAGE_SIZE) { d2600299dc44d38 Xin Jiang 2024-03-11 155 sc_page = (void *)(addr + offset); d2600299dc44d38 Xin Jiang 2024-03-11 156 if (sc_page->guid_64[0] == CSV3_SECURE_CALL_GUID_LOW && d2600299dc44d38 Xin Jiang 2024-03-11 157 sc_page->guid_64[1] == CSV3_SECURE_CALL_GUID_HIGH) { d2600299dc44d38 Xin Jiang 2024-03-11 158 if (count == 0) d2600299dc44d38 Xin Jiang 2024-03-11 159 csv3_boot_sc_page_a = addr + offset; d2600299dc44d38 Xin Jiang 2024-03-11 160 else if (count == 1) d2600299dc44d38 Xin Jiang 2024-03-11 161 csv3_boot_sc_page_b = addr + offset; d2600299dc44d38 Xin Jiang 2024-03-11 162 count++; d2600299dc44d38 Xin Jiang 2024-03-11 163 } d2600299dc44d38 Xin Jiang 2024-03-11 164 if (count >= 2) d2600299dc44d38 Xin Jiang 2024-03-11 165 return; d2600299dc44d38 Xin Jiang 2024-03-11 166 } d2600299dc44d38 Xin Jiang 2024-03-11 167 } d2600299dc44d38 Xin Jiang 2024-03-11 168 } d2600299dc44d38 Xin Jiang 2024-03-11 169 d2600299dc44d38 Xin Jiang 2024-03-11 170 /** d2600299dc44d38 Xin Jiang 2024-03-11 171 * csv3_early_secure_call_ident_map - issue early secure call command at the d2600299dc44d38 Xin Jiang 2024-03-11 172 * stage where identity page table is created. d2600299dc44d38 Xin Jiang 2024-03-11 173 * @base_address: Start address of the specified memory range. d2600299dc44d38 Xin Jiang 2024-03-11 174 * @num_pages: number of the specific pages. d2600299dc44d38 Xin Jiang 2024-03-11 175 * @cmd_type: Secure call cmd type. d2600299dc44d38 Xin Jiang 2024-03-11 176 */ d2600299dc44d38 Xin Jiang 2024-03-11 @177 void __init csv3_early_secure_call_ident_map(u64 base_address, u64 num_pages, :::::: The code at line 130 was first introduced by commit :::::: d2600299dc44d38ae1c69b2c0d5a0259c577290f x86/boot/compressed/64: Init CSV3 secure call pages :::::: TO: Xin Jiang <jiangxin(a)hygon.cn> :::::: CC: hanliyang <hanliyang(a)hygon.cn> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 2516/2516] security/integrity/ima/ima_template_lib.c:102:44: sparse: sparse: cast to restricted __le16
by kernel test robot 03 Dec '24

03 Dec '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 020e0507954f21291b7b3a0a280128270a0d8959 commit: 2c0768b2f0838b4a365d958abd751773e795e987 [2516/2516] ima: Add ima_show_template_uint() template library function config: x86_64-randconfig-121-20241203 (https://download.01.org/0day-ci/archive/20241203/202412031310.oFwEBFj9-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412031310.oFwEBFj9-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412031310.oFwEBFj9-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> security/integrity/ima/ima_template_lib.c:102:44: sparse: sparse: cast to restricted __le16 security/integrity/ima/ima_template_lib.c:109:44: sparse: sparse: cast to restricted __le32 >> security/integrity/ima/ima_template_lib.c:116:44: sparse: sparse: cast to restricted __le64 security/integrity/ima/ima_template_lib.c:137:60: sparse: sparse: restricted __le32 degrades to integer security/integrity/ima/ima_template_lib.c:232:49: sparse: sparse: cast to restricted __le32 vim +102 security/integrity/ima/ima_template_lib.c 66 67 static void ima_show_template_data_ascii(struct seq_file *m, 68 enum ima_show_type show, 69 enum data_formats datafmt, 70 struct ima_field_data *field_data) 71 { 72 u8 *buf_ptr = field_data->data; 73 u32 buflen = field_data->len; 74 75 switch (datafmt) { 76 case DATA_FMT_DIGEST_WITH_ALGO: 77 buf_ptr = strnchr(field_data->data, buflen, ':'); 78 if (buf_ptr != field_data->data) 79 seq_printf(m, "%s", field_data->data); 80 81 /* skip ':' and '\0' */ 82 buf_ptr += 2; 83 buflen -= buf_ptr - field_data->data; 84 fallthrough; 85 case DATA_FMT_DIGEST: 86 case DATA_FMT_HEX: 87 if (!buflen) 88 break; 89 ima_print_digest(m, buf_ptr, buflen); 90 break; 91 case DATA_FMT_STRING: 92 seq_printf(m, "%s", buf_ptr); 93 break; 94 case DATA_FMT_UINT: 95 switch (field_data->len) { 96 case sizeof(u8): 97 seq_printf(m, "%u", *(u8 *)buf_ptr); 98 break; 99 case sizeof(u16): 100 if (ima_canonical_fmt) 101 seq_printf(m, "%u", > 102 le16_to_cpu(*(u16 *)buf_ptr)); 103 else 104 seq_printf(m, "%u", *(u16 *)buf_ptr); 105 break; 106 case sizeof(u32): 107 if (ima_canonical_fmt) 108 seq_printf(m, "%u", 109 le32_to_cpu(*(u32 *)buf_ptr)); 110 else 111 seq_printf(m, "%u", *(u32 *)buf_ptr); 112 break; 113 case sizeof(u64): 114 if (ima_canonical_fmt) 115 seq_printf(m, "%llu", > 116 le64_to_cpu(*(u64 *)buf_ptr)); 117 else 118 seq_printf(m, "%llu", *(u64 *)buf_ptr); 119 break; 120 default: 121 break; 122 } 123 default: 124 break; 125 } 126 } 127 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0