- Kernel - mailweb.openeuler.org

[PATCH openEuler-1.0-LTS] scsi: target: tcmu: Fix possible page UAF
by Zheng Qixing 18 Mar '25

18 Mar '25

From: Xiaoguang Wang <xiaoguang.wang(a)linux.alibaba.com> stable inclusion from stable-v4.19.239 commit e3e0e067d5b34e4a68e3cc55f8eebc413f56f8ed category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBP6TV CVE: CVE-2022-49053 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… ------------------ [ Upstream commit a6968f7a367f128d120447360734344d5a3d5336 ] tcmu_try_get_data_page() looks up pages under cmdr_lock, but it does not take refcount properly and just returns page pointer. When tcmu_try_get_data_page() returns, the returned page may have been freed by tcmu_blocks_release(). We need to get_page() under cmdr_lock to avoid concurrent tcmu_blocks_release(). Link: https://lore.kernel.org/r/20220311132206.24515-1-xiaoguang.wang@linux.aliba… Reviewed-by: Bodo Stroesser <bostroesser(a)gmail.com> Signed-off-by: Xiaoguang Wang <xiaoguang.wang(a)linux.alibaba.com> Signed-off-by: Martin K. Petersen <martin.petersen(a)oracle.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Zheng Qixing <zhengqixing(a)huawei.com> --- drivers/target/target_core_user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index de27014685ac..eed2d8e1c92f 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -1528,6 +1528,7 @@ static struct page *tcmu_try_get_block_page(struct tcmu_dev *udev, uint32_t dbi) mutex_lock(&udev->cmdr_lock); page = tcmu_get_block_page(udev, dbi); if (likely(page)) { + get_page(page); mutex_unlock(&udev->cmdr_lock); return page; } @@ -1566,6 +1567,7 @@ static vm_fault_t tcmu_vma_fault(struct vm_fault *vmf) /* For the vmalloc()ed cmd area pages */ addr = (void *)(unsigned long)info->mem[mi].addr + offset; page = vmalloc_to_page(addr); + get_page(page); } else { uint32_t dbi; @@ -1576,7 +1578,6 @@ static vm_fault_t tcmu_vma_fault(struct vm_fault *vmf) return VM_FAULT_SIGBUS; } - get_page(page); vmf->page = page; return 0; } -- 2.39.2

2 1

[openeuler:openEuler-1.0-LTS 1501/1501] lib/ubsan.c:195:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_add_overflow'; expected 'void *'
by kernel test robot 18 Mar '25

18 Mar '25

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: a304375c0bb304fd38fa85987919aff3d831cf9b commit: d2e5767132d657577127f1d35764bb4721dd3cc5 [1501/1501] ubsan: Fix nasty -Wbuiltin-declaration-mismatch GCC-9 warnings config: arm64-randconfig-001-20250318 (https://download.01.org/0day-ci/archive/20250318/202503181741.vcHyKenV-lkp@…) compiler: aarch64-linux-gcc (GCC) 9.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250318/202503181741.vcHyKenV-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202503181741.vcHyKenV-lkp@intel.com/ All warnings (new ones prefixed by >>): >> lib/ubsan.c:195:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_add_overflow'; expected 'void *' [-Wbuiltin-declaration-mismatch] 195 | void __ubsan_handle_add_overflow(struct overflow_data *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> lib/ubsan.c:203:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_sub_overflow'; expected 'void *' [-Wbuiltin-declaration-mismatch] 203 | void __ubsan_handle_sub_overflow(struct overflow_data *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> lib/ubsan.c:210:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_mul_overflow'; expected 'void *' [-Wbuiltin-declaration-mismatch] 210 | void __ubsan_handle_mul_overflow(struct overflow_data *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> lib/ubsan.c:217:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_negate_overflow'; expected 'void *' [-Wbuiltin-declaration-mismatch] 217 | void __ubsan_handle_negate_overflow(struct overflow_data *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> lib/ubsan.c:238:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_divrem_overflow'; expected 'void *' [-Wbuiltin-declaration-mismatch] 238 | void __ubsan_handle_divrem_overflow(struct overflow_data *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/ubsan.c:323:6: warning: no previous prototype for '__ubsan_handle_type_mismatch' [-Wmissing-prototypes] 323 | void __ubsan_handle_type_mismatch(struct type_mismatch_data *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> lib/ubsan.c:337:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_type_mismatch_v1'; expected 'void *' [-Wbuiltin-declaration-mismatch] 337 | void __ubsan_handle_type_mismatch_v1(struct type_mismatch_data_v1 *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> lib/ubsan.c:352:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_vla_bound_not_positive'; expected 'void *' [-Wbuiltin-declaration-mismatch] 352 | void __ubsan_handle_vla_bound_not_positive(struct vla_bound_data *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> lib/ubsan.c:370:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_out_of_bounds'; expected 'void *' [-Wbuiltin-declaration-mismatch] 370 | void __ubsan_handle_out_of_bounds(struct out_of_bounds_data *data, void *index) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> lib/ubsan.c:387:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_shift_out_of_bounds'; expected 'void *' [-Wbuiltin-declaration-mismatch] 387 | void __ubsan_handle_shift_out_of_bounds(struct shift_out_of_bounds_data *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/ubsan.c:427:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_builtin_unreachable'; expected 'void *' [-Wbuiltin-declaration-mismatch] 427 | void __ubsan_handle_builtin_unreachable(struct unreachable_data *data) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> lib/ubsan.c:438:6: warning: mismatch in argument 1 type of built-in function '__ubsan_handle_load_invalid_value'; expected 'void *' [-Wbuiltin-declaration-mismatch] 438 | void __ubsan_handle_load_invalid_value(struct invalid_value_data *data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +195 lib/ubsan.c c6d308534aef6c Andrey Ryabinin 2016-01-20 194 c6d308534aef6c Andrey Ryabinin 2016-01-20 @195 void __ubsan_handle_add_overflow(struct overflow_data *data, d2e5767132d657 Andrey Ryabinin 2019-05-13 196 void *lhs, void *rhs) c6d308534aef6c Andrey Ryabinin 2016-01-20 197 { c6d308534aef6c Andrey Ryabinin 2016-01-20 198 c6d308534aef6c Andrey Ryabinin 2016-01-20 199 handle_overflow(data, lhs, rhs, '+'); c6d308534aef6c Andrey Ryabinin 2016-01-20 200 } c6d308534aef6c Andrey Ryabinin 2016-01-20 201 EXPORT_SYMBOL(__ubsan_handle_add_overflow); c6d308534aef6c Andrey Ryabinin 2016-01-20 202 c6d308534aef6c Andrey Ryabinin 2016-01-20 @203 void __ubsan_handle_sub_overflow(struct overflow_data *data, d2e5767132d657 Andrey Ryabinin 2019-05-13 204 void *lhs, void *rhs) c6d308534aef6c Andrey Ryabinin 2016-01-20 205 { c6d308534aef6c Andrey Ryabinin 2016-01-20 206 handle_overflow(data, lhs, rhs, '-'); c6d308534aef6c Andrey Ryabinin 2016-01-20 207 } c6d308534aef6c Andrey Ryabinin 2016-01-20 208 EXPORT_SYMBOL(__ubsan_handle_sub_overflow); c6d308534aef6c Andrey Ryabinin 2016-01-20 209 c6d308534aef6c Andrey Ryabinin 2016-01-20 @210 void __ubsan_handle_mul_overflow(struct overflow_data *data, d2e5767132d657 Andrey Ryabinin 2019-05-13 211 void *lhs, void *rhs) c6d308534aef6c Andrey Ryabinin 2016-01-20 212 { c6d308534aef6c Andrey Ryabinin 2016-01-20 213 handle_overflow(data, lhs, rhs, '*'); c6d308534aef6c Andrey Ryabinin 2016-01-20 214 } c6d308534aef6c Andrey Ryabinin 2016-01-20 215 EXPORT_SYMBOL(__ubsan_handle_mul_overflow); c6d308534aef6c Andrey Ryabinin 2016-01-20 216 c6d308534aef6c Andrey Ryabinin 2016-01-20 @217 void __ubsan_handle_negate_overflow(struct overflow_data *data, d2e5767132d657 Andrey Ryabinin 2019-05-13 218 void *old_val) c6d308534aef6c Andrey Ryabinin 2016-01-20 219 { c6d308534aef6c Andrey Ryabinin 2016-01-20 220 unsigned long flags; c6d308534aef6c Andrey Ryabinin 2016-01-20 221 char old_val_str[VALUE_LENGTH]; c6d308534aef6c Andrey Ryabinin 2016-01-20 222 c6d308534aef6c Andrey Ryabinin 2016-01-20 223 if (suppress_report(&data->location)) c6d308534aef6c Andrey Ryabinin 2016-01-20 224 return; c6d308534aef6c Andrey Ryabinin 2016-01-20 225 c6d308534aef6c Andrey Ryabinin 2016-01-20 226 ubsan_prologue(&data->location, &flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 227 c6d308534aef6c Andrey Ryabinin 2016-01-20 228 val_to_string(old_val_str, sizeof(old_val_str), data->type, old_val); c6d308534aef6c Andrey Ryabinin 2016-01-20 229 c6d308534aef6c Andrey Ryabinin 2016-01-20 230 pr_err("negation of %s cannot be represented in type %s:\n", c6d308534aef6c Andrey Ryabinin 2016-01-20 231 old_val_str, data->type->type_name); c6d308534aef6c Andrey Ryabinin 2016-01-20 232 c6d308534aef6c Andrey Ryabinin 2016-01-20 233 ubsan_epilogue(&flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 234 } c6d308534aef6c Andrey Ryabinin 2016-01-20 235 EXPORT_SYMBOL(__ubsan_handle_negate_overflow); c6d308534aef6c Andrey Ryabinin 2016-01-20 236 c6d308534aef6c Andrey Ryabinin 2016-01-20 237 c6d308534aef6c Andrey Ryabinin 2016-01-20 @238 void __ubsan_handle_divrem_overflow(struct overflow_data *data, d2e5767132d657 Andrey Ryabinin 2019-05-13 239 void *lhs, void *rhs) c6d308534aef6c Andrey Ryabinin 2016-01-20 240 { c6d308534aef6c Andrey Ryabinin 2016-01-20 241 unsigned long flags; c6d308534aef6c Andrey Ryabinin 2016-01-20 242 char rhs_val_str[VALUE_LENGTH]; c6d308534aef6c Andrey Ryabinin 2016-01-20 243 c6d308534aef6c Andrey Ryabinin 2016-01-20 244 if (suppress_report(&data->location)) c6d308534aef6c Andrey Ryabinin 2016-01-20 245 return; c6d308534aef6c Andrey Ryabinin 2016-01-20 246 c6d308534aef6c Andrey Ryabinin 2016-01-20 247 ubsan_prologue(&data->location, &flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 248 c6d308534aef6c Andrey Ryabinin 2016-01-20 249 val_to_string(rhs_val_str, sizeof(rhs_val_str), data->type, rhs); c6d308534aef6c Andrey Ryabinin 2016-01-20 250 c6d308534aef6c Andrey Ryabinin 2016-01-20 251 if (type_is_signed(data->type) && get_signed_val(data->type, rhs) == -1) c6d308534aef6c Andrey Ryabinin 2016-01-20 252 pr_err("division of %s by -1 cannot be represented in type %s\n", c6d308534aef6c Andrey Ryabinin 2016-01-20 253 rhs_val_str, data->type->type_name); c6d308534aef6c Andrey Ryabinin 2016-01-20 254 else c6d308534aef6c Andrey Ryabinin 2016-01-20 255 pr_err("division by zero\n"); c6d308534aef6c Andrey Ryabinin 2016-01-20 256 c6d308534aef6c Andrey Ryabinin 2016-01-20 257 ubsan_epilogue(&flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 258 } c6d308534aef6c Andrey Ryabinin 2016-01-20 259 EXPORT_SYMBOL(__ubsan_handle_divrem_overflow); c6d308534aef6c Andrey Ryabinin 2016-01-20 260 42440c1f9911b4 Andrey Ryabinin 2018-02-06 261 static void handle_null_ptr_deref(struct type_mismatch_data_common *data) c6d308534aef6c Andrey Ryabinin 2016-01-20 262 { c6d308534aef6c Andrey Ryabinin 2016-01-20 263 unsigned long flags; c6d308534aef6c Andrey Ryabinin 2016-01-20 264 42440c1f9911b4 Andrey Ryabinin 2018-02-06 265 if (suppress_report(data->location)) c6d308534aef6c Andrey Ryabinin 2016-01-20 266 return; c6d308534aef6c Andrey Ryabinin 2016-01-20 267 42440c1f9911b4 Andrey Ryabinin 2018-02-06 268 ubsan_prologue(data->location, &flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 269 c6d308534aef6c Andrey Ryabinin 2016-01-20 270 pr_err("%s null pointer of type %s\n", c6d308534aef6c Andrey Ryabinin 2016-01-20 271 type_check_kinds[data->type_check_kind], c6d308534aef6c Andrey Ryabinin 2016-01-20 272 data->type->type_name); c6d308534aef6c Andrey Ryabinin 2016-01-20 273 c6d308534aef6c Andrey Ryabinin 2016-01-20 274 ubsan_epilogue(&flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 275 } c6d308534aef6c Andrey Ryabinin 2016-01-20 276 42440c1f9911b4 Andrey Ryabinin 2018-02-06 277 static void handle_misaligned_access(struct type_mismatch_data_common *data, c6d308534aef6c Andrey Ryabinin 2016-01-20 278 unsigned long ptr) c6d308534aef6c Andrey Ryabinin 2016-01-20 279 { c6d308534aef6c Andrey Ryabinin 2016-01-20 280 unsigned long flags; c6d308534aef6c Andrey Ryabinin 2016-01-20 281 42440c1f9911b4 Andrey Ryabinin 2018-02-06 282 if (suppress_report(data->location)) c6d308534aef6c Andrey Ryabinin 2016-01-20 283 return; c6d308534aef6c Andrey Ryabinin 2016-01-20 284 42440c1f9911b4 Andrey Ryabinin 2018-02-06 285 ubsan_prologue(data->location, &flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 286 c6d308534aef6c Andrey Ryabinin 2016-01-20 287 pr_err("%s misaligned address %p for type %s\n", c6d308534aef6c Andrey Ryabinin 2016-01-20 288 type_check_kinds[data->type_check_kind], c6d308534aef6c Andrey Ryabinin 2016-01-20 289 (void *)ptr, data->type->type_name); c6d308534aef6c Andrey Ryabinin 2016-01-20 290 pr_err("which requires %ld byte alignment\n", data->alignment); c6d308534aef6c Andrey Ryabinin 2016-01-20 291 c6d308534aef6c Andrey Ryabinin 2016-01-20 292 ubsan_epilogue(&flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 293 } c6d308534aef6c Andrey Ryabinin 2016-01-20 294 42440c1f9911b4 Andrey Ryabinin 2018-02-06 295 static void handle_object_size_mismatch(struct type_mismatch_data_common *data, c6d308534aef6c Andrey Ryabinin 2016-01-20 296 unsigned long ptr) c6d308534aef6c Andrey Ryabinin 2016-01-20 297 { c6d308534aef6c Andrey Ryabinin 2016-01-20 298 unsigned long flags; c6d308534aef6c Andrey Ryabinin 2016-01-20 299 42440c1f9911b4 Andrey Ryabinin 2018-02-06 300 if (suppress_report(data->location)) c6d308534aef6c Andrey Ryabinin 2016-01-20 301 return; c6d308534aef6c Andrey Ryabinin 2016-01-20 302 42440c1f9911b4 Andrey Ryabinin 2018-02-06 303 ubsan_prologue(data->location, &flags); 901d805c33fc4c Nicolas Iooss 2016-08-02 304 pr_err("%s address %p with insufficient space\n", c6d308534aef6c Andrey Ryabinin 2016-01-20 305 type_check_kinds[data->type_check_kind], c6d308534aef6c Andrey Ryabinin 2016-01-20 306 (void *) ptr); c6d308534aef6c Andrey Ryabinin 2016-01-20 307 pr_err("for an object of type %s\n", data->type->type_name); c6d308534aef6c Andrey Ryabinin 2016-01-20 308 ubsan_epilogue(&flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 309 } c6d308534aef6c Andrey Ryabinin 2016-01-20 310 42440c1f9911b4 Andrey Ryabinin 2018-02-06 311 static void ubsan_type_mismatch_common(struct type_mismatch_data_common *data, c6d308534aef6c Andrey Ryabinin 2016-01-20 312 unsigned long ptr) c6d308534aef6c Andrey Ryabinin 2016-01-20 313 { c6d308534aef6c Andrey Ryabinin 2016-01-20 314 c6d308534aef6c Andrey Ryabinin 2016-01-20 315 if (!ptr) c6d308534aef6c Andrey Ryabinin 2016-01-20 316 handle_null_ptr_deref(data); c6d308534aef6c Andrey Ryabinin 2016-01-20 317 else if (data->alignment && !IS_ALIGNED(ptr, data->alignment)) b8fe1120b4ba34 Andrew Morton 2018-02-06 318 handle_misaligned_access(data, ptr); c6d308534aef6c Andrey Ryabinin 2016-01-20 319 else c6d308534aef6c Andrey Ryabinin 2016-01-20 320 handle_object_size_mismatch(data, ptr); c6d308534aef6c Andrey Ryabinin 2016-01-20 321 } 42440c1f9911b4 Andrey Ryabinin 2018-02-06 322 42440c1f9911b4 Andrey Ryabinin 2018-02-06 323 void __ubsan_handle_type_mismatch(struct type_mismatch_data *data, d2e5767132d657 Andrey Ryabinin 2019-05-13 324 void *ptr) 42440c1f9911b4 Andrey Ryabinin 2018-02-06 325 { 42440c1f9911b4 Andrey Ryabinin 2018-02-06 326 struct type_mismatch_data_common common_data = { 42440c1f9911b4 Andrey Ryabinin 2018-02-06 327 .location = &data->location, 42440c1f9911b4 Andrey Ryabinin 2018-02-06 328 .type = data->type, 42440c1f9911b4 Andrey Ryabinin 2018-02-06 329 .alignment = data->alignment, 42440c1f9911b4 Andrey Ryabinin 2018-02-06 330 .type_check_kind = data->type_check_kind 42440c1f9911b4 Andrey Ryabinin 2018-02-06 331 }; 42440c1f9911b4 Andrey Ryabinin 2018-02-06 332 d2e5767132d657 Andrey Ryabinin 2019-05-13 333 ubsan_type_mismatch_common(&common_data, (unsigned long)ptr); 42440c1f9911b4 Andrey Ryabinin 2018-02-06 334 } c6d308534aef6c Andrey Ryabinin 2016-01-20 335 EXPORT_SYMBOL(__ubsan_handle_type_mismatch); c6d308534aef6c Andrey Ryabinin 2016-01-20 336 42440c1f9911b4 Andrey Ryabinin 2018-02-06 @337 void __ubsan_handle_type_mismatch_v1(struct type_mismatch_data_v1 *data, d2e5767132d657 Andrey Ryabinin 2019-05-13 338 void *ptr) 42440c1f9911b4 Andrey Ryabinin 2018-02-06 339 { 42440c1f9911b4 Andrey Ryabinin 2018-02-06 340 42440c1f9911b4 Andrey Ryabinin 2018-02-06 341 struct type_mismatch_data_common common_data = { 42440c1f9911b4 Andrey Ryabinin 2018-02-06 342 .location = &data->location, 42440c1f9911b4 Andrey Ryabinin 2018-02-06 343 .type = data->type, 42440c1f9911b4 Andrey Ryabinin 2018-02-06 344 .alignment = 1UL << data->log_alignment, 42440c1f9911b4 Andrey Ryabinin 2018-02-06 345 .type_check_kind = data->type_check_kind 42440c1f9911b4 Andrey Ryabinin 2018-02-06 346 }; 42440c1f9911b4 Andrey Ryabinin 2018-02-06 347 d2e5767132d657 Andrey Ryabinin 2019-05-13 348 ubsan_type_mismatch_common(&common_data, (unsigned long)ptr); 42440c1f9911b4 Andrey Ryabinin 2018-02-06 349 } 42440c1f9911b4 Andrey Ryabinin 2018-02-06 350 EXPORT_SYMBOL(__ubsan_handle_type_mismatch_v1); 42440c1f9911b4 Andrey Ryabinin 2018-02-06 351 c6d308534aef6c Andrey Ryabinin 2016-01-20 @352 void __ubsan_handle_vla_bound_not_positive(struct vla_bound_data *data, d2e5767132d657 Andrey Ryabinin 2019-05-13 353 void *bound) c6d308534aef6c Andrey Ryabinin 2016-01-20 354 { c6d308534aef6c Andrey Ryabinin 2016-01-20 355 unsigned long flags; c6d308534aef6c Andrey Ryabinin 2016-01-20 356 char bound_str[VALUE_LENGTH]; c6d308534aef6c Andrey Ryabinin 2016-01-20 357 c6d308534aef6c Andrey Ryabinin 2016-01-20 358 if (suppress_report(&data->location)) c6d308534aef6c Andrey Ryabinin 2016-01-20 359 return; c6d308534aef6c Andrey Ryabinin 2016-01-20 360 c6d308534aef6c Andrey Ryabinin 2016-01-20 361 ubsan_prologue(&data->location, &flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 362 c6d308534aef6c Andrey Ryabinin 2016-01-20 363 val_to_string(bound_str, sizeof(bound_str), data->type, bound); c6d308534aef6c Andrey Ryabinin 2016-01-20 364 pr_err("variable length array bound value %s <= 0\n", bound_str); c6d308534aef6c Andrey Ryabinin 2016-01-20 365 c6d308534aef6c Andrey Ryabinin 2016-01-20 366 ubsan_epilogue(&flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 367 } c6d308534aef6c Andrey Ryabinin 2016-01-20 368 EXPORT_SYMBOL(__ubsan_handle_vla_bound_not_positive); c6d308534aef6c Andrey Ryabinin 2016-01-20 369 d2e5767132d657 Andrey Ryabinin 2019-05-13 @370 void __ubsan_handle_out_of_bounds(struct out_of_bounds_data *data, void *index) c6d308534aef6c Andrey Ryabinin 2016-01-20 371 { c6d308534aef6c Andrey Ryabinin 2016-01-20 372 unsigned long flags; c6d308534aef6c Andrey Ryabinin 2016-01-20 373 char index_str[VALUE_LENGTH]; c6d308534aef6c Andrey Ryabinin 2016-01-20 374 c6d308534aef6c Andrey Ryabinin 2016-01-20 375 if (suppress_report(&data->location)) c6d308534aef6c Andrey Ryabinin 2016-01-20 376 return; c6d308534aef6c Andrey Ryabinin 2016-01-20 377 c6d308534aef6c Andrey Ryabinin 2016-01-20 378 ubsan_prologue(&data->location, &flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 379 c6d308534aef6c Andrey Ryabinin 2016-01-20 380 val_to_string(index_str, sizeof(index_str), data->index_type, index); c6d308534aef6c Andrey Ryabinin 2016-01-20 381 pr_err("index %s is out of range for type %s\n", index_str, c6d308534aef6c Andrey Ryabinin 2016-01-20 382 data->array_type->type_name); c6d308534aef6c Andrey Ryabinin 2016-01-20 383 ubsan_epilogue(&flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 384 } c6d308534aef6c Andrey Ryabinin 2016-01-20 385 EXPORT_SYMBOL(__ubsan_handle_out_of_bounds); c6d308534aef6c Andrey Ryabinin 2016-01-20 386 c6d308534aef6c Andrey Ryabinin 2016-01-20 @387 void __ubsan_handle_shift_out_of_bounds(struct shift_out_of_bounds_data *data, d2e5767132d657 Andrey Ryabinin 2019-05-13 388 void *lhs, void *rhs) c6d308534aef6c Andrey Ryabinin 2016-01-20 389 { c6d308534aef6c Andrey Ryabinin 2016-01-20 390 unsigned long flags; c6d308534aef6c Andrey Ryabinin 2016-01-20 391 struct type_descriptor *rhs_type = data->rhs_type; c6d308534aef6c Andrey Ryabinin 2016-01-20 392 struct type_descriptor *lhs_type = data->lhs_type; c6d308534aef6c Andrey Ryabinin 2016-01-20 393 char rhs_str[VALUE_LENGTH]; c6d308534aef6c Andrey Ryabinin 2016-01-20 394 char lhs_str[VALUE_LENGTH]; c6d308534aef6c Andrey Ryabinin 2016-01-20 395 c6d308534aef6c Andrey Ryabinin 2016-01-20 396 if (suppress_report(&data->location)) c6d308534aef6c Andrey Ryabinin 2016-01-20 397 return; c6d308534aef6c Andrey Ryabinin 2016-01-20 398 c6d308534aef6c Andrey Ryabinin 2016-01-20 399 ubsan_prologue(&data->location, &flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 400 c6d308534aef6c Andrey Ryabinin 2016-01-20 401 val_to_string(rhs_str, sizeof(rhs_str), rhs_type, rhs); c6d308534aef6c Andrey Ryabinin 2016-01-20 402 val_to_string(lhs_str, sizeof(lhs_str), lhs_type, lhs); c6d308534aef6c Andrey Ryabinin 2016-01-20 403 c6d308534aef6c Andrey Ryabinin 2016-01-20 404 if (val_is_negative(rhs_type, rhs)) c6d308534aef6c Andrey Ryabinin 2016-01-20 405 pr_err("shift exponent %s is negative\n", rhs_str); c6d308534aef6c Andrey Ryabinin 2016-01-20 406 c6d308534aef6c Andrey Ryabinin 2016-01-20 407 else if (get_unsigned_val(rhs_type, rhs) >= c6d308534aef6c Andrey Ryabinin 2016-01-20 408 type_bit_width(lhs_type)) c6d308534aef6c Andrey Ryabinin 2016-01-20 409 pr_err("shift exponent %s is too large for %u-bit type %s\n", c6d308534aef6c Andrey Ryabinin 2016-01-20 410 rhs_str, c6d308534aef6c Andrey Ryabinin 2016-01-20 411 type_bit_width(lhs_type), c6d308534aef6c Andrey Ryabinin 2016-01-20 412 lhs_type->type_name); c6d308534aef6c Andrey Ryabinin 2016-01-20 413 else if (val_is_negative(lhs_type, lhs)) c6d308534aef6c Andrey Ryabinin 2016-01-20 414 pr_err("left shift of negative value %s\n", c6d308534aef6c Andrey Ryabinin 2016-01-20 415 lhs_str); c6d308534aef6c Andrey Ryabinin 2016-01-20 416 else c6d308534aef6c Andrey Ryabinin 2016-01-20 417 pr_err("left shift of %s by %s places cannot be" c6d308534aef6c Andrey Ryabinin 2016-01-20 418 " represented in type %s\n", c6d308534aef6c Andrey Ryabinin 2016-01-20 419 lhs_str, rhs_str, c6d308534aef6c Andrey Ryabinin 2016-01-20 420 lhs_type->type_name); c6d308534aef6c Andrey Ryabinin 2016-01-20 421 c6d308534aef6c Andrey Ryabinin 2016-01-20 422 ubsan_epilogue(&flags); c6d308534aef6c Andrey Ryabinin 2016-01-20 423 } c6d308534aef6c Andrey Ryabinin 2016-01-20 424 EXPORT_SYMBOL(__ubsan_handle_shift_out_of_bounds); c6d308534aef6c Andrey Ryabinin 2016-01-20 425 c6d308534aef6c Andrey Ryabinin 2016-01-20 426 :::::: The code at line 195 was first introduced by commit :::::: c6d308534aef6c99904bf5862066360ae067abc4 UBSAN: run-time undefined behavior sanity checker :::::: TO: Andrey Ryabinin <aryabinin(a)virtuozzo.com> :::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH openEuler-1.0-LTS] drm/plane: Move range check for format_count earlier
by Wang Wensheng 18 Mar '25

18 Mar '25

From: Steven Price <steven.price(a)arm.com> stable inclusion from stable-v4.19.247 commit 4ab7e453a3ee88c274cf97bee9487ab92a66d313 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBP6CD CVE: CVE-2021-47659 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 4b674dd69701c2e22e8e7770c1706a69f3b17269 ] While the check for format_count > 64 in __drm_universal_plane_init() shouldn't be hit (it's a WARN_ON), in its current position it will then leak the plane->format_types array and fail to call drm_mode_object_unregister() leaking the modeset identifier. Move it to the start of the function to avoid allocating those resources in the first place. Signed-off-by: Steven Price <steven.price(a)arm.com> Signed-off-by: Liviu Dudau <liviu.dudau(a)arm.com> Link: https://lore.kernel.org/dri-devel/20211203102815.38624-1-steven.price@arm.c… Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Wang Wensheng <wangwensheng4(a)huawei.com> --- drivers/gpu/drm/drm_plane.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 4c530900a208..35df2fac5c29 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -177,6 +177,13 @@ int drm_universal_plane_init(struct drm_device *dev, struct drm_plane *plane, if (WARN_ON(config->num_total_plane >= 32)) return -EINVAL; + /* + * First driver to need more than 64 formats needs to fix this. Each + * format is encoded as a bit and the current code only supports a u64. + */ + if (WARN_ON(format_count > 64)) + return -EINVAL; + WARN_ON(drm_drv_uses_atomic_modeset(dev) && (!funcs->atomic_destroy_state || !funcs->atomic_duplicate_state)); @@ -198,13 +205,6 @@ int drm_universal_plane_init(struct drm_device *dev, struct drm_plane *plane, return -ENOMEM; } - /* - * First driver to need more than 64 formats needs to fix this. Each - * format is encoded as a bit and the current code only supports a u64. - */ - if (WARN_ON(format_count > 64)) - return -EINVAL; - if (format_modifiers) { const uint64_t *temp_modifiers = format_modifiers; while (*temp_modifiers++ != DRM_FORMAT_MOD_INVALID) -- 2.22.0

2 1

[PATCH openEuler-1.0-LTS] drm/amdgpu/cs: make commands with 0 chunks illegal behaviour.
by Wang Wensheng 18 Mar '25

18 Mar '25

From: Dave Airlie <airlied(a)redhat.com> stable inclusion from stable-v4.19.247 commit 15c3bcc9b5349d40207e5f8d4d799b8b4b7d13b8 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBP2QX CVE: CVE-2022-49335 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- commit 31ab27b14daaa75541a415c6794d6f3567fea44a upstream. Submitting a cs with 0 chunks, causes an oops later, found trying to execute the wrong userspace driver. MESA_LOADER_DRIVER_OVERRIDE=v3d glxinfo [172536.665184] BUG: kernel NULL pointer dereference, address: 00000000000001d8 [172536.665188] #PF: supervisor read access in kernel mode [172536.665189] #PF: error_code(0x0000) - not-present page [172536.665191] PGD 6712a0067 P4D 6712a0067 PUD 5af9ff067 PMD 0 [172536.665195] Oops: 0000 [#1] SMP NOPTI [172536.665197] CPU: 7 PID: 2769838 Comm: glxinfo Tainted: P O 5.10.81 #1-NixOS [172536.665199] Hardware name: To be filled by O.E.M. To be filled by O.E.M./CROSSHAIR V FORMULA-Z, BIOS 2201 03/23/2015 [172536.665272] RIP: 0010:amdgpu_cs_ioctl+0x96/0x1ce0 [amdgpu] [172536.665274] Code: 75 18 00 00 4c 8b b2 88 00 00 00 8b 46 08 48 89 54 24 68 49 89 f7 4c 89 5c 24 60 31 d2 4c 89 74 24 30 85 c0 0f 85 c0 01 00 00 <48> 83 ba d8 01 00 00 00 48 8b b4 24 90 00 00 00 74 16 48 8b 46 10 [172536.665276] RSP: 0018:ffffb47c0e81bbe0 EFLAGS: 00010246 [172536.665277] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 [172536.665278] RDX: 0000000000000000 RSI: ffffb47c0e81be28 RDI: ffffb47c0e81bd68 [172536.665279] RBP: ffff936524080010 R08: 0000000000000000 R09: ffffb47c0e81be38 [172536.665281] R10: ffff936524080010 R11: ffff936524080000 R12: ffffb47c0e81bc40 [172536.665282] R13: ffffb47c0e81be28 R14: ffff9367bc410000 R15: ffffb47c0e81be28 [172536.665283] FS: 00007fe35e05d740(0000) GS:ffff936c1edc0000(0000) knlGS:0000000000000000 [172536.665284] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [172536.665286] CR2: 00000000000001d8 CR3: 0000000532e46000 CR4: 00000000000406e0 [172536.665287] Call Trace: [172536.665322] ? amdgpu_cs_find_mapping+0x110/0x110 [amdgpu] [172536.665332] drm_ioctl_kernel+0xaa/0xf0 [drm] [172536.665338] drm_ioctl+0x201/0x3b0 [drm] [172536.665369] ? amdgpu_cs_find_mapping+0x110/0x110 [amdgpu] [172536.665372] ? selinux_file_ioctl+0x135/0x230 [172536.665399] amdgpu_drm_ioctl+0x49/0x80 [amdgpu] [172536.665403] __x64_sys_ioctl+0x83/0xb0 [172536.665406] do_syscall_64+0x33/0x40 [172536.665409] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2018 Signed-off-by: Dave Airlie <airlied(a)redhat.com> Cc: stable(a)vger.kernel.org Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Wang Wensheng <wangwensheng4(a)huawei.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index d1554485f8e5..70e446c2acf8 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -110,7 +110,7 @@ static int amdgpu_cs_parser_init(struct amdgpu_cs_parser *p, union drm_amdgpu_cs int ret; if (cs->in.num_chunks == 0) - return 0; + return -EINVAL; chunk_array = kmalloc_array(cs->in.num_chunks, sizeof(uint64_t), GFP_KERNEL); if (!chunk_array) -- 2.22.0

2 1

[PATCH openEuler-1.0-LTS 0/3]some CVE fixes
by Tong Tiangen 18 Mar '25

18 Mar '25

Duoming Zhou (1): drivers: staging: rtl8192e: Fix deadlock in rtllib_beacons_stop() Martin Faltesek (1): nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling Yang Yingliang (1): rtc: mt6397: check return value after calling platform_get_resource() drivers/nfc/st21nfca/se.c | 13 ++++++++++--- drivers/rtc/rtc-mt6397.c | 2 ++ drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 3 files changed, 13 insertions(+), 4 deletions(-) -- 2.25.1

2 4

[openeuler:OLK-5.10] BUILD REGRESSION a348aa0315d2a90cde93df922b84ab682459a834
by kernel test robot 18 Mar '25

18 Mar '25

tree/branch: https://gitee.com/openeuler/kernel.git OLK-5.10 branch HEAD: a348aa0315d2a90cde93df922b84ab682459a834 !14918 [OLK-5.10] backport important bugfix from the kernel-5.10.y Error/Warning (recently discovered and may have been fixed): https://lore.kernel.org/oe-kbuild-all/202503171920.f4jVchcy-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202503181406.E4pR441t-lkp@intel.com ld.lld: error: version script assignment of 'LINUX_2.6' to symbol '__vdso_sgx_enter_enclave' failed: symbol not defined llvm-objcopy: error: 'arch/x86/entry/vdso/vdso64.so.dbg': No such file or directory llvm-objdump: error: 'arch/x86/entry/vdso/vdso64.so.dbg': No such file or directory Error/Warning ids grouped by kconfigs: recent_errors |-- arm64-allnoconfig | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- arm64-defconfig | |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset | |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- arm64-randconfig-001-20250317 | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- arm64-randconfig-002-20250317 | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- arm64-randconfig-003-20250317 | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- arm64-randconfig-004-20250317 | |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset | |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- x86_64-allnoconfig | |-- drivers-iommu-sw64-sunway_iommu_v2.c:linux-pci.h-is-included-more-than-once. | |-- ld.lld:error:version-script-assignment-of-LINUX_2.-to-symbol-__vdso_sgx_enter_enclave-failed:symbol-not-defined | |-- llvm-objcopy:error:arch-x86-entry-vdso-vdso64.so.dbg:No-such-file-or-directory | |-- llvm-objdump:error:arch-x86-entry-vdso-vdso64.so.dbg:No-such-file-or-directory | |-- mm-page_alloc.c:linux-vmalloc.h-is-included-more-than-once. | |-- mm-page_alloc.c:warning:no-previous-prototype-for-function-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-function-__zone_set_pageset_high_and_batch |-- x86_64-allyesconfig | |-- arch-x86-kernel-fpu-core.c:warning:no-previous-prototype-for-function-get_fpu_registers_pos | |-- arch-x86-kernel-fpu-core.c:warning:no-previous-prototype-for-function-save_fpregs_to_fpkernelstate | |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset | |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset | |-- mm-page_alloc.c:warning:no-previous-prototype-for-function-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-function-__zone_set_pageset_high_and_batch |-- x86_64-buildonly-randconfig-001-20250317 | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- x86_64-buildonly-randconfig-002-20250317 | |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset | |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset | |-- mm-page_alloc.c:warning:no-previous-prototype-for-function-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-function-__zone_set_pageset_high_and_batch |-- x86_64-buildonly-randconfig-003-20250317 | |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset | |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- x86_64-buildonly-randconfig-004-20250317 | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- x86_64-buildonly-randconfig-005-20250317 | |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset | |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- x86_64-buildonly-randconfig-006-20250317 | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- x86_64-defconfig | |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset | |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch |-- x86_64-randconfig-121-20250318 | |-- mm-memcontrol.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-got-void-noderef-__user-buffer | |-- mm-page_alloc.c:sparse:sparse:symbol-__drain_all_pages-was-not-declared.-Should-it-be-static | |-- mm-page_alloc.c:sparse:sparse:symbol-__zone_set_pageset_high_and_batch-was-not-declared.-Should-it-be-static | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch | `-- mm-percpu.c:sparse:sparse:symbol-pcpu_free_slot-was-not-declared.-Should-it-be-static |-- x86_64-randconfig-122-20250318 | |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset | |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset | |-- block-blk-mq-sysfs.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-struct-blk_mq_hw_ctx-hctx-got-struct-blk_mq_hw_ctx-noderef-__rcu | |-- block-blk-mq.c:sparse:sparse:incompatible-types-in-comparison-expression-(different-address-spaces): | |-- block-blk-mq.c:sparse:sparse:incorrect-type-in-assignment-(different-address-spaces)-expected-struct-blk_mq_hw_ctx-hctx-got-struct-blk_mq_hw_ctx-noderef-__rcu | |-- block-blk-mq.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-blk_mq_hw_ctx-hctxs-got-struct-blk_mq_hw_ctx-noderef-__rcu-queue_hw_ctx | |-- include-linux-blk-mq.h:sparse:sparse:incompatible-types-in-comparison-expression-(different-address-spaces): | |-- mm-page_alloc.c:sparse:sparse:symbol-__drain_all_pages-was-not-declared.-Should-it-be-static | |-- mm-page_alloc.c:sparse:sparse:symbol-__zone_set_pageset_high_and_batch-was-not-declared.-Should-it-be-static | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch | `-- mm-percpu.c:sparse:sparse:symbol-pcpu_free_slot-was-not-declared.-Should-it-be-static |-- x86_64-randconfig-123-20250318 | |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset | |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset | |-- block-blk-mq.c:sparse:sparse:incompatible-types-in-comparison-expression-(different-address-spaces): | |-- include-linux-blk-mq.h:sparse:sparse:incompatible-types-in-comparison-expression-(different-address-spaces): | |-- ld.lld:error:version-script-assignment-of-LINUX_2.-to-symbol-__vdso_sgx_enter_enclave-failed:symbol-not-defined | |-- llvm-objcopy:error:arch-x86-entry-vdso-vdso64.so.dbg:No-such-file-or-directory | |-- llvm-objdump:error:arch-x86-entry-vdso-vdso64.so.dbg:No-such-file-or-directory | |-- mm-page_alloc.c:warning:no-previous-prototype-for-function-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-function-__zone_set_pageset_high_and_batch `-- x86_64-randconfig-161-20250318 |-- block-bio.c:warning:Excess-function-parameter-nr_iovecs-description-in-bio_alloc_bioset |-- block-bio.c:warning:Function-parameter-or-member-nr_iovecs_int-not-described-in-bio_alloc_bioset |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch elapsed time: 1447m configs tested: 16 configs skipped: 129 tested configs: arm64 allmodconfig clang-19 arm64 allnoconfig gcc-14.2.0 arm64 defconfig gcc-14.2.0 arm64 randconfig-001-20250317 gcc-14.2.0 arm64 randconfig-002-20250317 gcc-14.2.0 arm64 randconfig-003-20250317 gcc-14.2.0 arm64 randconfig-004-20250317 gcc-14.2.0 x86_64 allnoconfig clang-20 x86_64 allyesconfig clang-20 x86_64 buildonly-randconfig-001-20250317 gcc-12 x86_64 buildonly-randconfig-002-20250317 clang-20 x86_64 buildonly-randconfig-003-20250317 gcc-12 x86_64 buildonly-randconfig-004-20250317 gcc-12 x86_64 buildonly-randconfig-005-20250317 gcc-12 x86_64 buildonly-randconfig-006-20250317 gcc-12 x86_64 defconfig gcc-11 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 2815/2815] block/blk-mq.c:485:19: sparse: sparse: incorrect type in assignment (different address spaces)
by kernel test robot 18 Mar '25

18 Mar '25

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: a348aa0315d2a90cde93df922b84ab682459a834 commit: 8a6bee347626968d467aef07453c4547bc23cb64 [2815/2815] blk-mq: fix potential uaf for 'queue_hw_ctx' config: x86_64-randconfig-122-20250318 (https://download.01.org/0day-ci/archive/20250318/202503181406.E4pR441t-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250318/202503181406.E4pR441t-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202503181406.E4pR441t-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> block/blk-mq-sysfs.c:339:55: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct blk_mq_hw_ctx *hctx @@ got struct blk_mq_hw_ctx [noderef] __rcu * @@ block/blk-mq-sysfs.c:339:55: sparse: expected struct blk_mq_hw_ctx *hctx block/blk-mq-sysfs.c:339:55: sparse: got struct blk_mq_hw_ctx [noderef] __rcu * block/blk-mq-sysfs.c: note: in included file: include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** -- >> block/blk-mq.c:485:19: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct blk_mq_hw_ctx *hctx @@ got struct blk_mq_hw_ctx [noderef] __rcu * @@ block/blk-mq.c:485:19: sparse: expected struct blk_mq_hw_ctx *hctx block/blk-mq.c:485:19: sparse: got struct blk_mq_hw_ctx [noderef] __rcu * >> block/blk-mq.c:3270:41: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct blk_mq_hw_ctx **hctxs @@ got struct blk_mq_hw_ctx [noderef] __rcu **queue_hw_ctx @@ block/blk-mq.c:3270:41: sparse: expected struct blk_mq_hw_ctx **hctxs block/blk-mq.c:3270:41: sparse: got struct blk_mq_hw_ctx [noderef] __rcu **queue_hw_ctx block/blk-mq.c:3284:17: sparse: sparse: incompatible types in comparison expression (different address spaces): block/blk-mq.c:3284:17: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * block/blk-mq.c:3284:17: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** block/blk-mq.c:4033:14: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct blk_mq_hw_ctx *hctx @@ got struct blk_mq_hw_ctx [noderef] __rcu * @@ block/blk-mq.c: note: in included file: include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** include/linux/blk-mq.h:620:18: sparse: sparse: incompatible types in comparison expression (different address spaces): include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu *[noderef] __rcu * include/linux/blk-mq.h:620:18: sparse: struct blk_mq_hw_ctx [noderef] __rcu ** vim +485 block/blk-mq.c 320ae51feed5c2 Jens Axboe 2013-10-24 446 cd6ce1482fd9e6 Bart Van Assche 2017-06-20 447 struct request *blk_mq_alloc_request_hctx(struct request_queue *q, 9a95e4ef709533 Bart Van Assche 2017-11-09 448 unsigned int op, blk_mq_req_flags_t flags, unsigned int hctx_idx) 1f5bd336b91505 Ming Lin 2016-06-13 449 { e6e7abffe386b6 Christoph Hellwig 2020-05-29 450 struct blk_mq_alloc_data data = { e6e7abffe386b6 Christoph Hellwig 2020-05-29 451 .q = q, e6e7abffe386b6 Christoph Hellwig 2020-05-29 452 .flags = flags, e6e7abffe386b6 Christoph Hellwig 2020-05-29 453 .cmd_flags = op, e6e7abffe386b6 Christoph Hellwig 2020-05-29 454 }; 600c3b0cea784a Christoph Hellwig 2020-05-29 455 u64 alloc_time_ns = 0; 6d2809d51a5079 Omar Sandoval 2017-02-27 456 unsigned int cpu; 600c3b0cea784a Christoph Hellwig 2020-05-29 457 unsigned int tag; 1f5bd336b91505 Ming Lin 2016-06-13 458 int ret; 1f5bd336b91505 Ming Lin 2016-06-13 459 600c3b0cea784a Christoph Hellwig 2020-05-29 460 /* alloc_time includes depth and tag waits */ 600c3b0cea784a Christoph Hellwig 2020-05-29 461 if (blk_queue_rq_alloc_time(q)) 600c3b0cea784a Christoph Hellwig 2020-05-29 462 alloc_time_ns = ktime_get_ns(); 600c3b0cea784a Christoph Hellwig 2020-05-29 463 1f5bd336b91505 Ming Lin 2016-06-13 464 /* 1f5bd336b91505 Ming Lin 2016-06-13 465 * If the tag allocator sleeps we could get an allocation for a 1f5bd336b91505 Ming Lin 2016-06-13 466 * different hardware context. No need to complicate the low level 1f5bd336b91505 Ming Lin 2016-06-13 467 * allocator for this for the rare use case of a command tied to 1f5bd336b91505 Ming Lin 2016-06-13 468 * a specific queue. 1f5bd336b91505 Ming Lin 2016-06-13 469 */ 600c3b0cea784a Christoph Hellwig 2020-05-29 470 if (WARN_ON_ONCE(!(flags & (BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED)))) 1f5bd336b91505 Ming Lin 2016-06-13 471 return ERR_PTR(-EINVAL); 1f5bd336b91505 Ming Lin 2016-06-13 472 1f5bd336b91505 Ming Lin 2016-06-13 473 if (hctx_idx >= q->nr_hw_queues) 1f5bd336b91505 Ming Lin 2016-06-13 474 return ERR_PTR(-EIO); 1f5bd336b91505 Ming Lin 2016-06-13 475 3a0a529971ec4e Bart Van Assche 2017-11-09 476 ret = blk_queue_enter(q, flags); 1f5bd336b91505 Ming Lin 2016-06-13 477 if (ret) 1f5bd336b91505 Ming Lin 2016-06-13 478 return ERR_PTR(ret); 1f5bd336b91505 Ming Lin 2016-06-13 479 c8712c6a674e33 Christoph Hellwig 2016-09-23 480 /* c8712c6a674e33 Christoph Hellwig 2016-09-23 481 * Check if the hardware context is actually mapped to anything. c8712c6a674e33 Christoph Hellwig 2016-09-23 482 * If not tell the caller that it should skip this queue. c8712c6a674e33 Christoph Hellwig 2016-09-23 483 */ a5ea5811058ddb Christoph Hellwig 2020-05-16 484 ret = -EXDEV; e6e7abffe386b6 Christoph Hellwig 2020-05-29 @485 data.hctx = q->queue_hw_ctx[hctx_idx]; e6e7abffe386b6 Christoph Hellwig 2020-05-29 486 if (!blk_mq_hw_queue_mapped(data.hctx)) a5ea5811058ddb Christoph Hellwig 2020-05-16 487 goto out_queue_exit; e6e7abffe386b6 Christoph Hellwig 2020-05-29 488 cpu = cpumask_first_and(data.hctx->cpumask, cpu_online_mask); e6e7abffe386b6 Christoph Hellwig 2020-05-29 489 data.ctx = __blk_mq_get_ctx(q, cpu); 1f5bd336b91505 Ming Lin 2016-06-13 490 42fdc5e49c2be9 Christoph Hellwig 2020-06-29 491 if (!q->elevator) 600c3b0cea784a Christoph Hellwig 2020-05-29 492 blk_mq_tag_busy(data.hctx); 600c3b0cea784a Christoph Hellwig 2020-05-29 493 a5ea5811058ddb Christoph Hellwig 2020-05-16 494 ret = -EWOULDBLOCK; 600c3b0cea784a Christoph Hellwig 2020-05-29 495 tag = blk_mq_get_tag(&data); 600c3b0cea784a Christoph Hellwig 2020-05-29 496 if (tag == BLK_MQ_NO_TAG) a5ea5811058ddb Christoph Hellwig 2020-05-16 497 goto out_queue_exit; 600c3b0cea784a Christoph Hellwig 2020-05-29 498 return blk_mq_rq_ctx_init(&data, tag, alloc_time_ns); 600c3b0cea784a Christoph Hellwig 2020-05-29 499 a5ea5811058ddb Christoph Hellwig 2020-05-16 500 out_queue_exit: a5ea5811058ddb Christoph Hellwig 2020-05-16 501 blk_queue_exit(q); a5ea5811058ddb Christoph Hellwig 2020-05-16 502 return ERR_PTR(ret); 1f5bd336b91505 Ming Lin 2016-06-13 503 } 1f5bd336b91505 Ming Lin 2016-06-13 504 EXPORT_SYMBOL_GPL(blk_mq_alloc_request_hctx); 1f5bd336b91505 Ming Lin 2016-06-13 505 :::::: The code at line 485 was first introduced by commit :::::: e6e7abffe386b614a194ec32457a00c304c980f4 blk-mq: simplify the blk_mq_get_request calling convention :::::: TO: Christoph Hellwig <hch(a)lst.de> :::::: CC: Jens Axboe <axboe(a)kernel.dk> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH openEuler-1.0-LTS] ubi: ubi_create_volume: Fix use-after-free when volume creation failed
by Wang Zhaolong 18 Mar '25

18 Mar '25

From: Zhihao Cheng <chengzhihao1(a)huawei.com> stable inclusion from stable-v4.19.247 commit abb67043060f2bf4c03d7c3debb9ae980e2b6db3 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBP1CU CVE: CVE-2022-49388 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 8c03a1c21d72210f81cb369cc528e3fde4b45411 ] There is an use-after-free problem for 'eba_tbl' in ubi_create_volume()'s error handling path: ubi_eba_replace_table(vol, eba_tbl) vol->eba_tbl = tbl out_mapping: ubi_eba_destroy_table(eba_tbl) // Free 'eba_tbl' out_unlock: put_device(&vol->dev) vol_release kfree(tbl->entries) // UAF Fix it by removing redundant 'eba_tbl' releasing. Fetch a reproducer in [Link]. Fixes: 493cfaeaa0c9b ("mtd: utilize new cdev_device_add helper function") Link: https://bugzilla.kernel.org/show_bug.cgi?id=215965 Signed-off-by: Zhihao Cheng <chengzhihao1(a)huawei.com> Signed-off-by: Richard Weinberger <richard(a)nod.at> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Wang Zhaolong <wangzhaolong1(a)huawei.com> --- drivers/mtd/ubi/vmt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c index 729588b94e41..f2fe6cdf8cd9 100644 --- a/drivers/mtd/ubi/vmt.c +++ b/drivers/mtd/ubi/vmt.c @@ -326,11 +326,10 @@ int ubi_create_volume(struct ubi_device *ubi, struct ubi_mkvol_req *req) out_mapping: spin_lock(&ubi->volumes_lock); ubi->volumes[vol_id] = NULL; ubi->vol_count -= 1; spin_unlock(&ubi->volumes_lock); - ubi_eba_destroy_table(eba_tbl); out_acc: spin_lock(&ubi->volumes_lock); ubi->rsvd_pebs -= vol->reserved_pebs; ubi->avail_pebs += vol->reserved_pebs; out_unlock: -- 2.39.2

2 1

[PATCH OLK-6.6] arm64_mpam: Add prefetch option
by Zeng Heng 17 Mar '25

17 Mar '25

Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- arch/arm64/include/asm/mpam.h | 15 ++++++ arch/arm64/include/asm/thread_info.h | 1 + fs/resctrl/internal.h | 1 + fs/resctrl/rdtgroup.c | 78 ++++++++++++++++++++++++++++ 4 files changed, 95 insertions(+) diff --git a/arch/arm64/include/asm/mpam.h b/arch/arm64/include/asm/mpam.h index 9abe1fe58c34..f2fc1cf99fb6 100644 --- a/arch/arm64/include/asm/mpam.h +++ b/arch/arm64/include/asm/mpam.h @@ -143,16 +143,31 @@ static inline void resctrl_arch_set_rmid(struct task_struct *tsk, u32 rmid) #endif } +#define setbit(x,y) x |= (1<<y) +#define clrbit(x,y) x &= ~(1<<y) + static inline void mpam_thread_switch(struct task_struct *tsk) { u64 oldregval; int cpu = smp_processor_id(); u64 regval = mpam_get_regval(tsk); + u64 val, val1; if (!IS_ENABLED(CONFIG_ARM64_MPAM) || !static_branch_likely(&mpam_enabled)) return; + asm volatile("mrs %0, S3_1_c15_c6_4" : "=r" (val)); + val1 = val; + + if (task_thread_info(tsk)->prefetch_dis) + setbit(val1, 0); + else + clrbit(val1, 0); + + if (val1 != val) + asm volatile("msr S3_1_c15_c6_4, %0" : : "r"(val1)); + if (regval == READ_ONCE(mpam_resctrl_default_group)) regval = READ_ONCE(per_cpu(arm64_mpam_default, cpu)); diff --git a/arch/arm64/include/asm/thread_info.h b/arch/arm64/include/asm/thread_info.h index 379d24059f5b..00cd142bc8fa 100644 --- a/arch/arm64/include/asm/thread_info.h +++ b/arch/arm64/include/asm/thread_info.h @@ -45,6 +45,7 @@ struct thread_info { #endif #ifdef CONFIG_ARM64_MPAM u64 mpam_partid_pmg; + u32 prefetch_dis; #endif u32 cpu; diff --git a/fs/resctrl/internal.h b/fs/resctrl/internal.h index fb620beba958..fbc76efa06d9 100644 --- a/fs/resctrl/internal.h +++ b/fs/resctrl/internal.h @@ -173,6 +173,7 @@ struct rdtgroup { struct mongroup mon; enum rdtgrp_mode mode; struct pseudo_lock_region *plr; + u32 prefetch_dis; }; /* List of all resource groups */ diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c index 3f1bb36482e0..af868b8f0539 100644 --- a/fs/resctrl/rdtgroup.c +++ b/fs/resctrl/rdtgroup.c @@ -822,6 +822,76 @@ static int rdtgroup_tasks_show(struct kernfs_open_file *of, return ret; } +static void update_prefetch_tasks(struct rdtgroup *r, u32 prefetch_dis) +{ + struct task_struct *p, *t; + + rcu_read_lock(); + + for_each_process_thread(p, t) { + if (is_closid_match(t, r) || is_rmid_match(t, r)) + WRITE_ONCE(task_thread_info(t)->prefetch_dis, prefetch_dis); + } + + rcu_read_unlock(); + + smp_mb(); +} + +static ssize_t rdtgroup_prefetch_write(struct kernfs_open_file *of, + char *buf, size_t nbytes, loff_t off) +{ + struct rdtgroup *rdtgrp; + int ret = 0; + u32 prefetch_dis; + + rdtgrp = rdtgroup_kn_lock_live(of->kn); + if (!rdtgrp) { + rdtgroup_kn_unlock(of->kn); + return -ENOENT; + } + rdt_last_cmd_clear(); + + if (rdtgrp->mode == RDT_MODE_PSEUDO_LOCKED || + rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP) { + ret = -EINVAL; + rdt_last_cmd_puts("Pseudo-locking in progress\n"); + goto unlock; + } + + if (kstrtou32(buf, 0, &prefetch_dis)) { + rdt_last_cmd_printf("Task list parsing error prefetch %s\n", buf); + ret = -EINVAL; + goto unlock; + } + + if (rdtgrp->prefetch_dis != prefetch_dis) { + rdtgrp->prefetch_dis = prefetch_dis; + update_prefetch_tasks(rdtgrp, prefetch_dis); + } + +unlock: + rdtgroup_kn_unlock(of->kn); + + return ret ?: nbytes; +} + +static int rdtgroup_prefetch_show(struct kernfs_open_file *of, + struct seq_file *s, void *v) +{ + struct rdtgroup *rdtgrp; + int ret = 0; + + rdtgrp = rdtgroup_kn_lock_live(of->kn); + if (rdtgrp) + seq_printf(s, "%u\n", rdtgrp->prefetch_dis); + else + ret = -ENOENT; + rdtgroup_kn_unlock(of->kn); + + return ret; +} + static int rdtgroup_closid_show(struct kernfs_open_file *of, struct seq_file *s, void *v) { @@ -1891,6 +1961,14 @@ static struct rftype res_common_files[] = { .seq_show = rdtgroup_tasks_show, .fflags = RFTYPE_BASE, }, + { + .name = "prefetch_dis", + .mode = 0644, + .kf_ops = &rdtgroup_kf_single_ops, + .write = rdtgroup_prefetch_write, + .seq_show = rdtgroup_prefetch_show, + .fflags = RFTYPE_BASE, + }, { .name = "mon_hw_id", .mode = 0444, -- 2.25.1

2 1

[openeuler:openEuler-1.0-LTS 1497/1497] kernel/sched/.tmp_debug.o: warning: objtool: missing symbol for section .text.unlikely
by kernel test robot 17 Mar '25

17 Mar '25

Hi Qiang, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: a91497a471caf8cc4af64a68492be62ec9568f7e commit: acfa0f545c7dd43f959c28e8ab4b139c927ba387 [1497/1497] svm: reduce log of run queue and atomic->atomic64 config: x86_64-buildonly-randconfig-005-20250317 (https://download.01.org/0day-ci/archive/20250317/202503171950.PEaY4TuS-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250317/202503171950.PEaY4TuS-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202503171950.PEaY4TuS-lkp@intel.com/ All warnings (new ones prefixed by >>): kernel/sched/debug.c:797:6: warning: no previous prototype for 'sysrq_sched_debug_tidy' [-Wmissing-prototypes] 797 | void sysrq_sched_debug_tidy(void) | ^~~~~~~~~~~~~~~~~~~~~~ >> kernel/sched/.tmp_debug.o: warning: objtool: missing symbol for section .text.unlikely -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0