- Kernel - mailweb.openeuler.org

[PATCH openEuler-1.0-LTS] smb: client: fix NULL deref in asn1_ber_decoder()
by ZhaoLong Wang 29 Jan '24

29 Jan '24

From: Paulo Alcantara <pc(a)manguebit.com> stable inclusion from stable-v4.19.304 commit 832c20fc4cc82c497566db35996ea488661fc764 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZPJF CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 90d025c2e953c11974e76637977c473200593a46 ] If server replied SMB2_NEGOTIATE with a zero SecurityBufferOffset, smb2_get_data_area() sets @len to non-zero but return NULL, so decode_negTokeninit() ends up being called with a NULL @security_blob: BUG: kernel NULL pointer dereference, address: 0000000000000000 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 2 PID: 871 Comm: mount.cifs Not tainted 6.7.0-rc4 #2 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.2-3-gd478f380-rebuilt.opensuse.org 04/01/2014 RIP: 0010:asn1_ber_decoder+0x173/0xc80 Code: 01 4c 39 2c 24 75 09 45 84 c9 0f 85 2f 03 00 00 48 8b 14 24 4c 29 ea 48 83 fa 01 0f 86 1e 07 00 00 48 8b 74 24 28 4d 8d 5d 01 <42> 0f b6 3c 2e 89 fa 40 88 7c 24 5c f7 d2 83 e2 1f 0f 84 3d 07 00 RSP: 0018:ffffc9000063f950 EFLAGS: 00010202 RAX: 0000000000000002 RBX: 0000000000000000 RCX: 000000000000004a RDX: 000000000000004a RSI: 0000000000000000 RDI: 0000000000000000 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000002 R11: 0000000000000001 R12: 0000000000000000 R13: 0000000000000000 R14: 000000000000004d R15: 0000000000000000 FS: 00007fce52b0fbc0(0000) GS:ffff88806ba00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000000 CR3: 000000001ae64000 CR4: 0000000000750ef0 PKRU: 55555554 Call Trace: <TASK> ? __die+0x23/0x70 ? page_fault_oops+0x181/0x480 ? __stack_depot_save+0x1e6/0x480 ? exc_page_fault+0x6f/0x1c0 ? asm_exc_page_fault+0x26/0x30 ? asn1_ber_decoder+0x173/0xc80 ? check_object+0x40/0x340 decode_negTokenInit+0x1e/0x30 [cifs] SMB2_negotiate+0xc99/0x17c0 [cifs] ? smb2_negotiate+0x46/0x60 [cifs] ? srso_alias_return_thunk+0x5/0xfbef5 smb2_negotiate+0x46/0x60 [cifs] cifs_negotiate_protocol+0xae/0x130 [cifs] cifs_get_smb_ses+0x517/0x1040 [cifs] ? srso_alias_return_thunk+0x5/0xfbef5 ? srso_alias_return_thunk+0x5/0xfbef5 ? queue_delayed_work_on+0x5d/0x90 cifs_mount_get_session+0x78/0x200 [cifs] dfs_mount_share+0x13a/0x9f0 [cifs] ? srso_alias_return_thunk+0x5/0xfbef5 ? lock_acquire+0xbf/0x2b0 ? find_nls+0x16/0x80 ? srso_alias_return_thunk+0x5/0xfbef5 cifs_mount+0x7e/0x350 [cifs] cifs_smb3_do_mount+0x128/0x780 [cifs] smb3_get_tree+0xd9/0x290 [cifs] vfs_get_tree+0x2c/0x100 ? capable+0x37/0x70 path_mount+0x2d7/0xb80 ? srso_alias_return_thunk+0x5/0xfbef5 ? _raw_spin_unlock_irqrestore+0x44/0x60 __x64_sys_mount+0x11a/0x150 do_syscall_64+0x47/0xf0 entry_SYSCALL_64_after_hwframe+0x6f/0x77 RIP: 0033:0x7fce52c2ab1e Fix this by setting @len to zero when @off == 0 so callers won't attempt to dereference non-existing data areas. Reported-by: Robert Morris <rtm(a)csail.mit.edu> Cc: stable(a)vger.kernel.org Signed-off-by: Paulo Alcantara (SUSE) <pc(a)manguebit.com> Signed-off-by: Steve French <stfrench(a)microsoft.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: ZhaoLong Wang <wangzhaolong1(a)huawei.com> --- fs/cifs/smb2misc.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c index 94fb82077bdd..6ac33ec15583 100644 --- a/fs/cifs/smb2misc.c +++ b/fs/cifs/smb2misc.c @@ -302,6 +302,9 @@ static const bool has_smb2_data_area[NUMBER_OF_SMB2_COMMANDS] = { char * smb2_get_data_area_len(int *off, int *len, struct smb2_sync_hdr *shdr) { + const int max_off = 4096; + const int max_len = 128 * 1024; + *off = 0; *len = 0; @@ -369,29 +372,20 @@ smb2_get_data_area_len(int *off, int *len, struct smb2_sync_hdr *shdr) * Invalid length or offset probably means data area is invalid, but * we have little choice but to ignore the data area in this case. */ - if (*off > 4096) { - cifs_dbg(VFS, "offset %d too large, data area ignored\n", *off); - *len = 0; - *off = 0; - } else if (*off < 0) { - cifs_dbg(VFS, "negative offset %d to data invalid ignore data area\n", - *off); + if (unlikely(*off < 0 || *off > max_off || + *len < 0 || *len > max_len)) { + cifs_dbg(VFS, "%s: invalid data area (off=%d len=%d)\n", + __func__, *off, *len); *off = 0; *len = 0; - } else if (*len < 0) { - cifs_dbg(VFS, "negative data length %d invalid, data area ignored\n", - *len); - *len = 0; - } else if (*len > 128 * 1024) { - cifs_dbg(VFS, "data area larger than 128K: %d\n", *len); + } else if (*off == 0) { *len = 0; } /* return pointer to beginning of data area, ie offset from SMB start */ - if ((*off != 0) && (*len != 0)) + if (*off > 0 && *len > 0) return (char *)shdr + *off; - else - return NULL; + return NULL; } /* -- 2.39.2

2 1

[PATCH OLK-6.6 0/2] Expose swapcache stat for memcg v1
by Liu Shixin 29 Jan '24

29 Jan '24

The first patch expose swapcache stat for memcg v1, the second patch remote unused do_memsw_account() in memcg1_stat_format(). Liu Shixin (2): memcg: expose swapcache stat for memcg v1 memcg: remove unused do_memsw_account in memcg1_stat_format Documentation/admin-guide/cgroup-v1/memory.rst | 1 + mm/memcontrol.c | 15 ++++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) -- 2.25.1

1 2

[PATCH V2 OLK-6.6 0/5] Add support for ecmdq
by Zhang Zekun 29 Jan '24

29 Jan '24

Add support for ecmdq v2: fix some code check errors Zhen Lei (5): iommu/arm-smmu-v3: Add support for ECMDQ register mode iommu/arm-smmu-v3: Ensure that a set of associated commands are inserted in the same ECMDQ iommu/arm-smmu-v3: Add arm_smmu_ecmdq_issue_cmdlist() for non-shared ECMDQ iommu/arm-smmu-v3: Add support for less than one ECMDQ per core iommu/arm-smmu-v3: Allow disabling ECMDQs at boot time drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 434 +++++++++++++++++++- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 39 ++ 2 files changed, 465 insertions(+), 8 deletions(-) -- 2.17.1

2 6

[PATCH OLK-6.6 0/4] misc for fd
by Chen Ridong 29 Jan '24

29 Jan '24

Chen Ridong (4): filescgroup: remove files of dfl_cftypes. filecgroup: move code of filescontrol.c to files-cgroup.c misc: add a type of resource to control fd. filscgroup: fix null pointer access when files_cgroup is not inited. Documentation/admin-guide/cgroup-v2.rst | 7 + fs/Makefile | 2 + fs/file.c | 16 +- fs/files-cgroup.c | 335 +++++++++++++++++++++++ fs/filescontrol.c | 344 +++--------------------- fs/misc-fd.c | 77 ++++++ include/linux/fdtable.h | 3 + include/linux/files-cgroup.h | 32 +++ include/linux/filescontrol.h | 46 ++-- include/linux/misc-fd.h | 21 ++ include/linux/misc_cgroup.h | 4 + kernel/cgroup/misc.c | 4 + 12 files changed, 556 insertions(+), 335 deletions(-) create mode 100644 fs/files-cgroup.c create mode 100644 fs/misc-fd.c create mode 100644 include/linux/files-cgroup.h create mode 100644 include/linux/misc-fd.h -- 2.34.1

1 4

[PATCH V2 PATCH 0/5] Add support for ecmdq
by Zhang Zekun 29 Jan '24

29 Jan '24

Add support for ecmdq v2: fix some code check errors Zhen Lei (5): iommu/arm-smmu-v3: Add support for ECMDQ register mode iommu/arm-smmu-v3: Ensure that a set of associated commands are inserted in the same ECMDQ iommu/arm-smmu-v3: Add arm_smmu_ecmdq_issue_cmdlist() for non-shared ECMDQ iommu/arm-smmu-v3: Add support for less than one ECMDQ per core iommu/arm-smmu-v3: Allow disabling ECMDQs at boot time drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 434 +++++++++++++++++++- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 39 ++ 2 files changed, 465 insertions(+), 8 deletions(-) -- 2.17.1

1 5

[PATCH OLK-6.6 00/20] kabi reserve patches
by Lin Yujun 29 Jan '24

29 Jan '24

*** BLURB HERE *** Chen Jiahao (1): KABI: reserve space for struct input_dev Lin Ruizhe (5): msi: Add kabi_reserve in msi.h interrupt: Add kabi_reserve in interrupt.h irq: Add kabi_reserve in irq irq_desc: Add kabi_reserve in irq_desc irqdomain: Add kabi_reserve in irqdomain Lin Yujun (13): drm: drm_atomic.h: Add kabi_reserve drm: drm_client.h: Add kabi_reserve drm: drm_connector.h: Add kabi_reserve drm: drm_crtc.h: Add kabi_reserve drm: drm_device.h: Add kabi_reserve drm: drm_drv.h: Add kabi_reserve drm: drm_fb_helper.h: Add kabi_reserve drm: drm_file.h: Add kabi_reserve drm: drm_fourcc.h: Add kabi_reserve drm: drm_gem.h: Add kabi_reserve pm: pm_domain.h: Add kabi_reserve pm: pm.h: Add kabi_reserve energy_model: Add kabi_reserve Yang Yingliang (1): kabi: reserve space for struct cpu_stop_work include/drm/drm_atomic.h | 6 ++++++ include/drm/drm_client.h | 7 +++++++ include/drm/drm_connector.h | 18 ++++++++++++++++++ include/drm/drm_crtc.h | 7 +++++++ include/drm/drm_device.h | 4 ++++ include/drm/drm_drv.h | 5 +++++ include/drm/drm_fb_helper.h | 8 ++++++++ include/drm/drm_file.h | 8 ++++++++ include/drm/drm_fourcc.h | 5 +++++ include/drm/drm_gem.h | 8 ++++++++ include/linux/energy_model.h | 5 +++++ include/linux/input.h | 4 ++++ include/linux/interrupt.h | 6 ++++++ include/linux/irq.h | 8 ++++++++ include/linux/irqdesc.h | 4 +++- include/linux/irqdomain.h | 3 +++ include/linux/msi.h | 7 +++++++ include/linux/pm.h | 11 +++++++++++ include/linux/pm_domain.h | 6 ++++++ include/linux/stop_machine.h | 3 +++ 20 files changed, 132 insertions(+), 1 deletion(-) -- 2.34.1

2 21

[PATCH OLK-6.6 v2] fs:/dcache.c: fix negative dentry limit not complete problem
by Long Li 29 Jan '24

29 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8JH5M CVE: NA -------------------------------- Restrictions of negative dentry can avoid softlock when too many dentry in memory, but restrictions before do not always take effect. For example, removing files which has been created would not enter retain_dentry(), because the dentry of file maybe has been added to lru list of superblock, it caused that fast_dput() reutrn true in last dput(). So, add restriction logic for the file which has been added to the lru list in fast_dput(), it prevents the negative dentry exceeding the limit when deleting existing file. Factor out negative dentry limit logic into limit_negative_dentry(), make the code more clean. Fixes: f3de89fc28ba ("fs/dcache.c: avoid softlock since too many negative dentry") Signed-off-by: Long Li <leo.lilong(a)huawei.com> --- fs/dcache.c | 70 ++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 48 insertions(+), 22 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index c27aa8ff78f4..ab5f8e954978 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -675,10 +675,36 @@ static inline struct dentry *lock_parent(struct dentry *dentry) return __lock_parent(dentry); } -static inline bool retain_dentry(struct dentry *dentry) +/* + * Return true if dentry is negative and exceed negative dentry limit. + */ +static inline bool limit_negative_dentry(struct dentry *dentry) { struct dentry *parent; + parent = dentry->d_parent; + if (unlikely(!parent)) + return false; + + WARN_ON((atomic_read(&parent->d_neg_dnum) < 0)); + if (!dentry->d_inode) { + if (!(dentry->d_flags & DCACHE_NEGATIVE_ACCOUNT)) { + unsigned int flags = READ_ONCE(dentry->d_flags); + + flags |= DCACHE_NEGATIVE_ACCOUNT; + WRITE_ONCE(dentry->d_flags, flags); + atomic_inc(&parent->d_neg_dnum); + } + + if (atomic_read(&parent->d_neg_dnum) >= NEG_DENTRY_LIMIT) + return true; + } + + return false; +} + +static inline bool retain_dentry(struct dentry *dentry) +{ WARN_ON(d_in_lookup(dentry)); /* Unreachable? Get rid of it */ @@ -696,27 +722,9 @@ static inline bool retain_dentry(struct dentry *dentry) if (unlikely(dentry->d_flags & DCACHE_DONTCACHE)) return false; - if (unlikely(!dentry->d_parent)) - goto noparent; - - parent = dentry->d_parent; - /* Return false if it's negative */ - WARN_ON((atomic_read(&parent->d_neg_dnum) < 0)); - if (!dentry->d_inode) { - if (!(dentry->d_flags & DCACHE_NEGATIVE_ACCOUNT)) { - unsigned int flags = READ_ONCE(dentry->d_flags); - - flags |= DCACHE_NEGATIVE_ACCOUNT; - WRITE_ONCE(dentry->d_flags, flags); - atomic_inc(&parent->d_neg_dnum); - } - } - - if (!dentry->d_inode && - atomic_read(&parent->d_neg_dnum) >= NEG_DENTRY_LIMIT) + if (unlikely(limit_negative_dentry(dentry))) return false; -noparent: /* retain; LRU fodder */ dentry->d_lockref.count--; if (unlikely(!(dentry->d_flags & DCACHE_LRU_LIST))) @@ -872,8 +880,25 @@ static inline bool fast_dput(struct dentry *dentry) DCACHE_DISCONNECTED | DCACHE_DONTCACHE; /* Nothing to do? Dropping the reference was all we needed? */ - if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry)) - return true; + if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry)) { + /* + * If the dentry is not negative dentry, return true directly, + * avoid holding dentry lock in the fast put path. + */ + if (dentry->d_inode) + return true; + /* + * If dentry is negative and need to be limitted, it maybe need + * to be killed, so shouldn't fast put and retain in memory. + */ + spin_lock(&dentry->d_lock); + if (likely(!limit_negative_dentry(dentry))) { + spin_unlock(&dentry->d_lock); + return true; + } + + goto dentry_locked; + } /* * Not the fast normal case? Get the lock. We've already decremented @@ -882,6 +907,7 @@ static inline bool fast_dput(struct dentry *dentry) */ spin_lock(&dentry->d_lock); +dentry_locked: /* * Did somebody else grab a reference to it in the meantime, and * we're no longer the last user after all? Alternatively, somebody -- 2.31.1

1 0

[PATCH OLK-5.10] net/rds: Fix UBSAN: array-index-out-of-bounds in rds_cmsg_recv
by Dong Chenchen 29 Jan '24

29 Jan '24

From: Sharath Srinivasan <sharath.srinivasan(a)oracle.com> mainline inclusion from mainline-v6.7 commit 13e788deb7348cc88df34bed736c3b3b9927ea52 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YC9I CVE: CVE-2024-23849 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- Syzcaller UBSAN crash occurs in rds_cmsg_recv(), which reads inc->i_rx_lat_trace[j + 1] with index 4 (3 + 1), but with array size of 4 (RDS_RX_MAX_TRACES). Here 'j' is assigned from rs->rs_rx_trace[i] and in-turn from trace.rx_trace_pos[i] in rds_recv_track_latency(), with both arrays sized 3 (RDS_MSG_RX_DGRAM_TRACE_MAX). So fix the off-by-one bounds check in rds_recv_track_latency() to prevent a potential crash in rds_cmsg_recv(). Found by syzcaller: ================================================================= UBSAN: array-index-out-of-bounds in net/rds/recv.c:585:39 index 4 is out of range for type 'u64 [4]' CPU: 1 PID: 8058 Comm: syz-executor228 Not tainted 6.6.0-gd2f51b3516da #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x136/0x150 lib/dump_stack.c:106 ubsan_epilogue lib/ubsan.c:217 [inline] __ubsan_handle_out_of_bounds+0xd5/0x130 lib/ubsan.c:348 rds_cmsg_recv+0x60d/0x700 net/rds/recv.c:585 rds_recvmsg+0x3fb/0x1610 net/rds/recv.c:716 sock_recvmsg_nosec net/socket.c:1044 [inline] sock_recvmsg+0xe2/0x160 net/socket.c:1066 __sys_recvfrom+0x1b6/0x2f0 net/socket.c:2246 __do_sys_recvfrom net/socket.c:2264 [inline] __se_sys_recvfrom net/socket.c:2260 [inline] __x64_sys_recvfrom+0xe0/0x1b0 net/socket.c:2260 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b ================================================================== Fixes: 3289025aedc0 ("RDS: add receive message trace used by application") Reported-by: Chenyuan Yang <chenyuan0y(a)gmail.com> Closes: https://lore.kernel.org/linux-rdma/CALGdzuoVdq-wtQ4Az9iottBqC5cv9ZhcE5q8N7L… Signed-off-by: Sharath Srinivasan <sharath.srinivasan(a)oracle.com> Reviewed-by: Simon Horman <horms(a)kernel.org> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Dong Chenchen <dongchenchen2(a)huawei.com> --- net/rds/af_rds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/af_rds.c b/net/rds/af_rds.c index b239120dd9ca..0ec0ae148349 100644 --- a/net/rds/af_rds.c +++ b/net/rds/af_rds.c @@ -419,7 +419,7 @@ static int rds_recv_track_latency(struct rds_sock *rs, sockptr_t optval, rs->rs_rx_traces = trace.rx_traces; for (i = 0; i < rs->rs_rx_traces; i++) { - if (trace.rx_trace_pos[i] > RDS_MSG_RX_DGRAM_TRACE_MAX) { + if (trace.rx_trace_pos[i] >= RDS_MSG_RX_DGRAM_TRACE_MAX) { rs->rs_rx_traces = 0; return -EFAULT; } -- 2.25.1

2 1

[PATCH openEuler-22.03-LTS] fs:/dcache.c: fix negative dentry limit not complete problem
by Long Li 29 Jan '24

29 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8WPQW CVE: NA -------------------------------- Restrictions of negative dentry can avoid softlock when too many dentry in memory, but restrictions before do not always take effect. For example, removing files which has been created would not enter retain_dentry(), because the dentry of file maybe has been added to lru list of superblock, it caused that fast_dput() reutrn true in last dput(). So, add restriction logic for the file which has been added to the lru list in fast_dput(), it prevents the negative dentry exceeding the limit when deleting existing file. Factor out negative dentry limit logic into limit_negative_dentry(), make the code more clean. Fixes: c44e1f780873 ("fs/dcache.c: avoid softlock since too many negative dentry") Signed-off-by: Long Li <leo.lilong(a)huawei.com> --- fs/dcache.c | 70 ++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 48 insertions(+), 22 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index f5b78cc80a00..3cf6fadd5550 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -647,10 +647,36 @@ static inline struct dentry *lock_parent(struct dentry *dentry) return __lock_parent(dentry); } -static inline bool retain_dentry(struct dentry *dentry) +/* + * Return true if dentry is negative and exceed negative dentry limit. + */ +static inline bool limit_negative_dentry(struct dentry *dentry) { struct dentry *parent; + parent = dentry->d_parent; + if (unlikely(!parent)) + return false; + + WARN_ON((atomic_read(&parent->d_neg_dnum) < 0)); + if (!dentry->d_inode) { + if (!(dentry->d_flags & DCACHE_NEGATIVE_ACCOUNT)) { + unsigned int flags = READ_ONCE(dentry->d_flags); + + flags |= DCACHE_NEGATIVE_ACCOUNT; + WRITE_ONCE(dentry->d_flags, flags); + atomic_inc(&parent->d_neg_dnum); + } + + if (atomic_read(&parent->d_neg_dnum) >= NEG_DENTRY_LIMIT) + return true; + } + + return false; +} + +static inline bool retain_dentry(struct dentry *dentry) +{ WARN_ON(d_in_lookup(dentry)); /* Unreachable? Get rid of it */ @@ -668,27 +694,9 @@ static inline bool retain_dentry(struct dentry *dentry) if (unlikely(dentry->d_flags & DCACHE_DONTCACHE)) return false; - if (unlikely(!dentry->d_parent)) - goto noparent; - - parent = dentry->d_parent; - /* Return false if it's negative */ - WARN_ON((atomic_read(&parent->d_neg_dnum) < 0)); - if (!dentry->d_inode) { - if (!(dentry->d_flags & DCACHE_NEGATIVE_ACCOUNT)) { - unsigned int flags = READ_ONCE(dentry->d_flags); - - flags |= DCACHE_NEGATIVE_ACCOUNT; - WRITE_ONCE(dentry->d_flags, flags); - atomic_inc(&parent->d_neg_dnum); - } - } - - if (!dentry->d_inode && - atomic_read(&parent->d_neg_dnum) >= NEG_DENTRY_LIMIT) + if (unlikely(limit_negative_dentry(dentry))) return false; -noparent: /* retain; LRU fodder */ dentry->d_lockref.count--; if (unlikely(!(dentry->d_flags & DCACHE_LRU_LIST))) @@ -837,8 +845,25 @@ static inline bool fast_dput(struct dentry *dentry) d_flags &= DCACHE_REFERENCED | DCACHE_LRU_LIST | DCACHE_DISCONNECTED; /* Nothing to do? Dropping the reference was all we needed? */ - if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry)) - return true; + if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry)) { + /* + * If the dentry is not negative dentry, return true directly, + * avoid holding dentry lock in the fast put path. + */ + if (dentry->d_inode) + return true; + /* + * If dentry is negative and need to be limitted, it maybe need + * to be killed, so shouldn't fast put and retain in memory. + */ + spin_lock(&dentry->d_lock); + if (likely(!limit_negative_dentry(dentry))) { + spin_unlock(&dentry->d_lock); + return true; + } + + goto dentry_locked; + } /* * Not the fast normal case? Get the lock. We've already decremented @@ -847,6 +872,7 @@ static inline bool fast_dput(struct dentry *dentry) */ spin_lock(&dentry->d_lock); +dentry_locked: /* * Did somebody else grab a reference to it in the meantime, and * we're no longer the last user after all? Alternatively, somebody -- 2.31.1

1 0

[PATCH openEuler-1.0-LTS] net/rds: Fix UBSAN: array-index-out-of-bounds in rds_cmsg_recv
by Dong Chenchen 29 Jan '24

29 Jan '24

From: Sharath Srinivasan <sharath.srinivasan(a)oracle.com> mainline inclusion from mainline-v6.7 commit 13e788deb7348cc88df34bed736c3b3b9927ea52 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YC9I CVE: CVE-2024-23849 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- Syzcaller UBSAN crash occurs in rds_cmsg_recv(), which reads inc->i_rx_lat_trace[j + 1] with index 4 (3 + 1), but with array size of 4 (RDS_RX_MAX_TRACES). Here 'j' is assigned from rs->rs_rx_trace[i] and in-turn from trace.rx_trace_pos[i] in rds_recv_track_latency(), with both arrays sized 3 (RDS_MSG_RX_DGRAM_TRACE_MAX). So fix the off-by-one bounds check in rds_recv_track_latency() to prevent a potential crash in rds_cmsg_recv(). Found by syzcaller: ================================================================= UBSAN: array-index-out-of-bounds in net/rds/recv.c:585:39 index 4 is out of range for type 'u64 [4]' CPU: 1 PID: 8058 Comm: syz-executor228 Not tainted 6.6.0-gd2f51b3516da #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x136/0x150 lib/dump_stack.c:106 ubsan_epilogue lib/ubsan.c:217 [inline] __ubsan_handle_out_of_bounds+0xd5/0x130 lib/ubsan.c:348 rds_cmsg_recv+0x60d/0x700 net/rds/recv.c:585 rds_recvmsg+0x3fb/0x1610 net/rds/recv.c:716 sock_recvmsg_nosec net/socket.c:1044 [inline] sock_recvmsg+0xe2/0x160 net/socket.c:1066 __sys_recvfrom+0x1b6/0x2f0 net/socket.c:2246 __do_sys_recvfrom net/socket.c:2264 [inline] __se_sys_recvfrom net/socket.c:2260 [inline] __x64_sys_recvfrom+0xe0/0x1b0 net/socket.c:2260 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b ================================================================== Fixes: 3289025aedc0 ("RDS: add receive message trace used by application") Reported-by: Chenyuan Yang <chenyuan0y(a)gmail.com> Closes: https://lore.kernel.org/linux-rdma/CALGdzuoVdq-wtQ4Az9iottBqC5cv9ZhcE5q8N7L… Signed-off-by: Sharath Srinivasan <sharath.srinivasan(a)oracle.com> Reviewed-by: Simon Horman <horms(a)kernel.org> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Dong Chenchen <dongchenchen2(a)huawei.com> --- net/rds/af_rds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/af_rds.c b/net/rds/af_rds.c index cd7e01ea8144..5eb71d276706 100644 --- a/net/rds/af_rds.c +++ b/net/rds/af_rds.c @@ -385,7 +385,7 @@ static int rds_recv_track_latency(struct rds_sock *rs, char __user *optval, rs->rs_rx_traces = trace.rx_traces; for (i = 0; i < rs->rs_rx_traces; i++) { - if (trace.rx_trace_pos[i] > RDS_MSG_RX_DGRAM_TRACE_MAX) { + if (trace.rx_trace_pos[i] >= RDS_MSG_RX_DGRAM_TRACE_MAX) { rs->rs_rx_traces = 0; return -EFAULT; } -- 2.25.1

1 0

[PATCH OLK-6.6] kabi: net: reserve space for net related structure
by Zhengchao Shao 29 Jan '24

29 Jan '24

hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZMS7 ---------------------------------------------------- Reserve some fields beforehand for net related structures prone to change. Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> --- include/linux/netlink.h | 5 +++++ include/net/cfg802154.h | 5 +++++ include/net/netns/conntrack.h | 4 ++++ include/net/netns/core.h | 6 ++++++ include/net/xfrm.h | 8 ++++++++ 5 files changed, 28 insertions(+) diff --git a/include/linux/netlink.h b/include/linux/netlink.h index 75d7de34c908..4111d53f4656 100644 --- a/include/linux/netlink.h +++ b/include/linux/netlink.h @@ -8,6 +8,7 @@ #include <linux/export.h> #include <net/scm.h> #include <uapi/linux/netlink.h> +#include <linux/kabi.h> struct net; @@ -88,6 +89,10 @@ struct netlink_ext_ack { u8 cookie[NETLINK_MAX_COOKIE_LEN]; u8 cookie_len; char _msg_buf[NETLINK_MAX_FMTMSG_LEN]; + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; /* Always use this macro, this allows later putting the diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h index f79ce133e51a..61aabd82b789 100644 --- a/include/net/cfg802154.h +++ b/include/net/cfg802154.h @@ -16,6 +16,8 @@ #include <net/nl802154.h> +#include <linux/kabi.h> + struct wpan_phy; struct wpan_phy_cca; struct cfg802154_scan_request; @@ -242,6 +244,9 @@ struct wpan_phy { */ enum ieee802154_filtering_level filtering; + KABI_RESERVE(1) + KABI_RESERVE(2) + char priv[] __aligned(NETDEV_ALIGN); }; diff --git a/include/net/netns/conntrack.h b/include/net/netns/conntrack.h index 1f463b3957c7..308c54643b3a 100644 --- a/include/net/netns/conntrack.h +++ b/include/net/netns/conntrack.h @@ -14,6 +14,7 @@ #include <linux/netfilter/nf_conntrack_sctp.h> #endif #include <linux/seqlock.h> +#include <linux/kabi.h> struct ctl_table_header; struct nf_conntrack_ecache; @@ -31,6 +32,9 @@ struct nf_tcp_net { #if IS_ENABLED(CONFIG_NF_FLOW_TABLE) unsigned int offload_timeout; #endif + + KABI_RESERVE(1) + KABI_RESERVE(2) }; enum udp_conntrack { diff --git a/include/net/netns/core.h b/include/net/netns/core.h index a91ef9f8de60..dfb54998c497 100644 --- a/include/net/netns/core.h +++ b/include/net/netns/core.h @@ -3,6 +3,7 @@ #define __NETNS_CORE_H__ #include <linux/types.h> +#include <linux/kabi.h> struct ctl_table_header; struct prot_inuse; @@ -22,6 +23,11 @@ struct netns_core { #if IS_ENABLED(CONFIG_RPS) && IS_ENABLED(CONFIG_SYSCTL) struct cpumask *rps_default_mask; #endif + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; #endif diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 363c7d510554..9eff85ef369c 100644 --- a/include/net/xfrm.h +++ b/include/net/xfrm.h @@ -32,6 +32,8 @@ #include <net/snmp.h> #endif +#include <linux/kabi.h> + #define XFRM_PROTO_ESP 50 #define XFRM_PROTO_AH 51 #define XFRM_PROTO_COMP 108 @@ -289,6 +291,9 @@ struct xfrm_state { /* Private data of this transformer, format is opaque, * interpreted by xfrm_type methods. */ void *data; + + KABI_RESERVE(1) + KABI_RESERVE(2) }; static inline struct net *xs_net(struct xfrm_state *x) @@ -549,6 +554,9 @@ struct xfrm_policy { struct rcu_head rcu; struct xfrm_dev_offload xdo; + + KABI_RESERVE(1) + KABI_RESERVE(2) }; static inline struct net *xp_net(const struct xfrm_policy *xp) -- 2.34.1

1 0

[PATCH OLK-5.10 v2 0/2] fs:/dcache.c: fix negative dentry limit not complete problem
by Long Li 29 Jan '24

29 Jan '24

In this patch set, it revert "fs:/dcache.c: fix negative dentry limit not complete problem" in patch 1/2 and rewrite this patch in patch 2/2. Long Li (2): Revert "fs:/dcache.c: fix negative dentry limit not complete problem" fs:/dcache.c: fix negative dentry limit not complete problem fs/dcache.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) -- 2.31.1

1 2

[PATCH OLK-6.6 v4 0/2] KABI reservation for IMA and crypto
by GUO Zihua 29 Jan '24

29 Jan '24

KABI reservation for IMA and crypto module. v4: Fixed remaining merge marks. v3: Reserve one more u64 for crypto related structs. v2: Changed reservation ordering, and more reservation. GUO Zihua (2): crypto: kabi: KABI reservation for crypto ima: kabi: KABI reservation for IMA include/crypto/aead.h | 7 +++++++ include/crypto/akcipher.h | 7 +++++++ include/crypto/algapi.h | 7 +++++++ include/crypto/cryptd.h | 3 +++ include/crypto/hash.h | 9 +++++++++ include/crypto/if_alg.h | 9 +++++++++ include/crypto/public_key.h | 5 +++++ include/crypto/rng.h | 5 +++++ include/crypto/skcipher.h | 7 +++++++ include/linux/crypto.h | 5 +++++ include/linux/fs.h | 2 ++ include/linux/kernel_read_file.h | 3 +++ include/linux/kexec.h | 5 +++++ include/linux/user_namespace.h | 3 +++ 14 files changed, 77 insertions(+) -- 2.34.1

2 3

[PATCH OLK-6.6 v2] kabi: reserve space for cpu cgroup and cpuset cgroup related structures
by Xiang Yang 29 Jan '24

29 Jan '24

From: Lu Jialin <lujialin4(a)huawei.com> hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I8SWPP --------------------------------------------- We reserve some fields beforehand for cpu cgroup and cpuset related structures prone to change, therefore, we can hot add/change features of cpu cgroup cpuset and cgroup with this enhancement. After reserving, normally cache does not matter as the reserved fields are not accessed at all. Signed-off-by: Lu Jialin <lujialin4(a)huawei.com> Signed-off-by: Xiang Yang <xiangyang3(a)huawei.com> --- kernel/cgroup/cpuset.c | 6 ++++++ kernel/sched/sched.h | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index cfdca8aeabda..ea78008dd899 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -43,6 +43,7 @@ #include <linux/sched/isolation.h> #include <linux/cgroup.h> #include <linux/wait.h> +#include <linux/kabi.h> DEFINE_STATIC_KEY_FALSE(cpusets_pre_enable_key); DEFINE_STATIC_KEY_FALSE(cpusets_enabled_key); @@ -186,6 +187,11 @@ struct cpuset { /* Handle for cpuset.cpus.partition */ struct cgroup_file partition_file; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; /* diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 88dbcbe3d7c1..938d4d6cc6f2 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -68,6 +68,7 @@ #include <linux/wait_api.h> #include <linux/wait_bit.h> #include <linux/workqueue_api.h> +#include <linux/kabi.h> #include <trace/events/power.h> #include <trace/events/sched.h> @@ -455,6 +456,11 @@ struct task_group { #if defined(CONFIG_QOS_SCHED_SMART_GRID) && !defined(__GENKSYMS__) struct auto_affinity *auto_affinity; #endif + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; #ifdef CONFIG_FAIR_GROUP_SCHED -- 2.34.1

2 1

[PATCH openEuler-1.0-LTS v2] fs:/dcache.c: fix negative dentry limit not complete problem
by Long Li 29 Jan '24

29 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8WPQW CVE: NA -------------------------------- Restrictions of negative dentry can avoid softlock when too many dentry in memory, but restrictions before do not always take effect. For example, removing files which has been created would not enter retain_dentry(), because the dentry of file maybe has been added to lru list of superblock, it caused that fast_dput() reutrn true in last dput(). So, add restriction logic for the file which has been added to the lru list in fast_dput(), it prevents the negative dentry exceeding the limit when deleting existing file. Factor out negative dentry limit logic into limit_negative_dentry(), make the code more clean. Fixes: 7ba5d5d0e8b5 ("fs/dcache.c: avoid softlock since too many negative dentry") Signed-off-by: Long Li <leo.lilong(a)huawei.com> --- fs/dcache.c | 70 ++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 48 insertions(+), 22 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index ef1641398eda..2a7eaac0c3ef 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -636,10 +636,36 @@ static inline struct dentry *lock_parent(struct dentry *dentry) return __lock_parent(dentry); } -static inline bool retain_dentry(struct dentry *dentry) +/* + * Return true if dentry is negative and exceed negative dentry limit. + */ +static inline bool limit_negative_dentry(struct dentry *dentry) { struct dentry *parent; + parent = dentry->d_parent; + if (unlikely(!parent)) + return false; + + WARN_ON((atomic_read(&parent->d_neg_dnum) < 0)); + if (!dentry->d_inode) { + if (!(dentry->d_flags & DCACHE_NEGATIVE_ACCOUNT)) { + unsigned int flags = READ_ONCE(dentry->d_flags); + + flags |= DCACHE_NEGATIVE_ACCOUNT; + WRITE_ONCE(dentry->d_flags, flags); + atomic_inc(&parent->d_neg_dnum); + } + + if (atomic_read(&parent->d_neg_dnum) >= NEG_DENTRY_LIMIT) + return true; + } + + return false; +} + +static inline bool retain_dentry(struct dentry *dentry) +{ WARN_ON(d_in_lookup(dentry)); /* Unreachable? Get rid of it */ @@ -654,27 +680,9 @@ static inline bool retain_dentry(struct dentry *dentry) return false; } - if (unlikely(!dentry->d_parent)) - goto noparent; - - parent = dentry->d_parent; - /* Return false if it's negative */ - WARN_ON((atomic_read(&parent->d_neg_dnum) < 0)); - if (!dentry->d_inode) { - if (!(dentry->d_flags & DCACHE_NEGATIVE_ACCOUNT)) { - unsigned flags = READ_ONCE(dentry->d_flags); - - flags |= DCACHE_NEGATIVE_ACCOUNT; - WRITE_ONCE(dentry->d_flags, flags); - atomic_inc(&parent->d_neg_dnum); - } - } - - if (!dentry->d_inode && - atomic_read(&parent->d_neg_dnum) >= NEG_DENTRY_LIMIT) + if (unlikely(limit_negative_dentry(dentry))) return false; -noparent: /* retain; LRU fodder */ dentry->d_lockref.count--; if (unlikely(!(dentry->d_flags & DCACHE_LRU_LIST))) @@ -808,8 +816,25 @@ static inline bool fast_dput(struct dentry *dentry) d_flags &= DCACHE_REFERENCED | DCACHE_LRU_LIST | DCACHE_DISCONNECTED; /* Nothing to do? Dropping the reference was all we needed? */ - if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry)) - return true; + if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry)) { + /* + * If the dentry is not negative dentry, return true directly, + * avoid holding dentry lock in the fast put path. + */ + if (dentry->d_inode) + return true; + /* + * If dentry is negative and need to be limitted, it maybe need + * to be killed, so shouldn't fast put and retain in memory. + */ + spin_lock(&dentry->d_lock); + if (likely(!limit_negative_dentry(dentry))) { + spin_unlock(&dentry->d_lock); + return true; + } + + goto dentry_locked; + } /* * Not the fast normal case? Get the lock. We've already decremented @@ -818,6 +843,7 @@ static inline bool fast_dput(struct dentry *dentry) */ spin_lock(&dentry->d_lock); +dentry_locked: /* * Did somebody else grab a reference to it in the meantime, and * we're no longer the last user after all? Alternatively, somebody -- 2.31.1

1 0

[openeuler:openEuler-1.0-LTS 6076/21575] net/ipv4/tcp_metrics.o: warning: objtool: tcp_metrics_nl_cmd_get() falls through to next function tcp_metrics_nl_dump()
by kernel test robot 29 Jan '24

29 Jan '24

First bad commit (maybe != root cause): tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: e0207e2784d0f836e732608faf1a6966546a8eb3 commit: d2bc250666ee233e0ee440ab9de9255dffa9af7f [6076/21575] objtool: Fix function fallthrough detection config: x86_64-randconfig-001-20240125 (attached as .config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (attached as reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401260200.WMl341pL-lkp@intel.com/ All warnings (new ones prefixed by >>): >> net/ipv4/tcp_metrics.o: warning: objtool: tcp_metrics_nl_cmd_get() falls through to next function tcp_metrics_nl_dump() >> net/ipv4/tcp_metrics.o: warning: objtool: tcp_metrics_nl_cmd_del() falls through to next function tcp_metrics_fill_info() -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1521/21575] drivers/scsi/libsas/sas_expander.c:2079: undefined reference to `ata_dev_same_device'
by kernel test robot 29 Jan '24

29 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: e0207e2784d0f836e732608faf1a6966546a8eb3 commit: d856ec500c97835c591ffacc005f514509f1a931 [1521/21575] scsi: libsas: check if the same sata device when flutter :::::: branch date: 13 hours ago :::::: commit date: 4 years, 1 month ago config: x86_64-randconfig-r113-20240125 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): (attached as reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401261034.TNcmiPjc-lkp@intel.com/ All errors (new ones prefixed by >>): ld: warning: arch/x86/lib/csum-copy_64.o: missing .note.GNU-stack section implies executable stack ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker ld: warning: arch/x86/lib/csum-copy_64.o: missing .note.GNU-stack section implies executable stack ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker ld: warning: .tmp_vmlinux1 has a LOAD segment with RWX permissions ld: drivers/scsi/libsas/sas_expander.o: in function `sas_rediscover_dev': >> drivers/scsi/libsas/sas_expander.c:2079: undefined reference to `ata_dev_same_device' vim +2079 drivers/scsi/libsas/sas_expander.c 354cf82980e244 Dan Williams 2012-01-12 2011 19252de6818ced Tom Peng 2009-07-17 2012 static int sas_rediscover_dev(struct domain_device *dev, int phy_id, bool last) 2908d778ab3e24 James Bottomley 2006-08-29 2013 { 2908d778ab3e24 James Bottomley 2006-08-29 2014 struct expander_device *ex = &dev->ex_dev; 2908d778ab3e24 James Bottomley 2006-08-29 2015 struct ex_phy *phy = &ex->ex_phy[phy_id]; d12b2bcfd3801c Jason Yan 2018-12-28 2016 struct asd_sas_port *port = dev->port; d12b2bcfd3801c Jason Yan 2018-12-28 2017 struct asd_sas_phy *sas_phy; aa9f8328fc5146 James Bottomley 2013-05-07 2018 enum sas_device_type type = SAS_PHY_UNUSED; 354cf82980e244 Dan Williams 2012-01-12 2019 u8 sas_addr[8]; 2908d778ab3e24 James Bottomley 2006-08-29 2020 int res; 2908d778ab3e24 James Bottomley 2006-08-29 2021 b2311a287553af Jeff Skirvin 2012-06-21 2022 memset(sas_addr, 0, 8); 354cf82980e244 Dan Williams 2012-01-12 2023 res = sas_get_phy_attached_dev(dev, phy_id, sas_addr, &type); 2908d778ab3e24 James Bottomley 2006-08-29 2024 switch (res) { 2908d778ab3e24 James Bottomley 2006-08-29 2025 case SMP_RESP_NO_PHY: 2908d778ab3e24 James Bottomley 2006-08-29 2026 phy->phy_state = PHY_NOT_PRESENT; 19252de6818ced Tom Peng 2009-07-17 2027 sas_unregister_devs_sas_addr(dev, phy_id, last); 354cf82980e244 Dan Williams 2012-01-12 2028 return res; 2908d778ab3e24 James Bottomley 2006-08-29 2029 case SMP_RESP_PHY_VACANT: 2908d778ab3e24 James Bottomley 2006-08-29 2030 phy->phy_state = PHY_VACANT; 19252de6818ced Tom Peng 2009-07-17 2031 sas_unregister_devs_sas_addr(dev, phy_id, last); 354cf82980e244 Dan Williams 2012-01-12 2032 return res; 2908d778ab3e24 James Bottomley 2006-08-29 2033 case SMP_RESP_FUNC_ACC: 2908d778ab3e24 James Bottomley 2006-08-29 2034 break; b2311a287553af Jeff Skirvin 2012-06-21 2035 case -ECOMM: b2311a287553af Jeff Skirvin 2012-06-21 2036 break; b2311a287553af Jeff Skirvin 2012-06-21 2037 default: b2311a287553af Jeff Skirvin 2012-06-21 2038 return res; 2908d778ab3e24 James Bottomley 2006-08-29 2039 } 2908d778ab3e24 James Bottomley 2006-08-29 2040 b2311a287553af Jeff Skirvin 2012-06-21 2041 if ((SAS_ADDR(sas_addr) == 0) || (res == -ECOMM)) { 2908d778ab3e24 James Bottomley 2006-08-29 2042 phy->phy_state = PHY_EMPTY; 19252de6818ced Tom Peng 2009-07-17 2043 sas_unregister_devs_sas_addr(dev, phy_id, last); 354cf82980e244 Dan Williams 2012-01-12 2044 return res; 354cf82980e244 Dan Williams 2012-01-12 2045 } else if (SAS_ADDR(sas_addr) == SAS_ADDR(phy->attached_sas_addr) && 354cf82980e244 Dan Williams 2012-01-12 2046 dev_type_flutter(type, phy->attached_dev_type)) { 354cf82980e244 Dan Williams 2012-01-12 2047 struct domain_device *ata_dev = sas_ex_to_ata(dev, phy_id); 354cf82980e244 Dan Williams 2012-01-12 2048 char *action = ""; 354cf82980e244 Dan Williams 2012-01-12 2049 a01e70e570a72b James Bottomley 2006-09-06 2050 sas_ex_phy_discover(dev, phy_id); 354cf82980e244 Dan Williams 2012-01-12 2051 aa9f8328fc5146 James Bottomley 2013-05-07 2052 if (ata_dev && phy->attached_dev_type == SAS_SATA_PENDING) 354cf82980e244 Dan Williams 2012-01-12 2053 action = ", needs recovery"; 354cf82980e244 Dan Williams 2012-01-12 2054 SAS_DPRINTK("ex %016llx phy 0x%x broadcast flutter%s\n", 354cf82980e244 Dan Williams 2012-01-12 2055 SAS_ADDR(dev->sas_addr), phy_id, action); d856ec500c9783 Jason Yan 2018-12-28 2056 d856ec500c9783 Jason Yan 2018-12-28 2057 /* the phy attached address will be updated by sas_ex_phy_discover() d856ec500c9783 Jason Yan 2018-12-28 2058 * and sometimes become abnormal d856ec500c9783 Jason Yan 2018-12-28 2059 */ d856ec500c9783 Jason Yan 2018-12-28 2060 if (SAS_ADDR(phy->attached_sas_addr) != SAS_ADDR(sas_addr) || d856ec500c9783 Jason Yan 2018-12-28 2061 SAS_ADDR(phy->attached_sas_addr) == 0) { d856ec500c9783 Jason Yan 2018-12-28 2062 /* if attached_sas_addr become abnormal, we must set the d856ec500c9783 Jason Yan 2018-12-28 2063 * original address back so that the device can be unregistered d856ec500c9783 Jason Yan 2018-12-28 2064 */ d856ec500c9783 Jason Yan 2018-12-28 2065 memcpy(phy->attached_sas_addr, sas_addr, SAS_ADDR_SIZE); d856ec500c9783 Jason Yan 2018-12-28 2066 SAS_DPRINTK("phy address(%016llx) abnormal, origin:%016llx\n", d856ec500c9783 Jason Yan 2018-12-28 2067 SAS_ADDR(phy->attached_sas_addr), d856ec500c9783 Jason Yan 2018-12-28 2068 SAS_ADDR(sas_addr)); d856ec500c9783 Jason Yan 2018-12-28 2069 goto unregister; d856ec500c9783 Jason Yan 2018-12-28 2070 } d856ec500c9783 Jason Yan 2018-12-28 2071 d856ec500c9783 Jason Yan 2018-12-28 2072 d856ec500c9783 Jason Yan 2018-12-28 2073 if (ata_dev) { d856ec500c9783 Jason Yan 2018-12-28 2074 struct ata_device *adev = sas_to_ata_dev(ata_dev); d856ec500c9783 Jason Yan 2018-12-28 2075 unsigned int class = ata_dev->sata_dev.class; d856ec500c9783 Jason Yan 2018-12-28 2076 u16 *id = ata_dev->sata_dev.id; d856ec500c9783 Jason Yan 2018-12-28 2077 d856ec500c9783 Jason Yan 2018-12-28 2078 /* to see if the disk is replaced with another one */ d856ec500c9783 Jason Yan 2018-12-28 @2079 if (!ata_dev_same_device(adev, class, id)) d856ec500c9783 Jason Yan 2018-12-28 2080 goto unregister; d856ec500c9783 Jason Yan 2018-12-28 2081 } d856ec500c9783 Jason Yan 2018-12-28 2082 2908d778ab3e24 James Bottomley 2006-08-29 2083 return res; 2908d778ab3e24 James Bottomley 2006-08-29 2084 } 2908d778ab3e24 James Bottomley 2006-08-29 2085 d856ec500c9783 Jason Yan 2018-12-28 2086 unregister: 24b7c4b6e22de5 Jason Yan 2018-12-28 2087 /* we always have to delete the old device when we went here */ c666aae6919114 Dan Williams 2012-01-19 2088 SAS_DPRINTK("ex %016llx phy 0x%x replace %016llx\n", c666aae6919114 Dan Williams 2012-01-19 2089 SAS_ADDR(dev->sas_addr), phy_id, c666aae6919114 Dan Williams 2012-01-19 2090 SAS_ADDR(phy->attached_sas_addr)); c666aae6919114 Dan Williams 2012-01-19 2091 sas_unregister_devs_sas_addr(dev, phy_id, last); c666aae6919114 Dan Williams 2012-01-19 2092 d12b2bcfd3801c Jason Yan 2018-12-28 2093 /* force the next revalidation find this phy and bring it up */ d12b2bcfd3801c Jason Yan 2018-12-28 2094 phy->phy_change_count = -1; d12b2bcfd3801c Jason Yan 2018-12-28 2095 ex->ex_change_count = -1; d12b2bcfd3801c Jason Yan 2018-12-28 2096 sas_phy = container_of(port->phy_list.next, struct asd_sas_phy, d12b2bcfd3801c Jason Yan 2018-12-28 2097 port_phy_el); d12b2bcfd3801c Jason Yan 2018-12-28 2098 port->ha->notify_port_event(sas_phy, PORTE_BROADCAST_RCVD); d12b2bcfd3801c Jason Yan 2018-12-28 2099 d12b2bcfd3801c Jason Yan 2018-12-28 2100 return 0; 354cf82980e244 Dan Williams 2012-01-12 2101 } 354cf82980e244 Dan Williams 2012-01-12 2102 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1581/21575] drivers/pci/probe.c:2223:3: sparse: sparse: symbol 'skip_1620_bus_num' was not declared. Should it be static?
by kernel test robot 29 Jan '24

29 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: e0207e2784d0f836e732608faf1a6966546a8eb3 commit: da5e23f4c7511cbc1a199bb4d5d5477e191dc26c [1581/21575] Hi1620 CS FPGA PCIe Skip Bus :::::: branch date: 16 hours ago :::::: commit date: 4 years, 1 month ago config: x86_64-randconfig-121-20240125 (attached as .config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (attached as reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401261304.VfCawDjG-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/pci/probe.c:2223:3: sparse: sparse: symbol 'skip_1620_bus_num' was not declared. Should it be static? drivers/pci/probe.c:448:21: sparse: sparse: self-comparison always evaluates to false vim +/skip_1620_bus_num +2223 drivers/pci/probe.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 2214 da5e23f4c7511c Dong Bo 2018-01-30 2215 static int skip_bus_flag = 0; da5e23f4c7511c Dong Bo 2018-01-30 2216 #define HOSTBRIGE_1620_NUM 48 da5e23f4c7511c Dong Bo 2018-01-30 2217 struct skip_bus_num { da5e23f4c7511c Dong Bo 2018-01-30 2218 char module_name[32]; da5e23f4c7511c Dong Bo 2018-01-30 2219 char label[4]; da5e23f4c7511c Dong Bo 2018-01-30 2220 int bus_num; da5e23f4c7511c Dong Bo 2018-01-30 2221 int dev_num; da5e23f4c7511c Dong Bo 2018-01-30 2222 int skip; da5e23f4c7511c Dong Bo 2018-01-30 @2223 } skip_1620_bus_num[HOSTBRIGE_1620_NUM] = { da5e23f4c7511c Dong Bo 2018-01-30 2224 /*chip 0*/ da5e23f4c7511c Dong Bo 2018-01-30 2225 { da5e23f4c7511c Dong Bo 2018-01-30 2226 .module_name = "chip0_pcie", da5e23f4c7511c Dong Bo 2018-01-30 2227 .label = "a0", da5e23f4c7511c Dong Bo 2018-01-30 2228 .bus_num = 0, da5e23f4c7511c Dong Bo 2018-01-30 2229 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2230 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2231 }, da5e23f4c7511c Dong Bo 2018-01-30 2232 { da5e23f4c7511c Dong Bo 2018-01-30 2233 .module_name = "chip0_pcie_dma", da5e23f4c7511c Dong Bo 2018-01-30 2234 .label = "a1", da5e23f4c7511c Dong Bo 2018-01-30 2235 .bus_num = 0x7b, da5e23f4c7511c Dong Bo 2018-01-30 2236 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2237 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2238 }, da5e23f4c7511c Dong Bo 2018-01-30 2239 { da5e23f4c7511c Dong Bo 2018-01-30 2240 .module_name = "chip0_pcie_sdi", da5e23f4c7511c Dong Bo 2018-01-30 2241 .label = "a2", da5e23f4c7511c Dong Bo 2018-01-30 2242 .bus_num = 0x7b, da5e23f4c7511c Dong Bo 2018-01-30 2243 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2244 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2245 }, da5e23f4c7511c Dong Bo 2018-01-30 2246 { da5e23f4c7511c Dong Bo 2018-01-30 2247 .module_name = "chip0_USB", da5e23f4c7511c Dong Bo 2018-01-30 2248 .label = "a3", da5e23f4c7511c Dong Bo 2018-01-30 2249 .bus_num = 0x7a, da5e23f4c7511c Dong Bo 2018-01-30 2250 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2251 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2252 }, da5e23f4c7511c Dong Bo 2018-01-30 2253 { da5e23f4c7511c Dong Bo 2018-01-30 2254 .module_name = "chip0_hpre", da5e23f4c7511c Dong Bo 2018-01-30 2255 .label = "a4", da5e23f4c7511c Dong Bo 2018-01-30 2256 .bus_num = 0x78, da5e23f4c7511c Dong Bo 2018-01-30 2257 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2258 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2259 }, da5e23f4c7511c Dong Bo 2018-01-30 2260 { da5e23f4c7511c Dong Bo 2018-01-30 2261 .module_name = "chip0_rde", da5e23f4c7511c Dong Bo 2018-01-30 2262 .label = "a5", da5e23f4c7511c Dong Bo 2018-01-30 2263 .bus_num = 0x78, da5e23f4c7511c Dong Bo 2018-01-30 2264 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2265 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2266 }, da5e23f4c7511c Dong Bo 2018-01-30 2267 { da5e23f4c7511c Dong Bo 2018-01-30 2268 .module_name = "chip0_nic", da5e23f4c7511c Dong Bo 2018-01-30 2269 .label = "aa", da5e23f4c7511c Dong Bo 2018-01-30 2270 .bus_num = 0x7c, da5e23f4c7511c Dong Bo 2018-01-30 2271 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2272 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2273 }, da5e23f4c7511c Dong Bo 2018-01-30 2274 { da5e23f4c7511c Dong Bo 2018-01-30 2275 .module_name = "chip0_sas", da5e23f4c7511c Dong Bo 2018-01-30 2276 .label = "a6", da5e23f4c7511c Dong Bo 2018-01-30 2277 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2278 .dev_num = 0x02, da5e23f4c7511c Dong Bo 2018-01-30 2279 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2280 }, da5e23f4c7511c Dong Bo 2018-01-30 2281 { da5e23f4c7511c Dong Bo 2018-01-30 2282 .module_name = "chip0_sas1", da5e23f4c7511c Dong Bo 2018-01-30 2283 .label = "ab", da5e23f4c7511c Dong Bo 2018-01-30 2284 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2285 .dev_num = 0x04, da5e23f4c7511c Dong Bo 2018-01-30 2286 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2287 }, da5e23f4c7511c Dong Bo 2018-01-30 2288 { da5e23f4c7511c Dong Bo 2018-01-30 2289 .module_name = "chip0_sata", da5e23f4c7511c Dong Bo 2018-01-30 2290 .label = "a7", da5e23f4c7511c Dong Bo 2018-01-30 2291 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2292 .dev_num = 0x03, da5e23f4c7511c Dong Bo 2018-01-30 2293 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2294 }, da5e23f4c7511c Dong Bo 2018-01-30 2295 { da5e23f4c7511c Dong Bo 2018-01-30 2296 .module_name = "chip0_zip", da5e23f4c7511c Dong Bo 2018-01-30 2297 .label = "a8", da5e23f4c7511c Dong Bo 2018-01-30 2298 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2299 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2300 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2301 }, da5e23f4c7511c Dong Bo 2018-01-30 2302 { da5e23f4c7511c Dong Bo 2018-01-30 2303 .module_name = "chip0_sec", da5e23f4c7511c Dong Bo 2018-01-30 2304 .label = "a9", da5e23f4c7511c Dong Bo 2018-01-30 2305 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2306 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2307 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2308 }, da5e23f4c7511c Dong Bo 2018-01-30 2309 /*chip 1*/ da5e23f4c7511c Dong Bo 2018-01-30 2310 { da5e23f4c7511c Dong Bo 2018-01-30 2311 .module_name = "chip1_pcie", da5e23f4c7511c Dong Bo 2018-01-30 2312 .label = "b0", da5e23f4c7511c Dong Bo 2018-01-30 2313 .bus_num = 0x80, da5e23f4c7511c Dong Bo 2018-01-30 2314 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2315 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2316 }, da5e23f4c7511c Dong Bo 2018-01-30 2317 { da5e23f4c7511c Dong Bo 2018-01-30 2318 .module_name = "chip1_pcie_dma", da5e23f4c7511c Dong Bo 2018-01-30 2319 .label = "b1", da5e23f4c7511c Dong Bo 2018-01-30 2320 .bus_num = 0xbb, da5e23f4c7511c Dong Bo 2018-01-30 2321 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2322 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2323 }, da5e23f4c7511c Dong Bo 2018-01-30 2324 { da5e23f4c7511c Dong Bo 2018-01-30 2325 .module_name = "chip1_pcie_sdi", da5e23f4c7511c Dong Bo 2018-01-30 2326 .label = "b2", da5e23f4c7511c Dong Bo 2018-01-30 2327 .bus_num = 0xbb, da5e23f4c7511c Dong Bo 2018-01-30 2328 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2329 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2330 }, da5e23f4c7511c Dong Bo 2018-01-30 2331 { da5e23f4c7511c Dong Bo 2018-01-30 2332 .module_name = "chip1_USB", da5e23f4c7511c Dong Bo 2018-01-30 2333 .label = "b3", da5e23f4c7511c Dong Bo 2018-01-30 2334 .bus_num = 0xba, da5e23f4c7511c Dong Bo 2018-01-30 2335 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2336 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2337 }, da5e23f4c7511c Dong Bo 2018-01-30 2338 { da5e23f4c7511c Dong Bo 2018-01-30 2339 .module_name = "chip1_hpre", da5e23f4c7511c Dong Bo 2018-01-30 2340 .label = "b4", da5e23f4c7511c Dong Bo 2018-01-30 2341 .bus_num = 0xb8, da5e23f4c7511c Dong Bo 2018-01-30 2342 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2343 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2344 }, da5e23f4c7511c Dong Bo 2018-01-30 2345 { da5e23f4c7511c Dong Bo 2018-01-30 2346 .module_name = "chip1_rde", da5e23f4c7511c Dong Bo 2018-01-30 2347 .label = "b5", da5e23f4c7511c Dong Bo 2018-01-30 2348 .bus_num = 0xb8, da5e23f4c7511c Dong Bo 2018-01-30 2349 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2350 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2351 }, da5e23f4c7511c Dong Bo 2018-01-30 2352 { da5e23f4c7511c Dong Bo 2018-01-30 2353 .module_name = "chip1_nic", da5e23f4c7511c Dong Bo 2018-01-30 2354 .label = "ba", da5e23f4c7511c Dong Bo 2018-01-30 2355 .bus_num = 0xbc, da5e23f4c7511c Dong Bo 2018-01-30 2356 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2357 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2358 }, da5e23f4c7511c Dong Bo 2018-01-30 2359 { da5e23f4c7511c Dong Bo 2018-01-30 2360 .module_name = "chip1_sas", da5e23f4c7511c Dong Bo 2018-01-30 2361 .label = "b6", da5e23f4c7511c Dong Bo 2018-01-30 2362 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2363 .dev_num = 0x02, da5e23f4c7511c Dong Bo 2018-01-30 2364 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2365 }, da5e23f4c7511c Dong Bo 2018-01-30 2366 { da5e23f4c7511c Dong Bo 2018-01-30 2367 .module_name = "chip1_sas1", da5e23f4c7511c Dong Bo 2018-01-30 2368 .label = "bb", da5e23f4c7511c Dong Bo 2018-01-30 2369 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2370 .dev_num = 0x04, da5e23f4c7511c Dong Bo 2018-01-30 2371 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2372 }, da5e23f4c7511c Dong Bo 2018-01-30 2373 { da5e23f4c7511c Dong Bo 2018-01-30 2374 .module_name = "chip1_sata", da5e23f4c7511c Dong Bo 2018-01-30 2375 .label = "b7", da5e23f4c7511c Dong Bo 2018-01-30 2376 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2377 .dev_num = 0x03, da5e23f4c7511c Dong Bo 2018-01-30 2378 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2379 }, da5e23f4c7511c Dong Bo 2018-01-30 2380 { da5e23f4c7511c Dong Bo 2018-01-30 2381 .module_name = "chip1_zip", da5e23f4c7511c Dong Bo 2018-01-30 2382 .label = "b8", da5e23f4c7511c Dong Bo 2018-01-30 2383 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2384 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2385 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2386 }, da5e23f4c7511c Dong Bo 2018-01-30 2387 { da5e23f4c7511c Dong Bo 2018-01-30 2388 .module_name = "chip0_sec", da5e23f4c7511c Dong Bo 2018-01-30 2389 .label = "b9", da5e23f4c7511c Dong Bo 2018-01-30 2390 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2391 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2392 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2393 }, da5e23f4c7511c Dong Bo 2018-01-30 2394 da5e23f4c7511c Dong Bo 2018-01-30 2395 /*chip 2*/ da5e23f4c7511c Dong Bo 2018-01-30 2396 { da5e23f4c7511c Dong Bo 2018-01-30 2397 .module_name = "chip2_pcie", da5e23f4c7511c Dong Bo 2018-01-30 2398 .label = "c0", da5e23f4c7511c Dong Bo 2018-01-30 2399 .bus_num = 0xc0, da5e23f4c7511c Dong Bo 2018-01-30 2400 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2401 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2402 }, da5e23f4c7511c Dong Bo 2018-01-30 2403 { da5e23f4c7511c Dong Bo 2018-01-30 2404 .module_name = "chip2_pcie_dma", da5e23f4c7511c Dong Bo 2018-01-30 2405 .label = "c1", da5e23f4c7511c Dong Bo 2018-01-30 2406 .bus_num = 0xdb, da5e23f4c7511c Dong Bo 2018-01-30 2407 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2408 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2409 }, da5e23f4c7511c Dong Bo 2018-01-30 2410 { da5e23f4c7511c Dong Bo 2018-01-30 2411 .module_name = "chip2_pcie_sdi", da5e23f4c7511c Dong Bo 2018-01-30 2412 .label = "c2", da5e23f4c7511c Dong Bo 2018-01-30 2413 .bus_num = 0xdb, da5e23f4c7511c Dong Bo 2018-01-30 2414 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2415 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2416 }, da5e23f4c7511c Dong Bo 2018-01-30 2417 { da5e23f4c7511c Dong Bo 2018-01-30 2418 .module_name = "chip2_USB", da5e23f4c7511c Dong Bo 2018-01-30 2419 .label = "c3", da5e23f4c7511c Dong Bo 2018-01-30 2420 .bus_num = 0xda, da5e23f4c7511c Dong Bo 2018-01-30 2421 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2422 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2423 }, da5e23f4c7511c Dong Bo 2018-01-30 2424 { da5e23f4c7511c Dong Bo 2018-01-30 2425 .module_name = "chip2_hpre", da5e23f4c7511c Dong Bo 2018-01-30 2426 .label = "c4", da5e23f4c7511c Dong Bo 2018-01-30 2427 .bus_num = 0xd8, da5e23f4c7511c Dong Bo 2018-01-30 2428 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2429 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2430 }, da5e23f4c7511c Dong Bo 2018-01-30 2431 { da5e23f4c7511c Dong Bo 2018-01-30 2432 .module_name = "chip2_rde", da5e23f4c7511c Dong Bo 2018-01-30 2433 .label = "c5", da5e23f4c7511c Dong Bo 2018-01-30 2434 .bus_num = 0xd8, da5e23f4c7511c Dong Bo 2018-01-30 2435 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2436 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2437 }, da5e23f4c7511c Dong Bo 2018-01-30 2438 { da5e23f4c7511c Dong Bo 2018-01-30 2439 .module_name = "chip2_nic", da5e23f4c7511c Dong Bo 2018-01-30 2440 .label = "ca", da5e23f4c7511c Dong Bo 2018-01-30 2441 .bus_num = 0xdc, da5e23f4c7511c Dong Bo 2018-01-30 2442 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2443 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2444 }, da5e23f4c7511c Dong Bo 2018-01-30 2445 { da5e23f4c7511c Dong Bo 2018-01-30 2446 .module_name = "chip2_sas", da5e23f4c7511c Dong Bo 2018-01-30 2447 .label = "c6", da5e23f4c7511c Dong Bo 2018-01-30 2448 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2449 .dev_num = 0x02, da5e23f4c7511c Dong Bo 2018-01-30 2450 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2451 }, da5e23f4c7511c Dong Bo 2018-01-30 2452 { da5e23f4c7511c Dong Bo 2018-01-30 2453 .module_name = "chip2_sas1", da5e23f4c7511c Dong Bo 2018-01-30 2454 .label = "cb", da5e23f4c7511c Dong Bo 2018-01-30 2455 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2456 .dev_num = 0x04, da5e23f4c7511c Dong Bo 2018-01-30 2457 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2458 }, da5e23f4c7511c Dong Bo 2018-01-30 2459 { da5e23f4c7511c Dong Bo 2018-01-30 2460 .module_name = "chip2_sata", da5e23f4c7511c Dong Bo 2018-01-30 2461 .label = "c7", da5e23f4c7511c Dong Bo 2018-01-30 2462 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2463 .dev_num = 0x03, da5e23f4c7511c Dong Bo 2018-01-30 2464 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2465 }, da5e23f4c7511c Dong Bo 2018-01-30 2466 { da5e23f4c7511c Dong Bo 2018-01-30 2467 .module_name = "chip2_zip", da5e23f4c7511c Dong Bo 2018-01-30 2468 .label = "c8", da5e23f4c7511c Dong Bo 2018-01-30 2469 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2470 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2471 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2472 }, da5e23f4c7511c Dong Bo 2018-01-30 2473 { da5e23f4c7511c Dong Bo 2018-01-30 2474 .module_name = "chip2_sec", da5e23f4c7511c Dong Bo 2018-01-30 2475 .label = "c9", da5e23f4c7511c Dong Bo 2018-01-30 2476 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2477 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2478 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2479 }, da5e23f4c7511c Dong Bo 2018-01-30 2480 da5e23f4c7511c Dong Bo 2018-01-30 2481 /*chip 3*/ da5e23f4c7511c Dong Bo 2018-01-30 2482 { da5e23f4c7511c Dong Bo 2018-01-30 2483 .module_name = "chip3_pcie", da5e23f4c7511c Dong Bo 2018-01-30 2484 .label = "d0", da5e23f4c7511c Dong Bo 2018-01-30 2485 .bus_num = 0xe0, da5e23f4c7511c Dong Bo 2018-01-30 2486 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2487 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2488 }, da5e23f4c7511c Dong Bo 2018-01-30 2489 { da5e23f4c7511c Dong Bo 2018-01-30 2490 .module_name = "chip3_pcie_dma", da5e23f4c7511c Dong Bo 2018-01-30 2491 .label = "d1", da5e23f4c7511c Dong Bo 2018-01-30 2492 .bus_num = 0xfb, da5e23f4c7511c Dong Bo 2018-01-30 2493 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2494 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2495 }, da5e23f4c7511c Dong Bo 2018-01-30 2496 { da5e23f4c7511c Dong Bo 2018-01-30 2497 .module_name = "chip3_pcie_sdi", da5e23f4c7511c Dong Bo 2018-01-30 2498 .label = "d2", da5e23f4c7511c Dong Bo 2018-01-30 2499 .bus_num = 0xfb, da5e23f4c7511c Dong Bo 2018-01-30 2500 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2501 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2502 }, da5e23f4c7511c Dong Bo 2018-01-30 2503 { da5e23f4c7511c Dong Bo 2018-01-30 2504 .module_name = "chip3_USB", da5e23f4c7511c Dong Bo 2018-01-30 2505 .label = "d3", da5e23f4c7511c Dong Bo 2018-01-30 2506 .bus_num = 0xfa, da5e23f4c7511c Dong Bo 2018-01-30 2507 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2508 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2509 }, da5e23f4c7511c Dong Bo 2018-01-30 2510 { da5e23f4c7511c Dong Bo 2018-01-30 2511 .module_name = "chip3_hpre", da5e23f4c7511c Dong Bo 2018-01-30 2512 .label = "d4", da5e23f4c7511c Dong Bo 2018-01-30 2513 .bus_num = 0xf8, da5e23f4c7511c Dong Bo 2018-01-30 2514 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2515 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2516 }, da5e23f4c7511c Dong Bo 2018-01-30 2517 { da5e23f4c7511c Dong Bo 2018-01-30 2518 .module_name = "chip3_rde", da5e23f4c7511c Dong Bo 2018-01-30 2519 .label = "d5", da5e23f4c7511c Dong Bo 2018-01-30 2520 .bus_num = 0xf8, da5e23f4c7511c Dong Bo 2018-01-30 2521 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2522 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2523 }, da5e23f4c7511c Dong Bo 2018-01-30 2524 { da5e23f4c7511c Dong Bo 2018-01-30 2525 .module_name = "chip3_nic", da5e23f4c7511c Dong Bo 2018-01-30 2526 .label = "da", da5e23f4c7511c Dong Bo 2018-01-30 2527 .bus_num = 0xfc, da5e23f4c7511c Dong Bo 2018-01-30 2528 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2529 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2530 }, da5e23f4c7511c Dong Bo 2018-01-30 2531 { da5e23f4c7511c Dong Bo 2018-01-30 2532 .module_name = "chip3_sas", da5e23f4c7511c Dong Bo 2018-01-30 2533 .label = "d6", da5e23f4c7511c Dong Bo 2018-01-30 2534 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2535 .dev_num = 0x02, da5e23f4c7511c Dong Bo 2018-01-30 2536 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2537 }, da5e23f4c7511c Dong Bo 2018-01-30 2538 { da5e23f4c7511c Dong Bo 2018-01-30 2539 .module_name = "chip3_sas1", da5e23f4c7511c Dong Bo 2018-01-30 2540 .label = "db", da5e23f4c7511c Dong Bo 2018-01-30 2541 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2542 .dev_num = 0x04, da5e23f4c7511c Dong Bo 2018-01-30 2543 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2544 }, da5e23f4c7511c Dong Bo 2018-01-30 2545 { da5e23f4c7511c Dong Bo 2018-01-30 2546 .module_name = "chip3_sata", da5e23f4c7511c Dong Bo 2018-01-30 2547 .label = "d7", da5e23f4c7511c Dong Bo 2018-01-30 2548 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2549 .dev_num = 0x03, da5e23f4c7511c Dong Bo 2018-01-30 2550 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2551 }, da5e23f4c7511c Dong Bo 2018-01-30 2552 { da5e23f4c7511c Dong Bo 2018-01-30 2553 .module_name = "chip3_zip", da5e23f4c7511c Dong Bo 2018-01-30 2554 .label = "d8", da5e23f4c7511c Dong Bo 2018-01-30 2555 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2556 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2557 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2558 }, da5e23f4c7511c Dong Bo 2018-01-30 2559 { da5e23f4c7511c Dong Bo 2018-01-30 2560 .module_name = "chip3_sec", da5e23f4c7511c Dong Bo 2018-01-30 2561 .label = "d9", da5e23f4c7511c Dong Bo 2018-01-30 2562 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2563 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2564 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2565 }, da5e23f4c7511c Dong Bo 2018-01-30 2566 }; da5e23f4c7511c Dong Bo 2018-01-30 2567 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 12086/30000] drivers/rtc/rtc-mc146818-lib.c:213 mc146818_set_time() error: uninitialized symbol 'save_freq_select'.
by kernel test robot 29 Jan '24

29 Jan '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: bb2503a5fcdf7f51d403ab34440c497acef3b4e7 commit: 31dc30955fcffeb32c96420b91e3c05e2f4614eb [12086/30000] rtc: Fix set RTC time delay 500ms on some Zhaoxin SOCs :::::: branch date: 5 hours ago :::::: commit date: 1 year, 11 months ago config: x86_64-randconfig-161-20240124 (attached as .config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401262043.WarePplV-lkp@intel.com/ smatch warnings: drivers/rtc/rtc-mc146818-lib.c:213 mc146818_set_time() error: uninitialized symbol 'save_freq_select'. vim +/save_freq_select +213 drivers/rtc/rtc-mc146818-lib.c d6faca40f40b62 Arnd Bergmann 2016-06-01 210 d6faca40f40b62 Arnd Bergmann 2016-06-01 211 CMOS_WRITE(save_control, RTC_CONTROL); 31dc30955fcffe LeoLiu-oc 2022-02-23 212 if (follow_mc146818_divider_reset()) d6faca40f40b62 Arnd Bergmann 2016-06-01 @213 CMOS_WRITE(save_freq_select, RTC_FREQ_SELECT); :::::: The code at line 213 was first introduced by commit :::::: d6faca40f40b62aca8ea8c29289c7bf7456172bb rtc: move mc146818 helper functions out-of-line :::::: TO: Arnd Bergmann <arnd(a)arndb.de> :::::: CC: Alexandre Belloni <alexandre.belloni(a)free-electrons.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 3208/21577] kernel/trace/bpf_trace.c:1273:5: sparse: sparse: symbol 'bpf_event_notify' was not declared. Should it be static?
by kernel test robot 29 Jan '24

29 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 992b5fc139d3aa14b25613b06adee4bb9c110b28 commit: 00d0f1b149a5201c072e868915c76f909c11c38f [3208/21577] bpf: support raw tracepoints in modules :::::: branch date: 7 hours ago :::::: commit date: 4 years, 1 month ago config: x86_64-randconfig-123-20240125 (attached as .config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (attached as reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401262122.kgKexAjZ-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> kernel/trace/bpf_trace.c:1273:5: sparse: sparse: symbol 'bpf_event_notify' was not declared. Should it be static? >> kernel/trace/bpf_trace.c:1312:12: sparse: sparse: symbol 'bpf_event_init' was not declared. Should it be static? kernel/trace/bpf_trace.c:173:14: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user *ptr @@ got void *unsafe_ptr @@ kernel/trace/bpf_trace.c:173:14: sparse: expected void const volatile [noderef] __user *ptr kernel/trace/bpf_trace.c:173:14: sparse: got void *unsafe_ptr kernel/trace/bpf_trace.c:1273:5: warning: no previous prototype for function 'bpf_event_notify' [-Wmissing-prototypes] 1273 | int bpf_event_notify(struct notifier_block *nb, unsigned long op, void *module) | ^ kernel/trace/bpf_trace.c:1273:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1273 | int bpf_event_notify(struct notifier_block *nb, unsigned long op, void *module) | ^ | static kernel/trace/bpf_trace.c:1312:12: warning: no previous prototype for function 'bpf_event_init' [-Wmissing-prototypes] 1312 | int __init bpf_event_init(void) | ^ kernel/trace/bpf_trace.c:1312:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1312 | int __init bpf_event_init(void) | ^ | static 2 warnings generated. vim +/bpf_event_notify +1273 kernel/trace/bpf_trace.c 00d0f1b149a520 Matt Mullins 2019-02-19 1271 00d0f1b149a520 Matt Mullins 2019-02-19 1272 #ifdef CONFIG_MODULES 00d0f1b149a520 Matt Mullins 2019-02-19 @1273 int bpf_event_notify(struct notifier_block *nb, unsigned long op, void *module) 00d0f1b149a520 Matt Mullins 2019-02-19 1274 { 00d0f1b149a520 Matt Mullins 2019-02-19 1275 struct bpf_trace_module *btm, *tmp; 00d0f1b149a520 Matt Mullins 2019-02-19 1276 struct module *mod = module; 00d0f1b149a520 Matt Mullins 2019-02-19 1277 00d0f1b149a520 Matt Mullins 2019-02-19 1278 if (mod->num_bpf_raw_events == 0 || 00d0f1b149a520 Matt Mullins 2019-02-19 1279 (op != MODULE_STATE_COMING && op != MODULE_STATE_GOING)) 00d0f1b149a520 Matt Mullins 2019-02-19 1280 return 0; 00d0f1b149a520 Matt Mullins 2019-02-19 1281 00d0f1b149a520 Matt Mullins 2019-02-19 1282 mutex_lock(&bpf_module_mutex); 00d0f1b149a520 Matt Mullins 2019-02-19 1283 00d0f1b149a520 Matt Mullins 2019-02-19 1284 switch (op) { 00d0f1b149a520 Matt Mullins 2019-02-19 1285 case MODULE_STATE_COMING: 00d0f1b149a520 Matt Mullins 2019-02-19 1286 btm = kzalloc(sizeof(*btm), GFP_KERNEL); 00d0f1b149a520 Matt Mullins 2019-02-19 1287 if (btm) { 00d0f1b149a520 Matt Mullins 2019-02-19 1288 btm->module = module; 00d0f1b149a520 Matt Mullins 2019-02-19 1289 list_add(&btm->list, &bpf_trace_modules); 00d0f1b149a520 Matt Mullins 2019-02-19 1290 } 00d0f1b149a520 Matt Mullins 2019-02-19 1291 break; 00d0f1b149a520 Matt Mullins 2019-02-19 1292 case MODULE_STATE_GOING: 00d0f1b149a520 Matt Mullins 2019-02-19 1293 list_for_each_entry_safe(btm, tmp, &bpf_trace_modules, list) { 00d0f1b149a520 Matt Mullins 2019-02-19 1294 if (btm->module == module) { 00d0f1b149a520 Matt Mullins 2019-02-19 1295 list_del(&btm->list); 00d0f1b149a520 Matt Mullins 2019-02-19 1296 kfree(btm); 00d0f1b149a520 Matt Mullins 2019-02-19 1297 break; 00d0f1b149a520 Matt Mullins 2019-02-19 1298 } 00d0f1b149a520 Matt Mullins 2019-02-19 1299 } 00d0f1b149a520 Matt Mullins 2019-02-19 1300 break; 00d0f1b149a520 Matt Mullins 2019-02-19 1301 } 00d0f1b149a520 Matt Mullins 2019-02-19 1302 00d0f1b149a520 Matt Mullins 2019-02-19 1303 mutex_unlock(&bpf_module_mutex); 00d0f1b149a520 Matt Mullins 2019-02-19 1304 00d0f1b149a520 Matt Mullins 2019-02-19 1305 return 0; 00d0f1b149a520 Matt Mullins 2019-02-19 1306 } 00d0f1b149a520 Matt Mullins 2019-02-19 1307 00d0f1b149a520 Matt Mullins 2019-02-19 1308 static struct notifier_block bpf_module_nb = { 00d0f1b149a520 Matt Mullins 2019-02-19 1309 .notifier_call = bpf_event_notify, 00d0f1b149a520 Matt Mullins 2019-02-19 1310 }; 00d0f1b149a520 Matt Mullins 2019-02-19 1311 00d0f1b149a520 Matt Mullins 2019-02-19 @1312 int __init bpf_event_init(void) 00d0f1b149a520 Matt Mullins 2019-02-19 1313 { 00d0f1b149a520 Matt Mullins 2019-02-19 1314 register_module_notifier(&bpf_module_nb); 00d0f1b149a520 Matt Mullins 2019-02-19 1315 return 0; 00d0f1b149a520 Matt Mullins 2019-02-19 1316 } 00d0f1b149a520 Matt Mullins 2019-02-19 1317 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 4369/21577] drivers/scsi/sd.c:1222:32: sparse: sparse: incorrect type in return expression (different base types)
by kernel test robot 29 Jan '24

29 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 992b5fc139d3aa14b25613b06adee4bb9c110b28 commit: d597314e1e561e653a9dbeafec69f20d6b372af1 [4369/21577] scsi: sd: Protect against READ(6) or WRITE(6) with zero block transfer length :::::: branch date: 7 hours ago :::::: commit date: 4 years, 1 month ago config: x86_64-randconfig-121-20240125 (attached as .config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (attached as reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401262223.5mM2ZI39-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/scsi/sd.c:1222:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected int @@ got restricted blk_status_t [usertype] @@ drivers/scsi/sd.c:1222:32: sparse: expected int drivers/scsi/sd.c:1222:32: sparse: got restricted blk_status_t [usertype] In file included from drivers/scsi/sd.c:46: In file included from include/linux/blkdev.h:16: include/linux/pagemap.h:401:21: warning: cast from 'int (*)(struct file *, struct page *)' to 'filler_t *' (aka 'int (*)(void *, struct page *)') converts to incompatible function type [-Wcast-function-type-strict] 401 | filler_t *filler = (filler_t *)mapping->a_ops->readpage; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. vim +1222 drivers/scsi/sd.c 90467c294aba7f FUJITA Tomonori 2010-07-03 1019 87949eee7e1547 Christoph Hellwig 2014-06-28 1020 static int sd_setup_read_write_cmnd(struct scsi_cmnd *SCpnt) ^1da177e4c3f41 Linus Torvalds 2005-04-16 1021 { a1b73fc194e73e Christoph Hellwig 2014-05-01 1022 struct request *rq = SCpnt->request; a1b73fc194e73e Christoph Hellwig 2014-05-01 1023 struct scsi_device *sdp = SCpnt->device; 776b23a0363d99 Christoph Hellwig 2006-01-06 1024 struct gendisk *disk = rq->rq_disk; 89d9475610771b Hannes Reinecke 2016-10-18 1025 struct scsi_disk *sdkp = scsi_disk(disk); 83096ebf1263b2 Tejun Heo 2009-05-07 1026 sector_t block = blk_rq_pos(rq); 18351070b86d15 Linus Torvalds 2008-08-05 1027 sector_t threshold; 83096ebf1263b2 Tejun Heo 2009-05-07 1028 unsigned int this_count = blk_rq_sectors(rq); d597314e1e561e Bart Van Assche 2019-03-23 1029 unsigned int nr_blocks = sectors_to_logical(sdp, blk_rq_sectors(rq)); c611529e7cd346 Martin K. Petersen 2014-09-26 1030 unsigned int dif, dix; c611529e7cd346 Martin K. Petersen 2014-09-26 1031 int ret; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1032 unsigned char protect; 7f9a6bc4e9d59e James Bottomley 2007-08-04 1033 3c356bde19e9a7 Christoph Hellwig 2014-09-05 1034 ret = scsi_init_io(SCpnt); 7f9a6bc4e9d59e James Bottomley 2007-08-04 1035 if (ret != BLKPREP_OK) 39051dd85f2870 Damien Le Moal 2017-12-21 1036 return ret; 0624cbb1e2e64a Bart Van Assche 2017-08-25 1037 WARN_ON_ONCE(SCpnt != rq->special); 7f9a6bc4e9d59e James Bottomley 2007-08-04 1038 7f9a6bc4e9d59e James Bottomley 2007-08-04 1039 /* from here on until we're complete, any goto out 7f9a6bc4e9d59e James Bottomley 2007-08-04 1040 * is used for a killable error condition */ 7f9a6bc4e9d59e James Bottomley 2007-08-04 1041 ret = BLKPREP_KILL; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1042 a1b73fc194e73e Christoph Hellwig 2014-05-01 1043 SCSI_LOG_HLQUEUE(1, a1b73fc194e73e Christoph Hellwig 2014-05-01 1044 scmd_printk(KERN_INFO, SCpnt, a1b73fc194e73e Christoph Hellwig 2014-05-01 1045 "%s: block=%llu, count=%d\n", a1b73fc194e73e Christoph Hellwig 2014-05-01 1046 __func__, (unsigned long long)block, this_count)); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1047 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1048 if (!sdp || !scsi_device_online(sdp) || 83096ebf1263b2 Tejun Heo 2009-05-07 1049 block + blk_rq_sectors(rq) > get_capacity(disk)) { fa0d34be06213e Martin K. Petersen 2007-02-27 1050 SCSI_LOG_HLQUEUE(2, scmd_printk(KERN_INFO, SCpnt, 83096ebf1263b2 Tejun Heo 2009-05-07 1051 "Finishing %u sectors\n", 83096ebf1263b2 Tejun Heo 2009-05-07 1052 blk_rq_sectors(rq))); fa0d34be06213e Martin K. Petersen 2007-02-27 1053 SCSI_LOG_HLQUEUE(2, scmd_printk(KERN_INFO, SCpnt, fa0d34be06213e Martin K. Petersen 2007-02-27 1054 "Retry with 0x%p\n", SCpnt)); 7f9a6bc4e9d59e James Bottomley 2007-08-04 1055 goto out; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1056 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1057 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1058 if (sdp->changed) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 1059 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 1060 * quietly refuse to do anything to a changed disc until ^1da177e4c3f41 Linus Torvalds 2005-04-16 1061 * the changed bit has been reset ^1da177e4c3f41 Linus Torvalds 2005-04-16 1062 */ 3ff5588d3f8afa Alan Stern 2010-09-07 1063 /* printk("SCSI disk has been changed or is not present. Prohibiting further I/O.\n"); */ 7f9a6bc4e9d59e James Bottomley 2007-08-04 1064 goto out; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1065 } 7f9a6bc4e9d59e James Bottomley 2007-08-04 1066 a0899d4df534d2 Hans de Goede 2008-01-20 1067 /* 18351070b86d15 Linus Torvalds 2008-08-05 1068 * Some SD card readers can't handle multi-sector accesses which touch 18351070b86d15 Linus Torvalds 2008-08-05 1069 * the last one or two hardware sectors. Split accesses as needed. a0899d4df534d2 Hans de Goede 2008-01-20 1070 */ 18351070b86d15 Linus Torvalds 2008-08-05 1071 threshold = get_capacity(disk) - SD_LAST_BUGGY_SECTORS * 18351070b86d15 Linus Torvalds 2008-08-05 1072 (sdp->sector_size / 512); 18351070b86d15 Linus Torvalds 2008-08-05 1073 18351070b86d15 Linus Torvalds 2008-08-05 1074 if (unlikely(sdp->last_sector_bug && block + this_count > threshold)) { 18351070b86d15 Linus Torvalds 2008-08-05 1075 if (block < threshold) { 18351070b86d15 Linus Torvalds 2008-08-05 1076 /* Access up to the threshold but not beyond */ 18351070b86d15 Linus Torvalds 2008-08-05 1077 this_count = threshold - block; 18351070b86d15 Linus Torvalds 2008-08-05 1078 } else { 18351070b86d15 Linus Torvalds 2008-08-05 1079 /* Access only a single hardware sector */ 18351070b86d15 Linus Torvalds 2008-08-05 1080 this_count = sdp->sector_size / 512; 18351070b86d15 Linus Torvalds 2008-08-05 1081 } 18351070b86d15 Linus Torvalds 2008-08-05 1082 } a0899d4df534d2 Hans de Goede 2008-01-20 1083 fa0d34be06213e Martin K. Petersen 2007-02-27 1084 SCSI_LOG_HLQUEUE(2, scmd_printk(KERN_INFO, SCpnt, "block=%llu\n", fa0d34be06213e Martin K. Petersen 2007-02-27 1085 (unsigned long long)block)); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1086 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1087 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 1088 * If we have a 1K hardware sectorsize, prevent access to single ^1da177e4c3f41 Linus Torvalds 2005-04-16 1089 * 512 byte sectors. In theory we could handle this - in fact ^1da177e4c3f41 Linus Torvalds 2005-04-16 1090 * the scsi cdrom driver must be able to handle this because ^1da177e4c3f41 Linus Torvalds 2005-04-16 1091 * we typically use 1K blocksizes, and cdroms typically have ^1da177e4c3f41 Linus Torvalds 2005-04-16 1092 * 2K hardware sectorsizes. Of course, things are simpler ^1da177e4c3f41 Linus Torvalds 2005-04-16 1093 * with the cdrom, since it is read-only. For performance ^1da177e4c3f41 Linus Torvalds 2005-04-16 1094 * reasons, the filesystems should be able to handle this ^1da177e4c3f41 Linus Torvalds 2005-04-16 1095 * and not force the scsi disk driver to use bounce buffers ^1da177e4c3f41 Linus Torvalds 2005-04-16 1096 * for this. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1097 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 1098 if (sdp->sector_size == 1024) { 83096ebf1263b2 Tejun Heo 2009-05-07 1099 if ((block & 1) || (blk_rq_sectors(rq) & 1)) { e73aec8247032e Martin K. Petersen 2007-02-27 1100 scmd_printk(KERN_ERR, SCpnt, e73aec8247032e Martin K. Petersen 2007-02-27 1101 "Bad block number requested\n"); 7f9a6bc4e9d59e James Bottomley 2007-08-04 1102 goto out; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1103 } else { ^1da177e4c3f41 Linus Torvalds 2005-04-16 1104 block = block >> 1; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1105 this_count = this_count >> 1; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1106 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1107 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1108 if (sdp->sector_size == 2048) { 83096ebf1263b2 Tejun Heo 2009-05-07 1109 if ((block & 3) || (blk_rq_sectors(rq) & 3)) { e73aec8247032e Martin K. Petersen 2007-02-27 1110 scmd_printk(KERN_ERR, SCpnt, e73aec8247032e Martin K. Petersen 2007-02-27 1111 "Bad block number requested\n"); 7f9a6bc4e9d59e James Bottomley 2007-08-04 1112 goto out; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1113 } else { ^1da177e4c3f41 Linus Torvalds 2005-04-16 1114 block = block >> 2; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1115 this_count = this_count >> 2; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1116 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1117 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1118 if (sdp->sector_size == 4096) { 83096ebf1263b2 Tejun Heo 2009-05-07 1119 if ((block & 7) || (blk_rq_sectors(rq) & 7)) { e73aec8247032e Martin K. Petersen 2007-02-27 1120 scmd_printk(KERN_ERR, SCpnt, e73aec8247032e Martin K. Petersen 2007-02-27 1121 "Bad block number requested\n"); 7f9a6bc4e9d59e James Bottomley 2007-08-04 1122 goto out; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1123 } else { ^1da177e4c3f41 Linus Torvalds 2005-04-16 1124 block = block >> 3; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1125 this_count = this_count >> 3; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1126 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1127 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1128 if (rq_data_dir(rq) == WRITE) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 1129 SCpnt->cmnd[0] = WRITE_6; af55ff675a8461 Martin K. Petersen 2008-07-17 1130 8c579ab69d50a4 Martin K. Petersen 2012-08-28 1131 if (blk_integrity_rq(rq)) 10c41ddd61323b Max Gurtovoy 2018-07-30 1132 t10_pi_prepare(SCpnt->request, sdkp->protection_type); af55ff675a8461 Martin K. Petersen 2008-07-17 1133 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1134 } else if (rq_data_dir(rq) == READ) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 1135 SCpnt->cmnd[0] = READ_6; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1136 } else { ef295ecf090d3e Christoph Hellwig 2016-10-28 1137 scmd_printk(KERN_ERR, SCpnt, "Unknown command %d\n", req_op(rq)); 7f9a6bc4e9d59e James Bottomley 2007-08-04 1138 goto out; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1139 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1140 fa0d34be06213e Martin K. Petersen 2007-02-27 1141 SCSI_LOG_HLQUEUE(2, scmd_printk(KERN_INFO, SCpnt, 83096ebf1263b2 Tejun Heo 2009-05-07 1142 "%s %d/%u 512 byte blocks.\n", fa0d34be06213e Martin K. Petersen 2007-02-27 1143 (rq_data_dir(rq) == WRITE) ? fa0d34be06213e Martin K. Petersen 2007-02-27 1144 "writing" : "reading", this_count, 83096ebf1263b2 Tejun Heo 2009-05-07 1145 blk_rq_sectors(rq))); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1146 c611529e7cd346 Martin K. Petersen 2014-09-26 1147 dix = scsi_prot_sg_count(SCpnt); c611529e7cd346 Martin K. Petersen 2014-09-26 1148 dif = scsi_host_dif_capable(SCpnt->device->host, sdkp->protection_type); c611529e7cd346 Martin K. Petersen 2014-09-26 1149 c611529e7cd346 Martin K. Petersen 2014-09-26 1150 if (dif || dix) c611529e7cd346 Martin K. Petersen 2014-09-26 1151 protect = sd_setup_protect_cmnd(SCpnt, dix, dif); af55ff675a8461 Martin K. Petersen 2008-07-17 1152 else 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1153 protect = 0; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1154 8475c8118551f8 Christoph Hellwig 2016-09-11 1155 if (protect && sdkp->protection_type == T10_PI_TYPE2_PROTECTION) { 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1156 SCpnt->cmnd = mempool_alloc(sd_cdb_pool, GFP_ATOMIC); 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1157 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1158 if (unlikely(SCpnt->cmnd == NULL)) { 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1159 ret = BLKPREP_DEFER; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1160 goto out; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1161 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1162 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1163 SCpnt->cmd_len = SD_EXT_CDB_SIZE; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1164 memset(SCpnt->cmnd, 0, SCpnt->cmd_len); 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1165 SCpnt->cmnd[0] = VARIABLE_LENGTH_CMD; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1166 SCpnt->cmnd[7] = 0x18; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1167 SCpnt->cmnd[9] = (rq_data_dir(rq) == READ) ? READ_32 : WRITE_32; 33659ebbae2622 Christoph Hellwig 2010-08-07 1168 SCpnt->cmnd[10] = protect | ((rq->cmd_flags & REQ_FUA) ? 0x8 : 0); 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1169 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1170 /* LBA */ 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1171 SCpnt->cmnd[12] = sizeof(block) > 4 ? (unsigned char) (block >> 56) & 0xff : 0; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1172 SCpnt->cmnd[13] = sizeof(block) > 4 ? (unsigned char) (block >> 48) & 0xff : 0; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1173 SCpnt->cmnd[14] = sizeof(block) > 4 ? (unsigned char) (block >> 40) & 0xff : 0; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1174 SCpnt->cmnd[15] = sizeof(block) > 4 ? (unsigned char) (block >> 32) & 0xff : 0; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1175 SCpnt->cmnd[16] = (unsigned char) (block >> 24) & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1176 SCpnt->cmnd[17] = (unsigned char) (block >> 16) & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1177 SCpnt->cmnd[18] = (unsigned char) (block >> 8) & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1178 SCpnt->cmnd[19] = (unsigned char) block & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1179 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1180 /* Expected Indirect LBA */ 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1181 SCpnt->cmnd[20] = (unsigned char) (block >> 24) & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1182 SCpnt->cmnd[21] = (unsigned char) (block >> 16) & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1183 SCpnt->cmnd[22] = (unsigned char) (block >> 8) & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1184 SCpnt->cmnd[23] = (unsigned char) block & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1185 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1186 /* Transfer length */ 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1187 SCpnt->cmnd[28] = (unsigned char) (this_count >> 24) & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1188 SCpnt->cmnd[29] = (unsigned char) (this_count >> 16) & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1189 SCpnt->cmnd[30] = (unsigned char) (this_count >> 8) & 0xff; 4e7392ec582cf0 Martin K. Petersen 2009-09-20 1190 SCpnt->cmnd[31] = (unsigned char) this_count & 0xff; e430cbc8bbd779 Akinobu Mita 2014-06-02 1191 } else if (sdp->use_16_for_rw || (this_count > 0xffff)) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 1192 SCpnt->cmnd[0] += READ_16 - READ_6; 33659ebbae2622 Christoph Hellwig 2010-08-07 1193 SCpnt->cmnd[1] = protect | ((rq->cmd_flags & REQ_FUA) ? 0x8 : 0); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1194 SCpnt->cmnd[2] = sizeof(block) > 4 ? (unsigned char) (block >> 56) & 0xff : 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1195 SCpnt->cmnd[3] = sizeof(block) > 4 ? (unsigned char) (block >> 48) & 0xff : 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1196 SCpnt->cmnd[4] = sizeof(block) > 4 ? (unsigned char) (block >> 40) & 0xff : 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1197 SCpnt->cmnd[5] = sizeof(block) > 4 ? (unsigned char) (block >> 32) & 0xff : 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1198 SCpnt->cmnd[6] = (unsigned char) (block >> 24) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1199 SCpnt->cmnd[7] = (unsigned char) (block >> 16) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1200 SCpnt->cmnd[8] = (unsigned char) (block >> 8) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1201 SCpnt->cmnd[9] = (unsigned char) block & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1202 SCpnt->cmnd[10] = (unsigned char) (this_count >> 24) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1203 SCpnt->cmnd[11] = (unsigned char) (this_count >> 16) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1204 SCpnt->cmnd[12] = (unsigned char) (this_count >> 8) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1205 SCpnt->cmnd[13] = (unsigned char) this_count & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1206 SCpnt->cmnd[14] = SCpnt->cmnd[15] = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1207 } else if ((this_count > 0xff) || (block > 0x1fffff) || af55ff675a8461 Martin K. Petersen 2008-07-17 1208 scsi_device_protection(SCpnt->device) || ^1da177e4c3f41 Linus Torvalds 2005-04-16 1209 SCpnt->device->use_10_for_rw) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 1210 SCpnt->cmnd[0] += READ_10 - READ_6; 33659ebbae2622 Christoph Hellwig 2010-08-07 1211 SCpnt->cmnd[1] = protect | ((rq->cmd_flags & REQ_FUA) ? 0x8 : 0); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1212 SCpnt->cmnd[2] = (unsigned char) (block >> 24) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1213 SCpnt->cmnd[3] = (unsigned char) (block >> 16) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1214 SCpnt->cmnd[4] = (unsigned char) (block >> 8) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1215 SCpnt->cmnd[5] = (unsigned char) block & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1216 SCpnt->cmnd[6] = SCpnt->cmnd[9] = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1217 SCpnt->cmnd[7] = (unsigned char) (this_count >> 8) & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1218 SCpnt->cmnd[8] = (unsigned char) this_count & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1219 } else { d597314e1e561e Bart Van Assche 2019-03-23 1220 /* Avoid that 0 blocks gets translated into 256 blocks. */ d597314e1e561e Bart Van Assche 2019-03-23 1221 if (WARN_ON_ONCE(nr_blocks == 0)) d597314e1e561e Bart Van Assche 2019-03-23 @1222 return BLK_STS_IOERR; d597314e1e561e Bart Van Assche 2019-03-23 1223 33659ebbae2622 Christoph Hellwig 2010-08-07 1224 if (unlikely(rq->cmd_flags & REQ_FUA)) { 007365ad60387d Tejun Heo 2006-01-06 1225 /* 007365ad60387d Tejun Heo 2006-01-06 1226 * This happens only if this drive failed 007365ad60387d Tejun Heo 2006-01-06 1227 * 10byte rw command with ILLEGAL_REQUEST 007365ad60387d Tejun Heo 2006-01-06 1228 * during operation and thus turned off 007365ad60387d Tejun Heo 2006-01-06 1229 * use_10_for_rw. 007365ad60387d Tejun Heo 2006-01-06 1230 */ e73aec8247032e Martin K. Petersen 2007-02-27 1231 scmd_printk(KERN_ERR, SCpnt, e73aec8247032e Martin K. Petersen 2007-02-27 1232 "FUA write on READ/WRITE(6) drive\n"); 7f9a6bc4e9d59e James Bottomley 2007-08-04 1233 goto out; 007365ad60387d Tejun Heo 2006-01-06 1234 } 007365ad60387d Tejun Heo 2006-01-06 1235 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1236 SCpnt->cmnd[1] |= (unsigned char) ((block >> 16) & 0x1f); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1237 SCpnt->cmnd[2] = (unsigned char) ((block >> 8) & 0xff); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1238 SCpnt->cmnd[3] = (unsigned char) block & 0xff; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1239 SCpnt->cmnd[4] = (unsigned char) this_count; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1240 SCpnt->cmnd[5] = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1241 } 30b0c37b27485a Boaz Harrosh 2007-12-13 1242 SCpnt->sdb.length = this_count * sdp->sector_size; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1243 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1244 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 1245 * We shouldn't disconnect in the middle of a sector, so with a dumb ^1da177e4c3f41 Linus Torvalds 2005-04-16 1246 * host adapter, it's safe to assume that we can at least transfer ^1da177e4c3f41 Linus Torvalds 2005-04-16 1247 * this many bytes between each connect / disconnect. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1248 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 1249 SCpnt->transfersize = sdp->sector_size; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1250 SCpnt->underflow = this_count << 9; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1251 SCpnt->allowed = SD_MAX_RETRIES; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1252 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1253 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 1254 * This indicates that the command is ready from our end to be ^1da177e4c3f41 Linus Torvalds 2005-04-16 1255 * queued. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1256 */ 7f9a6bc4e9d59e James Bottomley 2007-08-04 1257 ret = BLKPREP_OK; 7f9a6bc4e9d59e James Bottomley 2007-08-04 1258 out: a1b73fc194e73e Christoph Hellwig 2014-05-01 1259 return ret; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1260 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1261 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1581/21579] drivers/pci/probe.c:2223:3: sparse: sparse: symbol 'skip_1620_bus_num' was not declared. Should it be static?
by kernel test robot 29 Jan '24

29 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: acf72db532a7791fde53af3dc7b4d0a6adcf6eff commit: da5e23f4c7511cbc1a199bb4d5d5477e191dc26c [1581/21579] Hi1620 CS FPGA PCIe Skip Bus :::::: branch date: 2 days ago :::::: commit date: 4 years, 1 month ago config: x86_64-randconfig-121-20240125 (attached as .config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (attached as reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401290427.eM9fDHDi-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/pci/probe.c:2223:3: sparse: sparse: symbol 'skip_1620_bus_num' was not declared. Should it be static? drivers/pci/probe.c:448:21: sparse: sparse: self-comparison always evaluates to false vim +/skip_1620_bus_num +2223 drivers/pci/probe.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 2214 da5e23f4c7511c Dong Bo 2018-01-30 2215 static int skip_bus_flag = 0; da5e23f4c7511c Dong Bo 2018-01-30 2216 #define HOSTBRIGE_1620_NUM 48 da5e23f4c7511c Dong Bo 2018-01-30 2217 struct skip_bus_num { da5e23f4c7511c Dong Bo 2018-01-30 2218 char module_name[32]; da5e23f4c7511c Dong Bo 2018-01-30 2219 char label[4]; da5e23f4c7511c Dong Bo 2018-01-30 2220 int bus_num; da5e23f4c7511c Dong Bo 2018-01-30 2221 int dev_num; da5e23f4c7511c Dong Bo 2018-01-30 2222 int skip; da5e23f4c7511c Dong Bo 2018-01-30 @2223 } skip_1620_bus_num[HOSTBRIGE_1620_NUM] = { da5e23f4c7511c Dong Bo 2018-01-30 2224 /*chip 0*/ da5e23f4c7511c Dong Bo 2018-01-30 2225 { da5e23f4c7511c Dong Bo 2018-01-30 2226 .module_name = "chip0_pcie", da5e23f4c7511c Dong Bo 2018-01-30 2227 .label = "a0", da5e23f4c7511c Dong Bo 2018-01-30 2228 .bus_num = 0, da5e23f4c7511c Dong Bo 2018-01-30 2229 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2230 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2231 }, da5e23f4c7511c Dong Bo 2018-01-30 2232 { da5e23f4c7511c Dong Bo 2018-01-30 2233 .module_name = "chip0_pcie_dma", da5e23f4c7511c Dong Bo 2018-01-30 2234 .label = "a1", da5e23f4c7511c Dong Bo 2018-01-30 2235 .bus_num = 0x7b, da5e23f4c7511c Dong Bo 2018-01-30 2236 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2237 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2238 }, da5e23f4c7511c Dong Bo 2018-01-30 2239 { da5e23f4c7511c Dong Bo 2018-01-30 2240 .module_name = "chip0_pcie_sdi", da5e23f4c7511c Dong Bo 2018-01-30 2241 .label = "a2", da5e23f4c7511c Dong Bo 2018-01-30 2242 .bus_num = 0x7b, da5e23f4c7511c Dong Bo 2018-01-30 2243 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2244 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2245 }, da5e23f4c7511c Dong Bo 2018-01-30 2246 { da5e23f4c7511c Dong Bo 2018-01-30 2247 .module_name = "chip0_USB", da5e23f4c7511c Dong Bo 2018-01-30 2248 .label = "a3", da5e23f4c7511c Dong Bo 2018-01-30 2249 .bus_num = 0x7a, da5e23f4c7511c Dong Bo 2018-01-30 2250 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2251 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2252 }, da5e23f4c7511c Dong Bo 2018-01-30 2253 { da5e23f4c7511c Dong Bo 2018-01-30 2254 .module_name = "chip0_hpre", da5e23f4c7511c Dong Bo 2018-01-30 2255 .label = "a4", da5e23f4c7511c Dong Bo 2018-01-30 2256 .bus_num = 0x78, da5e23f4c7511c Dong Bo 2018-01-30 2257 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2258 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2259 }, da5e23f4c7511c Dong Bo 2018-01-30 2260 { da5e23f4c7511c Dong Bo 2018-01-30 2261 .module_name = "chip0_rde", da5e23f4c7511c Dong Bo 2018-01-30 2262 .label = "a5", da5e23f4c7511c Dong Bo 2018-01-30 2263 .bus_num = 0x78, da5e23f4c7511c Dong Bo 2018-01-30 2264 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2265 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2266 }, da5e23f4c7511c Dong Bo 2018-01-30 2267 { da5e23f4c7511c Dong Bo 2018-01-30 2268 .module_name = "chip0_nic", da5e23f4c7511c Dong Bo 2018-01-30 2269 .label = "aa", da5e23f4c7511c Dong Bo 2018-01-30 2270 .bus_num = 0x7c, da5e23f4c7511c Dong Bo 2018-01-30 2271 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2272 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2273 }, da5e23f4c7511c Dong Bo 2018-01-30 2274 { da5e23f4c7511c Dong Bo 2018-01-30 2275 .module_name = "chip0_sas", da5e23f4c7511c Dong Bo 2018-01-30 2276 .label = "a6", da5e23f4c7511c Dong Bo 2018-01-30 2277 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2278 .dev_num = 0x02, da5e23f4c7511c Dong Bo 2018-01-30 2279 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2280 }, da5e23f4c7511c Dong Bo 2018-01-30 2281 { da5e23f4c7511c Dong Bo 2018-01-30 2282 .module_name = "chip0_sas1", da5e23f4c7511c Dong Bo 2018-01-30 2283 .label = "ab", da5e23f4c7511c Dong Bo 2018-01-30 2284 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2285 .dev_num = 0x04, da5e23f4c7511c Dong Bo 2018-01-30 2286 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2287 }, da5e23f4c7511c Dong Bo 2018-01-30 2288 { da5e23f4c7511c Dong Bo 2018-01-30 2289 .module_name = "chip0_sata", da5e23f4c7511c Dong Bo 2018-01-30 2290 .label = "a7", da5e23f4c7511c Dong Bo 2018-01-30 2291 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2292 .dev_num = 0x03, da5e23f4c7511c Dong Bo 2018-01-30 2293 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2294 }, da5e23f4c7511c Dong Bo 2018-01-30 2295 { da5e23f4c7511c Dong Bo 2018-01-30 2296 .module_name = "chip0_zip", da5e23f4c7511c Dong Bo 2018-01-30 2297 .label = "a8", da5e23f4c7511c Dong Bo 2018-01-30 2298 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2299 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2300 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2301 }, da5e23f4c7511c Dong Bo 2018-01-30 2302 { da5e23f4c7511c Dong Bo 2018-01-30 2303 .module_name = "chip0_sec", da5e23f4c7511c Dong Bo 2018-01-30 2304 .label = "a9", da5e23f4c7511c Dong Bo 2018-01-30 2305 .bus_num = 0x74, da5e23f4c7511c Dong Bo 2018-01-30 2306 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2307 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2308 }, da5e23f4c7511c Dong Bo 2018-01-30 2309 /*chip 1*/ da5e23f4c7511c Dong Bo 2018-01-30 2310 { da5e23f4c7511c Dong Bo 2018-01-30 2311 .module_name = "chip1_pcie", da5e23f4c7511c Dong Bo 2018-01-30 2312 .label = "b0", da5e23f4c7511c Dong Bo 2018-01-30 2313 .bus_num = 0x80, da5e23f4c7511c Dong Bo 2018-01-30 2314 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2315 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2316 }, da5e23f4c7511c Dong Bo 2018-01-30 2317 { da5e23f4c7511c Dong Bo 2018-01-30 2318 .module_name = "chip1_pcie_dma", da5e23f4c7511c Dong Bo 2018-01-30 2319 .label = "b1", da5e23f4c7511c Dong Bo 2018-01-30 2320 .bus_num = 0xbb, da5e23f4c7511c Dong Bo 2018-01-30 2321 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2322 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2323 }, da5e23f4c7511c Dong Bo 2018-01-30 2324 { da5e23f4c7511c Dong Bo 2018-01-30 2325 .module_name = "chip1_pcie_sdi", da5e23f4c7511c Dong Bo 2018-01-30 2326 .label = "b2", da5e23f4c7511c Dong Bo 2018-01-30 2327 .bus_num = 0xbb, da5e23f4c7511c Dong Bo 2018-01-30 2328 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2329 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2330 }, da5e23f4c7511c Dong Bo 2018-01-30 2331 { da5e23f4c7511c Dong Bo 2018-01-30 2332 .module_name = "chip1_USB", da5e23f4c7511c Dong Bo 2018-01-30 2333 .label = "b3", da5e23f4c7511c Dong Bo 2018-01-30 2334 .bus_num = 0xba, da5e23f4c7511c Dong Bo 2018-01-30 2335 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2336 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2337 }, da5e23f4c7511c Dong Bo 2018-01-30 2338 { da5e23f4c7511c Dong Bo 2018-01-30 2339 .module_name = "chip1_hpre", da5e23f4c7511c Dong Bo 2018-01-30 2340 .label = "b4", da5e23f4c7511c Dong Bo 2018-01-30 2341 .bus_num = 0xb8, da5e23f4c7511c Dong Bo 2018-01-30 2342 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2343 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2344 }, da5e23f4c7511c Dong Bo 2018-01-30 2345 { da5e23f4c7511c Dong Bo 2018-01-30 2346 .module_name = "chip1_rde", da5e23f4c7511c Dong Bo 2018-01-30 2347 .label = "b5", da5e23f4c7511c Dong Bo 2018-01-30 2348 .bus_num = 0xb8, da5e23f4c7511c Dong Bo 2018-01-30 2349 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2350 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2351 }, da5e23f4c7511c Dong Bo 2018-01-30 2352 { da5e23f4c7511c Dong Bo 2018-01-30 2353 .module_name = "chip1_nic", da5e23f4c7511c Dong Bo 2018-01-30 2354 .label = "ba", da5e23f4c7511c Dong Bo 2018-01-30 2355 .bus_num = 0xbc, da5e23f4c7511c Dong Bo 2018-01-30 2356 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2357 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2358 }, da5e23f4c7511c Dong Bo 2018-01-30 2359 { da5e23f4c7511c Dong Bo 2018-01-30 2360 .module_name = "chip1_sas", da5e23f4c7511c Dong Bo 2018-01-30 2361 .label = "b6", da5e23f4c7511c Dong Bo 2018-01-30 2362 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2363 .dev_num = 0x02, da5e23f4c7511c Dong Bo 2018-01-30 2364 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2365 }, da5e23f4c7511c Dong Bo 2018-01-30 2366 { da5e23f4c7511c Dong Bo 2018-01-30 2367 .module_name = "chip1_sas1", da5e23f4c7511c Dong Bo 2018-01-30 2368 .label = "bb", da5e23f4c7511c Dong Bo 2018-01-30 2369 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2370 .dev_num = 0x04, da5e23f4c7511c Dong Bo 2018-01-30 2371 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2372 }, da5e23f4c7511c Dong Bo 2018-01-30 2373 { da5e23f4c7511c Dong Bo 2018-01-30 2374 .module_name = "chip1_sata", da5e23f4c7511c Dong Bo 2018-01-30 2375 .label = "b7", da5e23f4c7511c Dong Bo 2018-01-30 2376 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2377 .dev_num = 0x03, da5e23f4c7511c Dong Bo 2018-01-30 2378 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2379 }, da5e23f4c7511c Dong Bo 2018-01-30 2380 { da5e23f4c7511c Dong Bo 2018-01-30 2381 .module_name = "chip1_zip", da5e23f4c7511c Dong Bo 2018-01-30 2382 .label = "b8", da5e23f4c7511c Dong Bo 2018-01-30 2383 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2384 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2385 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2386 }, da5e23f4c7511c Dong Bo 2018-01-30 2387 { da5e23f4c7511c Dong Bo 2018-01-30 2388 .module_name = "chip0_sec", da5e23f4c7511c Dong Bo 2018-01-30 2389 .label = "b9", da5e23f4c7511c Dong Bo 2018-01-30 2390 .bus_num = 0xb4, da5e23f4c7511c Dong Bo 2018-01-30 2391 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2392 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2393 }, da5e23f4c7511c Dong Bo 2018-01-30 2394 da5e23f4c7511c Dong Bo 2018-01-30 2395 /*chip 2*/ da5e23f4c7511c Dong Bo 2018-01-30 2396 { da5e23f4c7511c Dong Bo 2018-01-30 2397 .module_name = "chip2_pcie", da5e23f4c7511c Dong Bo 2018-01-30 2398 .label = "c0", da5e23f4c7511c Dong Bo 2018-01-30 2399 .bus_num = 0xc0, da5e23f4c7511c Dong Bo 2018-01-30 2400 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2401 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2402 }, da5e23f4c7511c Dong Bo 2018-01-30 2403 { da5e23f4c7511c Dong Bo 2018-01-30 2404 .module_name = "chip2_pcie_dma", da5e23f4c7511c Dong Bo 2018-01-30 2405 .label = "c1", da5e23f4c7511c Dong Bo 2018-01-30 2406 .bus_num = 0xdb, da5e23f4c7511c Dong Bo 2018-01-30 2407 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2408 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2409 }, da5e23f4c7511c Dong Bo 2018-01-30 2410 { da5e23f4c7511c Dong Bo 2018-01-30 2411 .module_name = "chip2_pcie_sdi", da5e23f4c7511c Dong Bo 2018-01-30 2412 .label = "c2", da5e23f4c7511c Dong Bo 2018-01-30 2413 .bus_num = 0xdb, da5e23f4c7511c Dong Bo 2018-01-30 2414 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2415 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2416 }, da5e23f4c7511c Dong Bo 2018-01-30 2417 { da5e23f4c7511c Dong Bo 2018-01-30 2418 .module_name = "chip2_USB", da5e23f4c7511c Dong Bo 2018-01-30 2419 .label = "c3", da5e23f4c7511c Dong Bo 2018-01-30 2420 .bus_num = 0xda, da5e23f4c7511c Dong Bo 2018-01-30 2421 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2422 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2423 }, da5e23f4c7511c Dong Bo 2018-01-30 2424 { da5e23f4c7511c Dong Bo 2018-01-30 2425 .module_name = "chip2_hpre", da5e23f4c7511c Dong Bo 2018-01-30 2426 .label = "c4", da5e23f4c7511c Dong Bo 2018-01-30 2427 .bus_num = 0xd8, da5e23f4c7511c Dong Bo 2018-01-30 2428 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2429 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2430 }, da5e23f4c7511c Dong Bo 2018-01-30 2431 { da5e23f4c7511c Dong Bo 2018-01-30 2432 .module_name = "chip2_rde", da5e23f4c7511c Dong Bo 2018-01-30 2433 .label = "c5", da5e23f4c7511c Dong Bo 2018-01-30 2434 .bus_num = 0xd8, da5e23f4c7511c Dong Bo 2018-01-30 2435 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2436 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2437 }, da5e23f4c7511c Dong Bo 2018-01-30 2438 { da5e23f4c7511c Dong Bo 2018-01-30 2439 .module_name = "chip2_nic", da5e23f4c7511c Dong Bo 2018-01-30 2440 .label = "ca", da5e23f4c7511c Dong Bo 2018-01-30 2441 .bus_num = 0xdc, da5e23f4c7511c Dong Bo 2018-01-30 2442 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2443 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2444 }, da5e23f4c7511c Dong Bo 2018-01-30 2445 { da5e23f4c7511c Dong Bo 2018-01-30 2446 .module_name = "chip2_sas", da5e23f4c7511c Dong Bo 2018-01-30 2447 .label = "c6", da5e23f4c7511c Dong Bo 2018-01-30 2448 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2449 .dev_num = 0x02, da5e23f4c7511c Dong Bo 2018-01-30 2450 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2451 }, da5e23f4c7511c Dong Bo 2018-01-30 2452 { da5e23f4c7511c Dong Bo 2018-01-30 2453 .module_name = "chip2_sas1", da5e23f4c7511c Dong Bo 2018-01-30 2454 .label = "cb", da5e23f4c7511c Dong Bo 2018-01-30 2455 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2456 .dev_num = 0x04, da5e23f4c7511c Dong Bo 2018-01-30 2457 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2458 }, da5e23f4c7511c Dong Bo 2018-01-30 2459 { da5e23f4c7511c Dong Bo 2018-01-30 2460 .module_name = "chip2_sata", da5e23f4c7511c Dong Bo 2018-01-30 2461 .label = "c7", da5e23f4c7511c Dong Bo 2018-01-30 2462 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2463 .dev_num = 0x03, da5e23f4c7511c Dong Bo 2018-01-30 2464 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2465 }, da5e23f4c7511c Dong Bo 2018-01-30 2466 { da5e23f4c7511c Dong Bo 2018-01-30 2467 .module_name = "chip2_zip", da5e23f4c7511c Dong Bo 2018-01-30 2468 .label = "c8", da5e23f4c7511c Dong Bo 2018-01-30 2469 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2470 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2471 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2472 }, da5e23f4c7511c Dong Bo 2018-01-30 2473 { da5e23f4c7511c Dong Bo 2018-01-30 2474 .module_name = "chip2_sec", da5e23f4c7511c Dong Bo 2018-01-30 2475 .label = "c9", da5e23f4c7511c Dong Bo 2018-01-30 2476 .bus_num = 0xd4, da5e23f4c7511c Dong Bo 2018-01-30 2477 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2478 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2479 }, da5e23f4c7511c Dong Bo 2018-01-30 2480 da5e23f4c7511c Dong Bo 2018-01-30 2481 /*chip 3*/ da5e23f4c7511c Dong Bo 2018-01-30 2482 { da5e23f4c7511c Dong Bo 2018-01-30 2483 .module_name = "chip3_pcie", da5e23f4c7511c Dong Bo 2018-01-30 2484 .label = "d0", da5e23f4c7511c Dong Bo 2018-01-30 2485 .bus_num = 0xe0, da5e23f4c7511c Dong Bo 2018-01-30 2486 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2487 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2488 }, da5e23f4c7511c Dong Bo 2018-01-30 2489 { da5e23f4c7511c Dong Bo 2018-01-30 2490 .module_name = "chip3_pcie_dma", da5e23f4c7511c Dong Bo 2018-01-30 2491 .label = "d1", da5e23f4c7511c Dong Bo 2018-01-30 2492 .bus_num = 0xfb, da5e23f4c7511c Dong Bo 2018-01-30 2493 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2494 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2495 }, da5e23f4c7511c Dong Bo 2018-01-30 2496 { da5e23f4c7511c Dong Bo 2018-01-30 2497 .module_name = "chip3_pcie_sdi", da5e23f4c7511c Dong Bo 2018-01-30 2498 .label = "d2", da5e23f4c7511c Dong Bo 2018-01-30 2499 .bus_num = 0xfb, da5e23f4c7511c Dong Bo 2018-01-30 2500 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2501 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2502 }, da5e23f4c7511c Dong Bo 2018-01-30 2503 { da5e23f4c7511c Dong Bo 2018-01-30 2504 .module_name = "chip3_USB", da5e23f4c7511c Dong Bo 2018-01-30 2505 .label = "d3", da5e23f4c7511c Dong Bo 2018-01-30 2506 .bus_num = 0xfa, da5e23f4c7511c Dong Bo 2018-01-30 2507 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2508 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2509 }, da5e23f4c7511c Dong Bo 2018-01-30 2510 { da5e23f4c7511c Dong Bo 2018-01-30 2511 .module_name = "chip3_hpre", da5e23f4c7511c Dong Bo 2018-01-30 2512 .label = "d4", da5e23f4c7511c Dong Bo 2018-01-30 2513 .bus_num = 0xf8, da5e23f4c7511c Dong Bo 2018-01-30 2514 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2515 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2516 }, da5e23f4c7511c Dong Bo 2018-01-30 2517 { da5e23f4c7511c Dong Bo 2018-01-30 2518 .module_name = "chip3_rde", da5e23f4c7511c Dong Bo 2018-01-30 2519 .label = "d5", da5e23f4c7511c Dong Bo 2018-01-30 2520 .bus_num = 0xf8, da5e23f4c7511c Dong Bo 2018-01-30 2521 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2522 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2523 }, da5e23f4c7511c Dong Bo 2018-01-30 2524 { da5e23f4c7511c Dong Bo 2018-01-30 2525 .module_name = "chip3_nic", da5e23f4c7511c Dong Bo 2018-01-30 2526 .label = "da", da5e23f4c7511c Dong Bo 2018-01-30 2527 .bus_num = 0xfc, da5e23f4c7511c Dong Bo 2018-01-30 2528 .dev_num = 0xff, da5e23f4c7511c Dong Bo 2018-01-30 2529 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2530 }, da5e23f4c7511c Dong Bo 2018-01-30 2531 { da5e23f4c7511c Dong Bo 2018-01-30 2532 .module_name = "chip3_sas", da5e23f4c7511c Dong Bo 2018-01-30 2533 .label = "d6", da5e23f4c7511c Dong Bo 2018-01-30 2534 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2535 .dev_num = 0x02, da5e23f4c7511c Dong Bo 2018-01-30 2536 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2537 }, da5e23f4c7511c Dong Bo 2018-01-30 2538 { da5e23f4c7511c Dong Bo 2018-01-30 2539 .module_name = "chip3_sas1", da5e23f4c7511c Dong Bo 2018-01-30 2540 .label = "db", da5e23f4c7511c Dong Bo 2018-01-30 2541 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2542 .dev_num = 0x04, da5e23f4c7511c Dong Bo 2018-01-30 2543 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2544 }, da5e23f4c7511c Dong Bo 2018-01-30 2545 { da5e23f4c7511c Dong Bo 2018-01-30 2546 .module_name = "chip3_sata", da5e23f4c7511c Dong Bo 2018-01-30 2547 .label = "d7", da5e23f4c7511c Dong Bo 2018-01-30 2548 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2549 .dev_num = 0x03, da5e23f4c7511c Dong Bo 2018-01-30 2550 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2551 }, da5e23f4c7511c Dong Bo 2018-01-30 2552 { da5e23f4c7511c Dong Bo 2018-01-30 2553 .module_name = "chip3_zip", da5e23f4c7511c Dong Bo 2018-01-30 2554 .label = "d8", da5e23f4c7511c Dong Bo 2018-01-30 2555 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2556 .dev_num = 0x0, da5e23f4c7511c Dong Bo 2018-01-30 2557 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2558 }, da5e23f4c7511c Dong Bo 2018-01-30 2559 { da5e23f4c7511c Dong Bo 2018-01-30 2560 .module_name = "chip3_sec", da5e23f4c7511c Dong Bo 2018-01-30 2561 .label = "d9", da5e23f4c7511c Dong Bo 2018-01-30 2562 .bus_num = 0xf4, da5e23f4c7511c Dong Bo 2018-01-30 2563 .dev_num = 0x1, da5e23f4c7511c Dong Bo 2018-01-30 2564 .skip = 0 da5e23f4c7511c Dong Bo 2018-01-30 2565 }, da5e23f4c7511c Dong Bo 2018-01-30 2566 }; da5e23f4c7511c Dong Bo 2018-01-30 2567 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 v3 0/2] KABI reservation for IMA and crypto
by GUO Zihua 29 Jan '24

29 Jan '24

KABI reservation for IMA and crypto module. v3: Reserve one more u64 for crypto related structs. v2: Changed reservation ordering, and more reservation. GUO Zihua (2): crypto: kabi: KABI reservation for crypto ima: kabi: KABI reservation for IMA include/crypto/aead.h | 7 +++++++ include/crypto/akcipher.h | 7 +++++++ include/crypto/algapi.h | 7 +++++++ include/crypto/cryptd.h | 3 +++ include/crypto/hash.h | 9 +++++++++ include/crypto/if_alg.h | 9 +++++++++ include/crypto/public_key.h | 5 +++++ include/crypto/rng.h | 5 +++++ include/crypto/skcipher.h | 7 +++++++ include/linux/crypto.h | 5 +++++ include/linux/fs.h | 5 +++++ include/linux/kernel_read_file.h | 3 +++ include/linux/kexec.h | 5 +++++ include/linux/user_namespace.h | 3 +++ 14 files changed, 80 insertions(+) -- 2.34.1

1 2

[PATCH OLK-6.6] iommu/iova: avoid softlockup in fq_flush_timeout
by Zhang Zekun 29 Jan '24

29 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZE0I CVE: NA --------------------------------- There is softlockup under fio pressure test with smmu enabled: watchdog: BUG: soft lockup - CPU#81 stuck for 22s! [swapper/81:0] ... Call trace: fq_flush_timeout+0xc0/0x110 call_timer_fn+0x34/0x178 expire_timers+0xec/0x158 run_timer_softirq+0xc0/0x1f8 __do_softirq+0x120/0x324 irq_exit+0x11c/0x140 __handle_domain_irq+0x6c/0xc0 gic_handle_irq+0x6c/0x170 el1_irq+0xb8/0x140 arch_cpu_idle+0x38/0x1c0 default_idle_call+0x24/0x44 do_idle+0x1f4/0x2d8 cpu_startup_entry+0x2c/0x30 secondary_start_kernel+0x17c/0x1c8 This is because the timer callback fq_flush_timeout may run more than 10ms, and timer may be processed continuously in the softirq so trigger softlockup. We can use work to deal with fq_ring_free for each cpu which may take long time, that to avoid triggering softlockup. Signed-off-by: Li Bin <huawei.libin(a)huawei.com> Signed-off-by: Peng Wu <wupeng58(a)huawei.com> Signed-off-by: Zhang Zekun <zhangzekun11(a)huawei.com> --- drivers/iommu/dma-iommu.c | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 4b1a88f514c9..b144ce2b2915 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -68,6 +68,8 @@ struct iommu_dma_cookie { /* Domain for flush queue callback; NULL if flush queue not in use */ struct iommu_domain *fq_domain; struct mutex mutex; + + struct work_struct free_iova_work; }; static DEFINE_STATIC_KEY_FALSE(iommu_deferred_attach_enabled); @@ -155,20 +157,11 @@ static void fq_flush_iotlb(struct iommu_dma_cookie *cookie) static void fq_flush_timeout(struct timer_list *t) { struct iommu_dma_cookie *cookie = from_timer(cookie, t, fq_timer); - int cpu; atomic_set(&cookie->fq_timer_on, 0); fq_flush_iotlb(cookie); - for_each_possible_cpu(cpu) { - unsigned long flags; - struct iova_fq *fq; - - fq = per_cpu_ptr(cookie->fq, cpu); - spin_lock_irqsave(&fq->lock, flags); - fq_ring_free(cookie, fq); - spin_unlock_irqrestore(&fq->lock, flags); - } + schedule_work(&cookie->free_iova_work); } static void queue_iova(struct iommu_dma_cookie *cookie, @@ -235,9 +228,28 @@ static void iommu_dma_free_fq(struct iommu_dma_cookie *cookie) put_pages_list(&fq->entries[idx].freelist); } + flush_work(&cookie->free_iova_work); free_percpu(cookie->fq); } +static void free_iova_work_func(struct work_struct *work) +{ + struct iommu_dma_cookie *cookie; + int cpu; + + cookie = container_of(work, struct iommu_dma_cookie, free_iova_work); + for_each_possible_cpu(cpu) { + unsigned long flags; + struct iova_fq *fq; + + fq = per_cpu_ptr(cookie->fq, cpu); + spin_lock_irqsave(&fq->lock, flags); + fq_ring_free(cookie, fq); + spin_unlock_irqrestore(&fq->lock, flags); + } +} + + /* sysfs updates are serialised by the mutex of the group owning @domain */ int iommu_dma_init_fq(struct iommu_domain *domain) { @@ -271,6 +283,7 @@ int iommu_dma_init_fq(struct iommu_domain *domain) cookie->fq = queue; + INIT_WORK(&cookie->free_iova_work, free_iova_work_func); timer_setup(&cookie->fq_timer, fq_flush_timeout, 0); atomic_set(&cookie->fq_timer_on, 0); /* -- 2.17.1

2 1

[PATCH OLK-5.10] iommu/iova: avoid softlockup in fq_flush_timeout
by Zhang Zekun 29 Jan '24

29 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZE0I CVE: NA --------------------------------- There is softlockup under fio pressure test with smmu enabled: watchdog: BUG: soft lockup - CPU#81 stuck for 22s! [swapper/81:0] ... Call trace: fq_flush_timeout+0xc0/0x110 call_timer_fn+0x34/0x178 expire_timers+0xec/0x158 run_timer_softirq+0xc0/0x1f8 __do_softirq+0x120/0x324 irq_exit+0x11c/0x140 __handle_domain_irq+0x6c/0xc0 gic_handle_irq+0x6c/0x170 el1_irq+0xb8/0x140 arch_cpu_idle+0x38/0x1c0 default_idle_call+0x24/0x44 do_idle+0x1f4/0x2d8 cpu_startup_entry+0x2c/0x30 secondary_start_kernel+0x17c/0x1c8 This is because the timer callback fq_flush_timeout may run more than 10ms, and timer may be processed continuously in the softirq so trigger softlockup. We can use work to deal with fq_ring_free for each cpu which may take long time, that to avoid triggering softlockup. Signed-off-by: Li Bin <huawei.libin(a)huawei.com> Signed-off-by: Peng Wu <wupeng58(a)huawei.com> Signed-off-by: Zhang Zekun <zhangzekun11(a)huawei.com> --- drivers/iommu/dma-iommu.c | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 4b1a88f514c9..b144ce2b2915 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -68,6 +68,8 @@ struct iommu_dma_cookie { /* Domain for flush queue callback; NULL if flush queue not in use */ struct iommu_domain *fq_domain; struct mutex mutex; + + struct work_struct free_iova_work; }; static DEFINE_STATIC_KEY_FALSE(iommu_deferred_attach_enabled); @@ -155,20 +157,11 @@ static void fq_flush_iotlb(struct iommu_dma_cookie *cookie) static void fq_flush_timeout(struct timer_list *t) { struct iommu_dma_cookie *cookie = from_timer(cookie, t, fq_timer); - int cpu; atomic_set(&cookie->fq_timer_on, 0); fq_flush_iotlb(cookie); - for_each_possible_cpu(cpu) { - unsigned long flags; - struct iova_fq *fq; - - fq = per_cpu_ptr(cookie->fq, cpu); - spin_lock_irqsave(&fq->lock, flags); - fq_ring_free(cookie, fq); - spin_unlock_irqrestore(&fq->lock, flags); - } + schedule_work(&cookie->free_iova_work); } static void queue_iova(struct iommu_dma_cookie *cookie, @@ -235,9 +228,28 @@ static void iommu_dma_free_fq(struct iommu_dma_cookie *cookie) put_pages_list(&fq->entries[idx].freelist); } + flush_work(&cookie->free_iova_work); free_percpu(cookie->fq); } +static void free_iova_work_func(struct work_struct *work) +{ + struct iommu_dma_cookie *cookie; + int cpu; + + cookie = container_of(work, struct iommu_dma_cookie, free_iova_work); + for_each_possible_cpu(cpu) { + unsigned long flags; + struct iova_fq *fq; + + fq = per_cpu_ptr(cookie->fq, cpu); + spin_lock_irqsave(&fq->lock, flags); + fq_ring_free(cookie, fq); + spin_unlock_irqrestore(&fq->lock, flags); + } +} + + /* sysfs updates are serialised by the mutex of the group owning @domain */ int iommu_dma_init_fq(struct iommu_domain *domain) { @@ -271,6 +283,7 @@ int iommu_dma_init_fq(struct iommu_domain *domain) cookie->fq = queue; + INIT_WORK(&cookie->free_iova_work, free_iova_work_func); timer_setup(&cookie->fq_timer, fq_flush_timeout, 0); atomic_set(&cookie->fq_timer_on, 0); /* -- 2.17.1

1 0

[PATCH OLK-5.10 0/2] fix spinlock already unlocked in inet_csk_reqsk_queue_add' bug
by Zhengchao Shao 29 Jan '24

29 Jan '24

Fix spinlock already unlocked in inet_csk_reqsk_queue_add' bug. Zhengchao Shao (2): tcp: make sure init the accept_queue's spinlocks once ipv6: init the accept_queue's spinlocks in inet6_create include/net/inet_connection_sock.h | 8 ++++++++ net/core/request_sock.c | 3 --- net/ipv4/af_inet.c | 3 +++ net/ipv4/inet_connection_sock.c | 4 ++++ net/ipv6/af_inet6.c | 3 +++ 5 files changed, 18 insertions(+), 3 deletions(-) -- 2.34.1

1 2

[PATCH OLK-6.6 v2] tcp: fix compilation issue when CONFIG_SYSCTL is disabled
by Zhengchao Shao 29 Jan '24

29 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8Y7PX CVE: NA -------------------------------- The following error is reported when the kernel is compiled with CONFIG_SYSCTL disabled: aarch64-linux-ld: net/ipv4/inet_hashtables.o: in function `__inet_hash_connect': inet_hashtables.c:(.text+0x3564): undefined reference to `sysctl_local_port_allocation' aarch64-linux-ld: net/ipv4/inet_hashtables.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `sysctl_local_port_allocation' which may bind externally can not be used when making a shared object; recompile with -fPIC >> inet_hashtables.c:(.text+0x3564): dangerous relocation: unsupported relocation aarch64-linux-ld: inet_hashtables.c:(.text+0x3568): undefined reference to `sysctl_local_port_allocation' aarch64-linux-ld: inet_hashtables.c:(.text+0x3580): undefined reference to `sysctl_local_port_allocation' When CONFIG_SYSCTL is disabled, sysctl_local_port_allocation is undefined. Fixes: 208a72041292 ("tcp/dccp: Add another way to allocate local ports in connect()") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401180939.2N529UUe-lkp@intel.com/ Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> --- net/ipv4/inet_hashtables.c | 2 ++ net/ipv4/sysctl_net_ipv4.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c index a24dcf39e9ae..57a207101545 100644 --- a/net/ipv4/inet_hashtables.c +++ b/net/ipv4/inet_hashtables.c @@ -28,6 +28,8 @@ #include <net/tcp.h> #include <net/sock_reuseport.h> +int sysctl_local_port_allocation; + u32 inet_ehashfn(const struct net *net, const __be32 laddr, const __u16 lport, const __be32 faddr, const __be16 fport) diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index f212133b05e9..64b3bfcbfa25 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4/sysctl_net_ipv4.c @@ -39,7 +39,6 @@ static unsigned long ip_ping_group_range_min[] = { 0, 0 }; static unsigned long ip_ping_group_range_max[] = { GID_T_MAX, GID_T_MAX }; static u32 u32_max_div_HZ = UINT_MAX / HZ; static int one_day_secs = 24 * 3600; -int sysctl_local_port_allocation; static u32 fib_multipath_hash_fields_all_mask __maybe_unused = FIB_MULTIPATH_HASH_FIELD_ALL_MASK; static unsigned int tcp_child_ehash_entries_max = 16 * 1024 * 1024; -- 2.34.1

2 1

[PATCH OLK-5.10 0/3] linux Mainline ubifs Fix Patch bacnport to 5.10
by ZhaoLong Wang 29 Jan '24

29 Jan '24

revert the commit f13656bbd4c9423857d7115ab93263b76d860c96 for apply d07cec9c238ae8fc6c1a9f3f5d30a2f8ec6cdc71 Backport d81efd66106c03771ffc8637855a6ec24caa6350 Konstantin Meskhidze (1): ubifs: fix possible dereference after free ZhaoLong Wang (2): Revert "mtd/ubi/block: Fix uaf problem in ubiblock_cleanup" ubi: block: Fix use-after-free in ubiblock_cleanup drivers/mtd/ubi/block.c | 4 +++- fs/ubifs/tnc.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) -- 2.34.3

1 3

[PATCH OLK-6.6] ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
by ZhaoLong Wang 29 Jan '24

29 Jan '24

From: Namjae Jeon <linkinjeon(a)kernel.org> mainline inclusion from mainline-v6.7-rc8 commit d10c77873ba1e9e6b91905018e29e196fd5f863d category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YD63 CVE: CVE-2024-22705 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- If ->NameOffset/Length is bigger than ->CreateContextsOffset/Length, ksmbd_check_message doesn't validate request buffer it correctly. So slab-out-of-bounds warning from calling smb_strndup_from_utf16() in smb2_open() could happen. If ->NameLength is non-zero, Set the larger of the two sums (Name and CreateContext size) as the offset and length of the data area. Reported-by: Yang Chaoming <lometsj(a)live.com> Cc: stable(a)vger.kernel.org Signed-off-by: Namjae Jeon <linkinjeon(a)kernel.org> Signed-off-by: Steve French <stfrench(a)microsoft.com> Signed-off-by: ZhaoLong Wang <wangzhaolong1(a)huawei.com> --- fs/smb/server/smb2misc.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/fs/smb/server/smb2misc.c b/fs/smb/server/smb2misc.c index 23bd3d1209df..03dded29a980 100644 --- a/fs/smb/server/smb2misc.c +++ b/fs/smb/server/smb2misc.c @@ -106,16 +106,25 @@ static int smb2_get_data_area_len(unsigned int *off, unsigned int *len, break; case SMB2_CREATE: { + unsigned short int name_off = + le16_to_cpu(((struct smb2_create_req *)hdr)->NameOffset); + unsigned short int name_len = + le16_to_cpu(((struct smb2_create_req *)hdr)->NameLength); + if (((struct smb2_create_req *)hdr)->CreateContextsLength) { *off = le32_to_cpu(((struct smb2_create_req *) hdr)->CreateContextsOffset); *len = le32_to_cpu(((struct smb2_create_req *) hdr)->CreateContextsLength); - break; + if (!name_len) + break; + + if (name_off + name_len < (u64)*off + *len) + break; } - *off = le16_to_cpu(((struct smb2_create_req *)hdr)->NameOffset); - *len = le16_to_cpu(((struct smb2_create_req *)hdr)->NameLength); + *off = name_off; + *len = name_len; break; } case SMB2_QUERY_INFO: -- 2.34.3

2 1

[PATCH OLK-5.10] ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
by ZhaoLong Wang 29 Jan '24

29 Jan '24

From: Namjae Jeon <linkinjeon(a)kernel.org> mainline inclusion from mainline-v6.7-rc8 commit d10c77873ba1e9e6b91905018e29e196fd5f863d category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YD63 CVE: CVE-2024-22705 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- If ->NameOffset/Length is bigger than ->CreateContextsOffset/Length, ksmbd_check_message doesn't validate request buffer it correctly. So slab-out-of-bounds warning from calling smb_strndup_from_utf16() in smb2_open() could happen. If ->NameLength is non-zero, Set the larger of the two sums (Name and CreateContext size) as the offset and length of the data area. Reported-by: Yang Chaoming <lometsj(a)live.com> Cc: stable(a)vger.kernel.org Signed-off-by: Namjae Jeon <linkinjeon(a)kernel.org> Signed-off-by: Steve French <stfrench(a)microsoft.com> Signed-off-by: ZhaoLong Wang <wangzhaolong1(a)huawei.com> --- fs/ksmbd/smb2misc.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/fs/ksmbd/smb2misc.c b/fs/ksmbd/smb2misc.c index 41170a593acf..caf6739530e1 100644 --- a/fs/ksmbd/smb2misc.c +++ b/fs/ksmbd/smb2misc.c @@ -107,16 +107,25 @@ static int smb2_get_data_area_len(unsigned int *off, unsigned int *len, break; case SMB2_CREATE: { + unsigned short int name_off = + le16_to_cpu(((struct smb2_create_req *)hdr)->NameOffset); + unsigned short int name_len = + le16_to_cpu(((struct smb2_create_req *)hdr)->NameLength); + if (((struct smb2_create_req *)hdr)->CreateContextsLength) { *off = le32_to_cpu(((struct smb2_create_req *) hdr)->CreateContextsOffset); *len = le32_to_cpu(((struct smb2_create_req *) hdr)->CreateContextsLength); - break; + if (!name_len) + break; + + if (name_off + name_len < (u64)*off + *len) + break; } - *off = le16_to_cpu(((struct smb2_create_req *)hdr)->NameOffset); - *len = le16_to_cpu(((struct smb2_create_req *)hdr)->NameLength); + *off = name_off; + *len = name_len; break; } case SMB2_QUERY_INFO: -- 2.34.3

2 1

[openeuler:OLK-6.6] BUILD REGRESSION 6e92c8c8b1bba4cc649d5fb8f7e784aa47ec19c6
by kernel test robot 29 Jan '24

29 Jan '24

tree/branch: https://gitee.com/openeuler/kernel.git OLK-6.6 branch HEAD: 6e92c8c8b1bba4cc649d5fb8f7e784aa47ec19c6 !3774 [OLK-6.6] sched/fair: Scan cluster before scanning LLC in wake-up path Error/Warning ids grouped by kconfigs: clang_recent_errors |-- arm64-randconfig-001-20240128 | |-- kernel-sched-core.c:error:call-to-undeclared-function-init_auto_affinity-ISO-C99-and-later-do-not-support-implicit-function-declarations | |-- kernel-sched-core.c:error:call-to-undeclared-function-tg_update_affinity_domains-ISO-C99-and-later-do-not-support-implicit-function-declarations | |-- mm-memblock.c:warning:expecting-prototype-for-memblock_alloc_internal().-Prototype-was-for-__memblock_alloc_internal()-instead | |-- mm-memblock.c:warning:no-previous-prototype-for-function-memblock_alloc_range_nid_flags | |-- mm-oom_kill.c:warning:Function-parameter-or-member-oc-not-described-in-oom_next_task | |-- mm-oom_kill.c:warning:Function-parameter-or-member-points-not-described-in-oom_next_task | |-- mm-oom_kill.c:warning:Function-parameter-or-member-task-not-described-in-oom_next_task | |-- mm-oom_kill.c:warning:expecting-prototype-for-We-choose-the-task-in-low().-Prototype-was-for-oom_next_task()-instead | `-- mm-vmalloc.c:warning:Function-parameter-or-member-pgoff-not-described-in-remap_vmalloc_hugepage_range_partial |-- arm64-randconfig-002-20240128 | |-- kernel-sched-core.c:error:call-to-undeclared-function-init_auto_affinity-ISO-C99-and-later-do-not-support-implicit-function-declarations | |-- kernel-sched-core.c:error:call-to-undeclared-function-tg_update_affinity_domains-ISO-C99-and-later-do-not-support-implicit-function-declarations | |-- mm-madvise.c:warning:no-previous-prototype-for-function-force_swapin_vma | |-- mm-memblock.c:warning:expecting-prototype-for-memblock_alloc_internal().-Prototype-was-for-__memblock_alloc_internal()-instead | |-- mm-memblock.c:warning:no-previous-prototype-for-function-memblock_alloc_range_nid_flags | |-- mm-oom_kill.c:warning:Function-parameter-or-member-oc-not-described-in-oom_next_task | |-- mm-oom_kill.c:warning:Function-parameter-or-member-points-not-described-in-oom_next_task | |-- mm-oom_kill.c:warning:Function-parameter-or-member-task-not-described-in-oom_next_task | |-- mm-oom_kill.c:warning:expecting-prototype-for-We-choose-the-task-in-low().-Prototype-was-for-oom_next_task()-instead | `-- mm-vmalloc.c:warning:Function-parameter-or-member-pgoff-not-described-in-remap_vmalloc_hugepage_range_partial |-- arm64-randconfig-003-20240128 | |-- mm-memblock.c:warning:expecting-prototype-for-memblock_alloc_internal().-Prototype-was-for-__memblock_alloc_internal()-instead | |-- mm-memblock.c:warning:no-previous-prototype-for-function-memblock_alloc_range_nid_flags | |-- mm-oom_kill.c:warning:Function-parameter-or-member-oc-not-described-in-oom_next_task | |-- mm-oom_kill.c:warning:Function-parameter-or-member-points-not-described-in-oom_next_task | |-- mm-oom_kill.c:warning:Function-parameter-or-member-task-not-described-in-oom_next_task | |-- mm-oom_kill.c:warning:expecting-prototype-for-We-choose-the-task-in-low().-Prototype-was-for-oom_next_task()-instead | `-- mm-vmalloc.c:warning:Function-parameter-or-member-pgoff-not-described-in-remap_vmalloc_hugepage_range_partial `-- arm64-randconfig-004-20240128 |-- kernel-sched-core.c:error:call-to-undeclared-function-init_auto_affinity-ISO-C99-and-later-do-not-support-implicit-function-declarations |-- kernel-sched-core.c:error:call-to-undeclared-function-tg_update_affinity_domains-ISO-C99-and-later-do-not-support-implicit-function-declarations |-- mm-madvise.c:warning:no-previous-prototype-for-function-force_swapin_vma |-- mm-memblock.c:warning:expecting-prototype-for-memblock_alloc_internal().-Prototype-was-for-__memblock_alloc_internal()-instead |-- mm-memblock.c:warning:no-previous-prototype-for-function-memblock_alloc_range_nid_flags |-- mm-oom_kill.c:warning:Function-parameter-or-member-oc-not-described-in-oom_next_task |-- mm-oom_kill.c:warning:Function-parameter-or-member-points-not-described-in-oom_next_task |-- mm-oom_kill.c:warning:Function-parameter-or-member-task-not-described-in-oom_next_task |-- mm-oom_kill.c:warning:expecting-prototype-for-We-choose-the-task-in-low().-Prototype-was-for-oom_next_task()-instead `-- mm-vmalloc.c:warning:Function-parameter-or-member-pgoff-not-described-in-remap_vmalloc_hugepage_range_partial elapsed time: 2188m configs tested: 4 configs skipped: 65 tested configs: arm64 randconfig-001-20240128 clang arm64 randconfig-002-20240128 clang arm64 randconfig-003-20240128 clang arm64 randconfig-004-20240128 clang -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10] BUILD REGRESSION bb2503a5fcdf7f51d403ab34440c497acef3b4e7
by kernel test robot 28 Jan '24

28 Jan '24

tree/branch: https://gitee.com/openeuler/kernel.git OLK-5.10 branch HEAD: bb2503a5fcdf7f51d403ab34440c497acef3b4e7 !4149 block: remove precise_iostat Error/Warning: (recently discovered and may have been fixed) drivers/crypto/hisilicon/qm.c:2755:9: warning: 'strncpy' specified bound depends on the length of the source argument [-Wstringop-truncation] drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:2104:33: warning: 'hns3_unic_ethtool_ops' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:113:43: warning: 'hclge_dbg_ssu_reg_0' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:185:43: warning: 'hclge_dbg_ssu_reg_1' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:292:43: warning: 'hclge_dbg_ssu_reg_2' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:301:43: warning: 'hclge_dbg_igu_egu_reg' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:366:43: warning: 'hclge_dbg_rpu_reg_0' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:375:43: warning: 'hclge_dbg_rpu_reg_1' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:391:43: warning: 'hclge_dbg_ncsi_reg' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:463:43: warning: 'hclge_dbg_rtc_reg' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:493:43: warning: 'hclge_dbg_ppp_reg' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:649:43: warning: 'hclge_dbg_rcb_reg' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:721:43: warning: 'hclge_dbg_tqp_reg' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h:97:43: warning: 'hclge_dbg_bios_common_reg' defined but not used [-Wunused-const-variable=] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:11043:30: warning: unused variable 'ae_dev' [-Wunused-variable] drivers/vfio/pci/vfio_pci.c:123:5: warning: no previous prototype for function 'vfio_pci_set_vendor_irqs' [-Wmissing-prototypes] drivers/vfio/pci/vfio_pci.c:2317:5: warning: no previous prototype for function 'vfio_pci_match' [-Wmissing-prototypes] drivers/vfio/pci/vfio_pci.c:98:5: warning: no previous prototype for function 'vfio_pci_irq_type' [-Wmissing-prototypes] drivers/vfio/pci/vfio_pci_rdwr.c:227:15: warning: no previous prototype for function 'vfio_pci_get_barmap' [-Wmissing-prototypes] Unverified Error/Warning (likely false positive, please contact us if interested): arch/x86/events/zhaoxin/uncore.c:1608 uncore_pci_probe() warn: possible memory leak of 'boxes' drivers/rtc/rtc-mc146818-lib.c:213 mc146818_set_time() error: uninitialized symbol 'save_freq_select'. Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- arm64-allnoconfig | |-- arch-arm64-kernel-fpsimd.c:warning:get_sve_default_vl-defined-but-not-used | |-- arch-arm64-kernel-ipi_nmi.c:error:implicit-declaration-of-function-printk_safe_enter | |-- arch-arm64-kernel-ipi_nmi.c:error:implicit-declaration-of-function-printk_safe_exit | |-- arch-arm64-mm-init.c:warning:no-previous-prototype-for-ascend_enable_all_features | |-- drivers-irqchip-irq-gic-v3-its-platform-msi.c:warning:no-previous-prototype-for-vp_get_irq_domain | |-- kernel-workqueue.c:error:implicit-declaration-of-function-printk_safe_enter | |-- kernel-workqueue.c:error:implicit-declaration-of-function-printk_safe_exit | |-- mm-page_alloc.c:warning:no-previous-prototype-for-__drain_all_pages | `-- mm-page_alloc.c:warning:no-previous-prototype-for-__zone_set_pageset_high_and_batch `-- arm64-defconfig |-- drivers-crypto-hisilicon-qm.c:warning:strncpy-specified-bound-depends-on-the-length-of-the-source-argument |-- drivers-net-ethernet-hisilicon-hns3-hns3_ethtool.c:warning:hns3_unic_ethtool_ops-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_bios_common_reg-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_igu_egu_reg-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ncsi_reg-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ppp_reg-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_rcb_reg-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_rpu_reg_0-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_rpu_reg_1-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_rtc_reg-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ssu_reg_0-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ssu_reg_1-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_ssu_reg_2-defined-but-not-used |-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_debugfs.h:warning:hclge_dbg_tqp_reg-defined-but-not-used `-- drivers-net-ethernet-hisilicon-hns3-hns3pf-hclge_main.c:warning:unused-variable-ae_dev clang_recent_errors |-- x86_64-allyesconfig | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_irq_type | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_match | |-- drivers-vfio-pci-vfio_pci.c:warning:no-previous-prototype-for-function-vfio_pci_set_vendor_irqs | `-- drivers-vfio-pci-vfio_pci_rdwr.c:warning:no-previous-prototype-for-function-vfio_pci_get_barmap `-- x86_64-randconfig-161-20240124 |-- arch-x86-events-zhaoxin-uncore.c-uncore_pci_probe()-warn:possible-memory-leak-of-boxes `-- drivers-rtc-rtc-mc146818-lib.c-mc146818_set_time()-error:uninitialized-symbol-save_freq_select-. elapsed time: 2803m configs tested: 33 configs skipped: 121 tested configs: alpha allyesconfig gcc arm64 allnoconfig gcc arm64 randconfig-001-20240128 clang arm64 randconfig-002-20240128 clang arm64 randconfig-003-20240128 clang arm64 randconfig-004-20240128 clang hexagon allmodconfig clang hexagon allyesconfig clang loongarch allmodconfig gcc m68k allmodconfig gcc m68k allyesconfig gcc microblaze allmodconfig gcc microblaze allyesconfig gcc mips allyesconfig gcc nios2 allmodconfig gcc nios2 allyesconfig gcc openrisc allyesconfig gcc parisc allmodconfig gcc parisc allyesconfig gcc powerpc allmodconfig clang powerpc allyesconfig clang riscv allmodconfig gcc riscv allyesconfig gcc riscv rv32_defconfig clang s390 allmodconfig gcc s390 allyesconfig gcc sh allmodconfig gcc sh allyesconfig gcc sparc allmodconfig gcc sparc64 allmodconfig gcc sparc64 allyesconfig gcc um allmodconfig gcc um allyesconfig gcc -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 21291/21579] drivers/spi/spi-phytium-plat.c:192:36: warning: 'phytium_spi_acpi_match' defined but not used
by kernel test robot 27 Jan '24

27 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: acf72db532a7791fde53af3dc7b4d0a6adcf6eff commit: e8483fcd43fc1dbb8d21bb7eacce804cbab6a7c6 [21291/21579] spi: add phytium spi support config: arm64-randconfig-002-20240125 (https://download.01.org/0day-ci/archive/20240127/202401272041.NCqS8joD-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401272041.NCqS8joD-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401272041.NCqS8joD-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/spi/spi-phytium-plat.c:192:36: warning: 'phytium_spi_acpi_match' defined but not used [-Wunused-const-variable=] 192 | static const struct acpi_device_id phytium_spi_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~~ vim +/phytium_spi_acpi_match +192 drivers/spi/spi-phytium-plat.c 191 > 192 static const struct acpi_device_id phytium_spi_acpi_match[] = { 193 {"PHYT000E", 0}, 194 {} 195 }; 196 MODULE_DEVICE_TABLE(acpi, phytium_spi_acpi_match); 197 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/4] misc for fd
by Chen Ridong 27 Jan '24

27 Jan '24

Chen Ridong (4): filescgroup: remove files of dfl_cftypes. filecgroup: move code of filescontrol.c to files-cgroup.c misc: add MISC_CG_RES_FD resource to control fd. Documentation: add misc resource statement. Documentation/admin-guide/cgroup-v2.rst | 7 + fs/Makefile | 2 + fs/file.c | 16 +- fs/files-cgroup.c | 335 +++++++++++++++++++++++ fs/filescontrol.c | 339 +++--------------------- fs/misc-fd.c | 92 +++++++ include/linux/fdtable.h | 1 + include/linux/files-cgroup.h | 33 +++ include/linux/filescontrol.h | 45 ++-- include/linux/misc-fd.h | 23 ++ include/linux/misc_cgroup.h | 2 + kernel/cgroup/misc.c | 2 + 12 files changed, 563 insertions(+), 334 deletions(-) create mode 100644 fs/files-cgroup.c create mode 100644 fs/misc-fd.c create mode 100644 include/linux/files-cgroup.h create mode 100644 include/linux/misc-fd.h -- 2.34.1

1 4

[PATCH OLK-6.6 0/4] misc for df
by Chen Ridong 27 Jan '24

27 Jan '24

Add a new misc resource for controlling fd. Chen Ridong (4): filescgroup: remove files of dfl_cftypes. filecgroup: move code of filescontrol.c to files-cgroup.c misc: add MISC_CG_RES_FD resource to control fd. Documentation: add misc resource statement. Documentation/admin-guide/cgroup-v2.rst | 7 + fs/Makefile | 2 + fs/file.c | 16 +- fs/files-cgroup.c | 335 +++++++++++++++++++++++ fs/filescontrol.c | 339 +++--------------------- fs/misc-fd.c | 92 +++++++ include/linux/fdtable.h | 1 + include/linux/files-cgroup.h | 33 +++ include/linux/filescontrol.h | 45 ++-- include/linux/misc-fd.h | 23 ++ include/linux/misc_cgroup.h | 2 + kernel/cgroup/misc.c | 2 + 12 files changed, 563 insertions(+), 334 deletions(-) create mode 100644 fs/files-cgroup.c create mode 100644 fs/misc-fd.c create mode 100644 include/linux/files-cgroup.h create mode 100644 include/linux/misc-fd.h -- 2.34.1

2 5

[PATCH OLK-6.6 0/4] misc for fd
by Chen Ridong 27 Jan '24

27 Jan '24

V2: Add a new misc resource for controlling fd. Chen Ridong (4): filescgroup: remove files of dfl_cftypes. filecgroup: move code of filescontrol.c to files-cgroup.c misc: add MISC_CG_RES_FD resource to control fd. Documentation: add misc resource statement. Documentation/admin-guide/cgroup-v2.rst | 7 + fs/Makefile | 2 + fs/file.c | 16 +- fs/files-cgroup.c | 335 +++++++++++++++++++++++ fs/filescontrol.c | 339 +++--------------------- fs/misc-fd.c | 92 +++++++ include/linux/fdtable.h | 1 + include/linux/files-cgroup.h | 33 +++ include/linux/filescontrol.h | 45 ++-- include/linux/misc-fd.h | 23 ++ include/linux/misc_cgroup.h | 2 + kernel/cgroup/misc.c | 2 + 12 files changed, 563 insertions(+), 334 deletions(-) create mode 100644 fs/files-cgroup.c create mode 100644 fs/misc-fd.c create mode 100644 include/linux/files-cgroup.h create mode 100644 include/linux/misc-fd.h -- 2.34.1

1 4

[openeuler:openEuler-1.0-LTS 20703/21579] kernel/sched/core.c:5845:2: error: implicit declaration of function 'tg_update_affinity_domains'
by kernel test robot 27 Jan '24

27 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: acf72db532a7791fde53af3dc7b4d0a6adcf6eff commit: 713cfd2684fa5ea08b144d92b9858b932c0f1705 [20703/21579] sched: Introduce smart grid scheduling strategy for cfs config: x86_64-randconfig-001-20240125 (https://download.01.org/0day-ci/archive/20240127/202401271837.ND9zSaBY-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401271837.ND9zSaBY-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401271837.ND9zSaBY-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from kernel/sched/core.c:8: In file included from kernel/sched/sched.h:39: In file included from include/linux/blkdev.h:16: include/linux/pagemap.h:425:21: warning: cast from 'int (*)(struct file *, struct page *)' to 'filler_t *' (aka 'int (*)(void *, struct page *)') converts to incompatible function type [-Wcast-function-type-strict] 425 | filler_t *filler = (filler_t *)mapping->a_ops->readpage; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from kernel/sched/core.c:8: kernel/sched/sched.h:1249:15: warning: cast from 'void (*)(struct rq *)' to 'void (*)(struct callback_head *)' converts to incompatible function type [-Wcast-function-type-strict] 1249 | head->func = (void (*)(struct callback_head *))func; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/sched/core.c:1587:6: warning: no previous prototype for function 'sched_set_stop_task' [-Wmissing-prototypes] 1587 | void sched_set_stop_task(int cpu, struct task_struct *stop) | ^ kernel/sched/core.c:1587:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 1587 | void sched_set_stop_task(int cpu, struct task_struct *stop) | ^ | static kernel/sched/core.c:2741:10: warning: cast from 'void (*)(struct callback_head *)' to 'void (*)(struct rq *)' converts to incompatible function type [-Wcast-function-type-strict] 2741 | func = (void (*)(struct rq *))head->func; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/sched/core.c:3771:35: warning: no previous prototype for function 'preempt_schedule_irq' [-Wmissing-prototypes] 3771 | asmlinkage __visible void __sched preempt_schedule_irq(void) | ^ kernel/sched/core.c:3771:22: note: declare 'static' if the function is not intended to be used outside of this translation unit 3771 | asmlinkage __visible void __sched preempt_schedule_irq(void) | ^ | static >> kernel/sched/core.c:5845:2: error: implicit declaration of function 'tg_update_affinity_domains' [-Werror,-Wimplicit-function-declaration] 5845 | tg_update_affinity_domains(cpu, 1); | ^ kernel/sched/core.c:5904:2: error: implicit declaration of function 'tg_update_affinity_domains' [-Werror,-Wimplicit-function-declaration] 5904 | tg_update_affinity_domains(cpu, 0); | ^ >> kernel/sched/core.c:5976:2: error: implicit declaration of function 'init_auto_affinity' [-Werror,-Wimplicit-function-declaration] 5976 | init_auto_affinity(&root_task_group); | ^ kernel/sched/core.c:5976:2: note: did you mean 'irq_set_affinity'? include/linux/interrupt.h:292:1: note: 'irq_set_affinity' declared here 292 | irq_set_affinity(unsigned int irq, const struct cpumask *cpumask) | ^ >> kernel/sched/core.c:5976:22: error: use of undeclared identifier 'root_task_group'; did you mean 'task_group'? 5976 | init_auto_affinity(&root_task_group); | ^~~~~~~~~~~~~~~ | task_group kernel/sched/sched.h:1444:34: note: 'task_group' declared here 1444 | static inline struct task_group *task_group(struct task_struct *p) | ^ kernel/sched/core.c:6029:32: warning: variable 'ptr' set but not used [-Wunused-but-set-variable] 6029 | unsigned long alloc_size = 0, ptr; | ^ 6 warnings and 4 errors generated. vim +/tg_update_affinity_domains +5845 kernel/sched/core.c 5831 5832 int sched_cpu_activate(unsigned int cpu) 5833 { 5834 struct rq *rq = cpu_rq(cpu); 5835 struct rq_flags rf; 5836 5837 #ifdef CONFIG_SCHED_SMT 5838 /* 5839 * When going up, increment the number of cores with SMT present. 5840 */ 5841 if (cpumask_weight(cpu_smt_mask(cpu)) == 2) 5842 static_branch_inc_cpuslocked(&sched_smt_present); 5843 #endif 5844 set_cpu_active(cpu, true); > 5845 tg_update_affinity_domains(cpu, 1); 5846 5847 if (sched_smp_initialized) { 5848 sched_domains_numa_masks_set(cpu); 5849 cpuset_cpu_active(); 5850 } 5851 5852 /* 5853 * Put the rq online, if not already. This happens: 5854 * 5855 * 1) In the early boot process, because we build the real domains 5856 * after all CPUs have been brought up. 5857 * 5858 * 2) At runtime, if cpuset_cpu_active() fails to rebuild the 5859 * domains. 5860 */ 5861 rq_lock_irqsave(rq, &rf); 5862 if (rq->rd) { 5863 BUG_ON(!cpumask_test_cpu(cpu, rq->rd->span)); 5864 set_rq_online(rq); 5865 } 5866 rq_unlock_irqrestore(rq, &rf); 5867 5868 update_max_interval(); 5869 5870 return 0; 5871 } 5872 5873 int sched_cpu_deactivate(unsigned int cpu) 5874 { 5875 int ret; 5876 5877 set_cpu_active(cpu, false); 5878 /* 5879 * We've cleared cpu_active_mask, wait for all preempt-disabled and RCU 5880 * users of this state to go away such that all new such users will 5881 * observe it. 5882 * 5883 * Do sync before park smpboot threads to take care the rcu boost case. 5884 */ 5885 synchronize_rcu_mult(call_rcu, call_rcu_sched); 5886 5887 #ifdef CONFIG_SCHED_SMT 5888 /* 5889 * When going down, decrement the number of cores with SMT present. 5890 */ 5891 if (cpumask_weight(cpu_smt_mask(cpu)) == 2) 5892 static_branch_dec_cpuslocked(&sched_smt_present); 5893 #endif 5894 5895 if (!sched_smp_initialized) 5896 return 0; 5897 5898 ret = cpuset_cpu_inactive(cpu); 5899 if (ret) { 5900 set_cpu_active(cpu, true); 5901 return ret; 5902 } 5903 sched_domains_numa_masks_clear(cpu); 5904 tg_update_affinity_domains(cpu, 0); 5905 return 0; 5906 } 5907 5908 static void sched_rq_cpu_starting(unsigned int cpu) 5909 { 5910 struct rq *rq = cpu_rq(cpu); 5911 5912 rq->calc_load_update = calc_load_update; 5913 update_max_interval(); 5914 } 5915 5916 int sched_cpu_starting(unsigned int cpu) 5917 { 5918 sched_rq_cpu_starting(cpu); 5919 sched_tick_start(cpu); 5920 return 0; 5921 } 5922 5923 #ifdef CONFIG_HOTPLUG_CPU 5924 int sched_cpu_dying(unsigned int cpu) 5925 { 5926 struct rq *rq = cpu_rq(cpu); 5927 struct rq_flags rf; 5928 5929 /* Handle pending wakeups and then migrate everything off */ 5930 sched_ttwu_pending(); 5931 sched_tick_stop(cpu); 5932 5933 rq_lock_irqsave(rq, &rf); 5934 if (rq->rd) { 5935 BUG_ON(!cpumask_test_cpu(cpu, rq->rd->span)); 5936 set_rq_offline(rq); 5937 } 5938 migrate_tasks(rq, &rf); 5939 BUG_ON(rq->nr_running != 1); 5940 rq_unlock_irqrestore(rq, &rf); 5941 5942 calc_load_migrate(rq); 5943 update_max_interval(); 5944 nohz_balance_exit_idle(rq); 5945 hrtick_clear(rq); 5946 return 0; 5947 } 5948 #endif 5949 5950 void __init sched_init_smp(void) 5951 { 5952 sched_init_numa(); 5953 5954 /* 5955 * There's no userspace yet to cause hotplug operations; hence all the 5956 * CPU masks are stable and all blatant races in the below code cannot 5957 * happen. The hotplug lock is nevertheless taken to satisfy lockdep, 5958 * but there won't be any contention on it. 5959 */ 5960 cpus_read_lock(); 5961 mutex_lock(&sched_domains_mutex); 5962 sched_init_domains(cpu_active_mask); 5963 mutex_unlock(&sched_domains_mutex); 5964 cpus_read_unlock(); 5965 5966 /* Move init over to a non-isolated CPU */ 5967 if (set_cpus_allowed_ptr(current, housekeeping_cpumask(HK_FLAG_DOMAIN)) < 0) 5968 BUG(); 5969 sched_init_granularity(); 5970 5971 init_sched_rt_class(); 5972 init_sched_dl_class(); 5973 5974 sched_smp_initialized = true; 5975 > 5976 init_auto_affinity(&root_task_group); 5977 } 5978 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-5.10] nfc: nci: fix possible NULL pointer dereference in send_acknowledge()
by Ziyang Xuan 27 Jan '24

27 Jan '24

From: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> stable inclusion from stable-v5.10.199 commit c95fa5b20fe03609e0894656fa43c18045b5097e category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YCSH CVE: CVE-2023-46343 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- commit 7937609cd387246aed994e81aa4fa951358fba41 upstream. Handle memory allocation failure from nci_skb_alloc() (calling alloc_skb()) to avoid possible NULL pointer dereference. Reported-by: 黄思聪 <huangsicong(a)iie.ac.cn> Fixes: 391d8a2da787 ("NFC: Add NCI over SPI receive") Cc: <stable(a)vger.kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> Reviewed-by: Simon Horman <horms(a)kernel.org> Link: https://lore.kernel.org/r/20231013184129.18738-1-krzysztof.kozlowski@linaro… Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Ziyang Xuan <william.xuanziyang(a)huawei.com> --- net/nfc/nci/spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/nfc/nci/spi.c b/net/nfc/nci/spi.c index 7d8e10e27c20..0651640d6868 100644 --- a/net/nfc/nci/spi.c +++ b/net/nfc/nci/spi.c @@ -151,6 +151,8 @@ static int send_acknowledge(struct nci_spi *nspi, u8 acknowledge) int ret; skb = nci_skb_alloc(nspi->ndev, 0, GFP_KERNEL); + if (!skb) + return -ENOMEM; /* add the NCI SPI header to the start of the buffer */ hdr = skb_push(skb, NCI_SPI_HDR_LEN); -- 2.25.1

1 0

[PATCH openEuler-1.0-LTS v2] drm/amdgpu: Fix potential fence use-after-free v2
by GUO Zihua 27 Jan '24

27 Jan '24

From: shanzhulig <shanzhulig(a)gmail.com> mainline inclusion from mainline-v6.5-rc1 commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YD58 CVE: CVE-2023-51042 Reference: https://github.com/torvalds/linux/commit/2e54154b9f27262efd0cb4f903cc7d5ad1… -------------------------------- fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig <shanzhulig(a)gmail.com> Signed-off-by: Christian König <christian.koenig(a)amd.com> Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: GUO Zihua <guozihua(a)huawei.com> --- v2: Removed second Reference line in commit message. --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 81001d879322..aa2731848c3a 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -1501,15 +1501,15 @@ static int amdgpu_cs_wait_all_fences(struct amdgpu_device *adev, continue; r = dma_fence_wait_timeout(fence, true, timeout); + if (r > 0 && fence->error) + r = fence->error; + dma_fence_put(fence); if (r < 0) return r; if (r == 0) break; - - if (fence->error) - return fence->error; } memset(wait, 0, sizeof(*wait)); -- 2.34.1

2 1

[PATCH OLK-5.10 00/13] scsi: core: Always send batch on reset or error handling command
by Li Lingfeng 27 Jan '24

27 Jan '24

Always send batch on reset or error handling command. Alexander Atanasov (2): scsi: core: Always send batch on reset or error handling command scsi: core: Always send batch on reset or error handling command Bart Van Assche (3): scsi: core: Introduce scsi_get_sector() scsi: core: Use scsi_cmd_to_rq() instead of scsi_cmnd.request scsi: core: Use a structure member to track the SCSI command submitter Greg Kroah-Hartman (6): Revert "scsi: core: Always send batch on reset or error handling command" Revert "scsi: core: Use a structure member to track the SCSI command submitter" Revert "scsi: core: Use scsi_cmd_to_rq() instead of scsi_cmnd.request" Revert "scsi: core: Make scsi_get_lba() return the LBA" Revert "scsi: core: Introduce scsi_get_sector()" Revert "scsi: core: Add scsi_prot_ref_tag() helper" Martin K. Petersen (2): scsi: core: Add scsi_prot_ref_tag() helper scsi: core: Make scsi_get_lba() return the LBA drivers/scsi/scsi_error.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.31.1

1 13

[PATCH openEuler-1.0-LTS v2] rtc: check if __rtc_read_time was successful
by Yu Liao 27 Jan '24

27 Jan '24

From: Tom Rix <trix(a)redhat.com> mainline inclusion from mainline-v5.18-rc1 commit 915593a7a663b2ad08b895a5f3ba8b19d89d4ebf category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZCJG CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… ---------------------------------------- Clang static analysis reports this issue interface.c:810:8: warning: Passed-by-value struct argument contains uninitialized data now = rtc_tm_to_ktime(tm); ^~~~~~~~~~~~~~~~~~~ tm is set by a successful call to __rtc_read_time() but its return status is not checked. Check if it was successful before setting the enabled flag. Move the decl of err to function scope. Fixes: 2b2f5ff00f63 ("rtc: interface: ignore expired timers when enqueuing new timers") Signed-off-by: Tom Rix <trix(a)redhat.com> Signed-off-by: Alexandre Belloni <alexandre.belloni(a)bootlin.com> Link: https://lore.kernel.org/r/20220326194236.2916310-1-trix@redhat.com Signed-off-by: Yu Liao <liaoyu15(a)huawei.com> --- drivers/rtc/interface.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index ce051f91829f..e62b341bdc9e 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -820,9 +820,13 @@ static int rtc_timer_enqueue(struct rtc_device *rtc, struct rtc_timer *timer) struct timerqueue_node *next = timerqueue_getnext(&rtc->timerqueue); struct rtc_time tm; ktime_t now; + int err; + + err = __rtc_read_time(rtc, &tm); + if (err) + return err; timer->enabled = 1; - __rtc_read_time(rtc, &tm); now = rtc_tm_to_ktime(tm); /* Skip over expired timers */ @@ -836,7 +840,6 @@ static int rtc_timer_enqueue(struct rtc_device *rtc, struct rtc_timer *timer) trace_rtc_timer_enqueue(timer); if (!next || ktime_before(timer->node.expires, next->expires)) { struct rtc_wkalrm alarm; - int err; alarm.time = rtc_ktime_to_tm(timer->node.expires); alarm.enabled = 1; err = __rtc_set_alarm(rtc, &alarm); -- 2.33.0

1 0

[PATCH OLK-6.6] kabi: reserve space for struct acpi_device and acpi_scan_handler
by Xiongfeng Wang 27 Jan '24

27 Jan '24

hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZCY9 CVE: NA ------------------------------- reserve space for struct acpi_device, struct acpi_device_power and struct acpi_scan_handler Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> --- include/acpi/acpi_bus.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index 0b7eab0ef7d7..66639ce5056e 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -130,6 +130,8 @@ struct acpi_scan_handler { void (*bind)(struct device *phys_dev); void (*unbind)(struct device *phys_dev); struct acpi_hotplug_profile hotplug; + KABI_RESERVE(1) + KABI_RESERVE(2) }; /* @@ -282,6 +284,8 @@ struct acpi_device_power { struct acpi_device_power_flags flags; struct acpi_device_power_state states[ACPI_D_STATE_COUNT]; /* Power states (D0-D3Cold) */ u8 state_for_enumeration; /* Deepest power state for enumeration */ + KABI_RESERVE(1) + KABI_RESERVE(2) }; struct acpi_dep_data { @@ -389,6 +393,8 @@ struct acpi_device { struct list_head physical_node_list; struct mutex physical_node_lock; void (*remove)(struct acpi_device *); + KABI_RESERVE(1) + KABI_RESERVE(2) }; /* Non-device subnode */ -- 2.20.1

1 0

[PATCH OLK-6.6] kabi: reserve space for struct device
by Xiongfeng Wang 27 Jan '24

27 Jan '24

hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZD0E CVE: NA ------------------------------- reserve space for struct device. Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> --- include/linux/device.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/linux/device.h b/include/linux/device.h index 56d93a1ffb7b..c3a36b0eb784 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -805,6 +805,15 @@ struct device { #ifdef CONFIG_DMA_OPS_BYPASS bool dma_ops_bypass : 1; #endif + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) + KABI_RESERVE(5) + KABI_RESERVE(6) + KABI_RESERVE(7) + KABI_RESERVE(8) + KABI_AUX_PTR(device_extended) }; /** -- 2.20.1

2 1

[PATCH OLK-6.6 0/5] Add support for ecmdq
by Zhang Zekun 27 Jan '24

27 Jan '24

Add support for ecmdq trim the whit spaces Zhen Lei (5): iommu/arm-smmu-v3: Add support for ECMDQ register mode iommu/arm-smmu-v3: Ensure that a set of associated commands are inserted in the same ECMDQ iommu/arm-smmu-v3: Add arm_smmu_ecmdq_issue_cmdlist() for non-shared ECMDQ iommu/arm-smmu-v3: Add support for less than one ECMDQ per core iommu/arm-smmu-v3: Allow disabling ECMDQs at boot time drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 434 +++++++++++++++++++- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 39 ++ 2 files changed, 465 insertions(+), 8 deletions(-) -- 2.17.1

1 5

[PATCH openEuler-1.0-LTS] crypto: scomp - fix req->dst buffer overflow
by felix 27 Jan '24

27 Jan '24

From: Chengming Zhou <zhouchengming(a)bytedance.com> mainline inclusion from mainline-v6.8-rc1 commit 744e1885922a9943458954cfea917b31064b4131 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8ZBUC CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- The req->dst buffer size should be checked before copying from the scomp_scratch->dst to avoid req->dst buffer overflow problem. Fixes: 1ab53a77b772 ("crypto: acomp - add driver-side scomp interface") Reported-by: syzbot+3eff5e51bf1db122a16e(a)syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/0000000000000b05cd060d6b5511@google.com/ Signed-off-by: Chengming Zhou <zhouchengming(a)bytedance.com> Reviewed-by: Barry Song <v-songbaohua(a)oppo.com> Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au> Signed-off-by: Felix Fu <fuzhen5(a)huawei.com> --- crypto/scompress.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crypto/scompress.c b/crypto/scompress.c index 968bbcf65c94..3ade31df4f22 100644 --- a/crypto/scompress.c +++ b/crypto/scompress.c @@ -149,6 +149,7 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) const int cpu = get_cpu(); u8 *scratch_src = *per_cpu_ptr(scomp_src_scratches, cpu); u8 *scratch_dst = *per_cpu_ptr(scomp_dst_scratches, cpu); + unsigned int dlen; int ret; if (!req->src || !req->slen || req->slen > SCOMP_SCRATCH_SIZE) { @@ -164,6 +165,8 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) if (!req->dlen || req->dlen > SCOMP_SCRATCH_SIZE) req->dlen = SCOMP_SCRATCH_SIZE; + dlen = req->dlen; + scatterwalk_map_and_copy(scratch_src, req->src, 0, req->slen, 0); if (dir) ret = crypto_scomp_compress(scomp, scratch_src, req->slen, @@ -176,6 +179,9 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) req->dst = sgl_alloc(req->dlen, GFP_ATOMIC, NULL); if (!req->dst) goto out; + } else if (req->dlen > dlen) { + ret = -ENOSPC; + goto out; } scatterwalk_map_and_copy(scratch_dst, req->dst, 0, req->dlen, 1); -- 2.34.1

2 1

[PATCH OLK-6.6] ubifs: fix possible dereference after free
by ZhaoLong Wang 27 Jan '24

27 Jan '24

From: Konstantin Meskhidze <konstantin.meskhidze(a)huawei.com> mainline inclusion from mainline-v6.7-rc1 commit d81efd66106c03771ffc8637855a6ec24caa6350 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZCT1 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- 'old_idx' could be dereferenced after free via 'rb_link_node' function call. Fixes: b5fda08ef213 ("ubifs: Fix memleak when insert_old_idx() failed") Co-developed-by: Ivanov Mikhail <ivanov.mikhail1(a)huawei-partners.com> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze(a)huawei.com> Reviewed-by: Zhihao Cheng <chengzhihao1(a)huawei.com> Signed-off-by: Richard Weinberger <richard(a)nod.at> Signed-off-by: ZhaoLong Wang <wangzhaolong1(a)huawei.com> --- fs/ubifs/tnc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c index 6b7d95b65f4b..f4728e65d1bd 100644 --- a/fs/ubifs/tnc.c +++ b/fs/ubifs/tnc.c @@ -65,6 +65,7 @@ static void do_insert_old_idx(struct ubifs_info *c, else { ubifs_err(c, "old idx added twice!"); kfree(old_idx); + return; } } rb_link_node(&old_idx->rb, parent, p); -- 2.34.3

2 1

[PATCH OLK-5.10 0/3] linux Mainline ubifs Fix Patch bacnport
by ZhaoLong Wang 27 Jan '24

27 Jan '24

1. revert the commit f13656bbd4c9423857d7115ab93263b76d860c96 for apply d07cec9c238ae8fc6c1a9f3f5d30a2f8ec6cdc71 2. Backport d81efd66106c03771ffc8637855a6ec24caa6350 Konstantin Meskhidze (1): ubifs: fix possible dereference after free ZhaoLong Wang (2): Revert "mtd/ubi/block: Fix uaf problem in ubiblock_cleanup" ubi: block: Fix use-after-free in ubiblock_cleanup drivers/mtd/ubi/block.c | 4 +++- fs/ubifs/tnc.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) -- 2.34.3

1 3

[PATCH openEuler-1.0-LTS] crypto: scomp - fix req->dst buffer overflow
by felix 27 Jan '24

27 Jan '24

From: Chengming Zhou <zhouchengming(a)bytedance.com> mainline inclusion from mainline-v6.8-rc1 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8ZBUC CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- The req->dst buffer size should be checked before copying from the scomp_scratch->dst to avoid req->dst buffer overflow problem. Fixes: 1ab53a77b772 ("crypto: acomp - add driver-side scomp interface") Reported-by: syzbot+3eff5e51bf1db122a16e(a)syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/0000000000000b05cd060d6b5511@google.com/ Signed-off-by: Chengming Zhou <zhouchengming(a)bytedance.com> Reviewed-by: Barry Song <v-songbaohua(a)oppo.com> Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au> Signed-off-by: Felix Fu <fuzhen5(a)huawei.com> --- crypto/scompress.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crypto/scompress.c b/crypto/scompress.c index 968bbcf65c94..3ade31df4f22 100644 --- a/crypto/scompress.c +++ b/crypto/scompress.c @@ -149,6 +149,7 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) const int cpu = get_cpu(); u8 *scratch_src = *per_cpu_ptr(scomp_src_scratches, cpu); u8 *scratch_dst = *per_cpu_ptr(scomp_dst_scratches, cpu); + unsigned int dlen; int ret; if (!req->src || !req->slen || req->slen > SCOMP_SCRATCH_SIZE) { @@ -164,6 +165,8 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) if (!req->dlen || req->dlen > SCOMP_SCRATCH_SIZE) req->dlen = SCOMP_SCRATCH_SIZE; + dlen = req->dlen; + scatterwalk_map_and_copy(scratch_src, req->src, 0, req->slen, 0); if (dir) ret = crypto_scomp_compress(scomp, scratch_src, req->slen, @@ -176,6 +179,9 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) req->dst = sgl_alloc(req->dlen, GFP_ATOMIC, NULL); if (!req->dst) goto out; + } else if (req->dlen > dlen) { + ret = -ENOSPC; + goto out; } scatterwalk_map_and_copy(scratch_dst, req->dst, 0, req->dlen, 1); -- 2.34.1

1 0

[PATCH openEuler-1.0-LTS] drm/amdgpu: Fix potential fence use-after-free v2
by GUO Zihua 27 Jan '24

27 Jan '24

From: shanzhulig <shanzhulig(a)gmail.com> mainline inclusion from mainline-v6.5-rc1 commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YD58 CVE: CVE-2023-51042 Reference: https://github.com/torvalds/linux/commit/2e54154b9f27262efd0cb4f903cc7d5ad1… Reference: https://nvd.nist.gov/vuln/detail/CVE-2023-51042 -------------------------------- fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig <shanzhulig(a)gmail.com> Signed-off-by: Christian König <christian.koenig(a)amd.com> Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: GUO Zihua <guozihua(a)huawei.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 81001d879322..aa2731848c3a 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -1501,15 +1501,15 @@ static int amdgpu_cs_wait_all_fences(struct amdgpu_device *adev, continue; r = dma_fence_wait_timeout(fence, true, timeout); + if (r > 0 && fence->error) + r = fence->error; + dma_fence_put(fence); if (r < 0) return r; if (r == 0) break; - - if (fence->error) - return fence->error; } memset(wait, 0, sizeof(*wait)); -- 2.34.1

2 1

[PATCH OLK-5.10 v2] drm/amdgpu: Fix potential fence use-after-free v2
by GUO Zihua 27 Jan '24

27 Jan '24

From: shanzhulig <shanzhulig(a)gmail.com> mainline inclusion from mainline-v6.5-rc1 commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YD58 CVE: CVE-2023-51042 Reference: https://github.com/torvalds/linux/commit/2e54154b9f27262efd0cb4f903cc7d5ad1… Reference: https://nvd.nist.gov/vuln/detail/CVE-2023-51042 -------------------------------- fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig <shanzhulig(a)gmail.com> Signed-off-by: Christian König <christian.koenig(a)amd.com> Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: GUO Zihua <guozihua(a)huawei.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 9e5eae1207e4..ec41eba09b67 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -1517,15 +1517,15 @@ static int amdgpu_cs_wait_all_fences(struct amdgpu_device *adev, continue; r = dma_fence_wait_timeout(fence, true, timeout); + if (r > 0 && fence->error) + r = fence->error; + dma_fence_put(fence); if (r < 0) return r; if (r == 0) break; - - if (fence->error) - return fence->error; } memset(wait, 0, sizeof(*wait)); -- 2.34.1

1 0

[PATCH OLK-5.10] drm/amdgpu: Fix potential fence use-after-free v2
by GUO Zihua 27 Jan '24

27 Jan '24

From: shanzhulig <shanzhulig(a)gmail.com> mainline inclusion from mainline-v6.5-rc1 commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 category: bugfix bugzilla: 189498 CVE: CVE-2023-51042 Reference: https://github.com/torvalds/linux/commit/2e54154b9f27262efd0cb4f903cc7d5ad1… Reference: https://nvd.nist.gov/vuln/detail/CVE-2023-51042 -------------------------------- fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig <shanzhulig(a)gmail.com> Signed-off-by: Christian König <christian.koenig(a)amd.com> Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: GUO Zihua <guozihua(a)huawei.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 9e5eae1207e4..ec41eba09b67 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -1517,15 +1517,15 @@ static int amdgpu_cs_wait_all_fences(struct amdgpu_device *adev, continue; r = dma_fence_wait_timeout(fence, true, timeout); + if (r > 0 && fence->error) + r = fence->error; + dma_fence_put(fence); if (r < 0) return r; if (r == 0) break; - - if (fence->error) - return fence->error; } memset(wait, 0, sizeof(*wait)); -- 2.34.1

1 0

[PATCH OLK-6.6 0/5] Add support for ecmdq
by Zhang Zekun 27 Jan '24

27 Jan '24

Add support for ecmdq Zhen Lei (5): iommu/arm-smmu-v3: Add support for ECMDQ register mode iommu/arm-smmu-v3: Ensure that a set of associated commands are inserted in the same ECMDQ iommu/arm-smmu-v3: Add arm_smmu_ecmdq_issue_cmdlist() for non-shared ECMDQ iommu/arm-smmu-v3: Add support for less than one ECMDQ per core iommu/arm-smmu-v3: Allow disabling ECMDQs at boot time drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 434 +++++++++++++++++++- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 39 ++ 2 files changed, 465 insertions(+), 8 deletions(-) -- 2.17.1

2 6

[PATCH openEuler-1.0-LTS] rtc: check if __rtc_read_time was successful
by Yu Liao 27 Jan '24

27 Jan '24

From: Tom Rix <trix(a)redhat.com> mainline inclusion from mainline-v5.18-rc1 commit 915593a7a663b2ad08b895a5f3ba8b19d89d4ebf category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZCJG CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… ---------------------------------------- Clang static analysis reports this issue interface.c:810:8: warning: Passed-by-value struct argument contains uninitialized data now = rtc_tm_to_ktime(tm); ^~~~~~~~~~~~~~~~~~~ tm is set by a successful call to __rtc_read_time() but its return status is not checked. Check if it was successful before setting the enabled flag. Move the decl of err to function scope. Fixes: 2b2f5ff00f63 ("rtc: interface: ignore expired timers when enqueuing new timers") Signed-off-by: Tom Rix <trix(a)redhat.com> Signed-off-by: Alexandre Belloni <alexandre.belloni(a)bootlin.com> Link: https://lore.kernel.org/r/20220326194236.2916310-1-trix@redhat.com Signed-off-by: Yu Liao <liaoyu15(a)huawei.com> --- drivers/rtc/interface.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index ce051f91829f..e62b341bdc9e 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -820,9 +820,13 @@ static int rtc_timer_enqueue(struct rtc_device *rtc, struct rtc_timer *timer) struct timerqueue_node *next = timerqueue_getnext(&rtc->timerqueue); struct rtc_time tm; ktime_t now; + int err; + + err = __rtc_read_time(rtc, &tm); + if (err) + return err; timer->enabled = 1; - __rtc_read_time(rtc, &tm); now = rtc_tm_to_ktime(tm); /* Skip over expired timers */ @@ -836,7 +840,6 @@ static int rtc_timer_enqueue(struct rtc_device *rtc, struct rtc_timer *timer) trace_rtc_timer_enqueue(timer); if (!next || ktime_before(timer->node.expires, next->expires)) { struct rtc_wkalrm alarm; - int err; alarm.time = rtc_ktime_to_tm(timer->node.expires); alarm.enabled = 1; err = __rtc_set_alarm(rtc, &alarm); -- 2.33.0

1 0

[PATCH openEuler-1.0-LTS] crypto: scomp - fix req->dst buffer overflow
by felix 27 Jan '24

27 Jan '24

From: Chengming Zhou <zhouchengming(a)bytedance.com> mainline inclusion category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8ZBUC CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- The req->dst buffer size should be checked before copying from the scomp_scratch->dst to avoid req->dst buffer overflow problem. Fixes: 1ab53a77b772 ("crypto: acomp - add driver-side scomp interface") Reported-by: syzbot+3eff5e51bf1db122a16e(a)syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/0000000000000b05cd060d6b5511@google.com/ Signed-off-by: Chengming Zhou <zhouchengming(a)bytedance.com> Reviewed-by: Barry Song <v-songbaohua(a)oppo.com> Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au> Signed-off-by: Felix Fu <fuzhen5(a)huawei.com> --- crypto/scompress.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crypto/scompress.c b/crypto/scompress.c index 968bbcf65c94..3ade31df4f22 100644 --- a/crypto/scompress.c +++ b/crypto/scompress.c @@ -149,6 +149,7 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) const int cpu = get_cpu(); u8 *scratch_src = *per_cpu_ptr(scomp_src_scratches, cpu); u8 *scratch_dst = *per_cpu_ptr(scomp_dst_scratches, cpu); + unsigned int dlen; int ret; if (!req->src || !req->slen || req->slen > SCOMP_SCRATCH_SIZE) { @@ -164,6 +165,8 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) if (!req->dlen || req->dlen > SCOMP_SCRATCH_SIZE) req->dlen = SCOMP_SCRATCH_SIZE; + dlen = req->dlen; + scatterwalk_map_and_copy(scratch_src, req->src, 0, req->slen, 0); if (dir) ret = crypto_scomp_compress(scomp, scratch_src, req->slen, @@ -176,6 +179,9 @@ static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir) req->dst = sgl_alloc(req->dlen, GFP_ATOMIC, NULL); if (!req->dst) goto out; + } else if (req->dlen > dlen) { + ret = -ENOSPC; + goto out; } scatterwalk_map_and_copy(scratch_dst, req->dst, 0, req->dlen, 1); -- 2.34.1

1 0

[PATCH openEuler-1.0-LTS] Bluetooth: rfcomm: Fix null-ptr-deref in rfcomm_check_security
by Zhengchao Shao 27 Jan '24

27 Jan '24

From: Yuxuan Hu <20373622(a)buaa.edu.cn> maillist inclusion category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YV3O CVE: CVE-2024-22099 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/… -------------------------------- During our fuzz testing of the connection and disconnection process at the RFCOMM layer, we discovered this bug. By comparing the packets from a normal connection and disconnection process with the testcase that triggered a KASAN report. We analyzed the cause of this bug as follows: 1. In the packets captured during a normal connection, the host sends a `Read Encryption Key Size` type of `HCI_CMD` packet (Command Opcode: 0x1408) to the controller to inquire the length of encryption key.After receiving this packet, the controller immediately replies with a Command Completepacket (Event Code: 0x0e) to return the Encryption Key Size. 2. In our fuzz test case, the timing of the controller's response to this packet was delayed to an unexpected point: after the RFCOMM and L2CAP layers had disconnected but before the HCI layer had disconnected. 3. After receiving the Encryption Key Size Response at the time described in point 2, the host still called the rfcomm_check_security function. However, by this time `struct l2cap_conn *conn = l2cap_pi(sk)->chan->conn;` had already been released, and when the function executed `return hci_conn_security(conn->hcon, d->sec_level, auth_type, d->out);`, specifically when accessing `conn->hcon`, a null-ptr-deref error occurred. To fix this bug, check if `sk->sk_state` is BT_CLOSED before calling rfcomm_recv_frame in rfcomm_process_rx. Signed-off-by: Yuxuan Hu <20373622(a)buaa.edu.cn> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> --- net/bluetooth/rfcomm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c index b98225d65e87..6dff0d925400 100644 --- a/net/bluetooth/rfcomm/core.c +++ b/net/bluetooth/rfcomm/core.c @@ -1903,7 +1903,7 @@ static struct rfcomm_session *rfcomm_process_rx(struct rfcomm_session *s) /* Get data directly from socket receive queue without copying it. */ while ((skb = skb_dequeue(&sk->sk_receive_queue))) { skb_orphan(skb); - if (!skb_linearize(skb)) { + if (!skb_linearize(skb) && sk->sk_state != BT_CLOSED) { s = rfcomm_recv_frame(s, skb); if (!s) break; -- 2.34.1

1 0

[openeuler:openEuler-1.0-LTS 17239/21577] drivers/nvme/host/core.c:1163:27: error: 'compat_uptr_t' undeclared; did you mean 'compat_time_t'?
by kernel test robot 27 Jan '24

27 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 992b5fc139d3aa14b25613b06adee4bb9c110b28 commit: b8ba22a604e4d0a3ad8e23af22f432e12b6f1a65 [17239/21577] nvme: fix compat address handling in several ioctls config: arm64-randconfig-002-20240125 (https://download.01.org/0day-ci/archive/20240127/202401271204.lWrJHpqI-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401271204.lWrJHpqI-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401271204.lWrJHpqI-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/nvme/host/core.c: In function 'nvme_to_user_ptr': >> drivers/nvme/host/core.c:1163:27: error: 'compat_uptr_t' undeclared (first use in this function); did you mean 'compat_time_t'? 1163 | ptrval = (compat_uptr_t)ptrval; | ^~~~~~~~~~~~~ | compat_time_t drivers/nvme/host/core.c:1163:27: note: each undeclared identifier is reported only once for each function it appears in >> drivers/nvme/host/core.c:1163:41: error: expected ';' before 'ptrval' 1163 | ptrval = (compat_uptr_t)ptrval; | ^~~~~~ | ; vim +1163 drivers/nvme/host/core.c 1154 1155 /* 1156 * Convert integer values from ioctl structures to user pointers, silently 1157 * ignoring the upper bits in the compat case to match behaviour of 32-bit 1158 * kernels. 1159 */ 1160 static void __user *nvme_to_user_ptr(uintptr_t ptrval) 1161 { 1162 if (in_compat_syscall()) > 1163 ptrval = (compat_uptr_t)ptrval; 1164 return (void __user *)ptrval; 1165 } 1166 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-5.10] Bluetooth: rfcomm: Fix null-ptr-deref in rfcomm_check_security
by Zhengchao Shao 27 Jan '24

27 Jan '24

From: Yuxuan Hu <20373622(a)buaa.edu.cn> maillist inclusion category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YV3O CVE: CVE-2024-22099 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/… -------------------------------- During our fuzz testing of the connection and disconnection process at the RFCOMM layer, we discovered this bug. By comparing the packets from a normal connection and disconnection process with the testcase that triggered a KASAN report. We analyzed the cause of this bug as follows: 1. In the packets captured during a normal connection, the host sends a `Read Encryption Key Size` type of `HCI_CMD` packet (Command Opcode: 0x1408) to the controller to inquire the length of encryption key.After receiving this packet, the controller immediately replies with a Command Completepacket (Event Code: 0x0e) to return the Encryption Key Size. 2. In our fuzz test case, the timing of the controller's response to this packet was delayed to an unexpected point: after the RFCOMM and L2CAP layers had disconnected but before the HCI layer had disconnected. 3. After receiving the Encryption Key Size Response at the time described in point 2, the host still called the rfcomm_check_security function. However, by this time `struct l2cap_conn *conn = l2cap_pi(sk)->chan->conn;` had already been released, and when the function executed `return hci_conn_security(conn->hcon, d->sec_level, auth_type, d->out);`, specifically when accessing `conn->hcon`, a null-ptr-deref error occurred. To fix this bug, check if `sk->sk_state` is BT_CLOSED before calling rfcomm_recv_frame in rfcomm_process_rx. Signed-off-by: Yuxuan Hu <20373622(a)buaa.edu.cn> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com> Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> --- net/bluetooth/rfcomm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c index 8d6fce9005bd..4f54c7df3a94 100644 --- a/net/bluetooth/rfcomm/core.c +++ b/net/bluetooth/rfcomm/core.c @@ -1937,7 +1937,7 @@ static struct rfcomm_session *rfcomm_process_rx(struct rfcomm_session *s) /* Get data directly from socket receive queue without copying it. */ while ((skb = skb_dequeue(&sk->sk_receive_queue))) { skb_orphan(skb); - if (!skb_linearize(skb)) { + if (!skb_linearize(skb) && sk->sk_state != BT_CLOSED) { s = rfcomm_recv_frame(s, skb); if (!s) break; -- 2.34.1

2 1

[openeuler:openEuler-1.0-LTS 16561/21577] mm/pin_mem.c:228:31: error: 'HUGETLB_PAGE_DTOR' undeclared; did you mean 'HUGETLB_PAGE_ORDER'?
by kernel test robot 27 Jan '24

27 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 992b5fc139d3aa14b25613b06adee4bb9c110b28 commit: 1a378b87531ea80e7847bf0105adedff28a73080 [16561/21577] mm: add pin memory method for checkpoint add restore config: arm64-randconfig-003-20240125 (https://download.01.org/0day-ci/archive/20240127/202401271117.5DMuyrks-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401271117.5DMuyrks-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401271117.5DMuyrks-lkp@intel.com/ All errors (new ones prefixed by >>): mm/pin_mem.c:171:6: warning: no previous prototype for 'reserve_page_from_buddy' [-Wmissing-prototypes] 171 | void reserve_page_from_buddy(unsigned long nr_pages, struct page *page) | ^~~~~~~~~~~~~~~~~~~~~~~ mm/pin_mem.c: In function 'init_huge_pmd_pages': >> mm/pin_mem.c:228:31: error: 'HUGETLB_PAGE_DTOR' undeclared (first use in this function); did you mean 'HUGETLB_PAGE_ORDER'? 228 | page->compound_dtor = HUGETLB_PAGE_DTOR + 1; | ^~~~~~~~~~~~~~~~~ | HUGETLB_PAGE_ORDER mm/pin_mem.c:228:31: note: each undeclared identifier is reported only once for each function it appears in mm/pin_mem.c: At top level: mm/pin_mem.c:254:6: warning: no previous prototype for 'free_user_map_pages' [-Wmissing-prototypes] 254 | void free_user_map_pages(unsigned int pid_index, unsigned int entry_index, unsigned int page_index) | ^~~~~~~~~~~~~~~~~~~ mm/pin_mem.c:311:6: warning: no previous prototype for 'check_redirect_end_valid' [-Wmissing-prototypes] 311 | bool check_redirect_end_valid(struct redirect_info *redirect_start, | ^~~~~~~~~~~~~~~~~~~~~~~~ mm/pin_mem.c:392:5: warning: no previous prototype for 'calculate_pin_mem_digest' [-Wmissing-prototypes] 392 | int calculate_pin_mem_digest(struct pin_mem_dump_info *pmdi, char *digest) | ^~~~~~~~~~~~~~~~~~~~~~~~ mm/pin_mem.c:481:5: warning: no previous prototype for 'collect_pmd_huge_pages' [-Wmissing-prototypes] 481 | int collect_pmd_huge_pages(struct task_struct *task, | ^~~~~~~~~~~~~~~~~~~~~~ mm/pin_mem.c:544:5: warning: no previous prototype for 'collect_normal_pages' [-Wmissing-prototypes] 544 | int collect_normal_pages(struct task_struct *task, | ^~~~~~~~~~~~~~~~~~~~ mm/pin_mem.c: In function 'collect_normal_pages': mm/pin_mem.c:549:26: warning: variable 'nr_pages' set but not used [-Wunused-but-set-variable] 549 | unsigned long i, nr_pages; | ^~~~~~~~ mm/pin_mem.c: At top level: mm/pin_mem.c:610:6: warning: no previous prototype for 'free_pin_pages' [-Wmissing-prototypes] 610 | void free_pin_pages(struct page_map_entry *pme) | ^~~~~~~~~~~~~~ mm/pin_mem.c:770:12: warning: no previous prototype for 'remap_normal_pages' [-Wmissing-prototypes] 770 | vm_fault_t remap_normal_pages(struct mm_struct *mm, struct vm_area_struct *vma, | ^~~~~~~~~~~~~~~~~~ mm/pin_mem.c:857:12: warning: no previous prototype for 'remap_huge_pmd_pages' [-Wmissing-prototypes] 857 | vm_fault_t remap_huge_pmd_pages(struct mm_struct *mm, struct vm_area_struct *vma, | ^~~~~~~~~~~~~~~~~~~~ vim +228 mm/pin_mem.c 211 212 static void init_huge_pmd_pages(struct page *head_page) 213 { 214 int i = 0; 215 struct page *page = head_page; 216 unsigned long *temp; 217 unsigned long compound_pad = COMPOUND_PAD_START; 218 219 __set_bit(PG_head, &page->flags); 220 __set_bit(PG_active, &page->flags); 221 atomic_set(&page->_refcount, 1); 222 page++; 223 i++; 224 page->compound_head = (unsigned long)head_page + 1; 225 page->_compound_pad_2 = (unsigned long)head_page & COMPOUND_PAD_MASK; 226 temp = (unsigned long *)(&(page->_compound_pad_2)); 227 temp[1] = LIST_POISON4; > 228 page->compound_dtor = HUGETLB_PAGE_DTOR + 1; 229 page->compound_order = HPAGE_PMD_ORDER; 230 page++; 231 i++; 232 page->compound_head = (unsigned long)head_page + 1; 233 page->_compound_pad_2 = (unsigned long)head_page + compound_pad; 234 i++; 235 236 INIT_LIST_HEAD(&(page->deferred_list)); 237 for (; i < HPAGE_PMD_NR; i++) { 238 page = head_page + i; 239 page->compound_head = (unsigned long)head_page + 1; 240 compound_pad += COMPOUND_PAD_DELTA; 241 page->_compound_pad_2 = (unsigned long)head_page + compound_pad; 242 temp = (unsigned long *)(&(page->_compound_pad_2)); 243 temp[1] = LIST_POISON4; 244 } 245 } 246 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH openEuler-1.0-LTS 0/1] crypto: scomp - fix req->dst buffer overflow
by felix 27 Jan '24

27 Jan '24

From: Felix Fu <fuzhen5(a)huawei.com> *** BLURB HERE *** Chengming Zhou (1): crypto: scomp - fix req->dst buffer overflow crypto/scompress.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.34.1

1 1

[PATCH openEuler-1.0-LTS] nfc: nci: fix possible NULL pointer dereference in send_acknowledge()
by Ziyang Xuan 27 Jan '24

27 Jan '24

From: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> stable inclusion from stable-v4.19.297 commit 5622592f8f74ae3e594379af02e64ea84772d0dd category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I8YCSH CVE: CVE-2023-46343 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- commit 7937609cd387246aed994e81aa4fa951358fba41 upstream. Handle memory allocation failure from nci_skb_alloc() (calling alloc_skb()) to avoid possible NULL pointer dereference. Reported-by: 黄思聪 <huangsicong(a)iie.ac.cn> Fixes: 391d8a2da787 ("NFC: Add NCI over SPI receive") Cc: <stable(a)vger.kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> Reviewed-by: Simon Horman <horms(a)kernel.org> Link: https://lore.kernel.org/r/20231013184129.18738-1-krzysztof.kozlowski@linaro… Signed-off-by: Jakub Kicinski <kuba(a)kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Ziyang Xuan <william.xuanziyang(a)huawei.com> --- net/nfc/nci/spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/nfc/nci/spi.c b/net/nfc/nci/spi.c index 452f4c16b7a9..d2de7fc226f0 100644 --- a/net/nfc/nci/spi.c +++ b/net/nfc/nci/spi.c @@ -163,6 +163,8 @@ static int send_acknowledge(struct nci_spi *nspi, u8 acknowledge) int ret; skb = nci_skb_alloc(nspi->ndev, 0, GFP_KERNEL); + if (!skb) + return -ENOMEM; /* add the NCI SPI header to the start of the buffer */ hdr = skb_push(skb, NCI_SPI_HDR_LEN); -- 2.25.1

1 0

[openeuler:openEuler-1.0-LTS 20469/21577] arch/x86/entry/entry_64.o: warning: objtool: If this is a retpoline, please patch it in with alternatives and annotate it with ANNOTATE_NOSPEC_ALTERNATIVE.
by kernel test robot 27 Jan '24

27 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 992b5fc139d3aa14b25613b06adee4bb9c110b28 commit: 3acbac72baea337e0ac79801a8ba4b81e3b67014 [20469/21577] x86/speculation: Change FILL_RETURN_BUFFER to work with objtool config: x86_64-randconfig-001-20240125 (https://download.01.org/0day-ci/archive/20240127/202401270508.Gi2jxRRU-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401270508.Gi2jxRRU-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401270508.Gi2jxRRU-lkp@intel.com/ All warnings (new ones prefixed by >>): >> arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x1d2: unsupported intra-function call >> arch/x86/entry/entry_64.o: warning: objtool: If this is a retpoline, please patch it in with alternatives and annotate it with ANNOTATE_NOSPEC_ALTERNATIVE. -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 13850/21577] arch/arm64/mm/init.c:784:17: error: 'mem_sleep_current' undeclared
by kernel test robot 27 Jan '24

27 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 992b5fc139d3aa14b25613b06adee4bb9c110b28 commit: fdda68feeca82610ccbcdcbda7250623a6d187d2 [13850/21577] arm64/ascend: Set mem_sleep_current to PM_SUSPEND_ON for ascend platform config: arm64-randconfig-002-20240125 (https://download.01.org/0day-ci/archive/20240127/202401270152.apkuohJO-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401270152.apkuohJO-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401270152.apkuohJO-lkp@intel.com/ All errors (new ones prefixed by >>): arch/arm64/mm/init.c:469:13: warning: no previous prototype for 'arm64_memblock_init' [-Wmissing-prototypes] 469 | void __init arm64_memblock_init(void) | ^~~~~~~~~~~~~~~~~~~ arch/arm64/mm/init.c: In function 'ascend_enable_setup': >> arch/arm64/mm/init.c:784:17: error: 'mem_sleep_current' undeclared (first use in this function) 784 | mem_sleep_current = PM_SUSPEND_ON; | ^~~~~~~~~~~~~~~~~ arch/arm64/mm/init.c:784:17: note: each undeclared identifier is reported only once for each function it appears in vim +/mem_sleep_current +784 arch/arm64/mm/init.c 770 771 #ifdef CONFIG_ASCEND_FEATURES 772 static int __init ascend_enable_setup(char *__unused) 773 { 774 if (IS_ENABLED(CONFIG_ASCEND_DVPP_MMAP)) 775 enable_mmap_dvpp = 1; 776 777 if (IS_ENABLED(CONFIG_ASCEND_IOPF_HIPRI)) 778 enable_iopf_hipri = 1; 779 780 if (IS_ENABLED(CONFIG_ASCEND_CHARGE_MIGRATE_HUGEPAGES)) 781 enable_charge_mighp = 1; 782 783 if (IS_ENABLED(CONFIG_SUSPEND)) > 784 mem_sleep_current = PM_SUSPEND_ON; 785 786 return 1; 787 } 788 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH openEuler-1.0-LTS] crypto: hisilicon/qm - drop unnecessary IS_ENABLE(CONFIG_NUMA) check
by wangyuan 26 Jan '24

26 Jan '24

driver inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8ZA13 CVE: NA -------------------------------------------------------------------- dev_to_node() can handle the case when CONFIG_NUMA is not set, so the check of CONFIG_NUMA is redundant and can be removed. Signed-off-by: wangyuan <wangyuan46(a)huawei.com> --- drivers/crypto/hisilicon/qm.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 6abaec751867..5cab0bd77169 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -3503,16 +3503,14 @@ static int hisi_qm_sort_devices(int node, struct list_head *head, struct hisi_qm *qm; struct list_head *n; struct device *dev; - int dev_node = 0; + int dev_node; list_for_each_entry(qm, &qm_list->list, list) { dev = &qm->pdev->dev; - if (IS_ENABLED(CONFIG_NUMA)) { - dev_node = dev->numa_node; - if (dev_node < 0) - dev_node = 0; - } + dev_node = dev_to_node(dev); + if (dev_node < 0) + dev_node = 0; if (qm_list->check && !qm_list->check(qm)) continue; -- 2.33.0

1 0

[PATCH OLK-5.10 0/2] fix spinlock already unlocked in inet_csk_reqsk_queue_add' bug
by Zhengchao Shao 26 Jan '24

26 Jan '24

Fix spinlock already unlocked in inet_csk_reqsk_queue_add' bug. Zhengchao Shao (2): tcp: make sure init the accept_queue's spinlocks once ipv6: init the accept_queue's spinlocks in inet6_create include/net/inet_connection_sock.h | 8 ++++++++ net/core/request_sock.c | 3 --- net/ipv4/af_inet.c | 3 +++ net/ipv4/inet_connection_sock.c | 4 ++++ net/ipv6/af_inet6.c | 3 +++ 5 files changed, 18 insertions(+), 3 deletions(-) -- 2.34.1

2 3

[PATCH openEuler-1.0-LTS 0/2] fix spinlock already unlocked in inet_csk_reqsk_queue_add' bug
by Zhengchao Shao 26 Jan '24

26 Jan '24

Fix spinlock already unlocked in inet_csk_reqsk_queue_add' bug. Zhengchao Shao (2): tcp: make sure init the accept_queue's spinlocks once ipv6: init the accept_queue's spinlocks in inet6_create include/net/inet_connection_sock.h | 9 +++++++++ net/core/request_sock.c | 3 --- net/ipv4/af_inet.c | 3 +++ net/ipv4/inet_connection_sock.c | 4 ++++ net/ipv6/af_inet6.c | 3 +++ 5 files changed, 19 insertions(+), 3 deletions(-) -- 2.34.1

2 3

[PATCH OLK-6.6 0/2] mm: add swappiness= arg to memory.reclaim
by Jinjiang Tu 26 Jan '24

26 Jan '24

Allow proactive reclaimers to submit an additional swappiness= argument to memory.reclaim. This overrides the global or per-memcg swappiness setting for that reclaim attempt. Dan Schatzberg (2): mm: add defines for min/max swappiness mm: add swappiness= arg to memory.reclaim Documentation/admin-guide/cgroup-v2.rst | 18 +++++++++--- include/linux/swap.h | 5 +++- mm/memcontrol.c | 38 ++++++++++++++++-------- mm/vmscan.c | 39 ++++++++++++++++++------- 4 files changed, 73 insertions(+), 27 deletions(-) -- 2.25.1

1 2

[openeuler:OLK-6.6 2688/2772] WARNING: modpost: vmlinux: section mismatch in reference: resctrl_init+0x6c (section: .text) -> rdtgroup_setup_default (section: .init.text)
by kernel test robot 26 Jan '24

26 Jan '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 171c8e9da50fa0469772aff8e1c60184f51b55f6 commit: c5a4bf91167c714de74c47f5cd6d888c66e9860d [2688/2772] arm64: mpam: Select ARCH_HAS_CPU_RESCTRL config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20240126/202401261430.Xq824gQ5-lkp@…) compiler: clang version 18.0.0git (https://github.com/llvm/llvm-project a31a60074717fc40887cfe132b77eec93bedd307) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401261430.Xq824gQ5-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401261430.Xq824gQ5-lkp@intel.com/ All warnings (new ones prefixed by >>, old ones prefixed by <<): WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o >> WARNING: modpost: vmlinux: section mismatch in reference: resctrl_init+0x6c (section: .text) -> rdtgroup_setup_default (section: .init.text) WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm64/kernel/arm64-reloc-test.o WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm64/crypto/crct10dif-ce.o WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm64/crypto/poly1305-neon.o WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm64/crypto/aes-neon-bs.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/locking/locktorture.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/locking/test-ww_mutex.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/rcu/rcutorture.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/rcu/rcuscale.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/rcu/refscale.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/test_udelay.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/time_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/trace/preemptirq_delay_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/kcsan/kcsan_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/backtracetest.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/torture.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/resource_kunit.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/sysctl-test.o WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/scftorture.o WARNING: modpost: missing MODULE_DESCRIPTION() in mm/kfence/kfence_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in mm/dmapool_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in mm/hwpoison-inject.o WARNING: modpost: missing MODULE_DESCRIPTION() in mm/zsmalloc.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/nfs_acl.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs_common/grace.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp437.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp737.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp775.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp850.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp852.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp855.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp857.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp860.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp861.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp862.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp863.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp864.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp865.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp866.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp869.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp874.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp932.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_euc-jp.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp936.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp949.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp950.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp1250.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp1251.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_ascii.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-1.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-2.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-3.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-4.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-5.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-6.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-7.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_cp1255.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-9.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-13.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-14.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-15.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_koi8-r.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_koi8-u.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_koi8-ru.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_utf8.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-celtic.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-centeuro.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-croatian.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-cyrillic.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-gaelic.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-greek.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-iceland.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-inuit.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-romanian.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-roman.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/mac-turkish.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_ucs2_utils.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/unicode/utf8data.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/unicode/utf8-selftest.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/binfmt_misc.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/binfmt_script.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/ext4/ext4-inode-test.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/jbd2/jbd2.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/cramfs/cramfs.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/minix/minix.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/fat/fat.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/fat/fat_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/isofs/isofs.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/hfs/hfs.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfs.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv2.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv3.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nfs/nfsv4.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/sysv/sysv.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/smb/common/cifs_arc4.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/smb/common/cifs_md4.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/hpfs/hpfs.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/ufs/ufs.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/efs/efs.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/qnx4/qnx4.o WARNING: modpost: missing MODULE_DESCRIPTION() in fs/qnx6/qnx6.o -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 V2] pciehp: fix a race between pciehp and removing operations by sysfs
by Xiongfeng Wang 26 Jan '24

26 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8YPFU CVE: NA ------------------------------------------------- When I run a stress test about pcie hotplug and removing operations by sysfs, I got a hange task, and the following call trace is printed. INFO: task irq/746-pciehp:41551 blocked for more than 120 seconds. Tainted: P W OE 4.19.25- "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. irq/746-pciehp D 0 41551 2 0x00000228 Call trace: __switch_to+0x94/0xe8 __schedule+0x270/0x8b0 schedule+0x2c/0x88 schedule_preempt_disabled+0x14/0x20 __mutex_lock.isra.1+0x1fc/0x540 __mutex_lock_slowpath+0x24/0x30 mutex_lock+0x80/0xa8 pci_lock_rescan_remove+0x20/0x28 pciehp_configure_device+0x30/0x140 pciehp_handle_presence_or_link_change+0x35c/0x4b0 pciehp_ist+0x1cc/0x1d0 irq_thread_fn+0x30/0x80 irq_thread+0x128/0x200 kthread+0x134/0x138 ret_from_fork+0x10/0x18 INFO: task bash:6424 blocked for more than 120 seconds. Tainted: P W OE 4.19.25- "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. bash D 0 6424 2231 0x00000200 Call trace: __switch_to+0x94/0xe8 __schedule+0x270/0x8b0 schedule+0x2c/0x88 schedule_timeout+0x224/0x448 wait_for_common+0x198/0x2a0 wait_for_completion+0x28/0x38 kthread_stop+0x60/0x190 __free_irq+0x1c0/0x348 free_irq+0x40/0x88 pcie_shutdown_notification+0x54/0x80 pciehp_remove+0x30/0x50 pcie_port_remove_service+0x3c/0x58 device_release_driver_internal+0x1b4/0x250 device_release_driver+0x28/0x38 bus_remove_device+0xd4/0x160 device_del+0x128/0x348 device_unregister+0x24/0x78 remove_iter+0x48/0x58 device_for_each_child+0x6c/0xb8 pcie_port_device_remove+0x2c/0x48 pcie_portdrv_remove+0x5c/0x68 pci_device_remove+0x48/0xd8 device_release_driver_internal+0x1b4/0x250 device_release_driver+0x28/0x38 pci_stop_bus_device+0x84/0xb8 pci_stop_and_remove_bus_device_locked+0x24/0x40 remove_store+0xa4/0xb8 dev_attr_store+0x44/0x60 sysfs_kf_write+0x58/0x80 kernfs_fop_write+0xe8/0x1f0 __vfs_write+0x60/0x190 vfs_write+0xac/0x1c0 ksys_write+0x6c/0xd8 __arm64_sys_write+0x24/0x30 el0_svc_common+0xa0/0x180 el0_svc_handler+0x38/0x78 el0_svc+0x8/0xc When we remove a slot by sysfs. 'pci_stop_and_remove_bus_device_locked()' will be called. This function will get the global mutex lock 'pci_rescan_remove_lock', and remove the slot. If the irq thread 'pciehp_ist' is still running, we will wait until it exits. If a pciehp interrupt happens immediately after we remove the slot by sysfs, but before we free the pciehp irq in 'pci_stop_and_remove_bus_device_locked()'. 'pciehp_ist' will hung because the global mutex lock 'pci_rescan_remove_lock' is held by the sysfs operation. But the sysfs operation is waiting for the pciehp irq thread 'pciehp_ist' ends. Then a hung task occurs. So this two kinds of operation, removing through attention buttion and removing through /sys/devices/pci***/remove, should not be excuted at the same time. This patch add a global variable to mark that one of these operations is under processing. When this variable is set, if another operation is requested, it will be rejected. We use a global variable 'slot_being_removed_rescaned' to mark whether a slot is being removed or rescaned. This will cause a slot hotplug operation is delayed if another slot is being remove or rescaned. But if these two slots are under different root ports, they should not influence each other. This patch make the flag 'slot_being_removed_rescanned' per root port so that one slot hotplug operation doesn't influence slots below another root port. We record the root port in struct pci_dev when the pci device is initialized and added into the system instead of using 'pcie_find_root_port()' to find the root port when we need it. Because iterating the pci tree needs the protection of 'pci_lock_rescan_remove()'. This will make the problem more complexed because the lock is very coarse-grained. We don't need to worry about 'use-after-free' because child pci devices are always removed before the root port device is removed. Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> Reviewed-by: Hanjun Guo <guohanjun(a)huawei.com> Conflicts: drivers/pci/hotplug/pciehp_ctrl.c drivers/pci/hotplug/pciehp_hpc.c include/linux/pci.h Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> --- drivers/pci/hotplug/pciehp.h | 5 ++ drivers/pci/hotplug/pciehp_ctrl.c | 40 ++++++++++++++++ drivers/pci/hotplug/pciehp_hpc.c | 79 ++++++++++++++++++++++++++----- drivers/pci/pci-sysfs.c | 22 +++++++++ drivers/pci/probe.c | 5 ++ include/linux/pci.h | 8 ++++ include/linux/workqueue.h | 2 + 7 files changed, 150 insertions(+), 11 deletions(-) diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h index e0a614acee05..dad48d151ce2 100644 --- a/drivers/pci/hotplug/pciehp.h +++ b/drivers/pci/hotplug/pciehp.h @@ -199,6 +199,11 @@ static inline const char *slot_name(struct controller *ctrl) return hotplug_slot_name(&ctrl->hotplug_slot); } +static inline struct pci_dev *ctrl_dev(struct controller *ctrl) +{ + return ctrl->pcie->port; +} + static inline struct controller *to_ctrl(struct hotplug_slot *hotplug_slot) { return container_of(hotplug_slot, struct controller, hotplug_slot); diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c index dcdbfcf404dd..458ab6f6379c 100644 --- a/drivers/pci/hotplug/pciehp_ctrl.c +++ b/drivers/pci/hotplug/pciehp_ctrl.c @@ -143,6 +143,8 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) { struct controller *ctrl = container_of(work, struct controller, button_work.work); + int events = ctrl->button_work.data; + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; mutex_lock(&ctrl->state_lock); switch (ctrl->state) { @@ -153,6 +155,15 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) pciehp_request(ctrl, PCI_EXP_SLTSTA_PDC); break; default: + if (events) { + atomic_or(events, &ctrl->pending_events); + if (!pciehp_poll_mode) + irq_wake_thread(ctrl->pcie->irq, ctrl); + } else { + if (rpdev) + clear_bit(0, + &rpdev->slot_being_removed_rescanned); + } break; } mutex_unlock(&ctrl->state_lock); @@ -160,6 +171,8 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) void pciehp_handle_button_press(struct controller *ctrl) { + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; + mutex_lock(&ctrl->state_lock); switch (ctrl->state) { case OFF_STATE: @@ -176,6 +189,7 @@ void pciehp_handle_button_press(struct controller *ctrl) /* blink power indicator and turn off attention */ pciehp_set_indicators(ctrl, PCI_EXP_SLTCTL_PWR_IND_BLINK, PCI_EXP_SLTCTL_ATTN_IND_OFF); + ctrl->button_work.data = 0; schedule_delayed_work(&ctrl->button_work, 5 * HZ); break; case BLINKINGOFF_STATE: @@ -199,10 +213,14 @@ void pciehp_handle_button_press(struct controller *ctrl) ctrl_info(ctrl, "Slot(%s): Button press: canceling request to power on\n", slot_name(ctrl)); } + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); break; default: ctrl_err(ctrl, "Slot(%s): Button press: ignoring invalid state %#x\n", slot_name(ctrl), ctrl->state); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); break; } mutex_unlock(&ctrl->state_lock); @@ -210,6 +228,8 @@ void pciehp_handle_button_press(struct controller *ctrl) void pciehp_handle_disable_request(struct controller *ctrl) { + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; + mutex_lock(&ctrl->state_lock); switch (ctrl->state) { case BLINKINGON_STATE: @@ -221,11 +241,14 @@ void pciehp_handle_disable_request(struct controller *ctrl) mutex_unlock(&ctrl->state_lock); ctrl->request_result = pciehp_disable_slot(ctrl, SAFE_REMOVAL); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); } void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events) { int present, link_active; + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; /* * If the slot is on and presence or link has changed, turn it off. @@ -266,6 +289,8 @@ void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events) slot_name(ctrl)); } mutex_unlock(&ctrl->state_lock); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); return; } @@ -288,6 +313,8 @@ void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events) mutex_unlock(&ctrl->state_lock); break; } + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); } static int __pciehp_enable_slot(struct controller *ctrl) @@ -408,6 +435,14 @@ int pciehp_sysfs_enable_slot(struct hotplug_slot *hotplug_slot) int pciehp_sysfs_disable_slot(struct hotplug_slot *hotplug_slot) { struct controller *ctrl = to_ctrl(hotplug_slot); + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; + + if (rpdev && test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned)) { + ctrl_info(ctrl, "Slot(%s): Slot is being removed or rescanned, please try later!\n", + slot_name(ctrl)); + return -EINVAL; + } mutex_lock(&ctrl->state_lock); switch (ctrl->state) { @@ -418,6 +453,8 @@ int pciehp_sysfs_disable_slot(struct hotplug_slot *hotplug_slot) wait_event(ctrl->requester, !atomic_read(&ctrl->pending_events) && !ctrl->ist_running); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); return ctrl->request_result; case POWEROFF_STATE: ctrl_info(ctrl, "Slot(%s): Already in powering off state\n", @@ -436,5 +473,8 @@ int pciehp_sysfs_disable_slot(struct hotplug_slot *hotplug_slot) } mutex_unlock(&ctrl->state_lock); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); + return -ENODEV; } diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index fd713abdfb9f..a0fdcd4dc358 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -45,11 +45,6 @@ static const struct dmi_system_id inband_presence_disabled_dmi_table[] = { {} }; -static inline struct pci_dev *ctrl_dev(struct controller *ctrl) -{ - return ctrl->pcie->port; -} - static irqreturn_t pciehp_isr(int irq, void *dev_id); static irqreturn_t pciehp_ist(int irq, void *dev_id); static int pciehp_poll(void *data); @@ -694,6 +689,7 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) { struct controller *ctrl = (struct controller *)dev_id; struct pci_dev *pdev = ctrl_dev(ctrl); + struct pci_dev *rpdev = pdev->rpdev; irqreturn_t ret; u32 events; @@ -716,8 +712,20 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) } /* Check Attention Button Pressed */ - if (events & PCI_EXP_SLTSTA_ABP) - pciehp_handle_button_press(ctrl); + if (events & PCI_EXP_SLTSTA_ABP) { + if (!rpdev || (rpdev && !test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned))) + pciehp_handle_button_press(ctrl); + else { + if (ctrl->state == BLINKINGOFF_STATE || + ctrl->state == BLINKINGON_STATE) + pciehp_handle_button_press(ctrl); + else + ctrl_info(ctrl, "Slot(%s): Slot operation failed because a remove or" + " rescan operation is under processing, please try later!\n", + slot_name(ctrl)); + } + } /* Check Power Fault Detected */ if (events & PCI_EXP_SLTSTA_PFD) { @@ -741,10 +749,59 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) * or Data Link Layer State Changed events. */ down_read_nested(&ctrl->reset_lock, ctrl->depth); - if (events & DISABLE_SLOT) - pciehp_handle_disable_request(ctrl); - else if (events & (PCI_EXP_SLTSTA_PDC | PCI_EXP_SLTSTA_DLLSC)) - pciehp_handle_presence_or_link_change(ctrl, events); + if (events & DISABLE_SLOT) { + if (!rpdev || (rpdev && !test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned))) + pciehp_handle_disable_request(ctrl); + else { + if (ctrl->state == BLINKINGOFF_STATE || + ctrl->state == BLINKINGON_STATE) + pciehp_handle_disable_request(ctrl); + else { + ctrl_info(ctrl, "Slot(%s): DISABLE_SLOT event in remove or rescan process!\n", + slot_name(ctrl)); + /* + * we use the work_struct private data to store + * the event type + */ + ctrl->button_work.data = DISABLE_SLOT; + /* + * If 'work.timer' is pending, schedule the work will + * cause BUG_ON(). + */ + if (!timer_pending(&ctrl->button_work.timer)) + schedule_delayed_work(&ctrl->button_work, 3 * HZ); + else + ctrl_info(ctrl, "Slot(%s): Didn't schedule delayed_work because timer is pending!\n", + slot_name(ctrl)); + } + } + } else if (events & (PCI_EXP_SLTSTA_PDC | PCI_EXP_SLTSTA_DLLSC)) { + if (!rpdev || (rpdev && !test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned))) + pciehp_handle_presence_or_link_change(ctrl, events); + else { + if (ctrl->state == BLINKINGOFF_STATE || + ctrl->state == BLINKINGON_STATE) + pciehp_handle_presence_or_link_change(ctrl, + events); + else { + /* + * When we are removing or rescanning through + * sysfs, suprise link down/up happens. So we + * will handle this event 3 seconds later. + */ + ctrl_info(ctrl, "Slot(%s): Surprise link down/up in remove or rescan process!\n", + slot_name(ctrl)); + ctrl->button_work.data = events & (PCI_EXP_SLTSTA_PDC | PCI_EXP_SLTSTA_DLLSC); + if (!timer_pending(&ctrl->button_work.timer)) + schedule_delayed_work(&ctrl->button_work, 3 * HZ); + else + ctrl_info(ctrl, "Slot(%s): Didn't schedule delayed_work because timer is pending!\n", + slot_name(ctrl)); + } + } + } up_read(&ctrl->reset_lock); ret = IRQ_HANDLED; diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index e3373cdc5244..c7e948b4a5fb 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -484,16 +484,38 @@ static ssize_t remove_store(struct device *dev, struct device_attribute *attr, { unsigned long val; struct pci_dev *pdev = to_pci_dev(dev); + struct pci_dev *rpdev = pdev->rpdev; if (kstrtoul(buf, 0, &val) < 0) return -EINVAL; + if (rpdev && test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned)) { + pr_info("Slot is being removed or rescanned, please try later!\n"); + return -EINVAL; + } + + /* + * if 'dev' is root port itself, 'pci_stop_and_remove_bus_device()' may + * free the 'rpdev', but we need to clear + * 'rpdev->slot_being_removed_rescanned' in the end. So get 'rpdev' to + * avoid possible 'use-after-free'. + */ + if (rpdev) + pci_dev_get(rpdev); + if (val) { pci_dev_get(pdev); if (device_remove_file_self(dev, attr)) pci_stop_and_remove_bus_device_locked(pdev); pci_dev_put(pdev); } + + if (rpdev) { + clear_bit(0, &rpdev->slot_being_removed_rescanned); + pci_dev_put(rpdev); + } + return count; } static DEVICE_ATTR_IGNORE_LOCKDEP(remove, 0220, NULL, diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 1681a9f454f4..ec710d190e6e 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -2584,6 +2584,11 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus) /* Set up MSI IRQ domain */ pci_set_msi_domain(dev); + if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) + dev->rpdev = dev; + else + dev->rpdev = pcie_find_root_port(dev); + /* Notifier could use PCI capabilities */ dev->match_driver = false; ret = device_add(&dev->dev); diff --git a/include/linux/pci.h b/include/linux/pci.h index 9c8d2cddf465..131fa5ce64df 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -529,6 +529,13 @@ struct pci_dev { /* These methods index pci_reset_fn_methods[] */ u8 reset_methods[PCI_NUM_RESET_METHODS]; /* In priority order */ + + /* + * This flag is only set on root ports. When a slot below a root port + * is being removed or rescanned, this flag is set. + */ + unsigned long slot_being_removed_rescanned; + struct pci_dev *rpdev; /* root port pci_dev */ }; static inline struct pci_dev *pci_physfn(struct pci_dev *dev) @@ -1082,6 +1089,7 @@ extern struct bus_type pci_bus_type; /* Do NOT directly access these two variables, unless you are arch-specific PCI * code, or PCI core code. */ extern struct list_head pci_root_buses; /* List of all known PCI buses */ + /* Some device drivers need know if PCI is initiated */ int no_pci_devices(void); diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h index 24b1e5070f4d..571dd2ec4381 100644 --- a/include/linux/workqueue.h +++ b/include/linux/workqueue.h @@ -115,6 +115,8 @@ struct delayed_work { /* target workqueue and CPU ->timer uses to queue ->work */ struct workqueue_struct *wq; int cpu; + /* delayed_work private data, only used in pciehp now */ + unsigned long data; }; struct rcu_work { -- 2.20.1

1 0

[PATCH OLK-6.6 00/24] Initial cleanups for vCPU hotplug
by liwei 26 Jan '24

26 Jan '24

This series aims to switch most architectures over to using generic CPU devices rather than arch specific implementations. James Morse (16): ACPI: scan: Use the acpi_device_is_present() helper in more places ACPI: scan: Rename acpi_scan_device_not_present() to be about enumeration arm64, irqchip/gic-v3, ACPI: Move MADT GICC enabled check into a helper arch_topology: Make register_cpu_capacity_sysctl() tolerant to late CPUs x86: intel_epb: Don't rely on link order ACPI: Move ACPI_HOTPLUG_CPU to be disabled on arm64 and riscv drivers: base: Use present CPUs in GENERIC_CPU_DEVICES drivers: base: Allow parts of GENERIC_CPU_DEVICES to be overridden drivers: base: Implement weak arch_unregister_cpu() drivers: base: Move cpu_dev_init() after node_dev_init() drivers: base: Print a warning instead of panic() when register_cpu() fails arm64: setup: Switch over to GENERIC_CPU_DEVICES using arch_register_cpu() x86/topology: Switch over to GENERIC_CPU_DEVICES LoongArch: Switch over to GENERIC_CPU_DEVICES LoongArch: Use the __weak version of arch_unregister_cpu() riscv: Switch over to GENERIC_CPU_DEVICES Russell King (Oracle) (8): x86/topology: remove arch_*register_cpu() exports Loongarch: remove arch_*register_cpu() exports drivers: base: add arch_cpu_is_hotpluggable() arm64: convert to arch_cpu_is_hotpluggable() x86/topology: use weak version of arch_unregister_cpu() x86/topology: convert to use arch_cpu_is_hotpluggable() LoongArch: convert to use arch_cpu_is_hotpluggable() riscv: convert to use arch_cpu_is_hotpluggable() arch/arm64/Kconfig | 1 + arch/arm64/include/asm/cpu.h | 1 - arch/arm64/kernel/setup.c | 13 ++-------- arch/arm64/kernel/smp.c | 2 +- arch/loongarch/Kconfig | 2 ++ arch/loongarch/kernel/topology.c | 42 ++------------------------------ arch/riscv/Kconfig | 1 + arch/riscv/kernel/setup.c | 18 ++------------ arch/x86/Kconfig | 2 ++ arch/x86/include/asm/cpu.h | 4 --- arch/x86/kernel/cpu/intel_epb.c | 2 +- arch/x86/kernel/topology.c | 33 ++----------------------- drivers/acpi/Kconfig | 1 - drivers/acpi/acpi_processor.c | 18 -------------- drivers/acpi/processor_core.c | 2 +- drivers/acpi/scan.c | 12 ++++----- drivers/base/arch_topology.c | 38 ++++++++++++++++++++--------- drivers/base/cpu.c | 39 +++++++++++++++++++++++------ drivers/base/init.c | 2 +- drivers/irqchip/irq-gic-v3.c | 10 +++----- include/linux/acpi.h | 5 ++++ include/linux/cpu.h | 5 ++++ 22 files changed, 95 insertions(+), 158 deletions(-) -- 2.25.1

1 24

[PATCH OLK-6.6 0/1] Use KABI_AUX_PTR macro to reserve KABI padding for
by Zheng Zengkai 26 Jan '24

26 Jan '24

Considering kabi reserve shortage, use KABI_AUX_PTR to extend some base structures before kabi freeze. KABI_AUX_PTR stores a pointer to the aux structure in the base struct. The lifecycle of the aux struct needs to be properly taken care of. Refer to include/linux/kabi.h for further usage details. Zheng Zengkai (1): KABI: Add KABI_AUX_PTR extenstions to some more base structures include/linux/device.h | 8 ++++++++ include/linux/device/class.h | 8 ++++++++ include/linux/device/driver.h | 8 ++++++++ include/linux/hrtimer.h | 8 ++++++++ include/linux/ipmi_smi.h | 11 +++++++++++ include/linux/mm_types.h | 10 ++++++++++ include/linux/netdevice.h | 8 ++++++++ include/linux/sched.h | 9 +++++++++ 8 files changed, 70 insertions(+) -- 2.20.1

2 2

[PATCH OLK-6.6] kabi: reserve space for struct ptp_clock
by Yang Yingliang 26 Jan '24

26 Jan '24

hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I8Z2NU CVE: NA ------------------------------- reserve space for struct ptp_clock. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- drivers/ptp/ptp_private.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/ptp/ptp_private.h b/drivers/ptp/ptp_private.h index b8d4f61f14be..b68fcd117064 100644 --- a/drivers/ptp/ptp_private.h +++ b/drivers/ptp/ptp_private.h @@ -53,6 +53,10 @@ struct ptp_clock { struct mutex n_vclocks_mux; /* protect concurrent n_vclocks access */ bool is_virtual_clock; bool has_cycles; + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; #define info_to_vclock(d) container_of((d), struct ptp_vclock, info) -- 2.25.1

1 0

[PATCH OLK-6.6] pci: Enable acs for QLogic HBA cards
by Zeng Heng 26 Jan '24

26 Jan '24

From: Xishi Qiu <qiuxishi(a)huawei.com> euler inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8Z1IW CVE: N/A ------------------------------------------------- Add support of port isolation for QLogic HBA cards. Signed-off-by: Xishi Qiu <qiuxishi(a)huawei.com> Signed-off-by: Fang Ying <fangying1(a)huawei.com> Signed-off-by: Kefeng Wang <wangkefeng.wang(a)huawei.com> Signed-off-by: Hui Wang <john.wanghui(a)huawei.com> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5(a)huawei.com> Confilicts: drivers/pci/quirks.c Signed-off-by: Xuefeng Wang <wxf.wang(a)hisilicon.com> Reviewed-by: Yang Yingliang <yangyingliang(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> Signed-off-by: Jialin Zhang <zhangjialin11(a)huawei.com> Confilicts: drivers/pci/quirks.c Reviewed-by: wangxiongfeng <wangxiongfeng2(a)huawei.com> Signed-off-by: Zheng Zengkai <zhengzengkai(a)huawei.com> Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- drivers/pci/quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index ae95d0950772..83a875b53111 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5050,6 +5050,8 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, pci_quirk_intel_spt_pch_acs }, { 0x19a2, 0x710, pci_quirk_mf_endpoint_acs }, /* Emulex BE3-R */ { 0x10df, 0x720, pci_quirk_mf_endpoint_acs }, /* Emulex Skyhawk-R */ + { 0x1077, 0x2031, pci_quirk_mf_endpoint_acs}, /* QLogic QL2672 */ + { 0x1077, 0x2532, pci_quirk_mf_endpoint_acs}, /* Cavium ThunderX */ { PCI_VENDOR_ID_CAVIUM, PCI_ANY_ID, pci_quirk_cavium_acs }, /* Cavium multi-function devices */ -- 2.25.1

2 1

[PATCH OLK-6.6 V2] pciehp: fix a race between pciehp and removing operations by sysfs
by Xiongfeng Wang 26 Jan '24

26 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8YPFU CVE: NA ------------------------------------------------- When I run a stress test about pcie hotplug and removing operations by sysfs, I got a hange task, and the following call trace is printed. INFO: task irq/746-pciehp:41551 blocked for more than 120 seconds. Tainted: P W OE 4.19.25- "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. irq/746-pciehp D 0 41551 2 0x00000228 Call trace: __switch_to+0x94/0xe8 __schedule+0x270/0x8b0 schedule+0x2c/0x88 schedule_preempt_disabled+0x14/0x20 __mutex_lock.isra.1+0x1fc/0x540 __mutex_lock_slowpath+0x24/0x30 mutex_lock+0x80/0xa8 pci_lock_rescan_remove+0x20/0x28 pciehp_configure_device+0x30/0x140 pciehp_handle_presence_or_link_change+0x35c/0x4b0 pciehp_ist+0x1cc/0x1d0 irq_thread_fn+0x30/0x80 irq_thread+0x128/0x200 kthread+0x134/0x138 ret_from_fork+0x10/0x18 INFO: task bash:6424 blocked for more than 120 seconds. Tainted: P W OE 4.19.25- "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. bash D 0 6424 2231 0x00000200 Call trace: __switch_to+0x94/0xe8 __schedule+0x270/0x8b0 schedule+0x2c/0x88 schedule_timeout+0x224/0x448 wait_for_common+0x198/0x2a0 wait_for_completion+0x28/0x38 kthread_stop+0x60/0x190 __free_irq+0x1c0/0x348 free_irq+0x40/0x88 pcie_shutdown_notification+0x54/0x80 pciehp_remove+0x30/0x50 pcie_port_remove_service+0x3c/0x58 device_release_driver_internal+0x1b4/0x250 device_release_driver+0x28/0x38 bus_remove_device+0xd4/0x160 device_del+0x128/0x348 device_unregister+0x24/0x78 remove_iter+0x48/0x58 device_for_each_child+0x6c/0xb8 pcie_port_device_remove+0x2c/0x48 pcie_portdrv_remove+0x5c/0x68 pci_device_remove+0x48/0xd8 device_release_driver_internal+0x1b4/0x250 device_release_driver+0x28/0x38 pci_stop_bus_device+0x84/0xb8 pci_stop_and_remove_bus_device_locked+0x24/0x40 remove_store+0xa4/0xb8 dev_attr_store+0x44/0x60 sysfs_kf_write+0x58/0x80 kernfs_fop_write+0xe8/0x1f0 __vfs_write+0x60/0x190 vfs_write+0xac/0x1c0 ksys_write+0x6c/0xd8 __arm64_sys_write+0x24/0x30 el0_svc_common+0xa0/0x180 el0_svc_handler+0x38/0x78 el0_svc+0x8/0xc When we remove a slot by sysfs. 'pci_stop_and_remove_bus_device_locked()' will be called. This function will get the global mutex lock 'pci_rescan_remove_lock', and remove the slot. If the irq thread 'pciehp_ist' is still running, we will wait until it exits. If a pciehp interrupt happens immediately after we remove the slot by sysfs, but before we free the pciehp irq in 'pci_stop_and_remove_bus_device_locked()'. 'pciehp_ist' will hung because the global mutex lock 'pci_rescan_remove_lock' is held by the sysfs operation. But the sysfs operation is waiting for the pciehp irq thread 'pciehp_ist' ends. Then a hung task occurs. So this two kinds of operation, removing through attention buttion and removing through /sys/devices/pci***/remove, should not be excuted at the same time. This patch add a global variable to mark that one of these operations is under processing. When this variable is set, if another operation is requested, it will be rejected. We use a global variable 'slot_being_removed_rescaned' to mark whether a slot is being removed or rescaned. This will cause a slot hotplug operation is delayed if another slot is being remove or rescaned. But if these two slots are under different root ports, they should not influence each other. This patch make the flag 'slot_being_removed_rescanned' per root port so that one slot hotplug operation doesn't influence slots below another root port. We record the root port in struct pci_dev when the pci device is initialized and added into the system instead of using 'pcie_find_root_port()' to find the root port when we need it. Because iterating the pci tree needs the protection of 'pci_lock_rescan_remove()'. This will make the problem more complexed because the lock is very coarse-grained. We don't need to worry about 'use-after-free' because child pci devices are always removed before the root port device is removed. Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> Reviewed-by: Hanjun Guo <guohanjun(a)huawei.com> Conflicts: drivers/pci/hotplug/pciehp_ctrl.c drivers/pci/hotplug/pciehp_hpc.c include/linux/pci.h Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> --- drivers/pci/hotplug/pciehp.h | 5 ++ drivers/pci/hotplug/pciehp_ctrl.c | 40 ++++++++++++++++ drivers/pci/hotplug/pciehp_hpc.c | 79 ++++++++++++++++++++++++++----- drivers/pci/pci-sysfs.c | 22 +++++++++ drivers/pci/probe.c | 5 ++ include/linux/pci.h | 8 ++++ include/linux/workqueue.h | 2 + 7 files changed, 150 insertions(+), 11 deletions(-) diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h index e0a614acee05..dad48d151ce2 100644 --- a/drivers/pci/hotplug/pciehp.h +++ b/drivers/pci/hotplug/pciehp.h @@ -199,6 +199,11 @@ static inline const char *slot_name(struct controller *ctrl) return hotplug_slot_name(&ctrl->hotplug_slot); } +static inline struct pci_dev *ctrl_dev(struct controller *ctrl) +{ + return ctrl->pcie->port; +} + static inline struct controller *to_ctrl(struct hotplug_slot *hotplug_slot) { return container_of(hotplug_slot, struct controller, hotplug_slot); diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c index dcdbfcf404dd..458ab6f6379c 100644 --- a/drivers/pci/hotplug/pciehp_ctrl.c +++ b/drivers/pci/hotplug/pciehp_ctrl.c @@ -143,6 +143,8 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) { struct controller *ctrl = container_of(work, struct controller, button_work.work); + int events = ctrl->button_work.data; + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; mutex_lock(&ctrl->state_lock); switch (ctrl->state) { @@ -153,6 +155,15 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) pciehp_request(ctrl, PCI_EXP_SLTSTA_PDC); break; default: + if (events) { + atomic_or(events, &ctrl->pending_events); + if (!pciehp_poll_mode) + irq_wake_thread(ctrl->pcie->irq, ctrl); + } else { + if (rpdev) + clear_bit(0, + &rpdev->slot_being_removed_rescanned); + } break; } mutex_unlock(&ctrl->state_lock); @@ -160,6 +171,8 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) void pciehp_handle_button_press(struct controller *ctrl) { + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; + mutex_lock(&ctrl->state_lock); switch (ctrl->state) { case OFF_STATE: @@ -176,6 +189,7 @@ void pciehp_handle_button_press(struct controller *ctrl) /* blink power indicator and turn off attention */ pciehp_set_indicators(ctrl, PCI_EXP_SLTCTL_PWR_IND_BLINK, PCI_EXP_SLTCTL_ATTN_IND_OFF); + ctrl->button_work.data = 0; schedule_delayed_work(&ctrl->button_work, 5 * HZ); break; case BLINKINGOFF_STATE: @@ -199,10 +213,14 @@ void pciehp_handle_button_press(struct controller *ctrl) ctrl_info(ctrl, "Slot(%s): Button press: canceling request to power on\n", slot_name(ctrl)); } + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); break; default: ctrl_err(ctrl, "Slot(%s): Button press: ignoring invalid state %#x\n", slot_name(ctrl), ctrl->state); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); break; } mutex_unlock(&ctrl->state_lock); @@ -210,6 +228,8 @@ void pciehp_handle_button_press(struct controller *ctrl) void pciehp_handle_disable_request(struct controller *ctrl) { + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; + mutex_lock(&ctrl->state_lock); switch (ctrl->state) { case BLINKINGON_STATE: @@ -221,11 +241,14 @@ void pciehp_handle_disable_request(struct controller *ctrl) mutex_unlock(&ctrl->state_lock); ctrl->request_result = pciehp_disable_slot(ctrl, SAFE_REMOVAL); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); } void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events) { int present, link_active; + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; /* * If the slot is on and presence or link has changed, turn it off. @@ -266,6 +289,8 @@ void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events) slot_name(ctrl)); } mutex_unlock(&ctrl->state_lock); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); return; } @@ -288,6 +313,8 @@ void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events) mutex_unlock(&ctrl->state_lock); break; } + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); } static int __pciehp_enable_slot(struct controller *ctrl) @@ -408,6 +435,14 @@ int pciehp_sysfs_enable_slot(struct hotplug_slot *hotplug_slot) int pciehp_sysfs_disable_slot(struct hotplug_slot *hotplug_slot) { struct controller *ctrl = to_ctrl(hotplug_slot); + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; + + if (rpdev && test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned)) { + ctrl_info(ctrl, "Slot(%s): Slot is being removed or rescanned, please try later!\n", + slot_name(ctrl)); + return -EINVAL; + } mutex_lock(&ctrl->state_lock); switch (ctrl->state) { @@ -418,6 +453,8 @@ int pciehp_sysfs_disable_slot(struct hotplug_slot *hotplug_slot) wait_event(ctrl->requester, !atomic_read(&ctrl->pending_events) && !ctrl->ist_running); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); return ctrl->request_result; case POWEROFF_STATE: ctrl_info(ctrl, "Slot(%s): Already in powering off state\n", @@ -436,5 +473,8 @@ int pciehp_sysfs_disable_slot(struct hotplug_slot *hotplug_slot) } mutex_unlock(&ctrl->state_lock); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); + return -ENODEV; } diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index fd713abdfb9f..a0fdcd4dc358 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -45,11 +45,6 @@ static const struct dmi_system_id inband_presence_disabled_dmi_table[] = { {} }; -static inline struct pci_dev *ctrl_dev(struct controller *ctrl) -{ - return ctrl->pcie->port; -} - static irqreturn_t pciehp_isr(int irq, void *dev_id); static irqreturn_t pciehp_ist(int irq, void *dev_id); static int pciehp_poll(void *data); @@ -694,6 +689,7 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) { struct controller *ctrl = (struct controller *)dev_id; struct pci_dev *pdev = ctrl_dev(ctrl); + struct pci_dev *rpdev = pdev->rpdev; irqreturn_t ret; u32 events; @@ -716,8 +712,20 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) } /* Check Attention Button Pressed */ - if (events & PCI_EXP_SLTSTA_ABP) - pciehp_handle_button_press(ctrl); + if (events & PCI_EXP_SLTSTA_ABP) { + if (!rpdev || (rpdev && !test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned))) + pciehp_handle_button_press(ctrl); + else { + if (ctrl->state == BLINKINGOFF_STATE || + ctrl->state == BLINKINGON_STATE) + pciehp_handle_button_press(ctrl); + else + ctrl_info(ctrl, "Slot(%s): Slot operation failed because a remove or" + " rescan operation is under processing, please try later!\n", + slot_name(ctrl)); + } + } /* Check Power Fault Detected */ if (events & PCI_EXP_SLTSTA_PFD) { @@ -741,10 +749,59 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) * or Data Link Layer State Changed events. */ down_read_nested(&ctrl->reset_lock, ctrl->depth); - if (events & DISABLE_SLOT) - pciehp_handle_disable_request(ctrl); - else if (events & (PCI_EXP_SLTSTA_PDC | PCI_EXP_SLTSTA_DLLSC)) - pciehp_handle_presence_or_link_change(ctrl, events); + if (events & DISABLE_SLOT) { + if (!rpdev || (rpdev && !test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned))) + pciehp_handle_disable_request(ctrl); + else { + if (ctrl->state == BLINKINGOFF_STATE || + ctrl->state == BLINKINGON_STATE) + pciehp_handle_disable_request(ctrl); + else { + ctrl_info(ctrl, "Slot(%s): DISABLE_SLOT event in remove or rescan process!\n", + slot_name(ctrl)); + /* + * we use the work_struct private data to store + * the event type + */ + ctrl->button_work.data = DISABLE_SLOT; + /* + * If 'work.timer' is pending, schedule the work will + * cause BUG_ON(). + */ + if (!timer_pending(&ctrl->button_work.timer)) + schedule_delayed_work(&ctrl->button_work, 3 * HZ); + else + ctrl_info(ctrl, "Slot(%s): Didn't schedule delayed_work because timer is pending!\n", + slot_name(ctrl)); + } + } + } else if (events & (PCI_EXP_SLTSTA_PDC | PCI_EXP_SLTSTA_DLLSC)) { + if (!rpdev || (rpdev && !test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned))) + pciehp_handle_presence_or_link_change(ctrl, events); + else { + if (ctrl->state == BLINKINGOFF_STATE || + ctrl->state == BLINKINGON_STATE) + pciehp_handle_presence_or_link_change(ctrl, + events); + else { + /* + * When we are removing or rescanning through + * sysfs, suprise link down/up happens. So we + * will handle this event 3 seconds later. + */ + ctrl_info(ctrl, "Slot(%s): Surprise link down/up in remove or rescan process!\n", + slot_name(ctrl)); + ctrl->button_work.data = events & (PCI_EXP_SLTSTA_PDC | PCI_EXP_SLTSTA_DLLSC); + if (!timer_pending(&ctrl->button_work.timer)) + schedule_delayed_work(&ctrl->button_work, 3 * HZ); + else + ctrl_info(ctrl, "Slot(%s): Didn't schedule delayed_work because timer is pending!\n", + slot_name(ctrl)); + } + } + } up_read(&ctrl->reset_lock); ret = IRQ_HANDLED; diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index e3373cdc5244..c7e948b4a5fb 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -484,16 +484,38 @@ static ssize_t remove_store(struct device *dev, struct device_attribute *attr, { unsigned long val; struct pci_dev *pdev = to_pci_dev(dev); + struct pci_dev *rpdev = pdev->rpdev; if (kstrtoul(buf, 0, &val) < 0) return -EINVAL; + if (rpdev && test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned)) { + pr_info("Slot is being removed or rescanned, please try later!\n"); + return -EINVAL; + } + + /* + * if 'dev' is root port itself, 'pci_stop_and_remove_bus_device()' may + * free the 'rpdev', but we need to clear + * 'rpdev->slot_being_removed_rescanned' in the end. So get 'rpdev' to + * avoid possible 'use-after-free'. + */ + if (rpdev) + pci_dev_get(rpdev); + if (val) { pci_dev_get(pdev); if (device_remove_file_self(dev, attr)) pci_stop_and_remove_bus_device_locked(pdev); pci_dev_put(pdev); } + + if (rpdev) { + clear_bit(0, &rpdev->slot_being_removed_rescanned); + pci_dev_put(rpdev); + } + return count; } static DEVICE_ATTR_IGNORE_LOCKDEP(remove, 0220, NULL, diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 1681a9f454f4..ec710d190e6e 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -2584,6 +2584,11 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus) /* Set up MSI IRQ domain */ pci_set_msi_domain(dev); + if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) + dev->rpdev = dev; + else + dev->rpdev = pcie_find_root_port(dev); + /* Notifier could use PCI capabilities */ dev->match_driver = false; ret = device_add(&dev->dev); diff --git a/include/linux/pci.h b/include/linux/pci.h index 9c8d2cddf465..131fa5ce64df 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -529,6 +529,13 @@ struct pci_dev { /* These methods index pci_reset_fn_methods[] */ u8 reset_methods[PCI_NUM_RESET_METHODS]; /* In priority order */ + + /* + * This flag is only set on root ports. When a slot below a root port + * is being removed or rescanned, this flag is set. + */ + unsigned long slot_being_removed_rescanned; + struct pci_dev *rpdev; /* root port pci_dev */ }; static inline struct pci_dev *pci_physfn(struct pci_dev *dev) @@ -1082,6 +1089,7 @@ extern struct bus_type pci_bus_type; /* Do NOT directly access these two variables, unless you are arch-specific PCI * code, or PCI core code. */ extern struct list_head pci_root_buses; /* List of all known PCI buses */ + /* Some device drivers need know if PCI is initiated */ int no_pci_devices(void); diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h index 24b1e5070f4d..571dd2ec4381 100644 --- a/include/linux/workqueue.h +++ b/include/linux/workqueue.h @@ -115,6 +115,8 @@ struct delayed_work { /* target workqueue and CPU ->timer uses to queue ->work */ struct workqueue_struct *wq; int cpu; + /* delayed_work private data, only used in pciehp now */ + unsigned long data; }; struct rcu_work { -- 2.20.1

1 0

[PATCH OLK-5.10] netlink: fix potential sleeping issue in mqueue_flush_file
by Zhengchao Shao 26 Jan '24

26 Jan '24

mainline inclusion from mainline-v6.8-rc1 commit 234ec0b6034b16869d45128b8cd2dc6ffe596f04 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8Z1LM Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- I analyze the potential sleeping issue of the following processes: Thread A Thread B ... netlink_create //ref = 1 do_mq_notify ... sock = netlink_getsockbyfilp ... //ref = 2 info->notify_sock = sock; ... ... netlink_sendmsg ... skb = netlink_alloc_large_skb //skb->head is vmalloced ... netlink_unicast ... sk = netlink_getsockbyportid //ref = 3 ... netlink_sendskb ... __netlink_sendskb ... skb_queue_tail //put skb to sk_receive_queue ... sock_put //ref = 2 ... ... ... netlink_release ... deferred_put_nlk_sk //ref = 1 mqueue_flush_file spin_lock remove_notification netlink_sendskb sock_put //ref = 0 sk_free ... __sk_destruct netlink_sock_destruct skb_queue_purge //get skb from sk_receive_queue ... __skb_queue_purge_reason kfree_skb_reason __kfree_skb ... skb_release_all skb_release_head_state netlink_skb_destructor vfree(skb->head) //sleeping while holding spinlock In netlink_sendmsg, if the memory pointed to by skb->head is allocated by vmalloc, and is put to sk_receive_queue queue, also the skb is not freed. When the mqueue executes flush, the sleeping bug will occur. Use vfree_atomic instead of vfree in netlink_skb_destructor to solve the issue. Fixes: c05cdb1b864f ("netlink: allow large data transfers from user-space") Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> Link: https://lore.kernel.org/r/20240122011807.2110357-1-shaozhengchao@huawei.com Signed-off-by: Paolo Abeni <pabeni(a)redhat.com> Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> --- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 9737c3229c12..e3f34dccc97a 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -366,7 +366,7 @@ static void netlink_skb_destructor(struct sk_buff *skb) if (is_vmalloc_addr(skb->head)) { if (!skb->cloned || !atomic_dec_return(&(skb_shinfo(skb)->dataref))) - vfree(skb->head); + vfree_atomic(skb->head); skb->head = NULL; } -- 2.34.1

1 0

[PATCH openEuler-1.0-LTS] netlink: fix potential sleeping issue in mqueue_flush_file
by Zhengchao Shao 26 Jan '24

26 Jan '24

mainline inclusion from mainline-v6.8-rc1 commit 234ec0b6034b16869d45128b8cd2dc6ffe596f04 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8Z1LM Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- I analyze the potential sleeping issue of the following processes: Thread A Thread B ... netlink_create //ref = 1 do_mq_notify ... sock = netlink_getsockbyfilp ... //ref = 2 info->notify_sock = sock; ... ... netlink_sendmsg ... skb = netlink_alloc_large_skb //skb->head is vmalloced ... netlink_unicast ... sk = netlink_getsockbyportid //ref = 3 ... netlink_sendskb ... __netlink_sendskb ... skb_queue_tail //put skb to sk_receive_queue ... sock_put //ref = 2 ... ... ... netlink_release ... deferred_put_nlk_sk //ref = 1 mqueue_flush_file spin_lock remove_notification netlink_sendskb sock_put //ref = 0 sk_free ... __sk_destruct netlink_sock_destruct skb_queue_purge //get skb from sk_receive_queue ... __skb_queue_purge_reason kfree_skb_reason __kfree_skb ... skb_release_all skb_release_head_state netlink_skb_destructor vfree(skb->head) //sleeping while holding spinlock In netlink_sendmsg, if the memory pointed to by skb->head is allocated by vmalloc, and is put to sk_receive_queue queue, also the skb is not freed. When the mqueue executes flush, the sleeping bug will occur. Use vfree_atomic instead of vfree in netlink_skb_destructor to solve the issue. Fixes: c05cdb1b864f ("netlink: allow large data transfers from user-space") Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> Link: https://lore.kernel.org/r/20240122011807.2110357-1-shaozhengchao@huawei.com Signed-off-by: Paolo Abeni <pabeni(a)redhat.com> Signed-off-by: Zhengchao Shao <shaozhengchao(a)huawei.com> --- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 6b5be7a426ac..fd0fa4c37a3b 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -374,7 +374,7 @@ static void netlink_skb_destructor(struct sk_buff *skb) if (is_vmalloc_addr(skb->head)) { if (!skb->cloned || !atomic_dec_return(&(skb_shinfo(skb)->dataref))) - vfree(skb->head); + vfree_atomic(skb->head); skb->head = NULL; } -- 2.34.1

2 1

[PATCH OLK-6.6 V2] blk-mq: avoid housekeeping CPUs scheduling a worker on a non-housekeeping CPU
by Xiongfeng Wang 26 Jan '24

26 Jan '24

hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I8YB4M CVE: N/A --------------------------------- When NOHZ_FULL is enabled, such as in HPC situation, CPUs are divided into housekeeping CPUs and non-housekeeping CPUs. Non-housekeeping CPUs are NOHZ_FULL CPUs and are often monopolized by the userspace process, such HPC application process. Any sort of interruption is not expected. blk_mq_hctx_next_cpu() selects each cpu in 'hctx->cpumask' alternately to schedule the work thread blk_mq_run_work_fn(). When 'hctx->cpumask' contains housekeeping CPU and non-housekeeping CPU at the same time, a housekeeping CPU, which want to request a IO, may schedule a worker on a non-housekeeping CPU. This may affect the performance of the userspace application running on non-housekeeping CPUs. So let's just schedule the worker thread on the current CPU when the current CPU is housekeeping CPU. Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> --- block/blk-mq.c | 11 ++++++++++- include/linux/sched/isolation.h | 3 +++ kernel/sched/isolation.c | 8 ++++++++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 6ab7f360ff2a..52cfbeb75355 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -24,6 +24,7 @@ #include <linux/sched/sysctl.h> #include <linux/sched/topology.h> #include <linux/sched/signal.h> +#include <linux/sched/isolation.h> #include <linux/delay.h> #include <linux/crash_dump.h> #include <linux/prefetch.h> @@ -2214,9 +2215,17 @@ static int blk_mq_hctx_next_cpu(struct blk_mq_hw_ctx *hctx) */ void blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, unsigned long msecs) { + int work_cpu; + if (unlikely(blk_mq_hctx_stopped(hctx))) return; - kblockd_mod_delayed_work_on(blk_mq_hctx_next_cpu(hctx), &hctx->run_work, + + if (enhanced_isolcpus && tick_nohz_full_enabled() && + housekeeping_cpu(raw_smp_processor_id(), HK_TYPE_WQ)) + work_cpu = raw_smp_processor_id(); + else + work_cpu = blk_mq_hctx_next_cpu(hctx); + kblockd_mod_delayed_work_on(work_cpu, &hctx->run_work, msecs_to_jiffies(msecs)); } EXPORT_SYMBOL(blk_mq_delay_run_hw_queue); diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h index fe1a46f30d24..3894e74e8dc5 100644 --- a/include/linux/sched/isolation.h +++ b/include/linux/sched/isolation.h @@ -19,6 +19,7 @@ enum hk_type { }; #ifdef CONFIG_CPU_ISOLATION +extern bool enhanced_isolcpus; DECLARE_STATIC_KEY_FALSE(housekeeping_overridden); extern int housekeeping_any_cpu(enum hk_type type); extern const struct cpumask *housekeeping_cpumask(enum hk_type type); @@ -29,6 +30,8 @@ extern void __init housekeeping_init(void); #else +#define enhanced_isolcpus 0 + static inline int housekeeping_any_cpu(enum hk_type type) { return smp_processor_id(); diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c index 373d42c707bc..3884c245faf5 100644 --- a/kernel/sched/isolation.c +++ b/kernel/sched/isolation.c @@ -239,3 +239,11 @@ static int __init housekeeping_isolcpus_setup(char *str) return housekeeping_setup(str, flags); } __setup("isolcpus=", housekeeping_isolcpus_setup); + +bool enhanced_isolcpus; +static int __init enhanced_isolcpus_setup(char *str) +{ + enhanced_isolcpus = true; + return 0; +} +__setup("enhanced_isolcpus", enhanced_isolcpus_setup); -- 2.20.1

2 1

[PATCH OLK-6.6] pci: Enable acs for QLogic HBA cards
by Zeng Heng 26 Jan '24

26 Jan '24

From: Xishi Qiu <qiuxishi(a)huawei.com> euler inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8Z1IW CVE: N/A ------------------------------------------------- Add support of port isolation for QLogic HBA cards. Signed-off-by: Xishi Qiu <qiuxishi(a)huawei.com> Signed-off-by: Fang Ying <fangying1(a)huawei.com> Signed-off-by: Kefeng Wang <wangkefeng.wang(a)huawei.com> Signed-off-by: Hui Wang <john.wanghui(a)huawei.com> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5(a)huawei.com> Confilicts: drivers/pci/quirks.c Signed-off-by: Xuefeng Wang <wxf.wang(a)hisilicon.com> Reviewed-by: Yang Yingliang <yangyingliang(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> Signed-off-by: Jialin Zhang <zhangjialin11(a)huawei.com> Confilicts: drivers/pci/quirks.c Reviewed-by: wangxiongfeng <wangxiongfeng2(a)huawei.com> Signed-off-by: Zheng Zengkai <zhengzengkai(a)huawei.com> Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- drivers/pci/quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index ae95d0950772..83a875b53111 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5050,6 +5050,8 @@ static const struct pci_dev_acs_enabled { { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, pci_quirk_intel_spt_pch_acs }, { 0x19a2, 0x710, pci_quirk_mf_endpoint_acs }, /* Emulex BE3-R */ { 0x10df, 0x720, pci_quirk_mf_endpoint_acs }, /* Emulex Skyhawk-R */ + { 0x1077, 0x2031, pci_quirk_mf_endpoint_acs}, /* QLogic QL2672 */ + { 0x1077, 0x2532, pci_quirk_mf_endpoint_acs}, /* Cavium ThunderX */ { PCI_VENDOR_ID_CAVIUM, PCI_ANY_ID, pci_quirk_cavium_acs }, /* Cavium multi-function devices */ -- 2.25.1

1 0

[PATCH openEuler-1.0-LTS 0/2] dhugetlb: skip unexpected migration
by Liu Shixin 26 Jan '24

26 Jan '24

Fix unexpected migration of pages from dynamic hugetlb pool. Liu Shixin (2): dhugetlb: introduce page_belong_to_dynamic_hugetlb() function dhugetlb: skip unexpected migration include/linux/hugetlb.h | 5 +++++ include/linux/migrate.h | 6 +++++- mm/compaction.c | 3 +++ mm/hugetlb.c | 16 +++++++++++----- mm/mempolicy.c | 10 ++++++++-- mm/migrate.c | 3 +++ mm/page_isolation.c | 3 ++- 7 files changed, 37 insertions(+), 9 deletions(-) -- 2.25.1

2 3

[PATCH OLK-6.6] arm64: topology: Support PHYTIUM CPU
by Zeng Heng 26 Jan '24

26 Jan '24

From: Hanjun Guo <guohanjun(a)huawei.com> hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I8Z0KI CVE: NA --------------------------- Add the support for PHYTIUM topology detect, it's better use PPTT ACPI table to report the topology, but we can live with it at now. Signed-off-by: Hanjun Guo <guohanjun(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> Reviewed-by: Xie XiuQi <xiexiuqi(a)huawei.com> Signed-off-by: Zheng Zengkai <zhengzengkai(a)huawei.com> Conflicts: drivers/base/arch_topology.c Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- arch/arm64/include/asm/cputype.h | 1 + drivers/base/arch_topology.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h index 202588ad92e8..8629961ad39b 100644 --- a/arch/arm64/include/asm/cputype.h +++ b/arch/arm64/include/asm/cputype.h @@ -60,6 +60,7 @@ #define ARM_CPU_IMP_FUJITSU 0x46 #define ARM_CPU_IMP_HISI 0x48 #define ARM_CPU_IMP_APPLE 0x61 +#define ARM_CPU_IMP_PHYTIUM 0x70 #define ARM_CPU_IMP_AMPERE 0xC0 #define ARM_CPU_PART_AEM_V8 0xD0F diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c index b741b5ba82bd..0db635e94492 100644 --- a/drivers/base/arch_topology.c +++ b/drivers/base/arch_topology.c @@ -862,6 +862,14 @@ void store_cpu_topology(unsigned int cpuid) cpuid_topo->core_id = cpuid; cpuid_topo->package_id = cpu_to_node(cpuid); +#if defined(CONFIG_ARM64) + if (read_cpuid_implementor() == ARM_CPU_IMP_PHYTIUM) { + cpuid_topo->thread_id = 0; + cpuid_topo->core_id = cpuid; + cpuid_topo->package_id = 0; + } +#endif + pr_debug("CPU%u: package %d core %d thread %d\n", cpuid, cpuid_topo->package_id, cpuid_topo->core_id, cpuid_topo->thread_id); -- 2.25.1

2 1

[openeuler:OLK-6.6 691/2767] binfmt_elf32.c:undefined reference to `arch_elf_adjust_prot'
by kernel test robot 25 Jan '24

25 Jan '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 6188d51075eac8cf7cf6909fec1e73fbc51aa29b commit: 7de3ab4c3dd938fae3626a6344830b018eb7ba4f [691/2767] arm64: introduce binfmt_elf32.c config: arm64-randconfig-004-20240125 (https://download.01.org/0day-ci/archive/20240125/202401252015.eYqQYSXZ-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240125/202401252015.eYqQYSXZ-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401252015.eYqQYSXZ-lkp@intel.com/ All errors (new ones prefixed by >>): >> aarch64-linux-ld: Unexpected GOT/PLT entries detected! >> aarch64-linux-ld: Unexpected run-time procedure linkages detected! aarch64-linux-ld: arch/arm64/kernel/binfmt_elf32.o: in function `load_elf_interp': >> binfmt_elf32.c:(.text+0xa70): undefined reference to `arch_elf_adjust_prot' aarch64-linux-ld: arch/arm64/kernel/binfmt_elf32.o: in function `load_elf_binary': binfmt_elf32.c:(.text+0x1d88): undefined reference to `arch_elf_adjust_prot' -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 2629/2767] include/linux/resctrl.h:291: undefined reference to `lockdep_is_cpus_held'
by kernel test robot 25 Jan '24

25 Jan '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 6188d51075eac8cf7cf6909fec1e73fbc51aa29b commit: c054efea286659a6504fdeafc0a611c6a3b124cc [2629/2767] x86/resctrl: Claim get_domain_from_cpu() for resctrl config: x86_64-randconfig-012-20240125 (https://download.01.org/0day-ci/archive/20240125/202401252038.VOiTn1TA-lkp@…) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240125/202401252038.VOiTn1TA-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401252038.VOiTn1TA-lkp@intel.com/ All errors (new ones prefixed by >>): ld: vmlinux.o: in function `resctrl_get_domain_from_cpu': >> include/linux/resctrl.h:291: undefined reference to `lockdep_is_cpus_held' >> ld: include/linux/resctrl.h:291: undefined reference to `lockdep_is_cpus_held' >> ld: include/linux/resctrl.h:291: undefined reference to `lockdep_is_cpus_held' vim +291 include/linux/resctrl.h 274 275 /* 276 * Caller must be in a RCU read-side critical section, or hold the 277 * cpuhp read lock to prevent the struct rdt_domain being freed. 278 */ 279 static inline struct rdt_domain * 280 resctrl_get_domain_from_cpu(int cpu, struct rdt_resource *r) 281 { 282 struct rdt_domain *d; 283 284 /* 285 * Walking r->domains, ensure it can't race with cpuhp. 286 * Because this is called via IPI by rdt_ctrl_update(), assertions 287 * about locks this thread holds will lead to false positives. Check 288 * someone is holding the CPUs lock. 289 */ 290 if (IS_ENABLED(CONFIG_LOCKDEP)) > 291 lockdep_is_cpus_held(); 292 293 list_for_each_entry_rcu(d, &r->domains, list) { 294 /* Find the domain that contains this CPU */ 295 if (cpumask_test_cpu(cpu, &d->cpu_mask)) 296 return d; 297 } 298 299 return NULL; 300 } 301 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/1] arm64: Turn on CONFIG_IPI_AS_NMI in openeuler_defconfig
by Liao Chen 25 Jan '24

25 Jan '24

This patch turns on CONFIG_IPI_AS_NMI in openeuler_defconfig, which follows upstream commit 6188d51075ea (arm64: Add CONFIG_IPI_AS_NMI to IPI as NMI feature). CONFIG_IPI_AS_NMI=y Liao Chen (1): arm64: Turn on CONFIG_IPI_AS_NMI in openeuler_defconfig arch/arm64/configs/openeuler_defconfig | 1 + 1 file changed, 1 insertion(+) -- 2.34.1

1 0

[PATCH OLK-5.10] mm/dynamic_hugetlb: skip unexpected migration
by Liu Shixin 25 Jan '24

25 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8YUPE CVE: NA -------------------------------- With dynamic hugetlb feature, some memory is isolated in the dynamic pool. When try to compact memory, the kcompactd thread will scan all memory, althougt some memory is belonging to dynamic pool, kcompactd still try to migrate them. After migration, these memory will free to dynamic pool rather than buddy system, which results the free pages in buddy system decreased. Since it is unnecessary to compact the memory in the dynamic pool, skip migrate them to fix the problem. The same problem also existed in alloc_contig_range(), offline_pages() and numa balancing. Skip it again in these three scenarios. In addition to this, we have to consider the migration of hugepage, if a hugepage is from dynamic pool, we should not allow to migrate it. Signed-off-by: Liu Shixin <liushixin2(a)huawei.com> --- include/linux/dynamic_hugetlb.h | 4 ++-- mm/compaction.c | 4 ++++ mm/migrate.c | 7 +++++++ mm/page_isolation.c | 4 +++- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/include/linux/dynamic_hugetlb.h b/include/linux/dynamic_hugetlb.h index eff31669e210..06b20a24dfe6 100644 --- a/include/linux/dynamic_hugetlb.h +++ b/include/linux/dynamic_hugetlb.h @@ -184,12 +184,12 @@ static inline void free_huge_page_to_dhugetlb_pool(struct page *page, bool restore_reserve) { } +#endif + static inline bool page_belong_to_dynamic_hugetlb(struct page *page) { return false; } -#endif - #endif /* CONFIG_DYNAMIC_HUGETLB */ #endif /* __LINUX_DYNAMIC_HUGETLB_H */ diff --git a/mm/compaction.c b/mm/compaction.c index bdcde6ea7f97..754734a649d5 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -23,6 +23,7 @@ #include <linux/freezer.h> #include <linux/page_owner.h> #include <linux/psi.h> +#include <linux/dynamic_hugetlb.h> #include "internal.h" #ifdef CONFIG_COMPACTION @@ -1862,6 +1863,9 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc) if (!page) continue; + if (page_belong_to_dynamic_hugetlb(page)) + continue; + /* * If isolation recently failed, do not retry. Only check the * pageblock once. COMPACT_CLUSTER_MAX causes a pageblock diff --git a/mm/migrate.c b/mm/migrate.c index 9d40b1264a8b..c8491a744e8c 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -49,6 +49,7 @@ #include <linux/sched/mm.h> #include <linux/ptrace.h> #include <linux/oom.h> +#include <linux/dynamic_hugetlb.h> #include <asm/tlbflush.h> @@ -1611,6 +1612,9 @@ struct page *alloc_migration_target(struct page *page, unsigned long private) if (PageHuge(page)) { struct hstate *h = page_hstate(compound_head(page)); + if (page_belong_to_dynamic_hugetlb(page)) + return NULL; + gfp_mask = htlb_modify_alloc_mask(h, gfp_mask); return alloc_huge_page_nodemask(h, nid, mtc->nmask, gfp_mask); } @@ -2088,6 +2092,9 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) if (!migrate_balanced_pgdat(pgdat, compound_nr(page))) return 0; + if (page_belong_to_dynamic_hugetlb(page)) + return 0; + if (isolate_lru_page(page)) return 0; diff --git a/mm/page_isolation.c b/mm/page_isolation.c index bddf788f45bf..48a0ee9cef0a 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -10,6 +10,7 @@ #include <linux/hugetlb.h> #include <linux/page_owner.h> #include <linux/migrate.h> +#include <linux/dynamic_hugetlb.h> #include "internal.h" #define CREATE_TRACE_POINTS @@ -195,7 +196,8 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, pfn += pageblock_nr_pages) { page = __first_valid_page(pfn, pageblock_nr_pages); if (page) { - if (set_migratetype_isolate(page, migratetype, flags)) { + if (page_belong_to_dynamic_hugetlb(page) || + set_migratetype_isolate(page, migratetype, flags)) { undo_pfn = pfn; goto undo; } -- 2.25.1

2 1

[PATCH OLK-6.6 0/2] Expose swapcache stat for memcg v1
by Liu Shixin 25 Jan '24

25 Jan '24

The first patch expose swapcache stat for memcg v1, the second patch remote unused do_memsw_account() in memcg1_stat_format(). Liu Shixin (2): memcg: expose swapcache stat for memcg v1 memcg: remove unused do_memsw_account in memcg1_stat_format Documentation/admin-guide/cgroup-v1/memory.rst | 1 + mm/memcontrol.c | 15 ++++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) -- 2.25.1

1 2

[openeuler:openEuler-1.0-LTS 14777/21569] drivers/scsi/huawei/hifc/hifc_module.c:9:46: error: positional initialization of field in 'struct' declared with 'designated_init' attribute
by kernel test robot 25 Jan '24

25 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: c147f19e06e08b90efa3dda49bc4dcaf06424518 commit: 7fc993d55d1b54ae40e29dfac825a18d04d644c6 [14777/21569] scsi/hifc: add hifc driver FC service module config: x86_64-randconfig-015-20240125 (https://download.01.org/0day-ci/archive/20240125/202401251601.vlpK5QPa-lkp@…) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240125/202401251601.vlpK5QPa-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401251601.vlpK5QPa-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/scsi/huawei/hifc/hifc_module.c:9:46: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init] struct unf_cm_handle_op_s hifc_cm_handle = { 0 }; ^ drivers/scsi/huawei/hifc/hifc_module.c:9:46: note: (near initialization for 'hifc_cm_handle') >> drivers/scsi/huawei/hifc/hifc_module.c:9:46: error: invalid initializer drivers/scsi/huawei/hifc/hifc_module.c:9:46: note: (near initialization for 'hifc_cm_handle.<anonymous>') cc1: some warnings being treated as errors vim +9 drivers/scsi/huawei/hifc/hifc_module.c c27fa1ef544cd5 Chenguangli 2020-11-16 8 c27fa1ef544cd5 Chenguangli 2020-11-16 @9 struct unf_cm_handle_op_s hifc_cm_handle = { 0 }; c27fa1ef544cd5 Chenguangli 2020-11-16 10 unsigned int dif_sgl_mode; c27fa1ef544cd5 Chenguangli 2020-11-16 11 unsigned int max_speed = HIFC_SPEED_32G; c27fa1ef544cd5 Chenguangli 2020-11-16 12 unsigned int accum_db_num = 1; c27fa1ef544cd5 Chenguangli 2020-11-16 13 unsigned int dif_type = 0x1; c27fa1ef544cd5 Chenguangli 2020-11-16 14 unsigned int wqe_page_size = 4096; c27fa1ef544cd5 Chenguangli 2020-11-16 15 unsigned int wqe_pre_load = 6; c27fa1ef544cd5 Chenguangli 2020-11-16 16 unsigned int combo_length_kb = 8; c27fa1ef544cd5 Chenguangli 2020-11-16 17 unsigned int cos_bit_map = 0x1f; c27fa1ef544cd5 Chenguangli 2020-11-16 18 unsigned int hifc_dif_type; c27fa1ef544cd5 Chenguangli 2020-11-16 19 unsigned int hifc_dif_enable; c27fa1ef544cd5 Chenguangli 2020-11-16 20 unsigned char hifc_guard; c27fa1ef544cd5 Chenguangli 2020-11-16 21 :::::: The code at line 9 was first introduced by commit :::::: c27fa1ef544cd563228c1e13f1a09a565cafc9d5 scsi/hifc: add hifc driver scsi module :::::: TO: Chenguangli <chenguangli2(a)huawei.com> :::::: CC: Yang Yingliang <yangyingliang(a)huawei.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 13192/21567] drivers/crypto/hisilicon/qm.c:2916:39: error: 'struct device' has no member named 'numa_node'
by kernel test robot 25 Jan '24

25 Jan '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: c147f19e06e08b90efa3dda49bc4dcaf06424518 commit: 73d33f5c59dc3824444baca6a458427f4de3d8fa [13192/21567] qm: Move all the same logic functions of hisilicon crypto to qm config: arm64-randconfig-004-20240123 (https://download.01.org/0day-ci/archive/20240125/202401251651.XSRrMu3C-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240125/202401251651.XSRrMu3C-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401251651.XSRrMu3C-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/crypto/hisilicon/qm.c: In function 'hisi_qm_sort_devices': >> drivers/crypto/hisilicon/qm.c:2916:39: error: 'struct device' has no member named 'numa_node' 2916 | dev_node = dev->numa_node; | ^~ vim +2916 drivers/crypto/hisilicon/qm.c 2902 2903 static int hisi_qm_sort_devices(int node, struct list_head *head, 2904 struct hisi_qm_list *qm_list) 2905 { 2906 struct hisi_qm_resource *res, *tmp; 2907 struct hisi_qm *qm; 2908 struct list_head *n; 2909 struct device *dev; 2910 int dev_node = 0; 2911 2912 list_for_each_entry(qm, &qm_list->list, list) { 2913 dev = &qm->pdev->dev; 2914 2915 if (IS_ENABLED(CONFIG_NUMA)) { > 2916 dev_node = dev->numa_node; 2917 if (dev_node < 0) 2918 dev_node = 0; 2919 } 2920 2921 if (qm_list->check && !qm_list->check(qm)) 2922 continue; 2923 2924 res = kzalloc(sizeof(*res), GFP_KERNEL); 2925 if (!res) 2926 return -ENOMEM; 2927 2928 res->qm = qm; 2929 res->distance = node_distance(dev_node, node); 2930 n = head; 2931 list_for_each_entry(tmp, head, list) { 2932 if (res->distance < tmp->distance) { 2933 n = &tmp->list; 2934 break; 2935 } 2936 } 2937 list_add_tail(&res->list, n); 2938 } 2939 2940 return 0; 2941 } 2942 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6] tracing: Reserve kabi fields
by Zheng Yejian 25 Jan '24

25 Jan '24

hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I8YPFE CVE: NA -------------------------------- Reserve fields in tracing related structs for possible kabi compatibility processing. Signed-off-by: Zheng Yejian <zhengyejian1(a)huawei.com> --- include/linux/ftrace.h | 3 +++ include/linux/trace_events.h | 3 +++ include/linux/tracepoint-defs.h | 2 ++ kernel/trace/ring_buffer.c | 7 +++++++ kernel/trace/trace.h | 6 ++++++ 5 files changed, 21 insertions(+) diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h index e8921871ef9a..56892db7de5c 100644 --- a/include/linux/ftrace.h +++ b/include/linux/ftrace.h @@ -21,6 +21,7 @@ #include <linux/fs.h> #include <asm/ftrace.h> +#include <linux/kabi.h> /* * If the arch supports passing the variable contents of @@ -340,6 +341,8 @@ struct ftrace_ops { unsigned long direct_call; #endif #endif + KABI_RESERVE(1) + KABI_RESERVE(2) }; extern struct ftrace_ops __rcu *ftrace_ops_list; diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h index cf9f0c61796e..172cf91a45de 100644 --- a/include/linux/trace_events.h +++ b/include/linux/trace_events.h @@ -9,6 +9,7 @@ #include <linux/hardirq.h> #include <linux/perf_event.h> #include <linux/tracepoint.h> +#include <linux/kabi.h> struct trace_array; struct array_buffer; @@ -677,6 +678,8 @@ struct trace_event_file { atomic_t ref; /* ref count for opened files */ atomic_t sm_ref; /* soft-mode reference counter */ atomic_t tm_ref; /* trigger-mode reference counter */ + KABI_RESERVE(1) + KABI_RESERVE(2) }; #define __TRACE_EVENT_FLAGS(name, value) \ diff --git a/include/linux/tracepoint-defs.h b/include/linux/tracepoint-defs.h index 4dc4955f0fbf..b2b29dc8f259 100644 --- a/include/linux/tracepoint-defs.h +++ b/include/linux/tracepoint-defs.h @@ -10,6 +10,7 @@ #include <linux/atomic.h> #include <linux/static_key.h> +#include <linux/kabi.h> struct static_call_key; @@ -39,6 +40,7 @@ struct tracepoint { int (*regfunc)(void); void (*unregfunc)(void); struct tracepoint_func __rcu *funcs; + KABI_RESERVE(1) }; #ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index f1ef4329343b..e70aa61539dc 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -28,6 +28,7 @@ #include <linux/oom.h> #include <asm/local.h> +#include <linux/kabi.h> /* * The "absolute" timestamp in the buffer is only 59 bits. @@ -537,6 +538,9 @@ struct ring_buffer_per_cpu { struct completion update_done; struct rb_irq_work irq_work; + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) }; struct trace_buffer { @@ -571,6 +575,9 @@ struct ring_buffer_iter { u64 page_stamp; struct ring_buffer_event *event; int missed_events; + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) }; #ifdef RB_TIME_32 diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index 52123df262b2..8eebd99cbb89 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -21,6 +21,7 @@ #include <linux/workqueue.h> #include <linux/ctype.h> #include <linux/once_lite.h> +#include <linux/kabi.h> #include "pid_list.h" @@ -410,6 +411,9 @@ struct trace_array { struct cond_snapshot *cond_snapshot; #endif struct trace_func_repeats __percpu *last_func_repeats; + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) }; enum { @@ -1326,6 +1330,8 @@ struct ftrace_event_field { int size; int is_signed; int len; + KABI_RESERVE(1) + KABI_RESERVE(2) }; struct prog_entry; -- 2.25.1

1 0

[openeuler:OLK-6.6 1369/2731] mm/share_pool.c:3305:12: warning: 'proc_usage_show' defined but not used
by kernel test robot 25 Jan '24

25 Jan '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 901db4752b1cced0e23423a24a60e47b42e4b96b commit: df165ba49e6e4ce8b4f6076aded3b92e19918b03 [1369/2731] mm/sharepool: Add proc interfaces to show sp info config: arm64-randconfig-002-20240125 (https://download.01.org/0day-ci/archive/20240125/202401251418.DXCkpV5X-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240125/202401251418.DXCkpV5X-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401251418.DXCkpV5X-lkp@intel.com/ All warnings (new ones prefixed by >>): mm/share_pool.c: In function 'sp_hugetlb_entry': mm/share_pool.c:2584:21: error: implicit declaration of function 'huge_ptep_get' [-Werror=implicit-function-declaration] 2584 | pte_t pte = huge_ptep_get(ptep); | ^~~~~~~~~~~~~ mm/share_pool.c:2584:21: error: invalid initializer mm/share_pool.c: In function 'sp_unshare_kva': mm/share_pool.c:2796:14: warning: variable 'is_hugepage' set but not used [-Wunused-but-set-variable] 2796 | bool is_hugepage = true; | ^~~~~~~~~~~ mm/share_pool.c: At top level: >> mm/share_pool.c:3305:12: warning: 'proc_usage_show' defined but not used [-Wunused-function] 3305 | static int proc_usage_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~~ >> mm/share_pool.c:3285:12: warning: 'proc_group_usage_show' defined but not used [-Wunused-function] 3285 | static int proc_group_usage_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~~~~~~~~~ >> mm/share_pool.c:3234:12: warning: 'spa_stat_show' defined but not used [-Wunused-function] 3234 | static int spa_stat_show(struct seq_file *seq, void *offset) | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/proc_usage_show +3305 mm/share_pool.c 3233 > 3234 static int spa_stat_show(struct seq_file *seq, void *offset) 3235 { 3236 if (!should_show_statistics()) 3237 return -EPERM; 3238 3239 spg_overview_show(seq); 3240 spa_overview_show(seq); 3241 /* print the file header */ 3242 seq_printf(seq, "%-10s %-16s %-16s %-10s %-7s %-5s %-8s %-8s\n", 3243 "Group ID", "va_start", "va_end", "Size(KB)", "Type", "Huge", "PID", "Ref"); 3244 spa_ro_stat_show(seq); 3245 spa_normal_stat_show(seq); 3246 spa_dvpp_stat_show(seq); 3247 return 0; 3248 } 3249 3250 static int proc_usage_by_group(int id, void *p, void *data) 3251 { 3252 struct sp_group *spg = p; 3253 struct seq_file *seq = data; 3254 struct sp_group_node *spg_node; 3255 struct mm_struct *mm; 3256 struct sp_group_master *master; 3257 int tgid; 3258 unsigned long anon, file, shmem, total_rss; 3259 3260 down_read(&spg->rw_lock); 3261 list_for_each_entry(spg_node, &spg->proc_head, proc_node) { 3262 master = spg_node->master; 3263 mm = master->mm; 3264 tgid = master->tgid; 3265 3266 get_mm_rss_info(mm, &anon, &file, &shmem, &total_rss); 3267 3268 seq_printf(seq, "%-8d ", tgid); 3269 seq_printf(seq, "%-8d ", id); 3270 seq_printf(seq, "%-9ld %-9ld %-9ld %-8ld %-7ld %-7ld ", 3271 meminfo_alloc_sum_byKB(&spg_node->meminfo), 3272 meminfo_k2u_size(&spg_node->meminfo), 3273 meminfo_alloc_sum_byKB(&spg_node->spg->meminfo), 3274 page2kb(mm->total_vm), page2kb(total_rss), 3275 page2kb(shmem)); 3276 print_process_prot(seq, spg_node->prot); 3277 seq_putc(seq, '\n'); 3278 } 3279 up_read(&spg->rw_lock); 3280 cond_resched(); 3281 3282 return 0; 3283 } 3284 > 3285 static int proc_group_usage_show(struct seq_file *seq, void *offset) 3286 { 3287 if (!should_show_statistics()) 3288 return -EPERM; 3289 3290 spg_overview_show(seq); 3291 spa_overview_show(seq); 3292 3293 /* print the file header */ 3294 seq_printf(seq, "%-8s %-8s %-9s %-9s %-9s %-8s %-7s %-7s %-4s\n", 3295 "PID", "Group_ID", "SP_ALLOC", "SP_K2U", "SP_RES", 3296 "VIRT", "RES", "Shm", "PROT"); 3297 3298 down_read(&sp_global_sem); 3299 idr_for_each(&sp_group_idr, proc_usage_by_group, seq); 3300 up_read(&sp_global_sem); 3301 3302 return 0; 3303 } 3304 > 3305 static int proc_usage_show(struct seq_file *seq, void *offset) 3306 { 3307 struct sp_group_master *master = NULL; 3308 unsigned long anon, file, shmem, total_rss; 3309 long sp_res, sp_res_nsize, non_sp_res, non_sp_shm; 3310 struct sp_meminfo *meminfo; 3311 3312 if (!should_show_statistics()) 3313 return -EPERM; 3314 3315 seq_printf(seq, "%-8s %-16s %-9s %-9s %-9s %-10s %-10s %-8s\n", 3316 "PID", "COMM", "SP_ALLOC", "SP_K2U", "SP_RES", "Non-SP_RES", 3317 "Non-SP_Shm", "VIRT"); 3318 3319 down_read(&sp_global_sem); 3320 mutex_lock(&master_list_lock); 3321 list_for_each_entry(master, &master_list, list_node) { 3322 meminfo = &master->meminfo; 3323 get_mm_rss_info(master->mm, &anon, &file, &shmem, &total_rss); 3324 get_process_sp_res(master, &sp_res, &sp_res_nsize); 3325 get_process_non_sp_res(total_rss, shmem, sp_res_nsize, 3326 &non_sp_res, &non_sp_shm); 3327 seq_printf(seq, "%-8d %-16s %-9ld %-9ld %-9ld %-10ld %-10ld %-8ld\n", 3328 master->tgid, master->comm, 3329 meminfo_alloc_sum_byKB(meminfo), 3330 meminfo_k2u_size(meminfo), 3331 sp_res, non_sp_res, non_sp_shm, 3332 page2kb(master->mm->total_vm)); 3333 } 3334 mutex_unlock(&master_list_lock); 3335 up_read(&sp_global_sem); 3336 3337 return 0; 3338 } 3339 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS] BUILD REGRESSION 0ff07578f017c011d7806126c4aaafdbf39b32fa
by kernel test robot 25 Jan '24

25 Jan '24

tree/branch: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS branch HEAD: 0ff07578f017c011d7806126c4aaafdbf39b32fa !4137 sctp: fix potential deadlock on &net->sctp.addr_wq_lock Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202401250716.GKgR8ZVW-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) drivers/iio/adc/phytium-adc.c:651:12: warning: 'phytium_adc_suspend' defined but not used [-Wunused-function] drivers/iio/adc/phytium-adc.c:662:12: warning: 'phytium_adc_resume' defined but not used [-Wunused-function] Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- arm64-allmodconfig | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_getres | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_gettime | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_gettimeofday | |-- drivers-char-svm.c:warning:no-previous-prototype-for-svm_get_pasid | |-- drivers-gpio-gpio-dwapb.c:warning:enable_ascend_gpio_dwapb_setup-defined-but-not-used | |-- drivers-gpio-gpio-phytium-pci.c:warning:ordered-comparison-of-pointer-with-integer-zero | |-- drivers-gpu-drm-hisilicon-hibmc-hibmc_drm_drv.c:warning:array-subscript-is-outside-array-bounds-of-struct-aperture | |-- drivers-gpu-drm-phytium-e2000_dc.c:warning:no-previous-prototype-for-e2000_dc_hw_config_pix_clock | |-- drivers-gpu-drm-phytium-e2000_dc.c:warning:no-previous-prototype-for-e2000_dc_hw_fb_format_check | |-- drivers-gpu-drm-phytium-e2000_dc.c:warning:no-previous-prototype-for-e2000_dc_hw_plane_get_cursor_format | |-- drivers-gpu-drm-phytium-e2000_dc.c:warning:no-previous-prototype-for-e2000_dc_hw_plane_get_primary_format | |-- drivers-gpu-drm-phytium-e2000_dc.c:warning:no-previous-prototype-for-e2000_dc_hw_reset | |-- drivers-gpu-drm-phytium-e2000_dc.c:warning:no-previous-prototype-for-e2000_dc_hw_update_cursor_hi_addr | |-- drivers-gpu-drm-phytium-e2000_dc.c:warning:no-previous-prototype-for-e2000_dc_hw_update_primary_hi_addr | |-- drivers-gpu-drm-phytium-e2000_dc.c:warning:no-previous-prototype-for-e2000_dc_hw_vram_init | |-- drivers-gpu-drm-phytium-e2000_dp.c:warning:no-previous-prototype-for-e2000_dp_hw_get_source_lane_count | |-- drivers-gpu-drm-phytium-e2000_dp.c:warning:no-previous-prototype-for-e2000_dp_hw_reset | |-- drivers-gpu-drm-phytium-e2000_dp.c:warning:no-previous-prototype-for-e2000_dp_hw_spread_is_enable | |-- drivers-gpu-drm-phytium-phytium_crtc.c:warning:no-previous-prototype-for-phytium_crtc_atomic_destroy_state | |-- drivers-gpu-drm-phytium-phytium_crtc.c:warning:no-previous-prototype-for-phytium_crtc_atomic_duplicate_state | |-- drivers-gpu-drm-phytium-phytium_crtc.c:warning:variable-phytium_crtc_state-set-but-not-used | |-- drivers-gpu-drm-phytium-phytium_debugfs.c:warning:no-previous-prototype-for-phytium_debugfs_connector_add | |-- drivers-gpu-drm-phytium-phytium_debugfs.c:warning:no-previous-prototype-for-phytium_debugfs_display_register | |-- drivers-gpu-drm-phytium-phytium_display_drv.c:warning:variable-status-set-but-not-used | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_adjust_link_train_parameter | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_coding_8b10b_need_enable | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_dpcd_sink_dpms | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_fast_link_train | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_get_link_train_fallback_values | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hpd_poll_handler | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_config_video | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_disable_input_source | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_disable_output | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_disable_video | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_enable_audio | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_enable_input_source | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_enable_output | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_enable_video | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_hpd_irq_setup | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_init | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_output_is_enable | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_hw_video_is_enable | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_scrambled_need_enable | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_dp_start_link_train | |-- drivers-gpu-drm-phytium-phytium_dp.c:warning:no-previous-prototype-for-phytium_get_encoder_crtc_mask | |-- drivers-gpu-drm-phytium-phytium_fb.c:warning:variable-hsub-set-but-not-used | |-- drivers-gpu-drm-phytium-phytium_fbdev.c:warning:no-previous-prototype-for-phytium_drm_fbdev_fini | |-- drivers-gpu-drm-phytium-phytium_fbdev.c:warning:no-previous-prototype-for-phytium_drm_fbdev_init | |-- drivers-gpu-drm-phytium-phytium_gem.c:warning:no-previous-prototype-for-phytium_dma_transfer | |-- drivers-gpu-drm-phytium-phytium_gem.c:warning:no-previous-prototype-for-phytium_memory_pool_alloc | |-- drivers-gpu-drm-phytium-phytium_gem.c:warning:no-previous-prototype-for-phytium_memory_pool_free | |-- drivers-gpu-drm-phytium-phytium_panel.c:warning:no-previous-prototype-for-phytium_dp_panel_release_backlight_funcs | |-- drivers-gpu-drm-phytium-phytium_pci.c:warning:no-previous-prototype-for-phytium_pci_dma_fini | |-- drivers-gpu-drm-phytium-phytium_pci.c:warning:no-previous-prototype-for-phytium_pci_dma_init | |-- drivers-gpu-drm-phytium-phytium_pci.c:warning:no-previous-prototype-for-phytium_pci_vram_fini | |-- drivers-gpu-drm-phytium-phytium_pci.c:warning:no-previous-prototype-for-phytium_pci_vram_hw_init | |-- drivers-gpu-drm-phytium-phytium_pci.c:warning:no-previous-prototype-for-phytium_pci_vram_init | |-- drivers-gpu-drm-phytium-phytium_plane.c:warning:no-previous-prototype-for-phytium_plane_atomic_destroy_state | |-- drivers-gpu-drm-phytium-phytium_plane.c:warning:no-previous-prototype-for-phytium_plane_atomic_duplicate_state | |-- drivers-gpu-drm-phytium-phytium_plane.c:warning:no-previous-prototype-for-phytium_plane_atomic_set_property | |-- drivers-gpu-drm-phytium-phytium_plane.c:warning:no-previous-prototype-for-phytium_plane_destroy | |-- drivers-gpu-drm-phytium-phytium_plane.c:warning:variable-crtc_x-set-but-not-used | |-- drivers-gpu-drm-phytium-phytium_plane.c:warning:variable-crtc_y-set-but-not-used | |-- drivers-gpu-drm-phytium-phytium_platform.c:warning:no-previous-prototype-for-phytium_platform_carveout_mem_fini | |-- drivers-gpu-drm-phytium-phytium_platform.c:warning:no-previous-prototype-for-phytium_platform_carveout_mem_init | |-- drivers-gpu-drm-phytium-x100_dc.c:warning:no-previous-prototype-for-x100_dc_hw_clear_msi_irq | |-- drivers-gpu-drm-phytium-x100_dc.c:warning:no-previous-prototype-for-x100_dc_hw_config_pix_clock | |-- drivers-gpu-drm-phytium-x100_dc.c:warning:no-previous-prototype-for-x100_dc_hw_disable | |-- drivers-gpu-drm-phytium-x100_dc.c:warning:no-previous-prototype-for-x100_dc_hw_fb_format_check | |-- drivers-gpu-drm-phytium-x100_dc.c:warning:no-previous-prototype-for-x100_dc_hw_plane_get_cursor_format | |-- drivers-gpu-drm-phytium-x100_dc.c:warning:no-previous-prototype-for-x100_dc_hw_plane_get_primary_format | |-- drivers-gpu-drm-phytium-x100_dc.c:warning:no-previous-prototype-for-x100_dc_hw_update_dcreq | |-- drivers-gpu-drm-phytium-x100_dc.c:warning:no-previous-prototype-for-x100_dc_hw_update_primary_hi_addr | |-- drivers-gpu-drm-phytium-x100_dc.c:warning:no-previous-prototype-for-x100_dc_hw_vram_init | |-- drivers-gpu-drm-phytium-x100_dp.c:warning:no-previous-prototype-for-x100_dp_hw_get_source_lane_count | |-- drivers-gpu-drm-phytium-x100_dp.c:warning:no-previous-prototype-for-x100_dp_hw_reset | |-- drivers-gpu-drm-phytium-x100_dp.c:warning:no-previous-prototype-for-x100_dp_hw_spread_is_enable | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-clk_divisor_fast_plus_mode-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-clk_divisor_non_hs_mode-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-has_mst_fifo-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-has_multi_master_mode-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-has_slcg_override_reg-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-irq_disabled-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-is_multimaster_mode-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-rst-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-xfer_lock-not-described-in-tegra_i2c_dev | |-- drivers-iommu-arm-smmu-v3-context.c:warning:no-previous-prototype-for-arm_smmu_get_cd_mpam | |-- drivers-iommu-arm-smmu-v3-context.c:warning:no-previous-prototype-for-arm_smmu_set_cd_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-dev-not-described-in-arm_smmu_get_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-dev-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-dev-not-described-in-arm_smmu_set_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-partid-not-described-in-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-partid-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-pmg-not-described-in-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-pmg-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-s1mpam-not-described-in-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-s1mpam-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-ssid-not-described-in-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-ssid-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-user_mpam_en-not-described-in-arm_smmu_get_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-user_mpam_en-not-described-in-arm_smmu_set_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:no-previous-prototype-for-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:no-previous-prototype-for-arm_smmu_get_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:no-previous-prototype-for-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:no-previous-prototype-for-arm_smmu_set_dev_user_mpam_en | |-- drivers-md-bcache-acache.c:warning:array-subscript-unknown-is-outside-array-bounds-of-struct-acache_info | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-acache_open | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-acache_prefetch_init | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-acache_release | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-get_bio_by_item | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-get_cached_device_by_dev | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-init_acache_circ | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-read_circ_slice | |-- drivers-mmc-host-phytium-mci.c:warning:variable-read-set-but-not-used | |-- drivers-mmc-host-phytium-sdci.c:warning:variable-cmd-set-but-not-used | |-- drivers-mmc-host-phytium-sdci.c:warning:variable-read-set-but-not-used | |-- drivers-net-can-phytium-phytium_can.c:warning:Function-parameter-or-member-dev-not-described-in-phytium_can_start_xmit | |-- drivers-net-can-phytium-phytium_can.c:warning:Function-parameter-or-member-skb-not-described-in-phytium_can_start_xmit | |-- drivers-net-ethernet-hisilicon-hns3-hns3_enet.c:warning:unused-variable-handle | |-- drivers-net-ethernet-huawei-hinic-hinic_api_cmd.c:warning:Excess-function-parameter-chain-description-in-api_cmd_create_chain | |-- drivers-net-ethernet-huawei-hinic-hinic_api_cmd.c:warning:Function-parameter-or-member-cmd_chain-not-described-in-api_cmd_create_chain | |-- drivers-net-ethernet-huawei-hinic-hinic_cfg.c:warning:no-previous-prototype-for-cfg_get_func_sf_en | |-- drivers-net-ethernet-huawei-hinic-hinic_cfg.c:warning:no-previous-prototype-for-cfg_set_func_sf_en | |-- drivers-net-ethernet-huawei-hinic-hinic_cfg.c:warning:no-previous-prototype-for-hinic_vector_to_irq | |-- drivers-net-ethernet-huawei-hinic-hinic_cmdq.c:warning:no-previous-prototype-for-hinic_set_cmdq_ctxts | |-- drivers-net-ethernet-huawei-hinic-hinic_dbgtool_knl.c:warning:Function-parameter-or-member-arg-not-described-in-dbgtool_knl_unlocked_ioctl | |-- drivers-net-ethernet-huawei-hinic-hinic_dbgtool_knl.c:warning:Function-parameter-or-member-in_size-not-described-in-ffm_intr_msg_record | |-- drivers-net-ethernet-huawei-hinic-hinic_dbgtool_knl.c:warning:Function-parameter-or-member-out_size-not-described-in-ffm_intr_msg_record | |-- drivers-net-ethernet-huawei-hinic-hinic_dcb.c:warning:no-previous-prototype-for-__set_cos_up_map | |-- drivers-net-ethernet-huawei-hinic-hinic_dcb.c:warning:no-previous-prototype-for-hinic_dcb_config_init | |-- drivers-net-ethernet-huawei-hinic-hinic_dcb.c:warning:no-previous-prototype-for-hinic_dcbnl_set_all | |-- drivers-net-ethernet-huawei-hinic-hinic_dcb.c:warning:no-previous-prototype-for-hinic_init_ieee_settings | |-- drivers-net-ethernet-huawei-hinic-hinic_dcb.c:warning:no-previous-prototype-for-hinic_set_prio_tc_map | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Excess-function-parameter-hw_cb-description-in-hinic_aeq_register_hw_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Excess-function-parameter-sw_cb-description-in-hinic_aeq_register_swe_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Function-parameter-or-member-aeq_swe_cb-not-described-in-hinic_aeq_register_swe_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Function-parameter-or-member-hwe_cb-not-described-in-hinic_aeq_register_hw_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:implicit-conversion-from-enum-hinic_aeq_type-to-enum-hinic_ucode_event_type | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:variable-lev-set-but-not-used | |-- drivers-net-ethernet-huawei-hinic-hinic_ethtool.c:warning:no-previous-prototype-for-hinic_get_io_stats | |-- drivers-net-ethernet-huawei-hinic-hinic_ethtool.c:warning:no-previous-prototype-for-hinic_get_io_stats_size | |-- drivers-net-ethernet-huawei-hinic-hinic_ethtool.c:warning:no-previous-prototype-for-hinic_lp_test | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-_set_led_status | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-comm_pf_mbox_handler | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-hinic_get_phy_init_status | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-hinic_msg_to_mgmt_no_ack | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-hinic_ppf_ht_gpa_deinit | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-hinic_ppf_ht_gpa_init | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-mqm_eqm_alloc_page_mem | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-mqm_eqm_deinit | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-mqm_eqm_free_page_mem | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-mqm_eqm_init | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-mqm_eqm_set_cfg_2_hw | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-mqm_eqm_set_page_2_hw | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:no-previous-prototype-for-mqm_eqm_try_alloc_mem | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:snprintf-argument-overlaps-destination-object-tmp_str | |-- drivers-net-ethernet-huawei-hinic-hinic_hwdev.c:warning:the-comparison-will-always-evaluate-as-true-for-the-address-of-rt_cmd-will-never-be-NULL | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-db_base-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-db_base_phy-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-dwqe_mapping-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-intr_reg_base-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_lld.c:warning:no-previous-prototype-for-hinic_destroy_syncfw_timer | |-- drivers-net-ethernet-huawei-hinic-hinic_lld.c:warning:no-previous-prototype-for-hinic_event_process | |-- drivers-net-ethernet-huawei-hinic-hinic_lld.c:warning:no-previous-prototype-for-hinic_get_card_func_info_by_card_name | |-- drivers-net-ethernet-huawei-hinic-hinic_lld.c:warning:no-previous-prototype-for-hinic_get_ppf_hwdev_by_pdev | |-- drivers-net-ethernet-huawei-hinic-hinic_lld.c:warning:no-previous-prototype-for-hinic_init_syncfw_timer | |-- drivers-net-ethernet-huawei-hinic-hinic_lld.c:warning:no-previous-prototype-for-hinic_version_cmp | |-- drivers-net-ethernet-huawei-hinic-hinic_main.c:warning:no-previous-prototype-for-nic_event | |-- drivers-net-ethernet-huawei-hinic-hinic_mbox.c:warning:no-previous-prototype-for-check_vf_mbox_random_id | |-- drivers-net-ethernet-huawei-hinic-hinic_mbox.c:warning:no-previous-prototype-for-dump_mox_reg | |-- drivers-net-ethernet-huawei-hinic-hinic_mbox.c:warning:no-previous-prototype-for-set_vf_mbox_random_id | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-cmd-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-dest-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-hwdev-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-size-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-__mbox_to_host | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-__ppf_process_mbox_msg | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-comm_ppf_mbox_handler | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-comm_ppf_to_pf_handler | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-hilink_ppf_mbox_handler | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-hinic_nic_ppf_mbox_handler | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-hinic_nic_ppf_to_pf_handler | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-hinic_register_slave_ppf | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-set_slave_func_nic_state | |-- drivers-net-ethernet-huawei-hinic-hinic_multi_host_mgmt.c:warning:no-previous-prototype-for-sw_func_ppf_mbox_handler | |-- drivers-net-ethernet-huawei-hinic-hinic_nic_cfg.c:warning:no-previous-prototype-for-hinic_hiovs_del_cpath_vlan | |-- drivers-net-ethernet-huawei-hinic-hinic_nic_cfg.c:warning:no-previous-prototype-for-hinic_hiovs_set_cpath_vlan | |-- drivers-net-ethernet-huawei-hinic-hinic_nic_cfg.c:warning:no-previous-prototype-for-nic_pf_mbox_handler | |-- drivers-net-ethernet-huawei-hinic-hinic_nic_io.c:warning:no-previous-prototype-for-hinic_qp_prepare_cmdq_header | |-- drivers-net-ethernet-huawei-hinic-hinic_nic_io.c:warning:no-previous-prototype-for-hinic_rq_prepare_ctxt | |-- drivers-net-ethernet-huawei-hinic-hinic_nic_io.c:warning:no-previous-prototype-for-hinic_sq_prepare_ctxt | |-- drivers-net-ethernet-huawei-hinic-hinic_nictool.c:warning:no-previous-prototype-for-get_ets_info | |-- drivers-net-ethernet-huawei-hinic-hinic_nictool.c:warning:no-previous-prototype-for-get_pfc_info | |-- drivers-net-ethernet-huawei-hinic-hinic_nictool.c:warning:no-previous-prototype-for-get_support_tc | |-- drivers-net-ethernet-huawei-hinic-hinic_nictool.c:warning:no-previous-prototype-for-get_support_up | |-- drivers-net-ethernet-huawei-hinic-hinic_nictool.c:warning:no-previous-prototype-for-set_ets | |-- drivers-net-ethernet-huawei-hinic-hinic_nictool.c:warning:no-previous-prototype-for-set_pfc_control | |-- drivers-net-ethernet-huawei-hinic-hinic_nictool.c:warning:no-previous-prototype-for-set_pfc_priority | |-- drivers-net-ethernet-huawei-hinic-hinic_rx.c:warning:no-previous-prototype-for-hinic_rx_free_buffers | |-- drivers-net-ethernet-huawei-hinic-hinic_rx.c:warning:no-previous-prototype-for-recv_one_pkt | |-- drivers-net-ethernet-huawei-hinic-hinic_rx.c:warning:no-previous-prototype-for-rx_pass_super_cqe | |-- drivers-net-ethernet-huawei-hinic-hinic_sml_counter.c:warning:no-previous-prototype-for-hinic_sm_ctr_rd32 | |-- drivers-net-ethernet-huawei-hinic-hinic_sml_counter.c:warning:no-previous-prototype-for-hinic_sm_ctr_rd32_clear | |-- drivers-net-ethernet-huawei-hinic-hinic_sml_counter.c:warning:no-previous-prototype-for-hinic_sm_ctr_rd64 | |-- drivers-net-ethernet-huawei-hinic-hinic_sml_counter.c:warning:no-previous-prototype-for-hinic_sm_ctr_rd64_pair | |-- drivers-net-ethernet-huawei-hinic-hinic_sml_counter.c:warning:no-previous-prototype-for-hinic_sm_ctr_wr32 | |-- drivers-net-ethernet-huawei-hinic-hinic_sml_counter.c:warning:no-previous-prototype-for-hinic_sm_ctr_wr64 | |-- drivers-net-ethernet-huawei-hinic-hinic_sml_counter.c:warning:no-previous-prototype-for-hinic_sm_ctr_wr64_pair | |-- drivers-net-ethernet-huawei-hinic-hinic_tx.c:warning:no-previous-prototype-for-hinic_setup_tx_wqe | |-- drivers-net-ethernet-huawei-hinic-hinic_tx.c:warning:no-previous-prototype-for-hinic_stop_sq | |-- drivers-net-ethernet-mellanox-mlx5-core-en_tc.c:warning:unused-variable-ret | |-- drivers-net-ethernet-mellanox-mlx5-core-ipoib-ipoib.c:warning:no-previous-prototype-for-mlx5i_grp_sw_update_stats | |-- drivers-net-ethernet-stmicro-stmmac-dwmac-phytium.c:warning:no-previous-prototype-for-phytium_dwmac_remove | |-- drivers-net-ethernet-stmicro-stmmac-dwmac-phytium.c:warning:ordered-comparison-of-pointer-with-integer-zero | |-- drivers-net-ethernet-stmicro-stmmac-dwmac-phytium.c:warning:returning-void-from-a-function-with-return-type-int-makes-integer-from-pointer-without-a-cast | |-- drivers-pci-controller-pcie-altera.c:warning:data-may-be-used-uninitialized | |-- drivers-pci-pcie-aer.c:warning:array-subscript-is-outside-array-bounds-of-u32-aka-unsigned-int | |-- drivers-rtc-rtc-phytium.c:warning:variable-counter-set-but-not-used | |-- drivers-rtc-rtc-phytium.c:warning:variable-rtc_time-set-but-not-used | |-- drivers-rtc-rtc-phytium.c:warning:variable-tmp-set-but-not-used | |-- drivers-scsi-hisi_raid-hiraid_main.c:warning:d-directive-writing-between-and-bytes-into-a-region-of-size | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_code_mode_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_enable_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_linkrate_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_mode_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_phy_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_to_reg_name | |-- drivers-scsi-hisi_sas-hisi_sas_v3_hw.c:warning:no-previous-prototype-for-get_managed_irq_aff_v3_hw | |-- drivers-scsi-sssraid-sssraid_fw.c:warning:d-directive-writing-between-and-bytes-into-a-region-of-size | |-- drivers-spi-spi-phytium.c:warning:snprintf-output-may-be-truncated-before-the-last-format-character | |-- drivers-tee-optee-core.c:warning:returning-void-from-a-function-with-return-type-int-makes-integer-from-pointer-without-a-cast | |-- include-asm-generic-bitops-non-atomic.h:warning:array-subscript-long-unsigned-int-is-partly-outside-array-bounds-of-u32-aka-unsigned-int | |-- include-scsi-scsi_cmnd.h:warning:scsi_cmnd-may-be-used-uninitialized | |-- net-qrtr-qrtr.c:warning:ignoring-return-value-of-skb_put_padto-declared-with-attribute-warn_unused_result | |-- sound-pci-hda-hda_phytium.c:warning:variable-azx_dev-set-but-not-used | |-- sound-pci-hda-hda_phytium.c:warning:variable-hda-set-but-not-used | `-- sound-pci-hda-hda_phytium.c:warning:variable-index-set-but-not-used |-- arm64-allnoconfig | |-- arch-arm64-include-asm-atomic_ll_sc.h:warning:array-subscript-long-unsigned-int-is-partly-outside-array-bounds-of-enum-mitigation_state | |-- arch-arm64-include-asm-syscall.h:warning:memset-offset-is-out-of-the-bounds | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_getres | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_gettime | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_gettimeofday | |-- kernel-sched-core.c:error:implicit-declaration-of-function-init_auto_affinity | |-- kernel-sched-core.c:error:implicit-declaration-of-function-tg_update_affinity_domains | |-- kernel-sched-core.c:error:root_task_group-undeclared-(first-use-in-this-function) | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- arm64-defconfig | |-- arch-arm64-include-asm-syscall.h:warning:memset-offset-is-out-of-the-bounds | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_getres | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_gettime | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_gettimeofday | |-- drivers-char-svm.c:warning:no-previous-prototype-for-svm_get_pasid | |-- drivers-gpu-drm-hisilicon-hibmc-hibmc_drm_drv.c:warning:array-subscript-is-outside-array-bounds-of-struct-aperture | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-clk_divisor_fast_plus_mode-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-clk_divisor_non_hs_mode-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-has_mst_fifo-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-has_multi_master_mode-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-has_slcg_override_reg-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-irq_disabled-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-is_multimaster_mode-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-rst-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-xfer_lock-not-described-in-tegra_i2c_dev | |-- drivers-iommu-arm-smmu-v3-context.c:warning:no-previous-prototype-for-arm_smmu_get_cd_mpam | |-- drivers-iommu-arm-smmu-v3-context.c:warning:no-previous-prototype-for-arm_smmu_set_cd_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-dev-not-described-in-arm_smmu_get_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-dev-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-dev-not-described-in-arm_smmu_set_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-partid-not-described-in-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-partid-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-pmg-not-described-in-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-pmg-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-s1mpam-not-described-in-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-s1mpam-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-ssid-not-described-in-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-ssid-not-described-in-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-user_mpam_en-not-described-in-arm_smmu_get_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:Function-parameter-or-member-user_mpam_en-not-described-in-arm_smmu_set_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:no-previous-prototype-for-arm_smmu_get_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:no-previous-prototype-for-arm_smmu_get_dev_user_mpam_en | |-- drivers-iommu-arm-smmu-v3.c:warning:no-previous-prototype-for-arm_smmu_set_dev_mpam | |-- drivers-iommu-arm-smmu-v3.c:warning:no-previous-prototype-for-arm_smmu_set_dev_user_mpam_en | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_code_mode_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_enable_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_linkrate_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_mode_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_bist_phy_write | |-- drivers-scsi-hisi_sas-hisi_sas_main.c:warning:no-previous-prototype-for-hisi_sas_debugfs_to_reg_name | |-- drivers-scsi-hisi_sas-hisi_sas_v3_hw.c:warning:no-previous-prototype-for-get_managed_irq_aff_v3_hw | |-- drivers-tee-optee-core.c:warning:returning-void-from-a-function-with-return-type-int-makes-integer-from-pointer-without-a-cast | `-- include-scsi-scsi_cmnd.h:warning:scsi_cmnd-may-be-used-uninitialized |-- arm64-randconfig-001-20240125 | |-- arch-arm64-include-asm-syscall.h:warning:memset-offset-is-out-of-the-bounds | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_getres | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_gettime | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_gettimeofday | |-- drivers-clocksource-arm_arch_timer.c:error:hisi_161010101_read_cntvct_el0-undeclared-(first-use-in-this-function) | |-- drivers-gpu-drm-hisilicon-hibmc-hibmc_drm_drv.c:warning:array-subscript-is-outside-array-bounds-of-struct-aperture | |-- drivers-mmc-host-phytium-sdci.c:warning:variable-cmd-set-but-not-used | |-- drivers-mmc-host-phytium-sdci.c:warning:variable-read-set-but-not-used | |-- drivers-tee-optee-core.c:warning:returning-void-from-a-function-with-return-type-int-makes-integer-from-pointer-without-a-cast | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- arm64-randconfig-002-20240125 | |-- arch-arm64-include-asm-atomic_ll_sc.h:warning:array-subscript-long-unsigned-int-is-partly-outside-array-bounds-of-enum-mitigation_state | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_getres | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_gettime | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_gettimeofday | |-- drivers-spi-spi-phytium.c:warning:snprintf-output-may-be-truncated-before-the-last-format-character | |-- drivers-staging-gmjstcm-tcm_tis_spi.c:warning:inten-may-be-used-uninitialized | |-- drivers-staging-gmjstcm-tcm_tis_spi.c:warning:tcm_tis_spi_acpi_match-defined-but-not-used | |-- drivers-staging-gmjstcm-tcm_tis_spi.c:warning:vendor-may-be-used-uninitialized | |-- drivers-tee-optee-core.c:warning:returning-void-from-a-function-with-return-type-int-makes-integer-from-pointer-without-a-cast | |-- kernel-sched-core.c:error:implicit-declaration-of-function-init_auto_affinity | |-- kernel-sched-core.c:error:implicit-declaration-of-function-tg_update_affinity_domains | |-- kernel-sched-core.c:error:root_task_group-undeclared-(first-use-in-this-function) | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- arm64-randconfig-003-20240125 | |-- arch-arm64-include-asm-atomic_ll_sc.h:warning:array-subscript-long-unsigned-int-is-partly-outside-array-bounds-of-enum-mitigation_state | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_getres | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_gettime | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_gettimeofday | |-- drivers-gpio-gpio-phytium-pci.c:warning:ordered-comparison-of-pointer-with-integer-zero | |-- drivers-iommu-arm-smmu-v3-context.c:warning:no-previous-prototype-for-arm_smmu_get_cd_mpam | |-- drivers-iommu-arm-smmu-v3-context.c:warning:no-previous-prototype-for-arm_smmu_set_cd_mpam | |-- drivers-mmc-host-phytium-sdci.c:warning:variable-cmd-set-but-not-used | |-- drivers-mmc-host-phytium-sdci.c:warning:variable-read-set-but-not-used | |-- drivers-pci-pcie-aer.c:warning:array-subscript-is-outside-array-bounds-of-u32-aka-unsigned-int | |-- kernel-sched-core.c:error:implicit-declaration-of-function-init_auto_affinity | |-- kernel-sched-core.c:error:implicit-declaration-of-function-tg_update_affinity_domains | |-- kernel-sched-core.c:error:root_task_group-undeclared-(first-use-in-this-function) | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- arm64-randconfig-004-20240125 | |-- arch-arm64-include-asm-atomic_ll_sc.h:warning:array-subscript-long-unsigned-int-is-partly-outside-array-bounds-of-enum-mitigation_state | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_getres | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_gettime | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_gettimeofday | |-- drivers-clocksource-arm_arch_timer.c:error:hisi_161010101_read_cntvct_el0-undeclared-(first-use-in-this-function) | |-- drivers-gpio-gpio-dwapb.c:warning:enable_ascend_gpio_dwapb_setup-defined-but-not-used | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-clk_divisor_fast_plus_mode-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-clk_divisor_non_hs_mode-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-has_mst_fifo-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-has_multi_master_mode-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-has_slcg_override_reg-not-described-in-tegra_i2c_hw_feature | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-irq_disabled-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-is_multimaster_mode-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-rst-not-described-in-tegra_i2c_dev | |-- drivers-i2c-busses-i2c-tegra.c:warning:Function-parameter-or-member-xfer_lock-not-described-in-tegra_i2c_dev | |-- drivers-iio-adc-phytium-adc.c:warning:phytium_adc_resume-defined-but-not-used | |-- drivers-iio-adc-phytium-adc.c:warning:phytium_adc_suspend-defined-but-not-used | |-- drivers-mmc-host-phytium-sdci.c:warning:variable-cmd-set-but-not-used | |-- drivers-mmc-host-phytium-sdci.c:warning:variable-read-set-but-not-used | |-- drivers-spi-spi-phytium.c:warning:snprintf-output-may-be-truncated-before-the-last-format-character | |-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa | |-- sound-pci-hda-hda_phytium.c:warning:variable-hda-set-but-not-used | `-- sound-pci-hda-hda_phytium.c:warning:variable-index-set-but-not-used |-- arm64-randconfig-r123-20240125 | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_getres | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_clock_gettime | |-- arch-arm64-kernel-vdso-gettimeofday.c:warning:no-previous-prototype-for-__kernel_gettimeofday | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- x86_64-allnoconfig | |-- arch-arm64-kernel-sys_ilp32.c:asm-unistd.h-is-included-more-than-once. | |-- arch-x86-include-asm-msr.h:warning:mcu_ctrl-may-be-used-uninitialized | |-- arch-x86-kernel-cpu-tsx.o:warning:objtool:missing-symbol-for-section-.init.text | |-- arch-x86-kernel-unwind_orc.c:warning:orc_sort_cmp-defined-but-not-used | |-- arch-x86-kernel-unwind_orc.c:warning:orc_sort_swap-defined-but-not-used | |-- arch-x86-mm-maccess.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-i2c-busses-i2c-zhaoxin.c:linux-version.h-not-needed. | |-- drivers-infiniband-hw-hns-hns_roce_main.c:linux-sched.h-is-included-more-than-once. | |-- drivers-net-ethernet-hisilicon-hns3-hns3_cae-hns3_cae_init.c::need-linux-version.h | |-- drivers-net-ethernet-hisilicon-hns3-hns3_extension-hns3_enet_it.c::need-linux-version.h | |-- drivers-net-ethernet-hisilicon-hns3-kcompat.c::need-linux-version.h | |-- drivers-net-ethernet-huawei-bma-edma_drv-bma_include.h:linux-version.h-is-included-more-than-once. | |-- drivers-net-ethernet-huawei-hinic-ossl_knl_linux.h:linux-version.h-not-needed. | |-- drivers-scsi-huawei-hifc-hifc_cfg.c:hifc_hw.h-is-included-more-than-once. | |-- drivers-scsi-huawei-hifc-hifc_dbgtool_knl.c:linux-fs.h-is-included-more-than-once. | |-- drivers-scsi-huawei-hifc-hifc_hwdev.c:hifc_hwif.h-is-included-more-than-once. | |-- drivers-scsi-huawei-hifc-unf_npiv.c:unf_rport.h-is-included-more-than-once. | |-- drivers-scsi-huawei-hifc-unf_portman.c:unf_rport.h-is-included-more-than-once. | |-- drivers-scsi-huawei-hifc-unf_service.c:unf_exchg.h-is-included-more-than-once. | |-- drivers-scsi-spraid-spraid_main.c:linux-version.h-not-needed. | |-- fs-proc-etmem_scan.c:linux-uaccess.h-is-included-more-than-once. | |-- kernel-ktask.o:warning:objtool:missing-symbol-for-section-.text | |-- kernel-sysctl.c:..-lib-kstrtox.h-is-included-more-than-once. | |-- mm-ioremap.o:warning:objtool:missing-symbol-for-section-.text | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- x86_64-buildonly-randconfig-001-20240125 | |-- arch-x86-include-asm-msr.h:warning:mcu_ctrl-may-be-used-uninitialized-in-this-function | |-- arch-x86-kernel-cpu-tsx.o:warning:objtool:missing-symbol-for-section-.init.text | |-- arch-x86-kernel-unwind_orc.c:warning:orc_sort_cmp-defined-but-not-used | |-- arch-x86-kernel-unwind_orc.c:warning:orc_sort_swap-defined-but-not-used | |-- drivers-input-mouse-focaltech.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-pps-kc.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-spi-spi-fsl-lib.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-ubifs-budget.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-ubifs-compress.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-ubifs-ioctl.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-ubifs-log.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-ubifs-lpt.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-ubifs-misc.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-ubifs-recovery.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-ubifs-shrinker.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-ubifs-tnc_commit.o:warning:objtool:missing-symbol-for-section-.text | |-- kernel-ktask.o:warning:objtool:missing-symbol-for-section-.text | |-- mm-ioremap.o:warning:objtool:missing-symbol-for-section-.text | |-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa | |-- net-can-j1939-address-claim.o:warning:objtool:missing-symbol-for-section-.text | |-- net-netfilter-nf_nat_proto.o:warning:objtool:missing-symbol-for-section-.text | |-- net-qrtr-qrtr.c:warning:ignoring-return-value-of-skb_put_padto-declared-with-attribute-warn_unused_result | `-- sound-core-sound_oss.o:warning:objtool:missing-symbol-for-section-.text |-- x86_64-buildonly-randconfig-002-20240125 | |-- arch-x86-include-asm-msr.h:warning:mcu_ctrl-may-be-used-uninitialized-in-this-function | |-- drivers-gpu-drm-hisilicon-hibmc-hibmc_drm_drv.c:warning:hibmc_pm_resume-defined-but-not-used | |-- drivers-gpu-drm-hisilicon-hibmc-hibmc_drm_drv.c:warning:hibmc_pm_suspend-defined-but-not-used | |-- kernel-hung_task.c:error:sysctl_hung_task_all_cpu_backtrace-undeclared-(first-use-in-this-function) | `-- kernel-time-tick-broadcast.c:warning:tick_broadcast_oneshot_offline-declared-static-but-never-defined |-- x86_64-buildonly-randconfig-003-20240125 | |-- arch-x86-kernel-cpu-bugs.c:warning:mcu_ctrl-may-be-used-uninitialized | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-acache_open | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-acache_prefetch_init | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-acache_release | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-get_bio_by_item | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-get_cached_device_by_dev | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-init_acache_circ | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-read_circ_slice | |-- drivers-misc-uacce-uacce.c:error:implicit-declaration-of-function-module_refcount | `-- kernel-time-tick-broadcast.c:warning:tick_broadcast_oneshot_offline-declared-static-but-never-defined |-- x86_64-buildonly-randconfig-004-20240125 | |-- arch-x86-events-zhaoxin-core.c:error:redefinition-of-zhaoxin_pmu_init | |-- arch-x86-kernel-cpu-bugs.c:warning:mcu_ctrl-may-be-used-uninitialized-in-this-function | |-- arch-x86-kernel-cpu-hypervisor.o:warning:objtool:missing-symbol-for-section-.init.text | |-- arch-x86-kernel-unwind_orc.c:warning:orc_sort_cmp-defined-but-not-used | |-- arch-x86-kernel-unwind_orc.c:warning:orc_sort_swap-defined-but-not-used | |-- arch-x86-mm-maccess.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-pps-kc.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-ssb-scan.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-usb-storage-debug.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-xfs-scrub-inode.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-xfs-scrub-symlink.o:warning:objtool:missing-symbol-for-section-.text | |-- fs-xfs-xfs_stats.o:warning:objtool:missing-symbol-for-section-.text | |-- kernel-ktask.o:warning:objtool:missing-symbol-for-section-.text | |-- kernel-time-tick-broadcast.c:warning:tick_broadcast_oneshot_offline-declared-static-but-never-defined | |-- mm-ioremap.o:warning:objtool:missing-symbol-for-section-.text | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- x86_64-buildonly-randconfig-006-20240125 | |-- arch-x86-include-asm-msr.h:warning:mcu_ctrl-may-be-used-uninitialized | |-- drivers-gpio-gpio-dwapb.c:warning:enable_ascend_gpio_dwapb_setup-defined-but-not-used | |-- drivers-gpu-drm-hisilicon-hibmc-hibmc_drm_drv.c:warning:hibmc_pm_resume-defined-but-not-used | |-- drivers-gpu-drm-hisilicon-hibmc-hibmc_drm_drv.c:warning:hibmc_pm_suspend-defined-but-not-used | |-- drivers-i2c-busses-i2c-zhaoxin.c:warning:zxi2c_resume-defined-but-not-used | |-- drivers-i2c-busses-i2c-zhaoxin.c:warning:zxi2c_suspend-defined-but-not-used | |-- kernel-hung_task.c:error:sysctl_hung_task_all_cpu_backtrace-undeclared-(first-use-in-this-function) | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- x86_64-defconfig | |-- arch-x86-mm-maccess.o:warning:objtool:missing-symbol-for-section-.text | |-- include-asm-generic-bug.h:warning:mcu_ctrl-may-be-used-uninitialized-in-this-function | |-- kernel-ktask.o:warning:objtool:missing-symbol-for-section-.text | `-- mm-ioremap.o:warning:objtool:missing-symbol-for-section-.text |-- x86_64-randconfig-101-20240125 | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-acache_open | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-acache_prefetch_init | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-acache_release | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-get_bio_by_item | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-get_cached_device_by_dev | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-init_acache_circ | |-- drivers-md-bcache-acache.c:warning:no-previous-prototype-for-read_circ_slice | |-- kernel-hung_task.c:error:sysctl_hung_task_all_cpu_backtrace-undeclared-(first-use-in-this-function) | |-- kernel-time-tick-broadcast.c:warning:tick_broadcast_oneshot_offline-declared-static-but-never-defined | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- x86_64-randconfig-102-20240125 | |-- drivers-gpio-gpio-dwapb.c:warning:enable_ascend_gpio_dwapb_setup-defined-but-not-used | |-- kernel-hung_task.c:error:sysctl_hung_task_all_cpu_backtrace-undeclared-(first-use-in-this-function) | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- x86_64-randconfig-103-20240125 | `-- mm-memory.c:error:implicit-declaration-of-function-hugetlb_insert_hugepage_pte_by_pa |-- x86_64-randconfig-104-20240125 | |-- drivers-i2c-busses-i2c-zhaoxin.c:warning:zxi2c_resume-defined-but-not-used | |-- drivers-i2c-busses-i2c-zhaoxin.c:warning:zxi2c_suspend-defined-but-not-used | |-- kernel-sched-core.c:error:implicit-declaration-of-function-init_auto_affinity | |-- kernel-sched-core.c:error:implicit-declaration-of-function-tg_update_affinity_domains | `-- kernel-sched-core.c:error:root_task_group-undeclared-(first-use-in-this-function) |-- x86_64-randconfig-161-20240125 | `-- arch-x86-kernel-cpu-bugs.c:warning:mcu_ctrl-may-be-used-uninitialized-in-this-function `-- x86_64-randconfig-r113-20240125 |-- drivers-gpio-gpio-dwapb.c:warning:enable_ascend_gpio_dwapb_setup-defined-but-not-used |-- drivers-i2c-busses-i2c-zhaoxin.c:warning:zxi2c_resume-defined-but-not-used `-- drivers-i2c-busses-i2c-zhaoxin.c:warning:zxi2c_suspend-defined-but-not-used clang_recent_errors |-- x86_64-allmodconfig | |-- drivers-net-can-phytium-phytium_can.c:warning:Function-parameter-or-member-dev-not-described-in-phytium_can_start_xmit | |-- drivers-net-can-phytium-phytium_can.c:warning:Function-parameter-or-member-skb-not-described-in-phytium_can_start_xmit | |-- drivers-net-ethernet-3snic-sssnic-hw-.tmp_sss_hwdev_link.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-net-ethernet-3snic-sssnic-hw-.tmp_sss_hwif_export.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-net-ethernet-3snic-sssnic-nic-.tmp_sss_nic_ethtool_stats.o:warning:objtool:sss_nic_get_sset_count:can-t-find-switch-jump-table | |-- drivers-net-ethernet-3snic-sssnic-nic-.tmp_sss_nic_main.o:warning:objtool:sss_nic_event:can-t-find-switch-jump-table | |-- drivers-net-ethernet-hisilicon-hns3-hns3_enet.c:warning:unused-variable-handle | |-- drivers-net-ethernet-huawei-hinic-hinic_api_cmd.c:warning:Excess-function-parameter-chain-description-in-api_cmd_create_chain | |-- drivers-net-ethernet-huawei-hinic-hinic_api_cmd.c:warning:Function-parameter-or-member-cmd_chain-not-described-in-api_cmd_create_chain | |-- drivers-net-ethernet-huawei-hinic-hinic_dbgtool_knl.c:warning:Function-parameter-or-member-arg-not-described-in-dbgtool_knl_unlocked_ioctl | |-- drivers-net-ethernet-huawei-hinic-hinic_dbgtool_knl.c:warning:Function-parameter-or-member-in_size-not-described-in-ffm_intr_msg_record | |-- drivers-net-ethernet-huawei-hinic-hinic_dbgtool_knl.c:warning:Function-parameter-or-member-out_size-not-described-in-ffm_intr_msg_record | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Excess-function-parameter-hw_cb-description-in-hinic_aeq_register_hw_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Excess-function-parameter-sw_cb-description-in-hinic_aeq_register_swe_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Function-parameter-or-member-aeq_swe_cb-not-described-in-hinic_aeq_register_swe_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Function-parameter-or-member-hwe_cb-not-described-in-hinic_aeq_register_hw_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:variable-lev-set-but-not-used | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-db_base-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-db_base_phy-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-dwqe_mapping-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-intr_reg_base-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-cmd-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-dest-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-hwdev-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-size-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-mellanox-mlx5-core-en_tc.c:warning:unused-variable-ret | |-- drivers-net-ethernet-stmicro-stmmac-dwmac-phytium.c:error:incompatible-pointer-to-integer-conversion-returning-void-from-a-function-with-result-type-int | |-- drivers-net-ethernet-stmicro-stmmac-dwmac-phytium.c:warning:no-previous-prototype-for-function-phytium_dwmac_remove | |-- net-netfilter-nf_nat_proto.c:warning:no-previous-prototype-for-function-nf_nat_csum_recalc | |-- sound-pci-hda-hda_phytium.c:warning:variable-azx_dev-set-but-not-used | |-- sound-pci-hda-hda_phytium.c:warning:variable-hda-set-but-not-used | `-- sound-pci-hda-hda_phytium.c:warning:variable-index-set-but-not-used |-- x86_64-allyesconfig | |-- drivers-net-can-phytium-phytium_can.c:warning:Function-parameter-or-member-dev-not-described-in-phytium_can_start_xmit | |-- drivers-net-can-phytium-phytium_can.c:warning:Function-parameter-or-member-skb-not-described-in-phytium_can_start_xmit | |-- drivers-net-ethernet-3snic-sssnic-hw-.tmp_sss_hwdev_link.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-net-ethernet-3snic-sssnic-hw-.tmp_sss_hwif_export.o:warning:objtool:missing-symbol-for-section-.text | |-- drivers-net-ethernet-3snic-sssnic-nic-.tmp_sss_nic_ethtool_stats.o:warning:objtool:sss_nic_get_sset_count:can-t-find-switch-jump-table | |-- drivers-net-ethernet-3snic-sssnic-nic-.tmp_sss_nic_main.o:warning:objtool:sss_nic_event:can-t-find-switch-jump-table | |-- drivers-net-ethernet-hisilicon-hns3-hns3_enet.c:warning:unused-variable-handle | |-- drivers-net-ethernet-huawei-hinic-hinic_api_cmd.c:warning:Excess-function-parameter-chain-description-in-api_cmd_create_chain | |-- drivers-net-ethernet-huawei-hinic-hinic_api_cmd.c:warning:Function-parameter-or-member-cmd_chain-not-described-in-api_cmd_create_chain | |-- drivers-net-ethernet-huawei-hinic-hinic_dbgtool_knl.c:warning:Function-parameter-or-member-arg-not-described-in-dbgtool_knl_unlocked_ioctl | |-- drivers-net-ethernet-huawei-hinic-hinic_dbgtool_knl.c:warning:Function-parameter-or-member-in_size-not-described-in-ffm_intr_msg_record | |-- drivers-net-ethernet-huawei-hinic-hinic_dbgtool_knl.c:warning:Function-parameter-or-member-out_size-not-described-in-ffm_intr_msg_record | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Excess-function-parameter-hw_cb-description-in-hinic_aeq_register_hw_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Excess-function-parameter-sw_cb-description-in-hinic_aeq_register_swe_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Function-parameter-or-member-aeq_swe_cb-not-described-in-hinic_aeq_register_swe_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:Function-parameter-or-member-hwe_cb-not-described-in-hinic_aeq_register_hw_cb | |-- drivers-net-ethernet-huawei-hinic-hinic_eqs.c:warning:variable-lev-set-but-not-used | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-db_base-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-db_base_phy-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-dwqe_mapping-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_hwif.c:warning:Function-parameter-or-member-intr_reg_base-not-described-in-hinic_init_hwif | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-cmd-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-dest-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-hwdev-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-huawei-hinic-hinic_mgmt.c:warning:Function-parameter-or-member-size-not-described-in-hinic_api_cmd_write_nack | |-- drivers-net-ethernet-mellanox-mlx5-core-en_tc.c:warning:unused-variable-ret | |-- drivers-net-ethernet-stmicro-stmmac-dwmac-phytium.c:error:incompatible-pointer-to-integer-conversion-returning-void-from-a-function-with-result-type-int | |-- drivers-net-ethernet-stmicro-stmmac-dwmac-phytium.c:warning:no-previous-prototype-for-function-phytium_dwmac_remove | |-- net-netfilter-nf_nat_proto.c:warning:no-previous-prototype-for-function-nf_nat_csum_recalc | |-- sound-pci-hda-hda_phytium.c:warning:variable-azx_dev-set-but-not-used | |-- sound-pci-hda-hda_phytium.c:warning:variable-hda-set-but-not-used | `-- sound-pci-hda-hda_phytium.c:warning:variable-index-set-but-not-used |-- x86_64-randconfig-121-20240125 | `-- mm-vmscan.c:error:implicit-declaration-of-function-kernel_swap_enabled-Werror-Wimplicit-function-declaration |-- x86_64-randconfig-122-20240125 | `-- mm-vmscan.c:error:implicit-declaration-of-function-kernel_swap_enabled-Werror-Wimplicit-function-declaration |-- x86_64-randconfig-123-20240125 | |-- kernel-hung_task.c:error:use-of-undeclared-identifier-sysctl_hung_task_all_cpu_backtrace | `-- mm-vmscan.c:error:implicit-declaration-of-function-kernel_swap_enabled-Werror-Wimplicit-function-declaration `-- x86_64-rhel-8.3-rust `-- net-netfilter-nf_nat_proto.c:warning:no-previous-prototype-for-function-nf_nat_csum_recalc elapsed time: 1481m configs tested: 39 configs skipped: 121 tested configs: alpha allnoconfig gcc alpha defconfig gcc arc allmodconfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arm allmodconfig gcc arm allnoconfig gcc arm allyesconfig gcc arm defconfig gcc arm64 allmodconfig gcc arm64 allnoconfig gcc arm64 defconfig gcc arm64 randconfig-001-20240125 gcc arm64 randconfig-002-20240125 gcc arm64 randconfig-003-20240125 gcc arm64 randconfig-004-20240125 gcc csky allmodconfig gcc csky allnoconfig gcc csky allyesconfig gcc csky defconfig gcc loongarch allnoconfig gcc loongarch defconfig gcc m68k allnoconfig gcc m68k defconfig gcc microblaze allnoconfig gcc microblaze defconfig gcc mips allnoconfig gcc nios2 allnoconfig gcc nios2 defconfig gcc x86_64 allnoconfig gcc x86_64 allyesconfig clang x86_64 buildonly-randconfig-001-20240125 gcc x86_64 buildonly-randconfig-002-20240125 gcc x86_64 buildonly-randconfig-003-20240125 gcc x86_64 buildonly-randconfig-004-20240125 gcc x86_64 buildonly-randconfig-006-20240125 gcc x86_64 defconfig gcc x86_64 rhel-8.3-rust clang -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 v2 0/4] Support large folio for mlock
by Peng Zhang 25 Jan '24

25 Jan '24

From: ZhangPeng <zhangpeng362(a)huawei.com> Support large folio for mlock. Backport from v6.7-rc1. ChangeLog: v1->v2: - Add a bugfix patch of patch 2 Hugh Dickins (1): mm: mlock: avoid folio_within_range() on KSM pages Yin Fengwei (3): mm: add functions folio_in_range() and folio_within_vma() mm: handle large folio when large folio in VM_LOCKED VMA range mm: mlock: update mlock_pte_range to handle large folio mm/internal.h | 73 ++++++++++++++++++++++++++++++++++++++++++++------- mm/mlock.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++-- mm/rmap.c | 66 ++++++++++++++++++++++++++++++++++++++-------- 3 files changed, 186 insertions(+), 23 deletions(-) -- 2.25.1

1 4

[PATCH OLK-6.6 0/6] kabi: arch related KABI reserve
by Liao Chen 25 Jan '24

25 Jan '24

Affected files and structs: include/linux/mfd/core.h struct mfd_cell cpuhotplug.h enum cpuhp_state irq_work.h struct irq_work irqdesc.h struct irq_desc irqdomain_defs.h enum irq_domain_bus_token irqdomain.h struct irq_domain Liao Chen (6): kabi: reserve space for cpuhotplug.h: enum cpuhp_state kabi: reserve space for irq_work.h: struct irq_work kabi: reserve space for irqdesc.h: struct irq_desc kabi: reserve space for irqdomain.h: struct irq_domain kabi: reserve space for irqdomain_defs.h: enum irq_domain_bus_token kabi: reserve space for cpuhotplug.h: struct mfd_cell include/linux/cpuhotplug.h | 9 +++++++++ include/linux/irq_work.h | 5 +++++ include/linux/irqdesc.h | 5 +++++ include/linux/irqdomain.h | 5 +++++ include/linux/irqdomain_defs.h | 8 ++++++++ include/linux/mfd/core.h | 6 ++++++ 6 files changed, 38 insertions(+) -- 2.34.1

1 6

[PATCH OLK-6.6 00/17] kabi reserve patches
by Lin Yujun 25 Jan '24

25 Jan '24

*** BLURB HERE *** Chen Jiahao (1): KABI: reserve space for struct input_dev Lin Ruizhe (5): msi: Add kabi_reserve in msi.h interrupt: Add kabi_reserve in interrupt.h irq: Add kabi_reserve in irq irq_desc: Add kabi_reserve in irq_desc irqdomain: Add kabi_reserve in irqdomain Lin Yujun (10): drm: drm_atomic.h: Add kabi_reserve drm: drm_client.h: Add kabi_reserve drm: drm_connector.h: Add kabi_reserve drm: drm_crtc.h: Add kabi_reserve drm: drm_device.h: Add kabi_reserve drm: drm_drv.h: Add kabi_reserve drm: drm_fb_helper.h: Add kabi_reserve drm: drm_file.h: Add kabi_reserve drm: drm_fourcc.h: Add kabi_reserve drm: drm_gem.h: Add kabi_reserve Yang Yingliang (1): kabi: reserve space for struct cpu_stop_work include/drm/drm_atomic.h | 6 ++++++ include/drm/drm_client.h | 7 +++++++ include/drm/drm_connector.h | 18 ++++++++++++++++++ include/drm/drm_crtc.h | 7 +++++++ include/drm/drm_device.h | 4 ++++ include/drm/drm_drv.h | 5 +++++ include/drm/drm_fb_helper.h | 8 ++++++++ include/drm/drm_file.h | 8 ++++++++ include/drm/drm_fourcc.h | 5 +++++ include/drm/drm_gem.h | 8 ++++++++ include/linux/input.h | 4 ++++ include/linux/interrupt.h | 6 ++++++ include/linux/irq.h | 8 ++++++++ include/linux/irqdesc.h | 4 +++- include/linux/irqdomain.h | 3 +++ include/linux/msi.h | 7 +++++++ include/linux/stop_machine.h | 3 +++ 17 files changed, 110 insertions(+), 1 deletion(-) -- 2.34.1

2 18

[PATCH OLK-6.6 0/3] Support large folio for mlock
by Peng Zhang 25 Jan '24

25 Jan '24

From: ZhangPeng <zhangpeng362(a)huawei.com> Support large folio for mlock. Backport from v6.7-rc1. Yin Fengwei (3): mm: add functions folio_in_range() and folio_within_vma() mm: handle large folio when large folio in VM_LOCKED VMA range mm: mlock: update mlock_pte_range to handle large folio mm/internal.h | 73 ++++++++++++++++++++++++++++++++++++++++++++------- mm/mlock.c | 66 ++++++++++++++++++++++++++++++++++++++++++++-- mm/rmap.c | 66 ++++++++++++++++++++++++++++++++++++++-------- 3 files changed, 182 insertions(+), 23 deletions(-) -- 2.25.1

1 3

[PATCH OLK-6.6 0/1] cred: kabi: KABI reservation for cred
by felix 25 Jan '24

25 Jan '24

From: Felix Fu <fuzhen5(a)huawei.com> cred: kabi: KABI reservation for cred Felix Fu (1): cred: kabi: KABI reservation for cred include/linux/cred.h | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.34.1

2 2

[PATCH OLK-6.6 0/4] OLK-6.6 cred backport for kabi reserve
by felix 25 Jan '24

25 Jan '24

From: Felix Fu <fuzhen5(a)huawei.com> OLK-6.6 cred backport for kabi reserve Elena Reshetova (1): groups: Convert group_info.usage to refcount_t Jens Axboe (2): cred: switch to using atomic_long_t cred: get rid of CONFIG_DEBUG_CREDENTIALS Mateusz Guzik (1): cred: add get_cred_many and put_cred_many arch/powerpc/configs/skiroot_defconfig | 1 - arch/s390/configs/debug_defconfig | 1 - fs/nfsd/auth.c | 4 - fs/nfsd/nfssvc.c | 1 - fs/nfsd/vfs.c | 9 +- fs/open.c | 3 - include/linux/cred.h | 120 +++++----- kernel/cred.c | 271 +++------------------- kernel/exit.c | 3 - kernel/groups.c | 2 +- lib/Kconfig.debug | 15 -- net/sunrpc/auth.c | 3 - security/selinux/hooks.c | 6 - tools/objtool/noreturns.h | 1 - tools/testing/selftests/bpf/config.x86_64 | 1 - tools/testing/selftests/hid/config.common | 1 - 16 files changed, 96 insertions(+), 346 deletions(-) -- 2.34.1

2 5

[PATCH OLK-6.6 v3] kabi: reserve space for bpf related structures
by Pu Lehui 25 Jan '24

25 Jan '24

hulk inclusion category: feature bugzilla: https://gitee.com/openeuler/kernel/issues/I8UOP9 -------------------------------- reserve space for bpf related structures. Signed-off-by: Pu Lehui <pulehui(a)huawei.com> --- include/linux/bpf.h | 83 +++++++++++++++++++++++++++++++ include/linux/bpf_local_storage.h | 11 ++++ include/linux/bpf_verifier.h | 40 +++++++++++++++ 3 files changed, 134 insertions(+) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index 392f581af2ce..d615a1c02415 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -29,6 +29,7 @@ #include <linux/rcupdate_trace.h> #include <linux/static_call.h> #include <linux/memcontrol.h> +#include <linux/kabi.h> struct bpf_verifier_env; struct bpf_verifier_log; @@ -168,6 +169,11 @@ struct bpf_map_ops { /* bpf_iter info used to open a seq_file */ const struct bpf_iter_seq_info *iter_seq_info; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; enum { @@ -288,6 +294,11 @@ struct bpf_map { bool bypass_spec_v1; bool frozen; /* write-once; write-protected by freeze_mutex */ s64 __percpu *elem_count; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; static inline const char *btf_field_type_name(enum btf_field_type type) @@ -807,6 +818,11 @@ struct bpf_func_proto { }; int *ret_btf_id; /* return value btf_id */ bool (*allowed)(const struct bpf_prog *prog); + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; /* bpf_context is intentionally undefined structure. Pointer to bpf_context is @@ -942,6 +958,11 @@ struct bpf_verifier_ops { int (*btf_struct_access)(struct bpf_verifier_log *log, const struct bpf_reg_state *reg, int off, int size); + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_prog_offload_ops { @@ -1001,6 +1022,9 @@ struct btf_func_model { u8 nr_args; u8 arg_size[MAX_BPF_FUNC_ARGS]; u8 arg_flags[MAX_BPF_FUNC_ARGS]; + + KABI_RESERVE(1) + KABI_RESERVE(2) }; /* Restore arguments before returning from trampoline to let original function @@ -1121,6 +1145,11 @@ struct bpf_tramp_image { struct rcu_head rcu; struct work_struct work; }; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_trampoline { @@ -1149,6 +1178,11 @@ struct bpf_trampoline { /* Executable image of trampoline */ struct bpf_tramp_image *cur_image; struct module *mod; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_attach_target_info { @@ -1180,6 +1214,11 @@ struct bpf_dispatcher { struct static_call_key *sc_key; void *sc_tramp; #endif + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; static __always_inline __nocfi unsigned int bpf_dispatcher_nop_func( @@ -1465,6 +1504,15 @@ struct bpf_prog_aux { struct work_struct work; struct rcu_head rcu; }; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) + KABI_RESERVE(5) + KABI_RESERVE(6) + KABI_RESERVE(7) + KABI_RESERVE(8) }; struct bpf_prog { @@ -1499,6 +1547,11 @@ struct bpf_prog { DECLARE_FLEX_ARRAY(struct sock_filter, insns); DECLARE_FLEX_ARRAY(struct bpf_insn, insnsi); }; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_array_aux { @@ -1507,6 +1560,11 @@ struct bpf_array_aux { struct bpf_map *map; struct mutex poke_mutex; struct work_struct work; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_link { @@ -1516,6 +1574,11 @@ struct bpf_link { const struct bpf_link_ops *ops; struct bpf_prog *prog; struct work_struct work; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_link_ops { @@ -1529,6 +1592,11 @@ struct bpf_link_ops { struct bpf_link_info *info); int (*update_map)(struct bpf_link *link, struct bpf_map *new_map, struct bpf_map *old_map); + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_tramp_link { @@ -1626,6 +1694,11 @@ struct bpf_struct_ops { struct btf_func_model func_models[BPF_STRUCT_OPS_MAX_NR_MEMBERS]; u32 type_id; u32 value_id; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; #if defined(CONFIG_BPF_JIT) && defined(CONFIG_BPF_SYSCALL) @@ -1727,6 +1800,11 @@ struct bpf_array { DECLARE_FLEX_ARRAY(void *, ptrs) __aligned(8); DECLARE_FLEX_ARRAY(void __percpu *, pptrs) __aligned(8); }; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; #define BPF_COMPLEXITY_LIMIT_INSNS 1000000 /* yes. 1M insns */ @@ -1822,6 +1900,11 @@ struct bpf_prog_array_item { struct bpf_cgroup_storage *cgroup_storage[MAX_BPF_CGROUP_STORAGE_TYPE]; u64 bpf_cookie; }; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_prog_array { diff --git a/include/linux/bpf_local_storage.h b/include/linux/bpf_local_storage.h index 173ec7f43ed1..c2ae8788a5cb 100644 --- a/include/linux/bpf_local_storage.h +++ b/include/linux/bpf_local_storage.h @@ -14,6 +14,7 @@ #include <linux/hash.h> #include <linux/types.h> #include <linux/bpf_mem_alloc.h> +#include <linux/kabi.h> #include <uapi/linux/btf.h> #define BPF_LOCAL_STORAGE_CACHE_SIZE 16 @@ -59,6 +60,11 @@ struct bpf_local_storage_map { struct bpf_mem_alloc selem_ma; struct bpf_mem_alloc storage_ma; bool bpf_ma; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_local_storage_data { @@ -94,6 +100,11 @@ struct bpf_local_storage { */ struct rcu_head rcu; raw_spinlock_t lock; /* Protect adding/removing from the "list" */ + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; /* U16_MAX is much more than enough for sk local storage diff --git a/include/linux/bpf_verifier.h b/include/linux/bpf_verifier.h index b6e58dab8e27..d2b59c6d9d60 100644 --- a/include/linux/bpf_verifier.h +++ b/include/linux/bpf_verifier.h @@ -8,6 +8,7 @@ #include <linux/btf.h> /* for struct btf and btf_id() */ #include <linux/filter.h> /* for MAX_BPF_STACK */ #include <linux/tnum.h> +#include <linux/kabi.h> /* Maximum variable offset umax_value permitted when resolving memory accesses. * In practice this is far bigger than any realistic pointer offset; this limit @@ -225,6 +226,11 @@ struct bpf_reg_state { enum bpf_reg_liveness live; /* if (!precise && SCALAR_VALUE) min/max/tnum don't affect safety */ bool precise; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; enum bpf_stack_slot_type { @@ -273,6 +279,11 @@ struct bpf_reference_state { * exiting a callback function. */ int callback_ref; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; /* state of the program: @@ -306,6 +317,11 @@ struct bpf_func_state { struct bpf_reference_state *refs; int allocated_stack; struct bpf_stack_state *stack; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_idx_pair { @@ -383,6 +399,11 @@ struct bpf_verifier_state { */ struct bpf_idx_pair *jmp_history; u32 jmp_history_cnt; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; #define bpf_get_spilled_reg(slot, frame) \ @@ -490,6 +511,11 @@ struct bpf_insn_aux_data { * this instruction, regardless of any heuristics */ bool force_checkpoint; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; #define MAX_USED_MAPS 64 /* max number of maps accessed by one eBPF program */ @@ -541,6 +567,11 @@ struct bpf_subprog_info { bool tail_call_reachable; bool has_ld_abs; bool is_async_cb; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) }; struct bpf_verifier_env; @@ -640,6 +671,15 @@ struct bpf_verifier_env { * e.g., in reg_type_str() to generate reg_type string */ char tmp_str_buf[TMP_STR_BUF_LEN]; + + KABI_RESERVE(1) + KABI_RESERVE(2) + KABI_RESERVE(3) + KABI_RESERVE(4) + KABI_RESERVE(5) + KABI_RESERVE(6) + KABI_RESERVE(7) + KABI_RESERVE(8) }; __printf(2, 0) void bpf_verifier_vlog(struct bpf_verifier_log *log, -- 2.34.1

1 0

[PATCH OLK-6.6 0/4] cgroup and ns kabi
by Chen Ridong 25 Jan '24

25 Jan '24

Chen Ridong (4): cgroup: kabi: reserve space for cgroup frame namespace: kabi: reserve for future namespace development cgroup/psi: reserve kabi for future psi development cgroup/misc: reserve kabi for future misc development include/linux/cgroup-defs.h | 38 ++++++++++++++++++++++++++++++++++ include/linux/ipc_namespace.h | 1 + include/linux/misc_cgroup.h | 12 +++++++++++ include/linux/nsproxy.h | 4 ++++ include/linux/pid_namespace.h | 4 ++++ include/linux/psi_types.h | 29 ++++++++++++++++++++++++++ include/linux/user_namespace.h | 9 ++++++++ kernel/ucount.c | 6 ++++++ 8 files changed, 103 insertions(+) -- 2.34.1

2 5

[PATCH OLK-6.6 0/4] OLK-6.6 cred backport for kabi reserve
by felix 25 Jan '24

25 Jan '24

From: Felix Fu <fuzhen5(a)huawei.com> OLK-6.6 cred backport for kabi reserve Elena Reshetova (1): groups: Convert group_info.usage to refcount_t Jens Axboe (2): cred: switch to using atomic_long_t cred: get rid of CONFIG_DEBUG_CREDENTIALS Mateusz Guzik (1): cred: add get_cred_many and put_cred_many arch/powerpc/configs/skiroot_defconfig | 1 - arch/s390/configs/debug_defconfig | 1 - fs/nfsd/auth.c | 4 - fs/nfsd/nfssvc.c | 1 - fs/nfsd/vfs.c | 9 +- fs/open.c | 3 - include/linux/cred.h | 120 +++++----- kernel/cred.c | 271 +++------------------- kernel/exit.c | 3 - kernel/groups.c | 2 +- lib/Kconfig.debug | 15 -- net/sunrpc/auth.c | 3 - security/selinux/hooks.c | 6 - tools/objtool/noreturns.h | 1 - tools/testing/selftests/bpf/config.x86_64 | 1 - tools/testing/selftests/hid/config.common | 1 - 16 files changed, 96 insertions(+), 346 deletions(-) -- 2.34.1

2 5

[PATCH OLK-6.6] pciehp: fix a race between pciehp and removing operations by sysfs
by Xiongfeng Wang 25 Jan '24

25 Jan '24

hulk inclusion category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8YPFU CVE: NA ------------------------------------------------- When I run a stress test about pcie hotplug and removing operations by sysfs, I got a hange task, and the following call trace is printed. INFO: task irq/746-pciehp:41551 blocked for more than 120 seconds. Tainted: P W OE 4.19.25- "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. irq/746-pciehp D 0 41551 2 0x00000228 Call trace: __switch_to+0x94/0xe8 __schedule+0x270/0x8b0 schedule+0x2c/0x88 schedule_preempt_disabled+0x14/0x20 __mutex_lock.isra.1+0x1fc/0x540 __mutex_lock_slowpath+0x24/0x30 mutex_lock+0x80/0xa8 pci_lock_rescan_remove+0x20/0x28 pciehp_configure_device+0x30/0x140 pciehp_handle_presence_or_link_change+0x35c/0x4b0 pciehp_ist+0x1cc/0x1d0 irq_thread_fn+0x30/0x80 irq_thread+0x128/0x200 kthread+0x134/0x138 ret_from_fork+0x10/0x18 INFO: task bash:6424 blocked for more than 120 seconds. Tainted: P W OE 4.19.25- "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. bash D 0 6424 2231 0x00000200 Call trace: __switch_to+0x94/0xe8 __schedule+0x270/0x8b0 schedule+0x2c/0x88 schedule_timeout+0x224/0x448 wait_for_common+0x198/0x2a0 wait_for_completion+0x28/0x38 kthread_stop+0x60/0x190 __free_irq+0x1c0/0x348 free_irq+0x40/0x88 pcie_shutdown_notification+0x54/0x80 pciehp_remove+0x30/0x50 pcie_port_remove_service+0x3c/0x58 device_release_driver_internal+0x1b4/0x250 device_release_driver+0x28/0x38 bus_remove_device+0xd4/0x160 device_del+0x128/0x348 device_unregister+0x24/0x78 remove_iter+0x48/0x58 device_for_each_child+0x6c/0xb8 pcie_port_device_remove+0x2c/0x48 pcie_portdrv_remove+0x5c/0x68 pci_device_remove+0x48/0xd8 device_release_driver_internal+0x1b4/0x250 device_release_driver+0x28/0x38 pci_stop_bus_device+0x84/0xb8 pci_stop_and_remove_bus_device_locked+0x24/0x40 remove_store+0xa4/0xb8 dev_attr_store+0x44/0x60 sysfs_kf_write+0x58/0x80 kernfs_fop_write+0xe8/0x1f0 __vfs_write+0x60/0x190 vfs_write+0xac/0x1c0 ksys_write+0x6c/0xd8 __arm64_sys_write+0x24/0x30 el0_svc_common+0xa0/0x180 el0_svc_handler+0x38/0x78 el0_svc+0x8/0xc When we remove a slot by sysfs. 'pci_stop_and_remove_bus_device_locked()' will be called. This function will get the global mutex lock 'pci_rescan_remove_lock', and remove the slot. If the irq thread 'pciehp_ist' is still running, we will wait until it exits. If a pciehp interrupt happens immediately after we remove the slot by sysfs, but before we free the pciehp irq in 'pci_stop_and_remove_bus_device_locked()'. 'pciehp_ist' will hung because the global mutex lock 'pci_rescan_remove_lock' is held by the sysfs operation. But the sysfs operation is waiting for the pciehp irq thread 'pciehp_ist' ends. Then a hung task occurs. So this two kinds of operation, removing through attention buttion and removing through /sys/devices/pci***/remove, should not be excuted at the same time. This patch add a global variable to mark that one of these operations is under processing. When this variable is set, if another operation is requested, it will be rejected. We use a global variable 'slot_being_removed_rescaned' to mark whether a slot is being removed or rescaned. This will cause a slot hotplug operation is delayed if another slot is being remove or rescaned. But if these two slots are under different root ports, they should not influence each other. This patch make the flag 'slot_being_removed_rescanned' per root port so that one slot hotplug operation doesn't influence slots below another root port. We record the root port in struct pci_dev when the pci device is initialized and added into the system instead of using 'pcie_find_root_port()' to find the root port when we need it. Because iterating the pci tree needs the protection of 'pci_lock_rescan_remove()'. This will make the problem more complexed because the lock is very coarse-grained. We don't need to worry about 'use-after-free' because child pci devices are always removed before the root port device is removed. Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> Reviewed-by: Hanjun Guo <guohanjun(a)huawei.com> Conflicts: drivers/pci/hotplug/pciehp_ctrl.c drivers/pci/hotplug/pciehp_hpc.c include/linux/pci.h Signed-off-by: Xiongfeng Wang <wangxiongfeng2(a)huawei.com> --- drivers/pci/hotplug/pciehp.h | 5 ++ drivers/pci/hotplug/pciehp_ctrl.c | 40 ++++++++++++++++ drivers/pci/hotplug/pciehp_hpc.c | 79 ++++++++++++++++++++++++++----- drivers/pci/pci-sysfs.c | 22 +++++++++ drivers/pci/probe.c | 5 ++ include/linux/pci.h | 8 ++++ include/linux/workqueue.h | 2 + 7 files changed, 150 insertions(+), 11 deletions(-) diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h index e0a614acee05..dad48d151ce2 100644 --- a/drivers/pci/hotplug/pciehp.h +++ b/drivers/pci/hotplug/pciehp.h @@ -199,6 +199,11 @@ static inline const char *slot_name(struct controller *ctrl) return hotplug_slot_name(&ctrl->hotplug_slot); } +static inline struct pci_dev *ctrl_dev(struct controller *ctrl) +{ + return ctrl->pcie->port; +} + static inline struct controller *to_ctrl(struct hotplug_slot *hotplug_slot) { return container_of(hotplug_slot, struct controller, hotplug_slot); diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c index dcdbfcf404dd..458ab6f6379c 100644 --- a/drivers/pci/hotplug/pciehp_ctrl.c +++ b/drivers/pci/hotplug/pciehp_ctrl.c @@ -143,6 +143,8 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) { struct controller *ctrl = container_of(work, struct controller, button_work.work); + int events = ctrl->button_work.data; + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; mutex_lock(&ctrl->state_lock); switch (ctrl->state) { @@ -153,6 +155,15 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) pciehp_request(ctrl, PCI_EXP_SLTSTA_PDC); break; default: + if (events) { + atomic_or(events, &ctrl->pending_events); + if (!pciehp_poll_mode) + irq_wake_thread(ctrl->pcie->irq, ctrl); + } else { + if (rpdev) + clear_bit(0, + &rpdev->slot_being_removed_rescanned); + } break; } mutex_unlock(&ctrl->state_lock); @@ -160,6 +171,8 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) void pciehp_handle_button_press(struct controller *ctrl) { + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; + mutex_lock(&ctrl->state_lock); switch (ctrl->state) { case OFF_STATE: @@ -176,6 +189,7 @@ void pciehp_handle_button_press(struct controller *ctrl) /* blink power indicator and turn off attention */ pciehp_set_indicators(ctrl, PCI_EXP_SLTCTL_PWR_IND_BLINK, PCI_EXP_SLTCTL_ATTN_IND_OFF); + ctrl->button_work.data = 0; schedule_delayed_work(&ctrl->button_work, 5 * HZ); break; case BLINKINGOFF_STATE: @@ -199,10 +213,14 @@ void pciehp_handle_button_press(struct controller *ctrl) ctrl_info(ctrl, "Slot(%s): Button press: canceling request to power on\n", slot_name(ctrl)); } + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); break; default: ctrl_err(ctrl, "Slot(%s): Button press: ignoring invalid state %#x\n", slot_name(ctrl), ctrl->state); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); break; } mutex_unlock(&ctrl->state_lock); @@ -210,6 +228,8 @@ void pciehp_handle_button_press(struct controller *ctrl) void pciehp_handle_disable_request(struct controller *ctrl) { + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; + mutex_lock(&ctrl->state_lock); switch (ctrl->state) { case BLINKINGON_STATE: @@ -221,11 +241,14 @@ void pciehp_handle_disable_request(struct controller *ctrl) mutex_unlock(&ctrl->state_lock); ctrl->request_result = pciehp_disable_slot(ctrl, SAFE_REMOVAL); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); } void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events) { int present, link_active; + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; /* * If the slot is on and presence or link has changed, turn it off. @@ -266,6 +289,8 @@ void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events) slot_name(ctrl)); } mutex_unlock(&ctrl->state_lock); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); return; } @@ -288,6 +313,8 @@ void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events) mutex_unlock(&ctrl->state_lock); break; } + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); } static int __pciehp_enable_slot(struct controller *ctrl) @@ -408,6 +435,14 @@ int pciehp_sysfs_enable_slot(struct hotplug_slot *hotplug_slot) int pciehp_sysfs_disable_slot(struct hotplug_slot *hotplug_slot) { struct controller *ctrl = to_ctrl(hotplug_slot); + struct pci_dev *rpdev = ctrl_dev(ctrl)->rpdev; + + if (rpdev && test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned)) { + ctrl_info(ctrl, "Slot(%s): Slot is being removed or rescanned, please try later!\n", + slot_name(ctrl)); + return -EINVAL; + } mutex_lock(&ctrl->state_lock); switch (ctrl->state) { @@ -418,6 +453,8 @@ int pciehp_sysfs_disable_slot(struct hotplug_slot *hotplug_slot) wait_event(ctrl->requester, !atomic_read(&ctrl->pending_events) && !ctrl->ist_running); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); return ctrl->request_result; case POWEROFF_STATE: ctrl_info(ctrl, "Slot(%s): Already in powering off state\n", @@ -436,5 +473,8 @@ int pciehp_sysfs_disable_slot(struct hotplug_slot *hotplug_slot) } mutex_unlock(&ctrl->state_lock); + if (rpdev) + clear_bit(0, &rpdev->slot_being_removed_rescanned); + return -ENODEV; } diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index fd713abdfb9f..a0fdcd4dc358 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -45,11 +45,6 @@ static const struct dmi_system_id inband_presence_disabled_dmi_table[] = { {} }; -static inline struct pci_dev *ctrl_dev(struct controller *ctrl) -{ - return ctrl->pcie->port; -} - static irqreturn_t pciehp_isr(int irq, void *dev_id); static irqreturn_t pciehp_ist(int irq, void *dev_id); static int pciehp_poll(void *data); @@ -694,6 +689,7 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) { struct controller *ctrl = (struct controller *)dev_id; struct pci_dev *pdev = ctrl_dev(ctrl); + struct pci_dev *rpdev = pdev->rpdev; irqreturn_t ret; u32 events; @@ -716,8 +712,20 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) } /* Check Attention Button Pressed */ - if (events & PCI_EXP_SLTSTA_ABP) - pciehp_handle_button_press(ctrl); + if (events & PCI_EXP_SLTSTA_ABP) { + if (!rpdev || (rpdev && !test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned))) + pciehp_handle_button_press(ctrl); + else { + if (ctrl->state == BLINKINGOFF_STATE || + ctrl->state == BLINKINGON_STATE) + pciehp_handle_button_press(ctrl); + else + ctrl_info(ctrl, "Slot(%s): Slot operation failed because a remove or" + " rescan operation is under processing, please try later!\n", + slot_name(ctrl)); + } + } /* Check Power Fault Detected */ if (events & PCI_EXP_SLTSTA_PFD) { @@ -741,10 +749,59 @@ static irqreturn_t pciehp_ist(int irq, void *dev_id) * or Data Link Layer State Changed events. */ down_read_nested(&ctrl->reset_lock, ctrl->depth); - if (events & DISABLE_SLOT) - pciehp_handle_disable_request(ctrl); - else if (events & (PCI_EXP_SLTSTA_PDC | PCI_EXP_SLTSTA_DLLSC)) - pciehp_handle_presence_or_link_change(ctrl, events); + if (events & DISABLE_SLOT) { + if (!rpdev || (rpdev && !test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned))) + pciehp_handle_disable_request(ctrl); + else { + if (ctrl->state == BLINKINGOFF_STATE || + ctrl->state == BLINKINGON_STATE) + pciehp_handle_disable_request(ctrl); + else { + ctrl_info(ctrl, "Slot(%s): DISABLE_SLOT event in remove or rescan process!\n", + slot_name(ctrl)); + /* + * we use the work_struct private data to store + * the event type + */ + ctrl->button_work.data = DISABLE_SLOT; + /* + * If 'work.timer' is pending, schedule the work will + * cause BUG_ON(). + */ + if (!timer_pending(&ctrl->button_work.timer)) + schedule_delayed_work(&ctrl->button_work, 3 * HZ); + else + ctrl_info(ctrl, "Slot(%s): Didn't schedule delayed_work because timer is pending!\n", + slot_name(ctrl)); + } + } + } else if (events & (PCI_EXP_SLTSTA_PDC | PCI_EXP_SLTSTA_DLLSC)) { + if (!rpdev || (rpdev && !test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned))) + pciehp_handle_presence_or_link_change(ctrl, events); + else { + if (ctrl->state == BLINKINGOFF_STATE || + ctrl->state == BLINKINGON_STATE) + pciehp_handle_presence_or_link_change(ctrl, + events); + else { + /* + * When we are removing or rescanning through + * sysfs, suprise link down/up happens. So we + * will handle this event 3 seconds later. + */ + ctrl_info(ctrl, "Slot(%s): Surprise link down/up in remove or rescan process!\n", + slot_name(ctrl)); + ctrl->button_work.data = events & (PCI_EXP_SLTSTA_PDC | PCI_EXP_SLTSTA_DLLSC); + if (!timer_pending(&ctrl->button_work.timer)) + schedule_delayed_work(&ctrl->button_work, 3 * HZ); + else + ctrl_info(ctrl, "Slot(%s): Didn't schedule delayed_work because timer is pending!\n", + slot_name(ctrl)); + } + } + } up_read(&ctrl->reset_lock); ret = IRQ_HANDLED; diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 3317b9354716..156f97c9c696 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -483,12 +483,34 @@ static ssize_t remove_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { unsigned long val; + struct pci_dev *rpdev = to_pci_dev(dev)->rpdev; if (kstrtoul(buf, 0, &val) < 0) return -EINVAL; + if (rpdev && test_and_set_bit(0, + &rpdev->slot_being_removed_rescanned)) { + pr_info("Slot is being removed or rescanned, please try later!\n"); + return -EINVAL; + } + + /* + * if 'dev' is root port itself, 'pci_stop_and_remove_bus_device()' may + * free the 'rpdev', but we need to clear + * 'rpdev->slot_being_removed_rescanned' in the end. So get 'rpdev' to + * avoid possible 'use-after-free'. + */ + if (rpdev) + pci_dev_get(rpdev); + if (val && device_remove_file_self(dev, attr)) pci_stop_and_remove_bus_device_locked(to_pci_dev(dev)); + + if (rpdev) { + clear_bit(0, &rpdev->slot_being_removed_rescanned); + pci_dev_put(rpdev); + } + return count; } static DEVICE_ATTR_IGNORE_LOCKDEP(remove, 0220, NULL, diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 43159965e09e..9dfb9d22b1f6 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -2578,6 +2578,11 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus) /* Set up MSI IRQ domain */ pci_set_msi_domain(dev); + if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) + dev->rpdev = dev; + else + dev->rpdev = pcie_find_root_port(dev); + /* Notifier could use PCI capabilities */ dev->match_driver = false; ret = device_add(&dev->dev); diff --git a/include/linux/pci.h b/include/linux/pci.h index b56417276042..bf1de133c569 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -529,6 +529,13 @@ struct pci_dev { /* These methods index pci_reset_fn_methods[] */ u8 reset_methods[PCI_NUM_RESET_METHODS]; /* In priority order */ + + /* + * This flag is only set on root ports. When a slot below a root port + * is being removed or rescanned, this flag is set. + */ + unsigned long slot_being_removed_rescanned; + struct pci_dev *rpdev; /* root port pci_dev */ }; static inline struct pci_dev *pci_physfn(struct pci_dev *dev) @@ -1081,6 +1088,7 @@ extern struct bus_type pci_bus_type; /* Do NOT directly access these two variables, unless you are arch-specific PCI * code, or PCI core code. */ extern struct list_head pci_root_buses; /* List of all known PCI buses */ + /* Some device drivers need know if PCI is initiated */ int no_pci_devices(void); diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h index 24b1e5070f4d..571dd2ec4381 100644 --- a/include/linux/workqueue.h +++ b/include/linux/workqueue.h @@ -115,6 +115,8 @@ struct delayed_work { /* target workqueue and CPU ->timer uses to queue ->work */ struct workqueue_struct *wq; int cpu; + /* delayed_work private data, only used in pciehp now */ + unsigned long data; }; struct rcu_work { -- 2.20.1

2 1

[openeuler:OLK-6.6 1359/2707] mm/share_pool.c:1226:21: error: implicit declaration of function 'huge_ptep_get'
by kernel test robot 25 Jan '24

25 Jan '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: e076c150c75c29fb99c2e7d8ae567b7ed6cce8b3 commit: 549b1f40b56511536196f7522ffa4d7b3da42337 [1359/2707] mm/sharepool: Implement mg_sp_make_share_u2k() config: arm64-randconfig-002-20240125 (https://download.01.org/0day-ci/archive/20240125/202401250925.wptU5r3b-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240125/202401250925.wptU5r3b-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401250925.wptU5r3b-lkp@intel.com/ All errors (new ones prefixed by >>): mm/share_pool.c: In function 'sp_hugetlb_entry': >> mm/share_pool.c:1226:21: error: implicit declaration of function 'huge_ptep_get' [-Werror=implicit-function-declaration] 1226 | pte_t pte = huge_ptep_get(ptep); | ^~~~~~~~~~~~~ >> mm/share_pool.c:1226:21: error: invalid initializer mm/share_pool.c: At top level: mm/share_pool.c:1005:13: warning: 'sp_area_put_locked' defined but not used [-Wunused-function] 1005 | static void sp_area_put_locked(struct sp_area *spa) | ^~~~~~~~~~~~~~~~~~ mm/share_pool.c:944:24: warning: 'sp_area_get' defined but not used [-Wunused-function] 944 | static struct sp_area *sp_area_get(struct sp_group *spg, | ^~~~~~~~~~~ mm/share_pool.c:791:24: warning: 'sp_area_alloc' defined but not used [-Wunused-function] 791 | static struct sp_area *sp_area_alloc(unsigned long size, unsigned long flags, | ^~~~~~~~~~~~~ mm/share_pool.c:587:21: warning: 'spa_file' defined but not used [-Wunused-function] 587 | static struct file *spa_file(struct sp_area *spa) | ^~~~~~~~ mm/share_pool.c:582:22: warning: 'spa_size' defined but not used [-Wunused-function] 582 | static unsigned long spa_size(struct sp_area *spa) | ^~~~~~~~ mm/share_pool.c:497:13: warning: 'update_mem_usage_k2u' defined but not used [-Wunused-function] 497 | static void update_mem_usage_k2u(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:485:13: warning: 'update_mem_usage_alloc' defined but not used [-Wunused-function] 485 | static void update_mem_usage_alloc(unsigned long size, bool inc, | ^~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:438:12: warning: 'sp_group_setup_mapping_normal' defined but not used [-Wunused-function] 438 | static int sp_group_setup_mapping_normal(struct mm_struct *mm, struct sp_group *spg) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/share_pool.c:380:13: warning: 'sp_mapping_detach' defined but not used [-Wunused-function] 380 | static void sp_mapping_detach(struct sp_group *spg, struct sp_mapping *spm) | ^~~~~~~~~~~~~~~~~ mm/share_pool.c:237:13: warning: 'meminfo_init' defined but not used [-Wunused-function] 237 | static void meminfo_init(struct sp_meminfo *meminfo) | ^~~~~~~~~~~~ In file included from mm/share_pool.c:26: mm/share_pool.c:76:19: warning: 'sp_group_idr' defined but not used [-Wunused-variable] 76 | static DEFINE_IDR(sp_group_idr); | ^~~~~~~~~~~~ include/linux/idr.h:56:44: note: in definition of macro 'DEFINE_IDR' 56 | #define DEFINE_IDR(name) struct idr name = IDR_INIT(name) | ^~~~ mm/share_pool.c:73:12: warning: 'system_group_count' defined but not used [-Wunused-variable] 73 | static int system_group_count; | ^~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/huge_ptep_get +1226 mm/share_pool.c 1221 1222 static int sp_hugetlb_entry(pte_t *ptep, unsigned long hmask, 1223 unsigned long addr, unsigned long next, 1224 struct mm_walk *walk) 1225 { > 1226 pte_t pte = huge_ptep_get(ptep); 1227 struct page *page = pte_page(pte); 1228 struct sp_walk_data *sp_walk_data; 1229 1230 if (unlikely(!pte_present(pte))) { 1231 pr_debug("the page of addr %lx unexpectedly not in RAM\n", (unsigned long)addr); 1232 return -EFAULT; 1233 } 1234 1235 sp_walk_data = walk->private; 1236 get_page(page); 1237 sp_walk_data->pages[sp_walk_data->page_count++] = page; 1238 return 0; 1239 } 1240 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0