- Kernel - mailweb.openeuler.org

[PATCH openEuler-1.0-LTS] f2fs: fix to avoid dirent corruption
by Zizhi Wo 26 Feb '24

26 Feb '24

From: Chao Yu <chao(a)kernel.org> stable inclusion from stable-v4.19.306 commit 02160112e6d45c2610b049df6eb693d7a2e57b46 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I932VP CVE: CVE-2023-52444 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 53edb549565f55ccd0bdf43be3d66ce4c2d48b28 ] As Al reported in link[1]: f2fs_rename() ... if (old_dir != new_dir && !whiteout) f2fs_set_link(old_inode, old_dir_entry, old_dir_page, new_dir); else f2fs_put_page(old_dir_page, 0); You want correct inumber in the ".." link. And cross-directory rename does move the source to new parent, even if you'd been asked to leave a whiteout in the old place. [1] https://lore.kernel.org/all/20231017055040.GN800259@ZenIV/ With below testcase, it may cause dirent corruption, due to it missed to call f2fs_set_link() to update ".." link to new directory. - mkdir -p dir/foo - renameat2 -w dir/foo bar [ASSERT] (__chk_dots_dentries:1421) --> Bad inode number[0x4] for '..', parent parent ino is [0x3] [FSCK] other corrupted bugs [Fail] Fixes: 7e01e7ad746b ("f2fs: support RENAME_WHITEOUT") Cc: Jan Kara <jack(a)suse.cz> Reported-by: Al Viro <viro(a)zeniv.linux.org.uk> Signed-off-by: Chao Yu <chao(a)kernel.org> Reviewed-by: Jan Kara <jack(a)suse.cz> Signed-off-by: Jaegeuk Kim <jaegeuk(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Zizhi Wo <wozizhi(a)huawei.com> --- fs/f2fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 0ace2c2e3de9..98afafe633a2 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -968,7 +968,7 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, } if (old_dir_entry) { - if (old_dir != new_dir && !whiteout) + if (old_dir != new_dir) f2fs_set_link(old_inode, old_dir_entry, old_dir_page, new_dir); else -- 2.39.2

2 1

[openEuler-1.0-LTS] f2fs: fix to avoid dirent corruption
by Zizhi Wo 26 Feb '24

26 Feb '24

From: Chao Yu <chao(a)kernel.org> stable inclusion from stable-v4.19.306 commit 02160112e6d45c2610b049df6eb693d7a2e57b46 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I932VP CVE: CVE-2023-52444 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 53edb549565f55ccd0bdf43be3d66ce4c2d48b28 ] As Al reported in link[1]: f2fs_rename() ... if (old_dir != new_dir && !whiteout) f2fs_set_link(old_inode, old_dir_entry, old_dir_page, new_dir); else f2fs_put_page(old_dir_page, 0); You want correct inumber in the ".." link. And cross-directory rename does move the source to new parent, even if you'd been asked to leave a whiteout in the old place. [1] https://lore.kernel.org/all/20231017055040.GN800259@ZenIV/ With below testcase, it may cause dirent corruption, due to it missed to call f2fs_set_link() to update ".." link to new directory. - mkdir -p dir/foo - renameat2 -w dir/foo bar [ASSERT] (__chk_dots_dentries:1421) --> Bad inode number[0x4] for '..', parent parent ino is [0x3] [FSCK] other corrupted bugs [Fail] Fixes: 7e01e7ad746b ("f2fs: support RENAME_WHITEOUT") Cc: Jan Kara <jack(a)suse.cz> Reported-by: Al Viro <viro(a)zeniv.linux.org.uk> Signed-off-by: Chao Yu <chao(a)kernel.org> Reviewed-by: Jan Kara <jack(a)suse.cz> Signed-off-by: Jaegeuk Kim <jaegeuk(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Zizhi Wo <wozizhi(a)huawei.com> --- fs/f2fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 0ace2c2e3de9..98afafe633a2 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -968,7 +968,7 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, } if (old_dir_entry) { - if (old_dir != new_dir && !whiteout) + if (old_dir != new_dir) f2fs_set_link(old_inode, old_dir_entry, old_dir_page, new_dir); else -- 2.39.2

1 0

[openeuler:openEuler-1.0-LTS 13425/21632] drivers/net/ethernet/huawei/hinic/hinic_hwif.c:649:65: sparse: sparse: incorrect type in argument 4 (different base types)
by kernel test robot 25 Feb '24

25 Feb '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: b97b63500af297c36f80416fd1f1193d227cf51a commit: 90f09a01314abe26de1a722d1b51c351d84e1f5b [13425/21632] net/hinic: Add support for X86 Arch config: x86_64-randconfig-122-20240218 (https://download.01.org/0day-ci/archive/20240225/202402252031.ls64imy6-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240225/202402252031.ls64imy6-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402252031.ls64imy6-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) drivers/net/ethernet/huawei/hinic/hinic_hwif.c:40:16: sparse: sparse: cast to restricted __be32 drivers/net/ethernet/huawei/hinic/hinic_hwif.c:46:16: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int val @@ got restricted __be32 [usertype] @@ drivers/net/ethernet/huawei/hinic/hinic_hwif.c:46:16: sparse: expected unsigned int val drivers/net/ethernet/huawei/hinic/hinic_hwif.c:46:16: sparse: got restricted __be32 [usertype] drivers/net/ethernet/huawei/hinic/hinic_hwif.c:575:29: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected unsigned char [noderef] [usertype] __iomem *cfg_regs_base @@ got void *cfg_reg_base @@ drivers/net/ethernet/huawei/hinic/hinic_hwif.c:575:29: sparse: expected unsigned char [noderef] [usertype] __iomem *cfg_regs_base drivers/net/ethernet/huawei/hinic/hinic_hwif.c:575:29: sparse: got void *cfg_reg_base drivers/net/ethernet/huawei/hinic/hinic_hwif.c:576:30: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected unsigned char [noderef] [usertype] __iomem *intr_regs_base @@ got void *intr_reg_base @@ drivers/net/ethernet/huawei/hinic/hinic_hwif.c:576:30: sparse: expected unsigned char [noderef] [usertype] __iomem *intr_regs_base drivers/net/ethernet/huawei/hinic/hinic_hwif.c:576:30: sparse: got void *intr_reg_base drivers/net/ethernet/huawei/hinic/hinic_hwif.c:579:23: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected unsigned char [noderef] [usertype] __iomem *db_base @@ got void *db_base @@ drivers/net/ethernet/huawei/hinic/hinic_hwif.c:579:23: sparse: expected unsigned char [noderef] [usertype] __iomem *db_base drivers/net/ethernet/huawei/hinic/hinic_hwif.c:579:23: sparse: got void *db_base >> drivers/net/ethernet/huawei/hinic/hinic_hwif.c:649:65: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted gfp_t [usertype] flag @@ got unsigned int flag @@ drivers/net/ethernet/huawei/hinic/hinic_hwif.c:649:65: sparse: expected restricted gfp_t [usertype] flag drivers/net/ethernet/huawei/hinic/hinic_hwif.c:649:65: sparse: got unsigned int flag drivers/net/ethernet/huawei/hinic/hinic_hwif.c:664:65: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted gfp_t [usertype] flag @@ got unsigned int flag @@ drivers/net/ethernet/huawei/hinic/hinic_hwif.c:664:65: sparse: expected restricted gfp_t [usertype] flag drivers/net/ethernet/huawei/hinic/hinic_hwif.c:664:65: sparse: got unsigned int flag drivers/net/ethernet/huawei/hinic/hinic_hwif.c:970:17: sparse: sparse: cast to restricted __be32 drivers/net/ethernet/huawei/hinic/hinic_hwif.c:979:17: sparse: sparse: cast to restricted __be32 drivers/net/ethernet/huawei/hinic/hinic_hwif.c:564: warning: Function parameter or member 'intr_reg_base' not described in 'hinic_init_hwif' drivers/net/ethernet/huawei/hinic/hinic_hwif.c:564: warning: Function parameter or member 'db_base_phy' not described in 'hinic_init_hwif' drivers/net/ethernet/huawei/hinic/hinic_hwif.c:564: warning: Function parameter or member 'db_base' not described in 'hinic_init_hwif' drivers/net/ethernet/huawei/hinic/hinic_hwif.c:564: warning: Function parameter or member 'dwqe_mapping' not described in 'hinic_init_hwif' vim +649 drivers/net/ethernet/huawei/hinic/hinic_hwif.c 746ea35981b1f7 Xue 2019-01-30 640 746ea35981b1f7 Xue 2019-01-30 641 int hinic_dma_zalloc_coherent_align(void *dev_hdl, u64 size, u64 align, 746ea35981b1f7 Xue 2019-01-30 642 unsigned int flag, 746ea35981b1f7 Xue 2019-01-30 643 struct hinic_dma_addr_align *mem_align) 746ea35981b1f7 Xue 2019-01-30 644 { 746ea35981b1f7 Xue 2019-01-30 645 void *vaddr, *align_vaddr; 746ea35981b1f7 Xue 2019-01-30 646 dma_addr_t paddr, align_paddr; 746ea35981b1f7 Xue 2019-01-30 647 u64 real_size = size; 746ea35981b1f7 Xue 2019-01-30 648 746ea35981b1f7 Xue 2019-01-30 @649 vaddr = dma_zalloc_coherent(dev_hdl, real_size, &paddr, flag); 746ea35981b1f7 Xue 2019-01-30 650 if (!vaddr) 746ea35981b1f7 Xue 2019-01-30 651 return -ENOMEM; 746ea35981b1f7 Xue 2019-01-30 652 746ea35981b1f7 Xue 2019-01-30 653 align_paddr = ALIGN(paddr, align); 746ea35981b1f7 Xue 2019-01-30 654 /* align */ 746ea35981b1f7 Xue 2019-01-30 655 if (align_paddr == paddr) { 746ea35981b1f7 Xue 2019-01-30 656 align_vaddr = vaddr; 746ea35981b1f7 Xue 2019-01-30 657 goto out; 746ea35981b1f7 Xue 2019-01-30 658 } 746ea35981b1f7 Xue 2019-01-30 659 746ea35981b1f7 Xue 2019-01-30 660 dma_free_coherent(dev_hdl, real_size, vaddr, paddr); 746ea35981b1f7 Xue 2019-01-30 661 746ea35981b1f7 Xue 2019-01-30 662 /* realloc memory for align */ 746ea35981b1f7 Xue 2019-01-30 663 real_size = size + align; 746ea35981b1f7 Xue 2019-01-30 664 vaddr = dma_zalloc_coherent(dev_hdl, real_size, &paddr, flag); 746ea35981b1f7 Xue 2019-01-30 665 if (!vaddr) 746ea35981b1f7 Xue 2019-01-30 666 return -ENOMEM; 746ea35981b1f7 Xue 2019-01-30 667 746ea35981b1f7 Xue 2019-01-30 668 align_paddr = ALIGN(paddr, align); 746ea35981b1f7 Xue 2019-01-30 669 align_vaddr = (void *)((u64)vaddr + (align_paddr - paddr)); 746ea35981b1f7 Xue 2019-01-30 670 746ea35981b1f7 Xue 2019-01-30 671 out: 746ea35981b1f7 Xue 2019-01-30 672 mem_align->real_size = (u32)real_size; 746ea35981b1f7 Xue 2019-01-30 673 mem_align->ori_vaddr = vaddr; 746ea35981b1f7 Xue 2019-01-30 674 mem_align->ori_paddr = paddr; 746ea35981b1f7 Xue 2019-01-30 675 mem_align->align_vaddr = align_vaddr; 746ea35981b1f7 Xue 2019-01-30 676 mem_align->align_paddr = align_paddr; 746ea35981b1f7 Xue 2019-01-30 677 746ea35981b1f7 Xue 2019-01-30 678 return 0; 746ea35981b1f7 Xue 2019-01-30 679 } 746ea35981b1f7 Xue 2019-01-30 680 :::::: The code at line 649 was first introduced by commit :::::: 746ea35981b1f77e988d48642409d73f0470b3eb net: hinic: Add Hardware Abstract Layer :::::: TO: Xue <xuechaojing(a)huawei.com> :::::: CC: Xie XiuQi <xiexiuqi(a)huawei.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 10454/21632] sound/usb/validate.c:113:26: sparse: sparse: restricted __le16 degrades to integer
by kernel test robot 25 Feb '24

25 Feb '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: b97b63500af297c36f80416fd1f1193d227cf51a commit: c6a3607c78f8035db0efc67cb41374fe49e4709d [10454/21632] ALSA: usb-audio: More validations of descriptor units config: x86_64-randconfig-121-20240224 (https://download.01.org/0day-ci/archive/20240225/202402250716.ZS5etOKl-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240225/202402250716.ZS5etOKl-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402250716.ZS5etOKl-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> sound/usb/validate.c:113:26: sparse: sparse: restricted __le16 degrades to integer >> sound/usb/validate.c:113:26: sparse: sparse: restricted __le16 degrades to integer sound/usb/validate.c:128:26: sparse: sparse: restricted __le16 degrades to integer sound/usb/validate.c:128:26: sparse: sparse: restricted __le16 degrades to integer sound/usb/validate.c:145:26: sparse: sparse: restricted __le16 degrades to integer sound/usb/validate.c:145:26: sparse: sparse: restricted __le16 degrades to integer vim +113 sound/usb/validate.c 67 68 /* both for processing and extension units; covering all UACs */ 69 static bool validate_processing_unit(const void *p, 70 const struct usb_desc_validator *v) 71 { 72 const struct uac_processing_unit_descriptor *d = p; 73 const unsigned char *hdr = p; 74 size_t len, m; 75 76 if (d->bLength < sizeof(*d)) 77 return false; 78 len = d->bLength < sizeof(*d) + d->bNrInPins; 79 if (d->bLength < len) 80 return false; 81 switch (v->protocol) { 82 case UAC_VERSION_1: 83 default: 84 /* bNrChannels, wChannelConfig, iChannelNames, bControlSize */ 85 len += 1 + 2 + 1 + 1; 86 if (d->bLength < len) /* bControlSize */ 87 return false; 88 m = hdr[len]; 89 len += 1 + m + 1; /* bControlSize, bmControls, iProcessing */ 90 break; 91 case UAC_VERSION_2: 92 /* bNrChannels, bmChannelConfig, iChannelNames */ 93 len += 1 + 4 + 1; 94 if (v->type == UAC2_PROCESSING_UNIT_V2) 95 len += 2; /* bmControls -- 2 bytes for PU */ 96 else 97 len += 1; /* bmControls -- 1 byte for EU */ 98 len += 1; /* iProcessing */ 99 break; 100 case UAC_VERSION_3: 101 /* wProcessingDescrStr, bmControls */ 102 len += 2 + 4; 103 break; 104 } 105 if (d->bLength < len) 106 return false; 107 108 switch (v->protocol) { 109 case UAC_VERSION_1: 110 default: 111 if (v->type == UAC1_EXTENSION_UNIT) 112 return true; /* OK */ > 113 switch (d->wProcessType) { 114 case UAC_PROCESS_UP_DOWNMIX: 115 case UAC_PROCESS_DOLBY_PROLOGIC: 116 if (d->bLength < len + 1) /* bNrModes */ 117 return false; 118 m = hdr[len]; 119 len += 1 + m * 2; /* bNrModes, waModes(n) */ 120 break; 121 default: 122 break; 123 } 124 break; 125 case UAC_VERSION_2: 126 if (v->type == UAC2_EXTENSION_UNIT_V2) 127 return true; /* OK */ 128 switch (d->wProcessType) { 129 case UAC2_PROCESS_UP_DOWNMIX: 130 case UAC2_PROCESS_DOLBY_PROLOCIC: /* SiC! */ 131 if (d->bLength < len + 1) /* bNrModes */ 132 return false; 133 m = hdr[len]; 134 len += 1 + m * 4; /* bNrModes, daModes(n) */ 135 break; 136 default: 137 break; 138 } 139 break; 140 case UAC_VERSION_3: 141 if (v->type == UAC3_EXTENSION_UNIT) { 142 len += 2; /* wClusterDescrID */ 143 break; 144 } 145 switch (d->wProcessType) { 146 case UAC3_PROCESS_UP_DOWNMIX: 147 if (d->bLength < len + 1) /* bNrModes */ 148 return false; 149 m = hdr[len]; 150 len += 1 + m * 2; /* bNrModes, waClusterDescrID(n) */ 151 break; 152 case UAC3_PROCESS_MULTI_FUNCTION: 153 len += 2 + 4; /* wClusterDescrID, bmAlgorighms */ 154 break; 155 default: 156 break; 157 } 158 break; 159 } 160 if (d->bLength < len) 161 return false; 162 163 return true; 164 } 165 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 13350/21632] ld.lld: error: undefined symbol: kfree_skb
by kernel test robot 24 Feb '24

24 Feb '24

tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: b97b63500af297c36f80416fd1f1193d227cf51a commit: 6636f4434a9c5c9c645694db206188ee5a6626dd [13350/21632] ext4: report error to userspace by netlink config: x86_64-buildonly-randconfig-001-20240224 (https://download.01.org/0day-ci/archive/20240224/202402242133.TAc5acto-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240224/202402242133.TAc5acto-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402242133.TAc5acto-lkp@intel.com/ All errors (new ones prefixed by >>): >> ld.lld: error: undefined symbol: __alloc_skb >>> referenced by super.c >>> fs/ext4/super.o:(ext4_netlink_send_info) in archive built-in.a -- >> ld.lld: error: undefined symbol: __nlmsg_put >>> referenced by super.c >>> fs/ext4/super.o:(ext4_netlink_send_info) in archive built-in.a -- >> ld.lld: error: undefined symbol: kfree_skb >>> referenced by super.c >>> fs/ext4/super.o:(ext4_netlink_send_info) in archive built-in.a -- >> ld.lld: error: undefined symbol: netlink_broadcast >>> referenced by super.c >>> fs/ext4/super.o:(ext4_netlink_send_info) in archive built-in.a -- >> ld.lld: error: undefined symbol: init_net >>> referenced by super.c >>> fs/ext4/super.o:(ext4_init_fs) in archive built-in.a -- >> ld.lld: error: undefined symbol: __netlink_kernel_create >>> referenced by super.c >>> fs/ext4/super.o:(ext4_init_fs) in archive built-in.a -- >> ld.lld: error: undefined symbol: netlink_kernel_release >>> referenced by super.c >>> fs/ext4/super.o:(ext4_exit_fs) in archive built-in.a -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 29649/30000] drivers/ub/urma/ubcore/ubcore_device.c:393:23: warning: no previous prototype for function 'ubcore_find_tpf_device_legacy'
by kernel test robot 24 Feb '24

24 Feb '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 4fee6fdef7d687d6ce43289fd7e7f96fde039af0 commit: 329bf7f331286ee5d571d374e31ed50d2877b110 [29649/30000] ubcore: fix the bug of tp negotiation concurrency config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240224/202402242102.SLiva8Ut-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240224/202402242102.SLiva8Ut-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402242102.SLiva8Ut-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/ub/urma/ubcore/ubcore_device.c:306:6: warning: no previous prototype for function 'ubcore_destroy_upi_list' [-Wmissing-prototypes] 306 | void ubcore_destroy_upi_list(void) | ^ drivers/ub/urma/ubcore/ubcore_device.c:306:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 306 | void ubcore_destroy_upi_list(void) | ^ | static >> drivers/ub/urma/ubcore/ubcore_device.c:393:23: warning: no previous prototype for function 'ubcore_find_tpf_device_legacy' [-Wmissing-prototypes] 393 | struct ubcore_device *ubcore_find_tpf_device_legacy(void) | ^ drivers/ub/urma/ubcore/ubcore_device.c:393:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 393 | struct ubcore_device *ubcore_find_tpf_device_legacy(void) | ^ | static 2 warnings generated. -- drivers/ub/urma/ubcore/ubcore_tp.c:66:17: warning: no previous prototype for function 'ubcore_get_mtu' [-Wmissing-prototypes] 66 | enum ubcore_mtu ubcore_get_mtu(int mtu) | ^ drivers/ub/urma/ubcore/ubcore_tp.c:66:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 66 | enum ubcore_mtu ubcore_get_mtu(int mtu) | ^ | static >> drivers/ub/urma/ubcore/ubcore_tp.c:392:5: warning: no previous prototype for function 'ubcore_modify_tp_state' [-Wmissing-prototypes] 392 | int ubcore_modify_tp_state(struct ubcore_device *dev, struct ubcore_tp *tp, | ^ drivers/ub/urma/ubcore/ubcore_tp.c:392:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 392 | int ubcore_modify_tp_state(struct ubcore_device *dev, struct ubcore_tp *tp, | ^ | static drivers/ub/urma/ubcore/ubcore_tp.c:894:19: warning: no previous prototype for function 'ubcore_create_vtp' [-Wmissing-prototypes] 894 | struct ubcore_tp *ubcore_create_vtp(struct ubcore_device *dev, union ubcore_eid *remote_eid, | ^ drivers/ub/urma/ubcore/ubcore_tp.c:894:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 894 | struct ubcore_tp *ubcore_create_vtp(struct ubcore_device *dev, union ubcore_eid *remote_eid, | ^ | static drivers/ub/urma/ubcore/ubcore_tp.c:920:5: warning: no previous prototype for function 'ubcore_destroy_vtp' [-Wmissing-prototypes] 920 | int ubcore_destroy_vtp(struct ubcore_tp *vtp) | ^ drivers/ub/urma/ubcore/ubcore_tp.c:920:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 920 | int ubcore_destroy_vtp(struct ubcore_tp *vtp) | ^ | static 4 warnings generated. -- >> drivers/ub/urma/uburma/uburma_main.c:640:6: warning: no previous prototype for function 'uburma_dev_accessible_by_ns' [-Wmissing-prototypes] 640 | bool uburma_dev_accessible_by_ns(struct uburma_device *ubu_dev, struct net *net) | ^ drivers/ub/urma/uburma/uburma_main.c:640:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 640 | bool uburma_dev_accessible_by_ns(struct uburma_device *ubu_dev, struct net *net) | ^ | static >> drivers/ub/urma/uburma/uburma_main.c:665:5: warning: no previous prototype for function 'uburma_set_dev_ns' [-Wmissing-prototypes] 665 | int uburma_set_dev_ns(char *device_name, int ns_fd) | ^ drivers/ub/urma/uburma/uburma_main.c:665:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 665 | int uburma_set_dev_ns(char *device_name, int ns_fd) | ^ | static >> drivers/ub/urma/uburma/uburma_main.c:723:5: warning: no previous prototype for function 'uburma_set_ns_mode' [-Wmissing-prototypes] 723 | int uburma_set_ns_mode(bool shared) | ^ drivers/ub/urma/uburma/uburma_main.c:723:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 723 | int uburma_set_ns_mode(bool shared) | ^ | static 3 warnings generated. vim +/ubcore_find_tpf_device_legacy +393 drivers/ub/urma/ubcore/ubcore_device.c 392 > 393 struct ubcore_device *ubcore_find_tpf_device_legacy(void) 394 { 395 if (g_tpf == NULL) 396 ubcore_log_err("tpf is not registered yet"); 397 398 ubcore_get_device(g_tpf); 399 return g_tpf; 400 } 401 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 3269/3388] security/integrity/ima/ima_fs.c:773:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true
by kernel test robot 24 Feb '24

24 Feb '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 0e6ac87df9e5122747ac5d9e7da9a45555f16374 commit: 0e45634e06109de7611c36f8d25c0ab35baa0624 [3269/3388] ima: Introduce new securityfs files config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240224/202402241932.aJqB4j0N-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240224/202402241932.aJqB4j0N-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402241932.aJqB4j0N-lkp@intel.com/ All warnings (new ones prefixed by >>): >> security/integrity/ima/ima_fs.c:773:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] 773 | if (IS_ERR(digest_list_data_del)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ security/integrity/ima/ima_fs.c:791:9: note: uninitialized use occurs here 791 | return ret; | ^~~ security/integrity/ima/ima_fs.c:773:2: note: remove the 'if' if its condition is always false 773 | if (IS_ERR(digest_list_data_del)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 774 | goto out; | ~~~~~~~~ security/integrity/ima/ima_fs.c:767:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] 767 | if (IS_ERR(digest_list_data)) | ^~~~~~~~~~~~~~~~~~~~~~~~ security/integrity/ima/ima_fs.c:791:9: note: uninitialized use occurs here 791 | return ret; | ^~~ security/integrity/ima/ima_fs.c:767:2: note: remove the 'if' if its condition is always false 767 | if (IS_ERR(digest_list_data)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 768 | goto out; | ~~~~~~~~ security/integrity/ima/ima_fs.c:761:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] 761 | if (IS_ERR(digests_count)) | ^~~~~~~~~~~~~~~~~~~~~ security/integrity/ima/ima_fs.c:791:9: note: uninitialized use occurs here 791 | return ret; | ^~~ security/integrity/ima/ima_fs.c:761:2: note: remove the 'if' if its condition is always false 761 | if (IS_ERR(digests_count)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ 762 | goto out; | ~~~~~~~~ security/integrity/ima/ima_fs.c:690:9: note: initialize the variable 'ret' to silence this warning 690 | int ret; | ^ | = 0 3 warnings generated. vim +773 security/integrity/ima/ima_fs.c 687 688 int __init ima_fs_init(void) 689 { 690 int ret; 691 692 ima_dir = securityfs_create_dir("ima", integrity_dir); 693 if (IS_ERR(ima_dir)) 694 return PTR_ERR(ima_dir); 695 696 ima_symlink = securityfs_create_symlink("ima", NULL, "integrity/ima", 697 NULL); 698 if (IS_ERR(ima_symlink)) { 699 ret = PTR_ERR(ima_symlink); 700 goto out; 701 } 702 703 binary_runtime_measurements = 704 securityfs_create_file("binary_runtime_measurements", 705 S_IRUSR | S_IRGRP, ima_dir, NULL, 706 &ima_measurements_ops); 707 if (IS_ERR(binary_runtime_measurements)) { 708 ret = PTR_ERR(binary_runtime_measurements); 709 goto out; 710 } 711 712 ascii_runtime_measurements = 713 securityfs_create_file("ascii_runtime_measurements", 714 S_IRUSR | S_IRGRP, ima_dir, NULL, 715 &ima_ascii_measurements_ops); 716 if (IS_ERR(ascii_runtime_measurements)) { 717 ret = PTR_ERR(ascii_runtime_measurements); 718 goto out; 719 } 720 721 runtime_measurements_count = 722 securityfs_create_file("runtime_measurements_count", 723 S_IRUSR | S_IRGRP, ima_dir, NULL, 724 #ifdef CONFIG_IMA_DIGEST_LIST 725 &ima_htable_value_ops); 726 #else 727 &ima_measurements_count_ops); 728 #endif 729 if (IS_ERR(runtime_measurements_count)) { 730 ret = PTR_ERR(runtime_measurements_count); 731 goto out; 732 } 733 734 violations = 735 securityfs_create_file("violations", S_IRUSR | S_IRGRP, 736 #ifdef CONFIG_IMA_DIGEST_LIST 737 ima_dir, NULL, &ima_htable_value_ops); 738 #else 739 ima_dir, NULL, &ima_htable_violations_ops); 740 #endif 741 if (IS_ERR(violations)) { 742 ret = PTR_ERR(violations); 743 goto out; 744 } 745 746 ima_policy = securityfs_create_file("policy", POLICY_FILE_FLAGS, 747 ima_dir, NULL, 748 #ifdef CONFIG_IMA_DIGEST_LIST 749 &ima_data_upload_ops); 750 #else 751 &ima_measure_policy_ops); 752 #endif 753 if (IS_ERR(ima_policy)) { 754 ret = PTR_ERR(ima_policy); 755 goto out; 756 } 757 #ifdef CONFIG_IMA_DIGEST_LIST 758 digests_count = securityfs_create_file("digests_count", 759 S_IRUSR | S_IRGRP, ima_dir, 760 NULL, &ima_htable_value_ops); 761 if (IS_ERR(digests_count)) 762 goto out; 763 764 digest_list_data = securityfs_create_file("digest_list_data", S_IWUSR, 765 ima_dir, NULL, 766 &ima_data_upload_ops); 767 if (IS_ERR(digest_list_data)) 768 goto out; 769 770 digest_list_data_del = securityfs_create_file("digest_list_data_del", 771 S_IWUSR, ima_dir, NULL, 772 &ima_data_upload_ops); > 773 if (IS_ERR(digest_list_data_del)) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 19387/30000] drivers/vdpa/vdpa_sim/vdpa_sim_net.c:36:4: sparse: sparse: symbol 'macaddr_buf' was not declared. Should it be static?
by kernel test robot 24 Feb '24

24 Feb '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 4fee6fdef7d687d6ce43289fd7e7f96fde039af0 commit: d4a6c405d07d2c7eb60a781368d94c476ebe24ab [19387/30000] vdpa: split vdpasim to core and net modules config: x86_64-randconfig-122-20240224 (https://download.01.org/0day-ci/archive/20240224/202402241904.fKVDwGyh-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240224/202402241904.fKVDwGyh-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402241904.fKVDwGyh-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/vdpa/vdpa_sim/vdpa_sim_net.c:36:4: sparse: sparse: symbol 'macaddr_buf' was not declared. Should it be static? vim +/macaddr_buf +36 drivers/vdpa/vdpa_sim/vdpa_sim_net.c 35 > 36 u8 macaddr_buf[ETH_ALEN]; 37 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-5.10 19778/30000] drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:113:5: sparse: sparse: symbol 'ngbe_poll_for_msg' was not declared. Should it be static?
by kernel test robot 24 Feb '24

24 Feb '24

tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 4fee6fdef7d687d6ce43289fd7e7f96fde039af0 commit: a5961b4bc6ce09a70902686ecc848a47493a9251 [19778/30000] openeuler: net: ngbe: add ngbe module support config: x86_64-randconfig-122-20240218 (https://download.01.org/0day-ci/archive/20240224/202402241626.MnVH3cCn-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240224/202402241626.MnVH3cCn-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402241626.MnVH3cCn-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:113:5: sparse: sparse: symbol 'ngbe_poll_for_msg' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:143:5: sparse: sparse: symbol 'ngbe_poll_for_ack' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:244:5: sparse: sparse: symbol 'ngbe_read_v2p_mailbox' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:262:5: sparse: sparse: symbol 'ngbe_check_for_bit_vf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:278:5: sparse: sparse: symbol 'ngbe_check_for_msg_vf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:298:5: sparse: sparse: symbol 'ngbe_check_for_ack_vf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:318:5: sparse: sparse: symbol 'ngbe_check_for_rst_vf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:337:5: sparse: sparse: symbol 'ngbe_obtain_mbx_lock_vf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:365:5: sparse: sparse: symbol 'ngbe_write_mbx_vf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:403:5: sparse: sparse: symbol 'ngbe_read_mbx_vf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:461:5: sparse: sparse: symbol 'ngbe_check_for_bit_pf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:481:5: sparse: sparse: symbol 'ngbe_check_for_msg_pf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:501:5: sparse: sparse: symbol 'ngbe_check_for_ack_pf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:521:5: sparse: sparse: symbol 'ngbe_check_for_rst_pf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:544:5: sparse: sparse: symbol 'ngbe_obtain_mbx_lock_pf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:572:5: sparse: sparse: symbol 'ngbe_write_mbx_pf' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c:612:5: sparse: sparse: symbol 'ngbe_read_mbx_pf' was not declared. Should it be static? -- >> drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:818:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:818:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:818:17: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:1268:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:1268:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:1268:17: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:1297:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:1297:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:1297:9: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:474:25: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:474:25: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:474:25: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:474:25: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:474:25: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_sriov.c:474:25: sparse: int -- >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:16:6: sparse: sparse: symbol 'ngbe_check_reset_blocked' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:33:5: sparse: sparse: symbol 'ngbe_phy_read_reg' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:56:5: sparse: sparse: symbol 'ngbe_phy_write_reg' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:74:5: sparse: sparse: symbol 'ngbe_check_internal_phy_id' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:273:5: sparse: sparse: symbol 'ngbe_check_mdi_phy_id' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:337:6: sparse: sparse: symbol 'ngbe_validate_phy_addr' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:353:5: sparse: sparse: symbol 'ngbe_check_yt_phy_id' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:1242:5: sparse: sparse: symbol 'ngbe_phy_get_advertised_pause' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:1279:5: sparse: sparse: symbol 'ngbe_phy_get_lp_advertised_pause' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:1324:5: sparse: sparse: symbol 'ngbe_phy_set_pause_advertisement' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_phy.c:1450:5: sparse: sparse: symbol 'ngbe_phy_setup' was not declared. Should it be static? -- >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:399:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:399:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:399:9: sparse: int >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:752:6: sparse: sparse: symbol 'ngbe_add_uc_addr' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:885:6: sparse: sparse: symbol 'ngbe_set_mta' was not declared. Should it be static? drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:1937:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:1937:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:1937:9: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:2082:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:2082:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:2082:9: sparse: int >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:2186:5: sparse: sparse: symbol 'ngbe_setup_mac_link_hostif' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:2222:5: sparse: sparse: symbol 'ngbe_crc16_ccitt' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:2897:23: sparse: sparse: symbol 'ngbe_ptype_lookup' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3296:5: sparse: sparse: symbol 'ngbe_get_copper_link_capabilities' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3456:5: sparse: sparse: symbol 'ngbe_reset_misc' was not declared. Should it be static? drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3751:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3751:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3751:17: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3753:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3753:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3753:17: sparse: int >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3910:5: sparse: sparse: symbol 'ngbe_read_ee_hostif_data' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:3981:5: sparse: sparse: symbol 'ngbe_phy_led_oem_chk' was not declared. Should it be static? drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4066:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4066:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4066:17: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4148:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4148:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4148:9: sparse: int >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4163:5: sparse: sparse: symbol 'ngbe_read_ee_hostif_data32' was not declared. Should it be static? drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4208:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4208:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4208:17: sparse: int >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4225:5: sparse: sparse: symbol 'ngbe_write_ee_hostif_data' was not declared. Should it be static? drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4264:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4264:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4264:17: sparse: int >> drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4282:5: sparse: sparse: symbol 'ngbe_write_ee_hostif_data32' was not declared. Should it be static? drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4320:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4320:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4320:17: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4365:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4365:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_hw.c:4365:9: sparse: int -- >> drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:128:5: sparse: sparse: symbol 'ngbe_get_link_ksettings' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1548:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1548:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1548:9: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1570:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1570:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1570:9: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1607:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1607:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1607:9: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1611:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1611:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_ethtool.c:1611:9: sparse: int -- >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:139:6: sparse: sparse: symbol 'ngbe_service_event_schedule' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:888:57: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __be16 [usertype] vlan_proto @@ got unsigned short [usertype] @@ drivers/net/ethernet/netswift/ngbe/ngbe_main.c:888:57: sparse: expected restricted __be16 [usertype] vlan_proto drivers/net/ethernet/netswift/ngbe/ngbe_main.c:888:57: sparse: got unsigned short [usertype] >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:2458:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_main.c:2458:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_main.c:2458:17: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_main.c:2507:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_main.c:2507:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_main.c:2507:9: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3155:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3155:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3155:9: sparse: int >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3159:6: sparse: sparse: symbol 'ngbe_configure_isb' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3173:6: sparse: sparse: symbol 'ngbe_configure_port' was not declared. Should it be static? drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3541:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3541:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3541:9: sparse: int >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3644:5: sparse: sparse: symbol 'ngbe_init_shared_code' was not declared. Should it be static? drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3751:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3751:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_main.c:3751:9: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_main.c:4298:17: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_main.c:4298:17: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_main.c:4298:17: sparse: int >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5193:40: sparse: sparse: restricted __be16 degrades to integer drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5219:37: sparse: sparse: restricted __be16 degrades to integer drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5242:40: sparse: sparse: restricted __be16 degrades to integer >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5791:5: sparse: sparse: symbol 'ngbe_skb_pad_nonzero' was not declared. Should it be static? >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5833:30: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned short [usertype] protocol @@ got restricted __be16 [usertype] protocol @@ drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5833:30: sparse: expected unsigned short [usertype] protocol drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5833:30: sparse: got restricted __be16 [usertype] protocol >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5870:26: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] protocol @@ got restricted __be16 [usertype] h_vlan_encapsulated_proto @@ drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5870:26: sparse: expected unsigned short [usertype] protocol drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5870:26: sparse: got restricted __be16 [usertype] h_vlan_encapsulated_proto >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:5871:29: sparse: sparse: cast from restricted __be16 >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6192:26: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned short [usertype] type @@ got restricted __be16 [usertype] protocol @@ drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6192:26: sparse: expected unsigned short [usertype] type drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6192:26: sparse: got restricted __be16 [usertype] protocol >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6206:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] type @@ got restricted __be16 [usertype] h_vlan_encapsulated_proto @@ drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6206:22: sparse: expected unsigned short [usertype] type drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6206:22: sparse: got restricted __be16 [usertype] h_vlan_encapsulated_proto >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6232:35: sparse: sparse: incorrect type in initializer (incompatible argument 2 (different base types)) @@ expected int ( *ndo_vlan_rx_add_vid )( ... ) @@ got int ( * )( ... ) @@ drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6232:35: sparse: expected int ( *ndo_vlan_rx_add_vid )( ... ) drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6232:35: sparse: got int ( * )( ... ) >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6233:35: sparse: sparse: incorrect type in initializer (incompatible argument 2 (different base types)) @@ expected int ( *ndo_vlan_rx_kill_vid )( ... ) @@ got int ( * )( ... ) @@ drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6233:35: sparse: expected int ( *ndo_vlan_rx_kill_vid )( ... ) drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6233:35: sparse: got int ( * )( ... ) >> drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6237:35: sparse: sparse: incorrect type in initializer (incompatible argument 5 (different base types)) @@ expected int ( *ndo_set_vf_vlan )( ... ) @@ got int ( * )( ... ) @@ drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6237:35: sparse: expected int ( *ndo_set_vf_vlan )( ... ) drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6237:35: sparse: got int ( * )( ... ) drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6400:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6400:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6400:9: sparse: int drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6490:9: sparse: sparse: incompatible types in conditional expression (different base types): drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6490:9: sparse: void drivers/net/ethernet/netswift/ngbe/ngbe_main.c:6490:9: sparse: int vim +/ngbe_poll_for_msg +113 drivers/net/ethernet/netswift/ngbe/ngbe_mbx.c 105 106 /** 107 * ngbe_poll_for_msg - Wait for message notification 108 * @hw: pointer to the HW structure 109 * @mbx_id: id of mailbox to write 110 * 111 * returns SUCCESS if it successfully received a message notification 112 **/ > 113 int ngbe_poll_for_msg(struct ngbe_hw *hw, u16 mbx_id) 114 { 115 struct ngbe_mbx_info *mbx = &hw->mbx; 116 int countdown = mbx->timeout; 117 118 if (!countdown || !mbx->ops.check_for_msg) 119 goto out; 120 121 while (countdown && TCALL(hw, mbx.ops.check_for_msg, mbx_id)) { 122 countdown--; 123 if (!countdown) 124 break; 125 udelay(mbx->udelay); 126 } 127 128 if (countdown == 0) 129 ERROR_REPORT2(NGBE_ERROR_POLLING, 130 "Polling for VF%d mailbox message timedout", mbx_id); 131 132 out: 133 return countdown ? 0 : NGBE_ERR_MBX; 134 } 135 136 /** 137 * ngbe_poll_for_ack - Wait for message acknowledngbeent 138 * @hw: pointer to the HW structure 139 * @mbx_id: id of mailbox to write 140 * 141 * returns SUCCESS if it successfully received a message acknowledngbeent 142 **/ > 143 int ngbe_poll_for_ack(struct ngbe_hw *hw, u16 mbx_id) 144 { 145 struct ngbe_mbx_info *mbx = &hw->mbx; 146 int countdown = mbx->timeout; 147 148 if (!countdown || !mbx->ops.check_for_ack) 149 goto out; 150 151 while (countdown && TCALL(hw, mbx.ops.check_for_ack, mbx_id)) { 152 countdown--; 153 if (!countdown) 154 break; 155 udelay(mbx->udelay); 156 } 157 158 if (countdown == 0) 159 ERROR_REPORT2(NGBE_ERROR_POLLING, 160 "Polling for VF%d mailbox ack timedout", mbx_id); 161 162 out: 163 return countdown ? 0 : NGBE_ERR_MBX; 164 } 165 166 /** 167 * ngbe_read_posted_mbx - Wait for message notification and receive message 168 * @hw: pointer to the HW structure 169 * @msg: The message buffer 170 * @size: Length of buffer 171 * @mbx_id: id of mailbox to write 172 * 173 * returns SUCCESS if it successfully received a message notification and 174 * copied it into the receive buffer. 175 **/ 176 int ngbe_read_posted_mbx(struct ngbe_hw *hw, u32 *msg, u16 size, u16 mbx_id) 177 { 178 struct ngbe_mbx_info *mbx = &hw->mbx; 179 int err = NGBE_ERR_MBX; 180 181 if (!mbx->ops.read) 182 goto out; 183 184 err = ngbe_poll_for_msg(hw, mbx_id); 185 186 /* if ack received read message, otherwise we timed out */ 187 if (!err) 188 err = TCALL(hw, mbx.ops.read, msg, size, mbx_id); 189 out: 190 return err; 191 } 192 193 /** 194 * ngbe_write_posted_mbx - Write a message to the mailbox, wait for ack 195 * @hw: pointer to the HW structure 196 * @msg: The message buffer 197 * @size: Length of buffer 198 * @mbx_id: id of mailbox to write 199 * 200 * returns SUCCESS if it successfully copied message into the buffer and 201 * received an ack to that message within delay * timeout period 202 **/ 203 int ngbe_write_posted_mbx(struct ngbe_hw *hw, u32 *msg, u16 size, 204 u16 mbx_id) 205 { 206 struct ngbe_mbx_info *mbx = &hw->mbx; 207 int err; 208 209 /* exit if either we can't write or there isn't a defined timeout */ 210 if (!mbx->timeout) 211 return NGBE_ERR_MBX; 212 213 /* send msg */ 214 err = TCALL(hw, mbx.ops.write, msg, size, mbx_id); 215 216 /* if msg sent wait until we receive an ack */ 217 if (!err) 218 err = ngbe_poll_for_ack(hw, mbx_id); 219 220 return err; 221 } 222 223 /** 224 * ngbe_init_mbx_ops - Initialize MB function pointers 225 * @hw: pointer to the HW structure 226 * 227 * Setups up the mailbox read and write message function pointers 228 **/ 229 void ngbe_init_mbx_ops(struct ngbe_hw *hw) 230 { 231 struct ngbe_mbx_info *mbx = &hw->mbx; 232 233 mbx->ops.read_posted = ngbe_read_posted_mbx; 234 mbx->ops.write_posted = ngbe_write_posted_mbx; 235 } 236 237 /** 238 * ngbe_read_v2p_mailbox - read v2p mailbox 239 * @hw: pointer to the HW structure 240 * 241 * This function is used to read the v2p mailbox without losing the read to 242 * clear status bits. 243 **/ > 244 u32 ngbe_read_v2p_mailbox(struct ngbe_hw *hw) 245 { 246 u32 v2p_mailbox = rd32(hw, NGBE_VXMAILBOX); 247 248 v2p_mailbox |= hw->mbx.v2p_mailbox; 249 hw->mbx.v2p_mailbox |= v2p_mailbox & NGBE_VXMAILBOX_R2C_BITS; 250 251 return v2p_mailbox; 252 } 253 254 /** 255 * ngbe_check_for_bit_vf - Determine if a status bit was set 256 * @hw: pointer to the HW structure 257 * @mask: bitmask for bits to be tested and cleared 258 * 259 * This function is used to check for the read to clear bits within 260 * the V2P mailbox. 261 **/ > 262 int ngbe_check_for_bit_vf(struct ngbe_hw *hw, u32 mask) 263 { 264 u32 mailbox = ngbe_read_v2p_mailbox(hw); 265 266 hw->mbx.v2p_mailbox &= ~mask; 267 268 return (mailbox & mask ? 0 : NGBE_ERR_MBX); 269 } 270 271 /** 272 * ngbe_check_for_msg_vf - checks to see if the PF has sent mail 273 * @hw: pointer to the HW structure 274 * @mbx_id: id of mailbox to check 275 * 276 * returns SUCCESS if the PF has set the Status bit or else ERR_MBX 277 **/ > 278 int ngbe_check_for_msg_vf(struct ngbe_hw *hw, u16 __always_unused mbx_id) 279 { 280 int err = NGBE_ERR_MBX; 281 282 /* read clear the pf sts bit */ 283 if (!ngbe_check_for_bit_vf(hw, NGBE_VXMAILBOX_PFSTS)) { 284 err = 0; 285 hw->mbx.stats.reqs++; 286 } 287 288 return err; 289 } 290 291 /** 292 * ngbe_check_for_ack_vf - checks to see if the PF has ACK'd 293 * @hw: pointer to the HW structure 294 * @mbx_id: id of mailbox to check 295 * 296 * returns SUCCESS if the PF has set the ACK bit or else ERR_MBX 297 **/ > 298 int ngbe_check_for_ack_vf(struct ngbe_hw *hw, u16 __always_unused mbx_id) 299 { 300 int err = NGBE_ERR_MBX; 301 302 /* read clear the pf ack bit */ 303 if (!ngbe_check_for_bit_vf(hw, NGBE_VXMAILBOX_PFACK)) { 304 err = 0; 305 hw->mbx.stats.acks++; 306 } 307 308 return err; 309 } 310 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:OLK-6.6 3159/3388] arch/arm64/include/asm/kvm_mmu.h:221:undefined reference to `__kvm_nvhe_kvm_ncsnp_support'
by kernel test robot 24 Feb '24

24 Feb '24

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 0e6ac87df9e5122747ac5d9e7da9a45555f16374 commit: 625086f87673687dc420e79c9fedff0c2d65cb49 [3159/3388] KVM: arm64: Add support for probing Hisi ncsnp capability config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240224/202402241512.XOiHdLOg-lkp@…) compiler: aarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240224/202402241512.XOiHdLOg-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402241512.XOiHdLOg-lkp@intel.com/ All errors (new ones prefixed by >>): aarch64-linux-ld: arch/arm64/kvm/hyp/nvhe/kvm_nvhe.o: in function `__clean_dcache_guest_page': >> arch/arm64/include/asm/kvm_mmu.h:221:(.hyp.text+0x6898): undefined reference to `__kvm_nvhe_kvm_ncsnp_support' aarch64-linux-ld: arch/arm64/kvm/hyp/nvhe/kvm_nvhe.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `__kvm_nvhe_kvm_ncsnp_support' which may bind externally can not be used when making a shared object; recompile with -fPIC >> arch/arm64/include/asm/kvm_mmu.h:221:(.hyp.text+0x6898): dangerous relocation: unsupported relocation >> aarch64-linux-ld: arch/arm64/include/asm/kvm_mmu.h:221:(.hyp.text+0x689c): undefined reference to `__kvm_nvhe_kvm_ncsnp_support' aarch64-linux-ld: arch/arm64/kvm/hyp/nvhe/kvm_nvhe.o: in function `kvm_pgtable_stage2_flush': >> arch/arm64/kvm/hyp/nvhe/../pgtable.c:1345:(.hyp.text+0x10554): undefined reference to `__kvm_nvhe_kvm_ncsnp_support' aarch64-linux-ld: arch/arm64/kvm/hyp/nvhe/kvm_nvhe.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `__kvm_nvhe_kvm_ncsnp_support' which may bind externally can not be used when making a shared object; recompile with -fPIC >> arch/arm64/kvm/hyp/nvhe/../pgtable.c:1345:(.hyp.text+0x10554): dangerous relocation: unsupported relocation >> aarch64-linux-ld: arch/arm64/kvm/hyp/nvhe/../pgtable.c:1345:(.hyp.text+0x1056c): undefined reference to `__kvm_nvhe_kvm_ncsnp_support' vim +221 arch/arm64/include/asm/kvm_mmu.h 212 213 static inline void __clean_dcache_guest_page(void *va, size_t size) 214 { 215 /* 216 * With FWB, we ensure that the guest always accesses memory using 217 * cacheable attributes, and we don't have to clean to PoC when 218 * faulting in pages. Furthermore, FWB implies IDC, so cleaning to 219 * PoU is not required either in this case. 220 */ > 221 if (kvm_ncsnp_support || cpus_have_const_cap(ARM64_HAS_STAGE2_FWB)) 222 return; 223 224 kvm_flush_dcache_to_poc(va, size); 225 } 226 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0