- Kernel - mailweb.openeuler.org

[PATCH OLK-6.6] NFS: Shut down the nfs_client only after all the superblocks
by Wang Zhaolong 25 Apr '25

25 Apr '25

From: Trond Myklebust <trond.myklebust(a)hammerspace.com> mainline inclusion from mainline-v6.15-rc1 commit 2d3e998a0bc7fe26a724f87a8ce217848040520e category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IC40FO CVE: NA Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… -------------------------------- The nfs_client manages state for all the superblocks in the "cl_superblocks" list, so it must not be shut down until all of them are gone. Fixes: 7d3e26a054c8 ("NFS: Cancel all existing RPC tasks when shutdown") Reviewed-by: Benjamin Coddington <bcodding(a)redhat.com> Signed-off-by: Trond Myklebust <trond.myklebust(a)hammerspace.com> Signed-off-by: Wang Zhaolong <wangzhaolong1(a)huawei.com> --- fs/nfs/sysfs.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/fs/nfs/sysfs.c b/fs/nfs/sysfs.c index 7b59a40d40c0..784f7c1d003b 100644 --- a/fs/nfs/sysfs.c +++ b/fs/nfs/sysfs.c @@ -12,10 +12,11 @@ #include <linux/string.h> #include <linux/nfs_fs.h> #include <linux/rcupdate.h> #include <linux/lockd/lockd.h> +#include "internal.h" #include "nfs4_fs.h" #include "netns.h" #include "sysfs.h" static struct kset *nfs_kset; @@ -226,10 +227,29 @@ static void shutdown_client(struct rpc_clnt *clnt) { clnt->cl_shutdown = 1; rpc_cancel_tasks(clnt, -EIO, shutdown_match_client, NULL); } +/* + * Shut down the nfs_client only once all the superblocks + * have been shut down. + */ +static void shutdown_nfs_client(struct nfs_client *clp) +{ + struct nfs_server *server; + rcu_read_lock(); + list_for_each_entry_rcu(server, &clp->cl_superblocks, client_link) { + if (!(server->flags & NFS_MOUNT_SHUTDOWN)) { + rcu_read_unlock(); + return; + } + } + rcu_read_unlock(); + nfs_mark_client_ready(clp, -EIO); + shutdown_client(clp->cl_rpcclient); +} + static ssize_t shutdown_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { struct nfs_server *server = container_of(kobj, struct nfs_server, kobj); @@ -257,18 +277,18 @@ shutdown_store(struct kobject *kobj, struct kobj_attribute *attr, if (server->flags & NFS_MOUNT_SHUTDOWN) goto out; server->flags |= NFS_MOUNT_SHUTDOWN; shutdown_client(server->client); - shutdown_client(server->nfs_client->cl_rpcclient); if (!IS_ERR(server->client_acl)) shutdown_client(server->client_acl); if (server->nlm_host) shutdown_client(server->nlm_host->h_rpcclnt); out: + shutdown_nfs_client(server->nfs_client); return count; } static struct kobj_attribute nfs_sysfs_attr_shutdown = __ATTR_RW(shutdown); -- 2.34.3

2 1

[openeuler:openEuler-1.0-LTS] BUILD REGRESSION 08111f03f1ec65598372cfe9bf64f366d575671e
by kernel test robot 25 Apr '25

25 Apr '25

tree/branch: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS branch HEAD: 08111f03f1ec65598372cfe9bf64f366d575671e !15984 vlan: enforce underlying device type Error/Warning (recently discovered and may have been fixed): https://lore.kernel.org/oe-kbuild-all/202503271858.j6vJ9Bhc-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202504180904.aJTbSHsO-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202504241725.jmSsMrko-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202504241856.ApFHkRye-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202504250048.uf9ktecm-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202504250657.SBZLGq3K-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202504250827.FCNrED1Z-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202504250942.HWyvS6HD-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202504251109.LNg7C0pb-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202504251357.XH0GnYXx-lkp@intel.com arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x162: unsupported intra-function call arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x191: unsupported intra-function call arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x1b2: unsupported intra-function call arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x1c2: unsupported intra-function call arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x1d2: unsupported intra-function call arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x1e2: unsupported intra-function call arch/x86/entry/entry_64.o: warning: objtool: If this is a retpoline, please patch it in with alternatives and annotate it with ANNOTATE_NOSPEC_ALTERNATIVE. block/bio-integrity.c:41:6: warning: no previous prototype for '__bio_integrity_free' [-Wmissing-prototypes] block/blk-merge.c:688:16: warning: no previous prototype for 'blk_try_req_merge' [-Wmissing-prototypes] block/blk-merge.c:696:16: warning: no previous prototype for 'blk_try_req_merge' [-Wmissing-prototypes] block/blk-mq-sched.c:219:5: warning: no previous prototype for '__blk_mq_sched_dispatch_requests' [-Wmissing-prototypes] block/blk-mq-sched.c:220:5: warning: no previous prototype for '__blk_mq_sched_dispatch_requests' [-Wmissing-prototypes] block/genhd.c:525: warning: Function parameter or member 'devt' not described in 'blk_invalidate_devt' block/genhd.c:533: warning: Function parameter or member 'devt' not described in 'blk_invalidate_devt' block/genhd.c:642:5: warning: no previous prototype for 'disk_scan_partitions' [-Wmissing-prototypes] drivers/gpu/drm/ttm/ttm_object.c:60: error: Cannot parse struct or union! drivers/pinctrl/core.c:1338: error: Cannot parse struct or union! fs/nfs/nfs4proc.o: warning: objtool: update_open_stateid()+0x88b: can't find switch jump table kernel/hung_task.c:148:7: error: use of undeclared identifier 'sysctl_hung_task_all_cpu_backtrace' ld.lld: error: undefined symbol: init_net mm/kasan/kasan.o: warning: objtool: missing symbol for section .text mm/mem_reliable.c:41:22: warning: 'zero' defined but not used [-Wunused-variable] mm/memcontrol.o: warning: objtool: missing symbol for section .text.unlikely mm/mmu_gather.o: warning: objtool: missing symbol for section .text mm/sparse.o: warning: objtool: missing symbol for section .meminit.text sas_expander.c:(.text.unlikely+0x38c): undefined reference to `ata_dev_same_device' Unverified Error/Warning (likely false positive, kindly check if interested): ./samples/mic/mpssd/mpssd.c: 40 linux/version.h not needed. drivers/base/regmap/regmap.o: warning: objtool: regmap_raw_read() falls through to next function _regmap_raw_read() drivers/net/ethernet/intel/e1000/e1000_main.o: warning: objtool: e1000_watchdog() falls through to next function e1000_82547_tx_fifo_stall_task() mm/kasan/kasan_init.c:220: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_zero_shadow' mm/kasan/kasan_init.c:220: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_zero_shadow' Error/Warning ids grouped by kconfigs: recent_errors |-- arm64-allmodconfig | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | `-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow |-- arm64-defconfig | |-- block-bio-integrity.c:warning:no-previous-prototype-for-__bio_integrity_free | |-- block-blk-merge.c:warning:no-previous-prototype-for-blk_try_req_merge | |-- block-blk-mq-sched.c:warning:no-previous-prototype-for-__blk_mq_sched_dispatch_requests | |-- block-genhd.c:warning:Function-parameter-or-member-devt-not-described-in-blk_invalidate_devt | `-- block-genhd.c:warning:no-previous-prototype-for-disk_scan_partitions |-- arm64-randconfig-001-20250424 | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | `-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union |-- arm64-randconfig-002-20250424 | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | `-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union |-- arm64-randconfig-003-20250424 | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow | `-- mm-mem_reliable.c:warning:zero-defined-but-not-used |-- arm64-randconfig-004-20250424 | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | `-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union |-- x86_64-allnoconfig | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | |-- mm-mmu_gather.o:warning:objtool:missing-symbol-for-section-.text | |-- mm-vmscan.c:error:implicit-declaration-of-function-kernel_swap_enabled-Werror-Wimplicit-function-declaration | `-- samples-mic-mpssd-mpssd.c:linux-version.h-not-needed. |-- x86_64-allyesconfig | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | `-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow |-- x86_64-buildonly-randconfig-001-20250424 | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | `-- arch-x86-entry-entry_64.o:warning:objtool:If-this-is-a-retpoline-please-patch-it-in-with-alternatives-and-annotate-it-with-ANNOTATE_NOSPEC_ALTERNATIVE. |-- x86_64-buildonly-randconfig-002-20250424 | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- ld.lld:error:undefined-symbol:init_net | |-- mm-hugetlb.c:warning:no-previous-prototype-for-function-free_huge_page_to_dhugetlb_pool | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | `-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow |-- x86_64-buildonly-randconfig-003-20250424 | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | |-- arch-x86-entry-entry_64.o:warning:objtool:If-this-is-a-retpoline-please-patch-it-in-with-alternatives-and-annotate-it-with-ANNOTATE_NOSPEC_ALTERNATIVE. | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- mm-memcontrol.o:warning:objtool:missing-symbol-for-section-.text.unlikely | `-- sas_expander.c:(.text.unlikely):undefined-reference-to-ata_dev_same_device |-- x86_64-buildonly-randconfig-004-20250424 | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | |-- arch-x86-entry-entry_64.o:warning:objtool:If-this-is-a-retpoline-please-patch-it-in-with-alternatives-and-annotate-it-with-ANNOTATE_NOSPEC_ALTERNATIVE. | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | `-- mm-hugetlb.c:warning:no-previous-prototype-for-function-free_huge_page_to_dhugetlb_pool |-- x86_64-buildonly-randconfig-005-20250424 | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | |-- arch-x86-entry-entry_64.o:warning:objtool:If-this-is-a-retpoline-please-patch-it-in-with-alternatives-and-annotate-it-with-ANNOTATE_NOSPEC_ALTERNATIVE. | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow | `-- mm-vmscan.c:error:implicit-declaration-of-function-kernel_swap_enabled-Werror-Wimplicit-function-declaration |-- x86_64-buildonly-randconfig-006-20250424 | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | |-- arch-x86-entry-entry_64.o:warning:objtool:If-this-is-a-retpoline-please-patch-it-in-with-alternatives-and-annotate-it-with-ANNOTATE_NOSPEC_ALTERNATIVE. | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- mm-kasan-kasan.o:warning:objtool:missing-symbol-for-section-.text | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow | `-- mm-sparse.o:warning:objtool:missing-symbol-for-section-.meminit.text |-- x86_64-defconfig | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | `-- arch-x86-entry-entry_64.o:warning:objtool:If-this-is-a-retpoline-please-patch-it-in-with-alternatives-and-annotate-it-with-ANNOTATE_NOSPEC_ALTERNATIVE. |-- x86_64-randconfig-101-20250425 | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | `-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow |-- x86_64-randconfig-102-20250425 | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | |-- block-bio-integrity.c:warning:no-previous-prototype-for-__bio_integrity_free | |-- block-blk-merge.c:warning:no-previous-prototype-for-blk_try_req_merge | |-- block-blk-mq-sched.c:warning:no-previous-prototype-for-__blk_mq_sched_dispatch_requests | |-- block-genhd.c:warning:Function-parameter-or-member-devt-not-described-in-blk_invalidate_devt | |-- block-genhd.c:warning:no-previous-prototype-for-disk_scan_partitions | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | `-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow |-- x86_64-randconfig-103-20250425 | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | |-- block-blk-throttle.c:preceding-lock-on-line | |-- block-genhd.c:warning:Function-parameter-or-member-devt-not-described-in-blk_invalidate_devt | |-- drivers-base-regmap-regmap.o:warning:objtool:regmap_raw_read-falls-through-to-next-function-_regmap_raw_read() | |-- drivers-net-ethernet-intel-e1000-e1000_main.o:warning:objtool:e1000_watchdog-falls-through-to-next-function-e1000_82547_tx_fifo_stall_task() | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- fs-ext4-mballoc.o:warning:objtool:ext4_mb_complex_scan_group:unreachable-instruction | |-- fs-nfs-nfs4proc.o:warning:objtool:update_open_stateid:can-t-find-switch-jump-table | |-- kernel-hung_task.c:error:use-of-undeclared-identifier-sysctl_hung_task_all_cpu_backtrace | |-- mm-hugetlb.c:warning:no-previous-prototype-for-function-free_huge_page_to_dhugetlb_pool | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow | `-- mm-vmscan.o:warning:objtool:shrink_node:can-t-find-switch-jump-table |-- x86_64-randconfig-104-20250425 | |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call | |-- block-bio-integrity.c:warning:no-previous-prototype-for-__bio_integrity_free | |-- block-blk-merge.c:warning:no-previous-prototype-for-blk_try_req_merge | |-- block-blk-mq-sched.c:warning:no-previous-prototype-for-__blk_mq_sched_dispatch_requests | |-- block-genhd.c:warning:Function-parameter-or-member-devt-not-described-in-blk_invalidate_devt | |-- block-genhd.c:warning:no-previous-prototype-for-disk_scan_partitions | |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union | |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union | |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow | `-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow `-- x86_64-randconfig-161-20250425 |-- arch-x86-entry-entry_64.o:warning:objtool:.entry.text:unsupported-intra-function-call |-- arch-x86-entry-entry_64.o:warning:objtool:If-this-is-a-retpoline-please-patch-it-in-with-alternatives-and-annotate-it-with-ANNOTATE_NOSPEC_ALTERNATIVE. |-- drivers-gpu-drm-ttm-ttm_object.c:error:Cannot-parse-struct-or-union |-- drivers-pinctrl-core.c:error:Cannot-parse-struct-or-union |-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_end-not-described-in-kasan_populate_zero_shadow `-- mm-kasan-kasan_init.c:warning:Function-parameter-or-member-shadow_start-not-described-in-kasan_populate_zero_shadow elapsed time: 1457m configs tested: 16 configs skipped: 128 tested configs: arm64 allmodconfig gcc-14.2.0 arm64 allnoconfig gcc-14.2.0 arm64 defconfig gcc-14.2.0 arm64 randconfig-001-20250424 gcc-12.3.0 arm64 randconfig-002-20250424 gcc-8.5.0 arm64 randconfig-003-20250424 gcc-12.3.0 arm64 randconfig-004-20250424 gcc-8.5.0 x86_64 allnoconfig clang-20 x86_64 allyesconfig clang-20 x86_64 buildonly-randconfig-001-20250424 gcc-12 x86_64 buildonly-randconfig-002-20250424 clang-20 x86_64 buildonly-randconfig-003-20250424 gcc-12 x86_64 buildonly-randconfig-004-20250424 clang-20 x86_64 buildonly-randconfig-005-20250424 clang-20 x86_64 buildonly-randconfig-006-20250424 gcc-12 x86_64 defconfig gcc-11 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/7] arm64/mpam: Create l2 cache monitors
by Zeng Heng 25 Apr '25

25 Apr '25

James Morse (2): arm64: mpam: Add cpu_pm notifier to restore MPAM sysregs arm64: mpam: Restore the expected MPAM sysregs on cpuhp Zeng Heng (5): x86/resctrl: Add a handling path of default label in get_arch_mbm_state() arm64/mpam: Create l2 cache monitors fs/resctrl: Add l2 mount option to enable L2 msc arm64/mpam: Refuse cpu offline when L2 msc is enabled arm64/mpam: Refuse to enter powerdown state after L2 msc updated arch/arm64/kernel/cpufeature.c | 6 +++ arch/arm64/kernel/mpam.c | 41 +++++++++++++++ arch/x86/kernel/cpu/resctrl/monitor.c | 2 + drivers/platform/mpam/mpam_devices.c | 6 ++- drivers/platform/mpam/mpam_internal.h | 2 + drivers/platform/mpam/mpam_resctrl.c | 76 ++++++++++++++++++++++++--- fs/proc/base.c | 2 + fs/resctrl/ctrlmondata.c | 6 +++ fs/resctrl/internal.h | 2 +- fs/resctrl/rdtgroup.c | 16 ++++++ include/linux/arm_mpam.h | 2 + include/linux/resctrl.h | 4 ++ include/linux/resctrl_types.h | 15 ++++-- 13 files changed, 169 insertions(+), 11 deletions(-) -- 2.25.1

2 8

[openeuler:openEuler-1.0-LTS 1593/1593] block/blk-mq-sched.c:219:5: warning: no previous prototype for '__blk_mq_sched_dispatch_requests'
by kernel test robot 25 Apr '25

25 Apr '25

Hi Salman, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 08111f03f1ec65598372cfe9bf64f366d575671e commit: c1ea82c0ddde70d5998c2f547520afbee10bea2a [1593/1593] block: Limit number of items taken from the I/O scheduler in one go config: arm64-defconfig (https://download.01.org/0day-ci/archive/20250425/202504251357.XH0GnYXx-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504251357.XH0GnYXx-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202504251357.XH0GnYXx-lkp@intel.com/ All warnings (new ones prefixed by >>): >> block/blk-mq-sched.c:219:5: warning: no previous prototype for '__blk_mq_sched_dispatch_requests' [-Wmissing-prototypes] 219 | int __blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/__blk_mq_sched_dispatch_requests +219 block/blk-mq-sched.c 218 > 219 int __blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx) 220 { 221 struct request_queue *q = hctx->queue; 222 struct elevator_queue *e = q->elevator; 223 const bool has_sched_dispatch = e && e->type->ops.mq.dispatch_request; 224 int ret = 0; 225 LIST_HEAD(rq_list); 226 227 /* 228 * If we have previous entries on our dispatch list, grab them first for 229 * more fair dispatch. 230 */ 231 if (!list_empty_careful(&hctx->dispatch)) { 232 spin_lock(&hctx->lock); 233 if (!list_empty(&hctx->dispatch)) 234 list_splice_init(&hctx->dispatch, &rq_list); 235 spin_unlock(&hctx->lock); 236 } 237 238 /* 239 * Only ask the scheduler for requests, if we didn't have residual 240 * requests from the dispatch list. This is to avoid the case where 241 * we only ever dispatch a fraction of the requests available because 242 * of low device queue depth. Once we pull requests out of the IO 243 * scheduler, we can no longer merge or sort them. So it's best to 244 * leave them there for as long as we can. Mark the hw queue as 245 * needing a restart in that case. 246 * 247 * We want to dispatch from the scheduler if there was nothing 248 * on the dispatch list or we were able to dispatch from the 249 * dispatch list. 250 */ 251 if (!list_empty(&rq_list)) { 252 blk_mq_sched_mark_restart_hctx(hctx); 253 if (blk_mq_dispatch_rq_list(q, &rq_list, false)) { 254 if (has_sched_dispatch) 255 ret = blk_mq_do_dispatch_sched(hctx); 256 else 257 ret = blk_mq_do_dispatch_ctx(hctx); 258 } 259 } else if (has_sched_dispatch) { 260 ret = blk_mq_do_dispatch_sched(hctx); 261 } else if (hctx->dispatch_busy) { 262 /* dequeue request one by one from sw queue if queue is busy */ 263 ret = blk_mq_do_dispatch_ctx(hctx); 264 } else { 265 blk_mq_flush_busy_ctxs(hctx, &rq_list); 266 blk_mq_dispatch_rq_list(q, &rq_list, false); 267 } 268 269 return ret; 270 } 271 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[openeuler:openEuler-1.0-LTS 1593/1593] block/genhd.c:642:5: warning: no previous prototype for 'disk_scan_partitions'
by kernel test robot 25 Apr '25

25 Apr '25

Hi Yu, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 08111f03f1ec65598372cfe9bf64f366d575671e commit: cdfb5c11ad89867cd28c903369fbfebe3f36ca26 [1593/1593] block: fix kabi broken in ioctl.c config: arm64-defconfig (https://download.01.org/0day-ci/archive/20250425/202504251109.LNg7C0pb-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504251109.LNg7C0pb-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202504251109.LNg7C0pb-lkp@intel.com/ All warnings (new ones prefixed by >>): >> block/genhd.c:642:5: warning: no previous prototype for 'disk_scan_partitions' [-Wmissing-prototypes] 642 | int disk_scan_partitions(struct gendisk *disk, fmode_t mode) | ^~~~~~~~~~~~~~~~~~~~ block/genhd.c:533: warning: Function parameter or member 'devt' not described in 'blk_invalidate_devt' vim +/disk_scan_partitions +642 block/genhd.c d2bf1b6723ed0e Tejun Heo 2010-12-08 641 efc73feb2901d2 Christoph Hellwig 2023-04-07 @642 int disk_scan_partitions(struct gendisk *disk, fmode_t mode) b9484a857f600c Yu Kuai 2022-08-09 643 { b9484a857f600c Yu Kuai 2022-08-09 644 struct block_device *bdev; efc73feb2901d2 Christoph Hellwig 2023-04-07 645 int ret; b9484a857f600c Yu Kuai 2022-08-09 646 efc73feb2901d2 Christoph Hellwig 2023-04-07 647 if (!disk_part_scan_enabled(disk)) efc73feb2901d2 Christoph Hellwig 2023-04-07 648 return -EINVAL; b9484a857f600c Yu Kuai 2022-08-09 649 b9484a857f600c Yu Kuai 2022-08-09 650 bdev = bdget_disk(disk, 0); b9484a857f600c Yu Kuai 2022-08-09 651 if (!bdev) efc73feb2901d2 Christoph Hellwig 2023-04-07 652 return -ENOMEM; b9484a857f600c Yu Kuai 2022-08-09 653 b9484a857f600c Yu Kuai 2022-08-09 654 bdev->bd_invalidated = 1; efc73feb2901d2 Christoph Hellwig 2023-04-07 655 efc73feb2901d2 Christoph Hellwig 2023-04-07 656 ret = blkdev_get(bdev, mode, NULL); efc73feb2901d2 Christoph Hellwig 2023-04-07 657 if (!ret) efc73feb2901d2 Christoph Hellwig 2023-04-07 658 blkdev_put(bdev, mode); efc73feb2901d2 Christoph Hellwig 2023-04-07 659 efc73feb2901d2 Christoph Hellwig 2023-04-07 660 return ret; fbbec472351c99 Christoph Hellwig 2023-04-07 661 } fbbec472351c99 Christoph Hellwig 2023-04-07 662 :::::: The code at line 642 was first introduced by commit :::::: efc73feb2901d27dcd01fa859d1378aee42850aa block: merge disk_scan_partitions and blkdev_reread_part :::::: TO: Christoph Hellwig <hch(a)lst.de> :::::: CC: Yongqiang Liu <duanzi(a)zju.edu.cn> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH OLK-6.6 0/2] sched/fair: Prefer physical cores when migrating tasks
by Yu Kuai 25 Apr '25

25 Apr '25

Cheng Yu (2): sched/fair: Prefer physical cores when migrating tasks sched/fair: Optimize the dynamic smt arch/arm64/Kconfig | 1 + arch/arm64/configs/openeuler_defconfig | 1 + include/linux/sched/sysctl.h | 4 +++ init/Kconfig | 19 +++++++++++ kernel/sched/fair.c | 46 ++++++++++++++++++++++++++ kernel/sched/features.h | 4 +++ 6 files changed, 75 insertions(+) -- 2.39.2

2 3

mpam 交流
by openEuler conference 25 Apr '25

25 Apr '25

您好！ Kernel 邀请您参加 2025-04-25 11:00 召开的WeLink会议会议主题：mpam 交流会议链接：https://meeting.huaweicloud.com:36443/#/j/965812711 会议纪要：https://etherpad.openeuler.org/p/Kernel-meetings 更多资讯尽在：https://www.openeuler.org/zh/ Hello! Kernel invites you to attend the WeLink conference will be held at 2025-04-25 11:00, The subject of the conference is mpam 交流 You can join the meeting at https://meeting.huaweicloud.com:36443/#/j/965812711 Add topics at https://etherpad.openeuler.org/p/Kernel-meetings More information: https://www.openeuler.org/en/

1 0

[openeuler:openEuler-1.0-LTS 1593/1593] block/bio-integrity.c:41:6: warning: no previous prototype for '__bio_integrity_free'
by kernel test robot 25 Apr '25

25 Apr '25

Hi Chengguang, FYI, the error/warning still remains. tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS head: 08111f03f1ec65598372cfe9bf64f366d575671e commit: f9c4e7b09f7d51f9256fe51b9c40657cd7302530 [1593/1593] block: release bip in a right way in error path config: arm64-defconfig (https://download.01.org/0day-ci/archive/20250425/202504250942.HWyvS6HD-lkp@…) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504250942.HWyvS6HD-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202504250942.HWyvS6HD-lkp@intel.com/ All warnings (new ones prefixed by >>): >> block/bio-integrity.c:41:6: warning: no previous prototype for '__bio_integrity_free' [-Wmissing-prototypes] 41 | void __bio_integrity_free(struct bio_set *bs, struct bio_integrity_payload *bip) | ^~~~~~~~~~~~~~~~~~~~ vim +/__bio_integrity_free +41 block/bio-integrity.c 40 > 41 void __bio_integrity_free(struct bio_set *bs, struct bio_integrity_payload *bip) 42 { 43 if (bs && mempool_initialized(&bs->bio_integrity_pool)) { 44 if (bip->bip_vec) 45 bvec_free(&bs->bvec_integrity_pool, bip->bip_vec, 46 bip->bip_slab); 47 mempool_free(bip, &bs->bio_integrity_pool); 48 } else { 49 kfree(bip); 50 } 51 } 52 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH openEuler-1.0-LTS] usb: gadget: f_fs: Prevent race during ffs_ep0_queue_wait
by Guo Mengqi 25 Apr '25

25 Apr '25

From: Udipto Goswami <quic_ugoswami(a)quicinc.com> stable inclusion from stable-v4.19.272 commit e9036e951f93fb8d7b5e9d6e2c7f94a4da312ae4 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBWVWG CVE: CVE-2022-49755 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… -------------------------------- [ Upstream commit 6a19da111057f69214b97c62fb0ac59023970850 ] While performing fast composition switch, there is a possibility that the process of ffs_ep0_write/ffs_ep0_read get into a race condition due to ep0req being freed up from functionfs_unbind. Consider the scenario that the ffs_ep0_write calls the ffs_ep0_queue_wait by taking a lock &ffs->ev.waitq.lock. However, the functionfs_unbind isn't bounded so it can go ahead and mark the ep0req to NULL, and since there is no NULL check in ffs_ep0_queue_wait we will end up in use-after-free. Fix this by making a serialized execution between the two functions using a mutex_lock(ffs->mutex). Fixes: ddf8abd25994 ("USB: f_fs: the FunctionFS driver") Signed-off-by: Udipto Goswami <quic_ugoswami(a)quicinc.com> Tested-by: Krishna Kurapati <quic_kriskura(a)quicinc.com> Link: https://lore.kernel.org/r/20221215052906.8993-2-quic_ugoswami@quicinc.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> Signed-off-by: Guo Mengqi <guomengqi3(a)huawei.com> --- drivers/usb/gadget/function/f_fs.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 4ec3f27a0aea..5c1d797b5bcb 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -271,6 +271,9 @@ static int __ffs_ep0_queue_wait(struct ffs_data *ffs, char *data, size_t len) struct usb_request *req = ffs->ep0req; int ret; + if (!req) + return -EINVAL; + req->zero = len < le16_to_cpu(ffs->ev.setup.wLength); spin_unlock_irq(&ffs->ev.waitq.lock); @@ -1807,10 +1810,12 @@ static void functionfs_unbind(struct ffs_data *ffs) ENTER(); if (!WARN_ON(!ffs->gadget)) { + mutex_lock(&ffs->mutex); usb_ep_free_request(ffs->gadget->ep0, ffs->ep0req); ffs->ep0req = NULL; ffs->gadget = NULL; clear_bit(FFS_FL_BOUND, &ffs->flags); + mutex_unlock(&ffs->mutex); ffs_data_put(ffs); } } -- 2.22.0

2 1

[openeuler:OLK-6.6 2167/2167] block/blk-io-hierarchy/iodump.c:561:7: warning: no previous prototype for '__bio_stage_hierarchy_start'
by kernel test robot 25 Apr '25

25 Apr '25

tree: https://gitee.com/openeuler/kernel.git OLK-6.6 head: 2f6f8a0f52903845ede4602b637dd1323aef3592 commit: 67e0c6872f92397d82e9a938623105573f590fc3 [2167/2167] blk-io-hierarchy: support hierarchy stats for bio lifetime config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20250425/202504250828.wJjuSU89-lkp@…) compiler: loongarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504250828.wJjuSU89-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202504250828.wJjuSU89-lkp@intel.com/ All warnings (new ones prefixed by >>): >> block/blk-io-hierarchy/iodump.c:561:7: warning: no previous prototype for '__bio_stage_hierarchy_start' [-Wmissing-prototypes] 561 | void *__bio_stage_hierarchy_start(struct bio_stage_dump_data *bstage_ddata, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/__bio_stage_hierarchy_start +561 block/blk-io-hierarchy/iodump.c 1bf8f90fb90c60 Yu Kuai 2024-11-27 560 1bf8f90fb90c60 Yu Kuai 2024-11-27 @561 void *__bio_stage_hierarchy_start(struct bio_stage_dump_data *bstage_ddata, 1bf8f90fb90c60 Yu Kuai 2024-11-27 562 loff_t *pos) 1bf8f90fb90c60 Yu Kuai 2024-11-27 563 { 1bf8f90fb90c60 Yu Kuai 2024-11-27 564 struct pos_data *pdata = &bstage_ddata->pdata; 1bf8f90fb90c60 Yu Kuai 2024-11-27 565 struct rq_dump_data *rq_ddata = &bstage_ddata->rq_ddata; 1bf8f90fb90c60 Yu Kuai 2024-11-27 566 1bf8f90fb90c60 Yu Kuai 2024-11-27 567 retry: 1bf8f90fb90c60 Yu Kuai 2024-11-27 568 if (stage_is_bio(pdata->stage)) { 1bf8f90fb90c60 Yu Kuai 2024-11-27 569 struct list_head *list; 1bf8f90fb90c60 Yu Kuai 2024-11-27 570 struct bio_dump_data *bio_ddata = 1bf8f90fb90c60 Yu Kuai 2024-11-27 571 get_bio_stage_ddata(rq_ddata->q, pdata->stage); 1bf8f90fb90c60 Yu Kuai 2024-11-27 572 1bf8f90fb90c60 Yu Kuai 2024-11-27 573 if (!bio_ddata) { 1bf8f90fb90c60 Yu Kuai 2024-11-27 574 bio_stage_start_next_stage(bstage_ddata, pos); 1bf8f90fb90c60 Yu Kuai 2024-11-27 575 goto retry; 1bf8f90fb90c60 Yu Kuai 2024-11-27 576 } 1bf8f90fb90c60 Yu Kuai 2024-11-27 577 1bf8f90fb90c60 Yu Kuai 2024-11-27 578 spin_lock_irq(&bio_ddata->lock); 1bf8f90fb90c60 Yu Kuai 2024-11-27 579 list = seq_list_start(&bio_ddata->head, pdata->count); 1bf8f90fb90c60 Yu Kuai 2024-11-27 580 if (list) 1bf8f90fb90c60 Yu Kuai 2024-11-27 581 return list; 1bf8f90fb90c60 Yu Kuai 2024-11-27 582 1bf8f90fb90c60 Yu Kuai 2024-11-27 583 spin_unlock_irq(&bio_ddata->lock); 1bf8f90fb90c60 Yu Kuai 2024-11-27 584 bio_stage_start_next_stage(bstage_ddata, pos); 1bf8f90fb90c60 Yu Kuai 2024-11-27 585 goto retry; 1bf8f90fb90c60 Yu Kuai 2024-11-27 586 } 1bf8f90fb90c60 Yu Kuai 2024-11-27 587 1bf8f90fb90c60 Yu Kuai 2024-11-27 588 if (pdata->stage == STAGE_BIO && 1bf8f90fb90c60 Yu Kuai 2024-11-27 589 __rq_hierarchy_start(rq_ddata, pdata->count)) 1bf8f90fb90c60 Yu Kuai 2024-11-27 590 return bstage_ddata; 1bf8f90fb90c60 Yu Kuai 2024-11-27 591 1bf8f90fb90c60 Yu Kuai 2024-11-27 592 return NULL; 1bf8f90fb90c60 Yu Kuai 2024-11-27 593 } 1bf8f90fb90c60 Yu Kuai 2024-11-27 594 :::::: The code at line 561 was first introduced by commit :::::: 1bf8f90fb90c600d9f372e6be4ef251cc8905f04 block-io-hierarchy: core hierarchy stats and iodump implementation :::::: TO: Yu Kuai <yukuai3(a)huawei.com> :::::: CC: Yu Kuai <yukuai3(a)huawei.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0