driver inclusion category: bugfix bugzilla: https://atomgit.com/openeuler/kernel/issues/9840 ---------------------------------------------------------------------- The current use of schedule_timeout_uninterruptible() for NRDY delays in msmon reads has significant timing inaccuracies. This is particularly problematic for control groups that aggregate data from child monitoring groups, where the delays can be amplified by tens to hundreds of times. A single read operation may experience delays of several seconds, which significantly impacts performance. To address this, replace schedule_timeout_uninterruptible() with fsleep() which uses high-resolution timers for more precise delays. Signed-off-by: Yifan Wu <wuyifan50@huawei.com> Signed-off-by: Hongye Lin <linhongye@h-partners.com> --- drivers/platform/mpam/mpam_devices.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/platform/mpam/mpam_devices.c b/drivers/platform/mpam/mpam_devices.c index e93797fbe61b..e1e8c6d2a838 100644 --- a/drivers/platform/mpam/mpam_devices.c +++ b/drivers/platform/mpam/mpam_devices.c @@ -11,6 +11,7 @@ #include <linux/cacheinfo.h> #include <linux/cpu.h> #include <linux/cpumask.h> +#include <linux/delay.h> #include <linux/device.h> #include <linux/errno.h> #include <linux/gfp.h> @@ -1248,7 +1249,6 @@ int mpam_msmon_read(struct mpam_component *comp, struct mon_cfg *ctx, enum mpam_device_features type, u64 *val) { struct mon_read arg; - u64 wait_jiffies = 0; struct mpam_props *cprops = &comp->class->props; int err = 0; @@ -1268,11 +1268,9 @@ int mpam_msmon_read(struct mpam_component *comp, struct mon_cfg *ctx, *val = 0; err = _msmon_read(comp, &arg); - if (err == -EBUSY && comp->class->nrdy_usec) - wait_jiffies = usecs_to_jiffies(comp->class->nrdy_usec); - - while (wait_jiffies) - wait_jiffies = schedule_timeout_uninterruptible(wait_jiffies); + if (err == -EBUSY && comp->class->nrdy_usec) { + fsleep(comp->class->nrdy_usec); + } if (err == -EBUSY) { arg = (struct mon_read) { -- 2.33.0