[Compass-ci] Re: [PATCH lkp-tests] lib/bootstrap.sh: fix error when os is not integrated into lkp-tests

...

...

...

@@ -240,6 +240,7 @@ run_ntpdate() has_cmd ntpdate || { detect_system local DISTRO=$_system_name_lowercase

• [ "$DISTRO" == "unknown" ] && return
  

  . $LKP_SRC/distro/installer/$DISTRO $(echo ntpdate | $LKP_SRC/sbin/adapt-packages $DISTRO) }

at this pattern : boolen || do it wish to fix the boolen is false. you fix the do, not the boolen is false.

maybe it should check in front.

About the logic:

has_cmd ntpdate || { [ current os is unknown for lkp-tests ] && return install ntpdate }

Do you mean i should add some prompt about the abnormal state?

yes ~

Good!

-------- Thanks Yu Chuan

Thanks, Dewan

...

---

Thanks Yu Chuan

...

Thanks, Dewan

...

-- 2.23.0