19 Oct
2020
19 Oct
'20
4:08 p.m.
On Mon, Oct 19, 2020 at 03:11:25PM +0800, Luan Shengde wrote:
On Mon, Oct 19, 2020 at 02:51:10PM +0800, Wu Fengguang wrote:
+def check_smtp(mail_info, mail_server)
- if [nil, 'crystal.ci'].include? mail_info['to'].split('@')[1]
That "crystal.ci" won't work in 3rd party deployment.
so how to deal with the service send mail for crystal.ci and internet email? separate them in different containers?
'crystal.ci' can be passed from local server domain name, instead of hard coded. Better split the containers. The code can reuse if possible.
Thanks, Fengguang
- intranet_smtp(mail_server)
- else
- internet_smtp
- mail_info['from'] = (ENV['EMAIL_ADDR']).to_s
- end
+end
2.23.0