On Thu, Nov 19, 2020 at 10:47:23AM +0800, Xu Xijian wrote:
On Thu, Nov 19, 2020 at 08:47:16AM +0800, Yu Chuan wrote:
[Why] The 'os', 'os_arch', 'os_version' fields to be use by test job are the same as the 'iso_os', 'iso_arch', 'iso_version' of the destination iso this time.
So delete the 'test_os', 'test_os_arch', 'test_os_version'.
Signed-off-by: Yu Chuan 13186087857@163.com
jobs/iso2rootfs.yaml | 3 --- tests/iso2rootfs | 33 +++++++-------------------------- 2 files changed, 7 insertions(+), 29 deletions(-)
diff --git a/jobs/iso2rootfs.yaml b/jobs/iso2rootfs.yaml index c81d548b49ea..fc3fc1d2e3ba 100644 --- a/jobs/iso2rootfs.yaml +++ b/jobs/iso2rootfs.yaml @@ -18,8 +18,5 @@ iso2rootfs:
# submit test yaml related fields test_yaml:
- test_os:
- test_os_arch:
- test_os_version: test_os_mount: test_testbox:
diff --git a/tests/iso2rootfs b/tests/iso2rootfs index 34c8e84d9d74..e9ed955441b3 100755 --- a/tests/iso2rootfs +++ b/tests/iso2rootfs @@ -443,17 +443,8 @@ generate_global_yaml()
generate_submit_append_str() {
- local wait_add_vars=(
"os""os_arch""os_version""os_mount""testbox"- )
- for vt in "${wait_add_vars[@]}"
- do
SUBMIT_APPEND_STR="${SUBMIT_APPEND_STR} ${vt}=$(eval echo "\$test_${vt}")"- done
- [ "$#" -eq 2 ] || die "cannot get enough submit params."
The output cannot cover the scene of when parameter number > 2. So can use "Please give 2 parameters" or so.
Good, i'll modify as follow: generate_submit_append_str: please give 2 parameters.
-------- Thanks Yu Chuan
Thanks, Xijian