19 Oct
2020
19 Oct
'20
3:10 p.m.
WAN?
world area networ email I will update it
Well you used WAN in once place and internat in another place. WAN is against LAN, but you used intranet. Please be consistent.
- 'from' => data['from'] || (ENV['DEFAULT_EMAIL']).to_s,
DEFAULT_EMAIL is what?
when sending email to crystal.ci, the DEFAULT_EMAIL is team@crystal.ci
crystal.ci is not portable.
+def check_smtp(mail_info, mail_server)
- if [nil, 'crystal.ci'].include? mail_info['to'].split('@')[1]
- intranet_smtp(mail_server)
- else
- internet_smtp
- mail_info['from'] = (ENV['EMAIL_ADDR']).to_s
EMAIL_ADDR is what?
user's email address
That's my_email?
Looks DEFAULT_EMAIL/EMAIL_ADDR naming should be improved.
Please suggest new names here.
Thanks, Fengguang