[Compass-ci] Re: [PATCH lkp-tests 2/2] feat(iso2rootfs): add step: submit rootfs test job after rootfs is made

On Wed, Oct 21, 2020 at 12:11:19PM +0800, Xu Xijian wrote:

...

############ post works ############ post_works() { @@ -414,7 +483,7 @@ post_works() local soft_link="${iso_version}-dailybuild" cd "${ROOTFS_LOCAL_PATH}" && rm -f "${soft_link}" &&

• 	ln -s "$(basename ${ROOTFS_DES_DIR})" "${soft_link}"
  

• 	ln -s "$(basename "${ROOTFS_DES_DIR}")" "${soft_link}"
  

I think this new added "" is unnecessary as there is "" outside.

"" is used for 'basename' cmd, this cmd needs there is no space of the param.

-------- Thanks Yu Chuan

Thanks, Xijian