- Dev - mailweb.openeuler.org

[PATCH] multipathd: fix mpp->hwe use after free in ev_remove_path
by lixiaokeng 12 Feb '22

12 Feb '22

When a multipath device (for example mpatha) has only one path and it can't flush because of occupation, "multipathd del path" and "multipath -v2" may lead to multipathd coredump. The reason is that mpp->hwe = pp->hwe but pp->hwe will be free later. Here we clear mpp->hwe in clear_ref_from_mpp. Signed-off-by: Lixiaokeng <lixiaokeng(a)huawei.com> --- multipathd/main.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/multipathd/main.c b/multipathd/main.c index 3e00c41..ae864ad 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -823,17 +823,23 @@ void clear_ref_from_mpp(struct path * pp, struct vectors * vecs) int j; mpp = find_mp_by_wwid(vecs->mpvec, pp->wwid); - if(!!mpp){ - condlog(2, "%s: clear path from mpp %s", pp->dev, mpp->alias); - if ((i = find_slot(mpp->paths, (void *)pp)) != -1){ - vector_del_slot(mpp->paths, i); - } - vector_foreach_slot (mpp->pg, pgp, j) { - if ((i = find_slot(pgp->paths, (void *)pp)) != -1){ - vector_del_slot(pgp->paths, i); - } + if (!mpp) { + return; + } + + condlog(2, "%s: clear path from mpp %s", pp->dev, mpp->alias); + if (mpp->hwe == pp->hwe) { + mpp->hwe = NULL; + } + if ((i = find_slot(mpp->paths, (void *)pp)) != -1) { + vector_del_slot(mpp->paths, i); + } + vector_foreach_slot(mpp->pg, pgp, j) { + if ((i = find_slot(pgp->paths, (void *)pp)) != -1) { + vector_del_slot(pgp->paths, i); } } + extract_hwe_from_path(mpp); } static int --

1 0

[PATCH] clear path in mpp->pg in clear_ref_from_mpp
by lixiaokeng 12 Feb '22

12 Feb '22

When multipathd del path xxx, multipathd -v2, multipathd add path xxx and multipath -U dm-x are executed simultaneously, multipath -U dm-x will case coredump. The reason is that there are two paths with same dev_t in dm_table. The process is as follows: multipathd del path xxx(such as sde whose dev_t is 8:64): cli_del_path ->ev_remove_path ->domap //dm_table in kernel will be reloaded and doesn't contain 8:64. //Then multipath -v2 is executed, and the dm_table in kernel //will be reloaded and contains 8:64. ->setup_multipath ->update_multipath_strings ->update_multipath_table ->dm_get_map //get params with 8:64 ->disassemble_map //pp1 will be saved mpp->pg ->delete pp1 in pathvec ->clear_ref_from_mpp //pp is cleared in mpp->paths but still saved in //mpp->pg ->free_paths //pp1 is freed but still exist in mpp->pg and is not null multipathd add path sde cli_add_path ->store_pathinfo //alloc pp2 (dev_t is 8:64), and store it to gvecs->pathvec //pp2 is not equal to pp1 ->ev_add_path ->adopt_paths ->update_mpp_paths //pp1 is found in mpp->pg and its dev_t is //8:64 and dev is not sde (cased by free). //it will be stored in mpp->paths. ->pp2 is stored to mpp->paths ->setup_map //params with two 8:64 ->domap //dm_table is reloaded and contains two 8:64 multipath -U dm-x(sde is one path of dm-x) main ->check_usable_paths ->dm_get_maps //get params with two 8:64 ->disassemble_map //alloc pp3 whose dev_t is 8:64, and pp3 is saved //twice in mpp->pg ->free_multipath(mpp, FREE_PATHS) //double free pp3 Here, we add that pp1 in mpp->pg is cleared in clear_ref_from_mpp. Reported-by: Tianxiong Lu <lutianxiong(a)huawei.com> Signed-off-by: lixiaokeng <lixiaokeng(a)huawei.com> --- multipathd/main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/multipathd/main.c b/multipathd/main.c index e80ab74..a9e7edd 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -818,7 +818,9 @@ static void clear_ref_from_mpp(struct path * pp, struct vectors * vecs) { struct multipath * mpp = NULL; + struct pathgroup * pgp; int i = -1; + int j; mpp = find_mp_by_wwid(vecs->mpvec, pp->wwid); if(!!mpp){ @@ -826,6 +828,11 @@ void clear_ref_from_mpp(struct path * pp, struct vectors * vecs) if ((i = find_slot(mpp->paths, (void *)pp)) != -1){ vector_del_slot(mpp->paths, i); } + vector_foreach_slot (mpp->pg, pgp, j) { + if ((i = find_slot(pgp->paths, (void *)pp)) != -1){ + vector_del_slot(pgp->paths, i); + } + } } } --

1 0

sig-Zephyr2022年2月会议
by openEuler conference 11 Feb '22

11 Feb '22

您好！ sig-Zephyr SIG 邀请您参加 2022-02-12 21:45 召开的ZOOM会议会议主题：sig-Zephyr2022年2月会议会议内容： 1. sig-Zephyr简介 2.Zephyr最新进展 3.sig-Zephyr2022计划 4.其他事项讨论，包括Zephyr使用上的答疑解惑会议链接：https://us06web.zoom.us/j/83557438933?pwd=bXVkTmtxNXRsS05sZWNzMnF1S3BYZz09 温馨提醒：建议接入会议后修改参会人的姓名，也可以使用您在gitee.com的ID 更多资讯尽在：https://openeuler.org/zh/ Hello! openEuler sig-Zephyr SIG invites you to attend the ZOOM conference will be held at 2022-02-12 21:45, The subject of the conference is sig-Zephyr2022年2月会议, Summary: 1. sig-Zephyr简介 2.Zephyr最新进展 3.sig-Zephyr2022计划 4.其他事项讨论，包括Zephyr使用上的答疑解惑 You can join the meeting at https://us06web.zoom.us/j/83557438933?pwd=bXVkTmtxNXRsS05sZWNzMnF1S3BYZz09. Note: You are advised to change the participant name after joining the conference or use your ID at gitee.com. More information: https://openeuler.org/en/

1 0

Re: openEuler 技术委员会例会
by Jianmin Wang 11 Feb '22

11 Feb '22

肆仔，你好， CEV 这块在社区中由安全委员会负责，可以跟 weigang@gwei3 了解情况。建议可以关注 security-committee 安全委员会的例会（会在 dev(a)openeuler.org <mailto:dev@openeuler.org> 邮件列表中通知），与委员会的成员沟通了解更多安全漏洞方面的问题。下面的链接是安全委员会之前例会的会议纪要，也可以参考。 https://etherpad.openeuler.org/p/security-committee-meetings <https://etherpad.openeuler.org/p/security-committee-meetings> ——王建民 > On 8 Feb 2022, at 5:07 PM, 肆仔 <19464572(a)qq.com> wrote: > > > 你好，我想了解下社区版本发布规则跟cve漏洞修复要求 > > 也就是我们社区计划在某个时间点发布一个版本，对这个版本内高危紧急cve漏洞的修复有要求么？比如9分以上的cve漏洞都必须已经修复。 > > 主要是这一段时间高危紧急漏洞爆发的频繁，而cve的修复特别是内核和底层库的修复，又可能影响系统的性能，导致系统性能评测这块又要重做，继而导致系统发布延迟 > 所以想了解社区这边在系统发布时对该系统版本的cve修复是如何要求的 > > 谢谢 > > ------------------ 原始邮件 ------------------ > 发件人: "王建民" <jianmin(a)iscas.ac.cn>; > 发送时间: 2022年2月8日(星期二) 下午2:41 > 收件人: "tc"<tc(a)openeuler.org>;"dev"<dev(a)openeuler.org>; > 主题: [Dev] Fwd: openEuler 技术委员会例会 > > 大家新年好， > > 春节后第一次 TC 例会将于 2022 年 2 月 16 日进行，欢迎大家回复邮件提交议题。 > > 谢谢。 > > -王建民 > > Hello, Everyone, > > Happy New Year! > > The first bi-weekly meeting of openEuler TC will be held on 2022/02/16 Wednesday. > > Welcome to submit topics by replying to the email. > > > Best Regards, > Jianmin Wang > > > Begin forwarded message: > > From: openEuler conference <public(a)openeuler.org> > Date: 8 February 2022 at 2:28:47 PM GMT+8 > Subject: [Dev] openEuler 技术委员会例会 > > 您好！ > > TC SIG 邀请您参加 2022-02-16 10:00 召开的ZOOM会议 > > 会议主题：openEuler 技术委员会例会 > > 会议链接：https://us06web.zoom.us/j/82775432385?pwd=Y2hkOGZkeklrMzJVaUVnM2dONTBxdz09 > > 温馨提醒：建议接入会议后修改参会人的姓名，也可以使用您在gitee.com的ID > > 更多资讯尽在：https://openeuler.org/zh/ > > > > > Hello! > > openEuler TC SIG invites you to attend the ZOOM conference will be held at 2022-02-16 10:00, > > The subject of the conference is openEuler 技术委员会例会, > > You can join the meeting at https://us06web.zoom.us/j/82775432385?pwd=Y2hkOGZkeklrMzJVaUVnM2dONTBxdz09. > > Note: You are advised to change the participant name after joining the conference or use your ID at gitee.com. > > More information: https://openeuler.org/en/ > > _______________________________________________ > Dev mailing list -- dev(a)openeuler.org > To unsubscribe send an email to dev-leave(a)openeuler.org > _______________________________________________ > Dev mailing list -- dev(a)openeuler.org > To unsubscribe send an email to dev-leave(a)openeuler.org

1 0

sig-zephyr2022年2月会议
by openEuler conference 11 Feb '22

11 Feb '22

您好！ sig-Zephyr SIG 邀请您参加 2022-02-13 22:00 召开的ZOOM会议会议主题：sig-zephyr2022年2月会议会议内容： 1. sig-Zephyr简介 2.Zephyr最新进展 3.sig-Zephyr2022计划 4.其他事项讨论，包括Zephyr使用上的答疑解惑会议链接：https://us06web.zoom.us/j/84575182341?pwd=ZmN1b3c4KzdoYTZEQk9yamt3OXFwZz09 温馨提醒：建议接入会议后修改参会人的姓名，也可以使用您在gitee.com的ID 更多资讯尽在：https://openeuler.org/zh/ Hello! openEuler sig-Zephyr SIG invites you to attend the ZOOM conference will be held at 2022-02-13 22:00, The subject of the conference is sig-zephyr2022年2月会议, Summary: 1. sig-Zephyr简介 2.Zephyr最新进展 3.sig-Zephyr2022计划 4.其他事项讨论，包括Zephyr使用上的答疑解惑 You can join the meeting at https://us06web.zoom.us/j/84575182341?pwd=ZmN1b3c4KzdoYTZEQk9yamt3OXFwZz09. Note: You are advised to change the participant name after joining the conference or use your ID at gitee.com. More information: https://openeuler.org/en/

1 0

SIG-Cloudnative例会
by openEuler conference 11 Feb '22

11 Feb '22

您好！ sig-CloudNative SIG 邀请您参加 2022-02-15 16:00 召开的ZOOM会议(自动录制) 会议主题：SIG-Cloudnative例会会议内容： CloudNative SIG例会，欢迎大家积极申请议题会议链接：https://us06web.zoom.us/j/88106975696?pwd=M2RKWklKZ3pwVEVVWlBIWWViRkk4UT09 温馨提醒：建议接入会议后修改参会人的姓名，也可以使用您在gitee.com的ID 更多资讯尽在：https://openeuler.org/zh/ Hello! openEuler sig-CloudNative SIG invites you to attend the ZOOM conference(auto recording) will be held at 2022-02-15 16:00, The subject of the conference is SIG-Cloudnative例会, Summary: CloudNative SIG例会，欢迎大家积极申请议题 You can join the meeting at https://us06web.zoom.us/j/88106975696?pwd=M2RKWklKZ3pwVEVVWlBIWWViRkk4UT09. Note: You are advised to change the participant name after joining the conference or use your ID at gitee.com. More information: https://openeuler.org/en/

1 0

Compiler SIG双周例会
by openEuler conference 11 Feb '22

11 Feb '22

您好！ Compiler SIG 邀请您参加 2022-02-15 10:00 召开的ZOOM会议(自动录制) 会议主题：Compiler SIG双周例会会议内容：欢迎上报议题，新增议题回复邮件即可会议链接：https://us06web.zoom.us/j/89695091580?pwd=aWZibDNCZTlxdE1ZRWp4dnRFbUFMQT09 温馨提醒：建议接入会议后修改参会人的姓名，也可以使用您在gitee.com的ID 更多资讯尽在：https://openeuler.org/zh/ Hello! openEuler Compiler SIG invites you to attend the ZOOM conference(auto recording) will be held at 2022-02-15 10:00, The subject of the conference is Compiler SIG双周例会, Summary: 欢迎上报议题，新增议题回复邮件即可 You can join the meeting at https://us06web.zoom.us/j/89695091580?pwd=aWZibDNCZTlxdE1ZRWp4dnRFbUFMQT09. Note: You are advised to change the participant name after joining the conference or use your ID at gitee.com. More information: https://openeuler.org/en/

2 1

【议题收集】//// openEuler release 双周例会
by Huangchengpiao 11 Feb '22

11 Feb '22

本周五上午openEuler release SIG例会。欢迎各位社区开发者踊跃申报议题~ -----Original Message----- From: openEuler conference [mailto:public@openeuler.org] Sent: Monday, February 7, 2022 5:23 PM Subject: [Dev] openEuler release 双周例会您好！ sig-release-management SIG 邀请您参加 2022-02-11 10:00 召开的ZOOM会议(自动录制) 会议主题：openEuler release 双周例会会议链接：https://us06web.zoom.us/j/86141460269?pwd=OEU0OEFRVjVBbGI4c20wNWlwZVJLZz09 温馨提醒：建议接入会议后修改参会人的姓名，也可以使用您在gitee.com的ID 更多资讯尽在：https://openeuler.org/zh/ Hello! openEuler sig-release-management SIG invites you to attend the ZOOM conference(auto recording) will be held at 2022-02-11 10:00, The subject of the conference is openEuler release 双周例会, You can join the meeting at https://us06web.zoom.us/j/86141460269?pwd=OEU0OEFRVjVBbGI4c20wNWlwZVJLZz09. Note: You are advised to change the participant name after joining the conference or use your ID at gitee.com. More information: https://openeuler.org/en/ _______________________________________________ Dev mailing list -- dev(a)openeuler.org To unsubscribe send an email to dev-leave(a)openeuler.org

3 4

小程序功能讨论
by openEuler conference 10 Feb '22

10 Feb '22

您好！ sig-OpenDesign SIG 邀请您参加 2022-02-11 10:00 召开的ZOOM会议会议主题：小程序功能讨论会议内容：讨论小程序新功能会议链接：https://us06web.zoom.us/j/82802085863?pwd=VDJWTTlwUGJEUEV4dXVNU2FMUmEvQT09 温馨提醒：建议接入会议后修改参会人的姓名，也可以使用您在gitee.com的ID 更多资讯尽在：https://openeuler.org/zh/ Hello! openEuler sig-OpenDesign SIG invites you to attend the ZOOM conference will be held at 2022-02-11 10:00, The subject of the conference is 小程序功能讨论, Summary: 讨论小程序新功能 You can join the meeting at https://us06web.zoom.us/j/82802085863?pwd=VDJWTTlwUGJEUEV4dXVNU2FMUmEvQT09. Note: You are advised to change the participant name after joining the conference or use your ID at gitee.com. More information: https://openeuler.org/en/

1 0

OpenStack SIG例会
by openEuler conference 10 Feb '22

10 Feb '22

您好！ sig-openstack SIG 邀请您参加 2022-02-11 15:00 召开的ZOOM会议(自动录制) 会议主题：OpenStack SIG例会会议链接：https://us06web.zoom.us/j/85222921020?pwd=Ui9Qak9KaXdYNnhHMWlPNGlsMlZOZz09 温馨提醒：建议接入会议后修改参会人的姓名，也可以使用您在gitee.com的ID 更多资讯尽在：https://openeuler.org/zh/ Hello! openEuler sig-openstack SIG invites you to attend the ZOOM conference(auto recording) will be held at 2022-02-11 15:00, The subject of the conference is OpenStack SIG例会, You can join the meeting at https://us06web.zoom.us/j/85222921020?pwd=Ui9Qak9KaXdYNnhHMWlPNGlsMlZOZz09. Note: You are advised to change the participant name after joining the conference or use your ID at gitee.com. More information: https://openeuler.org/en/

1 0